Re: [U-Boot] [PATCH 2/2] powerpc: Rework cpu_init_f() to take no arguments

2017-08-13 Thread Mario Six
On Mon, Aug 14, 2017 at 8:20 AM, Christophe LEROY wrote: > Acked-by: Christophe Leroy > > > > Le 14/08/2017 à 04:44, Tom Rini a écrit : >> >> The function cpu_init_f() is called slightly differently on different >> PowerPC platforms. In some cases the function needs to make use of the >> IMMR an

Re: [U-Boot] [PATCH 1/2] powerpc: Rework interrupt_init_cpu()

2017-08-13 Thread Mario Six
On Mon, Aug 14, 2017 at 4:44 AM, Tom Rini wrote: > The function interrupt_init_cpu() is given an int return type but does > not return anything but 0. Rework this to be a void function. > > Signed-off-by: Tom Rini > --- > arch/powerpc/cpu/mpc83xx/interrupts.c | 4 +--- > arch/powerpc/cpu/mpc85x

Re: [U-Boot] [PATCH 2/2] powerpc: Rework cpu_init_f() to take no arguments

2017-08-13 Thread Christophe LEROY
Acked-by: Christophe Leroy Le 14/08/2017 à 04:44, Tom Rini a écrit : The function cpu_init_f() is called slightly differently on different PowerPC platforms. In some cases the function needs to make use of the IMMR and in other cases it does not. Rather than pass the IMMR location as the fun

Re: [U-Boot] [PATCH 2/2] sf: Preserve QE bit when clearing BP# bits for Macronix flash

2017-08-13 Thread Bin Meng
Hi Jagan, On Mon, Aug 14, 2017 at 1:17 PM, Jagan Teki wrote: > On Mon, Aug 14, 2017 at 10:34 AM, Bin Meng wrote: >> Hi Jagan, >> >> On Mon, Aug 14, 2017 at 12:58 PM, Jagan Teki >> wrote: >>> Hi Bin, >>> >>> On Mon, Aug 14, 2017 at 8:07 AM, Bin Meng wrote: Hi Jagan, On Mon, Aug

Re: [U-Boot] [PATCH 2/2] sf: Preserve QE bit when clearing BP# bits for Macronix flash

2017-08-13 Thread Jagan Teki
On Mon, Aug 14, 2017 at 10:34 AM, Bin Meng wrote: > Hi Jagan, > > On Mon, Aug 14, 2017 at 12:58 PM, Jagan Teki wrote: >> Hi Bin, >> >> On Mon, Aug 14, 2017 at 8:07 AM, Bin Meng wrote: >>> Hi Jagan, >>> >>> On Mon, Aug 14, 2017 at 1:22 AM, Jagan Teki >>> wrote: Hi Bin, On Wed, Au

Re: [U-Boot] [PATCH 2/2] sf: Preserve QE bit when clearing BP# bits for Macronix flash

2017-08-13 Thread Bin Meng
Hi Jagan, On Mon, Aug 14, 2017 at 12:58 PM, Jagan Teki wrote: > Hi Bin, > > On Mon, Aug 14, 2017 at 8:07 AM, Bin Meng wrote: >> Hi Jagan, >> >> On Mon, Aug 14, 2017 at 1:22 AM, Jagan Teki wrote: >>> Hi Bin, >>> >>> On Wed, Aug 2, 2017 at 3:56 AM, Bin Meng wrote: Hi Jagan, On Wed

Re: [U-Boot] [PATCH 2/2] sf: Preserve QE bit when clearing BP# bits for Macronix flash

2017-08-13 Thread Jagan Teki
Hi Bin, On Mon, Aug 14, 2017 at 8:07 AM, Bin Meng wrote: > Hi Jagan, > > On Mon, Aug 14, 2017 at 1:22 AM, Jagan Teki wrote: >> Hi Bin, >> >> On Wed, Aug 2, 2017 at 3:56 AM, Bin Meng wrote: >>> Hi Jagan, >>> >>> On Wed, Aug 2, 2017 at 12:01 AM, Jagan Teki >>> wrote: On Sun, Jul 23, 2017 a

Re: [U-Boot] rk3288: 32KB SPL size restriction

2017-08-13 Thread Jagan Teki
Hi Simon, On Mon, Aug 14, 2017 at 3:06 AM, Simon Glass wrote: > Hi Jagan, > > On 10 August 2017 at 03:07, Jagan Teki wrote: >> Hi Simon/Philipp or any, >> >> I believe rk3288 has 20KB BootRom and 100KB internal SRAM and current >> u-boot can archive the maximum size of u-boot-spl-dtb.bin which t

Re: [U-Boot] [PATCH v2 4/5] arm: socfpga: Add intermediate driver between flash and FPGA manager

2017-08-13 Thread Chee, Tien Fong
On Sab, 2017-08-12 at 18:49 +0200, Marek Vasut wrote: > On 08/12/2017 10:03 AM, Chee, Tien Fong wrote: > [...] > > > > > > > > > > > > > 1: It having ability to the right memory(OCRAM or SDRAM) to > > > > achieve > > > > the > > > > best FPGA programing performance. > > > Did you find significan

Re: [U-Boot] [PATCH] Makefile: honor PYTHON configuration properly

2017-08-13 Thread Jonathan Gray
On Sun, Aug 13, 2017 at 11:04:03PM +0200, Cl??ment B??sch wrote: > --- > Makefile | 2 +- > tools/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) There is a similiar fragment in scripts/Makefile.spl with the checkdtoc target that should also be fixed. checkdtoc: tools

[U-Boot] [PATCH 1/2] powerpc: Rework interrupt_init_cpu()

2017-08-13 Thread Tom Rini
The function interrupt_init_cpu() is given an int return type but does not return anything but 0. Rework this to be a void function. Signed-off-by: Tom Rini --- arch/powerpc/cpu/mpc83xx/interrupts.c | 4 +--- arch/powerpc/cpu/mpc85xx/interrupts.c | 4 +--- arch/powerpc/cpu/mpc86xx/interrupts.c

[U-Boot] [PATCH 2/2] powerpc: Rework cpu_init_f() to take no arguments

2017-08-13 Thread Tom Rini
The function cpu_init_f() is called slightly differently on different PowerPC platforms. In some cases the function needs to make use of the IMMR and in other cases it does not. Rather than pass the IMMR location as the function argument and then ignore it on some platforms, allow the function to

Re: [U-Boot] [PATCH v2 1/1] common: Move CONFIG_BOOTARGS to Kconfig

2017-08-13 Thread Tom Rini
On Thu, Jul 27, 2017 at 06:43:44PM +0300, Sam Protsenko wrote: > Also introduce CONFIG_USE_BOOTARGS option so we can control if > CONFIG_BOOTARGS defined at all. > > Signed-off-by: Sam Protsenko > --- > Changes in v2: > - remove CONFIG_USE_BOOTARGS=y when no CONFIG_BOOTARGS defined > - fixed m

[U-Boot] [Patch v2] QE: Set QE_IRAM_READY after uploading firmware

2017-08-13 Thread Zhao Qiang
QE_IRAM_READY should be set only after successfully uploading the firmware. Signed-off-by: Zhao Qiang --- Changes for v2: - modify commit msg to make it more understandable drivers/qe/qe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/qe/qe.c b/drivers/

Re: [U-Boot] [PATCH 2/2] sf: Preserve QE bit when clearing BP# bits for Macronix flash

2017-08-13 Thread Bin Meng
Hi Jagan, On Mon, Aug 14, 2017 at 1:22 AM, Jagan Teki wrote: > Hi Bin, > > On Wed, Aug 2, 2017 at 3:56 AM, Bin Meng wrote: >> Hi Jagan, >> >> On Wed, Aug 2, 2017 at 12:01 AM, Jagan Teki wrote: >>> On Sun, Jul 23, 2017 at 8:14 PM, Bin Meng wrote: On some flash (like Macronix), QE (quad ena

Re: [U-Boot] [PATCH 2/2] sandbox: Convert SANDBOX_BITS_PER_LONG to Kconfig

2017-08-13 Thread Bin Meng
Hi Simon, On Sun, Aug 13, 2017 at 11:35 PM, Simon Glass wrote: > Hi Bin, > > On 6 August 2017 at 03:13, Bin Meng wrote: >> Hi Simon, >> >> On Sun, Aug 6, 2017 at 1:16 PM, Simon Glass wrote: >>> Hi Bin, >>> >>> On 3 August 2017 at 18:17, Bin Meng wrote: Hi Simon, On Thu, Aug 3, 2

Re: [U-Boot] [PATCH 03/12] Makefile: build FIT image if CONFIG_SPL_FIT_GENERATOR defined

2017-08-13 Thread Peng Fan
Hi Simon, > -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Monday, August 14, 2017 5:37 AM > To: Peng Fan > Cc: Stefano Babic ; Peng Fan ; U- > Boot Mailing List ; Masahiro Yamada > ; Bin Meng ; > Andre Przywara ; Cooper Jr., Franklin

Re: [U-Boot] [PATCH 07/12] scripts: spl: Disable DM MMC when SPL DM not enabled

2017-08-13 Thread Peng Fan
> -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Monday, August 14, 2017 5:37 AM > To: Peng Fan > Cc: Stefano Babic ; Peng Fan ; U- > Boot Mailing List > Subject: Re: [PATCH 07/12] scripts: spl: Disable DM MMC when SPL DM not > enabl

Re: [U-Boot] [U-Boot,8/8] x86: qemu: Enable NVMe driver

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:31:03AM -0700, Bin Meng wrote: > QEMU supports NVMe emulation. Enable the NVMe driver on QEMU x86. > > Signed-off-by: Bin Meng > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] [U-Boot, v2] wdt: Update uclass to make clear that the timeout is in ms

2017-08-13 Thread Tom Rini
On Fri, Aug 04, 2017 at 03:48:28PM -0600, Simon Glass wrote: > From: Andy Shevchenko > > Convert name to show explicitly that we are using milliseconds. For a > watchdog timer this is precise enough. > > No functional change intended. > > Signed-off-by: Andy Shevchenko > Signed-off-by: Simon

Re: [U-Boot] [U-Boot,2/3] test: Convert the FIT test to test/py

2017-08-13 Thread Tom Rini
On Sat, Aug 05, 2017 at 10:28:40AM -0600, Simon Glass wrote: > Convert this test to use the pytest framework. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing l

Re: [U-Boot] [U-Boot, 7/8] nvme: Handle zero Maximum Data Transfer Size (MDTS)

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:31:02AM -0700, Bin Meng wrote: > Maximum Data Transfer Size (MDTS) field indicates the maximum > data transfer size between the host and the controller. The > host should not submit a command that exceeds this transfer > size. The value is in units of the minimum memory

Re: [U-Boot] [U-Boot, 2/2] ARM: OMAP5: Enable support for AVS0 for OMAP5 production devices

2017-08-13 Thread Tom Rini
On Fri, Aug 04, 2017 at 09:42:09PM -0500, Nishanth Menon wrote: > OMAP5432 did go into production with AVS class0 registers which were > mutually exclusive from AVS Class 1.5 registers. > > Most OMAP5-uEVM boards use the pre-production Class1.5 which has > production efuse registers set to 0. How

Re: [U-Boot] [U-Boot,1/1] stm32: remove redundant 'else if'

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:46:05PM +0200, xypron.g...@gmx.de wrote: > The if in the else branch is superfluous. > We can use a simple if. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: Di

Re: [U-Boot] boot_fit: Change return value from FDT_ERROR to -EINVAL in fdt_offset()

2017-08-13 Thread Tom Rini
On Sat, Aug 05, 2017 at 05:47:02AM +0900, Nobuhiro Iwamatsu wrote: > FDT_ERROR is defined as unsigned long. However, since the return value of > fdt_offset() is int, a warning will occur when compiling. Also, it is better > to use -EINVAL than FDT_ERROR. > This fixes this problem by change return

Re: [U-Boot] [U-Boot, 3/3] test: Move the FIT test into the correct place

2017-08-13 Thread Tom Rini
On Sat, Aug 05, 2017 at 10:28:41AM -0600, Simon Glass wrote: > Move this test so that it will run when 'make tests' is used. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U

Re: [U-Boot] [U-Boot,1/1] arm: mvebu: remove self assignment

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 09:51:05PM +0200, xypron.g...@gmx.de wrote: > Assigning dev_num to itself is superfluous. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___

Re: [U-Boot] [U-Boot, 1/3] test: Indent test-fit.py to match the next patch

2017-08-13 Thread Tom Rini
On Sat, Aug 05, 2017 at 10:28:39AM -0600, Simon Glass wrote: > We plan to rewrite this script to use the pytest framework. To make it > easier to review the changes, indent the code to match the next patch. > This gets all of the whitespace changes out of the way. > > Signed-off-by: Simon Glass

Re: [U-Boot] [U-Boot,1/1] tpm: add missing va_end

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 09:40:37PM +0200, xypron.g...@gmx.de wrote: > va_start must always be matched by va_end. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature _

Re: [U-Boot] [U-Boot, 3/8] nvme: Add show routine to print detailed information

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:30:58AM -0700, Bin Meng wrote: > From: Zhikang Zhang > > This adds nvme_print_info() to show detailed NVMe controller and > namespace information. > > Signed-off-by: Zhikang Zhang > Signed-off-by: Wenbin Song > Signed-off-by: Bin Meng > Reviewed-by: Tom Rini Appl

Re: [U-Boot] cmd/bdinfo: correct comment in board_detail

2017-08-13 Thread Tom Rini
On Mon, Aug 07, 2017 at 04:04:14PM +1200, Chris Packham wrote: > This appears to be a simple typo that dates back to the original > implementation of board_detail in commit e79394643b26 ("common: Update > cmd_bdinfo for PPC"). > > Signed-off-by: Chris Packham Applied to u-boot/master, thanks!

Re: [U-Boot] [U-Boot, 1/1] ARM: hisilicon: hikey: do not rely on random stack value

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 09:30:55PM +0200, xypron.g...@gmx.de wrote: > If CONFIG_MMC_DW is not defined the return value of > init_dwmmc should not rely on a random stack value. > > Instead indicate that no error occured. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schu

Re: [U-Boot] test: Fix FIT test to pass again

2017-08-13 Thread Tom Rini
On Fri, Aug 04, 2017 at 04:20:16PM -0600, Simon Glass wrote: > A recent change adjusted a test string so that the test no-longer passes. > Fix it. > > Signed-off-by: Simon Glass > Reported-by: Heiko Schocher > Fixes: b28c5fcc (test-fit.py: Minor grammar/spelling/clarification tweaks) Applied t

Re: [U-Boot] [U-Boot, 1/2] ARM: OMAP5: Remove OPP_LOW Definitions for ES2.0

2017-08-13 Thread Tom Rini
On Fri, Aug 04, 2017 at 09:42:08PM -0500, Nishanth Menon wrote: > ES2.0 descopes OPP_LOW definition. So remove it from macros defined. > > Signed-off-by: Nishanth Menon > Reviewed-by: Lokesh Vutla Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___

Re: [U-Boot] [U-Boot,2/2] Convert CONFIG_OMAP3_SPI to Kconfig

2017-08-13 Thread Tom Rini
On Wed, Jul 26, 2017 at 10:25:30PM -0500, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_OMAP3_SPI > > Signed-off-by: Adam Ford > > diff --git a/configs/am335x_baltos_defconfig b/configs/am335x_baltos_defconfig > index 09e028f..aa16b25 100644 Applied to u-boot/master, t

Re: [U-Boot] [U-Boot,6/8] nvme: Fix number of blocks detection

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:31:01AM -0700, Bin Meng wrote: > From: Jon Nettleton > > NVMe should use the nsze value from the queried device. This will > reflect the total number of blocks of the device and fix detecting > my Samsung 960 EVO 256GB. > > Original: > Capacity: 40386.6 MB = 39.4 GB (

Re: [U-Boot] [U-Boot, 1/8] dm: blk: part: Add UCLASS_NVME and IF_TYPE_NVME

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:30:56AM -0700, Bin Meng wrote: > From: Zhikang Zhang > > This adds a new uclass id and block interface type for NVMe. > > Signed-off-by: Zhikang Zhang > Signed-off-by: Wenbin Song > Signed-off-by: Bin Meng > Signed-off-by: Jon Nettleton > Reviewed-by: Tom Rini A

Re: [U-Boot] [U-Boot,1/1] stm32f1: remove stm32f1 support

2017-08-13 Thread Tom Rini
On Wed, Aug 09, 2017 at 03:13:02PM +0200, Patrice Chotard wrote: > From: Patrice Chotard > > A few years ago STM32F1 SoCs support has been added : > 0144caf22ce6acd5c gpio: stm32: add stm32f1 support > 2d18ef2364fd3561a ARMv7M: add STM32F1 support > > But neither STM32F1 dedicated defconfig n

Re: [U-Boot] [U-Boot,4/8] nvme: Add nvme commands

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:30:59AM -0700, Bin Meng wrote: > From: Zhikang Zhang > > Add nvme commands in U-Boot command line. > > 1. "nvme scan" - scan NVMe blk devices > 2. "nvme list" - show all available NVMe blk devices > 3. "nvme info" - show current or a specific NVMe blk device > 4. "nvm

Re: [U-Boot] [U-Boot, 1/2] OMAP3_SPI: Kconfig: move OMAP3_SPI out of DM_SPI section.

2017-08-13 Thread Tom Rini
On Wed, Jul 26, 2017 at 10:25:29PM -0500, Adam Ford wrote: > The OMAP3_SPI driver can work with or without DM_SPI. Moving this > outside of the #if DM_SPI section allows us to include it on boards > that don't support DM_SPI yet. > > Signed-off-by: Adam Ford > > diff --git a/drivers/spi/Kconfi

Re: [U-Boot] [U-Boot, 1/1] arm: mvebu: ddr3_debug: remove self assignments

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 09:54:56PM +0200, xypron.g...@gmx.de wrote: > Remove superfluous self assignements. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature _

Re: [U-Boot] [U-Boot,2/8] nvme: Add NVM Express driver support

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:30:57AM -0700, Bin Meng wrote: > From: Zhikang Zhang > > NVM Express (NVMe) is a register level interface that allows host > software to communicate with a non-volatile memory subsystem. This > interface is optimized for enterprise and client solid state drives, > typi

Re: [U-Boot] [U-Boot, 5/8] nvme: Detect devices that are class Storage Express

2017-08-13 Thread Tom Rini
On Thu, Aug 03, 2017 at 02:31:00AM -0700, Bin Meng wrote: > From: Jon Nettleton > > This adds support to detect the catchall PCI class for NVMe devices. > It allows the drivers to work with most NVMe devices that don't need > specific detection due to quirks etc. > > Tested against a Samsung 96

Re: [U-Boot] [U-Boot,1/1] armv7m: mpu_config add missing break

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:34:20PM +0200, xypron.g...@gmx.de wrote: > For DEVICE_NON_SHARED the newly assigned value of attr > is overwritten due to a missing break. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom s

Re: [U-Boot] [U-Boot, 1/1] bcm281xx: clock: avoid possible NULL dereference

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:27:16PM +0200, xypron.g...@gmx.de wrote: > It does not make sense first to dereference c and then > to check if it is NULL. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc De

Re: [U-Boot] [U-Boot, 1/1] arm: mvebu: avoid possible NULL dereference

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:40:43PM +0200, xypron.g...@gmx.de wrote: > It does not make sense to check if info is NULL after > dereferencing it. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! --

Re: [U-Boot] [U-Boot, 1/1] arm: bcm235xx: clk_set_rate avoid possible NULL deref

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:22:47PM +0200, xypron.g...@gmx.de wrote: > It does not make sense first to dereference c and then > to check if it is NULL. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___

Re: [U-Boot] [U-Boot,1/1] api: remove superfluous assignment

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 07:54:37PM +0200, xypron.g...@gmx.de wrote: > No need to assign a value to sig if the next statement using sig > is itself an assignment of a value to sig. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom sig

Re: [U-Boot] [U-Boot, 1/1] arm: spear: do not return random value from stack

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:09:38PM +0200, xypron.g...@gmx.de wrote: > If the NOR device is not available do not return > a random value from the stack. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] [U-Boot, 1/1] arm: bcm235xx: avoid possible NULL dereference

2017-08-13 Thread Tom Rini
On Sun, Jul 30, 2017 at 08:15:51PM +0200, xypron.g...@gmx.de wrote: > It does not make sense to first dereference c and then > check if it is NULL. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature __

Re: [U-Boot] [U-Boot, RFC, 1/1] omap3: incorrect logical check in do_emif4_init

2017-08-13 Thread Tom Rini
On Sat, Apr 15, 2017 at 04:11:12PM +0200, xypron.g...@gmx.de wrote: > ((readl(&emif4_base->sdram_iodft_tlgc) & (1<<10)) == 0x01) > is always false. > This does not match the comment > /*Wait till that bit clears*/ > > The problem was indicated by cppcheck. > > I do not have the hardware to test

Re: [U-Boot] [PATCH] fs: add fs_readdir()

2017-08-13 Thread Stefan Bruens
On Sonntag, 13. August 2017 23:36:57 CEST Simon Glass wrote: > Hi Rob, > > On 10 August 2017 at 12:13, Rob Clark wrote: > > On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: > >> Hi Rob, > >> > >> On 3 August 2017 at 13:36, Rob Clark wrote: > >>> On Thu, Aug 3, 2017 at 3:10 PM, Brüns, Stefan

[U-Boot] [PATCH] Makefile: honor PYTHON configuration properly

2017-08-13 Thread Clément Bœsch
On some systems `python` is `python3` (for instance, Archlinux). The `PYTHON` variable can be used to point to `python2` to have a successful build. The use of `PYTHON` is currently limited in the Makefile and needs to be extended to at 2 other cases: First, pylibfdt is required to be a Python 2

Re: [U-Boot] [PATCH 5/6] moveconfig: Support building a simple config database

2017-08-13 Thread Simon Glass
Hi Chris, On 16 May 2017 at 00:58, Chris Packham wrote: > > > On 15/05/2017 11:47 PM, "Simon Glass" wrote: > > Add a -b option which scans all the defconfigs and builds a database of > all the CONFIG options used by each. This is useful for querying later. > > At present this only works with the

[U-Boot] [PATCH] moveconfig: Use fd.write() instead of print >>

2017-08-13 Thread Simon Glass
Adjust this code so that it can work with Python 2 and 3. Fixes: d73fcb1 (moveconfig: Support building a simple config database) Reported-by: Chris Packham Signed-off-by: Simon Glass --- lib/libfdt/pylibfdt/libfdt.i | 2 ++ tools/moveconfig.py | 6 +++--- 2 files changed, 5 insertions

Re: [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

2017-08-13 Thread Tom Rini
On Sun, Aug 13, 2017 at 05:50:39PM -0400, Rob Clark wrote: > On Sun, Aug 13, 2017 at 5:13 PM, Tom Rini wrote: > > On Sun, Aug 13, 2017 at 06:45:20AM -0400, Rob Clark wrote: > > > >> Introduce directory traversal iterators, and implement fs_readdir() > >> which is needed by EFI_LOADER. > >> > >> Th

Re: [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

2017-08-13 Thread Rob Clark
On Sun, Aug 13, 2017 at 5:13 PM, Tom Rini wrote: > On Sun, Aug 13, 2017 at 06:45:20AM -0400, Rob Clark wrote: > >> Introduce directory traversal iterators, and implement fs_readdir() >> which is needed by EFI_LOADER. >> >> The part re-working fat.c to use the directory iterators itself is >> nearl

Re: [U-Boot] [PATCH 3/5] vsprintf.c: add UTF-16 string (%ls) support

2017-08-13 Thread Simon Glass
On 9 August 2017 at 17:14, Rob Clark wrote: > This is convenient for efi_loader which deals a lot with UTF-16. Only > enabled with CC_SHORT_WCHAR, leaving room to add a UTF-32 version when > CC_SHORT_WCHAR is not enabled. > > Signed-off-by: Rob Clark > --- > examples/api/Makefile | 1 + > lib/

Re: [U-Boot] [PATCH] usb: kbd: don't fail with iomux (v3)

2017-08-13 Thread Simon Glass
Hi Rob, On 13 August 2017 at 12:07, Rob Clark wrote: > On Sun, Aug 13, 2017 at 11:35 AM, Simon Glass wrote: >> Hi Rob, >> >> On 6 August 2017 at 05:58, Rob Clark wrote: >>> >>> On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: >>> > On 4 August 2017 at 07:16, Bin Meng wrote: >>> >> Hi Rob, >

Re: [U-Boot] [PATCH 07/12] scripts: spl: Disable DM MMC when SPL DM not enabled

2017-08-13 Thread Simon Glass
Hi Peng, On 9 August 2017 at 03:16, Peng Fan wrote: > Disable DM MMC when SPL DM not enabled. > > Signed-off-by: Peng Fan > Cc: Stefano Babic > Cc: Simon Glass > --- > scripts/Makefile.uncmd_spl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/Makefile.uncmd_spl b/scripts/Make

Re: [U-Boot] [PATCH] rockchip: enable rk322x sysreset driver

2017-08-13 Thread Simon Glass
On 9 August 2017 at 05:10, Kever Yang wrote: > The sysreset driver for rk322x is ready but not enabled, > add it to Makefile to make sure it's enabled. > > Signed-off-by: Kever Yang > --- > > drivers/sysreset/Makefile | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass ___

Re: [U-Boot] [PATCH] rockchip: rk322x: enable fastboot to set boot mode tag

2017-08-13 Thread Simon Glass
On 9 August 2017 at 05:28, Kever Yang wrote: > To support fastboot "fastboot reboot-bootloader" cmd. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk322x-board.c | 15 +++ > 1 file changed, 15 insertions(+) Reviewed-by: Simon Glass _

Re: [U-Boot] [PATCH] fs: add fs_readdir()

2017-08-13 Thread Simon Glass
Hi Rob, On 10 August 2017 at 12:13, Rob Clark wrote: > On Sun, Aug 6, 2017 at 1:16 AM, Simon Glass wrote: >> Hi Rob, >> >> On 3 August 2017 at 13:36, Rob Clark wrote: >>> On Thu, Aug 3, 2017 at 3:10 PM, Brüns, Stefan >>> wrote: On Donnerstag, 3. August 2017 18:54:30 CEST Rob Clark wrote:

Re: [U-Boot] [PATCH] rockchip: dts: rk3399-evb: remove redundant gmac node

2017-08-13 Thread Simon Glass
On 9 August 2017 at 04:51, Kever Yang wrote: > There are two same gmac node, remove one. > > Signed-off-by: Kever Yang > --- > > arch/arm/dts/rk3399-evb.dts | 16 > 1 file changed, 16 deletions(-) > Reviewed-by: Simon Glass ___ U-Boo

Re: [U-Boot] [PATCH 2/3] rockchip: rk3399: enable fastboot to set boot mode tag

2017-08-13 Thread Simon Glass
On 9 August 2017 at 04:18, Kever Yang wrote: > fastboot have a command "reboot-bootloader" which require the boot > loader to reboot and get into fastboot mode again. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk3399/rk3399.c | 14 ++ > 1 file changed, 14 insertio

Re: [U-Boot] [PATCH v2 2/2] dm: test: replace dm_scan_dt() by of dm_extended_scan_fdt() in dm_do_test

2017-08-13 Thread Simon Glass
On 8 August 2017 at 06:34, wrote: > From: Patrice Chotard > > This allows to scan the DT including all "clocks" node's sub-nodes > in which fixed-clock are defined. > All fixed-clock should be defined inside a clocks node which collect all > external oscillators. Until now, all clocks sub-nodes

Re: [U-Boot] [PATCH v2 1/1] i2c: add i2c driver for stm32

2017-08-13 Thread Simon Glass
On 9 August 2017 at 06:45, wrote: > From: Patrice Chotard > > Add i2c driver which can be used on both STM32F7 and STM32H7. > This I2C block supports the following features: > _ Slave and master modes > _ Multimaster capability > _ Standard-mode (up to 100 kHz) > _ Fast-mode (up to 400 kHz)

Re: [U-Boot] [patch v2 10/13] power: pmic.h: include dm/ofnode.h

2017-08-13 Thread Simon Glass
On 9 August 2017 at 06:52, Peng Fan wrote: > Include dm/ofnode.h. > > Signed-off-by: Peng Fan > Cc: Simon Glass > Cc: Stefano Babic > --- > include/power/pmic.h | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass Please see below. > > diff --git a/include/power/pmic.h b/includ

Re: [U-Boot] [UBOOT] [PATCH] cmd: usb: ignore block devices under mass storage device

2017-08-13 Thread Simon Glass
Hi Suneel, On 10 August 2017 at 23:53, Suneel Garapati wrote: > usb tree and info commands may cause crash otherwise > > Signed-off-by: Suneel Garapati > --- > cmd/usb.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Thank you for the patch - it certainly looks like a bug. Can

Re: [U-Boot] [PATCH v4 1/1] mmc: Add MMC support for stm32h7 Socs

2017-08-13 Thread Simon Glass
On 11 August 2017 at 08:35, wrote: > From: Patrice Chotard > > This patch adds SD/MMC support for STM32H7 SoCs. > > Here is an extraction of SDMMC main features, embedded in > STM32H7 SoCs. > The SD/MMC block include the following: > _ Full compliance with MultiMediaCard System Specification >

Re: [U-Boot] [PATCH v2 4/5] spl: fit: Support both external and embedded data

2017-08-13 Thread Simon Glass
Hi York, On 7 August 2017 at 17:16, York Sun wrote: > SPL supports U-Boot image in FIT format which has data outside of > FIT structure. This adds support for embedded data for normal FIT > images. > > Signed-off-by: York Sun > > --- > > Changes in v2: > Rebase on top of "SPL: FIT: factor out sp

Re: [U-Boot] [PATCH v2] wdt: Update uclass to make clear that the timeout is in ms

2017-08-13 Thread Simon Glass
Hi Maxim, On 7 August 2017 at 11:54, Maxim Sloyko wrote: > On Fri, Aug 4, 2017 at 2:48 PM, Simon Glass wrote: >> From: Andy Shevchenko >> >> Convert name to show explicitly that we are using milliseconds. For a >> watchdog timer this is precise enough. >> >> No functional change intended. >> >>

Re: [U-Boot] [PATCH 02/12] power: pmic/regulator allow dm be omited by SPL

2017-08-13 Thread Simon Glass
On 9 August 2017 at 03:16, Peng Fan wrote: > Allow the dm driver be omited by SPL. > > Signed-off-by: Peng Fan > Cc: Jaehoon Chung > Cc: Simon Glass > Cc: Keerthy > Cc: Minkyu Kang > Cc: Stefan Agner > Cc: Hou Zhiqiang > Cc: Jacob Chen > Cc: Kever Yang > Cc: Stefano Babic > --- > driver

Re: [U-Boot] rk3288: 32KB SPL size restriction

2017-08-13 Thread Simon Glass
Hi Jagan, On 10 August 2017 at 03:07, Jagan Teki wrote: > Hi Simon/Philipp or any, > > I believe rk3288 has 20KB BootRom and 100KB internal SRAM and current > u-boot can archive the maximum size of u-boot-spl-dtb.bin which the > boot ROM will read is 32KB, do we have any possibility to increase t

Re: [U-Boot] [PATCH 2/5] lib: add some utf16 handling helpers

2017-08-13 Thread Simon Glass
Hi Rob, On 9 August 2017 at 17:14, Rob Clark wrote: > We'll eventually want these in a few places in efi_loader, and also > vsprintf. > > Signed-off-by: Rob Clark > --- > include/charset.h| 55 ++ > lib/Makefile | 1 + > lib/charset.c

Re: [U-Boot] [U-Boot, v4, 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the RK3368

2017-08-13 Thread Simon Glass
+Philipp On 9 August 2017 at 15:45, Masahiro Yamada wrote: > Hi. > > > 2017-08-07 23:05 GMT+09:00 Tom Rini : >> On Mon, Aug 07, 2017 at 10:48:12AM +0200, Dr. Philipp Tomsich wrote: >>> +Tom >>> >>> Ok, so the problem is 'scripts/setlocalversion’, which does the following: >>> > if test -e include

Re: [U-Boot] [PATCH 1/3] apalis_t30: describe pcie ports

2017-08-13 Thread Simon Glass
On 8 August 2017 at 06:43, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Add some more comments describing the various PCIe ports available. > > Signed-off-by: Marcel Ziswiler > --- > > arch/arm/dts/tegra30-apalis.dts | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Simon Glass __

Re: [U-Boot] [PATCH v2] dm: core: also parse chosen node

2017-08-13 Thread Simon Glass
Hi Rob, On 7 August 2017 at 13:55, Rob Clark wrote: > This is the node that would contain, for example, the framebuffer setup > by an earlier stage. > > Signed-off-by: Rob Clark > --- > v2: simplify a bit (and fix incorrect handling of pre_reloc_only) by > calling dm_scan_fdt_node() recursiv

Re: [U-Boot] [PATCH v2 3/6] power: as3722: fix ldo_get/set_enable for ldo index bigger than 7

2017-08-13 Thread Simon Glass
On 8 August 2017 at 06:42, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Fix ldo_get_enable() and ldo_set_enable() functions for LDOs with an > index > 7. Turns out there are actually two separate AS3722_LDO_CONTROL > registers AS3722_LDO_CONTROL0 and AS3722_LDO_CONTROL1. Actually make use >

Re: [U-Boot] [PATCH 3/3] rockchip: rk3399: enable preboot for boot mode detect

2017-08-13 Thread Simon Glass
On 9 August 2017 at 04:18, Kever Yang wrote: > We need to get into preboot once we detect that we are not > get into normal boot. > > Signed-off-by: Kever Yang > --- > > include/configs/rk3399_common.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass _

Re: [U-Boot] [PATCH v2 3/5] spl: fit: Eanble GZIP support for image decompression

2017-08-13 Thread Simon Glass
Hi York, On 7 August 2017 at 17:16, York Sun wrote: > Add Kconfig option SPL_GZIP and SPL_ZLIB to enable gunzip support for > SPL boot, eg. falcon boot compressed kernel image. > > Signed-off-by: York Sun > > --- > > Changes in v2: > Combine Kconfig change and actual code into one patch > > com

Re: [U-Boot] [PATCH 1/3] rockchip: rk3399: detect boot mode

2017-08-13 Thread Simon Glass
On 9 August 2017 at 04:18, Kever Yang wrote: > U-Boot fastboot, kernel may reboot with parameter which require > bootloader to get into different boot mode, detect it and enter > proper mode. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk3399/Kconfig | 1 + > arch/arm/mach-r

Re: [U-Boot] [PATCH] common:usb_kbd:Add key values of F1~F12

2017-08-13 Thread Simon Glass
Hi, On 9 August 2017 at 04:33, Dr. Philipp Tomsich wrote: > >> On 08 Aug 2017, at 03:27, Leo Wen wrote: >> >> When you press the F1~F12 button from the USB keyboard, the reference Fn >> key table(usb_kbd_fn_key[]),the key value(0xf0~0xfb) will be returned, >> and you can use it to do more things

Re: [U-Boot] [PATCH 2/3] ARM: dts: rockchip: add USB nodes for evb-rv1108

2017-08-13 Thread Simon Glass
On 8 August 2017 at 21:36, William Wu wrote: > This patch adds USB OTG/EHCI/OHCI nodes for evb-rv1108 USB ports. > > Signed-off-by: William Wu > --- > arch/arm/dts/rv1108-evb.dts | 22 ++ > arch/arm/dts/rv1108.dtsi| 24 > 2 files changed, 46 inser

Re: [U-Boot] [PATCH 1/3] dm: Add migration plan for CONFIG_BLK

2017-08-13 Thread Simon Glass
Hi Tom, On 7 August 2017 at 09:39, Tom Rini wrote: > On Sat, Aug 05, 2017 at 03:45:53PM -0600, Simon Glass wrote: > >> The CONFIG_BLK conversion involves quite invasive changes in the U-Boot >> code, with #ifdefs and different code paths. We should try to move over to >> this soon so we can drop

Re: [U-Boot] [RFC PATCH v1 1/2] ARM: mvebu: Add SoC IDs for Marvell's integrated CPUs

2017-08-13 Thread Simon Glass
On 9 August 2017 at 02:23, Chris Packham wrote: > These SoCs are network packet processors (switch chips) with integrated > ARMv7 cores. They share a great deal of commonality with the Armada-XP > CPUs. > > Signed-off-by: Chris Packham > --- > There are actually a number of IDs for these chips, p

Re: [U-Boot] [PATCH 03/12] Makefile: build FIT image if CONFIG_SPL_FIT_GENERATOR defined

2017-08-13 Thread Simon Glass
Hi, On 9 August 2017 at 03:16, Peng Fan wrote: > Build FIT image if CONFIG_SPL_FIT_GENERATOR defined. > > Signed-off-by: Peng Fan > Cc: Simon Glass > Cc: Masahiro Yamada > Cc: Bin Meng > Cc: Andre Przywara > Cc: "Cooper Jr., Franklin" > Cc: "Álvaro Fernández Rojas" > Cc: Stefano Babic > -

Re: [U-Boot] [PATCH 3/3] rockchip: evb-rv1108: add usb init function for dwc2 gadget

2017-08-13 Thread Simon Glass
On 8 August 2017 at 21:36, William Wu wrote: > This patch implements board_usb_init() for dwc2 gadget, it > generally called from do_fastboot to do dwc2 udc probe and > support fastboot over USB. > > Signed-off-by: William Wu > --- > board/rockchip/evb_rv1108/evb_rv1108.c | 47 > +++

Re: [U-Boot] [PATCH 1/3] configs: rockchip: add USB configs for evb-rv1108 board

2017-08-13 Thread Simon Glass
On 8 August 2017 at 21:36, William Wu wrote: > This patch adds USB configs to support the USB OTG port(consist > of DWC2 controller) and the USB Host port(consist of EHCI and OHCI > controllers) on evb-rv1108 board, and also support fastboot over > USB and USB mass storage. > > Signed-off-by: Will

Re: [U-Boot] [PATCH v2 1/2] dm: core: add clocks node scan

2017-08-13 Thread Simon Glass
+Rob Clark who is doing a similar thing with the /chosen node Hi Patrice, On 8 August 2017 at 06:34, wrote: > From: Patrice Chotard > > Currently, all fixed-clock declared in "clocks" node in device tree > can be binded by clk_fixed_rate.c driver only if each of them have > the "simple-bus" co

Re: [U-Boot] [PATCH 09/51] phy: Support Marvell 88X2242

2017-08-13 Thread Simon Glass
Hi Joe, On 7 August 2017 at 10:37, Joe Hershberger wrote: > On Sun, Aug 6, 2017 at 12:16 AM, Simon Glass wrote: >> Hi Joe, >> >> On 27 July 2017 at 15:23, Joe Hershberger wrote: >>> On Tue, Jul 25, 2017 at 3:22 AM, Mario Six wrote: Hi Simon, On Tue, Jul 18, 2017 at 4:01 PM, Simo

Re: [U-Boot] [PATCH v4 8/9] spl: dm: Make it possible for the SPL to pick its own DTB from a FIT

2017-08-13 Thread Simon Glass
Hi Jean-Jacques, On 7 August 2017 at 04:07, Jean-Jacques Hiblot wrote: > u-boot can be embedded within a FIT image with multiple DTBs. It then > selects at run-time which one is best suited for the platform. > Use the same principle here for the SPL: put the DTBs in a FIT image, > compress it (L

Re: [U-Boot] [PATCH v4 1/9] dts: renamed FIT_EMBED to MULTI_DTB_FIT and moved it to the dts Kconfig

2017-08-13 Thread Simon Glass
On 7 August 2017 at 04:07, Jean-Jacques Hiblot wrote: > CONFIG_FIT_EMBED might be confused with CONFIG_OF_EMBED, rename it > MULTI_DTB_FIT as it is able to get a DTB from a FIT image containing > multiple DTBs. Also move the option to the Kconfig dedicated to the DTS > options and create a README

Re: [U-Boot] [PATCH] Convert CONFIG_BCH to Kconfig

2017-08-13 Thread Tom Rini
On Fri, Aug 11, 2017 at 09:46:05AM -0500, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_BCH > > Signed-off-by: Adam Ford The diffstat will get reworked once more options are moved to Kconfig and e.g. CONFIG_NAND_OMAP_ELM will select BCH. Reviewed-by: Tom Rini -- Tom

Re: [U-Boot] [PATCH] Makefile: honor PYTHON configuration properly

2017-08-13 Thread Tom Rini
On Sun, Aug 13, 2017 at 11:04:03PM +0200, Clément Bœsch wrote: > --- > Makefile | 2 +- > tools/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 50a002e72f..1f70144e0a 100644 > --- a/Makefile > +++ b/Makefile > @@ -1378,7 +137

Re: [U-Boot] [PATCH v2] arm: dts: am33xx: sync DTS with Linux 4.13-rc4

2017-08-13 Thread Tom Rini
On Sat, Aug 12, 2017 at 01:26:38PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > This re-syncs AM33xx DTS file with current file from > Linux v4.13-rc4 to ensure a consistent configuration. Upstream > Linux removed the redundant Interrupt-parent property from mmc, > mac, lcdc and

Re: [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

2017-08-13 Thread Tom Rini
On Sun, Aug 13, 2017 at 06:45:20AM -0400, Rob Clark wrote: > Introduce directory traversal iterators, and implement fs_readdir() > which is needed by EFI_LOADER. > > The part re-working fat.c to use the directory iterators itself is > nearly a 2:1 negative diffstat, and a pretty big cleanup. I f

[U-Boot] [PATCH] Makefile: honor PYTHON configuration properly

2017-08-13 Thread Clément Bœsch
--- Makefile | 2 +- tools/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 50a002e72f..1f70144e0a 100644 --- a/Makefile +++ b/Makefile @@ -1378,7 +1378,7 @@ $(timestamp_h): $(srctree)/Makefile FORCE $(call filechk,timestamp.h)

[U-Boot] Test Environment

2017-08-13 Thread Duncan Hare
1. Try to build the u-boot test environment with the command: ./test/py/test.py --bd sandbox --build Get the error ../include/image.h:1019:27: fatal error: openssl/evp.h: No such file or directory # include   2. Does the Sandbox support the dhcp, tftp and nfs commands so they can go over the net

Re: [U-Boot] [PATCH v3 3/3] efi_loader: implement OpenProtocolInformation

2017-08-13 Thread Alexander Graf
On 13.08.17 21:32, Heinrich Schuchardt wrote: On 08/13/2017 09:24 PM, Alexander Graf wrote: On 13.08.17 13:17, Heinrich Schuchardt wrote: On 08/12/2017 03:38 PM, Alexander Graf wrote: On 05.08.17 22:32, Heinrich Schuchardt wrote: efi_open_protocol_information provides the agent and cont

  1   2   >