Re: [U-Boot] Get Phy device ID for non standard phy

2018-08-02 Thread Pankaj Bansal
Hi Priyanka, Yes this patch takes care of cortina phy id. The problem arises, when we have two or more phys in one system that implement the phy ID at two different non-standard location. Like we have in our upcoming boards LX2160AQDS/LX2160ARDB : inphi phy and cortina phy. In which file we sho

[U-Boot] [PATCH v2 2/2] sandbox: Enable bitrev library build

2018-08-02 Thread Bin Meng
Imply CONFIG_BITREVERSE for Sandbox. Signed-off-by: Bin Meng --- Changes in v2: - Change to imply in the Kconfig arch/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/Kconfig b/arch/Kconfig index bf1b4a9..11900b0 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -78,6 +78,7 @@ c

[U-Boot] [PATCH v2 1/2] lib: bitrev: Sync with Linux kernel v4.17

2018-08-02 Thread Bin Meng
Signed-off-by: Bin Meng Reviewed-by: Simon Glass --- Changes in v2: None include/linux/bitrev.h | 102 - lib/bitrev.c | 28 +- 2 files changed, 102 insertions(+), 28 deletions(-) diff --git a/include/linux/bitrev.h b/inclu

Re: [U-Boot] Get Phy device ID for non standard phy

2018-08-02 Thread Priyanka Jain
Hello Pankaj, The requirement of LX2160ARD, LX2160AQDS has been taken care by the patch http://patchwork.ozlabs.org/patch/867403/ in upstream u-boot. Regards Priyanka From: Pankaj Bansal Sent: Friday, August 3, 2018 12:09 PM To: joe.hershber...@ni.com; u-boot Cc: Varun Sethi ; Priyanka Jain S

[U-Boot] Get Phy device ID for non standard phy

2018-08-02 Thread Pankaj Bansal
Hi All, I have a query about phy devices that implement phy identification registers at non-standard locations. The IEEE 802.3 specifies these registers as phy ID registers: 22.2.4.3.1 PHY Identifier (Registers 2 and 3) Registers 2 and 3 provide a 32-bit value, which shall constitute a unique i

Re: [U-Boot] [PATCH v1 14/17] cmd: fpga: Add support for missing fpga loadmk commands

2018-08-02 Thread Michal Simek
On 2.8.2018 22:37, Simon Glass wrote: > On 26 July 2018 at 08:16, Michal Simek wrote: >> Not all 4 fpga loadmk FIT image commands > > I don't understand this. Can you explain what you mean? hm not sure why I have written this short commit message. Maybe I wanted to extend it later when I was doi

Re: [U-Boot] [PATCH 0/2] Ethernet name length changes

2018-08-02 Thread Pankaj Bansal
> -Original Message- > From: Joe Hershberger [mailto:joe.hershber...@ni.com] > Sent: Thursday, August 2, 2018 10:15 PM > To: Pankaj Bansal > Cc: u-boot ; Joe Hershberger > ; Varun Sethi > Subject: Re: [U-Boot] [PATCH 0/2] Ethernet name length changes > > On Thu, Aug 2, 2018 at 6:01 AM,

Re: [U-Boot] [PATCH] stm32f7: board: Fix memory init

2018-08-02 Thread Vikas Manocha
Hi Patrice, On 08/02/2018 05:18 AM, Patrice Chotard wrote: > Commit 1473b12ad0b3 ("lib: fdtdec: Update ram_base to store ram start > adddress") brings regression on STM32F7 which can't boot. > > Use fdtdec_setup_mem_size_base() to setup memory base and size. > Use fdtdec_setup_memory_banksize() t

Re: [U-Boot] [PATCH v2 15/21] sandbox: Update test.dts for dynamic PCI device driver matching

2018-08-02 Thread Bin Meng
Hi Simon, On Fri, Aug 3, 2018 at 4:38 AM, Simon Glass wrote: > Hi Bin, > > On 29 July 2018 at 07:37, Bin Meng wrote: >> Signed-off-by: Bin Meng >> --- >> >> Changes in v2: None >> >> arch/sandbox/dts/test.dts | 16 ++-- >> 1 file changed, 2 insertions(+), 14 deletions(-) > > But do

Re: [U-Boot] [PATCH v2 10/21] test: dm: pci: Add tests for configuration space access

2018-08-02 Thread Bin Meng
Hi Simon, On Fri, Aug 3, 2018 at 4:38 AM, Simon Glass wrote: > Hi Bin, > > On 29 July 2018 at 07:37, Bin Meng wrote: >> So far we missed the testing for PCI configuration space access. > > You are also removing some asserts, but I suppose they are rendundant. > Correct. >> >> Signed-off-by: Bi

Re: [U-Boot] [PATCH] FSL PCI: Configure PCIe reference ratio

2018-08-02 Thread York Sun
On 08/02/2018 03:38 PM, Joakim Tjernlund wrote: > York, did this go anywhere? No, I didn't hear from Mingkai. I am OK with this patch and will merge it. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] FSL PCI: Configure PCIe reference ratio

2018-08-02 Thread Joakim Tjernlund
York, did this go anywhere? Jocke On Tue, 2018-02-27 at 19:54 +, York Sun wrote: > > On 02/27/2018 11:52 AM, Joakim Tjernlund wrote: > > On Tue, 2018-02-27 at 19:30 +, York Sun wrote: > > > > > > On 11/21/2017 10:20 AM, Joakim Tjernlund wrote: > > > > On Tue, 2017-11-21 at 18:04 +,

Re: [U-Boot] 2018.09-rc1 breakage on orangepi pc2

2018-08-02 Thread Mark Kettenis
> Date: Thu, 2 Aug 2018 22:55:23 +0200 (CEST) > From: Mark Kettenis > > I can no longer boot OpenBSD on the orangepi pc2. The kernel faults > somewhere in the EFI detection code, almost certainly where it looks > through the configuration table entries looking for the ACPI table. > I've bisected

Re: [U-Boot] [PATCH 1/9] dm: allow 4GB of DRAM on 32bit systems

2018-08-02 Thread Dr. Philipp Tomsich
> On 2 Aug 2018, at 22:36, Simon Glass wrote: > > On 26 July 2018 at 07:59, Philipp Tomsich > > wrote: >> Even on 32bit systems a full 4GB of DRAM may be installed and reported >> by the DRAM controller. Whether these 4GB are larger available >> de

[U-Boot] Questions about loading U-Boot from ATF

2018-08-02 Thread York Sun
Tom, Can you help me (or point me to the proper persons) to understand the long term flow of booting ARMv8 U-Boot with ATF? We are trying to make changes. As you may know, we have been booting U-Boot for NXP ARMv8 platforms from EL3 and drop to EL2 with an in-house ATF-compatible monitor. I have s

[U-Boot] 2018.09-rc1 breakage on orangepi pc2

2018-08-02 Thread Mark Kettenis
I can no longer boot OpenBSD on the orangepi pc2. The kernel faults somewhere in the EFI detection code, almost certainly where it looks through the configuration table entries looking for the ACPI table. I've bisected this resulting in: 4182a129ef735bfd6c54788affe1b649ab85b851 is the first bad

Re: [U-Boot] [PATCH v2 10/21] test: dm: pci: Add tests for configuration space access

2018-08-02 Thread Simon Glass
Hi Bin, On 29 July 2018 at 07:37, Bin Meng wrote: > So far we missed the testing for PCI configuration space access. You are also removing some asserts, but I suppose they are rendundant. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > test/dm/pci.c | 24 +++-

Re: [U-Boot] [PATCH v2 14/21] pci: sandbox: swap_case: Declare dynamic driver matching

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:37, Bin Meng wrote: > This adds a U_BOOT_PCI_DEVICE() declaration to the swap_case driver. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > arch/sandbox/include/asm/test.h | 4 > drivers/misc/swap_case.c| 7 +++ > 2 files changed, 11 insertions

Re: [U-Boot] [PATCH v1 16/17] cmd: fpga: Fix loads command

2018-08-02 Thread Simon Glass
On 26 July 2018 at 08:16, Michal Simek wrote: > Convert last loads command to fpga subcommands. > > Signed-off-by: Michal Simek > --- > > Changes in v1: None > > cmd/fpga.c | 148 > +++-- > 1 file changed, 36 insertions(+), 112 deletions(-

Re: [U-Boot] [PATCH v2 09/21] test: dm: pci: Test more than one PCI host controller

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:37, Bin Meng wrote: > So far there is only one PCI host controller in the sandbox test > configuration. This is normally the case for x86, but it can be > common on other architectures like ARM/PPC to have more than one > PCI host controller in the system. > > This updates th

Re: [U-Boot] [PATCH v1 13/17] cmd: fpga: Fix loadmk command

2018-08-02 Thread Simon Glass
On 26 July 2018 at 08:16, Michal Simek wrote: > Convert loadmk command to fpga subcommands. Not all combinations are > working but they have never worked properly. This will be fixed later. > > Signed-off-by: Michal Simek > --- > > Changes in v1: None > > cmd/fpga.c | 238 >

Re: [U-Boot] [PATCH v2 04/21] dm: pci: Extract vendor/device id in child_post_bind()

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:36, Bin Meng wrote: > Currently only devfn is extracted in child_post_bind(). Now that > we have the live-tree version API to look up PCI vendor and device > id from the compatible string, let's extract and save them too. > > Signed-off-by: Bin Meng > --- > > Changes in v2:

Re: [U-Boot] [PATCH v2 21/21] test: dm: pci: Add cases for finding PCI capability APIs

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:37, Bin Meng wrote: > Add several PCI capability and extended capability ID registers > in the swap_case driver, so that we can add test case for > dm_pci_find_capability() and dm_pci_find_ext_capability(). > > Signed-off-by: Bin Meng > > --- > > Changes in v2: None > > arc

Re: [U-Boot] [PATCH v2 02/21] dm: Correct typos in uclass_first/next_device_check()

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:36, Bin Meng wrote: > Correct typos in the comment block of uclass_first/next_device_check(). > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > include/dm/uclass.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass ___

Re: [U-Boot] [PATCH v1 14/17] cmd: fpga: Add support for missing fpga loadmk commands

2018-08-02 Thread Simon Glass
On 26 July 2018 at 08:16, Michal Simek wrote: > Not all 4 fpga loadmk FIT image commands I don't understand this. Can you explain what you mean? > > Signed-off-by: Michal Simek > - New patch from RFC > > --- > > Changes in v1: None > - Simon ___ U-Bo

Re: [U-Boot] [PATCH v2 07/21] test: dm: pci: Test more than one device on the same bus

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:36, Bin Meng wrote: > It's quite common to have more than one device on the same PCI bus. > This updates the test case to test such scenario. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > arch/sandbox/dts/test.dts | 7 +++ > test/dm/pci.c |

Re: [U-Boot] [PATCH v2 16/21] test: dm: pci: Test driver binding with driver data provided

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:37, Bin Meng wrote: > With struct pci_device_id, it's possible to pass a driver data for > bound driver to use. This adds a test case for this functionality. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > test/dm/pci.c | 17 + > 1 file changed

Re: [U-Boot] [PATCH 4/9] MIPS: use PRIx64 macros for printing ram size

2018-08-02 Thread Simon Glass
On 26 July 2018 at 07:59, Philipp Tomsich wrote: > With the recent changes of the underlying types for the ram size, we need > to adjust the formatting. Use PRIx64 to print the (now) u64 field. > > Signed-off-by: Philipp Tomsich > --- > > arch/mips/mach-bmips/dram.c | 2 +- > 1 file changed, 1

Re: [U-Boot] [PATCH v2 06/21] test: dm: pci: Remove unnecessary steps in dm_test_pci_swapcase()

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:36, Bin Meng wrote: > The check on uclass_get_device() and device_active() is unnecessary > as the follow-up test operations will implicitly probe the driver. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > test/dm/pci.c | 4 +--- > 1 file changed, 1 insertion

Re: [U-Boot] [PATCH v1 01/17] cmd: fpga: Remove fit image support passed without fpga device

2018-08-02 Thread Simon Glass
On 26 July 2018 at 08:16, Michal Simek wrote: > The patch applied in 2010 > "cmd_fpga: cleanup help and check parameters" > (sha1: a790b5b2326be9d7c9ad9e3d9b51a8bfabc62d07" > was adding this checking > > + if (dev == FPGA_INVALID_DEVICE) { > + puts("FPGA device not specified\n"

Re: [U-Boot] [PATCH 8/9] board: cm_fx6: use PRIx64 macros for printing ram size

2018-08-02 Thread Simon Glass
On 30 July 2018 at 19:42, Masahiro Yamada wrote: > 2018-07-26 22:59 GMT+09:00 Philipp Tomsich > : >> With the recent changes of the underlying types for the ram size, we >> need to adjust the formatting. Use PRIx64 to print the (now) u64 >> field. >> >> Signed-off-by: Philipp Tomsich >> --- > >

Re: [U-Boot] [PATCH v2 17/21] pci: sandbox: emul: Rename priv structure

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:37, Bin Meng wrote: > We have "struct sandbox_pci_priv" in pci_sandbox driver. To avoid > confusion, rename the emul's priv to "struct sandbox_pci_emul_priv". > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > drivers/pci/pci-emul-uclass.c | 8 > 1 file

Re: [U-Boot] [PATCH v2 13/21] pci: sandbox: Support dynamically binding device driver

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:37, Bin Meng wrote: > At present all emulated sandbox pci devices must be present in the > device tree in order to be used. The real world pci uclass driver > supports pci device driver matching, and we should add such support > on sandbox too. > > Signed-off-by: Bin Meng >

Re: [U-Boot] [PATCH 1/9] dm: allow 4GB of DRAM on 32bit systems

2018-08-02 Thread Simon Glass
On 26 July 2018 at 07:59, Philipp Tomsich wrote: > Even on 32bit systems a full 4GB of DRAM may be installed and reported > by the DRAM controller. Whether these 4GB are larger available > depends on the size/configuration of address decoding windows and > architectural features (e.g. consider a

Re: [U-Boot] [PATCH v2 11/21] pci: sandbox: emul: Fix the call to pci_bus_find_devfn()

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:37, Bin Meng wrote: > With the newly added test cases for PCI configuration access, we get: > > => ut dm pci_busdev > Test: dm_test_pci_busdev: pci.c > test/dm/pci.c:49, dm_test_pci_busdev(): SANDBOX_PCI_VENDOR_ID == vendor: > Expected 4660, got 65535 > Test: dm_tes

Re: [U-Boot] [PATCH v2 01/21] pci: Remove 440ep specific macros

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:36, Bin Meng wrote: > These macros should not be put in the generic pci.h header file. > Since they are not referenced anywhere, remove them completely. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > include/pci.h | 15 --- > 1 file changed, 15 de

Re: [U-Boot] [PATCH v2 08/21] pci: sandbox: swap_case: Preserve space indicator bit in BAR registers

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:36, Bin Meng wrote: > With the newly added testing of more than one device, we get: > > => ut dm pci_swapcase > Test: dm_test_pci_swapcase: pci.c > test/dm/pci.c:88, dm_test_pci_swapcase(): "tHIS IS A tESt" = ptr: > Expected "tHIS IS A tESt", got "this is a test" >

Re: [U-Boot] [PATCH v2 03/21] dm: core: Add ofnode function to read PCI vendor and device id

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:36, Bin Meng wrote: > We don't have the live-tree version of fdtdec_get_pci_vendev(). > This adds the API. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > drivers/core/ofnode.c | 36 > include/dm/ofnode.h | 13 +++

Re: [U-Boot] [PATCH v1 12/17] cmd: fpga: Fix loadfs command

2018-08-02 Thread Simon Glass
On 26 July 2018 at 08:16, Michal Simek wrote: > Convert loadfs command to fpga subcommands. > > Signed-off-by: Michal Simek > --- > > Changes in v1: None > > cmd/fpga.c | 58 -- > 1 file changed, 28 insertions(+), 30 deletions(-) Reviewed-

Re: [U-Boot] [PATCH v2 05/21] dm: pci: Fix scanning multi-function device

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:36, Bin Meng wrote: > The flag to control whether to scan multi-function device during > enumeration should be cleared at the beginning of each iteration > if the device's function number equals to zero. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > drivers/

Re: [U-Boot] [PATCH v2 20/21] dm: pci: Add APIs to find capability and extended capability

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:37, Bin Meng wrote: > This introduces two new APIs dm_pci_find_capability() and > dm_pci_find_ext_capability() to get PCI capability address and > PCI express extended capability address for a given PCI device. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - Mask

Re: [U-Boot] [PATCH 5/9] rockchip: rk3368: change type of ram-size field for a min()-calculation

2018-08-02 Thread Simon Glass
Hi Phiipp, On 26 July 2018 at 07:59, Philipp Tomsich wrote: > With the recent changes of the underlying types for the ram size, we need > to cast the constant used in clamping to u64 instead of size_t. > > Signed-off-by: Philipp Tomsich > --- > > drivers/ram/rockchip/dmc-rk3368.c | 2 +- > 1 fi

Re: [U-Boot] [PATCH v2 18/21] test: dm: pci: Add tests for mixed static and dynamic devices on the same bus

2018-08-02 Thread Simon Glass
On 29 July 2018 at 07:37, Bin Meng wrote: > In the Sandbox test configuration, PCI bus#0 only has static devices > while bus#1 only has dynamic devices. Create a bus#2 that has both > types of devices and test such. > > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > arch/sandbox/dts/t

Re: [U-Boot] [PATCH 7/9] board: keymile: add explicit cast to truncate the 64bit ram size field

2018-08-02 Thread Simon Glass
On 26 July 2018 at 07:59, Philipp Tomsich wrote: > With the change to a 64bit ram size field for 32bit architectures, we need > to add an explicit cast to truncate when converting to a pointer. > This casts to 'void*' through 'uintptr_t'. > > Signed-off-by: Philipp Tomsich > --- > > board/keymil

Re: [U-Boot] [PATCH v2 15/21] sandbox: Update test.dts for dynamic PCI device driver matching

2018-08-02 Thread Simon Glass
Hi Bin, On 29 July 2018 at 07:37, Bin Meng wrote: > Signed-off-by: Bin Meng > --- > > Changes in v2: None > > arch/sandbox/dts/test.dts | 16 ++-- > 1 file changed, 2 insertions(+), 14 deletions(-) But doesn't this mean we lose testing of the device-tree config? We need to keep tha

Re: [U-Boot] [PATCH u-boot 2/2] clk: clk_meson: Add mux and div support for reparent and rate setting

2018-08-02 Thread Simon Glass
On 26 July 2018 at 07:54, Neil Armstrong wrote: > This patch adds support for : > - Rate calculation through muxes and generic dividers > - Basic gate setting propagation > - Reparenting for muxes > - Clock rate setting through generic dividers without reparenting > > Support is only added to the

Re: [U-Boot] [PATCH u-boot 1/2] power: domain: Add the VPU Power Domain driver

2018-08-02 Thread Simon Glass
Hi Neil, On 26 July 2018 at 07:54, Neil Armstrong wrote: > The Amlogic Meson SoCs embeds a specific Power Domain dedicated to the > Video Processing Unit. > This patch implements support for this power domain in preparation of the > future support for the Video display support in U-Boot. > > This

Re: [U-Boot] [PATCH] Revert "efi_loader: efi_allocate_pages is too restrictive"

2018-08-02 Thread Simon Glass
On 2 August 2018 at 11:45, Stephen Warren wrote: > From: Stephen Warren > > This reverts commit aa909462d01866354f4cd4534db5f571c2cf1fbb. This change > caused "dhcp filename" to crash the system on p2371-2180 (Jetson TX1), for > example when running test/py. > > Reverting this change isn't optima

Re: [U-Boot] U-Boot: Verified Boot: signed configuration and mix and match attack

2018-08-02 Thread Simon Glass
Hi Johann, On 2 August 2018 at 07:20, Johann Neuhauser wrote: > Hello Simon, > >> > Dear U-Boot devs, >> > >> > I've setup verified boot on a imx6 board and want to protect my device >> against the "mix and match" attacks mentioned in >> "doc/uImage.FIT/signature.txt". >> > That's why I have only

[U-Boot] Talos Security Advisory (TALOS-2018-0633/CVE-2018-3968 )

2018-08-02 Thread Regina Wilson (regiwils)
Hello, Cisco Talos team discovered a security issue impacting Cujo product using an outdated version of U-boot. We’ve assigned a CVE for this issue (CVE-2018-3968) and have attached a copy of the security advisory provided to Cujo. <> ___ U-Boot mail

[U-Boot] [PATCH] Revert "efi_loader: efi_allocate_pages is too restrictive"

2018-08-02 Thread Stephen Warren
From: Stephen Warren This reverts commit aa909462d01866354f4cd4534db5f571c2cf1fbb. This change caused "dhcp filename" to crash the system on p2371-2180 (Jetson TX1), for example when running test/py. Reverting this change isn't optimal, but at least restores TX1 to a working state. In the future

Re: [U-Boot] [PATCH] travis: give every job a name

2018-08-02 Thread Tom Rini
On Thu, Aug 02, 2018 at 11:08:30AM -0600, Stephen Warren wrote: > On 07/30/2018 10:19 AM, Stephen Warren wrote: > >From: Stephen Warren > > > >Travis CI now supports giving jobs an explicit name. Do this for all jobs. > >This allows more direct control over jobs names than the previous > >automati

Re: [U-Boot] [PATCH 05/10] net: sandbox: Allow fake eth to handle more than 1 packet response

2018-08-02 Thread Simon Glass
On 24 July 2018 at 15:40, Joe Hershberger wrote: > Use up to the max allocated receive buffers so be able to test more > complex situations. > > Signed-off-by: Joe Hershberger > --- > > arch/sandbox/include/asm/eth.h | 10 +--- > drivers/net/sandbox.c | 57 > +++

Re: [U-Boot] [PATCH] travis: give every job a name

2018-08-02 Thread Stephen Warren
On 07/30/2018 10:19 AM, Stephen Warren wrote: From: Stephen Warren Travis CI now supports giving jobs an explicit name. Do this for all jobs. This allows more direct control over jobs names than the previous automatic or implicit naming based on the environment variables or script text. Does

Re: [U-Boot] [PATCH 06/10] net: Add an accessor to know if waiting for ARP

2018-08-02 Thread Simon Glass
On 24 July 2018 at 15:40, Joe Hershberger wrote: > This single-sources the state of the ARP. > > Signed-off-by: Joe Hershberger > --- > > include/net.h | 1 + > net/arp.c | 11 --- > 2 files changed, 9 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 04/10] net: sandbox: Share the priv structure with tests

2018-08-02 Thread Simon Glass
On 24 July 2018 at 15:40, Joe Hershberger wrote: > If tests want to implement tx handlers, they will likely need access to > the details in the priv structure. > > Signed-off-by: Joe Hershberger > --- > > arch/sandbox/include/asm/eth.h | 19 +++ > drivers/net/sandbox.c |

Re: [U-Boot] [PATCH 08/10] test: eth: Add a test for ARP requests

2018-08-02 Thread Simon Glass
On 24 July 2018 at 15:40, Joe Hershberger wrote: > This tests that ARP requests made to this target's IP address are > responded-to by the target when it is doing other networking operations. > > This currently corrupts the ongoing operation of the device if it > happens to be awaiting an ARP repl

Re: [U-Boot] [PATCH 02/10] net: sandbox: Refactor sandbox send function

2018-08-02 Thread Simon Glass
Hi Joe, On 24 July 2018 at 15:40, Joe Hershberger wrote: > Make the behavior of the send function reusable. > > Signed-off-by: Joe Hershberger > --- > > arch/sandbox/include/asm/eth.h | 20 + > drivers/net/sandbox.c | 176 > - > 2 files cha

Re: [U-Boot] [PATCH 01/10] net: sandbox: Move disabled flag into priv struct

2018-08-02 Thread Simon Glass
On 24 July 2018 at 15:40, Joe Hershberger wrote: > Store the per-device data with the device. > > Signed-off-by: Joe Hershberger > --- > > drivers/net/sandbox.c | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH v1 1/5] dm: gpio: Add get_function_number ops

2018-08-02 Thread Simon Glass
Hi Patrice, On 1 August 2018 at 10:38, Patrice Chotard wrote: > From: Patrick Delaunay > > When a pin is not configured as a GPIO, it could > have several alternate function. > > To be able to identify the alternate function, > add ops get_function_number() to request the pin > function index fr

Re: [U-Boot] [PATCH] efi_loader: don't allocate unusable RAM

2018-08-02 Thread Stephen Warren
On 08/01/2018 11:57 PM, Heinrich Schuchardt wrote: On 08/01/2018 06:17 PM, Stephen Warren wrote: On 08/01/2018 12:07 AM, Heinrich Schuchardt wrote: On 07/31/2018 09:44 PM, Stephen Warren wrote: From: Stephen Warren Some boards define a maximum usable RAM top that's more restrictive than the

Re: [U-Boot] [PATCH 09/10] test: eth: Add a test for the target being pinged

2018-08-02 Thread Simon Glass
On 24 July 2018 at 15:40, Joe Hershberger wrote: > The target will respond to pings while doing other network handling. > Make sure that the response happens and is correct. > > This currently corrupts the ongoing operation of the device if it > happens to be awaiting an ARP reply of its own to wh

Re: [U-Boot] [PATCH 10/10] net: Don't overwrite waiting packets with asynchronous replies

2018-08-02 Thread Simon Glass
On 24 July 2018 at 15:40, Joe Hershberger wrote: > Peter originally sent a fix, but it breaks a number of other things. > This addresses the original reported issue in a different way. > > That report was: > >> U-Boot has 1 common buffer to send Ethernet frames, pointed to by >> net_tx_packet. Wh

Re: [U-Boot] [PATCH] ARM: tegra: align carveout size

2018-08-02 Thread Stephen Warren
On 08/01/2018 06:06 PM, Tom Rini wrote: On Wed, Aug 01, 2018 at 11:52:36PM +, Tom Warren wrote: I can add this to my PR list (but probably won't get one out until tomorrow morning), or: Acked-by: Tom Warren If that'll get it in sooner. Applied, thanks! Thanks. The Jetson TK1 tests a

Re: [U-Boot] [PATCH 03/10] net: sandbox: Make the fake eth driver response configurable

2018-08-02 Thread Simon Glass
On 24 July 2018 at 15:40, Joe Hershberger wrote: > Make the send handler registerable so tests can check for different > things. > > Signed-off-by: Joe Hershberger > --- > > arch/sandbox/include/asm/eth.h | 17 ++ > drivers/net/sandbox.c | 53 > +

Re: [U-Boot] [PATCH v3 12/13] misc: Add gdsys_soc driver

2018-08-02 Thread Simon Glass
On 31 July 2018 at 04:01, Mario Six wrote: > This patch adds a driver for the bus associated with a IHS FPGA. > > Signed-off-by: Mario Six > --- > > v2 -> v3: > * Fixed style violations > * Added bindings file > * Added more debug output in case of errors > * Switched all printfs to debug > * Doc

Re: [U-Boot] [PATCH 07/10] net: sandbox: Add a priv ptr for tests to use

2018-08-02 Thread Simon Glass
Hi, On 24 July 2018 at 15:40, Joe Hershberger wrote: Missing commit message - what is this for? > Signed-off-by: Joe Hershberger > --- > > arch/sandbox/include/asm/eth.h | 9 + > drivers/net/sandbox.c | 20 > 2 files changed, 29 insertions(+) Regards,

Re: [U-Boot] [PATCH v3 13/13] misc: Add IHS FPGA driver

2018-08-02 Thread Simon Glass
On 31 July 2018 at 04:01, Mario Six wrote: > Add a driver for gdsys IHS (Integrated Hardware Systems) FPGAs, which > supports initialization of the FPGA, as well as information gathering. > > Signed-off-by: Mario Six > --- > > v2 -> v3: > * Fixed style violations > * Added full documentation > *

Re: [U-Boot] [PATCH v1 2/5] gpio: stm32f7: Add ops get_function

2018-08-02 Thread Simon Glass
On 1 August 2018 at 10:38, Patrice Chotard wrote: > From: Christophe Kerello > > This patch adds gpio get_function ops support. > This function reports the state of a gpio. > > Signed-off-by: Christophe Kerello > Signed-off-by: Patrice Chotard > --- > > drivers/gpio/stm32f7_gpio.c | 20 +++

Re: [U-Boot] [PATCH 6/9] ram: stm32mp1: use PRIx64 macros for printing ram size

2018-08-02 Thread Simon Glass
On 26 July 2018 at 07:59, Philipp Tomsich wrote: > > With the recent changes of the underlying types for the ram size, we > need to adjust the formatting. Use PRIx64 to print the (now) u64 > field. > > Signed-off-by: Philipp Tomsich > --- > > arch/arm/mach-stm32mp/dram_init.c | 2 +- > driver

Re: [U-Boot] [PATCH v3 03/13] regmap: Add documentation

2018-08-02 Thread Simon Glass
On 31 July 2018 at 04:01, Mario Six wrote: > Document the regmap_alloc() function. > > Signed-off-by: Mario Six > --- > > v2 -> v3: > New in v3 > > --- > drivers/core/regmap.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Simon Glass ___

Re: [U-Boot] [PATCH v3 02/13] regmap: Fix documentation

2018-08-02 Thread Simon Glass
Hi Mario, On 31 July 2018 at 04:00, Mario Six wrote: > The documentation in regmap.h is not in kernel-doc format. Correct this. > > Signed-off-by: Mario Six > --- > > v2 -> v3: > New in v3 > > --- > include/regmap.h | 48 +++- > 1 file changed, 39 ins

Re: [U-Boot] [PATCH v2 3/3] sandbox: Add serial test

2018-08-02 Thread Simon Glass
On 1 August 2018 at 09:58, Patrice Chotard wrote: > Signed-off-by: Patrice Chotard > --- > > Changes in v2: > - Add sandbox serial test > > drivers/serial/sandbox.c | 14 ++ > include/common.h | 1 + > test/dm/Makefile | 1 + > test/dm/serial.c | 26 ++

Re: [U-Boot] [PATCH v2 1/3] dm: serial: Replace setparity by setconfig

2018-08-02 Thread Simon Glass
Hi Patrice, On 1 August 2018 at 09:58, Patrice Chotard wrote: > From: Patrick Delaunay > > Replace setparity by more generic setconfig ops > to allow uart parity, bits word length and stop bits > number change. > > Adds SERIAL_GET_PARITY/BITS/STOP macros. > > Signed-off-by: Patrick Delaunay > S

Re: [U-Boot] [PATCH v3 01/13] test: regmap: Increase size of syscon0 memory

2018-08-02 Thread Simon Glass
On 31 July 2018 at 04:00, Mario Six wrote: > The upcoming changes to the regmap interface will contain a proper check > for plausibility when reading/writing from/to a register map. To still > have the current tests pass, increase the size of the memory region for > the syscon0 device, since one o

[U-Boot] Please pull u-boot-dm (take 2)

2018-08-02 Thread Simon Glass
Hi Tom, Here is another attempt. The build is here: https://travis-ci.org/sglass68/u-boot/builds/410948863 The following changes since commit 61523dde17d1539b8ea361e25909acfdfc465155: Merge tag 'arc-updates-for-2018.09-rc2' of git://git.denx.de/u-boot-arc (2018-08-01 09:26:15 -0400) are av

Re: [U-Boot] [PATCH 04/20] W1-EEPROM: Add an W1-EEPROM uclass for 1 wire EEPROMs

2018-08-02 Thread Simon Glass
Hi, On 30 July 2018 at 20:06, Tom Rini wrote: > On Mon, Jul 30, 2018 at 11:54:51AM +0300, Eugen Hristev wrote: >> >> >> On 20.07.2018 17:28, Maxime Ripard wrote: >> >Hi Eugen, >> > >> >Thanks for giving those patches another shot. >> > >> >On Thu, Jul 19, 2018 at 12:57:52PM +0300, Eugen Hristev w

Re: [U-Boot] [PATCH v3 04/13] regmap: Improve error handling

2018-08-02 Thread Simon Glass
On 31 July 2018 at 04:01, Mario Six wrote: > ofnode_read_simple_addr_cells may fail and return a negative error code. > Check for this when initializing regmaps. > > Also check if both_len is zero, since this is perfectly possible, and > would lead to a division-by-zero further down the line. > >

Re: [U-Boot] [PATCH] common: fdt: Make fdt_del_subnodes/fdt_del_partition static

2018-08-02 Thread Simon Glass
On 31 July 2018 at 06:32, Michal Simek wrote: > These functions are only called in this file that's why make them static > to keep static analysers happy. > > Signed-off-by: Michal Simek > --- > > common/fdt_support.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simo

Re: [U-Boot] [PATCH v2 2/3] serial: stm32: Replace setparity by setconfig

2018-08-02 Thread Simon Glass
Hi Patrice, On 1 August 2018 at 09:58, Patrice Chotard wrote: > Replace stm32_serial_setparity by stm32_serial_setconfig > which allows to set serial bits number, parity and stop > bits number. > Only parity setting is implemented. > > Signed-off-by: Patrick Delaunay > Signed-off-by: Patrice Cho

Re: [U-Boot] [PATCH 3/9] common: include always

2018-08-02 Thread Simon Glass
+Tom Hi Masahiro, On 30 July 2018 at 19:41, Masahiro Yamada wrote: > 2018-07-26 22:59 GMT+09:00 Philipp Tomsich > : >> With the ram-size variable changed to u64, we'll need appropriate >> macros for printing u64 values correctly either in 32bit builds >> (i.e. ILP32 models) or in 64bit builds (i

Re: [U-Boot] [PATCH v4 3/4] test: Add tests for misc uclass

2018-08-02 Thread Simon Glass
On 31 July 2018 at 06:24, Mario Six wrote: > Add a set of tests for the misc uclass. > > Signed-off-by: Mario Six > --- > > v3 -> v4: > New in v4 > > --- > arch/sandbox/dts/test.dts | 4 ++ > drivers/misc/Makefile | 2 +- > drivers/misc/misc_sandbox.c | 133 > +++

Re: [U-Boot] [PATCH v4 2/3] board: Add gazerbeam driver

2018-08-02 Thread Simon Glass
On 31 July 2018 at 03:44, Mario Six wrote: > Add a board driver for the upcoming gdsys Gazerbeam board. > > Signed-off-by: Mario Six > --- > > v3 -> v4: > * Fixed misplaced Kconfig lines > > v2 -> v3: > * Set startup-finished GPIOs during probe > * Added driver binding file for gazerbeam board >

Re: [U-Boot] [PATCH 2/2] sandbox: Enable bitrev library build

2018-08-02 Thread Simon Glass
2018-07-31 22:29 GMT-06:00 Bin Meng : > Turn on CONFIG_BITREVERSE for all sandbox builds. > > Signed-off-by: Bin Meng > --- > > configs/sandbox64_defconfig| 1 + > configs/sandbox_defconfig | 1 + > configs/sandbox_flattree_defconfig | 1 + > configs/sandbox_noblk_defconfig|

Re: [U-Boot] [PATCH 1/2] lib: bitrev: Sync with Linux kernel v4.17

2018-08-02 Thread Simon Glass
On 31 July 2018 at 22:29, Bin Meng wrote: > Signed-off-by: Bin Meng > --- > > include/linux/bitrev.h | 102 > - > lib/bitrev.c | 28 -- > 2 files changed, 101 insertions(+), 29 deletions(-) Reviewed-by: Simon Glass ___

Re: [U-Boot] [PATCH v2 5/8] ARM: Odroid XU3: Adjust BOOT_TARGET_DEVICES to allow booting from SD card (mmc2)

2018-08-02 Thread Simon Glass
On 1 August 2018 at 06:48, Lukasz Majewski wrote: > > This change is necessary to allow booting the Odroid XU3 from SD card > after enabling the DM_MMC support. > > After this change the SD card mmc IP block is correctly enumerated as mmc2 > (and not as mmc1 as in the legacy code). > > Signed-off-

Re: [U-Boot] [PATCH] net: fman: Support both new and legacy FMan Compatibles

2018-08-02 Thread Joe Hershberger
On Wed, Aug 1, 2018 at 4:48 AM, Zhao Qiang wrote: > Recently the FMan Port and MAC compatibles were changed. > This patch aligns the FMan Port and MAC compatibles > to the new FMan device tree binding document. > The FMan device tree binding document can be found in the Linux > kernel: > ./Docume

Re: [U-Boot] [PATCH v2 3/3] linux/if_ether.h: Add VLAN related macros

2018-08-02 Thread Joe Hershberger
On Tue, Jul 31, 2018 at 4:55 AM, Bin Meng wrote: > There are VLAN related macros defined in include/linux/if_vlan.h > in Linux kernel, as well as some kernel useful structures and inline > functions. Instead of a complete import from kernel, let's add these > VLAN macros to U-Boot's include/linux/

Re: [U-Boot] [PATCH v2 2/3] net.h: Include linux/if_ether.h to avoid duplication

2018-08-02 Thread Joe Hershberger
On Tue, Jul 31, 2018 at 4:55 AM, Bin Meng wrote: > There are plenty of existing drivers that have macros like ETH_ALEN > defined in their own source files. Now that we imported the kernel's > if_ether.h to U-Boot we can reduce some duplication. > > Signed-off-by: Bin Meng Acked-by: Joe Hershberg

Re: [U-Boot] [PATCH v2 1/3] linux/if_ether.h: Initial import from Linux kernel v4.17

2018-08-02 Thread Joe Hershberger
On Tue, Jul 31, 2018 at 4:55 AM, Bin Meng wrote: > This imports include/uapi/linux/if_ether.h from Linux kernel v4.17. > It can be very helpful When porting Linux ethernet driver to U-Boot. > > Note it is not exactly the same as the kernel one, as checkpatch > issues are fixed. > > Signed-off-by:

Re: [U-Boot] [PATCH 0/2] Ethernet name length changes

2018-08-02 Thread Joe Hershberger
On Thu, Aug 2, 2018 at 6:01 AM, Pankaj Bansal wrote: > The ethernet name should be within the ETH_NAME_LEN, as this > is the buffer space allocated to ethernet name. > > Otherwise, this causes buffer overflow. > > At the same time the 16 char ethernet name size is inadequate to hold the > name of

Re: [U-Boot] bootelf and 64 bit elf application

2018-08-02 Thread George Robinson
I would like to know an answer to that problem, too. Is the hello.world.bin an ELF file ? What does objdump say ? Also, the entry address is not the same as the load address, so maybe there is something to do with that... George On 2018-08-01 21:06, Siddharth Tuli wrote: Hi, I am trying t

Re: [U-Boot] [PATCH] net: fman: Support both new and legacy FMan Compatibles

2018-08-02 Thread York Sun
On 08/01/2018 02:50 AM, Zhao Qiang wrote: > Recently the FMan Port and MAC compatibles were changed. > This patch aligns the FMan Port and MAC compatibles > to the new FMan device tree binding document. > The FMan device tree binding document can be found in the Linux > kernel: > ./Documentation/d

Re: [U-Boot] xyz-modem: Change getc timeout loop waiting

2018-08-02 Thread Alexander Sverdlin
Hello Tomas, On Wed, 1 Aug 2018 09:16:38 +0300 Tomas Melin wrote: > >> Is the timeout a watchdog timeout or some communication freeze? > > I suppose, it reports false-positive timeout back to ymodem code. > > Because all it does is terminating communication gracefully (with 'C' > > and a bunch o

Re: [U-Boot] [PATCH v5 00/27] SPI-NAND support

2018-08-02 Thread Jose Landeros
___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH V2] Convert CONFIG_USB_ULPI_TIMEOUT to Kconfig

2018-08-02 Thread Marek Vasut
On 08/02/2018 04:02 PM, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_USB_ULPI_TIMEOUT > > Signed-off-by: Adam Ford > --- > V2: Make USB_ULPI_TIMEOUT depend on USB_ULPI > > diff --git a/drivers/usb/ulpi/Kconfig b/drivers/usb/ulpi/Kconfig > index 001564d40c..6a67f70411 10

[U-Boot] [PATCH V2] Convert CONFIG_USB_ULPI_TIMEOUT to Kconfig

2018-08-02 Thread Adam Ford
This converts the following to Kconfig: CONFIG_USB_ULPI_TIMEOUT Signed-off-by: Adam Ford --- V2: Make USB_ULPI_TIMEOUT depend on USB_ULPI diff --git a/drivers/usb/ulpi/Kconfig b/drivers/usb/ulpi/Kconfig index 001564d40c..6a67f70411 100644 --- a/drivers/usb/ulpi/Kconfig +++ b/drivers/usb/ulpi/

Re: [U-Boot] [PATCH] Convert CONFIG_USB_ULPI_TIMEOUT to Kconfig

2018-08-02 Thread Adam Ford
On Thu, Aug 2, 2018 at 8:56 AM Marek Vasut wrote: > > On 08/02/2018 03:27 PM, Adam Ford wrote: > > This converts the following to Kconfig: > >CONFIG_USB_ULPI_TIMEOUT > > > > Signed-off-by: Adam Ford > > > > diff --git a/drivers/usb/ulpi/Kconfig b/drivers/usb/ulpi/Kconfig > > index 001564d40c.

Re: [U-Boot] [PATCH] Convert CONFIG_USB_ULPI_TIMEOUT to Kconfig

2018-08-02 Thread Marek Vasut
On 08/02/2018 03:27 PM, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_USB_ULPI_TIMEOUT > > Signed-off-by: Adam Ford > > diff --git a/drivers/usb/ulpi/Kconfig b/drivers/usb/ulpi/Kconfig > index 001564d40c..d0eff66e1c 100644 > --- a/drivers/usb/ulpi/Kconfig > +++ b/drivers

Re: [U-Boot] [PATCH] ARM: socfpga: Convert to DM serial

2018-08-02 Thread Marek Vasut
On 08/02/2018 10:36 AM, Simon Goldschmidt wrote: > > > On 01.08.2018 18:34, Marek Vasut wrote: >> On 08/01/2018 05:42 PM, Simon Goldschmidt wrote: >>> >>> >>> Marek Vasut mailto:ma...@denx.de>> schrieb am Mi., 1. >>> Aug. 2018, 09:35: >>> >>> On 08/01/2018 09:29 AM, Goldschmidt Simon wrote:

  1   2   >