Re: [U-Boot] [RFC 0/9] import x509/pkcs7 parsers from linux

2019-10-02 Thread AKASHI Takahiro
Ping. Does anybody have any comments on this patch set? Happy or unhappy with my approach here? Thanks, -Takahiro Akashi On Tue, Sep 03, 2019 at 02:42:37PM +0900, AKASHI Takahiro wrote: > Asn1 parsers of x509 certificates and pkcs7 messages are required > to implement image authentication and

Re: [U-Boot] [RFC 3/3] lib: rsa: add rsa_verify_with_pkey()

2019-10-02 Thread AKASHI Takahiro
Simon, On Wed, Sep 18, 2019 at 12:03:25PM +0900, AKASHI Takahiro wrote: > Simon, > > Overall, do you agree to my approach here? Ping. Do you mind my sending out v2? -Takahiro Akashi > On Mon, Sep 16, 2019 at 10:48:07PM -0700, Simon Glass wrote: > > Hi AKASHI, > > > > On Fri, 6 Sep 2019 at

Re: [U-Boot] [U-BOOT PATCH v2 1/2] gpio: sifive: add support for DM based gpio driver for FU540-SoC

2019-10-02 Thread Sagar Kadam
Hi Bin, On Wed, Oct 2, 2019 at 6:33 PM Bin Meng wrote: > > On Wed, Oct 2, 2019 at 1:01 AM Sagar Shrikant Kadam > wrote: > > > > This patch adds a DM based driver model for gpio controller present in > > FU540-C000 SoC on HiFive Unleashed A00 board. This SoC has one GPIO > > bank and 16 GPIO

Re: [U-Boot] [PATCH] efi: device path for nvme

2019-10-02 Thread Bin Meng
+Heinrich to review On Thu, Oct 3, 2019 at 5:11 AM Patrick Wildt wrote: > > This adds a device path node for NVMe block devices. For that > nvme_get_namespace_id() is added to return the privately stored > namespace identifier. > > Signed-off-by: Patrick Wildt > > diff --git

[U-Boot] [PATCH] binman: Use qemu-x86_defconfig in the example

2019-10-02 Thread Bin Meng
The doc currently uses sandbox_defconfig as examples of enabling debug/verbose output of binman. However during a sandbox build it does not call binman at all. Change it to qemu-x86_defconfig. Signed-off-by: Bin Meng --- tools/binman/README | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [U-Boot] [PATCH v2 04/38] mtd: spi: Add 'struct spi_flash {' to the code

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 9:56 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > At present spi_flash is defined to be spi_nor which is confusing since it > > is not possible to find the 'spi_flash' by normal text search. Add a > > comment to help with this. > > > >

Re: [U-Boot] [PATCH v2 05/38] serial: ns16550: Allow serial to enabled/disabled in SPL

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 9:56 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > At present this driver uses the wrong condition for including the code and > > drivers in SPL/TPL. Update it so that the code is only included if > > DM_SERIAL is enabled for SPL/TPL. >

Re: [U-Boot] [PATCH v2 02/38] binman: Allow selection of logging verbosity

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 9:56 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > Support a new BINMAN_VERBOSE option to the build, to allow passing the > > -v flag to binman. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: None > > > > Makefile

Re: [U-Boot] [PATCH v2 03/38] dm: gpio: Allow control of GPIO uclass in SPL

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 9:56 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > At present if CONFIG_SPL_GPIO_SUPPORT is enabled then the GPIO uclass > > is included in SPL/TPL without any control for boards. Some boards may > > want to disable this to reduce code

Re: [U-Boot] [PATCH v2 01/38] binman: Pass the toolpath to binman from the main Makefile

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 9:55 PM Bin Meng wrote: > > On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > > > Pass in the toolpath in case binman needs to use tools compiled in the > > U-Boot tools/ directory. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: None > > > >

Re: [U-Boot] [PATCH 2/2] watchdog: designware: Convert to DM and DT probing

2019-10-02 Thread Ley Foon Tan
On Thu, Oct 3, 2019 at 6:56 AM Marek Vasut wrote: > > Convert the designware watchdog timer driver to DM and add DT probing > support. Perform minor coding style clean up, like drop superfluous > braces. These ought to be no functional change. > > Signed-off-by: Marek Vasut > Cc: Chin Liang See

Re: [U-Boot] One u-boot.bin for Raspberry PI 3 and 4 - possible?

2019-10-02 Thread Geoff Williams
> And with a U-Boot based on f5c626c64874d6e1482edf4a76aa22e5e54be63d without my > patches you see correct behavior? The screen turning off issue was caused by a deployment script copying the wrong u-boot binary to the SD card! The patch does not introduce a regression on RPI 3 (tested

Re: [U-Boot] [PATCH] NVMe: do PCI enumerate before nvme scan

2019-10-02 Thread Bin Meng
Hi Patrick, On Thu, Oct 3, 2019 at 3:58 AM Patrick Wildt wrote: > > Make sure that the PCI busses are enumerated before trying to > find a NVMe device. > > Signed-off-by: Patrick Wildt > > diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h > index

[U-Boot] [PATCH] ARM: socfpga: Fix default mtdparts

2019-10-02 Thread Marek Vasut
The default mtdparts value grew a trailing zero during the Kconfig conversion. This is because the mtdparts value in the header file had a \0 at the end, which got misconverted into plain 0 instead of being dropped. Signed-off-by: Marek Vasut Fixes: 43ede0bca7fc ("Kconfig: Migrate MTDIDS_DEFAULT

[U-Boot] [PATCH 2/2] watchdog: designware: Convert to DM and DT probing

2019-10-02 Thread Marek Vasut
Convert the designware watchdog timer driver to DM and add DT probing support. Perform minor coding style clean up, like drop superfluous braces. These ought to be no functional change. Signed-off-by: Marek Vasut Cc: Chin Liang See Cc: Dalon Westergreen Cc: Dinh Nguyen Cc: Ley Foon Tan Cc:

[U-Boot] [PATCH 1/2] watchdog: designware: Migrate CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2019-10-02 Thread Marek Vasut
Migrate CONFIG_DESIGNWARE_WATCHDOG to Kconfig and update the headers accordingly, no functional change. The S10 enables the WDT only in SPL, but does not enable it in U-Boot itself, hence disable it in the config again. Signed-off-by: Marek Vasut Cc: Chin Liang See Cc: Dalon Westergreen Cc:

[U-Boot] [PATCH] efi: device path for nvme

2019-10-02 Thread Patrick Wildt
This adds a device path node for NVMe block devices. For that nvme_get_namespace_id() is added to return the privately stored namespace identifier. Signed-off-by: Patrick Wildt diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index 561f757772..0a72fe2b75 100644 --- a/drivers/nvme/nvme.c

[U-Boot] [PATCH] NVMe: do PCI enumerate before nvme scan

2019-10-02 Thread Patrick Wildt
Make sure that the PCI busses are enumerated before trying to find a NVMe device. Signed-off-by: Patrick Wildt diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h index 3570a32dff..563f1bf5fa 100644 --- a/include/config_distro_bootcmd.h +++

[U-Boot] [PATCH 1/2] net: macb: explicitly pass phy_adr to mdio read and write

2019-10-02 Thread Josef Holzmayr
To support accessing arbitrary addresses the mii/mdio bus it is neccesary that the macb_mdio_read and macb_mdio_write functions do not implicitly use the address of the connected phy. The function signature is extended according to the Linux kernel equivalent. Signed-off-by: Josef Holzmayr ---

[U-Boot] [PATCH 0/2] net: macb: support arbitrary mdio addresses

2019-10-02 Thread Josef Holzmayr
This patch mini-series enables the macb driver to access all addresses on the mdio bus instead of only the one of the connected phy. This is especially useful if you have a tagging switch connected to the macb. Josef Holzmayr (2): net: macb: explicitly pass phy_adr to mdio read and write

[U-Boot] [PATCH 2/2] net: macb: let miiphy_read/_write pass arbitrary addresses

2019-10-02 Thread Josef Holzmayr
This allows passing arbitrary addresses through macb_miiphy_read and macb_miiphy_write, therefore enabling the mii command to access all mdio bus devices instead of only the defined phy. Signed-off-by: Josef Holzmayr --- drivers/net/macb.c | 10 ++ 1 file changed, 2 insertions(+), 8

[U-Boot] [PATCH 2/2] tiny-printf: Support vsnprintf()

2019-10-02 Thread Simon South
Add a simple implementation of this function, to allow logging to be enabled in the SPL or TPL for systems that rely on the tiny printf() implementation. To keep the code size small, - The function is built only when logging is enabled, as it (currently) is not needed otherwise; and - Like the

[U-Boot] [PATCH 1/2] common: Kconfig: Fix typo in TPL_LOG_CONSOLE description

2019-10-02 Thread Simon South
Signed-off-by: Simon South --- common/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/Kconfig b/common/Kconfig index 28d5e9a0cc..d9ecf79e0a 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -764,7 +764,7 @@ config SPL_LOG_CONSOLE line number are

[U-Boot] [PATCH 0/2] Small fixes to SPL/TPL logging

2019-10-02 Thread Simon South
These two patches fix small issues I encountered when enabling debugging output for U-Boot's TPL. The first fixes a typo in the description of the TPL_LOG_CONSOLE configuration option. The second adds a simple implementation of vsnprintf() to the tiny-printf library. Without this, enabling

Re: [U-Boot] [PATCH v2 31/38] x86: spl: Move broadwell-specific code out of generic x86 spl

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > When TPL is running, broadwell needs to do different init from SPL. There > is no need for this code to be in the generic x86 SPL file, so move it to > arch_cpu_init(). > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 35/38] x86: Add more comments to the start-up code

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > The full start-up sequence (TPL->SPL->U-Boot) can be a bit confusing since > each phase has its own 'start' file. Add comments to explain this. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/cpu/start.S

Re: [U-Boot] [PATCH v2 20/38] x86: fsp: Move common dram functions into a common file

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > Most of the DRAM functionality can be shared between FSP1 and FSP2. Move > it into a shared file. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/include/asm/fsp/fsp_support.h | 9 +++ > arch/x86/lib/Makefile

Re: [U-Boot] [PATCH v2 36/38] x86: Add support for booting from Fast SPI

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > Most x86 CPUs use a mechanism where the SPI flash is mapped into the very > top of 32-bit address space, so that it can be executed in place and read > simply by copying from memory. For an 8MB ROM the mapping starts at > 0xff80. > >

Re: [U-Boot] [PATCH v2 32/38] x86: fsp: Save usable RAM and hob_list in the handoff area

2019-10-02 Thread Bin Meng
Hi Simon, On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > The useable RAM is calculated when the RAM is inited. Save this value so > that it can be easily used in U-Boot proper. > > Also save a pointer to the hob list so that it is accessible (before > relocation only) in U-Boot proper.

Re: [U-Boot] [PATCH v2 37/38] x86: Add various MTRR indexes and values

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > Add some new MTRRs used by Apollolake as well as a mask for the MTRR > type. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/include/asm/msr-index.h | 22 ++ > arch/x86/include/asm/mtrr.h

Re: [U-Boot] [PATCH v2 24/38] x86: fsp: Add a few more definitions for FSP2

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > Add definitions for the FSP signature and the FSP init phase. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/include/asm/fsp/fsp_infoheader.h | 15 ++- > 1 file changed, 14 insertions(+), 1

Re: [U-Boot] [PATCH v2 34/38] x86: Change condition for using CAR

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > At present we assume that CAR (Cache-as-RAM) is used if HOBs (Hand-off > bLocks) are not, since HOBs typically indicate that an FSP is in use, and nits: blocks > FSPs handle the CAR init. > > However this is a bit indirect, and for FSP2

Re: [U-Boot] [PATCH v2 27/38] x86: Add binman symbols to the image

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > It is useful in SPL and TPL to access symbols from binman, such as the > position and size of an entry in the ROM. Collect these symbols together > in the SPL binaries. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 28/38] x86: pci: Add a function to clear and set PCI config regs

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > At present the x86 pre-DM equivalent of pci_bus_clrset_config32() does not > exist. Add it to simplify PCI init code on x86. > > Also add the missing functions to this header. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 38/38] x86: Rename turbo ratio MSR to MSR_TURBO_RATIO_LIMIT

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > This MSR number is used on most modern Intel processors, so drop the > confusing NHM prefix (which might mean Nehalem). > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Rebase to master > > arch/x86/cpu/broadwell/cpu_full.c | 2

Re: [U-Boot] [PATCH v2 21/38] x86: Move common fsp functions into a common file

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Some of this file can be shared between FSP1 and FSP2. Move it into a > shared file. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/include/asm/fsp/fsp_support.h | 17 >

Re: [U-Boot] [PATCH v2 30/38] x86: spl: Reduce priority of the basic SPL image loader

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > This image loader works on systems where the flash is directly mapped to > the last part of the 32-bit address space. On recent Intel systems (such > as apollolake) this is not the case. > > Reduce the priority of this loader so that another

Re: [U-Boot] [PATCH v2 25/38] x86: fsp: Add access to variable MRC data

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > With FSP2 the non-volatile storage used by the FSP to init memory can be > split into a fixed piece (determined at compile time) and a variable piece > (determined at run time). Add support for reading the latter. > > Signed-off-by: Simon

Re: [U-Boot] [PATCH v2 26/38] x86: Move common Intel CPU info code into a function

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > Add cpu_intel_get_info() to find out the CPU info on modern Intel CPUs. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/cpu/broadwell/cpu_full.c| 9 + > arch/x86/cpu/intel_common/cpu.c | 13

Re: [U-Boot] [PATCH v2 23/38] efi: Move inline functions to unconditional part of header

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > At present these two functions are defined in efi_loader.h but only if > CONFIG_EFI_LOADER is enabled. But these are functions that are useful to > other code, such as that which deals with Intel Handoff Blocks (HOBs). > > Move these to the

Re: [U-Boot] [PATCH v2 19/38] x86: fsp: Tidy up comment style a little

2019-10-02 Thread Bin Meng
Hi Simon, On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > The comments in the FSP code use a different style from the rest of the > x86 code. I am not sure it this is intentional. I guess it's because when it was written I was not familiar with the documenting style :) > >

Re: [U-Boot] [PATCH v2 22/38] x86: fsp: Move common support functions into a common file

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Some of this file can be shared between FSP1 and FSP2. Move it into a > shared file. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/lib/fsp/Makefile | 1 + > arch/x86/lib/fsp/fsp_support.c | 176

Re: [U-Boot] [PATCH v2 29/38] x86: spl: Use hang() instead of a while() loop

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass wrote: > > Use the standard hang() function when booting fails since this implements > the defined U-Boot behaviour for this situation. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/lib/spl.c | 3 +-- > arch/x86/lib/tpl.c

Re: [U-Boot] [PATCH v2 16/38] x86: Rename some FSP functions to have an fsp_ prefix

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Given these exported function an fsp_ prefix since they are declared in an > fsp.h header. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/cpu/baytrail/fsp_configs.c | 2 +- >

Re: [U-Boot] [PATCH 18/38] x86: fsp: Use if() instead of #ifdef

2019-10-02 Thread Bin Meng
Hi Simon, On Tue, Aug 27, 2019 at 12:03 AM Simon Glass wrote: > > Update a few #ifdefs to if() to improve build coverage. > > Signed-off-by: Simon Glass > --- > > arch/x86/lib/fsp1/fsp_common.c | 9 - > arch/x86/lib/fsp1/fsp_dram.c | 8 ++-- > 2 files changed, 6 insertions(+), 11

Re: [U-Boot] [PATCH v2 17/38] x86: fsp: Create a common fsp_support.h header

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Many support functions are common between FSP1 and FSP2. Add a new header > to handle this. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/include/asm/fsp/fsp_support.h | 128 >

Re: [U-Boot] [PATCH v2 15/38] x86: sysreset: Allow reset driver to be included in SPL/TPL

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present this driver is always included in SPL and TPL, if U-Boot proper > enables it. Update the Makefile to provide full control using the existing > Kconfig options. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 11/38] spl: Add a function to determine the U-Boot phase

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > U-Boot is built in three phases: TPL, SPL and U-Boot proper. Sometimes > it is necessary to use different init code depending on the phase. For > example, TPL might do very basic CPU init, SPL might do a little more > and U-Boot proper might

Re: [U-Boot] [PATCH v2 10/38] spl: Set up the bloblist in board_init_r()

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present the bloblist is set up in spl_common_init() which can be called > from spl_early_init(), i.e. before SDRAM is ready. This prevents the > bloblist from being located in SDRAM, which is useful on some platforms > where SRAM is

Re: [U-Boot] [PATCH v2 07/38] spl: Avoid checking for Ctrl-C in SPL with print_buffer()

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > We don't have a console in SPL so it doesn't make sense to check for > Ctrl-C when printing a memory dump. Skip this so that print_buffer() can > be used in SPL. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 09/38] spl: Add an arch-specific hook for writing to SPL handoff

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present there is an arch-specific area in the SPL handoff area intended > for use by arch-specific code, but there is no explicit call to fill in > this data. Add a hook for this. > > Also use the hook to remove the sandbox-specific test

Re: [U-Boot] [PATCH v2 08/38] spl: handoff: Correct Kconfig condition for SPL and TPL

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present these options can be enabled when bloblist is not enabled for > SPL or TPL. This is incorrect as SPL handoff requires bloblist. Fix it. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > common/spl/Kconfig | 4 ++--

Re: [U-Boot] [PATCH v2 05/38] serial: ns16550: Allow serial to enabled/disabled in SPL

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present this driver uses the wrong condition for including the code and > drivers in SPL/TPL. Update it so that the code is only included if > DM_SERIAL is enabled for SPL/TPL. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None

Re: [U-Boot] [PATCH v2 03/38] dm: gpio: Allow control of GPIO uclass in SPL

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present if CONFIG_SPL_GPIO_SUPPORT is enabled then the GPIO uclass > is included in SPL/TPL without any control for boards. Some boards may > want to disable this to reduce code size where GPIOs are not needed in > SPL or TPL. > > Add a

Re: [U-Boot] [PATCH v2 04/38] mtd: spi: Add 'struct spi_flash {' to the code

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > At present spi_flash is defined to be spi_nor which is confusing since it > is not possible to find the 'spi_flash' by normal text search. Add a > comment to help with this. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 02/38] binman: Allow selection of logging verbosity

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Support a new BINMAN_VERBOSE option to the build, to allow passing the > -v flag to binman. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > Makefile| 3 ++- > tools/binman/README | 6 ++ > 2 files changed,

Re: [U-Boot] [PATCH v2 01/38] binman: Pass the toolpath to binman from the main Makefile

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:12 PM Simon Glass wrote: > > Pass in the toolpath in case binman needs to use tools compiled in the > U-Boot tools/ directory. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > Makefile | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng

[U-Boot] [PATCH] Makefile: Fix typo around CONFIG_SPL_FIT_SOURCE

2019-10-02 Thread Michal Simek
Trivial fix. Signed-off-by: Michal Simek --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1d9ade948bab..60ae53d6388a 100644 --- a/Makefile +++ b/Makefile @@ -1232,7 +1232,7 @@ ifndef CONFIG_SYS_UBOOT_START CONFIG_SYS_UBOOT_START := 0

[U-Boot] [PATCH v2 11/13] arm64: zynqmp: probe firmware driver

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga Probe ZynqMP firmware driver on the board initialization phase and ensure that firmware is in place to continue execution. The probing is done on board_init so it can be used for both SPL and U-Boot proper. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek ---

[U-Boot] [PATCH v2 07/13] firmware: zynqmp: get fw version with mailbox driver

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga Implements the function to get PMU Firmware version using the mailbox driver or smc call based on if running SPL or not. Additionally gets version as part of the ZynqMP Firmware driver probing Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: -

[U-Boot] [PATCH v2 09/13] arm64: zynqmp: use firmware driver to get version

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga Use the new function from firmware version to get the firmware version. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None board/xilinx/zynqmp/zynqmp.c | 2 +- drivers/fpga/zynqmppl.c | 4 ++-- 2 files changed, 3 insertions(+), 3

[U-Boot] [PATCH v2 10/13] arm64: zynqmp: remove old fw version function

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga Removes the old function to get the firmware version. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None arch/arm/mach-zynqmp/cpu.c| 23 --- arch/arm/mach-zynqmp/include/mach/sys_proto.h | 1 - 2 files

[U-Boot] [PATCH v2 12/13] firmware: zynqmp: Separate function for sending message via mailbox

2019-10-02 Thread Michal Simek
U-Boot running in EL3 can't use SMC that's why there is a need to talk to PMUFW directly via mailbox. The same logic is applied to all functions which need to talk to PMUFW that's why move this logic to separate function to avoid code duplication. Also SMC request ID can be composed from

[U-Boot] [PATCH v2 13/13] arm64: zynqmp: Use mailbox driver for PMUFW config loading

2019-10-02 Thread Michal Simek
With new mailbox driver PMUFW configuration object can be loaded via the same interface and there is no need to have pmu_ipc.c completely. Signed-off-by: Michal Simek Reviewed-by: Luca Ceresoli --- Changes in v2: None arch/arm/mach-zynqmp/Makefile | 4 -

[U-Boot] [PATCH v2 06/13] arm64: zynqmp: Cleanup PM SMC macro composition

2019-10-02 Thread Michal Simek
Cleanup PM ID handling by using enum values. Signed-off-by: Michal Simek Signed-off-by: Ibai Erkiaga --- Changes in v2: None arch/arm/mach-zynqmp/include/mach/sys_proto.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

[U-Boot] [PATCH v2 05/13] arm64: zynqmp: add firmware and mailbox node to DT

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga The following patch adds a mailbox node and firmware node to following the mainline DT. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None arch/arm/dts/zynqmp.dtsi | 44 +++- 1 file changed, 39

[U-Boot] [PATCH v2 08/13] firmware: zynqmp: create firmware header

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga New firmware header to place firmware specific macro and function declarations. The patch also moves the macros defining PM operations as well as some helper macros. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: - Move pm_api_id higher -

[U-Boot] [PATCH v2 04/13] firmware: zynqmp: Add zynqmp-power support

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga zynqmp-power driver for ZynqMP to handle the communication with the PMU firmware. Firmware driver just probes subnodes and power driver handles communication with PMU using the IPI mailbox driver. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: -

[U-Boot] [PATCH v2 02/13] mailbox: allow subnode for mbox regs

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga The following patch allows the mailbox node in DT to host subnodes with mailbox definitions. If the client phandle to the mailbox is not the mailbox driver node, just checks parents as well. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None

[U-Boot] [PATCH v2 03/13] mailbox: zynqmp: ipi mailbox driver

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga ZynqMP mailbox driver implementing IPI communication with PMU. This would allow U-Boot SPL to communicate with PMUFW to request privileged operations. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None MAINTAINERS

[U-Boot] [PATCH v2 00/13] arm64: zynqmp: Clean communication with PMUFW

2019-10-02 Thread Michal Simek
Hi, This patch series using ZynqMP firmware driver to provide a interface to communicate with the PMU Firmware. As part of the series a mailbox driver is also implemented to handle communication through ipi interface. There are two new wiring: 1. Reading PMUFW version via firmware driver -

[U-Boot] [PATCH v2 01/13] mailbox: check ops prior calling

2019-10-02 Thread Michal Simek
From: Ibai Erkiaga Check if request and free operations are present prior calling to the functions. Signed-off-by: Ibai Erkiaga Signed-off-by: Michal Simek --- Changes in v2: None drivers/mailbox/mailbox-uclass.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [U-Boot] [U-BOOT PATCH v2 1/2] gpio: sifive: add support for DM based gpio driver for FU540-SoC

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 1:01 AM Sagar Shrikant Kadam wrote: > > This patch adds a DM based driver model for gpio controller present in > FU540-C000 SoC on HiFive Unleashed A00 board. This SoC has one GPIO > bank and 16 GPIO lines in total, out of which GPIO0 to GPIO9 and > GPIO15 are routed to the

[U-Boot] [PATCH v1 4/4] test: Add tests for the multiplexer framework

2019-10-02 Thread Jean-Jacques Hiblot
Provide tests to check the behavior of the multiplexer framework. The test uses a mmio-based multiplexer. Signed-off-by: Jean-Jacques Hiblot --- arch/sandbox/dts/test.dts | 26 +++ configs/sandbox_defconfig | 2 + test/dm/Makefile | 1 + test/dm/mux-mmio.c| 143

[U-Boot] [PATCH v1 1/4] drivers: Add a new framework for multiplexer devices

2019-10-02 Thread Jean-Jacques Hiblot
Add a new subsystem that handles multiplexer controllers. The API is the same as in Linux. Signed-off-by: Jean-Jacques Hiblot --- drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/mux/Kconfig | 7 + drivers/mux/Makefile | 6 +

[U-Boot] [PATCH v1 2/4] dm: board: complete the initialization of the muxes in initr_dm()

2019-10-02 Thread Jean-Jacques Hiblot
This will probe the multiplexer devices that have a "u-boot,mux-autoprobe" property. As a consequence they will be put in their idle state. Signed-off-by: Jean-Jacques Hiblot --- common/board_r.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/board_r.c b/common/board_r.c index

[U-Boot] [PATCH v1 0/4] drivers: Add a framework for MUX drivers

2019-10-02 Thread Jean-Jacques Hiblot
Add a new minimalistic subsystem that handles multiplexer controllers. It provides the same API as Linux and mux drivers should be portable with a minimum effort. This series also includes a port of the Linux's mmio-mux driver. This series relies on 2 other series [1] and [2] posted earlier.

[U-Boot] [PATCH v1 3/4] drivers: mux: mmio-based syscon mux controller

2019-10-02 Thread Jean-Jacques Hiblot
This adds a driver for mmio-based syscon multiplexers controlled by bitfields in a syscon register range. This is heavily based on the linux mmio-mux driver. Signed-off-by: Jean-Jacques Hiblot --- drivers/mux/Kconfig | 15 + drivers/mux/Makefile | 1 + drivers/mux/mmio.c | 155

[U-Boot] [PATCH] linux_compat: fix potential NULL pointer access

2019-10-02 Thread Marek Szyprowski
malloc_cache_aligned() might return zero, so fix potential NULL pointer access if __GFP_ZERO flag is set. Signed-off-by: Marek Szyprowski --- lib/linux_compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/linux_compat.c b/lib/linux_compat.c index

Re: [U-Boot] [PATCH 000/126] x86: Add initial support for apollolake

2019-10-02 Thread Bin Meng
Hi Simon, On Wed, Oct 2, 2019 at 10:15 AM Simon Glass wrote: > > Hi Bin, > > On Wed, 25 Sep 2019 at 08:58, Simon Glass wrote: > > > > Apollolake is an Intel SoC generation aimed at relatively low-end embedded > > systems. It was released in 2016 but has become more popular recently with > >

[U-Boot] [PATCH] thor: fix error path after g_dnl_register() failure

2019-10-02 Thread Marek Szyprowski
Set command return value and perform needed cleanup when g_dnl_register() function fails. Signed-off-by: Marek Szyprowski --- cmd/thordown.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/thordown.c b/cmd/thordown.c index dd0544d475..8dae024e31 100644 ---

[U-Boot] [PATCH] dwc3: flush cache only if there is a buffer attached to a request

2019-10-02 Thread Marek Szyprowski
Calling cache flush on invalid buffer, even with zero length might cause an exception on certain platforms. Signed-off-by: Marek Szyprowski --- drivers/usb/dwc3/gadget.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c

Re: [U-Boot] [PATCH v3 09/10] x86: Move fsp_bootmode.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This header file is the same for FSP v1 and v2, although there may be > some additions to come. Move it into the generic fsp directory. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2:

Re: [U-Boot] [PATCH v3 07/10] x86: Move fsp_hob.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 8:05 AM Bin Meng wrote: > > On Wed, Oct 2, 2019 at 8:00 AM Bin Meng wrote: > > > > On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > > > > > This header file is the same for FSP v1 and v2. Move it into the general > > > fsp directory. > > > > > > Signed-off-by:

Re: [U-Boot] [PATCH v3 10/10] x86: Move fsp_ffs.h include to fsp_arch.h

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This include file is only used for FSP v1. Avoid including it from > fdt_support.h so we can use the latter with FSP v2. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: None > >

Re: [U-Boot] [PATCH v3 08/10] x86: Move fsp_infoheader.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This header file is the same for FSP v1 and v2. Move it into the general > fsp directory. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: None > >

Re: [U-Boot] [PATCH v3 02/10] x86: Move fsp_azalia.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Oct 2, 2019 at 6:55 AM Bin Meng wrote: > > Hi Simon, > > On Wed, Oct 2, 2019 at 1:39 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Tue, 1 Oct 2019 at 04:59, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > > > > > > > This

Re: [U-Boot] [PATCH v3 06/10] x86: Move fsp_fv.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This header file is the same for FSP v1 and v2. Move it into the general > fsp directory. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: None > > arch/x86/include/asm/{fsp1 =>

Re: [U-Boot] [PATCH v3 04/10] x86: Move fsp_api.h inclusion out of fsp_support.h

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This header file is different for each version of FSP. Move it into the > fsp_arch.h header file. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: None > >

Re: [U-Boot] [PATCH v3 05/10] x86: Move fsp_types.h to the generic fsp directory

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > This header file is the same for FSP v1 and v2. Move it into the general > fsp directory. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: None > > arch/x86/include/asm/{fsp1 =>

Re: [U-Boot] [PATCH v3 03/10] x86: Create a new fsp_arch.h header

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > At present fsp_support.h includes fsp_vpd.h which is an FPSv1 concept > (VPD means Vital Product Data). For FSPv2 only UPD (Updatable Product > Data) is used. > > To avoid mangling header files, put these two includes in a separate > header

Re: [U-Boot] [PATCH v3 01/10] x86: Rename existing FSP code to fsp1

2019-10-02 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:00 PM Simon Glass wrote: > > Since there is now a new version of the FSP and it is incompatible with > the existing version, move the code into an fsp1 directory. This will > allow us to put FSP v2 code into an fsp2 directory. > > Add a Kconfig which defines which

Re: [U-Boot] [PATCH 4/5] riscv: dts: hifive-unleashed-a00: Add -u-boot.dtsi

2019-10-02 Thread Jagan Teki
On Mon, Sep 30, 2019 at 3:35 PM Bin Meng wrote: > > Hi Jagan, > > On Sun, Sep 29, 2019 at 3:43 PM Jagan Teki wrote: > > > > Add u-boot specific dts file for hifive-unleashed-a00, this > > would help to add u-boot specific properties and other node > > changes without touching the base dts(i)

[U-Boot] [PATCH v2] dfu: mmc: add support for in-partition offset

2019-10-02 Thread Marek Szyprowski
Add possibility to define a part of partition as a separate DFU entity. This allows to have more than one items on the given partition. The real use case for this option is TM2 board. It can use u-boot stored as Linux kernel on the defined partition (as RAW data) and load the real kernel from the

[U-Boot] [PATCH RESEND] cmd: thor: select DFU subsystem also for 'thor' download tool

2019-10-02 Thread Marek Szyprowski
'THOR' download command requires DFU infrastructure to properly flash board images. It can be used without enabling DFU command, so add such dependency to Kconfig. Signed-off-by: Marek Szyprowski Acked-by: Lukasz Majewski --- Resend reason: stand alone patch, independent from the main patchset:

Re: [U-Boot] [PATCH 1/5] riscv: dts: Add hifive-unleashed-a00 dts from Linux

2019-10-02 Thread Jagan Teki
On Mon, Sep 30, 2019 at 3:35 PM Bin Meng wrote: > > Hi Jagan, > > On Sun, Sep 29, 2019 at 3:42 PM Jagan Teki wrote: > > > > Sync the hifive-unleashed-a00 dts from Linux with > > below commit details: > > commit 11ae2d892139a1086f257188d457ddcb71ab5257 > > The latest commit should be: > > commit

[U-Boot] [PATCH RESEND] gadget: f_thor: properly enable 3rd endpoint defined by the protocol

2019-10-02 Thread Marek Szyprowski
This is needed to make Windows THOR flash tool happy, because it starts sending data only when interrupt packet is received on the 3rd endpoint. Signed-off-by: Marek Szyprowski Acked-by: Lukasz Majewski --- Resend reason: stand alone patch, independent from the main patchset:

[U-Boot] [PATCH RESEND] cmd: itest: add support for .q size specifier

2019-10-02 Thread Marek Szyprowski
Add support for quad (64bits) memory access specifier. Signed-off-by: Marek Szyprowski Acked-by: Lukasz Majewski --- Resend reason: stand alone patch, independent from the main patchset: https://patchwork.ozlabs.org/cover/994309/ --- cmd/itest.c | 12 1 file changed, 12

Re: [U-Boot] [PATCH v4 04/17] arm: socfpga: agilex: Add reset manager support

2019-10-02 Thread Simon Goldschmidt
On Wed, Oct 2, 2019 at 11:25 AM Ley Foon Tan wrote: > > On Wed, Oct 2, 2019 at 4:26 PM Simon Goldschmidt > wrote: > > > > On Thu, Sep 12, 2019 at 12:11 PM Ley Foon Tan > > wrote: > > > > > > Add reset manager support for Agilex. > > > > > > Signed-off-by: Ley Foon Tan > > > > > > --- > > >

Re: [U-Boot] [PATCH 04/13] firmware: zynqmp: Add zynqmp-power support

2019-10-02 Thread Michal Simek
On 02. 10. 19 11:34, Luca Ceresoli wrote: > Hi Ibai, Michal, > > On 27/09/19 15:34, Michal Simek wrote: >> From: Ibai Erkiaga >> >> zynqmp-power driver for ZynqMP to handle the communication with the PMU >> firmware. Firmware driver just probes subnodes and power driver handles >> communication

  1   2   >