Re: [PATCH] usb: ehci: Fix "EHCI timed out on TD - token=XXXX" error on ehci-hcd

2020-02-28 Thread Marek Vasut
On 2/29/20 4:20 AM, Tom Rini wrote: > On Sat, Feb 29, 2020 at 12:32:57AM +0100, Marek Vasut wrote: >> On 2/26/20 12:29 PM, Lukasz Majewski wrote: >>> This patch aims to improve robustness of 'usb' command operation on the >>> ehci-hcd IP block as it ports to contemporary U-Boot the patch described

[GIT PULL] UniPhier SoC updates for v2020.04 (3rd)

2020-02-28 Thread Masahiro Yamada
Hi Tom, Please pull more updates. Thanks. The following changes since commit 548ce227d3d852455c6395c0cec30af0cda77b09: Prepare v2020.04-rc3 (2020-02-26 07:53:20 -0500) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-uniphier.git tags/uniphier-v202

Re: [PATCH 2/3] ARM: dts: uniphier: add reset-names to NAND controller node

2020-02-28 Thread Masahiro Yamada
On Fri, Feb 28, 2020 at 9:58 PM Masahiro Yamada wrote: > > Import Linux commits: > > 37f3e0096f71 ("ARM: dts: uniphier: add reset-names to NAND controller node") > e98d5023fe1f ("arm64: dts: uniphier: add reset-names to NAND controller node") > > Signed-off-by: Masahiro Yamada > --- Applied to

Re: [PATCH 3/3] ARM: dts: uniphier: remove U-Boot own EEPROM compatible and property

2020-02-28 Thread Masahiro Yamada
On Fri, Feb 28, 2020 at 9:58 PM Masahiro Yamada wrote: > > The compatible string "i2c-eeprom" is U-Boot own compatible, which > has never been approved by the DT community. "u-boot,i2c-offset-len" > is also a U-Boot own hack. > > Linux adds "atmel,*" as generic compatibles, and U-Boot also followe

Re: [PATCH 1/3] ARM: dts: uniphier: rename DT nodes to follow json-schema

2020-02-28 Thread Masahiro Yamada
On Fri, Feb 28, 2020 at 9:58 PM Masahiro Yamada wrote: > > Import the nodename changes I made in Linux for avoiding dt-schama > warnings. This follows the $nodename patterns in the dt-schema. > > Signed-off-by: Masahiro Yamada > --- Applied to u-boot-uniphier. > arch/arm/dts/uniphier-ld11.dts

Re: [PATCH] usb: ehci: Fix "EHCI timed out on TD - token=XXXX" error on ehci-hcd

2020-02-28 Thread Tom Rini
On Sat, Feb 29, 2020 at 12:32:57AM +0100, Marek Vasut wrote: > On 2/26/20 12:29 PM, Lukasz Majewski wrote: > > This patch aims to improve robustness of 'usb' command operation on the > > ehci-hcd IP block as it ports to contemporary U-Boot the patch described > > and provided in [1] (originally app

Re: [U-Boot] [RFC/RFT PATCH v4 3/3] image: Add compressed Image parsing support in booti.

2020-02-28 Thread Atish Patra
On Thu, Feb 20, 2020 at 2:25 PM Atish Patra wrote: > > On Thu, Feb 20, 2020 at 1:14 PM David Abdurachmanov > wrote: > > > > On Tue, Feb 18, 2020 at 10:38 PM Tom Rini wrote: > > > > > > On Sun, Feb 16, 2020 at 04:48:22PM -0800, Atish Patra wrote: > > > > On Fri, Feb 14, 2020 at 8:43 AM Tom Rini

[PATCH] serial: mcfuart: renaming to a more appropriate name

2020-02-28 Thread Angelo Dureghello
From: Angelo Durgehello All drivers seems to align now to serial_xxx maning, so, aligning also this driver, to allow to be found easily. Signed-off-by: Angelo Durgehello --- drivers/serial/Makefile | 2 +- drivers/serial/mcfuart.c | 179 --- 2 files chang

[PATCH] serial: mcfuart: fix uart port index

2020-02-28 Thread Angelo Dureghello
From: Angelo Durgehello Actually, using dev->seq value before probe to deduce the current serial port index leads to reading an invalid seq value (-1). So, getting dev->seq at probe time. Signed-off-by: Angelo Durgehello --- drivers/serial/mcfuart.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [U-Boot] [PATCH] usb: ehci-mx5: Fix bus enumeration for DM case

2020-02-28 Thread Marek Vasut
On 2/26/20 10:16 AM, Lukasz Majewski wrote: [...] > diff --git a/drivers/usb/host/ehci-mx5.c > b/drivers/usb/host/ehci-mx5.c index 0b32728c57..4db513f4e5 100644 > --- a/drivers/usb/host/ehci-mx5.c > +++ b/drivers/usb/host/ehci-mx5.c > @@ -301,6 +301,22 @@ static int ehci_usb_ofd

Re: [PATCH] usb: ehci: Fix "EHCI timed out on TD - token=XXXX" error on ehci-hcd

2020-02-28 Thread Marek Vasut
On 2/26/20 12:29 PM, Lukasz Majewski wrote: > This patch aims to improve robustness of 'usb' command operation on the > ehci-hcd IP block as it ports to contemporary U-Boot the patch described > and provided in [1] (originally applicable to U-Boot 2016.05). > > According to the fix author - "rayvt

Re: Fixing low-speed USB keyboard detection

2020-02-28 Thread Marek Vasut
On 2/26/20 12:04 PM, Soeren Moch wrote: > Adding Marek as USB maintainer. Otherwise this non-patch-email may get > lost when sent to the mailing list only. Well, can you send these as proper patches ? > Soeren > > On 25.02.20 18:45, Stefan wrote: >> Hello! >> >> I own a D-Link DBT-120 Bluetooth

Re: [PATCH v5 25/33] wdt: Move asm/utils.h to log2.h

2020-02-28 Thread Marek Vasut
On 2/28/20 11:43 PM, Sean Anderson wrote: > > On 2/28/20 4:46 PM, Marek Vasut wrote: >> On 2/28/20 10:05 PM, Sean Anderson wrote: >>> This header is needed outside of the arm architecture for the designware >>> watchdog. >>> >>> Signed-off-by: Sean Anderson >>> Reviewed-by: Simon Glass >>> --- >

caching BLOBLISTT_SPL_HANDOFF (was Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently)

2020-02-28 Thread Rasmus Villemoes
On 28/02/2020 18.35, Tom Rini wrote: > On Fri, Feb 28, 2020 at 05:24:58PM +, Rasmus Villemoes wrote: >> eliminated, and there's not an #ifdef in sight. > > That sounds pretty nice actually. If you're so inclined I'd like to see > it. > So I started looking at that, and while it's mostly me

Re: m68k hangs silently

2020-02-28 Thread Angelo Dureghello
Hi Simon, On Wed, Feb 19, 2020 at 10:21 PM Simon Glass wrote: > > Hi Angelo, > > On Wed, 19 Feb 2020 at 07:36, Angelo Dureghello > wrote: > > > > Hi Simon, > > > > after this commit: > > > > commit 29f7d05a347ab7a42577c67fdfb787ef91537302 > > Author: Simon Glass > > Date: Sun Dec 29 21:19:17

Re: [PATCH v5 25/33] wdt: Move asm/utils.h to log2.h

2020-02-28 Thread Sean Anderson
On 2/28/20 4:46 PM, Marek Vasut wrote: > On 2/28/20 10:05 PM, Sean Anderson wrote: >> This header is needed outside of the arm architecture for the designware >> watchdog. >> >> Signed-off-by: Sean Anderson >> Reviewed-by: Simon Glass >> --- >> This patch previously appeared as >> https://patch

Re: [PATCH v5 25/33] wdt: Move asm/utils.h to log2.h

2020-02-28 Thread Marek Vasut
On 2/28/20 10:05 PM, Sean Anderson wrote: > This header is needed outside of the arm architecture for the designware > watchdog. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass > --- > This patch previously appeared as > https://patchwork.ozlabs.org/patch/1232411/ Can't you call rou

[PATCH v5 33/33] riscv: Add Sipeed Maix support

2020-02-28 Thread Sean Anderson
The Sipeed Maix series is a collection of boards built around the RISC-V Kendryte K210 processor. This processor contains several peripherals to accelerate neural network processing and other "ai" tasks. This includes a "KPU" neural network processor, an audio processor supporting beamforming recep

[PATCH v5 29/33] riscv: Allow use of reset drivers

2020-02-28 Thread Sean Anderson
Currently, one cannot use a reset driver on RISC-V. Follow the MIPS example, and disable the default reset handler when the sysreset driver is enabled. Signed-off-by: Sean Anderson Reviewed-by: Bin Meng --- Changes in v3: - New arch/riscv/lib/reset.c | 2 ++ 1 file changed, 2 insertions(+) d

[PATCH v5 32/33] riscv: Add device tree for K210 and Sipeed Maix BitM

2020-02-28 Thread Sean Anderson
Where possible, I have tried to find compatible drivers based on the layout of registers. However, many devices remain untested. All untested devices have been left disabled, but some tentative properties (such as compatible strings, and clocks, interrupts, and resets properties) have been added.

[PATCH v5 31/33] riscv: Enable cpu clock if it is present

2020-02-28 Thread Sean Anderson
The cpu clock is probably already enabled if we are executing code (though we could be executing from a different core). This patch prevents the cpu clock or its parents from being disabled. Signed-off-by: Sean Anderson Reviewed-by: Bin Meng --- This patch was previously submitted on its own as

[PATCH v5 30/33] riscv: Try to get cpu frequency from a "clocks" node if it exists

2020-02-28 Thread Sean Anderson
Instead of always using the "clock-frequency" property to determine cpu frequency, try using a clock in "clocks" if it exists. This patch also fixes a bug where there could be spurious higher frequencies if sizeof(u32) != sizeof(ulong). Signed-off-by: Sean Anderson Reviewed-by: Bin Meng --- This

[PATCH v5 27/33] riscv: Fix race conditions when initializing IPI

2020-02-28 Thread Sean Anderson
The IPI code could have race conditions in several places. * Several harts could race on the value of gd->arch->clint/plic * Non-boot harts could race with the main hart on the DM subsystem In addition, if an IPI was pending when U-Boot started, it would cause the IPI handler to jump to address

[PATCH v5 28/33] riscv: Add option to support RISC-V privileged spec 1.9

2020-02-28 Thread Sean Anderson
Some older processors (notably the Kendryte K210) use an older version of the RISC-V privileged specification. The primary changes between the old and new are in virtual memory, and in the merging of three separate counter enable CSRs. Using the new CSR on an old processor causes an illegal instru

[PATCH v5 24/33] spi: dw: Add mem_ops

2020-02-28 Thread Sean Anderson
The designware ssi device has "broken" chip select behaviour [1], and needs specific manipulation to use the built-in chip select. The existing fix is to use an external GPIO for chip select, but typically the K210 has SPI3 directly connected to a flash chip with dedicated pins. This makes it impos

[PATCH v5 25/33] wdt: Move asm/utils.h to log2.h

2020-02-28 Thread Sean Anderson
This header is needed outside of the arm architecture for the designware watchdog. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- This patch previously appeared as https://patchwork.ozlabs.org/patch/1232411/ Changes in v5: - New - Include linux/err.h explicitly arch/arm/cpu/armv7/c

[PATCH v5 26/33] riscv: Add headers for asm/global_data.h

2020-02-28 Thread Sean Anderson
This header depended on bd_t and ulong, but did not include the appropriate headers. Signed-off-by: Sean Anderson Reviewed-by: Bin Meng --- Changes in v4: - Include compiler.h not linux/compiler.h arch/riscv/include/asm/global_data.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/

[PATCH v5 21/33] spi: dw: Use generic function to read reg address

2020-02-28 Thread Sean Anderson
Using an fdt-specific function causes problems when compiled with a live tree. Signed-off-by: Sean Anderson --- Changes in v5: - New drivers/spi/designware_spi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/designware_spi.c b/drivers/spi/designware_spi.c i

[PATCH v5 19/33] spi: dw: Add device tree properties for fields in CTRL1

2020-02-28 Thread Sean Anderson
Some devices have different layouts for the fields in CTRL1 (e.g. the Kendryte K210). Allow this layout to be configurable from the device tree. The documentation has been taken from Linux. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v4: - New .../spi/snps,dw-apb-ssi.

[PATCH v5 17/33] gpio: dw: Return output value when direction is out

2020-02-28 Thread Sean Anderson
dm_gpio_ops.get_value can be called when the gpio is either input or output. The current dw code always returns the input value, which is invalid if the direction is set to out. Signed-off-by: Sean Anderson --- Changes in v5: - New drivers/gpio/dwapb_gpio.c | 19 --- 1 file cha

[PATCH v5 23/33] spi: dw: Properly set rx_end when not recieving

2020-02-28 Thread Sean Anderson
The difference between rx and rx_end is used by tx_max when calculating how much to write. If we aren't reading anything, this could cause us to let the tx fifo bottom out. Signed-off-by: Sean Anderson --- Changes in v5: - New drivers/spi/designware_spi.c | 3 ++- 1 file changed, 2 insertions(

[PATCH v5 22/33] spi: dw: Speed up transfer loops

2020-02-28 Thread Sean Anderson
The transfer loops are very tight on some platforms (especially on higher speeds). If we don't read/write fast enough we can run into over-/under- flow problems. This patch removes several divisions and log statements, and simplifies the read logic. Signed-off-by: Sean Anderson --- Changes in v5

[PATCH v5 20/33] spi: dw: Rename "cs-gpio" to "cs-gpios"

2020-02-28 Thread Sean Anderson
This property is named differently than other SPI drivers with the same property, as well as the property as used in Linux. Signed-off-by: Sean Anderson --- Changes in v5: - New arch/arc/dts/axs10x_mb.dtsi | 3 ++- arch/arc/dts/hsdk.dts| 3 ++- drivers/spi/designware_spi.c | 10 +++-

[PATCH v5 18/33] led: gpio: Default to using node name if label is absent

2020-02-28 Thread Sean Anderson
This more closely mirrors Linux's behaviour, and will make it easier to transition to using function+color in the future. Signed-off-by: Sean Anderson --- Changes in v5: - New drivers/led/led_gpio.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/led/led_gpio

[PATCH v5 13/33] pinctrl: Add support for Kendryte K210 FPIOA

2020-02-28 Thread Sean Anderson
The Fully-Programmable Input/Output Array (FPIOA) device controls pin multiplexing on the K210. The FPIOA can remap any supported function to any multifunctional IO pin. It can also perform basic GPIO functions, such as reading the current value of a pin. Signed-off-by: Sean Anderson --- Changes

[PATCH v5 14/33] gpio: sifive: Use generic reg read function

2020-02-28 Thread Sean Anderson
Using an fdt-specific function causes problems with a live tree. Signed-off-by: Sean Anderson --- Changes in v5: - New drivers/gpio/sifive-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/sifive-gpio.c b/drivers/gpio/sifive-gpio.c index 76d5a1d34e..111f75

[PATCH v5 15/33] gpio: dw: Fix warnings about casting int to pointer

2020-02-28 Thread Sean Anderson
Explicitly cast fdt_addr_t to a void pointer, since we pass it to readl. Signed-off-by: Sean Anderson --- Changes in v5: - New drivers/gpio/dwapb_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/dwapb_gpio.c b/drivers/gpio/dwapb_gpio.c index e3439eebb

[PATCH v5 11/33] reset: Add generic reset driver

2020-02-28 Thread Sean Anderson
This patch adds a generic reset driver. It is designed to be useful when one has a register in a regmap which contains bits that reset other devices. I thought this seemed like a very generic use, so here is a generic driver. The overall structure has been modeled on the syscon-reboot driver. Sign

[PATCH v5 16/33] gpio: dw: Add a trailing underscore to generated name

2020-02-28 Thread Sean Anderson
Previously, if there was no bank-name property, it was easy to have confusing gpio names like "gpio1@08", instead of "gpio1@0_8". This patch follows the example of the sifive gpio driver. Signed-off-by: Sean Anderson --- Changes in v5: - New drivers/gpio/dwapb_gpio.c | 10 +- 1 file ch

[PATCH v5 05/33] clk: Add K210 pll support

2020-02-28 Thread Sean Anderson
This pll code is primarily based on the code from the kendryte standalone sdk in lib/drivers/sysctl.c. k210_pll_calc_params is roughly analogous to the algorithm used to set the pll frequency, but it has been completely rewritten to be fixed-point based. Signed-off-by: Sean Anderson --- Changes

[PATCH v5 12/33] lib: Always set errno in hcreate_r

2020-02-28 Thread Sean Anderson
This could give a confusing error message if it failed and didn't set errno. Signed-off-by: Sean Anderson --- Changes in v5: - New lib/hashtable.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/hashtable.c b/lib/hashtable.c index 907e8a642f..e9ac7e252e 100644 -

[PATCH v5 10/33] dm: Fix error handling for dev_read_addr_ptr

2020-02-28 Thread Sean Anderson
dev_read_addr_ptr had different semantics depending on whether OF_LIVE was enabled. This patch converts both implementations to return NULL on error, and converts all call sites which check for FDT_ADDR_T_NONE to check for NULL instead. This patch also removes the call to map_physmem, since we have

[PATCH v5 07/33] clk: Add K210 clock support

2020-02-28 Thread Sean Anderson
Due to the large number of clocks, I decided to use the CCF. The overall structure is modeled after the imx code. Clocks are stored in several arrays. There are some translation macros (FOOIFY()) which allow for more dense packing. A possible improvement could be to only store the parameters we n

[PATCH v5 09/33] dm: Add support for simple-pm-bus

2020-02-28 Thread Sean Anderson
This type of bus is used in Linux to designate buses which have power domains and/or clocks which need to be enabled before their child devices can be used. Because power domains are automatically enabled before probing in U-Boot, we just need to enable any clocks present. Signed-off-by: Sean Ande

[PATCH v5 06/33] clk: Add a bypass clock for K210

2020-02-28 Thread Sean Anderson
This is a small driver to do a software bypass of a clock if hardware bypass is not working. I have tried to write this in a generic fashion, so that it could be potentially broken out of the kendryte code at some future date. For the K210, it is used to have aclk bypass pll0 and use in0 instead so

[PATCH v5 04/33] clk: Add functions to register CCF clock structs

2020-02-28 Thread Sean Anderson
This patch adds alternate versions of the clk_*_register functions for use with statically-allocated struct clks. This allows drivers to define clocks at compile-time and register them at run-time without malloc-ing. This increases the size of the binary, but should not affect ram usage (since the

[PATCH v5 02/33] clk: Check that ops of composite clock components exist before calling

2020-02-28 Thread Sean Anderson
clk_composite_ops was shared between all devices in the composite clock driver. If one clock had a feature (such as supporting set_parent) which another clock did not, it could call a null pointer dereference. This patch does three things 1. It adds null-pointer checks to all composite clock func

[PATCH v5 08/33] doc: Fix typo in FIT documentation

2020-02-28 Thread Sean Anderson
u_boot should be u-boot Signed-off-by: Sean Anderson --- Changes in v5: - New doc/uImage.FIT/source_file_format.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/uImage.FIT/source_file_format.txt b/doc/uImage.FIT/source_file_format.txt index 18d2aedcb7..00c4dc337c 10

[PATCH v5 03/33] clk: Unconditionally recursively en-/dis-able clocks

2020-02-28 Thread Sean Anderson
For clocks not in the CCF, their parents will not have UCLASS_CLK, so we just enable them as normal. The enable count is local to the struct clk, but this will never result in the actual en-/dis-able op being called (unless the same struct clk is enabled twice). For clocks in the CCF, we always tr

[PATCH v5 00/33] riscv: Add Sipeed Maix support

2020-02-28 Thread Sean Anderson
This patch series adds support for Sipeed Maix boards and the Kendryte K210 CPU. Currently, only the Maix Bit V2.0 is supported, however other models are similar. This series depends on (clk: Include missing headers for linux/clk-provider.h). This will

[PATCH v5 01/33] clk: Always use the supplied struct clk

2020-02-28 Thread Sean Anderson
CCF clocks should always use the struct clock passed to their methods for extracting the driver-specific clock information struct. Previously, many functions would use the clk->dev->priv if the device was bound. This could cause problems with composite clocks. The individual clocks in a composite c

Re: [PATCH] watchdog: Don't select CONFIG_WATCHDOG and CONFIG_HW_WATCHDOG at the same time

2020-02-28 Thread Tom Rini
On Wed, Feb 26, 2020 at 04:17:52PM +, Christophe Leroy wrote: > Commit 06985289d452 ("watchdog: Implement generic watchdog_reset() > version") introduced an automatic selection of CONFIG_WATCHDOG by > CONFIG_WDT. But for boards selecting CONFIG_HW_WATCHDOG, like > boards have a powerpc 8xx, CO

Re: [PATCH] watchdog: mpc8xx: Revert the 8xx watchdog back to CONFIG_HW_WATCHDOG

2020-02-28 Thread Tom Rini
On Thu, Feb 20, 2020 at 07:39:51AM +, Christophe Leroy wrote: > Commit f3729ba6e7b2 ("watchdog: mpc8xx_wdt: Watchdog driver and macros > cleanup") switched the watchdog to CONFIG_WATCHDOG. But this is not > compatible with the 8xx because it starts the watchdog HW timer at > reset and must be

Re: [PATCH] common: update_tftp: remove unnecessary build check

2020-02-28 Thread Heinrich Schuchardt
On 2/28/20 1:06 AM, AKASHI Takahiro wrote: Logically, the current update_tftp() should and does compile and work correctly even without satisfying the following condition: #if defined(CONFIG_UPDATE_TFTP) && !defined(CONFIG_MTD_NOR_FLASH) #error "CONFIG_UPDATE_TFTP and !CONFIG_MTD_NOR_FLASH need

Re: [PATCH] efi_loader: file: set a backend block device for file operations

2020-02-28 Thread Heinrich Schuchardt
On 2/28/20 1:05 AM, AKASHI Takahiro wrote: In the current implementation, set_blk_dev() is called in opening a file, but not in opening a directory. This will cause failures at succeeding directory operations as the "current" block device remains nullified. Adding set_blk_dev() fixes this issue.

Re: [PATCH] cmd: efidebug: fix a failure of "boot rm" sub-command

2020-02-28 Thread Heinrich Schuchardt
On 2/28/20 1:05 AM, AKASHI Takahiro wrote: There is a wrong usage of utf8_utf16_strncpy() in "boot rm" command, and then it will end up with a failure of this command due to a wrong value of an interim variable ("var_name16"). Signed-off-by: AKASHI Takahiro --- cmd/efidebug.c | 5 +++-- 1 fi

Re: [PATCH 1/1] doc: fix references to driver-model

2020-02-28 Thread Heinrich Schuchardt
On 2/28/20 3:56 PM, Patrick DELAUNAY wrote: Hi, From: U-Boot On Behalf Of Patrick DELAUNAY Sent: vendredi 28 février 2020 14:49 Hi Heinrich From: U-Boot On Behalf Of Heinrich Schuchardt Sent: mardi 25 février 2020 21:36 Fix some errors pointed out by 'make refcheckdocs'. Signed-off-by: H

Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently

2020-02-28 Thread Tom Rini
On Fri, Feb 28, 2020 at 05:24:58PM +, Rasmus Villemoes wrote: > On 28/02/2020 16.46, Tom Rini wrote: > > On Fri, Feb 28, 2020 at 08:42:21AM +, Rasmus Villemoes wrote: > >> On 28/02/2020 00.40, Simon Glass wrote: > > >>> Using if() is preferable to #if if there is no cost. > >> > >> Complet

[PATCH v2 1/1] scripts: add documentation-file-ref-check

2020-02-28 Thread Heinrich Schuchardt
'make refcheckdocs' requires scripts/documentation-file-ref-check. Adopt script from Linux v5.6-rc3. Signed-off-by: Heinrich Schuchardt --- v2: our device-tree documentation is at doc/device-tree-bindings/ --- scripts/documentation-file-ref-check | 226 +++ 1 file

Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently

2020-02-28 Thread Rasmus Villemoes
On 28/02/2020 16.46, Tom Rini wrote: > On Fri, Feb 28, 2020 at 08:42:21AM +, Rasmus Villemoes wrote: >> On 28/02/2020 00.40, Simon Glass wrote: >>> Using if() is preferable to #if if there is no cost. >> >> Completely agree, and I also prefer to have the linker eliminate unused >> functions ra

Re: [PATCH] common/board_f.c: use #ifdefs a little more consistently

2020-02-28 Thread Tom Rini
On Fri, Feb 28, 2020 at 08:42:21AM +, Rasmus Villemoes wrote: > On 28/02/2020 00.40, Simon Glass wrote: > > Hi Rasmus, > > > > On Thu, 27 Feb 2020 at 00:18, Rasmus Villemoes > > wrote: > >> > >> Some init functions, e.g. print_resetinfo(), are conditionally defined > >> depending on some conf

Re: [PATCH 1/1] vexpress_ca9x4: Enable use of correct DTB file and restore EFI loader.

2020-02-28 Thread Tom Rini
On Tue, Feb 25, 2020 at 06:22:16PM +0100, Kristian Amlie wrote: > EFI was disabled in f95b8a4b5f64f because of the missing DTB file, > and indeed, the DTB file is required to load recent versions of GRUB > (2.04) correctly. > > Signed-off-by: Kristian Amlie > --- > configs/vexpress_ca9x4_defcon

Re: [PATCH v3][ 4/6] board: tbs2910: enable CONFIG_DISTRO_DEFAULTS

2020-02-28 Thread Tom Rini
On Thu, Feb 27, 2020 at 01:48:23AM +0100, Denis 'GNUtoo' Carikli wrote: > On Mon, 10 Feb 2020 09:40:50 -0500 > Tom Rini wrote: > > That said, the "bring in PXE" part of DISTRO_DEFAULTS predates sysboot > > being pulled out of the PXE code, where it was historically > > introduced. I would like to

RE: [PATCH 1/1] doc: fix references to driver-model

2020-02-28 Thread Patrick DELAUNAY
Hi, > From: U-Boot On Behalf Of Patrick DELAUNAY > Sent: vendredi 28 février 2020 14:49 > > Hi Heinrich > > > From: U-Boot On Behalf Of Heinrich > > Schuchardt > > Sent: mardi 25 février 2020 21:36 > > > > Fix some errors pointed out by 'make refcheckdocs'. > > > > Signed-off-by: Heinrich Schu

[PATCH 0/7] doc: Fix some errors pointed out by 'make refcheckdocs'

2020-02-28 Thread Patrick Delaunay
Fix some errors pointed out by 'make refcheckdocs'. This target is available after Heinrich patch "scripts: add documentation-file-ref-check" http://patchwork.ozlabs.org/patch/1244498/ see also patches 1/ "doc: fix references to driver-model" http://patchwork.ozlabs.org/patch/1244504/ 2/ "Kc

Re: [cmd]:"env edit" vs "env set", do we need both options for "env" command ??

2020-02-28 Thread Wolfgang Denk
Dear Adarsh Babu Kalepalli, In message you wrote: > > Are'nt "env edit" vs "env set" redundant ??. No, they are not. > "env edit" allows modification of the environment variable value in the > next line,whereas "env set" requires the mention of the environment > variable value in the same line

Re: [cmd] "env import" command behaviour observation

2020-02-28 Thread Wolfgang Denk
Dear Adarsh Babu Kalepalli, In message you wrote: > > Exporting environment variables to a memory location and trying to import > them back. > On certain occasions,the import command is displaying errors. ... > ## Error: Can't overwrite "ethaddr" > himport_r: can't insert "ethaddr=b8:27:eb:bb:2

Re: [PATCH 1/7] README: update reference to *.README

2020-02-28 Thread Heinrich Schuchardt
On 2/28/20 3:18 PM, Patrick Delaunay wrote: Update some reference in README file detected by scripts/documentation-file-ref-check *.README => README.* Signed-off-by: Patrick Delaunay Reviewed-by: Heinrich Schuchardt --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/1] scripts: add documentation-file-ref-check

2020-02-28 Thread Heinrich Schuchardt
On 2/28/20 2:24 PM, Patrick DELAUNAY wrote: Hi Heinrich, From: Heinrich Schuchardt Sent: mardi 25 février 2020 20:52 'make refcheckdocs' requires scripts/documentation-file-ref-check. Adopt script from Linux v5.6-rc3. Signed-off-by: Heinrich Schuchardt --- Reviewed-by: Patrick Delaunay

[PATCH 3/7] doc: update reference to README.imximage

2020-02-28 Thread Patrick Delaunay
Update reference in many files detected by scripts/documentation-file-ref-check README.imximage => imx/mkimage/imximage.txt Signed-off-by: Patrick Delaunay --- board/advantech/dms-ba16/dms-ba16_1g.cfg| 2 +- board/advantech/dms-ba16/dms-ba16_2g.cfg| 2 +- board/aristainetos/aristaineto

[PATCH 2/7] Kconfig: update reference to README.x86

2020-02-28 Thread Patrick Delaunay
Update reference in Kconfig detected by scripts/documentation-file-ref-check README.x86 => doc/arch/x86.rst Signed-off-by: Patrick Delaunay --- Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Kconfig b/Kconfig index 66148ce477..6bb6a1e415 100644 --- a/Kconfig +++ b/

[PATCH 5/7] doc: update reference to README.board

2020-02-28 Thread Patrick Delaunay
Update reference in files detected by scripts/documentation-file-ref-check doc/README. => board//README Files moved in board directory in commit 702e6014f15b ("doc: cleanup - move board READMEs into respective board directories")' Signed-off-by: Patrick Delaunay --- board/cobra5272/README

[PATCH 6/7] doc: device-tree-bindings: update reference to binding directory

2020-02-28 Thread Patrick Delaunay
Update reference in files detected by scripts/documentation-file-ref-check doc/devicetree/device-tree-bindings/ => doc/device-tree-bindings/ Signed-off-by: Patrick Delaunay --- doc/device-tree-bindings/net/ti,dp83867.txt | 2 +- doc/device-tree-bindings/video/rockchip-lvds.txt | 2 +- 2

[PATCH 1/7] README: update reference to *.README

2020-02-28 Thread Patrick Delaunay
Update some reference in README file detected by scripts/documentation-file-ref-check *.README => README.* Signed-off-by: Patrick Delaunay --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 8cfa92fac9..4a0f8cbeef 100644 --- a/README +++ b/READM

[PATCH 7/7] arm: imx: update reference to README.mxc_hab

2020-02-28 Thread Patrick Delaunay
Update reference in files detected by scripts/documentation-file-ref-check doc/README.mxc_hab => doc/imx/habv4/* Signed-off-by: Patrick Delaunay --- arch/arm/mach-imx/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/

[PATCH 4/7] doc: update reference to README.imx8image

2020-02-28 Thread Patrick Delaunay
Update reference in many files detected by scripts/documentation-file-ref-check README.imx8image => imx/mkimage/imx8image.txt Signed-off-by: Patrick Delaunay --- board/freescale/imx8qxp_mek/imximage.cfg | 2 +- board/siemens/capricorn/imximage.cfg | 2 +- b

Antwort: Re: [RFC PATCH] serial: ns16550: Move PCI access from ofdata_to_platdata() to probe()

2020-02-28 Thread Wolfgang Wallner
Hi Bin, -"Bin Meng" schrieb: - > Hi Wolfgang, > > [snip] > > Unfortunately this patch breaks several ARM board: > > +drivers/built-in.o: In function `ofnode_get_parent': > +drivers/core/ofnode.c:235: undefined reference to `fdt_parent_offset' > +drivers/built-in.o: In function `ofnode_

RE: [PATCH 1/1] doc: fix references to driver-model

2020-02-28 Thread Patrick DELAUNAY
Hi Heinrich > From: U-Boot On Behalf Of Heinrich Schuchardt > Sent: mardi 25 février 2020 21:36 > > Fix some errors pointed out by 'make refcheckdocs'. > > Signed-off-by: Heinrich Schuchardt > --- I found also the same issue in doc/README.SPL ---

Re: [PATCH] configs: am335x_evm: Use default log level

2020-02-28 Thread Tom Rini
On Fri, Feb 28, 2020 at 07:08:15PM +0530, Lokesh Vutla wrote: > > > On 26/02/20 10:48 PM, Sam Protsenko wrote: > > Commit 920e3343 ("configs: am335x_evm: Reduce size of SPL") reduces > > log level from 4 (default) to 3 in order to reduce SPL size. Arguably > > the disadvantages of such a deci

Re: [PATCH] configs: am335x_evm: Use default log level

2020-02-28 Thread Lokesh Vutla
On 26/02/20 10:48 PM, Sam Protsenko wrote: > Commit 920e3343 ("configs: am335x_evm: Reduce size of SPL") reduces > log level from 4 (default) to 3 in order to reduce SPL size. Arguably > the disadvantages of such a decision outweigh the benefits: > > (+) reducing SPL footprint by 1 KiB, b

RE: [PATCH 1/1] Kconfig: fix typos in CMD_BEDBUG description

2020-02-28 Thread Patrick DELAUNAY
Hi Heinrich > From: U-Boot On Behalf Of Heinrich Schuchardt > Sent: mardi 25 février 2020 21:44 > > Fix documentation bug reported by 'make refcheckdocs'. > > Signed-off-by: Heinrich Schuchardt > --- Reviewed-by: Patrick Delaunay Regards Patrick

RE: [PATCH 1/1] scripts: add documentation-file-ref-check

2020-02-28 Thread Patrick DELAUNAY
Hi Heinrich, > From: Heinrich Schuchardt > Sent: mardi 25 février 2020 20:52 > > 'make refcheckdocs' requires scripts/documentation-file-ref-check. > Adopt script from Linux v5.6-rc3. > > Signed-off-by: Heinrich Schuchardt > --- Reviewed-by: Patrick Delaunay It is just a copy of kernel scri

[PATCH 2/2] misc: i2c_eeprom: store pagesize instead of pagewidth in i2c_eeprom_drv_data

2020-02-28 Thread Masahiro Yamada
Associate the pagesize with compatible strings, and copy it to priv->pagesize. This is more straight-forward. Signed-off-by: Masahiro Yamada --- drivers/misc/i2c_eeprom.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/misc/i2c_eepr

[PATCH 1/2] misc: i2c_eeprom: remove pagewidth field from i2c_eeprom

2020-02-28 Thread Masahiro Yamada
This struct member is not used in any effective way. Remove it. Signed-off-by: Masahiro Yamada --- drivers/misc/i2c_eeprom.c | 8 +++- include/i2c_eeprom.h | 2 -- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c index

[PATCH 3/3] ARM: dts: uniphier: remove U-Boot own EEPROM compatible and property

2020-02-28 Thread Masahiro Yamada
The compatible string "i2c-eeprom" is U-Boot own compatible, which has never been approved by the DT community. "u-boot,i2c-offset-len" is also a U-Boot own hack. Linux adds "atmel,*" as generic compatibles, and U-Boot also followed it by commit d7e28918aa3f ("i2c_eeprom: Add reading support"). T

[PATCH 2/3] ARM: dts: uniphier: add reset-names to NAND controller node

2020-02-28 Thread Masahiro Yamada
Import Linux commits: 37f3e0096f71 ("ARM: dts: uniphier: add reset-names to NAND controller node") e98d5023fe1f ("arm64: dts: uniphier: add reset-names to NAND controller node") Signed-off-by: Masahiro Yamada --- arch/arm/dts/uniphier-ld11.dtsi | 3 ++- arch/arm/dts/uniphier-ld20.dtsi | 3 ++-

[PATCH 1/3] ARM: dts: uniphier: rename DT nodes to follow json-schema

2020-02-28 Thread Masahiro Yamada
Import the nodename changes I made in Linux for avoiding dt-schama warnings. This follows the $nodename patterns in the dt-schema. Signed-off-by: Masahiro Yamada --- arch/arm/dts/uniphier-ld11.dtsi | 6 +++--- arch/arm/dts/uniphier-ld20.dtsi | 8 arch/arm/dts/uniphier-ld4.dtsi | 10

Re: [RFC PATCH] serial: ns16550: Move PCI access from ofdata_to_platdata() to probe()

2020-02-28 Thread Bin Meng
Hi Wolfgang, On Fri, Feb 28, 2020 at 3:50 PM Bin Meng wrote: > > On Thu, Feb 27, 2020 at 5:36 PM Bin Meng wrote: > > > > On Tue, Feb 18, 2020 at 8:36 PM Wolfgang Wallner > > wrote: > > > > > > Currently the ofdata_to_platdata() method calls dev_read_addr_pci(), > > > which potentially accesses

[PATCH] dma: ti: k3-udma: Mark flow id as valid parameter for RX channel config

2020-02-28 Thread Lokesh Vutla
When flow id is not marked as valid, sysfw reads the register value to get the range of flow ids that are supported. Then compares the flow range with the U-Boot's host id. This will definitely fail as board configuration doesn't assign the full range to U-Boot's host id. In order to work around th

[PATCH] firmware: tisci: Drop all deprecated messages

2020-02-28 Thread Lokesh Vutla
SYSFW v2020.01 and later versions no longer supports the below messages: - TI_SCI_MSG_RM_RING_GET_CFG - TISCI_MSG_RM_UDMAP_TX_CH_GET_CFG 0x1206 - TISCI_MSG_RM_UDMAP_RX_CH_GET_CFG 0x1216 - TISCI_MSG_RM_UDMAP_FLOW_GET_CFG0x1232 - TISCI_MSG_RM_UDMAP_FLOW_SIZE_THRESH_GET_CFG0x1233 Ther

[PATCH] board: ti: k3: Update the sysfw image gen repository

2020-02-28 Thread Lokesh Vutla
Now k3-image-gen[0] is the official repository for generating sysfw.itb Update the same in AM65x and J721e README. [0] https://git.ti.com/cgit/k3-image-gen/k3-image-gen/ Signed-off-by: Lokesh Vutla --- board/ti/am65x/README | 2 +- board/ti/j721e/README | 2 +- 2 files changed, 2 insertions(+),

Re: [PATCH] ARM: zynq: Remove single comment about QSPI

2020-02-28 Thread Michal Simek
út 25. 2. 2020 v 15:32 odesílatel Michal Simek napsal: > > Very likely configs have been moved to Kconfig by scripts and this just > remains there that's why remove it. > > Signed-off-by: Michal Simek > --- > > include/configs/zynq-common.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [PATCH v2] ARM: zynq: Rename defconfig to be align with ZynqMP and Versal

2020-02-28 Thread Michal Simek
út 18. 2. 2020 v 17:04 odesílatel Michal Simek napsal: > > Just cosmetic change before real switch. > > Signed-off-by: Michal Simek > --- > > Changes in v2: > - Cover this new file by MAINTAINERS fragment > > board/xilinx/zynq/MAINTAINERS | 1 + > configs/{zynq_virt

Re: [PATCH] arm: xilinx: Fill DEVICE_TREE directly in Makefiles

2020-02-28 Thread Michal Simek
čt 13. 2. 2020 v 14:53 odesílatel Michal Simek napsal: > > DEVICE_TREE variable is not exported from dts/Makefile that's why it is > necessary to setup directly before use. > > Fixes: 312f2c5b14fa ("arm: xilinx: Use device tree which can be passed on cmd > line") > Signed-off-by: Michal Simek >

Re: [PATCH] net: zynq: Free allocated buffers in case of error

2020-02-28 Thread Michal Simek
čt 6. 2. 2020 v 16:04 odesílatel Michal Simek napsal: > > Driver probe function is called again and again in case of error. > Malloc space is getting full which is is reported by: > Insufficient RAM for page table: 0x15000 > 0x14000. > Please increase the size in get_page_table_size() > ### ERR

Re: [PATCH] net: phy: dp83867: Clean force link good bit

2020-02-28 Thread Michal Simek
čt 6. 2. 2020 v 16:03 odesílatel Michal Simek napsal: > > On Xilinx ZynqMP revA board initial value of PHYCR register is 0x5448 which > means FORCE_LINK_GOOD is already setup. Origin code was doing write but the > new code is doing read/modify/write and keep this bit untouched. That's why > ethern

Re: [PATCH] mtd: nand: Fix on-die ecc issues in arasan_nfc driver

2020-02-28 Thread Michal Simek
po 20. 1. 2020 v 9:48 odesílatel Michal Simek napsal: > > From: T Karthik Reddy > > Fixed wrong enumeration of nand_config structure. Added chip select > function before reading the nand chip for maf/dev id's, without this > unable to access id's from some of the micron chips. Also added a > prin

Re: [PATCH] versal: drivers: clk: Fix invalid clock name queries

2020-02-28 Thread Michal Simek
pá 17. 1. 2020 v 8:31 odesílatel Michal Simek napsal: > > From: Rajan Vaja > > The clock driver makes EEMI call to get the name of invalid clk > when executing versal_get_clock_info() function. This results in > error messages. > Added check for validating clock before saving clock attribute and

Re: [PATCH] net: zynq_gem: Use ulong instead of u32 data type

2020-02-28 Thread Michal Simek
čt 16. 1. 2020 v 8:54 odesílatel Michal Simek napsal: > > From: T Karthik Reddy > > flush_dcache_range() expects unsigned long in the arguments. Here u32 > variable is unable to hold the higher address value when ddr mapped > to higher addresses & flushing lower address dchache range instead > wh

Re: [PATCH 1/2] Makefile: Add environment variable DEVICE_TREE to header

2020-02-28 Thread Michal Simek
On 26. 02. 20 16:33, Simon Glass wrote: > Hi Michal, > > On Tue, 18 Feb 2020 at 09:02, Michal Simek wrote: >> >> Users have option to overwrite default device tree >> (CONFIG_DEFAULT_DEVICE_TREE) via environment variable DEVICE_TREE. >> >> Feature has been added long time ago by commit 74de8c9a16

  1   2   >