[PATCH 00/36] Tidy up the 'bd' command.

2020-05-04 Thread Simon Glass
The code for the 'bd' command never got the 'generic board' treatment many years ago when global_data and bd_info were converted. As a result it still has a lot of arch-specific duplication of generic code. This series aims to make as much code in this file generic as possible, so that it is easy

RE: [PATCH 10/13] imx: load calibration parameters from fuse for i.MX8MP

2020-05-04 Thread Peng Fan
> Subject: Re: [PATCH 10/13] imx: load calibration parameters from fuse for > i.MX8MP > > Hi Peng, > > On Sun, May 3, 2020 at 8:39 PM Peng Fan wrote: > > > 5.4.3 upstream kernel + latest upstream boot? > > No, I meant imx_5.4.3_2.0.0 NXP kernel + latest upstream U-Boot. > > > Disable

Re: [PATCH v10 14/21] riscv: Clean up IPI initialization code

2020-05-04 Thread Rick Chen
Hi Sean > The previous IPI code initialized the device whenever the first call was > made to a riscv_*_ipi function. This made it difficult to determine when > the IPI device was initialized. This patch introduces a new function > riscv_init_ipi. It is called once during arch_cpu_init_dm. Before

Re: [PATCH 12/36] bdinfo: riscv: Use the generic bd command

2020-05-04 Thread Rick Chen
> From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Simon Glass > Sent: Tuesday, May 05, 2020 7:17 AM > To: U-Boot Mailing List > Cc: Tom Rini; Simon Glass; Bin Meng; Heiko Schocher > Subject: [PATCH 12/36] bdinfo: riscv: Use the generic bd command > > This arch has none of its own

Re: [PATCH 11/36] bdinfo: nds32: Use the generic bd command

2020-05-04 Thread Rick Chen
> From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Simon Glass > Sent: Tuesday, May 05, 2020 7:17 AM > To: U-Boot Mailing List > Cc: Tom Rini; Simon Glass; Bin Meng; Heiko Schocher; Macpaul Lin > Subject: [PATCH 11/36] bdinfo: nds32: Use the generic bd command > > This arch has none

Re: [PATCH 02/36] bdinfo: riscv: Use generic bd_info

2020-05-04 Thread Rick Chen
> From: Simon Glass [mailto:s...@chromium.org] > Sent: Tuesday, May 05, 2020 7:17 AM > To: U-Boot Mailing List > Cc: Tom Rini; Simon Glass; Joe Hershberger; Rick Jian-Zhi Chen(陳建志) > Subject: [PATCH 02/36] bdinfo: riscv: Use generic bd_info > > At present riscv still uses its own private bd_info

Re: [PATCH 01/36] bdinfo: nds32: Use generic bd_info

2020-05-04 Thread Rick Chen
> From: Simon Glass [mailto:s...@chromium.org] > Sent: Tuesday, May 05, 2020 7:17 AM > To: U-Boot Mailing List > Cc: Tom Rini; Simon Glass; Joe Hershberger; Macpaul Lin; Rick Jian-Zhi > Chen(陳建志) > Subject: [PATCH 01/36] bdinfo: nds32: Use generic bd_info > > At present nds32 still uses its own

[PATCH 36/36] bdinfo: x86: vesa: Update fb_base to the correct value

2020-05-04 Thread Simon Glass
Set this value in global_data so that it is reported correctly on x86 boards. In fact, space is allocated for the frame buffer even though it is not used. The FSP picks the address itself, which is why the current value is wrong. Signed-off-by: Simon Glass --- arch/x86/lib/fsp/fsp_graphics.c

[PATCH 35/36] bdinfo: dm: Update fb_base when using driver model

2020-05-04 Thread Simon Glass
Update this value with the address of a video device so that it shows with the 'bd' command. It would be better to obtain the address from the uclass by looking in struct video_uc_platdata for each device. We can move over to that once DM_VIDEO migration is complete. Signed-off-by: Simon Glass

[PATCH 31/36] bdinfo: ppc: Move PPC-specific info into its own file

2020-05-04 Thread Simon Glass
We don't really want to have PPC-specific code in a generic file. Create a new arch-specific function to hold it, and move it into that. Make the function weak so that any arch can implement it. Signed-off-by: Simon Glass --- arch/powerpc/lib/Makefile | 2 ++ arch/powerpc/lib/bdinfo.c | 41

[PATCH 33/36] bdinfo: m68k: ppc: Move arch-specific code from bdinfo

2020-05-04 Thread Simon Glass
We don't have an easy way to share these three lines of code with two architectures. We also want to make it clear that this code is actually arch-specific. So just duplicate it in each arch-specific file. Signed-off-by: Simon Glass --- arch/m68k/lib/bdinfo.c| 5 +

[PATCH 32/36] bdinfo: m68k: Move m68k-specific info into its own file

2020-05-04 Thread Simon Glass
We don't really want to have m68k-specific code in a generic file. Create a new arch-specific function to hold it, and move it into that. Make the function weak so that any arch can implement it. Signed-off-by: Simon Glass --- arch/m68k/lib/Makefile | 1 + arch/m68k/lib/bdinfo.c | 29

[PATCH 30/36] bdinfo: arm: Move ARM-specific info into its own file

2020-05-04 Thread Simon Glass
We don't really want to have ARM-specific code in a generic file. Create a new arch-specific function to hold it, and move it into that. Make the function weak so that any arch can implement it. Signed-off-by: Simon Glass --- arch/arm/lib/Makefile | 1 + arch/arm/lib/bdinfo.c | 51

[PATCH 29/36] bdinfo: Export some basic printing functions

2020-05-04 Thread Simon Glass
At present the functions to print a number and a frequency are static. We want to move some of the code in here to an arch-specific file. For consistency that code should use these same functions. So export them with an appropriate name. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 78

[PATCH 34/36] bdinfo: Update the file comments

2020-05-04 Thread Simon Glass
Update the comment at the top of the file to indicate what this file does. Also drop the line at the bottom and an unnecessary header include. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c

[PATCH 25/36] bdinfo: net: ppc: Drop prints for CONFIG_HAS_ETHn

2020-05-04 Thread Simon Glass
These config options have not been migrated to Kconfig. This should be handled using driver model, iterating over the available Ethernet devices. For now, remove the code. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 15 --- 1 file changed, 15 deletions(-) diff --git

[PATCH 24/36] bdinfo: net: ppc: Drop bi_enet1addr and other similar info

2020-05-04 Thread Simon Glass
These values were 'old' in 2013 so it should be safe to remove them. They are never set in U-Boot anyway, so the values will always be zero. Signed-off-by: Simon Glass --- common/board_r.c | 16 +--- include/asm-generic/u-boot.h | 17 - 2 files changed,

[PATCH 28/36] bdinfo: net: Inline print_eth_ip_addr()

2020-05-04 Thread Simon Glass
This function only has two lines of code now, so inline it. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index e6237daf93..e30d530411 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@

[PATCH 26/36] bdinfo: net: Drop legacy ethernet bdinfo

2020-05-04 Thread Simon Glass
This code pre-dates driver model and the migration date is nearly upon us. Pare the print_eths() function down and enable it for driver model, since it works correctly. The IP address is already printed in print_eth_ip_addr() so we can remove that. Signed-off-by: Simon Glass --- cmd/bdinfo.c

[PATCH 27/36] bdinfo: net: Inline print_eths()

2020-05-04 Thread Simon Glass
This function has only one line of code so inline it. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index ba69575fc2..e6237daf93 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@ -34,11 +34,6 @@

[PATCH 23/36] bdinfo: Drop print_cpu_word_size()

2020-05-04 Thread Simon Glass
This function only has one line of code in it so inline it. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index f22dc7a129..d0afef5b5e 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@ -15,11

[PATCH 22/36] bdinfo: Drop print_bi_flash()

2020-05-04 Thread Simon Glass
This function only has three lines of code in it so inline it. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index b65eec332d..f22dc7a129 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@

[PATCH 18/36] bdinfo: Drop print_std_bdinfo()

2020-05-04 Thread Simon Glass
Everything in this function is standard now so it serves no purpose. Move it into the generic do_bdinfo() function. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index

[PATCH 21/36] bdinfo: Drop print_bi_boot_params()

2020-05-04 Thread Simon Glass
This function only has one line of code in it so inline it. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 5ffd86e508..b65eec332d 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@ -72,12

[PATCH 20/36] bdinfo: sh: arc: Drop arch-specific print_bi_mem()

2020-05-04 Thread Simon Glass
It isn't worth having arch-specific code for such minor output differences. In fact it is better if all archs are consistent. Drop the arch-specific code in print_bi_mem() and inline it to avoid a two-line function. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 17 ++--- 1 file

[PATCH 19/36] bdinfo: ppc: Drop arch-specific print_baudrate()

2020-05-04 Thread Simon Glass
This function outputs the same basic info. Since the baud rate is commonly 115200 these is often no difference. Drop the arch-specific code and inline it to avoid a one-line function. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-)

[PATCH 17/36] bdinfo: Drop unnecessary inline on functions

2020-05-04 Thread Simon Glass
This serves no purpose since the compiler will inline the functions automatically. Drop use of inline in this file. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index

[PATCH 14/36] bdinfo: Drop the option to not use the generic 'bd' command

2020-05-04 Thread Simon Glass
Now that all architectures are using the generic do_bdinfo(), drop the option to not use it. When new architectures are added, they will get at least some useful information from the generic implementation. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 59

[PATCH 16/36] bdinfo: microblaze: sh: nios2: Drop arch-specific flash info

2020-05-04 Thread Simon Glass
The differences these architectures have are minor and not worth the extra code. Use the generic version always. Tidy up the code style by removing unnecessary tabs. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff

[PATCH 15/36] bdinfo: Drop unused __maybe_unused

2020-05-04 Thread Simon Glass
Some of these are not needed now. Drop them to avoid cluttering the code. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 13b4f2ebba..204d4c5db1 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c

[PATCH 12/36] bdinfo: riscv: Use the generic bd command

2020-05-04 Thread Simon Glass
This arch has none of its own info to show. Move it over to use the generic do_bdinfo(). Signed-off-by: Simon Glass --- cmd/bdinfo.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 6a2bbfb348..0e96dd619c 100644 ---

[PATCH 11/36] bdinfo: nds32: Use the generic bd command

2020-05-04 Thread Simon Glass
This arch has none of its own info to show. Move it over to use the generic do_bdinfo(). Signed-off-by: Simon Glass --- cmd/bdinfo.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index dce24b43fa..6a2bbfb348 100644 ---

[PATCH 13/36] bdinfo: arm: Use the generic bd command

2020-05-04 Thread Simon Glass
Unfortunately ARM has a lot of special stuff. Move it into the generic function for now, so we can have it all in one place. Add in the frame-buffer printout, since it supports driver model too. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 250

[PATCH 09/36] bdinfo: x86: Use the generic bd command

2020-05-04 Thread Simon Glass
This arch shows 'ethspeed' info but only the freescale drivers use it, so it can be dropped. It also calls print_bi_dram() which is safe to call from any arch since it has an #ifdef inside it. Add this to the generic do_bdinfo() and move x86 over to use it. Put it first since pytests rely on

[PATCH 03/36] bdinfo: m68k: Drop bd_info->bi_ipbfreq

2020-05-04 Thread Simon Glass
This field is not used anymore. Drop it. Signed-off-by: Simon Glass --- include/asm-generic/u-boot.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/asm-generic/u-boot.h b/include/asm-generic/u-boot.h index cc94d39069..be0014c3b3 100644 --- a/include/asm-generic/u-boot.h +++

[PATCH 10/36] bdinfo: sandbox: Use the generic bd command

2020-05-04 Thread Simon Glass
Sandbox has a printout of 'FB base' but this code is not used since sandbox uses driver model for everything. Move sandbox over to use the generic do_bdinfo(). Signed-off-by: Simon Glass --- cmd/bdinfo.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git

[PATCH 07/36] bdinfo: microblaze: Use the generic bd command

2020-05-04 Thread Simon Glass
Microblaze prints out ethernet and FDT information. This is useful to most archs, so move it into the generic code and move microblaze over to use it. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 30 +++--- 1 file changed, 7 insertions(+), 23 deletions(-) diff --git

[PATCH 06/36] bdinfo: nios2: Use the generic bd command

2020-05-04 Thread Simon Glass
Nios2 currently has some code to output SRAM information which is behind an #ifdef. No nios2 boards define this option, so the code can be removed. Move Nios2 over to use the generic function. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 19 +-- 1 file changed, 1

[PATCH 08/36] bdinfo: sh: Use the generic bd command

2020-05-04 Thread Simon Glass
This arch has no code that is not already in the generic function. Drop the arch-specific function and change sh over to use the generic one. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/cmd/bdinfo.c

[PATCH 05/36] bdinfo: mips: Use the generic bd command

2020-05-04 Thread Simon Glass
MIPS currently has a few extra things which are generally useful. Add them to the generic function and move MIPS over to use it. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index

[PATCH 04/36] bdinfo: xtensa: Create a generic do_bdinfo for xtensa

2020-05-04 Thread Simon Glass
This arch uses only the generic function. It would be nice if all the archs did the same. As a first step, create a new generic function for the 'bd' command and make xtensa use it. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 14 ++ 1 file changed, 10 insertions(+), 4

[PATCH 02/36] bdinfo: riscv: Use generic bd_info

2020-05-04 Thread Simon Glass
At present riscv still uses its own private bd_info struct. Move it over to use the generic one like other archs. Signed-off-by: Simon Glass --- arch/riscv/include/asm/u-boot.h | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git

[PATCH 01/36] bdinfo: nds32: Use generic bd_info

2020-05-04 Thread Simon Glass
At present nds32 still uses its own private bd_info struct. Move it over to use the generic one like other archs. Signed-off-by: Simon Glass --- arch/nds32/include/asm/u-boot.h | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git

[PATCH] mpc83xx: remove redundant MPC83xx_RESET #define

2020-05-04 Thread Rasmus Villemoes
This macro is only used (tested for existence) in mpc83xx.c, which unconditionally includes mpc83xx.h where it is unconditionally defined. Removing it makes the remaining code easier to read. Signed-off-by: Rasmus Villemoes --- arch/powerpc/cpu/mpc83xx/cpu.c | 24

Re: [U-Boot] [PATCH v2 13/18] autoboot: Tidy up use of menukey

2020-05-04 Thread Da Xue
Hi Simon, I think there's something funny going on with this line: #define AUTOBOOT_MENUKEY CONFIG_USE_AUTOBOOT_MENUKEY Did you mean: #define AUTOBOOT_MENUKEY CONFIG_AUTOBOOT_MENUKEY? Best, Da On Mon, May 4, 2020 at 5:26 PM Da Xue wrote: > Hi Simon, > > The Kconfig doesn't match the

Re: [U-Boot] [PATCH v2 13/18] autoboot: Tidy up use of menukey

2020-05-04 Thread Da Xue
Hi Simon, The Kconfig doesn't match the common/autoboot.c. Kconfig is using AUTOBOOT_USE_MENUKEY and common/autoboot.c is CONFIG_USE_AUTOBOOT_MENUKEY. Best, Da On Sat, Jul 20, 2019 at 11:56 PM Simon Glass wrote: > Move the variable to the top of the file and adjust the code which uses it > to

[PATCH v4 0/5] TI Ethernet PHY changes

2020-05-04 Thread Dan Murphy
Hello The addition of the DP83867 driver to uboot was done in a generic way that made it a bit difficult to bring in new PHY drivers. The difficulty came in the config flags and the phy_init function. The change is to make the flags and init for the DP83867 more specific to the DP83867 device

[PATCH v4 5/5] net: phy: Add DP8382x phy registration to TI PHY init

2020-05-04 Thread Dan Murphy
Add the DP8382X generic PHY registration to the TI PHY init file. Acked-by: Michal Simek Signed-off-by: Dan Murphy --- drivers/net/phy/Kconfig | 7 +++ drivers/net/phy/ti_phy_init.c | 83 +++ 2 files changed, 90 insertions(+) diff --git

[PATCH v4 4/5] net: phy: Add support for TI PHY init

2020-05-04 Thread Dan Murphy
ti_phy_init function was allocated to the DP83867 PHY. This function name is to generic for a specific PHY. The function can be moved to a TI specific file that can register all TI PHYs that are defined in the defconfig. The ti_phy_init file will contain all TI PHYs initialization so that only

[PATCH v4 3/5] net: phy: Add helper routines to set and clear bits

2020-05-04 Thread Dan Murphy
Add phy_set/clear_bit helper routines so that ported drivers from the kernel can use these functions. Acked-by: Michal Simek Signed-off-by: Dan Murphy --- include/phy.h | 54 +++ 1 file changed, 54 insertions(+) diff --git a/include/phy.h

[PATCH v4 1/5] net: phy: Add missing kernel doc to phy functions

2020-05-04 Thread Dan Murphy
Add kernel doc to the phy_read/write utility functions in phy.h Acked-by: Michal Simek Signed-off-by: Dan Murphy --- include/phy.h | 39 +++ 1 file changed, 39 insertions(+) diff --git a/include/phy.h b/include/phy.h index b5de14cbfc29..c1f6509e42fc 100644

[PATCH v4 2/5] net: phy: Fix kernel doc issues in phy.h

2020-05-04 Thread Dan Murphy
Fix kernel doc warnings in phy.h. Mostly the warnings were due to the return missing the semi-colon. Acked-by: Michal Simek Signed-off-by: Dan Murphy --- include/phy.h | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/include/phy.h b/include/phy.h index

[PATCH 6/6] rtc: add rtc command

2020-05-04 Thread Rasmus Villemoes
Mostly as an aid for debugging RTC drivers, provide a command that can be used to read/write arbitrary registers (assuming the driver provides the read8/write8 methods or their _array variants). Signed-off-by: Rasmus Villemoes --- cmd/Kconfig | 6 ++ cmd/Makefile | 1 + cmd/rtc.c| 153

[PATCH 5/6] rtc: pcf2127: provide ->write8_array method

2020-05-04 Thread Rasmus Villemoes
Signed-off-by: Rasmus Villemoes --- drivers/rtc/pcf2127.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/rtc/pcf2127.c b/drivers/rtc/pcf2127.c index b3f6de8496..227ab09880 100644 --- a/drivers/rtc/pcf2127.c +++ b/drivers/rtc/pcf2127.c @@ -43,6 +43,12 @@ static int

[PATCH 4/6] rtc: pcf2127: provide ->read8_array method

2020-05-04 Thread Rasmus Villemoes
This simply consists of renaming the existing pcf2127_read_reg() helper to follow the naming of the other methods (i.e. pcf2127_rtc_) and changing the type of its "len" parameter. Signed-off-by: Rasmus Villemoes --- drivers/rtc/pcf2127.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH 3/6] rtc: fall back to ->{read, write}8_array if ->{read, write}8 are not provided

2020-05-04 Thread Rasmus Villemoes
Similar to how the rtc_{read,write}8_array functions fall back to using the {read,write}8 methods, do the opposite in the rtc_{read,write}8 functions. This way, each driver only needs to provide either ->read8 or ->read8_array to make both rtc_read8() and rtc_read8_array() work - without this, a

[PATCH 1/6] rtc: add rtc_read8_array helper and ->read8_array method

2020-05-04 Thread Rasmus Villemoes
Some users may want to read multiple consecutive 8-bit registers. Instead of each caller having to implement the loop, provide a rtc_read8_array() helper. Also, allow a driver to provide a read8_array method, which can be more efficient than reading one register at a time. Signed-off-by: Rasmus

[PATCH 2/6] rtc: add rtc_write8_array() helper

2020-05-04 Thread Rasmus Villemoes
Similar to the rtc_read8_array(), introduce a helper that allows the caller to write multiple consecutive 8-bit registers with one call. If the driver provides the ->write8_array method, use that, otherwise loop using ->write8. Signed-off-by: Rasmus Villemoes --- drivers/rtc/rtc-uclass.c | 18

[PATCH 0/6] rtc: add rtc_{read,write}8_array and rtc command

2020-05-04 Thread Rasmus Villemoes
I need access to registers other than just the timekeeping ones of the pcf2127, so I wanted to implement ->read8 and ->write8. But for testing these it appeared there was no convenient way to invoke those from the shell, so I also ended up adding such a command. Also, it seemed more natural to

[PATCH v4 1/4] patman: Suppress empty changelog entries

2020-05-04 Thread Sean Anderson
Patman outputs a line for every edition of the series in every patch, regardless of whether any changes were made. This can result in many redundant lines in patch changelogs, especially when a patch did not exist before a certain revision. For example, the existing behaviour could result in a

[PATCH v4 4/4] patman: Modify functional tests for new behavior

2020-05-04 Thread Sean Anderson
This patch adds or modifies functional tests for the Cover-changes, Commit-changes, and Series-process-log tags in order to account for new behavior added in the previous few patches. The '(no changes since v1)' case is not tested for, since that would need an additional commit to test in addition

[PATCH v4 2/4] patman: Add new tags for finer-grained changelog control

2020-05-04 Thread Sean Anderson
By default patman generates a combined changelog for the cover letter. This may not always be desirable. Many patches may have the same changes. These can be coalesced with "Series-process-log: uniq", but this is imperfect. Similar changes like "Move foo to patch 7" will not be merged with the

[PATCH v4 3/4] patman: Support multi-line changes in changelogs

2020-05-04 Thread Sean Anderson
This patch adds support to multi-line changes. That is, if one has a line in a changelog like - Do a thing but it spans multiple lines Using Series-process-log sort would sort as if those lines were unrelated. With this patch, any change line starting with whitespace will be considered part of

[PATCH v4 0/4] patman: Add changelog customization options

2020-05-04 Thread Sean Anderson
This series adds a few changes I have been using locally as new tags for patman. This series has itself been developed using these patches, and the unprocessed commits can be viewed at [1]. [1] https://github.com/Forty-Bot/u-boot/tree/patman Changes in v4: - Document ParseVersion - Fix

Re: [PATCH v3 2/4] patman: Suppress empty changelog entries

2020-05-04 Thread Simon Glass
Hi Sean, On Mon, 4 May 2020 at 10:59, Sean Anderson wrote: > > On 5/4/20 10:39 AM, Simon Glass wrote: > > Hi Sean, > > > > On Sun, 3 May 2020 at 15:55, Sean Anderson wrote: > >> > >> Patman outputs a line for every edition of the series in every patch, > >> regardless of whether any changes

Re: [PATCH v5 1/2] drivers: gpio: add broadcom iproc gpio driver support

2020-05-04 Thread Simon Glass
Hi Rayagonda, On Mon, 4 May 2020 at 10:00, Rayagonda Kokatanur wrote: > > Add gpio driver support for Broadcom iproc-based socs. > This seems to be missing a change log. Can I suggest using patman to make this automatic? > Signed-off-by: Rayagonda Kokatanur > Signed-off-by: Sheetal Tigadoli

Re: [PATCH 1/4] kbuild: efi: Avoid rebuilding efi targets

2020-05-04 Thread Heinrich Schuchardt
On 5/4/20 2:38 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Add a couple of missing targets so that helloworld and other efi targets > are not needlessly rebuilt. > > CC: Heinrich Schuchardt > Signed-off-by: Jan Kiszka Tested-by: Heinrich Schuchardt > --- > lib/efi_loader/Makefile | 1 + >

Re: [PATCH 1/2] arm: mvebu: armada-370-xp.dtsi: add u-boot,dm-pre-reloc to spi0

2020-05-04 Thread Ezra Buehler
Hi Chris, > On 4 May 2020, at 10:04, Chris Packham wrote: > > I think this would be better in the specific board dts files. Not every > platform will want this in spl. Thanks for the input, I can do that. However, please note that before, the "spi0" node was under "internal-regs" which had

Re: [PATCH] clk: Fix clk func names in comments

2020-05-04 Thread Jagan Teki
On Fri, May 1, 2020 at 11:45 PM Jagan Teki wrote: > > clk function names in comments should be prefix with > clk instead of clock. > > Fix it. > > Cc: Simon Glass > Cc: Tom Rini > Signed-off-by: Jagan Teki > --- + Lukasz

Re: Please pull u-boot-marvell/master

2020-05-04 Thread Tom Rini
On Mon, May 04, 2020 at 08:54:26AM +0200, Stefan Roese wrote: > Hi Tom, > > please pull these 2 MVEBU related fixes. > > Here the Azure build, without any issues: > > https://dev.azure.com/sr0718/u-boot/_build/results?buildId=6=results > > Thanks, > Stefan > > The following changes since

Re: Please pull u-boot-x86

2020-05-04 Thread Tom Rini
On Mon, May 04, 2020 at 05:31:53PM +0800, Bin Meng wrote: > Hi Tom, > > This PR includes the following x86 changes for v2020.07 release: > > - Support 64-bit U-Boot as the payload for coreboot x86 > > The following changes since commit c693f212c5b0433b3a49a89d87cbff28bf78eb87: > > Merge

Re: [GIT PULL] Pull request: u-boot-imx u-boot-imx-20200502

2020-05-04 Thread Tom Rini
On Sat, May 02, 2020 at 11:25:21AM +0200, Stefano Babic wrote: > Hi Tom, > > please pull form u-boot-imx, thanks ! > > The following changes since commit 78021b63373de32335bd204471d6cb7c7e18bc52: > > Merge tag 'efi-2020-07-rc2' of > https://gitlab.denx.de/u-boot/custodians/u-boot-efi

Re: [PATCH v8 00/14] Add support for MediaTek xHCI host controller

2020-05-04 Thread Tom Rini
On Mon, May 04, 2020 at 06:52:17PM +0200, Frank Wunderlich wrote: > > > Am 2. Mai 2020 12:32:56 MESZ schrieb Marek Vasut : > >Applied, thanks. > > Hi Tom, > > Can you merge it too? When Marek sends me a PR with it, yes. -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 4/5] net: phy: Add support for TI PHY init

2020-05-04 Thread Dan Murphy
Michal On 5/4/20 4:46 AM, Michal Simek wrote: On 30. 04. 20 18:30, Dan Murphy wrote: ti_phy_init function was allocated to the DP83867 PHY. This function name is to generic for a specific PHY. The function can be moved to a TI specific file that can register all TI PHYs that are defined in

Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-04 Thread Simon Glass
Hi Heiko, On Mon, 4 May 2020 at 09:40, Heiko Stübner wrote: > > Am Montag, 4. Mai 2020, 16:17:52 CEST schrieb Simon Glass: > > +Tom Rini > > > > On Sun, 3 May 2020 at 05:26, Heiko Stuebner wrote: > > > > > > From: Heiko Stuebner > > > > > > To fill the exponent field of the rsa_public_key

Re: [PATCH v3 2/4] patman: Suppress empty changelog entries

2020-05-04 Thread Sean Anderson
On 5/4/20 10:39 AM, Simon Glass wrote: > Hi Sean, > > On Sun, 3 May 2020 at 15:55, Sean Anderson wrote: >> >> Patman outputs a line for every edition of the series in every patch, >> regardless of whether any changes were made. This can result in many >> redundant lines in patch changelogs,

Re: [PATCH v8 00/14] Add support for MediaTek xHCI host controller

2020-05-04 Thread Frank Wunderlich
Am 2. Mai 2020 12:32:56 MESZ schrieb Marek Vasut : >Applied, thanks. Hi Tom, Can you merge it too? Regards Frank regards Frank

Re: [PATCH] cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

2020-05-04 Thread Stefan Roese
On 04.05.20 13:54, Michal Simek wrote: There is no real need to exactly define space for saving patterns for alternate memory test. It is much easier to allocate space on the stack and use it instead of trying to find out space where pattern should be saved. For example if you want to test the

Re: [PATCH] cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

2020-05-04 Thread Simon Glass
On Mon, 4 May 2020 at 05:54, Michal Simek wrote: > > There is no real need to exactly define space for saving patterns for > alternate memory test. It is much easier to allocate space on the stack and > use it instead of trying to find out space where pattern should be saved. > > For example if

[PATCH] cmd: mem: Remove CONFIG_SYS_MEMTEST_SCRATCH mapping

2020-05-04 Thread Michal Simek
There is no real need to exactly define space for saving patterns for alternate memory test. It is much easier to allocate space on the stack and use it instead of trying to find out space where pattern should be saved. For example if you want to test the whole DDR memory you can't save patter to

[PATCH v5 1/2] drivers: gpio: add broadcom iproc gpio driver support

2020-05-04 Thread Rayagonda Kokatanur
Add gpio driver support for Broadcom iproc-based socs. Signed-off-by: Rayagonda Kokatanur Signed-off-by: Sheetal Tigadoli --- drivers/gpio/Kconfig | 11 ++ drivers/gpio/Makefile | 1 + drivers/gpio/iproc_gpio.c | 275 ++ 3 files changed, 287

[PATCH v5 0/2] add brcm iproc gpio driver

2020-05-04 Thread Rayagonda Kokatanur
Add support for broadcom iproc gpio driver. Changes from v4: -Address review comments from Simon Glass, Check for function return value. Changes from v3: -Address review comments from Simon Glass, Rearrange header file, Add struct comment taking about members, Use clrsetbits_le32(),

[PATCH v5 2/2] gpio: do not include on TARGET_BCMNS3

2020-05-04 Thread Rayagonda Kokatanur
As no gpio.h is defined for this architecture, to avoid compilation failure, do not include for arch bcmns3. Signed-off-by: Rayagonda Kokatanur Reviewed-by: Simon Glass --- arch/arm/include/asm/gpio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

RE: [PATCH v7 18/22] configs: fu540: Add config options for U-Boot SPL

2020-05-04 Thread Pragnesh Patel
Hi Jagan, >-Original Message- >From: Jagan Teki >Sent: 02 May 2020 22:22 >To: Pragnesh Patel >Cc: U-Boot-Denx ; Atish Patra >; Palmer Dabbelt ; Bin >Meng ; Paul Walmsley ; >Troy Benjegerdes ; Anup Patel >; Sagar Kadam ; Rick Chen >; Palmer Dabbelt >Subject: Re: [PATCH v7 18/22]

Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-04 Thread Heiko Stübner
Am Montag, 4. Mai 2020, 16:17:52 CEST schrieb Simon Glass: > +Tom Rini > > On Sun, 3 May 2020 at 05:26, Heiko Stuebner wrote: > > > > From: Heiko Stuebner > > > > To fill the exponent field of the rsa_public_key struct, rsa_mod_exp_sw > > did a cast to uint64_t of the key_prop->public_exponent

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Fabio Estevam
On Mon, May 4, 2020 at 12:21 PM Harald Seiler wrote: > With or without the revert? When I change the defconfig like: --- a/configs/imx8mp_evk_defconfig +++ b/configs/imx8mp_evk_defconfig @@ -57,7 +57,9 @@ CONFIG_ENV_IS_IN_MMC=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Harald Seiler
On Mon, 2020-05-04 at 12:18 -0300, Fabio Estevam wrote: > On Mon, May 4, 2020 at 12:05 PM Harald Seiler wrote: > > > "Failed to find clock node. Check device tree" comes from spl_board_init() > > in board/freescale/imx8mp_evk/spl.c; line 56: > > > > ret =

Re: [PATCH] dm: serial: introduce puts hook

2020-05-04 Thread Simon Glass
Hi Peng, On Mon, 4 May 2020 at 08:24, Peng Fan wrote: > > Hi Simon, > > > Subject: Re: [PATCH] dm: serial: introduce puts hook > > > > Hi Peng, > > > > On Sun, 3 May 2020 at 06:42, Peng Fan wrote: > > > > > > Introduce puts hook for dm serial driver. > > > > > > Signed-off-by: Peng Fan > > >

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Fabio Estevam
On Mon, May 4, 2020 at 12:05 PM Harald Seiler wrote: > "Failed to find clock node. Check device tree" comes from spl_board_init() > in board/freescale/imx8mp_evk/spl.c; line 56: > > ret = uclass_get_device_by_name(UCLASS_CLK, >

Re: [PATCH v2 2/2] arm: bcm283x: serial: Move ofdata reading to probe() method

2020-05-04 Thread Matthias Brugger
On 23/03/2020 04:15, Simon Glass wrote: > We cannot rely on a parent bus that needs to be probed, until we know that > it is probed. That means that code in the ofdata_to_platdata() method > cannot rely on the parent bus being probed. > > Move the ofdata code in the two serial drivers into a

Re: [PATCH v2 1/2] arm: dts: bcm283x: Allow UARTs to work before relocation

2020-05-04 Thread Matthias Brugger
On 23/03/2020 04:15, Simon Glass wrote: > At present the pinctrl nodes are not enabled in pre-relocation U-Boot so > the UARTs do not correctly select the pinconfig to enable the UART pins. > Fix this so that the U-Boot banner is printed. > > This fixes serial output on rpi_3b_32b with the

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Harald Seiler
Hello, On Mon, 2020-05-04 at 16:32 +0200, Marek Vasut wrote: > On 5/4/20 4:27 PM, Fabio Estevam wrote: > > Hi, > > > > On Wed, Apr 29, 2020 at 10:05 AM Harald Seiler wrote: > > > From: Marek Vasut > > > > > > Board files should not re-implement do_reset() to work around this > > > function

Re: [PATCH v3 4/4] patman: Support multi-line changes in changelogs

2020-05-04 Thread Simon Glass
On Sun, 3 May 2020 at 15:55, Sean Anderson wrote: > > This patch adds support to multi-line changes. That is, if one has a line > in a changelog like > - Do a thing but > it spans multiple lines > Using Series-process-log sort would sort as if those lines were unrelated. > With this patch, any

Re: [PATCH v3 2/4] patman: Suppress empty changelog entries

2020-05-04 Thread Simon Glass
Hi Sean, On Sun, 3 May 2020 at 15:55, Sean Anderson wrote: > > Patman outputs a line for every edition of the series in every patch, > regardless of whether any changes were made. This can result in many > redundant lines in patch changelogs, especially when a patch did not exist > before a

Re: [PATCH v3 3/4] patman: Add new tags for finer-grained changelog control

2020-05-04 Thread Simon Glass
HI Sean, On Sun, 3 May 2020 at 15:55, Sean Anderson wrote: > > By default patman generates a combined changelog for the cover letter. This > may not always be desireable. desirable > > Many patches may have the same changes. These can be coalesced with > "Series-process-log: uniq", but this is

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Marek Vasut
On 5/4/20 4:27 PM, Fabio Estevam wrote: > Hi, > > On Wed, Apr 29, 2020 at 10:05 AM Harald Seiler wrote: >> >> From: Marek Vasut >> >> Board files should not re-implement do_reset() to work around this >> function not being defined in for specific configurations. Rather, >> the fix is to compile

RE: [PATCH 1/4] sata: ahsata: Fix resource leak

2020-05-04 Thread Peng Fan
Hi Simon, > Subject: Re: [PATCH 1/4] sata: ahsata: Fix resource leak > > On Sun, 3 May 2020 at 08:04, Peng Fan wrote: > > > > From: Ye Li > > > > Fix coverity issue CID 3606684: Resource leak (RESOURCE_LEAK) > > leaked_storage: Variable uc_priv going out of scope leaks the storage > > it

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Fabio Estevam
Hi, On Wed, Apr 29, 2020 at 10:05 AM Harald Seiler wrote: > > From: Marek Vasut > > Board files should not re-implement do_reset() to work around this > function not being defined in for specific configurations. Rather, > the fix is to compile in drivers which implement this properly. > This

Re: [PATCH v2] imx: support for conga-QMX8 board

2020-05-04 Thread Oliver Graute
On 04/05/20, Stefano Babic wrote: > Hi Oliver, > > this was quite lost under the flood of other patches, sorry for that. > What about to rebase and repost it ? > will rebase and rework that patch, as soon as I'am back in office and get access to that board again. Best regards, Oliver

RE: [PATCH] dm: serial: introduce puts hook

2020-05-04 Thread Peng Fan
Hi Simon, > Subject: Re: [PATCH] dm: serial: introduce puts hook > > Hi Peng, > > On Sun, 3 May 2020 at 06:42, Peng Fan wrote: > > > > Introduce puts hook for dm serial driver. > > > > Signed-off-by: Peng Fan > > --- > > drivers/serial/serial-uclass.c | 13 +++-- > > include/serial.h

  1   2   3   >