Re: [PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

2020-06-07 Thread Michal Simek
On 07. 06. 20 7:36, Sean Anderson wrote: > This reverts commit 0486497e2b5f4d36fa968a1a60fea358cbf70b65. > > The strtoul has well-defined semantics. It is defined by the C standard and > POSIX. To quote the relevant section of the man pages, > >> If base is zero or 16, the string may then include

[PATCH 2/2] config: lx2160/2a: enable dspi

2020-06-07 Thread Qiang Zhao
From: Zhao Qiang Enable dspi in lx2160aqds tfa defconfig Enable CONFIG_SPI_FLASH_SST/EON in config file. Signed-off-by: Zhao Qiang --- configs/lx2160aqds_tfa_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/lx2160aqds_tfa_defconfig b/configs/lx2160aqds_tfa_defconfig ind

[PATCH 1/2] armv8: dts: fsl-lx2160a: add flash node under dspi to qds dts

2020-06-07 Thread Qiang Zhao
From: Zhao Qiang Add flash node under dspi into fsl-lx2160a-qds.dtsi Signed-off-by: Zhao Qiang --- arch/arm/dts/fsl-lx2160a-qds.dtsi | 99 +++ 1 file changed, 99 insertions(+) diff --git a/arch/arm/dts/fsl-lx2160a-qds.dtsi b/arch/arm/dts/fsl-lx2160a-qds.dt

[PATCH v2 07/10] dm: test: Rename test flags to be generic

2020-06-07 Thread Simon Glass
At present the flags value is common to all tests but only defined by the driver-model tests. Rename the enum and move it into the generic unit-test header. Signed-off-by: Simon Glass --- (no changes since v1) doc/README.commands| 2 +- include/dm/test.h | 9 - include/test/

[PATCH v2 10/10] cmd: Add a memory-search command

2020-06-07 Thread Simon Glass
It is useful to be able to find hex values and strings in a memory range. Add a command to support this. Signed-off-by: Simon Glass --- Changes in v2: - Rename the Kconfig to CONFIG_CMD_MEM_SEARCH - Use a separate var for the remaining search length - Drop unnecessary ':' in the U_BOOT_CMD - Ena

[PATCH v2 06/10] test: Add a way to check part of a console line or skip it

2020-06-07 Thread Simon Glass
Some lines of the output are not worth testing, or not worth testing in their entirety. For example, when checking a hex dump we know that the hex-dump routine can display ASCII so we only need to check the hex bytes, not the ASCII dump. Add a new test macros which can check only part of a console

Re: [PATCH] regmap: Check for out-of-range offsets before mapping them

2020-06-07 Thread Simon Glass
Hi Pratyush, On Tue, 26 May 2020 at 06:06, Pratyush Yadav wrote: > > In regmap_raw_{read,write}_range(), offsets are checked to make sure > they aren't out of range. But this check happens _after_ the address is > mapped from physical memory. Input should be sanity-checked before using > it. Mapp

[PATCH v2 09/10] test: Add a flag for tests that need console recording

2020-06-07 Thread Simon Glass
Allow tests that need console recording to be marked, so they can be skipped if it is not available. Signed-off-by: Simon Glass --- (no changes since v1) include/test/test.h | 1 + test/cmd_ut.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/include/test/test.h b/inclu

Re: [PATCH] buildman: Remove _of_#_ from results directory paths

2020-06-07 Thread Simon Glass
Hi Ovidiu, On Fri, 15 May 2020 at 00:32, Ovidiu Panait wrote: > > Currently, the following scenario will rebuild the first commit even > though it is not really necessary - the commit sha or the position in the > patchset did not change: > > $ git am > $ tools/buildman/buildman -P -E -W -b maste

[PATCH v2 08/10] console: Always define the console-recording functions

2020-06-07 Thread Simon Glass
On boards without console recording these function are currently missing. It is more convenient for them to be present but to return dummy values. That way if we know that a test needs recording, we can check if it is available, and skip the test if not, while avoiding #ifdefs. Update the header f

[PATCH v2 04/10] display_options: Drop #ifdef for MEM_SUPPORT_64BIT_DATA

2020-06-07 Thread Simon Glass
This is defined only when __lp64__ is defined. That means that ulong is 64 bits long. Therefore we don't need to use a separate u64 type on those architectures. Fix up the code to take advantage of that, removing the preprocessor conditions. Signed-off-by: Simon Glass Reviewed-by: Stefan Roese

[PATCH v2 05/10] command: Drop #ifdef for MEM_SUPPORT_64BIT_DATA

2020-06-07 Thread Simon Glass
This is defined only when __lp64__ is defined. That means that ulong is 64 bits long. Therefore we don't need to use a separate u64 type on those architectures. Fix up the code to take advantage of that, removing the preprocessor conditions. Also include the header file that defines MEM_SUPPORT_6

[PATCH v2 03/10] cmd: mem: Drop #ifdef for MEM_SUPPORT_64BIT_DATA

2020-06-07 Thread Simon Glass
This is defined only when __lp64__ is defined. That means that ulong is 64 bits long. Therefore we don't need to use a separate u64 type on those architectures. Fix up the code to take advantage of that, removing the preprocessor conditions. Signed-off-by: Simon Glass Reviewed-by: Stefan Roese

[PATCH v2 02/10] cmd: mem: Use a macro to avoid #ifdef in help

2020-06-07 Thread Simon Glass
It is a bit painful to have #ifdefs in the middle of the help for each command. Add a macro to avoid this. Signed-off-by: Simon Glass Reviewed-by: Stefan Roese --- (no changes since v1) cmd/mem.c | 68 ++- 1 file changed, 17 insertions(+), 5

[PATCH v2 01/10] Update MEM_SUPPORT_64BIT_DATA to be always defined

2020-06-07 Thread Simon Glass
Define this macro always so we don't need the preprocessor to check it. Convert the users to #if instead of #ifdef. Note that '#if MEM_SUPPORT_64BIT_DATA' does not give an error if the macro is not define. It just assumes zero. Signed-off-by: Simon Glass Reviewed-by: Stefan Roese --- (no chang

Re: [PATCH 6/6] cmd: Add a memory-search command

2020-06-07 Thread Simon Glass
Hi Stefan, On Wed, 3 Jun 2020 at 00:05, Stefan Roese wrote: > > On 03.06.20 03:26, Simon Glass wrote: > > It is useful to be able to find hex values and strings in a memory range. > > Add a command to support this. > > > > cmd: Fix 'md' and add a memory-search command > > At present 'md.q' is bro

[PATCH v2 00/10] cmd: Fix 'md' and add a memory-search command

2020-06-07 Thread Simon Glass
This series implements a new memory-search command called 'ms'. It allows searching memory for hex and string data. It also cleans up the use of MEM_SUPPORT_64BIT_DATA since this is currently reliant on including compiler.h and failes silently if it is not. Note: The fix for 'md.q' in the v1 seri

[PATCH] cmd: Correct the 'md.q' command

2020-06-07 Thread Simon Glass
This displays incorrect data at present due to a missing header file in display_options. Fix it. Fixes: 09140113108 ("command: Remove the cmd_tbl_t typedef") Signed-off-by: Simon Glass --- lib/display_options.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/display_options.c b/lib/dis

[PATCH v2 10/10] riscv: Add FPIOA and GPIO support for Kendryte K210

2020-06-07 Thread Sean Anderson
This patch adds the necessary configs and docs for FPIOA and GPIO support on the K210. Signed-off-by: Sean Anderson --- Changes in v2: - Remove SPI flash related Kconfig settings board/sipeed/maix/Kconfig | 9 ++ doc/board/sipeed/maix.rst | 64 +-- 2 fi

[PATCH v2 08/10] led: gpio: Default to using node name if label is absent

2020-06-07 Thread Sean Anderson
This more closely mirrors Linux's behaviour, and will make it easier to transition to using function+color in the future. Signed-off-by: Sean Anderson --- This patch was previously submitted as part of https://patchwork.ozlabs.org/project/uboot/list/?series=161576 (no changes since v1) drivers

[PATCH v2 05/10] gpio: dw: Fix warnings about casting int to pointer

2020-06-07 Thread Sean Anderson
Change the type of gpio_dwabp_platdata.base from fdt_addr_t to a void pointer, since we pass it to readl. Signed-off-by: Sean Anderson Reviewed-by: Bin Meng --- This patch was previously submitted as part of https://patchwork.ozlabs.org/project/uboot/list/?series=161576 (no changes since v1)

[PATCH v2 06/10] gpio: dw: Add a trailing underscore to generated name

2020-06-07 Thread Sean Anderson
Previously, if there was no bank-name property, it was easy to have confusing gpio names like "gpio1@08", instead of "gpio1@0_8". This patch follows the example of the sifive gpio driver. Signed-off-by: Sean Anderson --- This patch was previously submitted as part of https://patchwork.ozlabs.org/

[PATCH v2 09/10] riscv: Add pinmux and gpio bindings for Kendryte K210

2020-06-07 Thread Sean Anderson
This patch adds the necessary device tree bindings. Signed-off-by: Sean Anderson --- Changes in v2: - Convert to use pinmux property - Don't hog ISP on boot - Re-order GPIOs to match the defaults more closely arch/riscv/dts/k210-maix-bit.dts | 104 +++ arch/riscv/d

[PATCH v2 03/10] pinctrl: Add support for Kendryte K210 FPIOA

2020-06-07 Thread Sean Anderson
The Fully-Programmable Input/Output Array (FPIOA) device controls pin multiplexing on the K210. The FPIOA can remap any supported function to any multifunctional IO pin. It can also perform basic GPIO functions, such as reading the current value of a pin. However, GPIO functionality remains largely

[PATCH v2 01/10] pinctrl: Add pinmux property support to pinctrl-generic

2020-06-07 Thread Sean Anderson
The pinmux property allows for smaller and more compact device trees, especially when there are many pins which need to be assigned individually. Instead of specifying an array of strings to be parsed as pins and a function property, the pinmux property contains an array of integers representing pi

[PATCH v2 04/10] gpio: sifive: Use generic reg read function

2020-06-07 Thread Sean Anderson
Using an fdt-specific function causes problems with a live tree. Signed-off-by: Sean Anderson Reviewed-by: Bin Meng --- This patch was previously submitted as part of https://patchwork.ozlabs.org/project/uboot/list/?series=161576 (no changes since v1) drivers/gpio/sifive-gpio.c | 2 +- 1 file

[PATCH v2 00/10] riscv: Add FPIOA and GPIO support for Kendryte K210

2020-06-07 Thread Sean Anderson
This patch series adds support for pinmuxing, gpios, and leds on the Kendyte K210. This patch series was previously part of https://patchwork.ozlabs.org/project/uboot/list/?series=161576 This patch series depends on https://patchwork.ozlabs.org/project/uboot/list/?series=178480 Changes in v2: -

[PATCH v2 02/10] test: pinmux: Add test for pin muxing

2020-06-07 Thread Sean Anderson
This extends the pinctrl-sandbox driver to support pin muxing, and adds a test for that behaviour. The test is done in C and not python (like the existing tests for the pinctrl uclass) because it needs to call pinctrl_select_state. Another option could be to add a command that invokes pinctrl_sele

[PATCH v2 07/10] gpio: dw: Return output value when direction is out

2020-06-07 Thread Sean Anderson
dm_gpio_ops.get_value can be called when the gpio is either input or output. The current dw code always returns the input value, which is invalid if the direction is set to out. Signed-off-by: Sean Anderson --- This patch was previously submitted as part of https://patchwork.ozlabs.org/project/ub

Re: [PATCH 1/1] Dockerfile: add libguestfs-tools package

2020-06-07 Thread AKASHI Takahiro
On Fri, Jun 05, 2020 at 11:19:15AM -0400, Tom Rini wrote: > On Sun, May 31, 2020 at 12:16:58AM +0200, Heinrich Schuchardt wrote: > > > In some of our Python tests we build disk images. Currently this involves > > using the sudo command for losetup and mount. For some tests sudo is > > not necessar

Re: [PATCH 1/1] arm: wandboard: move CONFIG_MXC_UART to defconfig

2020-06-07 Thread Fabio Estevam
On Sun, Jun 7, 2020 at 8:44 PM Heinrich Schuchardt wrote: > > For using a debug UART on the Wandboard CONFIG_MXC_UART=y must be set in > the .config file. > > To avoid duplicate definitions move the setting from > include/configs/wandboard.h to configs/wandboard_defconfig. > > Document the debug U

[PATCH 1/1] arm: wandboard: move CONFIG_MXC_UART to defconfig

2020-06-07 Thread Heinrich Schuchardt
For using a debug UART on the Wandboard CONFIG_MXC_UART=y must be set in the .config file. To avoid duplicate definitions move the setting from include/configs/wandboard.h to configs/wandboard_defconfig. Document the debug UART settings in the README. Signed-off-by: Heinrich Schuchardt --- boa

[RESEND PATCH] usb: max3420: add the gadget driver

2020-06-07 Thread jassisinghbrar
From: Jassi Brar MAX3420 implements FullSpeed USB Device over SPI. Another version MAX3421, also implements USB Host mode. This driver should be good for the device mode of max3421 as well. Signed-off-by: Jassi Brar --- drivers/usb/gadget/Kconfig| 6 + drivers/usb/gadget/Makefile

Re: [PATCH] patman: use new --u-boot option with checkpath.pl

2020-06-07 Thread Simon Glass
Hi Daniel, On Sun, 7 Jun 2020 at 08:15, Daniel Schwierzeck wrote: > > > > Am 07.06.20 um 05:44 schrieb Simon Glass: > > Hi Daniel, > > > > On Sat, 6 Jun 2020 at 20:02, Simon Glass wrote: > >> > >> Hi Daniel, > >> > >> On Sat, 6 Jun 2020 at 15:31, Daniel Schwierzeck > >> wrote: > >>> > >>> check

[RESEND v2 1/1] log: don't show function by default

2020-06-07 Thread Heinrich Schuchardt
The name of the function emitting a log message may be of interest for a developer but is distracting for normal users. See the example below: try_load_entry() Booting: Debian Make the default format for log messages customizable. By default show only the message text. Signed-off-by: Heinric

Re: [PATCH 1/1] mtd: cfi_flash: use __raw_writeq(), __raw_readq()

2020-06-07 Thread Heinrich Schuchardt
On 6/6/20 11:13 PM, Heinrich Schuchardt wrote: > Functions __raw_writeq(), __raw_readq() are available for all > architectures. So let's use them. The major architectures have these but not m68k, microblaze, nd32, nios2, powerpc, sh, xtenza. > > Signed-off-by: Heinrich Schuchardt > --- > driver

rockchip: correctly set vop0 or vop1

2020-06-07 Thread Patrick Wildt
The EDP_LCDC_SEL bit has to be set correctly to select vop0 or vop1, but so far we have set it in both conditions, which is not correct. Can someone verify this is the correct way round? vop1 -> set, vop0 -> clear? Signed-off-by: Patrick Wildt diff --git a/drivers/video/rockchip/rk_edp.c b/dri

Re: [PATCH 1/1] sandbox: handling out of memory

2020-06-07 Thread Heinrich Schuchardt
On 6/7/20 4:02 PM, Heinrich Schuchardt wrote: > Am June 7, 2020 1:45:53 PM UTC schrieb Simon Glass : >> Hi Heinrich, >> >> On Thu, 4 Jun 2020 at 11:28, Heinrich Schuchardt >> wrote: >>> >>> assert() only works in debug mode. So checking a successful memory >>> allocation should not use assert(). >

[PATCH 1/1] sandbox: make RAM size configurable

2020-06-07 Thread Heinrich Schuchardt
Up to now the RAM size of the sandbox is hard coded as 128 MiB. This does not allow testing the correct handling of addresses outside the 32bit range. 128 MiB is also rather small when tracing functions where the trace is written to RAM. Provide configuration variable CONFIG_SANDBOX_RAM_SIZE_MB to

Re: [PATCH v3 2/2] rockchip: Enable PCIe and NVMe on ROCKPro64

2020-06-07 Thread Patrick Wildt
On Sun, Jun 07, 2020 at 02:57:00PM +0100, Peter Robinson wrote: > On Sun, Jun 7, 2020 at 2:47 PM Peter Robinson wrote: > > > > On Sun, Jun 7, 2020 at 1:07 PM Mark Kettenis wrote: > > > > > > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > > > ROCKPro64 board. > > > > > > Signed-of

Re: [PATCH] patman: use new --u-boot option with checkpath.pl

2020-06-07 Thread Daniel Schwierzeck
Am 07.06.20 um 05:44 schrieb Simon Glass: > Hi Daniel, > > On Sat, 6 Jun 2020 at 20:02, Simon Glass wrote: >> >> Hi Daniel, >> >> On Sat, 6 Jun 2020 at 15:31, Daniel Schwierzeck >> wrote: >>> >>> checkpatch.pl now supports a --u-boot option for U-Boot specific >>> checks. Use that in patman t

Re: [PATCH 1/1] sandbox: handling out of memory

2020-06-07 Thread Heinrich Schuchardt
Am June 7, 2020 1:45:53 PM UTC schrieb Simon Glass : >Hi Heinrich, > >On Thu, 4 Jun 2020 at 11:28, Heinrich Schuchardt >wrote: >> >> assert() only works in debug mode. So checking a successful memory >> allocation should not use assert(). >> > >Reviewed-by: Simon Glass > >What sort of environment

Re: rockchip: enable PCIe and NVMe on Pinebook Pro

2020-06-07 Thread Peter Robinson
On Sun, Jun 7, 2020 at 11:08 AM Patrick Wildt wrote: > > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > Pinebook Pro. > > Signed-off-by: Patrick Wildt Reviewed-by: Peter Robinson > diff --git a/configs/pinebook-pro-rk3399_defconfig > b/configs/pinebook-pro-rk3399_defconfig >

Re: [PATCH v3 2/2] rockchip: Enable PCIe and NVMe on ROCKPro64

2020-06-07 Thread Peter Robinson
On Sun, Jun 7, 2020 at 2:47 PM Peter Robinson wrote: > > On Sun, Jun 7, 2020 at 1:07 PM Mark Kettenis wrote: > > > > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > > ROCKPro64 board. > > > > Signed-off-by: Mark Kettenis > > Reviewed-by: Kever Yang > Reviewed-by: Peter Robinson

Re: [PATCH v3 2/2] rockchip: Enable PCIe and NVMe on ROCKPro64

2020-06-07 Thread Peter Robinson
On Sun, Jun 7, 2020 at 1:07 PM Mark Kettenis wrote: > > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > ROCKPro64 board. > > Signed-off-by: Mark Kettenis > Reviewed-by: Kever Yang Reviewed-by: Peter Robinson It's generally considered good taste to cc: the maintainer, you can fi

Re: [PATCH 1/2] cmd: booti: Fix spelling of "environment".

2020-06-07 Thread Simon Glass
On Thu, 4 Jun 2020 at 11:42, Vagrant Cascadian wrote: > > Signed-off-by: Vagrant Cascadian > --- > > cmd/booti.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH 1/1] sandbox: handling out of memory

2020-06-07 Thread Simon Glass
Hi Heinrich, On Thu, 4 Jun 2020 at 11:28, Heinrich Schuchardt wrote: > > assert() only works in debug mode. So checking a successful memory > allocation should not use assert(). > Reviewed-by: Simon Glass What sort of environment are you using that returns NULL in this case? Regards, Simon

Re: [PATCH] test_sleep.py: make sleep time and margin configurable

2020-06-07 Thread Simon Glass
On Thu, 4 Jun 2020 at 09:24, Heiko Schocher wrote: > > make the sleep time and the margin configurable. > > Signed-off-by: Heiko Schocher > --- > > travis build: > https://travis-ci.org/github/hsdenx/u-boot-test/builds/694545225 > > This patch is needed as I start test/py now within tbot [1]. On

Re: [PATCH] tpm: add TPM2_GetRandom command support

2020-06-07 Thread Simon Glass
On Thu, 4 Jun 2020 at 17:44, Dhananjay Phadke wrote: > > Add support for TPM2 GetRandom command > > Signed-off-by: Dhananjay Phadke > --- > include/tpm-v2.h | 13 + > lib/tpm-v2.c | 44 > 2 files changed, 57 insertions(+) > Reviewed-b

Re: [PATCH 1/1] sandbox: spi: sandbox_sf_state_name() is required

2020-06-07 Thread Simon Glass
On Sun, 7 Jun 2020 at 01:28, Heinrich Schuchardt wrote: > > Compiling drivers/mtd/spi/sandbox.c fails when compiled with > CONFIG_LOG=n: > > In file included from include/common.h:20, > from drivers/mtd/spi/sandbox.c:13: > drivers/mtd/spi/sandbox.c:295:15: error: format ‘%s’ expec

Re: [PATCH v3 1/2] rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399【请注意,邮件由mark.kette...@sibelius.xs4all.nl代发】

2020-06-07 Thread Kever Yang
Hi Mark, On 2020/6/7 下午8:44, Mark Kettenis wrote: From: Kever Yang Date: Sun, 7 Jun 2020 20:32:33 +0800 Hi Mark,     What's the change in this new version? No change. Just regenerated from a clean master such that there are no conflicts when applying. Thanks, already apply to u-boot-roc

[PATCH v4 2/6] patman: Avoid circular dependency between command and tools

2020-06-07 Thread Simon Glass
This seems to cause problems in some cases. Split the dependency by copying the code to command. Reported-by: Stefan Bosch Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/command.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/patman/comma

[PATCH v4 3/6] patman: Use a dict in gitutil to avoid importing series

2020-06-07 Thread Simon Glass
Only a few members of this class are used and only in a test. To avoid importing the module, convert the test to use a dict. Signed-off-by: Simon Glass Reported-by: Stefan Bosch --- (no changes since v1) tools/patman/gitutil.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) d

[PATCH v4 5/6] patman: Avoid importing gitutil in settings

2020-06-07 Thread Simon Glass
Pass this module in so that settings does not need to import it. Signed-off-by: Simon Glass Reported-by: Stefan Bosch --- (no changes since v3) Changes in v3: - Add more patches based on testing on a dusty Ubuntu 14.04 Changes in v2: - Update gitutil as well tools/patman/main.py | 2 +-

[PATCH v4 1/6] patman: Drop unnecessary import in gitutil

2020-06-07 Thread Simon Glass
The checkpatch module is not used, so drop it. Signed-off-by: Simon Glass Reported-by: Stefan Bosch --- (no changes since v3) Changes in v3: - Split out the gitutil change into a separate patch tools/patman/gitutil.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/patman/gitutil.py

[PATCH v4 6/6] patman: Drop import of test_util in test_util

2020-06-07 Thread Simon Glass
This module doesn't need to import itself. It causes problems on very old Python 3 (e.g. 3.4.0). Drop it. Signed-off-by: Simon Glass --- Changes in v4: - Add a new patch to drop import of test_util in test_util - Add a cover letter tools/patman/test_util.py | 1 - 1 file changed, 1 deletion(-)

[PATCH v4 4/6] patman: Pass in maintainer dirs to avoid and import

2020-06-07 Thread Simon Glass
Adjust the get_maintainer module to accept a list of directories to search for the script. This avoids needing to import gitutil. Signed-off-by: Simon Glass Reported-by: Stefan Bosch --- (no changes since v1) tools/patman/get_maintainer.py | 14 +++--- tools/patman/series.py |

[PATCH v4 0/6] patman: Support old Python 3 versions

2020-06-07 Thread Simon Glass
With the move to supporting only Python 3, patman is reliant on whatever version of Python 3 is available on the host machine. For old distributions such as Ubuntu 14.04 this means Python 3.4.0 which seems to have some problems with importing modules. This series updates patman to work correctly i

Re: [PATCH v3 1/2] rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399

2020-06-07 Thread Mark Kettenis
> From: Kever Yang > Date: Sun, 7 Jun 2020 20:32:33 +0800 > > Hi Mark, > >     What's the change in this new version? No change. Just regenerated from a clean master such that there are no conflicts when applying. > On 2020/6/7 下午8:06, Mark Kettenis wrote: > > Enable CONFIG_PCI and CONFIG_NV

Re: [PATCH v3 1/2] rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399

2020-06-07 Thread Kever Yang
Hi Mark,     What's the change in this new version? Thanks, - Kever On 2020/6/7 下午8:06, Mark Kettenis wrote: Enable CONFIG_PCI and CONFIG_NVME and related configs for the Firefly RK3399 board. Signed-off-by: Mark Kettenis Reviewed-by: Simon Glass Reviewed-by: Kever Yang --- configs/fir

[PATCH v2] lz4: fix decompressor on big-endian powerpc

2020-06-07 Thread Rasmus Villemoes
Booting an lz4-compressed kernel image fails on our powerpc board with -EPROTONOSUPPORT. Adding a bit of debug prints, we get magic: 0x184d2204 flags: 0x64 reserved0: 1 has_content_checksum: 1 has_content_size: 0 has_block_checksum: 0 independent_blocks: 1 version: 0 block_descri

Re: [PATCH] lz4: fix decompressor on big-endian powerpc

2020-06-07 Thread Rasmus Villemoes
On 05/06/2020 22.37, Julius Werner wrote: >> I'm a bit puzzled about the github.com/Cyan4973/lz4 >> reference. Cyan4973 is Yann Collet, the author of lz4, and nowadays at >> least that github url redirects to the upstream repo, >> github.com/lz4/lz4. Grepping through all available tags and branches

[PATCH v3 1/2] rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399

2020-06-07 Thread Mark Kettenis
Enable CONFIG_PCI and CONFIG_NVME and related configs for the Firefly RK3399 board. Signed-off-by: Mark Kettenis Reviewed-by: Simon Glass Reviewed-by: Kever Yang --- configs/firefly-rk3399_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/firefly-rk3399_defconfig b/conf

[PATCH v3 2/2] rockchip: Enable PCIe and NVMe on ROCKPro64

2020-06-07 Thread Mark Kettenis
Enable CONFIG_PCI and CONFIG_NVME and related configs for the ROCKPro64 board. Signed-off-by: Mark Kettenis Reviewed-by: Kever Yang --- configs/rockpro64-rk3399_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defco

Re: [PATCH v2 1/2] rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399

2020-06-07 Thread Mark Kettenis
> From: Kever Yang > Date: Mon, 1 Jun 2020 09:15:17 +0800 > > Hi Mark, > > This is not able to apply directly, this is the first time I met this error: > > $ git-pw patch apply 1297197 > Applying: rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399 > error: sha1 information is lacking or usele

Re: rockchip: enable PCIe and NVMe on Pinebook Pro

2020-06-07 Thread Kever Yang
On 2020/6/7 下午6:08, Patrick Wildt wrote: Enable CONFIG_PCI and CONFIG_NVME and related configs for the Pinebook Pro. Signed-off-by: Patrick Wildt Reviewed-by: Kever Yang Thanks, - Kever diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig index 9cc

Re: [PATCH] test: add dependency for UT_LOG

2020-06-07 Thread Heinrich Schuchardt
Am June 7, 2020 11:29:38 AM UTC schrieb Kever Yang : > >On 2020/6/7 下午1:55, Heinrich Schuchardt wrote: >> Am June 7, 2020 3:52:37 AM UTC schrieb Kever Yang >: >>> The callback of do_ut_log() is defined in test/log/test-main.c >>> which is depend on CONFIG_LOG. >> Where do you see such a dependency?

Re: [PATCH] test: add dependency for UT_LOG

2020-06-07 Thread Kever Yang
On 2020/6/7 下午1:55, Heinrich Schuchardt wrote: Am June 7, 2020 3:52:37 AM UTC schrieb Kever Yang : The callback of do_ut_log() is defined in test/log/test-main.c which is depend on CONFIG_LOG. Where do you see such a dependency? With which configuration did you have a build problem? I met

[PATCH] nvme: Invalidate dcache before submitting admin cmd

2020-06-07 Thread Jagan Teki
Some architecture like ARM Cortex A53, A72 would need to invalidate dcache to sync the cache with the memory contents before flushing the cache to memory. The NVME here submitting the admin command using dma_addr to the memory without prior cache invalidation. This causing dma_addr is pointing to

Re: [PATCH 2/5] arm: qemu: enable LPAE on 32-bit

2020-06-07 Thread Ard Biesheuvel
On Sun, 7 Jun 2020 at 13:03, Heinrich Schuchardt wrote: > > Am June 7, 2020 8:59:00 AM UTC schrieb Ard Biesheuvel : > >On Sat, 6 Jun 2020 at 22:49, Heinrich Schuchardt > >wrote: > >> > >> On 6/6/20 10:32 PM, Heinrich Schuchardt wrote: > >> > On 6/6/20 7:15 PM, Ard Biesheuvel wrote: > >> >> QEMU's

Re: [PATCH 2/5] arm: qemu: enable LPAE on 32-bit

2020-06-07 Thread Heinrich Schuchardt
Am June 7, 2020 8:59:00 AM UTC schrieb Ard Biesheuvel : >On Sat, 6 Jun 2020 at 22:49, Heinrich Schuchardt >wrote: >> >> On 6/6/20 10:32 PM, Heinrich Schuchardt wrote: >> > On 6/6/20 7:15 PM, Ard Biesheuvel wrote: >> >> QEMU's mach-virt machine only supports selecting CPU models that >> >> implemen

rockchip: enable PCIe and NVMe on Pinebook Pro

2020-06-07 Thread Patrick Wildt
Enable CONFIG_PCI and CONFIG_NVME and related configs for the Pinebook Pro. Signed-off-by: Patrick Wildt diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig index 9cce7ac00c1..0c129b9aebb 100644 --- a/configs/pinebook-pro-rk3399_defconfig +++ b/configs/pin

[PATCH 1/1] config: qemu: increase SYS_MALLOC_F_LEN

2020-06-07 Thread Heinrich Schuchardt
Several configutation options require additional memory before relocation: * CONSOLE_RECORD * LOG * RSA The current default of 0x400 is too small to encompass them all. Increase the value of SYS_MALLOC_F_LEN to 0x2000 for ARCH_QEMU. Signed-off-by: Heinrich Schuchardt --- There is a similar patc

Re: [PATCH 2/5] arm: qemu: enable LPAE on 32-bit

2020-06-07 Thread Ard Biesheuvel
On Sat, 6 Jun 2020 at 22:49, Heinrich Schuchardt wrote: > > On 6/6/20 10:32 PM, Heinrich Schuchardt wrote: > > On 6/6/20 7:15 PM, Ard Biesheuvel wrote: > >> QEMU's mach-virt machine only supports selecting CPU models that > >> implement the virtualization extensions, and are therefore guaranteed >

[PATCH 1/1] sandbox: spi: sandbox_sf_state_name() is required

2020-06-07 Thread Heinrich Schuchardt
Compiling drivers/mtd/spi/sandbox.c fails when compiled with CONFIG_LOG=n: In file included from include/common.h:20, from drivers/mtd/spi/sandbox.c:13: drivers/mtd/spi/sandbox.c:295:15: error: format ‘%s’ expects argument of type ‘char *’, but argument 7 has type ‘int’ [-Werror=f