Re: [PATCH 1/2] rockchip: rk3399: Re-init clocks in U-Boot proper

2020-10-26 Thread Simon Glass
Hi Alper, On Sat, 24 Oct 2020 at 16:29, Alper Nebi Yasak wrote: > > On 24/10/2020 03:05, Simon Glass wrote: > > Hi Alper, > > > > On Thu, 22 Oct 2020 at 14:37, Alper Nebi Yasak > > wrote: > >> > >> It's possible to chainload U-Boot proper from the vendor firmware in > >> rk3399 chromebooks,

Re: [PATCH v2 21/30] patman: Require tags to be before sign-off

2020-10-26 Thread Simon Glass
Hi Sean, On Sun, 25 Oct 2020 at 19:23, Sean Anderson wrote: > > On 10/25/20 9:04 PM, Simon Glass wrote: > > At present it is possible to put sign-off tags before the change log. This > > works but then it is hard for patman to add its own tags to a commit. Also > > if the commit has a Change-Id

Re: [PATCH] video: rockchip: Restrict EDP, VOP, MIPI files to GPL-2.0

2020-10-26 Thread Simon Glass
On Thu, 22 Oct 2020 at 13:44, Alper Nebi Yasak wrote: > > These files have a lot of code in common with their counterparts in > coreboot, especially in their earlier revisions: > > U-Boot | coreboot > >

Re: [PATCH] test: log: Actually test enable/disable output

2020-10-26 Thread Simon Glass
On Sat, 17 Oct 2020 at 07:20, Sean Anderson wrote: > > Strings are truth-y in python, so ``assert 'anything'`` will always > evaluate to True. Fix the test so that it actually checks the output. > > Fixes: 3d03ab6361 ("log: Add a way to enable/disable a log device") > Signed-off-by: Sean Anderson

Re: [PATCH v4 5/7] test: Add tests for the multiplexer framework

2020-10-26 Thread Simon Glass
Hi Pratyush, On Fri, 16 Oct 2020 at 04:46, Pratyush Yadav wrote: > > From: Jean-Jacques Hiblot > > Provide tests to check the behavior of the multiplexer framework. > > Two sets of tests are added. One is using an emulated multiplexer driver > that can be used to test basic functionality like

Re: [PATCH 5/5] test: adjust sysreset tests

2020-10-26 Thread Simon Glass
On Sun, 25 Oct 2020 at 00:04, Heinrich Schuchardt wrote: > > As we have a working COLD_RESET on the sandbox the sysreset test has to be > adjusted. > > Signed-off-by: Heinrich Schuchardt > --- > test/dm/sysreset.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) Reviewed-by:

Re: [PATCH 1/1] test: fix build failure for syslog_test

2020-10-26 Thread Simon Glass
On Sat, 17 Oct 2020 at 05:45, Heinrich Schuchardt wrote: > > Avoid failures like: > > test/log/syslog_test_ndebug.c:18:10: > fatal error: syslog_test.h: No such file or directory >18 | #include > | ^~~ > > syslog_test.h is a local include. Use "" and not <>. > >

Re: [PATCH v2 2/2] rtc: provide an emulated RTC

2020-10-26 Thread Simon Glass
Hi Heinrich, On Sun, 25 Oct 2020 at 01:13, Heinrich Schuchardt wrote: > > On a board without hardware clock this software real time clock can be > used. The build time is used to initialize the RTC. So you will have > to adjust the time either manually using the 'date' command or use > the

Re: [PATCH 1/5] sandbox: eth-raw: do not close the console input

2020-10-26 Thread Simon Glass
On Sun, 25 Oct 2020 at 00:04, Heinrich Schuchardt wrote: > > When the sandbox eth-raw device host_lo is removed this leads to closing > the console input. > > Do not call close(0). > > Signed-off-by: Heinrich Schuchardt > --- > arch/sandbox/cpu/eth-raw-os.c | 8 > arch/sandbox/cpu/os.c

Re: [PATCH 2/5] sandbox: enable poweroff command

2020-10-26 Thread Simon Glass
On Sun, 25 Oct 2020 at 00:04, Heinrich Schuchardt wrote: > > The command to shut down a device is 'poweroff'. It is a deficit of the > sandbox that it does not support resetting yet but shuts down upong seeing > the 'reset' command. > > Once the sandbox properly supports reset we need the

Re: [PATCH 4/5] sandbox: implement reset

2020-10-26 Thread Simon Glass
Hi Heinrich, On Sun, 25 Oct 2020 at 00:04, Heinrich Schuchardt wrote: > > Up to now the sandbox would shutdown upon a cold reset request. Instead it > should be reset. > > In our coding we use static variables. The only safe way to return to an > initial state is to relaunch the U-Boot binary.

Re: [PATCH v3 1/2] dm: core: add function uclass_probe_all() to probe all devices

2020-10-26 Thread Simon Glass
On Mon, 19 Oct 2020 at 12:10, Vabhav Sharma wrote: > > From: Vabhav Sharma > > Support a common method to probe all devices associated with uclass. > > This includes data structures and code for finding the first device and > looping for remaining devices associated with uclasses (groups of

Re: [PATCH v2 1/2] Makefile: provide constant with seconds since epoch

2020-10-26 Thread Simon Glass
On Sun, 25 Oct 2020 at 01:13, Heinrich Schuchardt wrote: > > Provide a constant U_BOOT_EPOCH with the number of seconds since > 1970-01-01. This constant can be used to initialize a software > real time clock until it is updated via the 'sntp' command. > > Signed-off-by: Heinrich Schuchardt >

Re: [PATCH 2/2] rockchip: gru: Allow setting up clocks in U-Boot proper

2020-10-26 Thread Simon Glass
Hi Alper, On Sat, 24 Oct 2020 at 16:29, Alper Nebi Yasak wrote: > > On 24/10/2020 03:05, Simon Glass wrote: > > Hi Alper, > > > > On Thu, 22 Oct 2020 at 14:38, Alper Nebi Yasak > > wrote: > >> > >> Commit fe974716326c ("rockchip: rk3288: Allow setting up clocks in > >> U-Boot proper") fixes

Re: [PATCH 3/5] test/py: test poweroff

2020-10-26 Thread Simon Glass
On Sun, 25 Oct 2020 at 00:04, Heinrich Schuchardt wrote: > > It is the 'poweroff' and not the 'reset' command that should shut down the > sandbox. > > Adjust the unit test accordingly > > Signed-off-by: Heinrich Schuchardt > --- > test/py/tests/test_sandbox_exit.py | 8 > 1 file

Re: [PATCH 1/1] input: add support for FN1 - FN10 on crosswire kbd

2020-10-26 Thread Simon Glass
On Fri, 23 Oct 2020 at 12:52, Heinrich Schuchardt wrote: > > Chromebooks and the sandbox use a crosswire keyboard with function keys > FN1 - FN10. These keys are needed when running UEFI applications like GRUB > or the UEFI SCT. > > Add support for these keys when translating from key codes to >

Re: [PATCH 1/1] log: correct and check array size of log categories

2020-10-26 Thread Simon Glass
On Fri, 23 Oct 2020 at 05:00, Heinrich Schuchardt wrote: > > The log command has led to NULL dereferences if an unknown category name > name was used due to missing entries in the list of category names. > > Add compile time checks for the array sizes of log_cat_name and > log_lvl_name to avoid

Re: [PATCH v2 1/3] log: move processing_msg to global data

2020-10-26 Thread Simon Glass
On Sat, 17 Oct 2020 at 06:32, Heinrich Schuchardt wrote: > > Replace the static variable processing_msg by a field in the global data. > Make the field bool at it can only be true or false. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > new patch > --- > common/log.c

Re: [PATCH v4 4/7] Kconfig: Increase the pre-relocation memory

2020-10-26 Thread Simon Glass
On Fri, 16 Oct 2020 at 04:46, Pratyush Yadav wrote: > > The memory is close to full and adding a syscon node in test.dts makes > it go over the limit and makes malloc() fail on startup. > > Signed-off-by: Pratyush Yadav > --- > > Notes: > New in v4. > > Kconfig | 2 +- > 1 file changed, 1

Re: [PATCH v2 2/3] log: allow for message continuation

2020-10-26 Thread Simon Glass
On Sat, 17 Oct 2020 at 06:32, Heinrich Schuchardt wrote: > > Some drivers use macro pr_cont() for continuing a message sent via printk. > Hence if we want to convert printk messaging to using the logging system, > we must support continuation of log messages too. > > As pr_cont() does not provide

Re: [PATCH v4 7/7] test: mux-cmd: Add tests for the 'mux' command

2020-10-26 Thread Simon Glass
Hi Pratyush, On Fri, 16 Oct 2020 at 04:46, Pratyush Yadav wrote: > > Tests tests run the three mux subcommands: list, select, and deselect, > and verify that the commands do what we expect. > > Signed-off-by: Pratyush Yadav > --- > > Notes: > New in v4. > > configs/sandbox_defconfig | 1

Re: [PATCH v4 6/7] cmd: Add a mux command

2020-10-26 Thread Simon Glass
Hi Pratyush, On Fri, 16 Oct 2020 at 04:46, Pratyush Yadav wrote: > > This command lets the user list, select, and deselect mux controllers > introduced with the mux framework on the fly. It has 3 subcommands: > list, select, and deselect. > > List: Lists all the mux present on the system. The

Re: [PATCH 13/18] gpio: add GPIO controller driver for MediaTek MT7620 SoC

2020-10-26 Thread Simon Glass
On Fri, 16 Oct 2020 at 01:36, Weijie Gao wrote: > > This patch adds GPIO controller driver for MediaTek MT7620 SoC > > Signed-off-by: Weijie Gao > --- > drivers/gpio/Kconfig | 8 ++ > drivers/gpio/Makefile | 1 + > drivers/gpio/mt7620_gpio.c | 146

Re: [PATCH 08/18] serial: add uart driver for MediaTek MT7620 SoC

2020-10-26 Thread Simon Glass
Hi Weijie, On Fri, 16 Oct 2020 at 01:36, Weijie Gao wrote: > > This patch adds uart support for MediaTek MT7620 and earlier SoCs. > > The UART used by MT7620 is incompatible with the ns16550a driver. > All registers of this UART have different addresses. A special 16-bit > register for Divisor

Re: [PATCH 04/17] dm: core: Avoid void * in the of-platdata structs

2020-10-26 Thread Simon Glass
These pointers point to drivers. Update the definition to make this clear. Signed-off-by: Simon Glass --- include/dt-structs.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 02/20] dtoc: Document the return value of scan_structs()

2020-10-26 Thread Simon Glass
Add documentation to this function as well as generate_structs(), where the return value is ultimately passed in. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 15 +++ 1 file changed, 15 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 01/17] dtoc: Extract inner loop from output_node()

2020-10-26 Thread Simon Glass
This function is very long. Put the inner loop in a separate function to enhance readability. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 89 +- 1 file changed, 49 insertions(+), 40 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 08/17] dm: test: Make use of CONFIG_UNIT_TEST

2020-10-26 Thread Simon Glass
At present we always include test/dm from the main Makefile. We have a CONFIG_UNIT_TEST that should control whether the test/ directory is built, so rely on that instead. Signed-off-by: Simon Glass --- Makefile | 2 +- test/Makefile | 3 ++- 2 files changed, 3 insertions(+), 2

Re: [PATCH 07/12] binman: Add a way to read the ROM offset

2020-10-26 Thread Simon Glass
Provide a function to read the ROM offset so that we can store the value in one place and clients don't need to store it themselves after calling binman_set_rom_offset(). Signed-off-by: Simon Glass --- include/binman.h | 7 +++ lib/binman.c | 7 ++- 2 files changed, 13

Re: [PATCH v2 1/1] sandbox: make SDL window resizable

2020-10-26 Thread Simon Glass
On Fri, 9 Oct 2020 at 15:44, Heinrich Schuchardt wrote: > > Without resizing the SDL window showed by > > ./u-boot -D -l > > is not legible on a high resolution screen. > > Allow resizing the window > > Signed-off-by: Heinrich Schuchardt > --- > v2: > Do not maximize the window. >

Re: [PATCH 02/17] dtoc: Use a namedtuple for _links

2020-10-26 Thread Simon Glass
The use of strings to access a dict is a bit ugly. Use a namedtuple for this instead. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 16 1 file changed, 12 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 03/17] dm: core: Expand the comment for DM_GET_DEVICE()

2020-10-26 Thread Simon Glass
The current documentation for this is not particularly enlightening. Add a little more detail. Signed-off-by: Simon Glass --- include/dm/platdata.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH 08/12] binman: Support multiple images in the library

2020-10-26 Thread Simon Glass
Add support for multiple images, since these are used on x86 now. Select the first image for now, since that is generally the correct one. At some point we can add a way to determine which image is currently running. Signed-off-by: Simon Glass --- lib/binman.c | 7 +++ 1 file changed, 7

Re: [PATCH 07/17] dm: test: Update Makefile conditions

2020-10-26 Thread Simon Glass
At present most of the tests in test/Makefile are dependent on CONFIG_SANDBOX. But this is not ideal since they rely on commands being available and SPL does not support commands. Use CONFIG_COMMAND instead. This has the dual purpose of allowing these tests to be used on other boards and allowing

Re: [PATCH 01/20] sandbox: Drop ad-hoc device declarations in SPL

2020-10-26 Thread Simon Glass
Since sandbox's SPL is build with of-platadata, we should not use U_BOOT_DEVICE() declarations as well. Drop them. Signed-off-by: Simon Glass --- board/sandbox/sandbox.c | 2 ++ drivers/serial/sandbox.c| 3 +++ drivers/sysreset/sysreset_sandbox.c | 2 ++ 3 files

Re: [PATCH 06/17] dm: test: Sort the Makefile

2020-10-26 Thread Simon Glass
Move everything into alphabetical order. Signed-off-by: Simon Glass --- test/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 03/20] dtoc: Order the structures internally by name

2020-10-26 Thread Simon Glass
At present the structures are written in name order, but parents have to be written before their children, so the file does not end up being in order. The order of nodes in _valid_nodes matches the order of the devicetree. Update the code so that _valid_nodes is in sorted order, by C name of the

Re: [PATCH 09/17] dm: test: Disable some tests that should not run in SPL

2020-10-26 Thread Simon Glass
Tests are easier to run in U-Boot proper. Running them in SPL does not add test coverage in most cases. Also some tests use features that are not available in SPL. Update the build rules to disable these tests in SPL. We still need test-main to be able to actually run SPL tests. Signed-off-by:

Re: [PATCH 04/20] dm: core: Allow dm_warn() to be used in SPL

2020-10-26 Thread Simon Glass
At present this option is disabled in SPL, meaning that warnings are not displayed. It is sometimes useful to see warnings in SPL for debugging purposes. Add a new Kconfig option to permit this. Signed-off-by: Simon Glass --- drivers/core/Kconfig | 18 --

Re: [PATCH] dm: core: fix typo in device.h

2020-10-26 Thread Simon Glass
On Sun, 11 Oct 2020 at 06:27, Dario Binacchi wrote: > > Replace 'a the' with 'the' in include/dm/device.h. > > Signed-off-by: Dario Binacchi > --- > > include/dm/device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass Applied to u-boot-dm, thanks!

Re: [PATCH 05/20] dtoc: Fix widening of int to bytes

2020-10-26 Thread Simon Glass
At present an integer is converted to bytes incorrectly. The whole 32-bit integer is inserted as the first element of the byte array, and the other three bytes are skipped. This was not noticed because the unit test did not check it, and the functional test was checking for wrong values. Update

Re: [PATCH 06/18] mips: mtmips: add two reference boards for mt7620

2020-10-26 Thread Weijie Gao
On Mon, 2020-10-26 at 14:06 +0100, Daniel Schwierzeck wrote: > Am Freitag, den 16.10.2020, 15:35 +0800 schrieb Weijie Gao: > > The mt7620_rfb board supports integrated 10/100M PHYs plus two external > > giga PHYs. It also has 8MB SPI-NOR, mini PCI-e x1 slot, SDHC and USB. > > > > The

Re: [PATCH v2 5/7] riscv: dts: Add device tree for Microchip Icicle Kit

2020-10-26 Thread Atish Patra
On Mon, Oct 26, 2020 at 6:14 AM Bin Meng wrote: > > On Thu, Oct 22, 2020 at 3:23 PM Padmarao Begari > wrote: > > > > Add device tree for Microchip PolarFire SoC Icicle Kit. > > > > Signed-off-by: Padmarao Begari > > --- > > arch/riscv/dts/Makefile | 1 + > >

Re: [PATCH 05/18] mips: mtmips: add support for MediaTek MT7620 SoC

2020-10-26 Thread Weijie Gao
On Mon, 2020-10-26 at 13:51 +0100, Daniel Schwierzeck wrote: > Am Freitag, den 16.10.2020, 15:35 +0800 schrieb Weijie Gao: > > This patch adds support for MediaTek MT7620 SoC. > > All files are dedicated for u-boot. > > > > Signed-off-by: Weijie Gao > > --- > > arch/mips/dts/mt7620-u-boot.dtsi

Re: how to use SPL_MULTI_DTB_FIT?

2020-10-26 Thread Tim Harvey
On Fri, Oct 23, 2020 at 11:32 AM Tim Harvey wrote: > > Greetings, > > I'm working on U-Boot board support for a family of IMX8MM boards and > need to support multiple DTB's. My boards have an i2c EEPROM that I > need to read to find the model and other specifics before >

Re: [PATCH v2] nokia_rx51: disable obsolete VIDEO config

2020-10-26 Thread Pali Rohár
On Monday 26 October 2020 19:58:20 Anatolij Gustschin wrote: > Disable VIDEO config to fix DM_VIDEO conversion > deadline warning. > > Signed-off-by: Anatolij Gustschin > Cc: Pali Rohár > --- > > Changes in v2: > - select CFB_CONSOLE instead of VIDEO to let video console >support enabled

[PATCH v2 23/28] binman: Call CheckSize() from the section's Pack() method

2020-10-26 Thread Simon Glass
At present CheckSize() is called from the function that packs the entries. Move it up to the main Pack() function so that _PackEntries() can just do the packing. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 5 - 1 file changed, 4 insertions(+), 1

[PATCH v2 17/28] binman: Store the original data before compression

2020-10-26 Thread Simon Glass
When compressing an entry, the original uncompressed data is overwritten. Store it so it is available if needed. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 7 ++- tools/binman/ftest.py | 12 2 files changed, 18 insertions(+), 1 deletion(-)

[PATCH v2 26/28] binman: Use the actual contents in CheckSize()

2020-10-26 Thread Simon Glass
At present this function adds up the total size of entries to work out the size of a section's contents. With compression this is no-longer enough. We may as well bite the bullet and build the section contents instead. Call _BuildSectionData() to get the (possibly compressed) contents and

[PATCH v2 27/28] binman: Support compression of sections

2020-10-26 Thread Simon Glass
With the previous changes, it is now possible to compress entire sections. Add some tests to check that compression works correctly, including updating the metadata. Also update the documentation. Signed-off-by: Simon Glass --- Changes in v2: - Renumber the test .dts files to make space for

[PATCH v2 28/28] binman: Avoid calculated section data repeatedly

2020-10-26 Thread Simon Glass
Refactor the implementation slightly so that section data is not rebuilt when it is already available. We still have GetData() set up to rebuild the section, since we don't currently track when things change that might affect a section. For example, if a blob is updated within a section, we must

[PATCH v2 25/28] binman: Update CheckEntries() for compressed sections

2020-10-26 Thread Simon Glass
At present this function assumes that the size of a section is at least as large as its contents. With compression this is often not the case. Relax this constraint by using the uncompressed size, if available. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py

[PATCH v2 19/28] binman: Avoid reporting image-pos with compression

2020-10-26 Thread Simon Glass
When a section is compressed, all entries within it are grouped together into a compressed block of data. This obscures the start of each individual child entry. Avoid reporting bogus 'image-pos' properties in this case, since it is not possible to access the entry at the location provided. The

[PATCH v2 21/28] binman: Move sort and expand to the main Pack() function

2020-10-26 Thread Simon Glass
At present sorting and expanding entries are side-effects of the CheckEntries() function. This is a bit confusing, as 'checking' would not normally involve making changes. Move these steps into the Pack() function instead. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v2 24/28] binman: Drop CheckEntries()

2020-10-26 Thread Simon Glass
This method introduces a separation between packing and checking that is different for sections. In order to handle compression properly, we need to be able to deal with a section's size being smaller than the uncompressed size of its contents. It is easier to make this work if everything happens

[PATCH v2 02/28] binman: Drop unused return variable for _DoTestFile()

2020-10-26 Thread Simon Glass
This function returns the exit code from binman, not any data. Fix up a few callers in the tests. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to drop unused return variable for _DoTestFile() tools/binman/ftest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 22/28] binman: Drop the Entry.CheckSize() method

2020-10-26 Thread Simon Glass
This is only used by entry_Section and that class already calls it. Avoid calling it twice. Also drop it from the documentation. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README | 21 ++--- tools/binman/control.py | 1 - 2 files changed, 10

[PATCH v2 20/28] binman: Drop Entry.CheckOffset()

2020-10-26 Thread Simon Glass
This function just calls CheckEntries() in the only non-trivial implementation. Drop it and use CheckEntries() directly. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 2 +- tools/binman/etype/section.py | 5 + 2 files changed, 2 insertions(+), 5

[PATCH v2 11/28] binman: Expand docs and test for padding

2020-10-26 Thread Simon Glass
Padding becomes part of the entry once the image is written out, but within binman the entry contents does not include the padding. Add documentation to make this clear, as well as a test. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README | 12 +---

[PATCH v2 18/28] binman: Set section contents in GetData()

2020-10-26 Thread Simon Glass
Section contents is not set up when ObtainContents() is called, since packing often changes the layout of the contents. Ensure that the contents are correctly recorded by making this function regenerate the section. It is normally only called by the parent section (when packing) or by the

[PATCH v2 16/28] binman: Make section padding consistent with other entries

2020-10-26 Thread Simon Glass
At present padding of sections is inconsistent with other entry types, in that different pad bytes are used. When a normal entry is padded by its parent, the parent's pad byte is used. But for sections, the section's pad byte is used. Adjust logic to always do this the same way. Note there is

[PATCH v2 07/28] binman: Expand the error message for breaching a section

2020-10-26 Thread Simon Glass
Add in a few more details to this error message to make it easier to see what is going on. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 10 ++ tools/binman/ftest.py | 5 +++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH v2 14/28] binman: Refactor _BuildSectionData()

2020-10-26 Thread Simon Glass
At present this function does the padding needed around an entry. It is easier to understand what is going on if we have a function that returns the contents of an entry, with padding included. Refactor the code accordingly, adding a new GetPaddedData() method. Signed-off-by: Simon Glass ---

[PATCH v2 15/28] binman: Move section padding to the parent

2020-10-26 Thread Simon Glass
Each section is padded up to its size, if the contents are not large enough. Move this logic from _BuildSectionData() to GetPaddedDataForEntry() so that all the padding is in one place. With this, the testDual test is working again, so enable it. Signed-off-by: Simon Glass --- Changes in v2: -

[PATCH v2 12/28] binman: Expand docs and test for alignment

2020-10-26 Thread Simon Glass
Alignment does form part of the entry once the image is written out, but within binman the entry contents does not include the padding. Add documentation to make this clear, as well as a test. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README | 29

[PATCH v2 13/28] binman: Move section-building code into a function

2020-10-26 Thread Simon Glass
Create a new _BuildSectionData() to hold the code that is now in GetData(), so that it is clearly separated from entry.GetData() base function. Separate out the 'pad-before' processing to make this easier to understand. Unfortunately this breaks the testDual test. Rather than squash several

[PATCH v2 09/28] binman: Use 'files-compress' to set compression for files

2020-10-26 Thread Simon Glass
At present we use 'compress' as the property to set the compression of a 'files' entry. But this conflicts with the same property for entries, of which Entry_section is a subclass. Strictly speaking, since Entry_files is in fact a subclass of Entry_section, the files can be compressed

[PATCH v2 10/28] binman: Update testPackExtra with more checks

2020-10-26 Thread Simon Glass
Check the contents of each section to make sure it is actually in the right place. Also fix a whitespace error in the .dts file. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/ftest.py| 27 ++- tools/binman/test/009_pack_extra.dts |

[PATCH v2 08/28] binman: Move CompressData() into Entry base class

2020-10-26 Thread Simon Glass
At present this is only used by blobs. To allow it to be used by other entry types (such as sections), move it into the base class. Also read the compression type in the base class. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 17 +

[PATCH v2 06/28] binman: Remove references to 'image' in entry_Section

2020-10-26 Thread Simon Glass
While a section is the base class of Image, it is more correct to refer to sections in most places in this file. Fix these comments. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 05/28] binman: Fix return from u-boot-ucode if there is no DT

2020-10-26 Thread Simon Glass
This should return empty contents, not leave it unset. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/u_boot_ucode.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/binman/etype/u_boot_ucode.py b/tools/binman/etype/u_boot_ucode.py index

[PATCH v2 04/28] binman: Give a sensible error if no command is given

2020-10-26 Thread Simon Glass
At present if 'binman' is typed on the command line, a strange error about a missing argument is displayed. Fix this. These does not seem to be standard way to add the 'required' argument in all recent Python versions, so set it manually. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v2 01/28] binman: Update the entry docs

2020-10-26 Thread Simon Glass
This has got out of sync with the entries. Regenerate it. Signed-off-by: Simon Glass --- Changes in v2: - Add a patch to update the entry docs tools/binman/README.entries | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tools/binman/README.entries

[PATCH v2 00/28] binman: Support compression of sections

2020-10-26 Thread Simon Glass
This series includes a number of improvements and refactors to support compressing entire sections. This is sometimes useful when a section contains a number of entries which are accessed as a whole and are best compressed together. Most of the effort here is clarifying what is in a section and

[PATCH v2 03/28] binman: Add tests for skip-at-start sections

2020-10-26 Thread Simon Glass
At present this feature is tested view the end-at-4gb feature. Add some tests of its own, including the operation of padding. The third test here shows binman's current, inconsistent approach to padding in the top-level section. Future patches in this series will address this. Signed-off-by:

Re: [PATCH 10/25] binman: Move section-building code into a function

2020-10-26 Thread Alper Nebi Yasak
On 26/10/2020 22:22, Simon Glass wrote: > On Mon, 19 Oct 2020 at 15:29, Alper Nebi Yasak > wrote: >> On 19/10/2020 05:41, Simon Glass wrote: >>> for entry in self._entries.values(): >>> data = entry.GetData() >>> -base = self.pad_before + (entry.offset or 0) -

Re: [PATCH 16/25] binman: Avoid reporting image-pos with compression

2020-10-26 Thread Alper Nebi Yasak
On 26/10/2020 22:22, Simon Glass wrote: > Hi Alper, > > On Mon, 19 Oct 2020 at 15:29, Alper Nebi Yasak > wrote: >> >> On 19/10/2020 05:41, Simon Glass wrote: >>> When a section is compressed, all entries within it are grouped together >>> into a compressed block of data. This obscures the start

[PATCH v2] Nokia RX-51: Convert to CONFIG_DM_I2C

2020-10-26 Thread Pali Rohár
Use twl4030_i2c_read(), i2c_get_chip_for_busnum() and remove CONFIG_SYS_I2C. Signed-off-by: Pali Rohár --- board/nokia/rx51/rx51.c | 25 +++-- configs/nokia_rx51_defconfig | 2 ++ include/configs/nokia_rx51.h | 2 -- 3 files changed, 21 insertions(+), 8 deletions(-)

SPI Boot - Rock Pi 4

2020-10-26 Thread Anthony Davies
Hi All, I have attempted to use mainline u-boot installed into the SPI flash on my Rock Pi 4B but I can't seem to get it to work. U-Boot was compiled with SPI options (I think I have all the right ones) and BL31 was set correctly. I followed the "Booting from SPI" instructions in

Re: [PATCH 2/2] Nokia RX-51: Convert to CONFIG_DM_I2C

2020-10-26 Thread Tom Rini
On Mon, Oct 26, 2020 at 10:36:16PM +0100, Pali Rohár wrote: > Signed-off-by: Pali Rohár Please include something for the commit message. > --- > board/nokia/rx51/rx51.c | 26 -- > configs/nokia_rx51_defconfig | 2 ++ > include/configs/nokia_rx51.h | 2 ++ > 3

Re: U-Boot i2c bus num 1 is broken on Nokia N900

2020-10-26 Thread Pali Rohár
On Monday 27 April 2020 09:03:13 Heiko Schocher wrote: > Hello Pali, > > Am 26.04.2020 um 01:54 schrieb Pali Rohár: > > Adding Hannes and Heiko to the loop, please look at this problem. > > > > On Saturday 25 April 2020 14:11:32 Pali Rohár wrote: > > > On Saturday 25 April 2020 07:00:58 Adam

Re: [PATCH v3 6/8] mmc: zynq_sdhci: Add clock phase delays for Versal

2020-10-26 Thread Jaehoon Chung
On 10/26/20 8:42 PM, Michal Simek wrote: > From: Ashok Reddy Soma > > Define default values for input and output clock phase delays for > Versal. Also define functions for setting tapdelays based on these > clock phase delays. > > Signed-off-by: Ashok Reddy Soma > Signed-off-by: Michal Simek

Re: [PATCH v3 7/8] mmc: zynq_sdhci: Extend UHS timings till hs200

2020-10-26 Thread Jaehoon Chung
On 10/26/20 8:43 PM, Michal Simek wrote: > From: Ashok Reddy Soma > > Fix the condition to set UHS timings for speeds upto HS200. > > Signed-off-by: Ashok Reddy Soma > Signed-off-by: Michal Simek > Reviewed-by: Peng Fan Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > >

Re: [PATCH v3 4/8] mmc: zynq_sdhci: Read clock phase delays from dt

2020-10-26 Thread Jaehoon Chung
On 10/26/20 8:42 PM, Michal Simek wrote: > Define input and output clock phase delays with pre-defined values. > > Define arasan_sdhci_clk_data type structure and add it to priv > structure and store these clock phase delays in it. > > Read input and output clock phase delays from dt. If these

Re: [PATCH v3 5/8] mmc: zynq_sdhci: Set tapdelays based on clk phase delays

2020-10-26 Thread Jaehoon Chung
On 10/26/20 8:42 PM, Michal Simek wrote: > From: Ashok Reddy Soma > > Define and use functions for setting input and output tapdelays > based on clk phase delays. > > Signed-off-by: Ashok Reddy Soma > Signed-off-by: Michal Simek > Reviewed-by: Peng Fan Reviewed-by: Jaehoon Chung Best

Re: [PATCH v3 3/8] mmc: zynq_sdhci: Move macro to the top

2020-10-26 Thread Jaehoon Chung
On 10/26/20 8:42 PM, Michal Simek wrote: > Just group macros below headers. Other patches will be using this location > too. > > Signed-off-by: Michal Simek > Signed-off-by: Ashok Reddy Soma > Reviewed-by: Peng Fan Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > (no

[PATCH 2/2] Nokia RX-51: Convert to CONFIG_DM_I2C

2020-10-26 Thread Pali Rohár
Signed-off-by: Pali Rohár --- board/nokia/rx51/rx51.c | 26 -- configs/nokia_rx51_defconfig | 2 ++ include/configs/nokia_rx51.h | 2 ++ 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/board/nokia/rx51/rx51.c b/board/nokia/rx51/rx51.c index

[PATCH 1/2] power: twl4030: Add twl4030_i2c_read() function

2020-10-26 Thread Pali Rohár
Function twl4030_i2c_read() is like twl4030_i2c_read_u8() but instead of single value it rather returns array of values. Signed-off-by: Pali Rohár --- drivers/power/twl4030.c | 7 +++ include/twl4030.h | 12 +--- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v4 0/7] wdt: Add support for watchdogs on Kendryte K210

2020-10-26 Thread Tom Rini
On Fri, Oct 23, 2020 at 09:30:24AM -0400, Sean Anderson wrote: > > On 10/1/20 10:56 AM, Sean Anderson wrote: > > On 9/9/20 5:04 PM, Sean Anderson wrote: > >> This series depends on > >> https://patchwork.ozlabs.org/project/uboot/list/?series=200642 > >> > >> Changes in v4: > >> - Fix build error

Re: Pull request: u-boot-riscv/master 20201026

2020-10-26 Thread Tom Rini
On Mon, Oct 26, 2020 at 11:03:00AM +0800, ub...@andestech.com wrote: > Hi Tom, > > Please pull some riscv updates: > > - No need to check before free in kendryte clk. > - Only enable OF_BOARD_FIXUP if U-Boot is configured for S-Mode. > - Reduce k210 dts DMA block size > - Move timers into

Please pull u-boot-video

2020-10-26 Thread Anatolij Gustschin
Hi Tom, please pull more video updates for v2021.01. gitlab CI: https://gitlab.denx.de/u-boot/custodians/u-boot-video/-/pipelines/5138 Thanks! The following changes since commit c99e87f82803500f9811b1e98926d9d25df35b38: Merge branch '2020-10-23-misc-changes' (2020-10-24 10:49:28 -0400)

Re: [PATCH v2] nokia_rx51: disable obsolete VIDEO config

2020-10-26 Thread Anatolij Gustschin
On Mon, 26 Oct 2020 19:58:20 +0100 Anatolij Gustschin ag...@denx.de wrote: > Disable VIDEO config to fix DM_VIDEO conversion > deadline warning. > > Signed-off-by: Anatolij Gustschin > Cc: Pali Rohár > --- > > Changes in v2: > - select CFB_CONSOLE instead of VIDEO to let video console >

Re: [PATCH] xfi3: disable obsolete VIDEO config

2020-10-26 Thread Anatolij Gustschin
On Sun, 18 Oct 2020 21:18:27 +0200 Anatolij Gustschin ag...@denx.de wrote: > DM_VIDEO conversion deadline has passed, disable VIDEO config. > > Signed-off-by: Anatolij Gustschin > Cc: Marek Vasut > --- > configs/xfi3_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied

Re: [PATCH] sansa_fuze_plus: disable obsolete VIDEO config

2020-10-26 Thread Anatolij Gustschin
On Sun, 18 Oct 2020 21:18:26 +0200 Anatolij Gustschin ag...@denx.de wrote: > DM_VIDEO conversion deadline has passed, disable VIDEO config. > > Signed-off-by: Anatolij Gustschin > Cc: Marek Vasut > --- > configs/sansa_fuze_plus_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] picosam9g45: disable obsolete VIDEO config

2020-10-26 Thread Anatolij Gustschin
On Sun, 18 Oct 2020 21:18:25 +0200 Anatolij Gustschin ag...@denx.de wrote: > DM_VIDEO conversion deadline has passed, disable VIDEO config. > > Signed-off-by: Anatolij Gustschin > Cc: Erik van Luijk > --- > configs/picosam9g45_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] ls1021atwr: disable obsolete VIDEO config

2020-10-26 Thread Anatolij Gustschin
On Sun, 18 Oct 2020 21:18:22 +0200 Anatolij Gustschin ag...@denx.de wrote: > DM_VIDEO conversion deadline has passed, disable VIDEO config. > > Signed-off-by: Anatolij Gustschin > --- > configs/ls1021atwr_nor_SECURE_BOOT_defconfig| 4 ++-- > configs/ls1021atwr_nor_defconfig

Re: [PATCH] mx23evk: disable obsolete VIDEO config

2020-10-26 Thread Anatolij Gustschin
On Sun, 18 Oct 2020 21:18:23 +0200 Anatolij Gustschin ag...@denx.de wrote: > DM_VIDEO conversion deadline has passed, disable VIDEO config. > > Signed-off-by: Anatolij Gustschin > Cc: Otavio Salvador > --- > configs/mx23evk_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] ls1021aqds: disable obsolete VIDEO config

2020-10-26 Thread Anatolij Gustschin
On Sun, 18 Oct 2020 21:18:21 +0200 Anatolij Gustschin ag...@denx.de wrote: > DM_VIDEO conversion deadline has passed, disable VIDEO config. > > Signed-off-by: Anatolij Gustschin > Cc: Alison Wang > --- > configs/ls1021aqds_ddr4_nor_defconfig| 4 ++-- >

Re: [PATCH] eb_cpu5282: fix CONFIG_DM_VIDEO build warnings

2020-10-26 Thread Anatolij Gustschin
On Sun, 18 Oct 2020 21:18:18 +0200 Anatolij Gustschin ag...@denx.de wrote: > Remove CONFIG_VIDEO dependency to fix board removal warnings. > > Signed-off-by: Anatolij Gustschin > Cc: Jens Scharsig > --- > board/BuS/eb_cpu5282/eb_cpu5282.c | 7 +++ > common/stdio.c

Re: [PATCH] imx: mx6sxsabresd: disable obsolete VIDEO config

2020-10-26 Thread Anatolij Gustschin
On Sun, 18 Oct 2020 21:18:19 +0200 Anatolij Gustschin ag...@denx.de wrote: > DM_VIDEO conversion deadline has passed, disable VIDEO config. > > Signed-off-by: Anatolij Gustschin > --- > configs/mx6sxsabresd_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to

  1   2   >