Re: [PATCH 1/2] pinctrl: k210: Fix inverted IE and OE for I2C

2020-11-12 Thread Rick Chen
Hi Sean > > I2C and SCCB previously shared defaults. However, SCCB needs OE_INV and > > IE_INV set, but I2C cannot have those bits set. This adds a separate > > default for SCCB. > > > > Signed-off-by: Sean Anderson > > Reported-by: Damien Le Moal > > --- > > > >

Re: [PATCH v8 00/18] efi_loader: add capsule update support

2020-11-12 Thread Heinrich Schuchardt
On 11/13/20 5:14 AM, AKASHI Takahiro wrote: > Summary > === > 'UpdateCapsule' is one of runtime services defined in UEFI specification > and its aim is to allow a caller (OS) to pass information to the firmware, > i.e. U-Boot. This is mostly used to update firmware binary on devices by >

Re: [PATCH v2 1/2] i2c: ocores: add i2c driver for OpenCores I2C controller

2020-11-12 Thread Rick Chen
Hi Pragnesh > > From: Pragnesh Patel [mailto:pragnesh.pa...@sifive.com] > > Sent: Thursday, October 22, 2020 2:55 PM > > To: u-boot@lists.denx.de > > Cc: atish.pa...@wdc.com; palmerdabb...@google.com; bmeng...@gmail.com; > > paul.walms...@sifive.com; anup.pa...@wdc.com; sagar.ka...@sifive.com;

RE: [PATCH] usb: xhci: fix event trb handling missed

2020-11-12 Thread Ran Wang
Hi Bin, On Friday, November 13, 2020 2:25 PM Bin Meng wrote: > > Hi Ran, > > On Wed, Nov 11, 2020 at 4:07 PM Ran Wang wrote: > > > > Hi Bin > > > > On Tuesday, November 10, 2020 5:55 PM, Ran Wang wrote: > > > > > > Hi Bin, > > > > > > > > > > > > > > record_transfer_result():comp_code: 1 csw

Re: [PATCH] usb: xhci: fix event trb handling missed

2020-11-12 Thread Bin Meng
Hi Ran, On Wed, Nov 11, 2020 at 4:07 PM Ran Wang wrote: > > Hi Bin > > On Tuesday, November 10, 2020 5:55 PM, Ran Wang wrote: > > > > Hi Bin, > > > > > > > > > record_transfer_result():comp_code: 1 csw org fbb4ec90, > > > > adjusted to fbb4fffe > > > >

[PATCH v8 16/18] test/py: efi_capsule: test for FIT image capsule

2020-11-12 Thread AKASHI Takahiro
The test can run on sandbox build and it attempts to execute a firmware update via a capsule-on-disk, using a FIT image capsule, CONFIG_EFI_CAPSULE_FIT. To run this test successfully, you need configure U-Boot specifically; See test_capsule_firmware.py for requirements, and hence it won't run on

[PATCH v8 15/18] tools: add mkeficapsule command for UEFI capsule update

2020-11-12 Thread AKASHI Takahiro
This is a utility mainly for test purpose. mkeficapsule -f: create a test capsule file for FIT image firmware Having said that, you will be able to customize the code to fit your specific requirements for your platform. Signed-off-by: AKASHI Takahiro --- tools/Makefile | 2 +

[PATCH v8 18/18] sandbox: enable capsule update for testing

2020-11-12 Thread AKASHI Takahiro
Add more configuration options to allow for efi capsule update on sandbox. Signed-off-by: AKASHI Takahiro --- configs/sandbox64_defconfig | 6 ++ configs/sandbox_defconfig | 6 ++ 2 files changed, 12 insertions(+) diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig

[PATCH v8 14/18] cmd: add "efidebug capsule" command

2020-11-12 Thread AKASHI Takahiro
"efidebug capsule" is more or less a debugging utility. efidebug capsule update: invoke UpdateCapsule against data on memory efidebug capsule show: show a capsule header efidebug capsule result: dump a capsule result variable Signed-off-by: AKASHI Takahiro --- cmd/efidebug.c | 235

[PATCH v8 13/18] efi_loader: add firmware management protocol for raw image

2020-11-12 Thread AKASHI Takahiro
In this commit, a very simple firmware management protocol driver is implemented. It will take a binary image in a capsule file and apply the data using dfu backend storage drivers via dfu_write_by_alt() interface. So "dfu_alt_info" variable should be properly set to specify a device and location

[PATCH v8 17/18] test/py: efi_capsule: test for raw image capsule

2020-11-12 Thread AKASHI Takahiro
The test can run on sandbox build and it attempts to execute a firmware update via a capsule-on-disk, using a raw image capsule, CONFIG_EFI_CAPSULE_RAW. To run this test successfully, you need configure U-Boot specifically; See test_capsule_firmware.py for requirements, and hence it won't run on

[PATCH v8 10/18] efi_loader: capsule: support firmware update

2020-11-12 Thread AKASHI Takahiro
A capsule tagged with the guid, EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID, is handled as a firmware update object. What efi_update_capsule() basically does is to load any firmware management protocol (or fmp) drivers contained in a capsule, find out an appropriate fmp driver and then invoke its

[PATCH v8 12/18] dfu: add dfu_write_by_alt()

2020-11-12 Thread AKASHI Takahiro
This function is a variant of dfu_write_by_name() and takes a DFU alt setting number for dfu configuration. It will be utilised to implement UEFI capsule management protocol for raw image in a later commit. Signed-off-by: AKASHI Takahiro --- drivers/dfu/dfu_alt.c | 47

[PATCH v8 08/18] efi_loader: capsule: add capsule_on_disk support

2020-11-12 Thread AKASHI Takahiro
Capsule data can be loaded into the system either via UpdateCapsule runtime service or files on a file system (of boot device). The latter case is called "capsules on disk", and actual updates will take place at the next boot time. In this commit, we will support capsule on disk mechanism.

[PATCH v8 11/18] efi_loader: add firmware management protocol for FIT image

2020-11-12 Thread AKASHI Takahiro
In this commit, a very simple firmware management protocol driver is implemented. It will take a common FIT image firmware in a capsule file and apply the data using dfu backend storage drivers via update_fit() interface. So "dfu_alt_info" variable should be properly set to specify a device and

[PATCH v8 09/18] efi_loader: capsule: add memory range capsule definitions

2020-11-12 Thread AKASHI Takahiro
Memory range capsule gives us a way to notify that some memory regions should be left untouched across the next reset. See UEFI specification, section 8.5.3. Since how we should handle this kind of capsule is totally up to the system, no implementation will be added in this commit.

[PATCH v8 07/18] efi_loader: define UpdateCapsule api

2020-11-12 Thread AKASHI Takahiro
In this commit, skeleton functions for capsule-related API's are added under CONFIG_EFI_UPDATE_CAPSULE configuration. Detailed implementation for a specific capsule type will be added in the succeeding patches. Signed-off-by: AKASHI Takahiro --- include/efi_api.h| 12 +++

[PATCH v8 06/18] efi_loader: add efi_create_indexed_name()

2020-11-12 Thread AKASHI Takahiro
This function will be used from several places in UEFI subsystem to generate some specific form of utf-16 variable name. For example, L"Capsule0001" Signed-off-by: AKASHI Takahiro --- include/efi_loader.h | 3 +++ lib/efi_loader/efi_setup.c | 30 ++ 2 files

[PATCH v8 05/18] efi_loader: add option to initialise EFI subsystem early

2020-11-12 Thread AKASHI Takahiro
If this option, CONFIG_EFI_SETUP_EARLY, is enabled, the initialisation of UEFI subsystem will be done as part of U-Boot initialisation. Please note that this option won't be enabled explicitly by users, instead, should be enabled implicitly by other configuration options. Specifically, this

[PATCH v8 04/18] dfu: export dfu_list

2020-11-12 Thread AKASHI Takahiro
This variable will be utilized to enumerate all dfu entities for UEFI capsule firmware update in a later commit. Signed-off-by: AKASHI Takahiro --- drivers/dfu/dfu.c | 2 +- include/dfu.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dfu/dfu.c

[PATCH v8 03/18] common: update: add a generic interface for FIT image

2020-11-12 Thread AKASHI Takahiro
The main purpose of this patch is to separate a generic interface for updating firmware using DFU drivers from "auto-update" via tftp. This function will also be used in implementing UEFI capsule update in a later commit. Signed-off-by: AKASHI Takahiro --- common/Kconfig | 15 ++

[PATCH v8 02/18] dfu: modify an argument type for an address

2020-11-12 Thread AKASHI Takahiro
The range of an addressable pointer can go beyond 'integer'. So change the argument type to a void pointer. Signed-off-by: AKASHI Takahiro Reviewed-by: Heinrich Schuchardt --- common/update.c | 3 ++- drivers/dfu/dfu_alt.c | 6 +++--- include/dfu.h | 4 ++-- 3 files changed, 7

[PATCH v8 01/18] dfu: rename dfu_tftp_write() to dfu_write_by_name()

2020-11-12 Thread AKASHI Takahiro
This function is essentially independent from tftp, and will also be utilised in implementing UEFI capsule update in a later commit. So just give it a more generic name. In addition, a new configuration option, CONFIG_DFU_WRITE_ALT, was introduced so that the file will be compiled with different

[PATCH v8 00/18] efi_loader: add capsule update support

2020-11-12 Thread AKASHI Takahiro
Summary === 'UpdateCapsule' is one of runtime services defined in UEFI specification and its aim is to allow a caller (OS) to pass information to the firmware, i.e. U-Boot. This is mostly used to update firmware binary on devices by instructions from OS. While 'UpdateCapsule' is a runtime

Re: [PATCH] env: mmc: Correct partition comparison in mmc_offset_try_partition

2020-11-12 Thread Hoyeonjiki Kim
On Fri, Nov 13, 2020 at 5:06 AM Wolfgang Denk wrote: > > Dear Hoyeonjiki Kim, > > In message <20201112123026.458-1-jigi@gmail.com> you wrote: > > The function mmc_offset_try_partition searches MMC partition to save the > > environment data by name. However, it only compares the first

Re: [PATCH v2] env: mmc: Correct partition comparison in mmc_offset_try_partition

2020-11-12 Thread Hoyeonjiki Kim
On Fri, Nov 13, 2020 at 5:07 AM Wolfgang Denk wrote: > > Dear Hoyeonjiki Kim, > > In message <20201112131237.1239-1-jigi@gmail.com> you wrote: > > The function mmc_offset_try_partition searches MMC partition to save the > > environment data by name. However, it only compares the first

RE: [RESEND v2 07/22] arm: socfpga: Rearrange sequence of macros in handoff_soc64.h

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, November 10, 2020 2:44 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

RE: [RESEND v2 06/22] arm: socfpga: Changed system_manager_s10.c to system_manager_soc64.c

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, November 10, 2020 2:44 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

RE: [RESEND v2 05/22] arm: socfpga: Changed wrap_pll_config_s10.c to wrap_pll_config_soc64.c

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, November 10, 2020 2:44 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

RE: [RESEND v2 04/22] arm: socfpga: Rename Stratix10 and Agilex handoff common macros

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, November 10, 2020 2:44 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

RE: [RESEND v2 03/22] arm: socfpga: dm: Add firewall support for Agilex and Diamond Mesa

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, November 10, 2020 2:44 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

[PATCH 2/2] arm: dts: enable MTK SPI NOR controller driver

2020-11-12 Thread SkyLake Huang
From: "SkyLake.Huang" Enable MTK SPI NOR controller driver on mt7622 & mt7629. Signed-off-by: SkyLake.Huang --- arch/arm/dts/mt7622-rfb.dts | 14 +- arch/arm/dts/mt7622.dtsi | 7 +++ arch/arm/dts/mt7629-rfb.dts | 14 +- arch/arm/dts/mt7629.dtsi | 9

[PATCH 1/2] spi: mtk_snor: add support for MTK SPI NOR controller

2020-11-12 Thread SkyLake Huang
From: "SkyLake.Huang" This patch adds support for MTK SPI NOR controller, which you can see on mt7622 & mt7629. This controller is designed only for SPI NOR. We can't adjust its bus clock dynamically. Set clock in dts instead. Signed-off-by: SkyLake.Huang --- drivers/spi/Kconfig| 7 +

[PATCH 0/2] *** Add support for Mediatek mt762x SoC ***

2020-11-12 Thread SkyLake Huang
From: "SkyLake.Huang" This patch adds support MTK's SPI NOR controller on mt7622 & mt7629. With this controller, you can access SPI NOR with better performance on mt762x platform. SkyLake.Huang (2): spi: mtk_snor: add support for MTK SPI NOR controller arm: dts: enable MTK SPI NOR

Re: [PATCH 5/5] dtoc: Tidy up Python style in dtb_platdata

2020-11-12 Thread Walter Lozano
Hi Simon, Thanks for this series. I've tried to test it but I had issues to apply it. I have tried in u-boot, both master and next, and u-boot-dm. Could you please point me to the right tree/version? On 9/11/20 00:36, Simon Glass wrote: Update this, mostly to add comments for argument and

RE: [RESEND v2 02/22] arm: socfpga: dm: Add base address for Intel Diamond Mesa

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, November 10, 2020 2:44 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

RE: [RESEND v2 01/22] arm: socfpga: Move Stratix10 and Agilex to use TARGET_SOCFPGA_SOC64

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, November 10, 2020 2:44 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

RE: [v3 16/16] configs: socfpga: Add defconfig for Agilex and Stratix 10 with ATF support

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Thursday, October 15, 2020 8:30 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Ang, > Chee Hong ; Lim, Elly

RE: [v3 15/16] arm: socfpga: soc64: Enable FIT image generation using binman

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Thursday, October 15, 2020 8:30 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Lim, > Elly Siew Chin >

RE: [v3 14/16] arm: socfpga: dts: soc64: Add binman node of FIT image with ATF support

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Thursday, October 15, 2020 8:30 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Lim, > Elly Siew Chin >

[PATCH 2/2 v5] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-12 Thread Ilias Apalodimas
Since U-boot EFI implementation is getting richer it makes sense to add support for EFI_TCG2_PROTOCOL taking advantage of any hardware TPM available on the device. This is the initial implementation of the protocol which only adds support for GetCapability(). It's limited in the newer and safer

[PATCH 1/2 v5] tpm: Add some headers from the spec

2020-11-12 Thread Ilias Apalodimas
A following patch introduces EFI_TCG2_PROTOCOL. Add the required TPMv2 headers to support it. Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- * changes since v3: - Add TPM2 prefix on PT_GROUP, PT_FIXED * changes since v2: - Added description and

Secure the environment variables

2020-11-12 Thread Jorge Cisneros
Hi All I'm new in this mail list, this is my first post, I have a question is there any way to protect the variables on the environment file? I search on the Internet and look like is possible to make the variables read-only or write-one but is not working for me, maybe I doing something wrong?

Re: [PATCH 1/1] efi_selftest: keep devices in ExitBootServices()

2020-11-12 Thread Ilias Apalodimas
On Thu, Nov 12, 2020 at 09:29:21PM +0100, Heinrich Schuchardt wrote: > When calling ExitBootServices during out unit tests we should not detach > devices as we need console output for runtime tests. > > Fixes: 529441ca89b1 ("efi_loader: Disable devices before handing over > control") >

Re: [U-Boot] Issue in u-boot; TFTP error: trying to overwrite reserved memory...

2020-11-12 Thread Bernhard Kirchen
Hello Christopher, hello SImon, today I debugged this problem, as tftp was not working in my u-boot SPL (AM335x based custom board) for the reasons described in this thread. It turns out that lmb_init_and_reserve() could not set proper values as bd->bi_dram[0].size = . The reason IMHO is

[PATCH 1/1] efi_selftest: keep devices in ExitBootServices()

2020-11-12 Thread Heinrich Schuchardt
When calling ExitBootServices during out unit tests we should not detach devices as we need console output for runtime tests. Fixes: 529441ca89b1 ("efi_loader: Disable devices before handing over control") Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h| 3 +++

Re: [PATCH v2] env: mmc: Correct partition comparison in mmc_offset_try_partition

2020-11-12 Thread Wolfgang Denk
Dear Hoyeonjiki Kim, In message <20201112131237.1239-1-jigi@gmail.com> you wrote: > The function mmc_offset_try_partition searches MMC partition to save the > environment data by name. However, it only compares the first word-size > bytes (size of 'const char *'), which may make the function

Re: [PATCH] env: mmc: Correct partition comparison in mmc_offset_try_partition

2020-11-12 Thread Wolfgang Denk
Dear Hoyeonjiki Kim, In message <20201112123026.458-1-jigi@gmail.com> you wrote: > The function mmc_offset_try_partition searches MMC partition to save the > environment data by name. However, it only compares the first word-size > bytes (size of 'const char *'), which may make the function

Re: [PATCH] env: mmc: Correct partition comparison in mmc_offset_try_partition

2020-11-12 Thread Wolfgang Denk
Dear Jaehoon Chung, In message <21adc771-9660-da52-65c8-c2029de9a...@samsung.com> you wrote: > On 11/10/20 11:28 PM, Hoyeonjiki Kim wrote: > > The function mmc_offset_try_partition searches MMC partition to save the > > environment data by name. However, it only compares the first word-size > >

Re: [PATCH 4/5] env: allow default environment to be amended from control dtb

2020-11-12 Thread Wolfgang Denk
Dear Rasmus Villemoes, In message <20201110202603.20944-5-rasmus.villem...@prevas.dk> you wrote: > It can be useful to use the same U-Boot binary for multiple purposes, > say the normal one, one for developers that allow breaking into the > U-Boot shell, and one for use during bootstrapping which

Re: [PATCH 3/5] env: make env_set_default_vars() return void

2020-11-12 Thread Wolfgang Denk
Dear Rasmus, In message <20201110202603.20944-4-rasmus.villem...@prevas.dk> you wrote: > Unlike most other functions declared in env.h, the return value of > this one also isn't documented. It only has a single caller, which > ignores the return value. And the companion, env_set_default(), >

Re: [PATCH 2/2 v4] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-12 Thread Ilias Apalodimas
On Thu, 12 Nov 2020 at 21:22, Heinrich Schuchardt wrote: > On 11/12/20 8:10 PM, Ilias Apalodimas wrote: > > Hi Heinrich, > > > > > > [...] > >>> + return EFI_SUCCESS; > >>> + > >>> + tpm_ver = tpm_get_version(dev); > >>> + if (tpm_ver != TPM_V2) { > >>> +

Re: [PATCH 2/2 v4] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-12 Thread Heinrich Schuchardt
On 11/11/20 10:18 AM, Ilias Apalodimas wrote: > Since U-boot EFI implementation is getting richer it makes sense to > add support for EFI_TCG2_PROTOCOL taking advantage of any hardware TPM > available on the device. > > This is the initial implementation of the protocol which only adds > support

Re: [PATCH 2/2 v4] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-12 Thread Heinrich Schuchardt
On 11/12/20 8:10 PM, Ilias Apalodimas wrote: > Hi Heinrich, > > > [...] >>> + return EFI_SUCCESS; >>> + >>> + tpm_ver = tpm_get_version(dev); >>> + if (tpm_ver != TPM_V2) { >>> + log_warning("Only TPMv2 supported for EFI_TCG2_PROTOCOL"); >> >> The message should end with

Re: [PATCH 2/2 v4] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-12 Thread Heinrich Schuchardt
On 11/12/20 7:49 PM, Heinrich Schuchardt wrote: > On 11/11/20 10:18 AM, Ilias Apalodimas wrote: >> Since U-boot EFI implementation is getting richer it makes sense to >> add support for EFI_TCG2_PROTOCOL taking advantage of any hardware TPM >> available on the device. >> >> This is the initial

Re: [PATCH 2/2 v4] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-12 Thread Ilias Apalodimas
Hi Heinrich, [...] > > + return EFI_SUCCESS; > > + > > + tpm_ver = tpm_get_version(dev); > > + if (tpm_ver != TPM_V2) { > > + log_warning("Only TPMv2 supported for EFI_TCG2_PROTOCOL"); > > The message should end with \n. > > This message becomes superfluous if you

RE: [PATCH v3 4/4] dm: soc: SoC identification driver for Renesas SoC's

2020-11-12 Thread Biju Das
Hi All, I need to update copyright information for this patch. This work is derived from linux and linux has extra copyright information. I have missed that. Will send V4 for fixing it. Regards, Biju > -Original Message- > From: Biju Das > Sent: 04 November 2020 10:56 > To: Simon

Re: [PATCH 2/2 v4] efi: Add basic EFI_TCG2_PROTOCOL support

2020-11-12 Thread Heinrich Schuchardt
On 11/11/20 10:18 AM, Ilias Apalodimas wrote: > Since U-boot EFI implementation is getting richer it makes sense to > add support for EFI_TCG2_PROTOCOL taking advantage of any hardware TPM > available on the device. > > This is the initial implementation of the protocol which only adds > support

[PATCH v2] arm: vexpress: don't reset flags in board_init for vexpress boards

2020-11-12 Thread Arnaud Aujon Chevallier
Re-submitted because of missing description and signed-off flags reset in board_init caused bugs when executing command like editenv because the reallocated flag was lost. Signed-off-by: Arnaud Aujon Chevallier

[PATCH] vexpress: don't reset flags in board_init to avoid losing previous ones

2020-11-12 Thread Arnaud Aujon Chevallier
--- board/armltd/vexpress/vexpress_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/armltd/vexpress/vexpress_common.c b/board/armltd/vexpress/vexpress_common.c index 70f6cd80d5..8fea8ff352 100644 --- a/board/armltd/vexpress/vexpress_common.c +++

RE: [PATCH v3 1/4] dm: core: Add of_match_node helper function

2020-11-12 Thread Biju Das
Hi Simon, Gentle ping. Are you happy with this patch? Regards, Biju > -Original Message- > From: Biju Das > Sent: 04 November 2020 10:56 > To: Simon Glass > Cc: Biju Das ; u-boot@lists.denx.de; Marek > Vasut ; Nobuhiro Iwamatsu > ; Chris Paterson ; > Prabhakar Mahadev Lad > Subject:

Properly using gpio_request and pinmux for GPIO

2020-11-12 Thread Oliver Westermann
Hey, I'm wondering if there is documentation or a good example on how to configure pin muxing in combination with the gpio_request functions. Our current implementation is incomplete as it doesn't handle the muxing, but before randomly copying code I would like to know what the "upstream" way of

Re: [PATCH 1/1] riscv: Fix efi header size for RV32

2020-11-12 Thread Heinrich Schuchardt
On 12.11.20 14:43, Leo Liang wrote: > Date: Thu, 12 Nov 2020 10:09:52 +0800 > From: Leo Yu-Chi Liang > Subject: [PATCH 1/1] riscv: Fix efi header size for RV32 > > This patch depends on Atish's patch. >

[PATCH 1/1] riscv: Fix efi header size for RV32

2020-11-12 Thread Leo Liang
Date: Thu, 12 Nov 2020 10:09:52 +0800 From: Leo Yu-Chi Liang Subject: [PATCH 1/1] riscv: Fix efi header size for RV32 This patch depends on Atish's patch. (https://patchwork.ozlabs.org/project/uboot/patch/20201013192331.3236458-1-atish.pa...@wdc.com/) Modify the size of the Optional Header

Re: [PATCH RESEND v2 0/2] arm64: meson: add libretech cc v2 support

2020-11-12 Thread Neil Armstrong
On 06/11/2020 10:45, Jerome Brunet wrote: > This patchset adds support for the Amlogic based libretech cc v2. > Like the v1, this revised platform used the s905x SoC. > > Changes since v1: > - Move Makefile change to patch #1 > - Amend documentation for libretech cc v2 > > Jerome Brunet (2): >

Re: [PATCH] video: add TDO tl070wsh30 panel driver

2020-11-12 Thread Neil Armstrong
On 06/11/2020 20:02, Anatolij Gustschin wrote: > On Fri, 6 Nov 2020 11:29:47 +0100 > Neil Armstrong narmstr...@baylibre.com wrote: > >> This adds support for the TDO TL070WSH30 TFT-LCD panel module. >> The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. >> It provides a MIPI DSI

Re: [PATCH 0/4] ARM: upgrade Amlogic DT to Linux 5.10

2020-11-12 Thread Neil Armstrong
On 06/11/2020 11:18, Neil Armstrong wrote: > This syncs the Amlogic DT to 5.10, and : > - adds support for the new common MESON_EE_POWER_DOMAIN synced on 5.10 > - adds Odroid-N2+ DT using the Odroid-N2 DT as base > > Neil Armstrong (4): > ARM: dts: sync Amlogic GX & AXG from Linux 5.10-rc1 >

Re: i.MX USB SDP broken on imx6q-sabresd

2020-11-12 Thread Heiko Schocher
Hello Fabio, Am 12.11.2020 um 13:52 schrieb Fabio Estevam: Hi Heiko, On Thu, Nov 12, 2020 at 2:12 AM Heiko Schocher wrote: Hmm... just tried cuurent mainline on an imx6ull based board, works fine for me, see log [1] ... Ok, I boot signed image: u-boot-ivt.img.signed Thanks for your test.

Re: [PATCH v2 0/3] mmc: meson-gx: fix mmc & sdcard failur on SM1 SoCs

2020-11-12 Thread Neil Armstrong
On 11/11/2020 00:22, Jaehoon Chung wrote: > Amlogic SM1 SoCs doesn't work over 50MHz. When phase sets to 270', it's > working fine over 50MHz on Amlogic SM1 SoCs. > > To use a proper phase value adds an u-boot only sm1 compatible. > > In future, it needs to find what value is a proper about each

Re: [PATCH] ARM: mach-meson: update SoC IDs

2020-11-12 Thread Neil Armstrong
On 09/11/2020 14:33, Neil Armstrong wrote: > Update From Linux commits > - 240051cb833b ("soc: amlogic: meson-gx-socinfo: Add A1 and A113L IDs") > - 1d7c541b8a5b ("soc: amlogic: meson-gx-socinfo: Add S905X3 ID for VIM3L") > - fdfc6997bd08 ("soc: amlogic: meson-gx-socinfo: Fix S905D3 ID for VIM3L")

[PATCH v2] env: mmc: Correct partition comparison in mmc_offset_try_partition

2020-11-12 Thread Hoyeonjiki Kim
The function mmc_offset_try_partition searches MMC partition to save the environment data by name. However, it only compares the first word-size bytes (size of 'const char *'), which may make the function to find unintended partition. Correct the function not to partially compare the partition

Re: [PATCH] env: mmc: Correct partition comparison in mmc_offset_try_partition

2020-11-12 Thread Hoyeonjiki Kim
Mis-submitted the patch without versioning... :( I'll re-submit my patch again. Sorry for interrupting you. Best Regards, Hoyeonjiki Kim On Thu, Nov 12, 2020 at 9:30 PM Hoyeonjiki Kim wrote: > > The function mmc_offset_try_partition searches MMC partition to save the > environment data by

Re: i.MX USB SDP broken on imx6q-sabresd

2020-11-12 Thread Fabio Estevam
Hi Heiko, On Thu, Nov 12, 2020 at 2:12 AM Heiko Schocher wrote: > Hmm... just tried cuurent mainline on an imx6ull based board, works > fine for me, see log [1] ... Ok, I boot signed image: u-boot-ivt.img.signed Thanks for your test. I suppose your board does not use CONFIG_SPL_LOAD_FIT=y.

Properly using gpio_request and muxing

2020-11-12 Thread Oliver Westermann
Hey, I'm wondering if there is documentation or a good example on how to configure pin muxing in combination with the gpio_request functions. Our current implementation is incomplete as it doesn't handle the muxing, but before randomly copying code I would like to know what the "upstream" way of

Re: [PATCH] common/board_r: make sure to call initr_dm() before initr_trace()

2020-11-12 Thread Heinrich Schuchardt
On 11/12/20 12:18 PM, Pragnesh Patel wrote: > Tracing need timer ticks and initr_dm() will make gd->timer and > gd->dm_root is equal to NULL, so make sure that initr_dm() to > call before tracing got enabled. > > Signed-off-by: Pragnesh Patel > --- > common/board_r.c | 6 +++--- > 1 file

[PATCH] env: mmc: Correct partition comparison in mmc_offset_try_partition

2020-11-12 Thread Hoyeonjiki Kim
The function mmc_offset_try_partition searches MMC partition to save the environment data by name. However, it only compares the first word-size bytes (size of 'const char *'), which may make the function to find unintended partition. Correct the function not to partially compare the partition

RE: [PATCH v3 1/1] riscv: Add timer_get_us() for tracing

2020-11-12 Thread Pragnesh Patel
>-Original Message- >From: U-Boot On Behalf Of Pragnesh Patel >Sent: 12 November 2020 13:06 >To: Heinrich Schuchardt ; Simon Glass > >Cc: atish.pa...@wdc.com; palmerdabb...@google.com; u-boot@lists.denx.de; >bmeng...@gmail.com; Paul Walmsley ( Sifive) ; >anup.pa...@wdc.com; Sagar Kadam ;

Re: [PATCH] env: mmc: Correct partition comparison in mmc_offset_try_partition

2020-11-12 Thread Hoyeonjiki Kim
On Thu, Nov 12, 2020 at 8:34 AM Jaehoon Chung wrote: > > Hi, > > On 11/11/20 7:25 PM, 김호연지기 wrote: > > On Wed, Nov 11, 2020 at 7:07 PM Jorge Ramirez-Ortiz, Gmail > > wrote: > >> > >> On 11/11/20, Jaehoon Chung wrote: > >>> On 11/10/20 11:28 PM, Hoyeonjiki Kim wrote: > The function

RE: [v3 09/16] arm: socfpga: soc64: Add ATF support for Reset Manager driver

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Thursday, October 15, 2020 8:30 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Ang, > Chee Hong ; Lim, Elly

[PATCH v1] imx: clk: added IPG Clock for I2C on imx8qm

2020-11-12 Thread Oliver Graute
This patch fixes this clk issue on I2C on imx8qm => i2c bus Bus 3: i2c@5a83 => i2c dev 3 Setting bus to 3 Failed to enable ipg clk Failure changing bus number (-524) Signed-off-by: Oliver Graute Cc: Stefano Babic Cc: Peng Fan Cc: uboot-imx --- drivers/clk/imx/clk-imx8qm.c | 24

Re: I2C on imx8qm - Failed to enable ipg clk

2020-11-12 Thread Oliver Graute
On 10/08/20, Oliver Graute wrote: > On 05/08/20, Anatolij Gustschin wrote: > > Hi Oliver, > > > > On Wed, 5 Aug 2020 15:47:07 +0200 > > Oliver Graute oliver.gra...@gmail.com wrote: > > > > > Hello, > > > > > > I try to get my I2C working on imx8qm. But I run into this issue: > > > > > > => i2c

RE: [v3 08/16] net: designware: socfpga: Add ATF support for MAC driver

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Thursday, October 15, 2020 8:30 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Ang, > Chee Hong ; Lim, Elly

RE: [v3 07/16] mmc: dwmmc: socfpga: Add ATF support for MMC driver

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Thursday, October 15, 2020 8:30 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Ang, > Chee Hong ; Lim, Elly

RE: [v3 02/16] arm: socfpga: soc64: Load FIT image with ATF support

2020-11-12 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Thursday, October 15, 2020 8:30 PM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Ang, > Chee Hong ; Lim, Elly

Re: [PATCH v2 2/3] mmc: meson-gx: change clock phase value on SM1 SoCs

2020-11-12 Thread Anand Moon
Hi Jaehoon, On Wed, 11 Nov 2020 at 04:52, Jaehoon Chung wrote: > > From: Neil Armstrong > > Amlogic SM1 SoCs doesn't work over 50MHz. When phase sets to 270', it's > working fine over 50MHz on Amlogic SM1 SoCs. > Since Other Amlogic SoCs doens't report an issue, phase value is using > to 180'

[PATCH v4 22/23] reset: reset-mtmips: add DM_FLAG_PRE_RELOC flag

2020-11-12 Thread Weijie Gao
Add DM_FLAG_PRE_RELOC flag for reset-mtmips to make sure this driver can be probed before relocation even if u-boot,dm-pre-reloc is not present in the dts. Reviewed-by: Stefan Roese Signed-off-by: Weijie Gao --- v4 changes: none v3 changes: none v2 changes: new --- drivers/reset/reset-mtmips.c

[PATCH v4 23/23] MAINTAINERS: add maintainer for MediaTek MIPS platform

2020-11-12 Thread Weijie Gao
Update maintainer for MediaTek MIPS platform Acked-by: Stefan Roese Reviewed-by: Stefan Roese Signed-off-by: Weijie Gao --- v4 changes: none v3 changes: none v2 changes: none --- MAINTAINERS | 23 +++ 1 file changed, 23 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH v4 19/23] mmc: mtk-sd: fix sclk cycles shift value

2020-11-12 Thread Weijie Gao
It turns out that the sclk cycles used by mt7620/mt7628 is the same as other chips (20 bits, 1048576), not 65536. This patch removes sclk_cycle_shift from dev_comp, and uses a macro with a value 20 instead. Reviewed-by: Stefan Roese Signed-off-by: Weijie Gao --- v4 changes: none v3 changes:

[PATCH v4 21/23] mmc: mtk-sd: assign plat->cfg.f_max with a correct value

2020-11-12 Thread Weijie Gao
Currently this driver does not set the value of plat->cfg.f_max, which results in that MMC framework will always run at the lowest frequency. This patch sets plat->cfg.f_max to the maximum allowed frequency, which equals to the source clock frequency. Reviewed-by: Stefan Roese Signed-off-by:

[PATCH v4 20/23] mmc: mtk-sd: add pad control settings for MediaTek MT7620/MT76x8 SoCs

2020-11-12 Thread Weijie Gao
The driver is missing pad control settings (pad delay and pad conf) for the mt7620 and mt76x8. Although mt76x8 still works well, mt7620 will encounter CRC error on data transfers. This patch adds default pad control settings for mt7620_compat. Reviewed-by: Stefan Roese Signed-off-by: Weijie Gao

[PATCH v4 17/23] phy: add USB PHY driver for MediaTek MT7620 SoC

2020-11-12 Thread Weijie Gao
This patch adds USB PHY driver for MediaTek MT7620 SoC Reviewed-by: Stefan Roese Signed-off-by: Weijie Gao --- v4 changes: none v3 changes: remove duplicated dev field in mt7620_usb_phy v2 changes: none --- drivers/phy/Kconfig | 7 +++ drivers/phy/Makefile | 1 +

[PATCH v4 18/23] net: add ethernet driver for MediaTek MT7620 SoC

2020-11-12 Thread Weijie Gao
This patch adds ethernet driver for MediaTek MT7620 SoC. The MT7620 SoC has a built-in ethernet (Frame Engine) and a built-in 7-port switch and two xMII interfaces (can be MII/RMII/RGMII). The port 0-3 of the switch connects to intergrited FE PHYs. Port 4 can be configured to connect to either

[PATCH v4 16/23] spi: add spi controller support for MediaTek MT7620 SoC

2020-11-12 Thread Weijie Gao
This patch adds spi controller support for MediaTek MT7620 SoC. The SPI controller supports two chip selects. These two chip selects are implemented as two separate register groups, but they share the same bus (DI/DO/CLK), only CS pins are dedicated for each register group. Appearently these two

[PATCH v4 13/23] pinctrl: mtmips: add support for MediaTek MT7620 SoC

2020-11-12 Thread Weijie Gao
This patch adds pinctrl support for MediaTek MT7620 SoC. The MT7620 SoC supports only pinmux. Reviewed-by: Stefan Roese Signed-off-by: Weijie Gao --- v4 changes: none v3 changes: none v2 changes: none --- drivers/pinctrl/mtmips/Kconfig | 9 ++ drivers/pinctrl/mtmips/Makefile

[PATCH v4 15/23] gpio: add GPIO controller driver for MediaTek MT7620 SoC

2020-11-12 Thread Weijie Gao
This patch adds GPIO controller driver for MediaTek MT7620 SoC Reviewed-by: Stefan Roese Reviewed-by: Simon Glass Signed-off-by: Weijie Gao --- v4 changes: none v3 changes: none v2 changes: none --- drivers/gpio/Kconfig | 8 ++ drivers/gpio/Makefile | 1 +

[PATCH v4 14/23] watchdog: add watchdog driver for MediaTek MT7620 SoC

2020-11-12 Thread Weijie Gao
This patch adds watchdog support for the Mediatek MT7620 SoC Reviewed-by: Stefan Roese Reviewed-by: Jagan Teki Signed-off-by: Weijie Gao --- v4 changes: none v3 changes: add detail comments for mt7620_wdt_expire_now() v2 changes: add expire_now --- drivers/watchdog/Kconfig | 7 ++

[PATCH v4 11/23] clk: add clock driver for MediaTek MT7620 SoC

2020-11-12 Thread Weijie Gao
This patch adds a clock driver for MediaTek MT7620 SoC. This driver provides clock gate control as well as getting clock frequency for CPU/SYS/XTAL and some peripherals. Reviewed-by: Stefan Roese Signed-off-by: Weijie Gao --- v4 changes: none v3 changes: none v2 changes: none ---

[PATCH v4 12/23] reset: mtmips: add reset controller support for MediaTek MT7620 SoC

2020-11-12 Thread Weijie Gao
This patch adds reset controller bits definition header file for MediaTek MT7620 SoC Reviewed-by: Stefan Roese Signed-off-by: Weijie Gao --- v4 changes: none v3 changes: none v2 changes: none --- include/dt-bindings/reset/mt7620-reset.h | 35 1 file changed, 35

[PATCH v4 10/23] serial: add uart driver for MediaTek MT7620 SoC

2020-11-12 Thread Weijie Gao
This patch adds uart support for MediaTek MT7620 and earlier SoCs. The UART used by MT7620 is incompatible with the ns16550a driver. All registers of this UART have different addresses. A special 16-bit register for Divisor Latch is used to set the baudrate instead of the original two 8-bit

[PATCH v4 09/23] configs: mtmips: refresh for mt7628 based boards

2020-11-12 Thread Weijie Gao
Since mt7620 is added into Kconfig, the CONFIG_SOC_MT7628=y which is omitted by default must be added back, otherwise make xxx_defconfig for these boards will be configured for mt7620 platform. Reviewed-by: Stefan Roese Signed-off-by: Weijie Gao --- v4 changes: none v3 changes: none v2 changes:

  1   2   >