Re: [PATCH 1/1] ubifs: do not decide upon uninitialized variable

2020-12-25 Thread Heinrich Schuchardt
Am 26. Dezember 2020 08:08:52 MEZ schrieb Chris Packham : >(note replying on mobile device only code access is via git.denx.de) > >On Sat, 26 Dec 2020, 3:19 AM Heinrich Schuchardt, >wrote: > >> Before 'if (err)' we have to initialize the variable otherwise we use >a >> random value from the

Re: [PATCH 1/1] ubifs: do not decide upon uninitialized variable

2020-12-25 Thread Chris Packham
(note replying on mobile device only code access is via git.denx.de) On Sat, 26 Dec 2020, 3:19 AM Heinrich Schuchardt, wrote: > Before 'if (err)' we have to initialize the variable otherwise we use a > random value from the stack. > > Signed-off-by: Heinrich Schuchardt > --- > In all the

Re: [PATCH 2/2] arm: dart6ul: read and print SoM info from eeprom on startup

2020-12-25 Thread Fabio Estevam
On Tue, Dec 22, 2020 at 4:58 PM wrote: > > From: Marc Ferland > > The dart6ul has an i2c eeprom at 0x50 which contains, among other > things, the manufacturing/revision/options info of the SoM. This patch > replaces the current checkboard() implementation with a more > exhaustive one based on

Re: [PATCH 1/2] arm: dart6ul: change compatible string for eeprom

2020-12-25 Thread Fabio Estevam
On Tue, Dec 22, 2020 at 4:58 PM wrote: > > From: Marc Ferland > > The eeprom at address 0x50 is a BR24G04NUX-3TTR. It has a > 4Kbit (512x8) capacity, change the compatible string to reflect this > fact. > > Also, add an alias to easily refer to this eeprom with > fdt_path_offset() which will be

RE: [PATCH 1/1] imx: mx7: clock: use correct format strings

2020-12-25 Thread Peng Fan
> Subject: [PATCH 1/1] imx: mx7: clock: use correct format strings > > Use %u and not %d for unsigned values. > Print kHz and not khz. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Peng Fan > --- > arch/arm/mach-imx/mx7/clock.c | 22 +++--- > 1 file changed, 11

[PATCH v1 3/3] xea: config: Disable CONFIG_SPL_OF_PLATDATA_PARENT on XEA (imx28)

2020-12-25 Thread Lukasz Majewski
On the XEA board (imx28) one needs in the SPL support for GPIO, MMC and SPI. Two last ones are necessary for booting the device. The GPIO support allows deciding which medium will be used. For example the GPIO DTS node (gpio@0 at imx28.dtsi) has pinctrl parent (pinctrl@80018000) for which we don't

[PATCH v1 2/3] xea: config: Use CONFIG_PREBOOT from Kconfig

2020-12-25 Thread Lukasz Majewski
The usage of the preboot feature is now controlled via a separate Kconfig option - namely CONFIG_USE_PREBOOT. It must be enabled for preboot code executing commands now defined in CONFIG_PREBOOT (also moved to the Kconfig). After defining both CONFIG_USE_PREBOOT and CONFIG_PREBOOT in

[PATCH v1 1/3] xea: spl: Disable pull UP for GPIO0_2{35}

2020-12-25 Thread Lukasz Majewski
On the imx287 pin GPMI_WRN (GPIO0_25) no PullUP is available that can be enabled. To get the same behavior for both boot select pins (i.e. GPIO0_2{35}) disable pull UPs on both. Signed-off-by: Lukasz Majewski --- board/liebherr/xea/spl_xea.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v1 0/3] arm: xea: Regression fixes for i.MX28 based XEA board

2020-12-25 Thread Lukasz Majewski
This patch set provides boot regression fix and some enhancements for i.MX28 based XEA board. The most notably one is the disablement of CONFIG_SPL_OF_PLATDATA_PARENT which prevents from having the board bricked. Lukasz Majewski (3): xea: spl: Disable pull UP for GPIO0_2{35} xea: config:

[PATCH v2] sysboot: add zboot support to boot x86 Linux kernel image

2020-12-25 Thread Kory Maincent
Add "zboot" command to the list of supported boot in the label_boot function. Signed-off-by: Kory Maincent --- Change since v1: - Modify comment cmd/pxe_utils.c | 4 include/command.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/cmd/pxe_utils.c b/cmd/pxe_utils.c index

[PATCH 1/1] imx: mx7: clock: use correct format strings

2020-12-25 Thread Heinrich Schuchardt
Use %u and not %d for unsigned values. Print kHz and not khz. Signed-off-by: Heinrich Schuchardt --- arch/arm/mach-imx/mx7/clock.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-imx/mx7/clock.c b/arch/arm/mach-imx/mx7/clock.c index

[PATCH 1/1] sandbox: fix sandbox_cmdline_cb_test_fdt()

2020-12-25 Thread Heinrich Schuchardt
fmt does not foresee any parameter. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/start.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c index f6c98545e0..6d27f13875 100644 --- a/arch/sandbox/cpu/start.c +++

[PATCH 1/1] ubifs: do not decide upon uninitialized variable

2020-12-25 Thread Heinrich Schuchardt
Before 'if (err)' we have to initialize the variable otherwise we use a random value from the stack. Signed-off-by: Heinrich Schuchardt --- fs/ubifs/io.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/ubifs/io.c b/fs/ubifs/io.c index eb14b89544..9962cbe7eb 100644

[PATCH] fs: fat: eliminate DIRENTSPERBLOCK() macro

2020-12-25 Thread Heinrich Schuchardt
The FAT filesystem implementation uses several marcros referring to a magic variable name mydata which renders the code less readable. Eliminate one of them which is only used for a debug() statement. Use log_debug() instead of debug(). Signed-off-by: Heinrich Schuchardt --- Applicable to

Re: [PATCH 1/1] fs: btrfs: simplify close_ctree_fs_info()

2020-12-25 Thread Qu Wenruo
On 2020/12/25 下午8:45, Heinrich Schuchardt wrote: At the beginning of close_ctree_fs_info() the value 0 is assigned to err and never changed before testing it. Let's get rid of the superfluous variable. Fixes: f06bfcf54d0e ("fs: btrfs: Crossport open_ctree_fs_info() from btrfs-progs")

[PATCH 1/1] fs: btrfs: simplify close_ctree_fs_info()

2020-12-25 Thread Heinrich Schuchardt
At the beginning of close_ctree_fs_info() the value 0 is assigned to err and never changed before testing it. Let's get rid of the superfluous variable. Fixes: f06bfcf54d0e ("fs: btrfs: Crossport open_ctree_fs_info() from btrfs-progs") Signed-off-by: Heinrich Schuchardt --- fs/btrfs/disk-io.c