Re: [PATCH v7 23/28] video: omap: add panel driver

2020-12-28 Thread Lokesh Vutla
On 24/12/20 1:04 pm, Dario Binacchi wrote: > The previous version of am335x-fb.c contained the functionalities of two > drivers that this patch has split. It was a video type driver that used > the same registration compatible string that now registers a panel type > driver. The proof of this

Re: [PATCH v3 00/14] qemu: arm64: Add support for uefi capsule update on qemu arm platform

2020-12-28 Thread Sughosh Ganu
hello Heinrich, On Mon, 28 Dec 2020 at 20:09, Heinrich Schuchardt wrote: > On 12/23/20 8:03 AM, Sughosh Ganu wrote: > > The capsule update feature is supported on a platform configuration > > booting in a non-secure mode, i.e with -machine virt,secure=off option > > set. This results in the

[PATCH 48/49] dtoc: Generate uclass devices

2020-12-28 Thread Simon Glass
Add support for generating a file containing uclass instances. This avoids the need to create these at run time. Update a test uclass to include a 'priv_auto' member, to increase test coverage. Signed-off-by: Simon Glass --- drivers/misc/test_drv.c| 1 + include/dm/test.h | 5

[PATCH 49/49] dtoc: Generate device instances

2020-12-28 Thread Simon Glass
Add support for generating a file containing udevice instances. This avoids the need to create these at run time. Update a test uclass to include a 'per_device_plat_auto' member, to increase test coverage. Signed-off-by: Simon Glass --- drivers/misc/test_drv.c| 4 +

[PATCH 47/49] dtoc: Don't generate platform data with instantiation

2020-12-28 Thread Simon Glass
This file is not used when instantiating devices. Update dtoc to skip generating its contents and just add a comment instead. Also it is useful to see the driver name and parent for each device. Update the file to show that information, to avoid updating the same tests twice. Signed-off-by:

[PATCH 46/49] dtoc: Add support for decl file

2020-12-28 Thread Simon Glass
Add an option to generate the declaration file, which declares all drivers and uclasses, so references can be used in the code. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 36 +++ tools/dtoc/test_dtoc.py| 91 +++--- 2 files

[PATCH 45/49] dm: of-platadata: Add option for device instantiation

2020-12-28 Thread Simon Glass
Add Kconfig options to support build-time device instantiation. When fully implemented, this will allow dtoc to create U-Boot devices (i.e. struct udevice records) at build time, thus reducing code space in SPL. For now this defaults to off, but will be enabled when the rest of the implementation

[PATCH 43/49] dtoc: Support processing the root node

2020-12-28 Thread Simon Glass
The device for the root node is normally bound by driver model on init. With devices being instantiated at build time, we must handle the root device also. Add support for processing the root node, which may not have a compatible string. Signed-off-by: Simon Glass ---

[PATCH 42/49] dtoc: Set up the uclasses that are used

2020-12-28 Thread Simon Glass
We only care about uclasses that are actually used. This is determined by the drivers that use them. Check all the used drivers and build a list of 'valid' uclasses. Also add references to the uclasses so we can generate C code that uses them. Attach a uclass to each valid driver. For the tests,

[PATCH 44/49] dtoc: Add an option for device instantiation

2020-12-28 Thread Simon Glass
Add an option to instantiate devices at build time. For now this just parses the option and sets up a few parameters. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 17 +++-- tools/dtoc/main.py | 4 +++- tools/dtoc/test_dtoc.py| 37

[PATCH 39/49] dtoc: Warn of duplicate drivers

2020-12-28 Thread Simon Glass
If drivers have the same name then we cannot distinguish them. This only matters if the driver is actually used by dtoc, but in that case, issue a warning. Signed-off-by: Simon Glass --- tools/dtoc/src_scan.py | 28 ++- tools/dtoc/test_src_scan.py | 95

[PATCH 41/49] dtoc: Assign a sequence number to each node

2020-12-28 Thread Simon Glass
Now that we have the alias information we can assign a sequence number to each device in the uclass. Store this in the node associated with each device. This requires renaming the sandbox test drivers to have the right name. Note that test coverage is broken with this patch, but fixed in the next

[PATCH 40/49] dtoc: Read aliases for uclasses

2020-12-28 Thread Simon Glass
Scan the aliases in the device tree to establish the number of devices within each uclass, and the sequence number of each. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 28 ++ tools/dtoc/src_scan.py | 32 ++-

[PATCH 38/49] dtoc: Process driver aliases along with drivers

2020-12-28 Thread Simon Glass
Instead of using a separate step for this processing, handle it while scanning its associated driver. This allows us to drop the code coverage exception in this case. Note that only files containing drivers are scanned by dtoc, so aliases declared in a file that doesn't hold a driver will not be

[PATCH 37/49] dtoc: Support headers needed for drivers

2020-12-28 Thread Simon Glass
Typically dtoc can detect the header file needed for a driver by looking for the structs that it uses. For example, if a driver as a .priv_auto that uses 'struct serial_priv', then dtoc can search header files for the definition of that struct and use the file. In some cases, enums are used in

[PATCH 33/49] dtoc: Process nodes to set up required properties

2020-12-28 Thread Simon Glass
Add logic to assign property values to nodes as required by dtoc. The references allow nodes to refer to each other in C code. The macros used by dtoc are not yet defined in driver model. They will be added along with the actual driver model implementation. Signed-off-by: Simon Glass ---

[PATCH 34/49] dtoc: Track nodes which are actually used

2020-12-28 Thread Simon Glass
Mark all nodes that are actually used, so we can perform extra checks on them. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 3 +++ tools/dtoc/src_scan.py | 25 ++--- tools/dtoc/test_dtoc.py | 11 +++ tools/dtoc/test_src_scan.py | 2 +- 4

[PATCH 35/49] dtoc: Support tracking the phase of U-Boot

2020-12-28 Thread Simon Glass
U-Boot operates in several phases, typically TPL, SPL and U-Boot proper. The latter does not use dtoc. In some rare cases different drivers are used for two phases. For example, in TPL it may not be necessary to use the full PCI subsystem, so a simple driver can be used instead. This works in

[PATCH 27/49] dtoc: Support scanning of uclasses

2020-12-28 Thread Simon Glass
Uclasses can have per-device private / platform data so dtoc needs to scan these drivers. This allows it to find out the size of this data so it can be allocated a build time. Add a parser for uclass information, similar to drivers. Keep a dict of the uclasses that were found. Signed-off-by:

[PATCH 28/49] dtoc: Support scanning of structs in header files

2020-12-28 Thread Simon Glass
Drivers can have private / platform data contained in structs and these struct definitions are generally kept in header files. In order to generate build-time devices, dtoc needs to generate code that declares the data contained in those structs. This generated code must include the relevant

[PATCH 20/49] dtoc: Split source-code scanning to a separate file

2020-12-28 Thread Simon Glass
Before expanding the scanning features any more, move this into a separate file. This will make it easier to maintain in the future. In particular, it reduces the size of dtb_platdata.py and allows us to add tests specifically for scanning, without going through that file. The pieces moved are

[PATCH 24/49] dtoc: Save scan information across test runs

2020-12-28 Thread Simon Glass
At present most of the tests scan the U-Boot source tree as part of their run. This information does not change across tests, so we can save time by remembering it. Add a way to set up this information and use it for each test, taking a copy first, so as not to mess up the original. This reduces

[PATCH 22/49] dtoc: Tidy up src_scan tests

2020-12-28 Thread Simon Glass
Some of these tests don't actually check anything. Add a few more checks to complete the tests. Also add a simple scan test that does the basics. Signed-off-by: Simon Glass --- tools/dtoc/test_src_scan.py | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-)

[PATCH 21/49] dtoc: Move src_scan tests to a separate file

2020-12-28 Thread Simon Glass
Move the tests related to scanning into their own class, updating them to avoid using dtb_platdata as a pass-through. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 2 +- tools/dtoc/main.py | 5 +- tools/dtoc/src_scan.py | 4 +- tools/dtoc/test_dtoc.py | 73

[PATCH 19/49] dtoc: Drop dm_populate_phandle_data()

2020-12-28 Thread Simon Glass
This has not been needed since parent information was added and we started using indicies for references to other drivers instead of pointers. It was kept around in the expectation that it might be needed later. However with the latest updates, it doesn't seem likely that we'll need this in the

[PATCH 18/49] dtoc: Output nodes in order

2020-12-28 Thread Simon Glass
Previously we had to worry about nodes being output before those that they depended on, thus causing build errors. So the current algorithm is careful to output nodes in the right order. We now use a different method for outputting phandles that does not involve pointers. Also we plan to add a

[PATCH 08/49] dm: Rename U_BOOT_DEVICE() to U_BOOT_DRVINFO()

2020-12-28 Thread Simon Glass
The current macro is a misnomer since it does not declare a device directly. Instead, it declares driver_info record which U-Boot uses at runtime to create a device. The distinction seems somewhat minor most of the time, but is becomes quite confusing when we actually want to declare a device,

[PATCH 36/49] Makefile: Pass the U-Boot phase to dtoc

2020-12-28 Thread Simon Glass
Pass the U-Boot phase as a parameter so dtoc can use it. At present it is ether "spl" or "tpl". Signed-off-by: Simon Glass --- scripts/Makefile.spl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 87021e22e55..72c0ad82793

[PATCH 32/49] dtoc: Make use of node properties

2020-12-28 Thread Simon Glass
Now that we have these available, use them instead of recalculating things each time. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 45 -- 1 file changed, 19 insertions(+), 26 deletions(-) diff --git a/tools/dtoc/dtb_platdata.py

[PATCH 30/49] dtoc: Rename sandbox_i2c_test and sandbox_pmic_test

2020-12-28 Thread Simon Glass
These have '_test' suffixes which are not present on the drivers in the source code. Drop the suffixes to avoid a mismatch when scanning. Signed-off-by: Simon Glass --- tools/dtoc/test/dtoc_test_simple.dts | 4 ++-- tools/dtoc/test_dtoc.py | 12 ++-- 2 files changed, 8

[PATCH 31/49] dtoc: Add some extra properties to nodes

2020-12-28 Thread Simon Glass
It is convenient to attach drivers, etc. to nodes so that we can use the Node object as the main data structure in this module. Add a function which adds the new properties, along with documentation. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 37

[PATCH 29/49] dtoc: Move test files into a test/ directory

2020-12-28 Thread Simon Glass
It is confusing to have the test files in the same places as the implementation. Move them into a separate directory. Add a helper function for test_dtoc, to avoid repeating the same path. Signed-off-by: Simon Glass --- tools/dtoc/{ => test}/dtoc_test.dts | 0 tools/dtoc/{ =>

[PATCH 26/49] dtoc: Collect priv/plat struct info from drivers

2020-12-28 Thread Simon Glass
In order to output variables to hold the priv/plat information used by each device, dtoc needs to know the struct for each. With this, it can declare this at build time: u8 xxx_priv [sizeof(struct )]; Collect the various struct names from the drivers. Signed-off-by: Simon Glass ---

[PATCH 25/49] dtoc: Ignore unwanted files when scanning for drivers

2020-12-28 Thread Simon Glass
We should ignore anything in the .git directory or any of the build-sandbox, etc. directories created by 'make check'. These can confuse dtoc. Update the code to ignore these. Signed-off-by: Simon Glass --- tools/dtoc/src_scan.py | 5 + tools/dtoc/test_src_scan.py | 5 - 2 files

[PATCH 23/49] dtoc: Scan drivers for available information

2020-12-28 Thread Simon Glass
At present we simply record the name of a driver parsed from its implementation file. We also need to get the uclass and a few other things so we can instantiate devices at build time. Add support for collecting this information. This requires parsing each driver file. Signed-off-by: Simon Glass

[PATCH 17/49] dtoc: Allow specifying the base directory for tests

2020-12-28 Thread Simon Glass
The base directory of U-Boot, where the source is, it currently calculated from the directory of the dtb_platdata.py script. If this is installed elsewhere that will not work. Also it is inconvenient for tests. Add a parameter to allow specifying this base directory. To test this, pass a

[PATCH 16/49] dtoc: Add the method for each command to OutputFile

2020-12-28 Thread Simon Glass
Rather than the if/else construct, update OutputFile with the method to call to process each command. This is easier to maintain as the number of commands increases. Rename generate_tables to generate_plat since it better describes what is being generated ('plat' is the U-Boot name for platform

[PATCH 10/49] dm: Rename DM_GET_DRIVER() to DM_DRIVER_GET()

2020-12-28 Thread Simon Glass
In the spirit of using the same base name for all of these related macros, rename this to have the operation at the end. This is not widely used so the impact is fairly small. Signed-off-by: Simon Glass --- arch/arm/lib/gic-v3-its.c | 10 +-

[PATCH 15/49] dtoc: Rename dt-platdata.c to dt-plat.c

2020-12-28 Thread Simon Glass
Use this new name to be consistent with the rest of U-Boot, which talks about 'plat' for the platform data, which is what this file holds. Signed-off-by: Simon Glass --- include/dm/platdata.h | 2 +- include/linux/mtd/spi-nor.h | 2 +- scripts/Makefile.spl| 2 +-

[PATCH 14/49] dtoc: Add a header comment to each generated file

2020-12-28 Thread Simon Glass
It is currently fairly obvious what the two generated files are for, but this will change as more are added. It is helpful for readers to describe the purpose of each file. Add a header commment field to OutputFile and use it to generate a comment at the top of each file. Signed-off-by: Simon

[PATCH 11/49] dm: Rename U_BOOT_DRIVER_ALIAS to DM_DRIVER_ALIAS

2020-12-28 Thread Simon Glass
We use the U_BOOT_ prefix (i.e. U_BOOT_DRIVER) to declare a driver but in every other case we just use DM_. Update the alias macros to use the DM_ prefix. We could perhaps rename U_BOOT_DRIVER() to DM_DRIVER(), but this macro is widely used and there is at least some benefit to indicating it us a

[PATCH 12/49] concurrencytest: Fix Python3 warning

2020-12-28 Thread Simon Glass
This gives a warning in some situations: File "tools/dtoc/../concurrencytest/concurrencytest.py", line 95, in do_fork stream = os.fdopen(c2pread, 'rb', 1) File "/usr/lib/python3.8/os.py", line 1023, in fdopen return io.open(fd, *args, **kwargs) RuntimeWarning: line buffering

[PATCH 13/49] dtoc: Run tests using test_util

2020-12-28 Thread Simon Glass
Use the standard function for running tests and reported results. This allows the tests to run in parallel, which is a significant speed-up on most machines (e.g. 4.5 seconds -> 1.5s on mine). Signed-off-by: Simon Glass --- tools/dtoc/main.py | 31 ++- 1 file

[PATCH 09/49] dm: Rename DM_GET_DEVICE() to DM_DRVINFO_GET()

2020-12-28 Thread Simon Glass
This does not get a device (struct udevice *) but a struct driver_info * so the name is confusing. Rename it accordingly. Since we plan to have several various of these macros, put GET at the end instead of the middle, so it is easier to spot the related macros. Signed-off-by: Simon Glass ---

[PATCH 06/49] dtoc: Add an 'all' command

2020-12-28 Thread Simon Glass
With upcoming changes, dtoc will output several files for different of-platdata components. Add a way to output all ava!ilable files at once ('all'), to the appropriate directories, without needing to specify each one invidually. This puts the commands in alphabetical order, so update the tests

[PATCH 07/49] Makefile: Invoke dtoc only once

2020-12-28 Thread Simon Glass
Update the Makefile to run dtoc only once, generating all required files. This saves time since there is a lot of processing in each invocation of dtoc. We already have a variable for the object files to build, so use that instead of repeating the same filenames. Add a C version of this also, for

[PATCH 05/49] dtoc: Allow outputing to multiple files

2020-12-28 Thread Simon Glass
Implement the 'output directory' feature, allowing dtoc to write the output files separately to the supplied directories. This allows us to handle the struct and platdata output in one run of dtoc. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 96

[PATCH 03/49] dtoc: Test the stdout output

2020-12-28 Thread Simon Glass
Normally dtoc outputs to a file but it also offers a way to write output to stdout. At present the test for that does not actually check that the output is correct. Add this to the test. This uses a member variable to hold the expected text, so it can be used in muitiple places. Signed-off-by:

[PATCH 04/49] dtoc: Allow providing a directory to write files to

2020-12-28 Thread Simon Glass
At present dtoc writes only a single file on each invocation. U-Boot writes the two files it needs by separate invocations of dtoc. Since dtoc now scans all U-Boot driver source, this is fairly slow (about 1 second per file). It would be better if dtoc could write all the files at once. In

[PATCH 02/49] dtoc: Use None to mean stdout

2020-12-28 Thread Simon Glass
At present dtoc uses '-' internally to mean that output should go to stdout. This is not necessary and None is more convenient. Update it. Signed-off-by: Simon Glass --- tools/dtoc/dtb_platdata.py | 10 +- tools/dtoc/main.py | 2 +- tools/dtoc/test_dtoc.py| 2 +- 3 files

[PATCH 00/49] dm: Add dtoc implementation of device instantiation (part D)

2020-12-28 Thread Simon Glass
By way of background, in May[1] and July[2] two 'tiny-dm' series were sent out, showing a possible way to reduce the overhead of driver model in SPL. The potential impact of that work was described in the cover letter[3]. While this was a successful demonstration, all but eliminating the overhead

[PATCH 01/49] dtoc: Tidy up pylint warnings in test

2020-12-28 Thread Simon Glass
Tidy up this file to reduce the number of pylint warnings. Signed-off-by: Simon Glass --- tools/dtoc/test_dtoc.py | 156 ++-- 1 file changed, 85 insertions(+), 71 deletions(-) diff --git a/tools/dtoc/test_dtoc.py b/tools/dtoc/test_dtoc.py index

Re: About t1042 fsl sata driver

2020-12-28 Thread Simon Glass
Hi, On Thu, 24 Dec 2020 at 03:47, Yusuf Kaya wrote: > > Hi, > > I'm confused about usage of DCC(Data DWord Count) Field of PRD Entries in > fsl_sata.c > > In T1042 Reference manual, DCC field is explained as the following way; > > Data DWord count. A 0-based value that Indicates the length, in

Re: [PATCH v1 3/3] xea: config: Disable CONFIG_SPL_OF_PLATDATA_PARENT on XEA (imx28)

2020-12-28 Thread Simon Glass
Hi Lukasz, On Fri, 25 Dec 2020 at 17:09, Lukasz Majewski wrote: > > On the XEA board (imx28) one needs in the SPL support for GPIO, MMC and > SPI. Two last ones are necessary for booting the device. The GPIO support > allows deciding which medium will be used. For example the GPIO DTS node >

Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-28 Thread Simon Glass
Hi Alex, On Mon, 21 Dec 2020 at 15:24, Alex G. wrote: > > > > On 12/21/20 2:23 PM, Simon Glass wrote: > > Hi Alex, > > > > On Mon, 21 Dec 2020 at 12:28, Alex G. wrote: > >> > >> On 12/18/20 8:28 PM, Simon Glass wrote: > >>> Hi Alexandru, > >>> > >>> On Tue, 15 Dec 2020 at 17:09, Alexandru

Re: [PATCHv2] drivers: tee: i2c trampoline driver

2020-12-28 Thread Simon Glass
hI Jorge, On Mon, 28 Dec 2020 at 05:17, Jorge Ramirez-Ortiz wrote: > > This commit gives the secure world access to the I2C bus so it can > communicate with I2C slaves (tipically those would be secure elements > like the NXP SE050). > > Signed-off-by: Jorge Ramirez-Ortiz > --- >

Re: [PATCH 1/1] lib: aes: build failure with DEBUG=1

2020-12-28 Thread Simon Glass
On Mon, 28 Dec 2020 at 09:56, Heinrich Schuchardt wrote: > > Building fails with DEBUG=1: > > lib/aes.c: In function ‘debug_print_vector’: > lib/aes.c:622:45: error: > cast from pointer to integer of different size > [-Werror=pointer-to-int-cast] > 622 | printf("%s [%d] @0x%08x", name,

Re: [PATCH 2/3] cmd: Makefile: build nvedit.c when needed

2020-12-28 Thread Simon Glass
On Mon, 28 Dec 2020 at 04:44, Peng Fan (OSS) wrote: > > From: Peng Fan > > No need to build nvedit.c when CONFIG_$(SPL_)ENV_SUPPORT is n > > Signed-off-by: Peng Fan > --- > cmd/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass

Re: [PATCH 1/3] common: Makefile: drop duplicated line

2020-12-28 Thread Simon Glass
On Mon, 28 Dec 2020 at 04:44, Peng Fan (OSS) wrote: > > From: Peng Fan > > obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o is there, > no need obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o > > Signed-off-by: Peng Fan > --- > common/Makefile | 1 - > 1 file changed, 1 deletion(-)

Re: [PATCH v2] bootmenu: Allow to quit it via ESC/CTRL+C

2020-12-28 Thread Simon Glass
On Sat, 26 Dec 2020 at 17:05, Pali Rohár wrote: > > When ESC/CTRL+C is pressed interrupt bootmenu and jump into U-Boot console. > As the last entry in bootmenu is always U-Boot console just choose the last > entry when ESC or CTRL+C is pressed. > > ESC key is detected when either no other

Re: [PATCH] bootmenu: Select CFB_CONSOLE_ANSI if CFB_CONSOLE

2020-12-28 Thread Simon Glass
Hi Paul, On Sat, 26 Dec 2020 at 14:04, Pali Rohár wrote: > > CMD_BOOTMENU uses ANSI terminal. Therefore if U-Boot has enabled > CFB_CONSOLE then bootmenu needs also CFB_CONSOLE_ANSI to work. > > Define this dependency in Kconfig and remove information about this > requirement from documentation

Re: [PATCH] drivers: tee: i2c trampoline driver

2020-12-28 Thread Simon Glass
Hi Jorge, On Mon, 21 Dec 2020 at 11:15, Jorge Ramirez-Ortiz wrote: > > This commit gives the secure world access to the I2C bus so it can > communicate with I2C slaves (tipically those would be secure elements typically > like the NXP SE050). > > Tested on imx8mmevk. We don't seem to have any

Re: [PATCH 1/1] sandbox: fix sandbox_cmdline_cb_test_fdt()

2020-12-28 Thread Simon Glass
On Fri, 25 Dec 2020 at 08:04, Heinrich Schuchardt wrote: > > fmt does not foresee any parameter. > > Signed-off-by: Heinrich Schuchardt > --- > arch/sandbox/cpu/start.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH] fs: fat: eliminate DIRENTSPERBLOCK() macro

2020-12-28 Thread Simon Glass
On Fri, 25 Dec 2020 at 07:11, Heinrich Schuchardt wrote: > > The FAT filesystem implementation uses several marcros referring to a magic > variable name mydata which renders the code less readable. Eliminate one of > them which is only used for a debug() statement. > > Use log_debug() instead of

Re: [PATCH] cmd: mmc: add mmcboot command

2020-12-28 Thread Simon Glass
On Wed, 23 Dec 2020 at 12:57, Ravik Hasija wrote: > > Similar to usbboot, add command line to boot from raw mmc partition > using common_diskboot(), which supports legacy or FIT images. > > Usage: > mmcboot loadAaddr dev:part > > Where defaults to CONFIG_SYS_LOAD_ADDR, and > defaults to

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-28 Thread Simon Glass
Hi guys, On Wed, 23 Dec 2020 at 03:24, Torsten Duwe wrote: > > On Sun, 20 Dec 2020 11:17:50 -0700 > Simon Glass wrote: > > > Hi Torsten, > > > > On Sun, 20 Dec 2020 at 10:00, Torsten Duwe wrote: > > > > > > On Fri, 18 Dec 2020 19:29:12 -0700 > > > Simon Glass wrote: > > > > > > > > -

Re: [PATCH v2 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-28 Thread Simon Glass
On Tue, 22 Dec 2020 at 16:54, Alexandru Gagniuc wrote: > > The logical steps in spl_load_simple_fit() are difficult to follow. > I think the long comments, ifdefs, and ungodly number of variables > seriously affect the readability. In particular, it violates section 6 > of the coding style,

Re: [PATCH v4 2/3] button: add a simple Analog to Digital Converter device based button driver

2020-12-28 Thread Simon Glass
Hi, On Tue, 22 Dec 2020 at 02:46, Heinrich Schuchardt wrote: > > On 12/22/20 9:56 AM, Marek Szyprowski wrote: > > Add a simple Analog to Digital Converter device based button driver. This > > driver binds to the 'adc-keys' device tree node. > > > > Signed-off-by: Marek Szyprowski > > --- > >

Re: [PATCH v2 6/6] cmd: Add MBR partition layout control utility

2020-12-28 Thread Simon Glass
Hi Marek, On Tue, 22 Dec 2020 at 07:09, Marek Szyprowski wrote: > > Add a 'mbr' command to let user create or verify MBR partition layout > based on the provided text description. The partition layout is > altearnatively read from 'mbr_parts' environment variable. This can be > used in scripts

Re: test_efi_selftest occasionally fails on qemu-x86?

2020-12-28 Thread Simon Glass
Hi Heinrich, On Tue, 22 Dec 2020 at 01:40, Heinrich Schuchardt wrote: > > On 12/22/20 9:14 AM, Heinrich Schuchardt wrote: > > On 12/22/20 6:00 AM, Bin Meng wrote: > >> Hi, > >> > >> Please check the log: > >>

Re: [v5 17/18] arm: socfpga: soc64: Enable FIT image generation using binman

2020-12-28 Thread Simon Glass
On Mon, 21 Dec 2020 at 09:50, Siew Chin Lim wrote: > > Enable BINMAN when using Arm-Trusted-Firmware (ATF) to > generate FIT images. > > Signed-off-by: Siew Chin Lim > > --- > v4 > --- > Adjust BINMAN sequence in code, sorted by alphabetical order. > > v5 > --- > Revert all changes in Makefile

Re: [PATCH v2 1/2] trace: select TIMER_EARLY to avoid infinite recursion

2020-12-28 Thread Simon Glass
On Mon, 21 Dec 2020 at 23:23, Pragnesh Patel wrote: > > When tracing functions is enabled this adds calls to > __cyg_profile_func_enter() and __cyg_profile_func_exit() to the traced > functions. > > __cyg_profile_func_enter() and __cyg_profile_func_exit() invoke > timer_get_us() to record the

Re: [v5 16/18] arm: socfpga: dts: soc64: Add binman node of FIT image with ATF support

2020-12-28 Thread Simon Glass
On Mon, 21 Dec 2020 at 09:50, Siew Chin Lim wrote: > > Add binman node to device tree to generate the FIT image for u-boot > (u-boot.itb) and OS kernel (kernel.itb). > > u-boot.itb contains arm trusted firmware (ATF), u-boot proper and > u-boot device tree for ATF u-boot flow. > > kernel.itb

RE: [PATCH 07/13] imx: imx8mn: add i.MX8MN LPDDR4 EVK support

2020-12-28 Thread Peng Fan
> Subject: RE: [PATCH 07/13] imx: imx8mn: add i.MX8MN LPDDR4 EVK support > > Hello Peng, > > > -Original Message- > > From: U-Boot On Behalf Of Peng Fan (OSS) > > Sent: Monday, December 28, 2020 1:17 PM > > To: sba...@denx.de; feste...@gmail.com > > Cc: uboot-...@nxp.com;

RE: [PATCH 05/13] imx: imx8mn_evk: correct stack/malloc adress

2020-12-28 Thread Peng Fan
> Subject: RE: [PATCH 05/13] imx: imx8mn_evk: correct stack/malloc adress > > Hello Peng, > > > -Original Message- > > From: U-Boot On Behalf Of Peng Fan > > (OSS) > > Sent: Monday, December 28, 2020 1:17 PM > > To: sba...@denx.de; feste...@gmail.com > > Cc: uboot-...@nxp.com;

RE: [PATCH 01/13] imx: imx8mp_evk: enable eth support

2020-12-28 Thread Peng Fan
> Subject: Re: [PATCH 01/13] imx: imx8mp_evk: enable eth support > > Hi Peng, > > On Mon, Dec 28, 2020 at 8:48 AM Peng Fan (OSS) > wrote: > > > +static void setup_iomux_fec(void) > > +{ > > + imx_iomux_v3_setup_multiple_pads(fec1_rst_pads, > > + > ARRAY_SIZE(fec1_rst_pads)); > > + > > +

[PATCH 1/1] efi_loader: use after free in efi_exit()

2020-12-28 Thread Heinrich Schuchardt
Do not use data from the loaded image object after deleting it. Fixes: 126a43f15b36 ("efi_loader: unload applications upon Exit()") Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 4 ++-- lib/efi_loader/efi_boottime.c | 17 - 2 files changed, 14

Re: [PATCH 2/6] efi_loader: Introduce helper functions for EFI

2020-12-28 Thread Ilias Apalodimas
Hi Heinrich, > > + > > + /* make sure we have enough space for replacements */ > > + if (u16_strsize(name) < sizeof(*name) * start + u16_strsize(L"")) { > > + ret = EFI_INVALID_PARAMETER; > > + goto out; > > + } > > + boot_order_size = sizeof(boot_order); > > +

Re: [PATCH v5 10/13] xhci: translate virtual addresses into the bus's address space

2020-12-28 Thread Peter Robinson
On Thu, Dec 24, 2020 at 12:23 PM Nicolas Saenz Julienne wrote: > > On Wed, 2020-12-23 at 19:55 +0100, Nicolas Saenz Julienne wrote: > > So far we've been content with passing physical addresses when > > configuring memory addresses into XHCI controllers, but not all > > platforms have buses with

Re: [PATCH 3/6] efi_loader: Replace config option with EFI variable for initrd loading

2020-12-28 Thread Ilias Apalodimas
Hi Heinrich, On Mon, Dec 28, 2020 at 03:55:49PM +0100, Heinrich Schuchardt wrote: [...] > > ret = try_load_entry(bootorder[i], handle, load_options); > > - if (ret == EFI_SUCCESS) > > + if (ret == EFI_SUCCESS) { > > + if

Re: [PATCH 01/13] imx: imx8mp_evk: enable eth support

2020-12-28 Thread Fabio Estevam
Hi Peng, On Mon, Dec 28, 2020 at 8:48 AM Peng Fan (OSS) wrote: > +static void setup_iomux_fec(void) > +{ > + imx_iomux_v3_setup_multiple_pads(fec1_rst_pads, > +ARRAY_SIZE(fec1_rst_pads)); > + > + gpio_request(FEC_RST_PAD, "fec1_rst"); > +

RE: [PATCH 07/13] imx: imx8mn: add i.MX8MN LPDDR4 EVK support

2020-12-28 Thread ZHIZHIKIN Andrey
Hello Peng, > -Original Message- > From: U-Boot On Behalf Of Peng Fan (OSS) > Sent: Monday, December 28, 2020 1:17 PM > To: sba...@denx.de; feste...@gmail.com > Cc: uboot-...@nxp.com; u-boot@lists.denx.de; Peng Fan > Subject: [PATCH 07/13] imx: imx8mn: add i.MX8MN LPDDR4 EVK support >

[PATCH 1/1] efi_loader: describe struct efi_loaded_image_obj

2020-12-28 Thread Heinrich Schuchardt
Add the missing description of some fields of struct efi_loaded_image_obj. Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/efi_loader.h b/include/efi_loader.h index 3c68b85b68..dc3c6ac304 100644 ---

RE: [PATCH 05/13] imx: imx8mn_evk: correct stack/malloc adress

2020-12-28 Thread ZHIZHIKIN Andrey
Hello Peng, > -Original Message- > From: U-Boot On Behalf Of Peng Fan (OSS) > Sent: Monday, December 28, 2020 1:17 PM > To: sba...@denx.de; feste...@gmail.com > Cc: uboot-...@nxp.com; u-boot@lists.denx.de; Peng Fan > Subject: [PATCH 05/13] imx: imx8mn_evk: correct stack/malloc adress >

RE: [PATCH 01/13] imx: imx8mp_evk: enable eth support

2020-12-28 Thread ZHIZHIKIN Andrey
Hello Peng, > -Original Message- > From: U-Boot On Behalf Of Peng Fan (OSS) > Sent: Monday, December 28, 2020 1:17 PM > To: sba...@denx.de; feste...@gmail.com > Cc: uboot-...@nxp.com; u-boot@lists.denx.de; Peng Fan > Subject: [PATCH 01/13] imx: imx8mp_evk: enable eth support > > >

Re: [PATCH] mx6ul(l)evk: Enable DM_ETH_PHY

2020-12-28 Thread Fabio Estevam
Hi Sean, On Mon, Dec 28, 2020 at 4:58 PM Sean Anderson wrote: > > This fixes eth0 not initializing properly. Both eth0 and eth1 use the > MDIO interface on eth1 to access their PHYs. However, without > DM_ETH_PHY, eth0 still tries to use its own MDIO interface to access its > phy. Before this

[PATCH] lib: zlib: our putc() takes only one argument

2020-12-28 Thread Heinrich Schuchardt
In contrast to the C99 standard [1] our putc() takes only one argument. [1] ISO/IEC 9899:1999 Signed-off-by: Heinrich Schuchardt --- lib/zlib/deflate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/zlib/deflate.c b/lib/zlib/deflate.c index 1fe58d5da6..63473359e4

[PATCH 1/1] lib: zlib: include ctype.h

2020-12-28 Thread Heinrich Schuchardt
Our ctype.h is in include/linux/ Signed-off-by: Heinrich Schuchardt --- lib/zlib/trees.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/zlib/trees.c b/lib/zlib/trees.c index 3e09517ed0..700c62f6d7 100644 --- a/lib/zlib/trees.c +++ b/lib/zlib/trees.c @@ -38,7 +38,7 @@

[PATCH] mx6ul(l)evk: Enable DM_ETH_PHY

2020-12-28 Thread Sean Anderson
This fixes eth0 not initializing properly. Both eth0 and eth1 use the MDIO interface on eth1 to access their PHYs. However, without DM_ETH_PHY, eth0 still tries to use its own MDIO interface to access its phy. Before this patch, a boot log might contain lines like Net: Warning: ethernet@20b4000

[PATCH RFC v1 4/4] doc: signature.txt: Document devicetree format for ECDSA keys

2020-12-28 Thread Alexandru Gagniuc
Signed-off-by: Alexandru Gagniuc --- doc/uImage.FIT/signature.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/uImage.FIT/signature.txt b/doc/uImage.FIT/signature.txt index a3455889ed..0139295d33 100644 --- a/doc/uImage.FIT/signature.txt +++

[PATCH RFC v1 3/4] lib: Add support for ECDSA image signing

2020-12-28 Thread Alexandru Gagniuc
mkimage supports rsa2048, and rsa4096 signatures. With newer silicon now supporting hardware-accelerated ECDSA, it makes sense to expand signing support to elliptic curves. Implement host-side ECDSA signing and verification with libcrypto. Device-side implementation of signature verification is

[PATCH RFC v1 2/4] lib/rsa: Make fdt_add_bignum() available outside of RSA code

2020-12-28 Thread Alexandru Gagniuc
fdt_add_bignum() is useful for algorithms other than just RSA. To allow its use for ECDSA, move it to a common file under lib/. The new file is suffixed with '-libcrypto' because it has a direct dependency on openssl. This is due to the use of the "BIGNUM *" type. Signed-off-by: Alexandru

[PATCH RFC v1 1/4] lib: Rename rsa-checksum.c to hash-checksum.c

2020-12-28 Thread Alexandru Gagniuc
rsa-checksum.c sontains the hash_calculate() implementations. Despite the "rsa-" file prefix, this function is useful for other algorithms. To prevent confusion, move this file to lib/crypto, and rename it to hash-checksum.c, to give it a more "generic" feel. Signed-off-by: Alexandru Gagniuc

[PATCH RFC v1 0/4] Add support for ECDSA image signing

2020-12-28 Thread Alexandru Gagniuc
# Introduction This series is part of a larger effort to implement verified boot on STM32MP1. The ROM code on this chip requires an ECDSA-signed SSBL. Maintaining verified boot through FIT images would require switching to an RSA key after SPL. This would be stupid, so this series is focused on

Re: [PATCH v1] doc: README.distro: Special case with Windows formatted disk

2020-12-28 Thread Andy Shevchenko
On Mon, Dec 28, 2020 at 06:50:39PM +0100, Pali Rohár wrote: > On Sunday 27 December 2020 11:08:05 Andy Shevchenko wrote: > > On Sunday, December 27, 2020, Pali Rohár wrote: > > > On Friday 17 January 2020 12:44:51 Andy Shevchenko wrote: ... > > > > +Using a eMMC partition that has been

Re: [PATCH v1] doc: README.distro: Special case with Windows formatted disk

2020-12-28 Thread Pali Rohár
On Sunday 27 December 2020 11:08:05 Andy Shevchenko wrote: > On Sunday, December 27, 2020, Pali Rohár wrote: > > > On Friday 17 January 2020 12:44:51 Andy Shevchenko wrote: > > > If someone wants to use shared (by installed OS) eMMC partition to > > > the Windows to boot from, it's not possible

[PATCH 1/1] lib: aes: build failure with DEBUG=1

2020-12-28 Thread Heinrich Schuchardt
Building fails with DEBUG=1: lib/aes.c: In function ‘debug_print_vector’: lib/aes.c:622:45: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] 622 | printf("%s [%d] @0x%08x", name, num_bytes, (u32)data); Pointers can only be cast to (uintptr_t). But anyway we

Re: [PATCH v5 02/13] rpi: Add identifier for the new CM4

2020-12-28 Thread Peter Robinson
On Wed, Dec 23, 2020 at 6:55 PM Nicolas Saenz Julienne wrote: > > The Raspberry Pi Foundation released the new Compute Module 4 which we > want to detect, so we can enable Ethernet on it and know the correct > device tree file name. > > Note that this sets the Ethernet option to true since the

Re: [PATCH 22/26] dm: core: Access device ofnode through functions

2020-12-28 Thread Simon Glass
At present ofnode is present in the device even if it is never used. With of-platdata this field is not used, so can be removed. In preparation for this, change the access to go through inline functions. Signed-off-by: Simon Glass --- arch/arm/mach-stm32mp/pwr_regulator.c | 2 +-

Re: [PATCH 05/26] x86: apl: Move priv/plat structs to headers

2020-12-28 Thread Simon Glass
With the new of-platdata, these need to be available to dt_platdata.c so must be in header files. Move them. Signed-off-by: Simon Glass --- arch/x86/cpu/apollolake/hostbridge.c | 20 + arch/x86/cpu/apollolake/pmc.c | 8 +-

  1   2   3   >