Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-13 Thread Heinrich Schuchardt
On 1/14/21 6:42 AM, Bin Meng wrote: Hi Simon, On Thu, Jan 14, 2021 at 5:57 AM Simon Glass wrote: Hi Bin, I added you, Heinrich, Tom and Andy. For others, as mentioned in the doc I can add you to the invitation. Just reply on this thread. I am not sure how Google meet works as I never use

[PATCH] mmc: sdhci: skip cache invalidation if DMA is not used

2021-01-13 Thread Yuezhang.Mo
If DMA(SDMA or ADMA) is not used, the cache invalidation after reading is no need, should be skipped. Otherwise U-Boot may hang at the cache invalidation. Found this issue and tested this fix on DragonBoard 410c. Fixes: commit 4155ad9aac94 ("mmc: sdhci: fix missing cache invalidation after readi

Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-13 Thread Bin Meng
Hi Simon, On Thu, Jan 14, 2021 at 5:57 AM Simon Glass wrote: > > Hi Bin, > > I added you, Heinrich, Tom and Andy. > > For others, as mentioned in the doc I can add you to the invitation. > Just reply on this thread. > I am not sure how Google meet works as I never used that. I guess Zoom is much

Re: [RFC PATCH 3/3] efidebug: add multiple device path instances on Boot####

2021-01-13 Thread AKASHI Takahiro
Ilias, On Wed, Jan 13, 2021 at 01:11:49PM +0200, Ilias Apalodimas wrote: > The UEFI spec allow a packed array of UEFI device paths in the > FilePathList[] of an EFI_LOAD_OPTION. The first file path must > describe the laoded image but the rest are OS specific. > Previous patches parse the device p

Re: [RFC PATCH 1/3] efi_loader: Introduce helper functions for EFI

2021-01-13 Thread Heinrich Schuchardt
Am 14. Januar 2021 05:48:28 MEZ schrieb AKASHI Takahiro : >On Wed, Jan 13, 2021 at 01:11:47PM +0200, Ilias Apalodimas wrote: >> A following patch introduces a different logic for loading initrd's >> based on the EFI_LOAD_FILE2_PROTOCOL. >> Since similar logic can be applied in the future for other

Re: [RFC PATCH 1/3] efi_loader: Introduce helper functions for EFI

2021-01-13 Thread AKASHI Takahiro
On Wed, Jan 13, 2021 at 01:11:47PM +0200, Ilias Apalodimas wrote: > A following patch introduces a different logic for loading initrd's > based on the EFI_LOAD_FILE2_PROTOCOL. > Since similar logic can be applied in the future for other system files > (i.e DTBs), In this respect, > let's add some

Re: [PATCH] Add fixdefconfig script to update lists of defconfig files from savedefconfig

2021-01-13 Thread Joel Peshkin
No worries. As long as there is a mechanism that will work OK. On Wed, Jan 13, 2021 at 12:16 PM Tom Rini wrote: > On Wed, Jan 13, 2021 at 09:10:41AM -0700, Simon Glass wrote: > > > Hi Joel, > > > > On Mon, 11 Jan 2021 at 20:01, Joel Peshkin > wrote: > > > > > > Cc: Simon Glass > > > Cc: Heinr

Re: [RFC PATCH 2/3] efi_loader: efi_loader: Replace config option for initrd loading

2021-01-13 Thread AKASHI Takahiro
Ilias, On Wed, Jan 13, 2021 at 01:11:48PM +0200, Ilias Apalodimas wrote: > Up to now we install EFI_LOAD_FILE2_PROTOCOL to load an initrd > unconditionally. Although we correctly return various EFI exit codes > depending on the file status (i.e EFI_NO_MEDIA, EFI_NOT_FOUND etc), the > kernel loader

[PATCH 00/17] Various minor clean-ups and improvements

2021-01-13 Thread Simon Glass
This series includes a collection of things noticed while bringing up verified boot on Coral. It includes support for relocating the bloblist. Simon Glass (17): doc: Correct documentation for uclass_root spl: Add functions for next and previous phase bloblist: Support relocating to a large

Re: [PATCH 4/4] log: Convert log values to printf() if not enabled

2021-01-13 Thread Heinrich Schuchardt
Am 14. Januar 2021 04:30:51 MEZ schrieb Simon Glass : >At present if logging not enabled, log_info() becomes a nop. But we >want >log output at the 'info' level to be akin to printf(). Update the macro >to >pass the output straight to printf() in this case. Looking at https://github.com/trini/u-

Re: [PATCH 0/4] log: Allow multiple lines and conversion to printf()

2021-01-13 Thread Heinrich Schuchardt
Am 14. Januar 2021 04:30:47 MEZ schrieb Simon Glass : >At present when logging is not enabled, all log calls become nops. This >does not seem right, since if the log level is high enough then there >should be some sort of message. So in that case, this series updates it >to >print the message if th

[PATCH 2/4] log: Handle line continuation

2021-01-13 Thread Simon Glass
When multiple log() calls are used which don't end in newline, the log prefix is prepended multiple times in the same line. This makes the output look strange. Fix this by detecting when the previous log record did not end in newline. In that case, setting a flag. Drop the unused BUFFSIZE in the

[PATCH 3/4] log: Add return-checking macros for 0 being success

2021-01-13 Thread Simon Glass
The existing log_ret() and log_msg_ret() macros consider an error to be less than zero. But some function may return a positive number to indicate a different kind of failure. Add macros to check for that also. Signed-off-by: Simon Glass --- doc/develop/logging.rst | 15 ++- include

[PATCH 4/4] log: Convert log values to printf() if not enabled

2021-01-13 Thread Simon Glass
At present if logging not enabled, log_info() becomes a nop. But we want log output at the 'info' level to be akin to printf(). Update the macro to pass the output straight to printf() in this case. Signed-off-by: Simon Glass --- doc/develop/logging.rst | 5 +++-- include/log.h | 12

[PATCH 1/4] log: Set up a flag byte for log records

2021-01-13 Thread Simon Glass
At present only a single flag (force_debug) is used in log records. Before adding more, convert this into a bitfield, so more can be added without using more space. To avoid expanding the log_record struct itself (which some drivers may wish to store in memory) reduce the line-number field to 16 b

[PATCH 0/4] log: Allow multiple lines and conversion to printf()

2021-01-13 Thread Simon Glass
At present when logging is not enabled, all log calls become nops. This does not seem right, since if the log level is high enough then there should be some sort of message. So in that case, this series updates it to print the message if the log level is above LOGL_INFO. Also the current implement

[PATCH 15/17] crc32: Exclude crc32 from TPL

2021-01-13 Thread Simon Glass
Unfortunately the toolchain often brings in the crc32 table even if the function is not actually used. For now, exclude it from the TPL build, which is very sensitive to size. Signed-off-by: Simon Glass --- lib/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/Makefile b/lib/Ma

[PATCH 17/17] binman: Allow reading entries from a subnode

2021-01-13 Thread Simon Glass
Some images may have multiple copies of the same thing, e.g. two versions of the read/write U-Boots. It is necessary to read data from one or other of these under selection of the verified-boot logic. Add a function to select the subnode to use. Signed-off-by: Simon Glass --- include/binman.h |

[PATCH 16/17] binman: Move selection of the binman node into a function

2021-01-13 Thread Simon Glass
Move this logic out of the main init function so it is available for other purpose. Use a different error when multiple-images is in use but no subnode is available. This makes it easier to determine what is wrong. Signed-off-by: Simon Glass --- lib/binman.c | 43 ++

[PATCH 14/17] mmc: pci_mmc: Set the removable flag

2021-01-13 Thread Simon Glass
Set this flag so that it is available to those looking at the device. For non-removable devices there is no need to check for insertion/removable since the media can never change. Signed-off-by: Simon Glass --- drivers/mmc/pci_mmc.c | 8 1 file changed, 8 insertions(+) diff --git a/dr

[PATCH 12/17] mmc: pci_mmc: Only generate ACPI code for the SD card

2021-01-13 Thread Simon Glass
At present if an eMMC part is in the system, the ACPI table generated will include information about that, as well as the SD card. We only need to include the SD card, since it has a card-detect GPIO. Use a different compatible string for each option, and add code only for the SD card. Signed-off-

[PATCH 13/17] x86: coral: Add a devicetree node for eMMC

2021-01-13 Thread Simon Glass
Add a node for this so we can indicate that it is does not require any ACPI code. Signed-off-by: Simon Glass --- arch/x86/dts/chromebook_coral.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/dts/chromebook_coral.dts b/arch/x86/dts/chromebook_coral.dts index 965f59276af..

[PATCH 09/17] fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup()

2021-01-13 Thread Simon Glass
This setting may be different in SPL and TPL. Update the code to check the correct setting. Signed-off-by: Simon Glass --- lib/fdtdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 54f7a1fe477..a2d2fb4e1fe 100644 --- a/lib/fdtdec.c +++ b/

[PATCH 11/17] uuid: Add a comment for UUID_STR_LEN

2021-01-13 Thread Simon Glass
This macro is the length of the string but excludes the terminator. Users must add 1 when declaring a large-enough string. Add a comment to make this clear. Signed-off-by: Simon Glass --- include/uuid.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uuid.h b/include/uuid.h index 73

[PATCH 10/17] display_options: Use USE_TINY_PRINTF for SPL check

2021-01-13 Thread Simon Glass
At present this code uses a simple printf() format if running in SPL. But SPL can use the full printf. Use USE_TINY_PRINTF instead. Signed-off-by: Simon Glass --- lib/display_options.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/display_options.c b/lib/displ

[PATCH 08/17] fdtdec: Update the missing-devicetree message

2021-01-13 Thread Simon Glass
This includes information about sandbox which is not relevant for most boards. Drop it. Also add the address to help figure out the problem. Signed-off-by: Simon Glass --- lib/fdtdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 0ab71

[PATCH 05/17] x86: tsc_timer: Correct overflow in __udelay()

2021-01-13 Thread Simon Glass
At present long delays such as msleep(2000) can cause an overflow in this function. There is no need for this, since it already uses a 64-bit int. Add a cast to correct this. Signed-off-by: Simon Glass --- drivers/timer/tsc_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH 04/17] bloblist: Add missing tag names

2021-01-13 Thread Simon Glass
Add tag names for recently added types. Fixes: d2cb7a22da0 (x86: Allow putting some tables in the bloblist) Signed-off-by: Simon Glass --- common/bloblist.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/common/bloblist.c b/common/bloblist.c index e32f551e27e..0e6448becbc 100644 ---

[PATCH 06/17] video: Allow syncing the entire framebuffer to the copy

2021-01-13 Thread Simon Glass
In some cases so much of the framebuffer is updated that it is not worth copying the changes piece by piece to the copy framebuffer. Add a function to copy the whole thing. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 10 ++ include/video.h | 14 +++

[PATCH 07/17] net: Use CONFIG_IS_ENABLED() in eth_dev_get_mac_address()

2021-01-13 Thread Simon Glass
This function may be used in SPL where devicetree is not available. Use the correct macro so that the function does not try to read it. Signed-off-by: Simon Glass --- net/eth-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/eth-uclass.c b/net/eth-uclass.c index 0

[PATCH 03/17] bloblist: Support relocating to a larger space

2021-01-13 Thread Simon Glass
Typically in TPL/SPL the bloblist is quite small. But U-Boot proper may want to add a lot more to it, such as ACPI tables. Add a way to expand the bloblist by relocating it in U-Boot proper, along with the other relocation activities. Signed-off-by: Simon Glass --- common/Kconfig | 10

[PATCH 02/17] spl: Add functions for next and previous phase

2021-01-13 Thread Simon Glass
It is useful to be able to figure out which phase we are loading next and which phase we came from. Add some functions to handle this as well as returning the name of a phase. This allows messages like "Booting to x" where x is the next phase. At present, TPL says 'Jumping to U-Boot' at the end, w

[PATCH 01/17] doc: Correct documentation for uclass_root

2021-01-13 Thread Simon Glass
The comments are swapped at present so this produces an error with 'make htmldocs'. Fix it. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_da

[PATCH] ARM: imx6: dh-imx6: Move bootcounter to SNVS_LPGDR

2021-01-13 Thread Marek Vasut
Move the bootcounter to SVNS_LPGDR to free up OCRAM for usage by the VPU. Signed-off-by: Marek Vasut Cc: Stefano Babic --- configs/dh_imx6_defconfig | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configs/dh_imx6_defconfig b/configs/dh_imx6_defconfig index 0d1f0cfeac1..0

Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-13 Thread Andy Shevchenko
On Thu, Jan 14, 2021 at 12:00 AM Simon Glass wrote: > On Wed, 13 Jan 2021 at 06:00, Andy Shevchenko > wrote: > > On Wed, Jan 13, 2021 at 5:39 AM Simon Glass wrote: ... > > I added myself with a topic, but two issues so far: > > - i have no camera setup > > That should be easy to fix! Unfortu

Re: [PATCH] net: sun8i-emac: Allow all RGMII PHY modes

2021-01-13 Thread André Przywara
On 30/11/2020 17:23, Heinrich Schuchardt wrote: Hi Joe, > On 11/16/20 10:46 AM, Andre Przywara wrote: >> So far all GBit users of the sun8i-emac driver were using the "rgmii" >> PHY mode, even though this turns out to be mostly wrong. It just worked >> because the PHY driver doesn't do the proper

Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-13 Thread Simon Glass
Hi Andy, On Wed, 13 Jan 2021 at 06:00, Andy Shevchenko wrote: > > On Wed, Jan 13, 2021 at 5:39 AM Simon Glass wrote: > > > > Hi, > > > > (This has been discussed for a while now so I thought I would just try it) > > > > As an experiment I'd like to set up a regular 30-minute U-Boot call > > for

Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-13 Thread Simon Glass
Hi Bin, I added you, Heinrich, Tom and Andy. For others, as mentioned in the doc I can add you to the invitation. Just reply on this thread. Regards, Simon On Tue, 12 Jan 2021 at 20:44, Bin Meng wrote: > > Hi Simon,, > > On Wed, Jan 13, 2021 at 11:39 AM Simon Glass wrote: > > > > Hi, > > > >

Re: [PATCH] Add fixdefconfig script to update lists of defconfig files from savedefconfig

2021-01-13 Thread Tom Rini
On Wed, Jan 13, 2021 at 09:10:41AM -0700, Simon Glass wrote: > Hi Joel, > > On Mon, 11 Jan 2021 at 20:01, Joel Peshkin wrote: > > > > Cc: Simon Glass > > Cc: Heinrich Schuchardt > > --- > > scripts/fixdefconfig | 25 + > > 1 file changed, 25 insertions(+) > > create m

Re: [PATCH 4/5] arm: dts: ls1028a: Add Ethernet switch node and dependencies

2021-01-13 Thread Michael Walle
Am 2021-01-13 19:05, schrieb Claudiu Manoil: From: Alex Marginean The definition follows the DSA binding in kernel and describes the switch, its ports and PHYs. ENETC PF6 is the 2nd Eth controller linked to the switch on LS1028A, it is not used in U-Boot and was disabled. Ethernet port ali

[PATCH 4/4] board: gateworks: imx8mm: Add Gateworks Venice board support

2021-01-13 Thread Tim Harvey
Add initial support for Gateworks Venice product family based on the i.MX 8M Mini SoC Signed-off-by: Tim Harvey --- arch/arm/dts/imx8mm-venice-gw700x-u-boot.dtsi| 105 + arch/arm/dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi |5 + arch/arm/dts/imx8mm-venice-gw72xx-0x-u-boot.dtsi |5 + arc

Re: Pull request: u-boot-riscv/master

2021-01-13 Thread Tom Rini
On Wed, Jan 13, 2021 at 01:34:55PM +0800, ub...@andestech.com wrote: > Hi Tom, > > Please pull some riscv updates: > > - Update qemu-riscv.rst build instructions. > - Add support for SPI on Kendryte K210. > - Add Microchip PolarFire SoC Icicle Kit support. > > Thanks > Rick > > CI: passed > ht

Re: spi-nor dummy bytes for fast read command

2021-01-13 Thread Tudor.Ambarus
On 1/13/21 4:06 AM, Bin Meng wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi, Hi, > > It seems both U-Boot and Linux kernel spi-nor drivers have the same > assumption on dummy cycles required in a fast read command. > > In U-Boot sp

Pull request for UEFI sub-system for efi-2021-04-rc1

2021-01-13 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit ee6726be4f0dccb612f0193c62ca149164c8a5af: Merge tag 'ti-v2021.04-rc1' of https://gitlab.denx.de/u-boot/custodians/u-boot-ti (2021-01-12 09:32:48 -0500) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.g

Re: [PATCH 03/16] dh_imx6: Switch to full DM-aware

2021-01-13 Thread Marek Vasut
On 6/29/20 4:01 PM, Tom Rini wrote: On Mon, Jun 29, 2020 at 12:27:08PM +, Ludwig Zenz wrote: On 25/06/20 2:52 PM, Tom Rini wrote: On Thu, Jun 25, 2020 at 02:52:58PM +, Ludwig Zenz wrote: On 22/06/20 9:38 AM, Tom Rini wrote: On Mon, Jun 22, 2020 at 09:38:36AM +, Ludwig Zenz wrote:

[PATCH 4/5] arm: dts: ls1028a: Add Ethernet switch node and dependencies

2021-01-13 Thread Claudiu Manoil
From: Alex Marginean The definition follows the DSA binding in kernel and describes the switch, its ports and PHYs. ENETC PF6 is the 2nd Eth controller linked to the switch on LS1028A, it is not used in U-Boot and was disabled. Ethernet port aliases were also added to better manage the multitude

[PATCH 2/5] sandbox: Add a DSA sandbox driver and unit test

2021-01-13 Thread Claudiu Manoil
The DSA sandbox driver is used for unit testing the DSA class code. It implements a simple 2 port switch plus 1 CPU port, and uses a very simple tag to identify the ports. The DSA sandbox device is connected via CPU port to a regular Ethernet sandbox device, called 'dsa-test-eth, managed by the exi

[PATCH 3/5] drivers: net: Add Felix DSA switch driver

2021-01-13 Thread Claudiu Manoil
From: Alex Marginean This driver is used for the Ethernet switch integrated into LS1028A NXP. Felix on LS1028A has 4 front panel ports and two internal ports, I/O to/from the switch is done through an ENETC Ethernet interface. The 4 front panel ports are available as Ethernet interfaces and can b

[PATCH 5/5] configs: ls1028a: Enable the Ethernet switch driver in defconfig

2021-01-13 Thread Claudiu Manoil
From: Alex Marginean The switch driver for LS1028A Ethernet switch is now compiled in for both LS1028A boards. Signed-off-by: Alex Marginean Signed-off-by: Claudiu Manoil --- configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 2 ++ configs/ls1028aqds_tfa_defconfig | 2 ++ configs/ls10

[PATCH 1/5] net: Introduce DSA class for Ethernet switches

2021-01-13 Thread Claudiu Manoil
DSA stands for Distributed Switch Architecture and it covers switches that are connected to the CPU through an Ethernet link and generally use frame tags to pass information about the source/destination ports to/from CPU. Front panel ports are presented as regular ethernet devices in U-Boot and the

[PATCH 0/5] Introduce DSA Ethernet switch class and Felix driver

2021-01-13 Thread Claudiu Manoil
DSA stands for Distributed Switch Architecture and it is a subsystem introduced in the Linux kernel to support switches that: - have an Ethernet link up to the CPU - use some form of tagging to identify the source/destination port for Rx/Tx - may be cascaded in tree-like structures. DSA is descr

[PATCH u-boot-marvell] arm: mvebu: turris_mox: enable wdt command in defconfig

2021-01-13 Thread Marek Behún
Enable wdt command in defconfig for Turris MOX. This is useful when doing debugging. Signed-off-by: Marek Behún --- configs/turris_mox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/turris_mox_defconfig b/configs/turris_mox_defconfig index 66dc2473d6..4543acf073 100644 ---

[PATCH 3/4] arm: dts: imx8mm: add Gateworks i.MX8 Mini Dev kits

2021-01-13 Thread Tim Harvey
Add Gateworks i.MX 8M Mini Development kits from Mainline Linux Signed-off-by: Tim Harvey --- arch/arm/dts/Makefile| 4 + arch/arm/dts/imx8mm-venice-gw700x.dtsi | 495 +++ arch/arm/dts/imx8mm-venice-gw71xx-0x.dts | 19 ++ arch/arm/dts/imx8mm-v

[PATCH 2/4] power: pmic: add driver for Monolithic Power mp5416

2021-01-13 Thread Tim Harvey
This adds basic register access and child regulator binding for the Monolithic MP5416 Power Management IC which integrates four DC/DC switching converters and five LDO regulators. Signed-off-by: Tim Harvey --- drivers/power/pmic/Kconfig | 15 +++ drivers/power/pmic/Makefile | 1 + drivers/

[PATCH 0/4] Add Gateworks Venice board support

2021-01-13 Thread Tim Harvey
The Gateworks Venice product family consists of several boards based on the i.MX 8M Mini SoC. A challenge I've had with this is that the board model information is stored in an I2C based EEPROM that must be read to know what PMIC is on the board in order to adjust certain power rails before DRAM i

[PATCH 1/4] Respect that some compression algos can be enabled separately for SPL

2021-01-13 Thread Tim Harvey
From: Frieder Schrempf Some compression algorithms currently can be enabled for SPL and U-Boot proper separately. Therefore we need to use CONFIG_IS_ENABLED() in these cases and also prevent compiling these functions in case of a host tool build. Signed-off-by: Frieder Schrempf Signed-off-by: T

[PATCH 4/4] board: keymile: add support for seli8 design based on nxp ls102x soc

2021-01-13 Thread Aleksandar Gerasimovski
The SELI8 design is a new tdm service unit card for Hitachi-Powergrids XMC and FOX product lines. It is based on NXP LS1021 SoC and it provides following interfaces: - IFC interface for NOR, NAND and external FPGA's - 1 x RGMII ETH for debug purposes - 2 x SGMII ETH for management communication

[PATCH 3/4] board: keymile: common: fix pnvramaddr and varaddr address calculation

2021-01-13 Thread Aleksandar Gerasimovski
Take into account SDRAM_BASE address when calculating pnvramaddr and varaddr offsets. Up to now Keymile designs had SDRAM_BASE equal to zero and the offsets where calculated correctly, this fix is for the upcoming designs that have SDRAM_BASE different then zero. Signed-off-by: Aleksandar Gerasimo

[PATCH 2/4] keymile: common: qrio: print QRIO id and revision number

2021-01-13 Thread Aleksandar Gerasimovski
Add show_qrio function to print chip id and revision information. There are already multiple QRIO chip versions available and the upcoming designs may want to show used version. Signed-off-by: Rainer Boschung Signed-off-by: Aleksandar Gerasimovski --- board/keymile/common/qrio.c | 12 +

[PATCH 1/4] board: keymile: common: fix qrio compilation for arm

2021-01-13 Thread Aleksandar Gerasimovski
This patch is fixing qrio driver compilation for ARM architecture: - It includes asm/io.h for in_/out_ access - It use correct names for set/clear_bits as defined in linux/bitops.h Signed-off-by: Aleksandar Gerasimovski --- board/keymile/common/qrio.c | 7 --- 1 file changed, 4 insertions(+

Re: [PATCH] fastboot: add UUU command UCmd and ACmd support

2021-01-13 Thread Simon Glass
Hi Heiko, On Mon, 11 Jan 2021 at 03:19, Heiko Schocher wrote: > > add support for the UUU commands ACmd and UCmd. > > Enable them through the Kconfig option > CONFIG_FASTBOOT_UUU_SUPPORT > > base was commit in NXP kernel > 9b149c2a2882: ("MLK-18591-3 android: Add FSL android fastboot support") >

Re: [PATCH] common: fit-sig: Fix error message in fit_config_verify_sig()

2021-01-13 Thread Simon Glass
On Mon, 11 Jan 2021 at 07:47, Alexandru Gagniuc wrote: > > In fit_config_verify_sig(), when no 'signature*' subnode exists in > the configuration node, the fdt_for_each_subnode() loop is a no-op. > Therefore, no error flags are set, and 'err_,sg' is not populated > with an error string. This is in

Re: [PATCH 1/4] misc: make CONFIG_IRQ selectable for all platforms

2021-01-13 Thread Simon Glass
On Tue, 12 Jan 2021 at 02:05, Wasim Khan wrote: > > From: Wasim Khan > > UCLASS_IRQ driver is not Intel specific. Make CONFIG_IRQ > selectable for all platfroms. > > Signed-off-by: Wasim Khan > --- > drivers/misc/Kconfig | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > Reviewed-b

Re: [PATCH] Add fixdefconfig script to update lists of defconfig files from savedefconfig

2021-01-13 Thread Simon Glass
Hi Joel, On Mon, 11 Jan 2021 at 20:01, Joel Peshkin wrote: > > Cc: Simon Glass > Cc: Heinrich Schuchardt > --- > scripts/fixdefconfig | 25 + > 1 file changed, 25 insertions(+) > create mode 100755 scripts/fixdefconfig +Tom Rini I normally use moveconfig for this...T

Re: [PATCH] cmd: disk: Remove fit_print_contents API

2021-01-13 Thread Simon Glass
On Fri, 8 Jan 2021 at 10:56, Ravik Hasija wrote: > > fit_print_contents prints similar fit information as printed in bootm stages. > Removing this API reduces redundancy & provides improvement in boottime. > > Signed-off-by: Ravik Hasija > --- > > cmd/disk.c | 1 - > 1 file changed, 1 deletion(-

Re: [PATCHv3 1/4] drivers: tee: i2c trampoline driver

2021-01-13 Thread Simon Glass
On Tue, 12 Jan 2021 at 01:43, Jorge Ramirez-Ortiz wrote: > > This commit gives the secure world access to the I2C bus so it can > communicate with I2C slaves (typically those would be secure elements > like the NXP SE050). > > A similar service implementation has been merged in linux: > c05210ab (

Re: [PATCH v3 3/6] lib: Add support for ECDSA image signing

2021-01-13 Thread Simon Glass
On Thu, 7 Jan 2021 at 15:34, Alexandru Gagniuc wrote: > > mkimage supports rsa2048, and rsa4096 signatures. With newer silicon > now supporting hardware-accelerated ECDSA, it makes sense to expand > signing support to elliptic curves. > > Implement host-side ECDSA signing and verification with lib

Re: [PATCH 3/5] lib: ecdsa: Implement signature verification for crypto_algo API

2021-01-13 Thread Simon Glass
On Mon, 11 Jan 2021 at 08:41, Alexandru Gagniuc wrote: > > Implement the crypto_algo .verify() function for ecdsa256. Because > it backends on UCLASS_ECDSA, this change is focused on parsing the > keys from devicetree and passing this information to the specific > UCLASS driver. > > Signed-off-by:

Re: [PATCH 4/4] sandbox: enable IRQ using select for sandbox architecture

2021-01-13 Thread Simon Glass
On Tue, 12 Jan 2021 at 02:05, Wasim Khan wrote: > > From: Wasim Khan > > Enable IRQ using select for sandbox architecture. > > Signed-off-by: Wasim Khan > --- > arch/Kconfig | 1 + > configs/sandbox64_defconfig| 1 - > configs/sandbox_defconfig | 1 - > co

Re: [PATCH] pci: Remove CONFIG_PCI_ENUM_ONLY as it's not used (any more)

2021-01-13 Thread Simon Glass
On Tue, 12 Jan 2021 at 04:03, Stefan Roese wrote: > > This patch completely removes CONFIG_PCI_ENUM_ONLY from the PCI code as > it is not configured for any board (any more). With this removal, some > PCI related files get cleaned up a bit. > > Additional, dm_pciauto_setup_device() is now static,

Re: [PATCH 2/4] arch: arm: update Kconfig to select IRQ when GIC_V3_ITS is enabled

2021-01-13 Thread Simon Glass
On Tue, 12 Jan 2021 at 02:05, Wasim Khan wrote: > > From: Wasim Khan > > GIC_V3_ITS uses UCLASS_IRQ driver. Update Kconfig to select > IRQ when GIC_V3_ITS is enabled. > > Signed-off-by: Wasim Khan > --- > arch/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass

Re: [PATCH 3/4] arch: Kconfig: enable IRQ using select for x86 architecture

2021-01-13 Thread Simon Glass
On Tue, 12 Jan 2021 at 02:05, Wasim Khan wrote: > > From: Wasim Khan > > use 'select' to enable IRQ as it does not have architecture > specific dependency. > > Signed-off-by: Wasim Khan > --- > arch/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCHv3 4/4] test: dm: tee: extend with RPC test

2021-01-13 Thread Simon Glass
On Tue, 12 Jan 2021 at 01:44, Jorge Ramirez-Ortiz wrote: > > From: Igor Opaniuk > > Extend existing DM tee tests adding test coverage for reverse RPC calls. > Currently this commit only adds tests for I2C requests from TEE driver > to TEE supplicant, for instance reading/writing data to emulated

Re: [PATCHv3 3/4] drivers: tee: sandbox: add rpc test ta emulation

2021-01-13 Thread Simon Glass
On Tue, 12 Jan 2021 at 01:44, Jorge Ramirez-Ortiz wrote: > > From: Igor Opaniuk > > This adds support for RPC test trusted application emulation, which > permits to test reverse RPC calls to TEE supplicant. Currently it covers > requests to the I2C bus from TEE. > > Signed-off-by: Igor Opaniuk >

Re: [PATCHv3 2/4] test: py: add pygit2 and pyelftools to requirements.txt

2021-01-13 Thread Simon Glass
On Tue, 12 Jan 2021 at 01:43, Jorge Ramirez-Ortiz wrote: > > From: Igor Opaniuk > > Add pygit2 and pyelftools to the list of packages for virtualenv > needed to run all sets of pytests.This fixes warnings like: > > binman.elf_test.TestElf.testDecodeElf (subunit.RemotedTestCase): > Python elftools

Re: [PATCH 5/5] Kconfig: FIT_SIGNATURE should not select RSA_VERIFY

2021-01-13 Thread Simon Glass
On Mon, 11 Jan 2021 at 08:41, Alexandru Gagniuc wrote: > > FIT signatures can now be implemented with ECDSA. The assumption that > all FIT images are signed with RSA is no longer valid. Thus, instead > of 'select'ing RSA, only 'imply' it. This doesn't change the defaults, > but allows one to expli

Re: [PATCH 1/5] dm: crypto: Define UCLASS API for ECDSA signature verification

2021-01-13 Thread Simon Glass
Hi Alexandru, On Mon, 11 Jan 2021 at 08:41, Alexandru Gagniuc wrote: > > Define a UCLASS API for verifying ECDSA signatures. Unlike > UCLASS_MOD_EXP, which focuses strictly on modular exponentiation, > the ECDSA class focuses on verification. This is done so that it > better aligns with mach-spec

Re: [PATCH v3 5/6] test/py: Add pycryptodomex to list of required pakages

2021-01-13 Thread Simon Glass
On Thu, 7 Jan 2021 at 15:34, Alexandru Gagniuc wrote: > > We wish to use pycryptodomex to verify code paths involving ECDSA > signatures. Add it to requirements.txt so that they get picked up > automatically .gitlab and .azure tasks > > Signed-off-by: Alexandru Gagniuc > --- > test/py/requiremen

Re: [PATCH v3 6/6] test/py: ecdsa: Add test for mkimage ECDSA signing

2021-01-13 Thread Simon Glass
Hi Alexandru, On Thu, 7 Jan 2021 at 15:34, Alexandru Gagniuc wrote: > > Add a test to make sure that the ECDSA signatures generated by > mkimage can be verified successfully. pyCryptodomex was chosen as the > crypto library because it integrates much better with python code. > Using openssl would

Re: [PATCH v3 4/6] doc: signature.txt: Document devicetree format for ECDSA keys

2021-01-13 Thread Simon Glass
On Thu, 7 Jan 2021 at 15:34, Alexandru Gagniuc wrote: > > Signed-off-by: Alexandru Gagniuc > --- > doc/uImage.FIT/signature.txt | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > I think you left off my review tag so I am adding it again here. You can try 'patman status' to collect

Re: [PATCH v3 2/6] lib/rsa: Make fdt_add_bignum() available outside of RSA code

2021-01-13 Thread Simon Glass
On Thu, 7 Jan 2021 at 15:33, Alexandru Gagniuc wrote: > > fdt_add_bignum() is useful for algorithms other than just RSA. To > allow its use for ECDSA, move it to a common file under lib/. > > The new file is suffixed with '-libcrypto' because it has a direct > dependency on openssl. This is due to

Re: [PATCH v3 1/6] lib: Rename rsa-checksum.c to hash-checksum.c

2021-01-13 Thread Simon Glass
On Thu, 7 Jan 2021 at 15:33, Alexandru Gagniuc wrote: > > rsa-checksum.c sontains the hash_calculate() implementations. Despite > the "rsa-" file prefix, this function is useful for other algorithms. > > To prevent confusion, move this file to lib/crypto, and rename it to > hash-checksum.c, to giv

[PATCH v3] board: phytec: imx8mp: Add PHYTEC phyCORE-i.MX8MP support

2021-01-13 Thread Teresa Remmet
Add initial support PHYTEC phyCORE-i.MX8MP SOM. Supported features: - 2GB LPDDR4 RAM - eMMC - external SD - debug UART2 - watchdog Signed-off-by: Teresa Remmet Reviewed-by: Heiko Schocher --- Changes in v3: - switched to accepted upstream kernel device tree (http

Re: [PATCH] env: Remove all dependencies for SYS_REDUNDAND_ENVIRONMENT

2021-01-13 Thread Michal Simek
On 13. 01. 21 15:43, Tom Rini wrote: > On Wed, Jan 13, 2021 at 03:24:24PM +0100, Michal Simek wrote: >> On 13. 01. 21 15:02, Tom Rini wrote: >>> On Wed, Jan 13, 2021 at 01:26:27PM +0100, Michal Simek wrote: >>> CONFIG_SYS_REDUNDAND_ENVIRONMENT is changing in env_internal.h how u-boot w

[PATCH v2] armv8: lx2: SVR_SOC_VER: Mask CAN_FD and security bit

2021-01-13 Thread Wasim Khan
From: Wasim Khan Multiple LX2(LX2160A/LX2162A SoC) personality variants exists based on CAN-FD and security bit in SVR. Currenly SVR_SOC_VER mask only security bit. Update SVR_SOC_VER to mask CAN_FD and security bit for LX2 products. Signed-off-by: Wasim Khan --- Changes in v2: - Updated commi

activate Logging SPL log.c:48: undefined reference to `uclass_get_name'

2021-01-13 Thread Arendt, Steffen
By activating Logging of SPL (uboot 20.04) I got the error: aarch64-poky-linux-ld.bfd: common/built-in.o: in function `log_get_cat_name': /home/user/y/src/uboot/uboot-imx/common/log.c:48: undefined reference to `uclass_get_name' I found something about DM in mailing list, but DM is activated whi

build the u-boot for BCM53016

2021-01-13 Thread scd rjcom
How do I build the u-boot for BCM53016 SoC ( https://www.broadcom.com/products/embedded-and-networking-processors/communications/bcm5301x )? Is there any compatible board/config for the BCM53016 SoC? It is supported by the linux kernel under CONFIG_ARCH_BCM_5301X config flag.

[PATCH V2] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF

2021-01-13 Thread Peng Fan (OSS)
From: Peng Fan Drop CONFIG_SYS_[I,D]CACHE_OFF, it is safe to run with caches enabled on these platforms. Signed-off-by: Peng Fan --- V2: Update subject/commit Per Fabio's comments include/configs/imx8mn_evk.h | 2 -- include/configs/imx8mp_evk.h | 2 -- 2 files changed, 4 deletions(-) diff

[PATCH] imx: imx8mn/p: drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage

2021-01-13 Thread Peng Fan (OSS)
From: Peng Fan Drop CONFIG_SYS_[I,D]CACHE_OFF in SPL stage Signed-off-by: Peng Fan --- This is to replace https://patchwork.ozlabs.org/project/uboot/patch/20210103101144.4375-12-peng@oss.nxp.com/ include/configs/imx8mn_evk.h | 2 -- include/configs/imx8mp_evk.h | 2 -- 2 files changed, 4

Re: [PULL u-boot] Please pull u-boot-amlogic-20210112

2021-01-13 Thread Tom Rini
On Tue, Jan 12, 2021 at 05:39:54PM +0100, Neil Armstrong wrote: > Hi Tom, > > These are the changes for the next release, in brief is adds some features to > the VIM3 boards > (drivers fro function button detect using ADC, mac from efuses), new boards > (V2 of libretech-cc, > GT-King/Pro and We

Re: [PATCH] env: Remove all dependencies for SYS_REDUNDAND_ENVIRONMENT

2021-01-13 Thread Tom Rini
On Wed, Jan 13, 2021 at 03:24:24PM +0100, Michal Simek wrote: > On 13. 01. 21 15:02, Tom Rini wrote: > > On Wed, Jan 13, 2021 at 01:26:27PM +0100, Michal Simek wrote: > > > >> CONFIG_SYS_REDUNDAND_ENVIRONMENT is changing in env_internal.h how u-boot > >> works with variables. struct environment_s

Re: [PATCH] env: Remove all dependencies for SYS_REDUNDAND_ENVIRONMENT

2021-01-13 Thread Michal Simek
On 13. 01. 21 15:02, Tom Rini wrote: > On Wed, Jan 13, 2021 at 01:26:27PM +0100, Michal Simek wrote: > >> CONFIG_SYS_REDUNDAND_ENVIRONMENT is changing in env_internal.h how u-boot >> works with variables. struct environment_s has one byte flags property >> which also affects ENV_SIZE macro. >>

Re: [PATCH] env: Remove all dependencies for SYS_REDUNDAND_ENVIRONMENT

2021-01-13 Thread Tom Rini
On Wed, Jan 13, 2021 at 01:26:27PM +0100, Michal Simek wrote: > CONFIG_SYS_REDUNDAND_ENVIRONMENT is changing in env_internal.h how u-boot > works with variables. struct environment_s has one byte flags property > which also affects ENV_SIZE macro. > > I have reached the case where CONFIG_ENV_IS_N

Re: [RFC PATCH 1/3] efi_loader: Introduce helper functions for EFI

2021-01-13 Thread Ilias Apalodimas
Hi Heinrich, > > + efi_status_t ret; > > + void *buf = NULL; > > + > > + *size = 0; > > + ret = efi_get_variable_int(name, vendor, NULL, size, buf, NULL); > > + if (ret == EFI_BUFFER_TOO_SMALL) { > > + buf = malloc(*size); > > Please, always check the output of malloc(), e.g. >

Re: Devicetree state of U-Boot vs kernel

2021-01-13 Thread Neil Armstrong
Hi, On 08/01/2021 01:39, Bill Mills wrote: > All, > > On the Devicetree evolution call Wednesday I promised to finish my comparison > of u-boot DT vs kernel DT. > The script is not perfect but the results are still interesting. > > For each dts and dtsi file in the tip of the u-boot tree, it tr

Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-13 Thread Heinrich Schuchardt
On 13.01.21 14:12, Marek Vasut wrote: > On 1/13/21 1:59 PM, Andy Shevchenko wrote: >> On Wed, Jan 13, 2021 at 5:39 AM Simon Glass wrote: >>> >>> Hi, >>> >>> (This has been discussed for a while now so I thought I would just >>> try it) >>> >>> As an experiment I'd like to set up a regular 30-minut

Re: [RFC PATCH 2/3] efi_loader: efi_loader: Replace config option for initrd loading

2021-01-13 Thread Ilias Apalodimas
> > + initrd= will stop working. The protocol will only be [...] > > How about > > "Linux v5.7 and later can make use of this option. If the boot option > selected by the UEFI boot manager specifies an existing file to be used > as initial RAM disk, a Linux specific Load File2 protocol will b

Re: [RFC PATCH 3/3] efidebug: add multiple device path instances on Boot####

2021-01-13 Thread Ilias Apalodimas
On Wed, Jan 13, 2021 at 02:13:44PM +0100, Heinrich Schuchardt wrote: > On 13.01.21 12:11, Ilias Apalodimas wrote: > > The UEFI spec allow a packed array of UEFI device paths in the > > FilePathList[] of an EFI_LOAD_OPTION. The first file path must > > describe the laoded image but the rest are OS s

Re: [RFC PATCH 3/3] efidebug: add multiple device path instances on Boot####

2021-01-13 Thread Heinrich Schuchardt
On 13.01.21 12:11, Ilias Apalodimas wrote: > The UEFI spec allow a packed array of UEFI device paths in the > FilePathList[] of an EFI_LOAD_OPTION. The first file path must > describe the laoded image but the rest are OS specific. > Previous patches parse the device path and try to use the second >

Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-13 Thread Marek Vasut
On 1/13/21 1:59 PM, Andy Shevchenko wrote: On Wed, Jan 13, 2021 at 5:39 AM Simon Glass wrote: Hi, (This has been discussed for a while now so I thought I would just try it) As an experiment I'd like to set up a regular 30-minute U-Boot call for people to discuss features, bugs, patches, etc.

  1   2   >