Re: [PATCH 4/5] log: convert pr_*() to logging

2021-01-16 Thread Heinrich Schuchardt
On 1/17/21 1:16 AM, Tom Rini wrote: On Mon, Jan 04, 2021 at 08:02:55AM +0100, Heinrich Schuchardt wrote: In drivers we use a family of printing functions including pr_err() and pr_cont(). CONFIG_LOGLEVEL is used to control which of these lead to output via printf(). Our logging functions allow

Re: [PATCH 4/4] log: Convert log values to printf() if not enabled

2021-01-16 Thread Heinrich Schuchardt
On 1/14/21 4:30 AM, Simon Glass wrote: At present if logging not enabled, log_info() becomes a nop. But we want log output at the 'info' level to be akin to printf(). Update the macro to pass the output straight to printf() in this case. Signed-off-by: Simon Glass --- doc/develop/logging.rst

Re: [PATCH 4/5] log: convert pr_*() to logging

2021-01-16 Thread Heinrich Schuchardt
On 1/17/21 1:37 AM, Sean Anderson wrote: On 1/4/21 2:02 AM, Heinrich Schuchardt wrote: In drivers we use a family of printing functions including pr_err() and pr_cont(). CONFIG_LOGLEVEL is used to control which of these lead to output via printf(). Our logging functions allow finer grained co

[PATCH 1/1] efi_loader: efi_size_in_pages() missing parentheses

2021-01-16 Thread Heinrich Schuchardt
Add parentheses around size to avoid possible operator precedence problems. Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/efi_loader.h b/include/efi_loader.h index e53d286b9d..3c69d9ce1e 100644 --- a/includ

[PATCH 1/1] efi_loader: provide initrddump test tool

2021-01-16 Thread Heinrich Schuchardt
Provide an UEFI application to save the initial RAM disk provided by U-Boot via the Load File2 protocol. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/Makefile | 6 + lib/efi_selftest/initrddump.c | 378 ++ 2 files changed, 384 insertions(+) creat

[PATCH 1/1] efi_selftest: don't compile dtbdump if GENERATE_ACPI_TABLE

2021-01-16 Thread Heinrich Schuchardt
If we are using ACPI tables instead of a device tree, we don't need the dtbdump.efi test tool. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/efi_selftest/Makefile b/lib/efi_selftest/Makefile index 426

Re: [PATCH 5/7] sandbox: Avoid using malloc() for system state

2021-01-16 Thread Heinrich Schuchardt
On 1/16/21 10:54 PM, Simon Glass wrote: This state is not accessible to the running U-Boot but at present it is allocated in the emulated SDRAM. This doesn't seem very useful. Adjust it to allocate from the OS instead. Signed-off-by: Simon Glass --- arch/sandbox/cpu/state.c | 16

[PATCH 1/1] efi_selftest: ask before overwriting in dtbdump.efi

2021-01-16 Thread Heinrich Schuchardt
Before overwriting an existing file ask the user. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/dtbdump.c | 59 +- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/lib/efi_selftest/dtbdump.c b/lib/efi_selftest/dtbdump.c index efef759863.

RE: [PATCH 2/3] cmd: Makefile: build nvedit.c when needed

2021-01-16 Thread Peng Fan
> Subject: Re: [PATCH 2/3] cmd: Makefile: build nvedit.c when needed > > On Mon, Dec 28, 2020 at 08:13:12PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > No need to build nvedit.c when CONFIG_$(SPL_)ENV_SUPPORT is n > > > > Signed-off-by: Peng Fan > > Reviewed-by: Simon Glass > >

Re: [PATCH 4/5] log: convert pr_*() to logging

2021-01-16 Thread Sean Anderson
On 1/4/21 2:02 AM, Heinrich Schuchardt wrote: In drivers we use a family of printing functions including pr_err() and pr_cont(). CONFIG_LOGLEVEL is used to control which of these lead to output via printf(). Our logging functions allow finer grained control of output. So replace printf() by the

Re: [PATCH 2/3] cmd: Makefile: build nvedit.c when needed

2021-01-16 Thread Tom Rini
On Mon, Dec 28, 2020 at 08:13:12PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > No need to build nvedit.c when CONFIG_$(SPL_)ENV_SUPPORT is n > > Signed-off-by: Peng Fan > Reviewed-by: Simon Glass This breaks a handful of PowerPC platforms that are using the original SPL/etc setup and d

Re: [PATCH 4/5] log: convert pr_*() to logging

2021-01-16 Thread Tom Rini
On Mon, Jan 04, 2021 at 08:02:55AM +0100, Heinrich Schuchardt wrote: > In drivers we use a family of printing functions including pr_err() and > pr_cont(). CONFIG_LOGLEVEL is used to control which of these lead to output > via printf(). > > Our logging functions allow finer grained control of out

[PATCH] ARM: imx: add i.MX8MN lpddr4 image cfg file

2021-01-16 Thread Marek Vasut
Add cfg file for i.MX8MN LPDDR4 Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- arch/arm/mach-imx/imx8m/imximage-8mn-lpddr4.cfg | 17 + 1 file changed, 17 insertions(+) create mode 100644 arch/arm/mach-imx/imx8m/imximage-8mn-lpddr4.cfg diff --

[PATCH] ARM: imx: Add missing FEC ethernet quirk for MX8M

2021-01-16 Thread Marek Vasut
The MX8M also contains a gigabit MAC, so define FEC_QUIRK_ENET_MAC. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- arch/arm/include/asm/arch-imx8m/imx-regs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/include/asm/arch-imx8m/imx-regs.h b/ar

[PATCH] net: phy: micrel: Try default PHY ofnode first

2021-01-16 Thread Marek Vasut
The phydev structure has a PHY OF node pointer in it, use that OF node first when looking up PHY OF node properties, since that is likely the correct PHY OF node pointer. If the pointer is not valid, which is the case e.g. on legacy DTs, fall back to parsing MAC ethernet-phy subnode. Signed-off-by

[PATCH 7/7] bootm: Fix duplicate debugging in bootm_process_cmdline()

2021-01-16 Thread Simon Glass
These two returns use the same string so are not distinguishable with LOG_ERROR_RETURN. Fix it. Signed-off-by: Simon Glass --- common/bootm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/bootm.c b/common/bootm.c index 8298693900d..48a5b04cd7a 100644 --- a/common/bo

[PATCH 6/7] sandbox: Write out bloblist when existing

2021-01-16 Thread Simon Glass
Sandbox provides a way to write out its emulated memory on exit. This makes it possible to pass a bloblist from one phase (e.g. SPL) to the next. However the bloblist is not closed off, so the checksum is generally invalid. Fix this by finishing up the bloblist before writing the memory file. Sig

[PATCH 4/7] s5p4418_nanopi2: Bring in some dead code

2021-01-16 Thread Simon Glass
This code is still using the old command typedef. It was not noticed since this file is not currently built. It is using a non-existent option in the Makefile. Fix it up and add it to the build. (This is offered as an act of service in the hope of receiving a free beer at some point.) Signed-off

[PATCH 5/7] sandbox: Avoid using malloc() for system state

2021-01-16 Thread Simon Glass
This state is not accessible to the running U-Boot but at present it is allocated in the emulated SDRAM. This doesn't seem very useful. Adjust it to allocate from the OS instead. Signed-off-by: Simon Glass --- arch/sandbox/cpu/state.c | 16 1 file changed, 8 insertions(+), 8 de

[PATCH 3/7] doc: Add a note about how to produce 'md' output using hexdump

2021-01-16 Thread Simon Glass
Comparing a hex dump on the U-Boot command line with the contents of a file on the host system is fairly easy and convenient to do manually if it is small. But the format used hexdump by default differs from that shown by U-Boot. Add a note about how to make them the same. (For large dumps, writin

[PATCH 2/7] binman: Indicate how to make binman verbose

2021-01-16 Thread Simon Glass
Add notes about how to make binman produce verbose logging when building. Add a comment on how to do this. Signed-off-by: Simon Glass --- Makefile| 1 + tools/binman/README | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c2b7046ce3b

[PATCH 1/7] spl: Drop duplicate 'Jumping to U-Boot' message

2021-01-16 Thread Simon Glass
This is printed twice but we only need one message, since there is very little processing in between them. Drop the first one. Signed-off-by: Simon Glass --- common/spl/spl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 12b00e2a407..7fe0812799f 10

[PATCH 0/7] Various minor fixes

2021-01-16 Thread Simon Glass
This series collects a few minor fixes and improvements that have been hanging around in a branch for a while. Simon Glass (7): spl: Drop duplicate 'Jumping to U-Boot' message binman: Indicate how to make binman verbose doc: Add a note about how to produce 'md' output using hexdump s5p441

[PATCH 12/12] x86: coral: Show memory config and SKU ID on startup

2021-01-16 Thread Simon Glass
Provide the model information through sysinfo so that it shows up on boot. For memconfig 4 pins are provided, for 16 combinations. For SKU ID there are two options: - two pins provided in a ternary arrangement, for 9 combinations. - reading from the EC Add a binding doc and drop the unused

[PATCH 11/12] sysinfo: Allow showing model info from sysinfo

2021-01-16 Thread Simon Glass
Some boards may want to show the SKU ID or other information obtained at runtime. Allow this to come from sysinfo. The board can then provide a sysinfo driver to provide it. Signed-off-by: Simon Glass --- common/board_info.c | 37 + include/sysinfo.h | 4 +

[PATCH 10/12] x86: tpl: Show next stage being booted

2021-01-16 Thread Simon Glass
Enhance the debugging to show the next stage being booted as well as a dump of the start of the image. Signed-off-by: Simon Glass --- arch/x86/lib/tpl.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/lib/tpl.c b/arch/x86/lib/tpl.c index 04ff32277fd..c84a0c9bc

[PATCH 09/12] x86: spl: Clear BSS unconditionally

2021-01-16 Thread Simon Glass
This should be done even if not using TPL, since BSS may be in use or boards that only use SPL. Fix it. Signed-off-by: Simon Glass --- arch/x86/lib/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/spl.c b/arch/x86/lib/spl.c index cf22fa2d7b5..6699de49c63 10

[PATCH 08/12] x86: zimage: Improve command-line debug handling

2021-01-16 Thread Simon Glass
At present if the command line is very long it is truncated by the printf() statement, which works within a limited buffer. Use puts() instead. Also show better debugging with the command-line setup fails. Signed-off-by: Simon Glass --- arch/x86/lib/zimage.c | 10 +++--- 1 file changed, 7 i

[PATCH 07/12] x86: zimage: Allow dumping the image from outside the module

2021-01-16 Thread Simon Glass
At present it is possible to dump an image within the zimage command, but it is also useful to be able to dump it from elsewhere, for example in a loader that has special handling for the different zimage stages. Export this feature as a new function. Signed-off-by: Simon Glass --- arch/x86/in

[PATCH 06/12] x86: Update Chromium OS GNVS names

2021-01-16 Thread Simon Glass
The Global Non-Voltatile Storage struct has some fields with particular meanings. Rename these to make things easier to follow. Also add a few more boot flags. GNVS should not be confused with GNVQ (Going Nowhere Very Quickly). Signed-off-by: Simon Glass --- arch/x86/include/asm/intel_gnvs.h |

[PATCH 05/12] x86: spl: Make moving BSS conditional

2021-01-16 Thread Simon Glass
At present BSS is always placed in SDRAM. If a separate BSS is not in use this means that BSS doesn't work as expected. Make the setting conditional on the SEPARATE_BSS option. Signed-off-by: Simon Glass --- arch/x86/cpu/u-boot-spl.lds | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/

[PATCH 04/12] x86: Make sure the SPL image ends on a suitable boundary

2021-01-16 Thread Simon Glass
The part of U-Boot that actually ends up in u-boot-nodtb.bin is not built with any particular alignment. It ends at the start of the BSS section. The BSS section selects its own alignment, which may larger. This means that there can be a gap of a few bytes between the image ending and BSS starting.

[PATCH 03/12] x86: apl: Enhance debugging in the SPL loader

2021-01-16 Thread Simon Glass
Move to log_debug() and make use of the new SPL function to find the text base. Signed-off-by: Simon Glass --- arch/x86/cpu/apollolake/spl.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/arch/x86/cpu/apollolake/spl.c b/arch/x86/cpu/apollolake/spl.c index 8991d

[PATCH 02/12] x86: spl: Add a function to find the text base

2021-01-16 Thread Simon Glass
It is useful to know the TEXT_BASE value for the image being loaded in TPL/SPL. Add a new spl_get_image_text_base() function to handle this. Make use of this in the x86 SPL handler, instead of having the logic there. Signed-off-by: Simon Glass --- common/spl/spl.c | 6 ++ include/spl.h

[PATCH 01/12] x86: acpi_gpe: Update driver name to match devicetree

2021-01-16 Thread Simon Glass
Use a driver name in line with the compatible string so that of-platdata can use this driver. Signed-off-by: Simon Glass --- arch/x86/cpu/acpi_gpe.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/cpu/acpi_gpe.c b/arch/x86/cpu/acpi_gpe.c index 83128c33c2c..da0

[PATCH 00/12] x86: Minor improvements mostly for image loading

2021-01-16 Thread Simon Glass
This series provides a few improvements for loading of images. It also provides a way to show more detailed model information as well as an of-platdata fix noticed recently. Simon Glass (12): x86: acpi_gpe: Update driver name to match devicetree x86: spl: Add a function to find the text base

[PATCH 10/10] cros_ec: Add vstore support

2021-01-16 Thread Simon Glass
The EC can store small amounts of data for the benefit of the verified boot process. Since the EC is seldom reset, this can allow the AP to store data that survives a reboot or a suspend/resume cycle. Add support for this. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 71

[PATCH 09/10] cros_ec: Allow use with of-platdata

2021-01-16 Thread Simon Glass
Avoid reading the device tree when of-platdata is in use. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/misc/cros_ec.c b/drivers/misc/cros_ec.c index 0bc28e882c9..c22bb4b5b50 100644 --- a/drivers/misc/cros_ec.c +++ b/drivers/

[PATCH 08/10] cros_ec: Show events in human-readable form

2021-01-16 Thread Simon Glass
Add a command to show the current events as a list of names. This is easier to decipher than a bit mask. Signed-off-by: Simon Glass --- cmd/cros_ec.c | 70 +++--- drivers/misc/cros_ec_sandbox.c | 12 +- test/dm/cros_ec.c | 37 +++

[PATCH 07/10] cros_ec: Add support for switches

2021-01-16 Thread Simon Glass
On x86 platforms the EC provides a way to read 'switches', which are on/off values determined by the EC. Add a new driver method for this and implement it for LPC. Signed-off-by: Simon Glass --- arch/sandbox/include/asm/test.h | 1 + cmd/cros_ec.c | 41 ++

[PATCH 06/10] cros_ec: Add documentation for cros_ec driver operations

2021-01-16 Thread Simon Glass
Add comments to these methods so it is documented in this central place, not just in each driver. Signed-off-by: Simon Glass --- include/cros_ec.h | 40 1 file changed, 40 insertions(+) diff --git a/include/cros_ec.h b/include/cros_ec.h index 338878c3be

[PATCH 05/10] cros_ec: Support reading EC features

2021-01-16 Thread Simon Glass
The EC can support a variety of features and provides a way to find out what is available. Add support for this. Also update the feature list to the lastest available while we are here. This is at: https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master/include/ec_command

[PATCH 04/10] cros_ec: Add support for reading the SKU ID

2021-01-16 Thread Simon Glass
This allows reading strapping pins attached to the EC. Add an implementation for this. Signed-off-by: Simon Glass --- cmd/cros_ec.c | 10 ++ drivers/misc/cros_ec.c | 13 + drivers/misc/cros_ec_sandbox.c | 7 +++ include/cros_ec.h |

[PATCH 03/10] cros_ec: Add run-time check for input buffer overflow

2021-01-16 Thread Simon Glass
This should not happen in normal operation, but the EC might have a bug, so add a run-time check just in case. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/misc/cros_ec.c b/drivers/misc/cros_ec.c index ce5fa5bee35..e51ac8740

[PATCH 02/10] cros_ec: Tidy up a few delays

2021-01-16 Thread Simon Glass
Allow a longer time for the EC to reboot. Also use a constant for the hash delay time, so it is clear what it is for. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/misc/cros_ec.c b/driv

[PATCH 01/10] cros_ec: Add a function for the hello message

2021-01-16 Thread Simon Glass
This is used several times in this file. Put it in a function to avoid code duplication. Also add a test for this function. There are no cros_ec tests at present, so it is time to update the code. Signed-off-by: Simon Glass --- arch/sandbox/include/asm/test.h | 14 ++ drivers/misc/cros

[PATCH 00/10] cros_ec: Add features required for verified boot

2021-01-16 Thread Simon Glass
The Chromium OS EC has developed a few more features. This series adds support for some of these, to allow a more recent verified-boot implementation to work. Also some existing features don't have commands available. It is useful to be able to check the EC state from the command line, so this ser

[PATCH 11/11] tpm: Allow disabling platform hierarchy with TPM2

2021-01-16 Thread Simon Glass
With TPM2 we don't actually lock the TPM once verified boot is finished. Instead we disable the platform hierarchy which serves the same purpose. Add an implementation of this so we can safely boot into the kernel. Signed-off-by: Simon Glass --- include/tpm-v2.h | 12 lib/tpm-v2.c

[PATCH 09/11] tpm: Add TPM2 support for read/write values

2021-01-16 Thread Simon Glass
Implement this API function for TPM2. Signed-off-by: Simon Glass --- include/tpm-common.h | 3 ++ include/tpm-v2.h | 38 lib/tpm-v2.c | 84 lib/tpm_api.c| 4 +-- 4 files changed, 127 insertions(+), 2 deletio

[PATCH 10/11] tpm: Add TPM2 support for write_lock

2021-01-16 Thread Simon Glass
Implement this API function for TPM2. Signed-off-by: Simon Glass --- include/tpm-v2.h | 12 lib/tpm-v2.c | 23 +++ lib/tpm_api.c| 2 +- 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 6a400771af1.

[PATCH 05/11] tpm: Switch TPMv1 over to use the new API

2021-01-16 Thread Simon Glass
Take over the plain 'tpm_...' functions for use by the new TPM API. Rename all the TPMv1 functions so they are called from the API. Update the TPMv1 functions so that they are called from the API. Change existing users to use the tpm1_ prefix so they don't need to go through the API, which might i

[PATCH 08/11] tpm: Add an implementation of define_space

2021-01-16 Thread Simon Glass
Add support for this so that the TPM can be set up for use with Chromium OS verified boot. Signed-off-by: Simon Glass --- include/tpm-v2.h | 18 ++ lib/tpm-v2.c | 44 2 files changed, 62 insertions(+) diff --git a/include/tpm-v2.

[PATCH 07/11] tpm: Reduce duplication in a few functions

2021-01-16 Thread Simon Glass
Update tpm2_clear() and tpm2_pcr_extend() so that the command size is not repeated twice. Add a small comment to the latter. Signed-off-by: Simon Glass --- lib/tpm-v2.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c index 1f3deb06e48.

[PATCH 06/11] tpm: Add a basic API implementation for TPMv2

2021-01-16 Thread Simon Glass
Add support for TPMv2 versions of API functions. So far this is not complete as the standard is quite large, but it implements everything currently available for TPMv2 in U-Boot. Signed-off-by: Simon Glass --- lib/tpm_api.c | 84 ++- 1 file change

[PATCH 04/11] tpm: Add an API that can support v1.2 and v2

2021-01-16 Thread Simon Glass
There are two different TPM standards. U-Boot supports both but each has its own set of functions. We really need a single TPM API that can call one or the other. This is not always possible as there are some differences between the two standards, but it is mostly possible. Add an API to handle th

[PATCH 03/11] tpm: Add debugging of request in tpm_sendrecv_command()

2021-01-16 Thread Simon Glass
The response is shown but not the request. Update the code to show both if debugging is enabled. Signed-off-by: Simon Glass --- lib/tpm-common.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/tpm-common.c b/lib/tpm-common.c index e4af87f76aa..0255d3bd9cf 100

[PATCH 02/11] tpm: Use logging in the uclass

2021-01-16 Thread Simon Glass
Update this to use log_debug() instead of the old debug(). Signed-off-by: Simon Glass --- drivers/tpm/tpm-uclass.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/tpm/tpm-uclass.c b/drivers/tpm/tpm-uclass.c index beb0fa3f93c..35774a6289e 100644 --- a/drivers/

[PATCH 01/11] tpm: Don't include cr50 in TPL/SPL

2021-01-16 Thread Simon Glass
At present the security chip is not used in these U-Boot phases. Update the Makefile to exclude it. Fix a few logging statements while we are here. Signed-off-by: Simon Glass --- drivers/tpm/Makefile | 2 +- drivers/tpm/cr50_i2c.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) d

[PATCH 00/11] tpm: Support using TPM1 and TPM2 from a single API

2021-01-16 Thread Simon Glass
At present if an application wants to be written so it can work with both TPMv1.2 and TPM2 it must use two different APIs. This is inconvenient since it requires adding code to deal with the mismatch between the two. It would be better to have a common API that all boards could share. This series

[PATCH] env/fat.c: support redund environment

2021-01-16 Thread Brandon Maier
Signed-off-by: Brandon Maier CC: Joe Hershberger CC: Wolfgang Denk --- env/Kconfig | 13 +++-- env/fat.c | 41 + 2 files changed, 44 insertions(+), 10 deletions(-) diff --git a/env/Kconfig b/env/Kconfig index 67ce93061b..a940ddce95 100644 --- a

[PATCH v8 4/4] mmc: renesas-sdhi: Add SDHI quirks for R-Car H3 and RZ/G2H

2021-01-16 Thread Biju Das
Add SDHI quirks for R-Car H3 and RZ/G2H SoC. Signed-off-by: Biju Das Reviewed-by: Lad Prabhakar Reviewed-by: Jaehoon chung --- v8: * Added Jaehoon chung's Rb tag. v7: * No Change. v6: * New patch. quirks using soc_device_match. --- drivers/mmc/renesas-sdhi.c | 33

[PATCH v8 3/4] mmc: renesas-sdhi: Add SDHI quirks for R-Car M3-N and RZ/G2N

2021-01-16 Thread Biju Das
Add SDHI quirks for R-Car M3-N and RZ/G2N SoC. Signed-off-by: Biju Das Reviewed-by: Lad Prabhakar Reviewed-by: Jaehoon chung --- v7->v8: * Added Jaehoon chung's Rb tag v6->v7: * No Change. rebased on u-boot-sh/next v6: * New patch --- drivers/mmc/renesas-sdhi.c | 14 +- 1 file

[PATCH v8 2/4] mmc: renesas-sdhi: Add SDHI quirks for R-Car M3-W and RZ/G2M

2021-01-16 Thread Biju Das
Add SDHI quirks for R-Car M3-W and RZ/G2M SoC. Signed-off-by: Biju Das Reviewed-by: Lad Prabhakar Reviewed-by: Jaehoon chung --- v8: * Added Jaehoon Chung's Rb tag v7: * Incorporated Jaehoon Chung's review comments. * Fixed the build error on Renesas ARM32 platforms. v6: * New patch. quirks

[PATCH v8 1/4] arm: rmobile: Add RZ/G2[HMNE] SoC support

2021-01-16 Thread Biju Das
RZ/G2 SoC's are identical to R-Car Gen3 SoC's apart from some automotive peripherals. RZ/G2H (R8A774E1) = R-Car H3-N (R8A77951). RZ/G2M (R8A774A1) = R-Car M3-W (R8A77960). RZ/G2N (R8A774B1) = R-Car M3-N (R8A77965). RZ/G2E (R8A774C0) = R-Car E3 (R8A77990). As the devices are the same they also hav

[PATCH v8 0/4] Add CPU identification support for RZ/G2 SoC's

2021-01-16 Thread Biju Das
This patch series aims to add CPU identification support for RZ/G2 SoC's and adding SDHI quirks using SoC identification driver. This patch series depend on SoC identification driver[1] [1] https://patchwork.ozlabs.org/project/uboot/list/?series=224764 v8: * Added Jaehoon Chung's Rb tag * Optim

Re: [PATCH] mtd: spi-nor-ids: add support for Micron mt25ql02g

2021-01-16 Thread Brandon Maier
On Sat, Jan 16, 2021 at 3:27 AM Bin Meng wrote: > > Hi Brandon, > > On Sat, Jan 16, 2021 at 5:54 AM Brandon Maier > wrote: > > > > From: Taylor Burton > > > > Micron's mt25ql02g is not currently supported in > > U-Boot, but is in Linux. Linux already has this flash > > present in its table. A sn

Re: [PATCH] spi: zynqmp_gqspi: support dual and quad mode

2021-01-16 Thread Brandon Maier
On Sat, Jan 16, 2021 at 5:06 AM Bin Meng wrote: > > Hi Brandon, > > On Sat, Jan 16, 2021 at 5:30 AM Brandon Maier > wrote: > > > > The dm_spi_ops.xfer() API does not support dual and quad SPI modes. It > > also doesn't allow the zynqmp_gqspi driver to calculate the correct > > number of dummy cyc

[PATCH v3 5/6] mmc: actions: add MMC driver for Actions OWL S700/S900

2021-01-16 Thread Amit Singh Tomar
From: Amit Singh Tomar This commit adds support for MMC controllers found on Actions OWL SoC platform(S700/S900). Signed-off-by: Amit Singh Tomar --- Changes since v2: * Progammed read/write delays as suggested by Jaehoon, its more readable now. * Updated commit messag

[PATCH v3 6/6] configs: Enable mmc support

2021-01-16 Thread Amit Singh Tomar
From: Amit Singh Tomar This commits enables mmc on the Actions Cubieboard7 board. Signed-off-by: Amit Singh Tomar --- Changes since previous versions * No change. --- configs/cubieboard7_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/cubieboard7_defconfig b/co

[PATCH v3 4/6] ARM: dts: s700: add MMC/SD controller node

2021-01-16 Thread Amit Singh Tomar
From: Amit Singh Tomar This patch adds node for mmc/sd controller found on Action Semi OWL S700 SoC. Since, upstream Linux binding has not been merged for S700 MMC/SD controller, Changes are put in u-boot specific dtsi file. Signed-off-by: Amit Singh Tomar --- Changes since previous versions

[PATCH v3 3/6] ARM: dts: sync Actions Semi S700 DT from Linux 5.10-rc7

2021-01-16 Thread Amit Singh Tomar
From: Amit Singh Tomar This Synchronizes the Actions Semi S700 SoC DT changes from commit "0477e9288185" ("Linux 5.10-rc7"). Signed-off-by: Amit Singh Tomar --- Changes since previous versions * No change. --- arch/arm/dts/s700.dtsi | 17 - inclu

[PATCH v3 2/6] clk: actions: Add SD/MMC clocks

2021-01-16 Thread Amit Singh Tomar
From: Amit Singh Tomar This commit adds SD/MMC clocks, and provides .set/get_rate callbacks for SD/MMC device present on Actions OWL S700 SoCs. Signed-off-by: Amit Singh Tomar --- Changes since v2: * Fixed the not weird div assignment. * Moved the clock bit for SD from header fi

[PATCH v3 1/6] clk: actions: Introduce dummy get/set_rate callbacks

2021-01-16 Thread Amit Singh Tomar
From: Amit Singh Tomar This commit introduces get/set_rate callbacks, these are dummy at the moment, and can be used to get/set clock for various devices based on the clk id. Signed-off-by: Amit Singh Tomar --- Changes since v2: * No changes. Changes since previous version: * Re

[PATCH v3 0/6] Add MMC/SD support for S700/S900

2021-01-16 Thread Amit Singh Tomar
From: Amit Singh Tomar This series(v3) addresses review comments provided by Andre and Jaehoon. Earlier in MMC driver, we were *not* checking the command response errors(for instance, the CRC error) based on STATU register. This is now addressed in patch 5/6. Also, MMC driver(pacth 5/6) now has

Pull request for documentation tag doc-2021-04-rc1

2021-01-16 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit b0db69b4e1e1bf1109bd9d4a5185cbd4058f4a8b: dm: fix build errors generated by last merges (2021-01-15 13:12:38 -0500) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git tags/doc-2021-04-rc1 for you to

Pull request for documentation tag doc-2021-04-rc1

2021-01-16 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit b0db69b4e1e1bf1109bd9d4a5185cbd4058f4a8b: dm: fix build errors generated by last merges (2021-01-15 13:12:38 -0500) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git tags/doc-2021-04-rc1 for you to

Re: [PATCH 1/3] test: cmd_ut_category: raise a error when the test is not found

2021-01-16 Thread Tom Rini
On Thu, Nov 19, 2020 at 10:08:41AM +0100, Patrick Delaunay wrote: > Raise an error when test is not found, for example with manual test > with bad test name, as following, doesn't raise an error > > => ut lib bad > Failures: 0 > > After the patch: > > => ut lib bad > lib test bad not found > Fa

[PATCH v5 3/3] dm: soc: SoC identification driver for Renesas SoC's

2021-01-16 Thread Biju Das
Add SoC identification driver for Renesas SoC's. This allows to identify the SoC type and revision based on Product Register. This can be checked where needed using soc_device_match(). Signed-off-by: Biju Das Reviewed-by: Lad Prabhakar --- This patch depend on [1] [1] http://u-boot.10912.n7.n

[PATCH v5 2/3] dm: soc: Add SoC id for attribute matching

2021-01-16 Thread Biju Das
Mainline kernel uses the "soc_id" attribute to identify the SoC for some of the h/w platforms. On such platforms adding this attribute in u-boot will make SoC identification similar to the mainline kernel, so that it can be easily maintained. Add a new attribute named "soc_id" to SOC uclass, in or

[PATCH v5 1/3] soc: Fix comments from SOC to SoC

2021-01-16 Thread Biju Das
Fix the comments from "an SOC" to "an SoC". Signed-off-by: Biju Das Reviewed-by: Lad Prabhakar Reviewed-by: Simon Glass --- v4->v5: No Change. v3->v4: No Change * Added Simon's Rb tag. v3: * New patch (Ref: https://patchwork.ozlabs.org/project/uboot/patch/20201102150959.4793-3-biju.das

[PATCH v5 0/3] Add Renesas SoC identification driver support

2021-01-16 Thread Biju Das
This patch series aims to support Renesas SoC identification driver. Also added soc_id attribute support in UCLASS_SOC which is required for Renesas SoC identification driver similar to mainline linux. Patch 3 in this series depend on [1] [1] http://u-boot.10912.n7.nabble.com/PATCH-v5-dm-core-A

Re: [PATCH v3 6/6] cmd: Add MBR partition layout control utility

2021-01-16 Thread Tom Rini
On Wed, Dec 23, 2020 at 01:55:15PM +0100, Marek Szyprowski wrote: > Add a 'mbr' command to let users create or verify MBR partition layout > based on the provided text description. The partition layout is > alternatively read from the 'mbr_parts' environment variable. This can be > used in scripts

Re: [PATCH v3 5/6] disk: dos: add code for creating MBR partition layout

2021-01-16 Thread Tom Rini
On Wed, Dec 23, 2020 at 01:55:14PM +0100, Marek Szyprowski wrote: > Add a code for creating and writing MBR partition layout. The code generates > similar layout of EBRs (Exteneded Block Records) and logical volumes as > Linux's fdisk utility. > > Signed-off-by: Marek Szyprowski Applied to u-bo

Re: [PATCH v3 4/6] disk: dos: make some functions static

2021-01-16 Thread Tom Rini
On Wed, Dec 23, 2020 at 01:55:13PM +0100, Marek Szyprowski wrote: > Make functions not used outside this file static. > > Signed-off-by: Marek Szyprowski Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 3/6] disk: dos: use generic macro for unaligned le32 access

2021-01-16 Thread Tom Rini
On Wed, Dec 23, 2020 at 01:55:12PM +0100, Marek Szyprowski wrote: > Use a generic helper for reading LE32 integers. > > Signed-off-by: Marek Szyprowski Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 2/6] disk: dos: add some defines for the hardcoded numbers

2021-01-16 Thread Tom Rini
On Wed, Dec 23, 2020 at 01:55:11PM +0100, Marek Szyprowski wrote: > Add some handy defines for some hardcoded magic numbers related to > extended partition handling. > > Signed-off-by: Marek Szyprowski Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 1/6] disk: dos: rename write_mbr_partition to write_mbr_sector

2021-01-16 Thread Tom Rini
On Wed, Dec 23, 2020 at 01:55:10PM +0100, Marek Szyprowski wrote: > write_mbr_partition() function name is a bit misleading, so rename it to > write_mbr_sector(). This is a preparation for adding code for writing a > complete MBR partition layout. > > Signed-off-by: Marek Szyprowski Applied to

Re: [PATCH v3 9/9] IOMUX: Stop dropped consoles

2021-01-16 Thread Tom Rini
On Mon, Dec 21, 2020 at 02:30:08PM +0200, Andy Shevchenko wrote: > When at some point environment shrinks we need to stop dropped devices. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 8/9] IOMUX: Drop indentation level by removing redundant 'else'

2021-01-16 Thread Tom Rini
On Mon, Dec 21, 2020 at 02:30:07PM +0200, Andy Shevchenko wrote: > Obviously the following has unnecessary indentation level in 'else' branch. > > if (foo) { > ... > return; > } else { > ... > } > > Drop indentation level by removing re

Re: [PATCH v3 7/9] IOMUX: Refactor iomux_doenv() in order to increase readability

2021-01-16 Thread Tom Rini
On Mon, Dec 21, 2020 at 02:30:06PM +0200, Andy Shevchenko wrote: > Refactor iomux_doenv() a bit in order to increase readability. > There is no change in code generation on x86. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature

Re: [PATCH v3 6/9] IOMUX: Preserve console list if realloc() fails

2021-01-16 Thread Tom Rini
On Mon, Dec 21, 2020 at 02:30:05PM +0200, Andy Shevchenko wrote: > It's realloc() 101 to avoid `foo = realloc(foo, ...);` call > due to getting a memory leak. > > Actually it's not clear why realloc() has been used here. > If we shrink the array, the memcpy() overwrites it anyway > with the conte

Re: [PATCH v3 5/9] console: Provide a documentation for console_search_dev()

2021-01-16 Thread Tom Rini
On Mon, Dec 21, 2020 at 02:30:04PM +0200, Andy Shevchenko wrote: > Provide a documentation for console_search_dev(). > > Suggested-by: Simon Glass > Signed-off-by: Andy Shevchenko Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 4/9] console: rename search_device() to console_search_dev()

2021-01-16 Thread Tom Rini
On Mon, Dec 21, 2020 at 02:30:03PM +0200, Andy Shevchenko wrote: > Rename search_device() to console_search_dev() since it's in console.h. > > Suggested-by: Simon Glass > Signed-off-by: Andy Shevchenko > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Descr

Re: [PATCH v3 3/9] console: move search_device() from iomux.h to console.h

2021-01-16 Thread Tom Rini
On Mon, Dec 21, 2020 at 02:30:02PM +0200, Andy Shevchenko wrote: > search_device() is defined in console.c. Move its declaration > to an appropriate header file. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description

Re: [PATCH v3 2/9] console: Keep ->start() and ->stop() balanced

2021-01-16 Thread Tom Rini
On Mon, Dec 21, 2020 at 02:30:01PM +0200, Andy Shevchenko wrote: > There is no need to call ->start() for already started device. All the same, > there is no need to call ->stop() for devices still in use. > > For now enforce this only for IOMUX case. > > Cc: Simon Glass > Signed-off-by: Andy S

Re: [PATCH v3 1/9] console: Introduce console_start() and console_stop()

2021-01-16 Thread Tom Rini
On Mon, Dec 21, 2020 at 02:30:00PM +0200, Andy Shevchenko wrote: > In the future we would like to stop unused consoles and > also add a reference counting to avoid imbalanced calls > to ->start() and ->stop() in some cases. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Simon Glass Applied

Re: [PATCH v3 4/4] console: add console_has_tstc helper function for CONSOLE_MUX

2021-01-16 Thread Tom Rini
On Fri, Dec 18, 2020 at 12:46:46PM +0100, Patrick Delaunay wrote: > From: Patrick Delaunay > > Add the helper function console_has_tstc() and replace the test > #if CONFIG_IS_ENABLED(CONSOLE_MUX) to a simple 'if' test to > respect the U-Boot coding rule. > > No functional change. > > Signed-of

Re: [PATCH v3 3/4] console: remove #ifdef CONFIG_CONSOLE_RECORD

2021-01-16 Thread Tom Rini
On Fri, Dec 18, 2020 at 12:46:45PM +0100, Patrick Delaunay wrote: > From: Patrick Delaunay > > Add helper functions to access to gd->console_out and gd->console_in > with membuff API and replace the #ifdef CONFIG_CONSOLE_RECORD test > by if (IS_ENABLED(CONFIG_CONSOLE_RECORD)) to respect the U-Bo

Re: [PATCH v3 2/4] console: add function console_devices_set

2021-01-16 Thread Tom Rini
On Fri, Dec 18, 2020 at 12:46:44PM +0100, Patrick Delaunay wrote: > From: Patrick Delaunay > > Add a new function to access to console_devices only defined if > CONFIG_IS_ENABLED(CONSOLE_MUX). > > This path allows to remove #if CONFIG_IS_ENABLED(CONSOLE_MUX) > in console_getc function. > > Sig

Re: [PATCH v3 1/4] console: remove #ifdef CONFIG when it is possible

2021-01-16 Thread Tom Rini
On Fri, Dec 18, 2020 at 12:46:43PM +0100, Patrick Delaunay wrote: > From: Patrick Delaunay > > Remove #ifdef or #ifndef for CONFIG when it is possible to simplify > the console.c code and respect the U-Boot coding rules. > > Signed-off-by: Patrick Delaunay > Signed-off-by: Patrick Delaunay >

  1   2   >