Re: [PATCH v2 00/21] sunxi: Introduce H616 support

2021-01-23 Thread Andre Przywara
On Mon, 11 Jan 2021 21:11:32 +0100 Jernej Skrabec wrote: Hi, Jernej: many thanks for your work on this and your persistence! Jaehoon, Samuel: thanks for the diligent review, that's much appreciated and very helpful! > This series introduces H616 support. Later patches add also OrangePi > Zero2

Re: [PATCH v2 21/21] sunxi: Add support for OrangePi Zero2

2021-01-23 Thread Andre Przywara
On Mon, 11 Jan 2021 21:11:53 +0100 Jernej Skrabec wrote: > OrangePi Zero2 is SBC based on Allwinner H616 with 1 GiB of RAM, SD card > support, gigabit ethernet, micro HDMI, WIFI, Bluetooth and 1 USB 2.0 > port. It also has two GPIO headers which allows further peripherals to > be used. > > Devic

Re: [PATCH v2 20/21] clk: sunxi: Add support for H616 clocks

2021-01-23 Thread Andre Przywara
On Mon, 11 Jan 2021 21:11:52 +0100 Jernej Skrabec wrote: > This commit introduces DM H616 clock driver. > > Reviewed-by: Andre Przywara > Signed-off-by: Jernej Skrabec > --- > drivers/clk/sunxi/Kconfig| 7 ++ > drivers/clk/sunxi/Makefile | 1 + > drivers/clk/sunxi/clk_h616.c | 120 +

Re: [PATCH v2 18/21] arm: sunxi: add initial H616 DTSI and headers

2021-01-23 Thread Andre Przywara
On Mon, 11 Jan 2021 21:11:50 +0100 Jernej Skrabec wrote: Hi, > This commit introduces H616 DTSI file and dt-bindings headers needed for > device tree files. > > Files are taken from initial Linux H616 support submission with minor > change - emac0 fallback has H6 compatible instead of A64, othe

Re: [PATCH 04/11] pinctrl: single: get register area size by device API

2021-01-23 Thread Simon Glass
Hi Dario, On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > Use dev_read_addr_size to get size of the controller's register area. > > Signed-off-by: Dario Binacchi > --- > > drivers/pinctrl/pinctrl-single.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/

Re: [RFC PATCH] arm: EFI: Disallow EFI bootmgr when providing PSCI

2021-01-23 Thread Simon Glass
On Fri, 22 Jan 2021 at 05:05, Andre Przywara wrote: > > When "bootefi bootmgr" is run, it switches the CPU into non-secure > state. This breaks platforms like 32-bit Allwinner boards that rely on > running in secure state until late in the process, when they install > the PSCI handler in secure me

Re: [PATCH] cmd: misc: Fix return value for the sleep command

2021-01-23 Thread Simon Glass
On Fri, 22 Jan 2021 at 04:27, Marek Szyprowski wrote: > > If sleeping has been interrupted, return CMD_RET_FAILURE instead of -1 > (CMD_RET_USAGE). > > Signed-off-by: Marek Szyprowski > --- > cmd/sleep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH v3 01/20] mmc: sdhci: Add helper functions for UHS modes

2021-01-23 Thread Simon Glass
Hi Aswath, On Thu, 21 Jan 2021 at 05:41, Aswath Govindraju wrote: > > From: Faiz Abbas > > Add a set_voltage() function which handles the switch from 3.3V to 1.8V > for SD card UHS modes. > > Signed-off-by: Faiz Abbas > Signed-off-by: Aswath Govindraju > --- > drivers/mmc/sdhci.c | 80 +++

Re: [PATCH 02/11] pinctrl: single: fix the loop counter variable type

2021-01-23 Thread Simon Glass
On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > The patch changes the variable 'n' type from phys_addr_t to int. s/The patch changes/Change/ > > Signed-off-by: Dario Binacchi > --- > > drivers/pinctrl/pinctrl-single.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > >

Re: [PATCH] test: unit test for echo command

2021-01-23 Thread Simon Glass
On Thu, 21 Jan 2021 at 10:48, Heinrich Schuchardt wrote: > > Provide a unit test for the unit command > > Signed-off-by: Heinrich Schuchardt > --- > test/cmd/Makefile| 3 +++ > test/cmd/test_echo.c | 57 > 2 files changed, 60 insertions(+) > cre

Re: [PATCH 2/7] global_data.h: Change ram_top type to phys_addr_t

2021-01-23 Thread Simon Glass
On Thu, 21 Jan 2021 at 08:00, Bin Meng wrote: > > From: Bin Meng > > It's possible to have ram_top above 4 GiB in a 32-bit system, hence > we need to declare ram_top as `phys_addr_t`. > > Signed-off-by: Bin Meng > --- > > include/asm-generic/global_data.h | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH] lib: rsa: rsa-verify: don't look for keys in the FIT image

2021-01-23 Thread Simon Glass
Hi , On Tue, 12 Jan 2021 at 11:19, Philippe Reynes wrote: > > In the function rsa_verify_hash, if the "main" key doesn't > work, u-boot try others keys. But it searches those keys > in the FIT image instead of the u-boot device tree. > > Signed-off-by: Philippe Reynes > --- > lib/rsa/rsa-verify

Re: [PATCH 1/1] doc: document echo command

2021-01-23 Thread Simon Glass
On Thu, 21 Jan 2021 at 10:55, Heinrich Schuchardt wrote: > > Provide a man-page for the echo command. > > Signed-off-by: Heinrich Schuchardt > --- > doc/usage/echo.rst | 65 + > doc/usage/index.rst | 1 + > 2 files changed, 66 insertions(+) > create

Re: [PATCH 11/11] test: pinmux: add test for 'pinctrl-single' driver

2021-01-23 Thread Simon Glass
On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > The test adds two pinmux nodes to the device tree, one to test when a > register changes only one pin's mux (pinctrl-single,pins), and the other > to test when more than one pin's mux is changed (pinctrl-single,bits). > This required replacin

Re: [PATCH 05/11] pinctrl: single: check "register-width" DT property

2021-01-23 Thread Simon Glass
Hi Dario, On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > In more recent versions of the Linux kernel the driver's probe function > returns an error if the "pinctrl-single,register-width" DT property is > missing. The lack of this information, in fact, does not allow to know > whether to

Re: [PATCH 10/11] pinctrl: single: add get_pin_muxing operation

2021-01-23 Thread Simon Glass
Hi Dario, On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > It allows to display the muxing of a given pin. Inspired by more recent > versions of the Linux driver, in addition to the address and the value > of the configuration register I added the pin function retrieved from > the DT. In d

Re: [PATCH 08/11] pinctrl: single: add get_pins_count operation

2021-01-23 Thread Simon Glass
On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > It returns the number of selectable pins. > > Signed-off-by: Dario Binacchi > --- > > drivers/pinctrl/pinctrl-single.c | 22 ++ > 1 file changed, 22 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH 09/11] pinctrl: single: add get_pin_name operation

2021-01-23 Thread Simon Glass
On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > It returns the name of the requested pin. > > Signed-off-by: Dario Binacchi > --- > > drivers/pinctrl/pinctrl-single.c | 16 > 1 file changed, 16 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH 07/11] pinctrl: single: use function pointer for register access

2021-01-23 Thread Simon Glass
Hi Dario, On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > The patch allows you to call the read/write functions set during probing > without having to check the type of access at runtime. It also adds > functions for 8-bit registers access. > > Signed-off-by: Dario Binacchi > --- > > dr

Re: [PATCH 01/11] pinctrl: single: fix format of structure documentation

2021-01-23 Thread Simon Glass
On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > U-Boot adopted the kernel-doc annotation style. > > Signed-off-by: Dario Binacchi > --- > > drivers/pinctrl/pinctrl-single.c | 45 +--- > 1 file changed, 36 insertions(+), 9 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 03/11] pinctrl: single: fix debug messages formatting

2021-01-23 Thread Simon Glass
Hi Dario, On Sat, 23 Jan 2021 at 11:27, Dario Binacchi wrote: > > The printf '%pa' format specifier appends the '0x' prefix to the > displayed address. Furthermore, the offset variable is displayed with > the '%x' format specifier instead of '%pa'. Please start your commit message with the probl

Re: [PATCH 1/1] doc: describe loady command

2021-01-23 Thread Simon Glass
On Fri, 22 Jan 2021 at 11:20, Heinrich Schuchardt wrote: > > Create a man-page for the loady command. > > Signed-off-by: Heinrich Schuchardt > --- > doc/usage/index.rst | 1 + > doc/usage/loady.rst | 67 + > 2 files changed, 68 insertions(+) > create

Re: [PATCH 4/7] fdtdec: Cast prior_stage_fdt_address with uintptr_t

2021-01-23 Thread Simon Glass
On Thu, 21 Jan 2021 at 08:01, Bin Meng wrote: > > From: Bin Meng > > At present prior_stage_fdt_address is declared as phys_addr_t. On > a 32-bit platform where phys_addr_t can be 64-bit, assigning its > value to gd->fdt_blob which is a pointer, can cause warnings. > > Cast it to uintptr_t before

Re: [PATCH] dm: replace auto_alloc_size with auto

2021-01-23 Thread Simon Glass
On Sat, 23 Jan 2021 at 11:49, Dario Binacchi wrote: > > The auto_alloc_size members of struct driver has been renamed auto. > > Signed-off-by: Dario Binacchi > --- > > include/dm/device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass

Re: [PATCH 2/2] console: Don't start/stop console if stdio device invalid

2021-01-23 Thread Simon Glass
On Wed, 20 Jan 2021 at 07:05, Nicolas Saenz Julienne wrote: > > Don't start/stop an stdio device that might have been already freed. > > Signed-off-by: Nicolas Saenz Julienne > Fixes: 70c2525c0d3c ("IOMUX: Stop dropped consoles") > --- > common/console.c | 3 +++ > 1 file changed, 3 insertions(+

Re: [PATCH 1/2] stdio: Introduce stdio_valid()

2021-01-23 Thread Simon Glass
Hi Nicolas, On Wed, 20 Jan 2021 at 07:05, Nicolas Saenz Julienne wrote: > > stdio_valid() will confirm that a struct stdio_dev pointer is indeed > valid. > > Signed-off-by: Nicolas Saenz Julienne > --- > common/stdio.c | 11 +++ > include/stdio_dev.h | 1 + > 2 files changed, 12 i

Booting on PX30

2021-01-23 Thread Piotr Lobacz
Hi all, In our company we have a board which was made for us by Liteon with PX30 chip on it. It boots with miniloader and uboot.img along with trust.img. The problem is that i wanted to boot it up using TPL/SPL images and it doesn't boot. With uboot source code which was given to us it prints for m

Re: Sync include/linux/*.h from kernel

2021-01-23 Thread Tom Rini
On Fri, Jan 22, 2021 at 09:22:14AM +, Peng Fan (OSS) wrote: > All, > > Do we need to sync the header files under > include/linux/*.h from Linux Kernel? > > Seems many files are out of date and Linux > Kernel changed a lot, such as linkage.h. Yes, we need to sync various files more often. I

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-23 Thread Stefano Babic
Hi Marek, On 23.01.21 20:57, Marek Vasut wrote: On 1/23/21 8:54 PM, sba...@denx.de wrote: The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC interna

Re: [PATCH 3/4] usb: musb: Fix handling interrupts for EP0 and SET ADDRESS commmand

2021-01-23 Thread Pali Rohár
On Saturday 23 January 2021 22:23:10 Lukasz Majewski wrote: > Hi Pali, > > > On Saturday 23 January 2021 16:16:11 Lukasz Majewski wrote: > > > Hi Pali, > > > > > > > Interrupt for EP0 is indicated in intrtx register via first bit. > > > > It is set for both RX and TX. First bit in intrrx regist

Re: [PATCH 3/4] usb: musb: Fix handling interrupts for EP0 and SET ADDRESS commmand

2021-01-23 Thread Lukasz Majewski
Hi Pali, > On Saturday 23 January 2021 16:16:11 Lukasz Majewski wrote: > > Hi Pali, > > > > > Interrupt for EP0 is indicated in intrtx register via first bit. > > > It is set for both RX and TX. First bit in intrrx register is > > > reserved and not set. > > > > > > So remove calling musb_peri

[U-Boot] Question: PCIe enumeration of PEX switch

2021-01-23 Thread Ramakrishna Maladi (rmaladi)
Hi U-boot is unable to enumerate pericom PCIe switch and subsequent end point devices on our board (arm v8.2, 64-bit) When booted to linux, we see the same enumerated with endpoints Have any one come ever come across this issue and found a workaround to it? I hope we no need to have a spec

Re: [PATCH] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

2021-01-23 Thread Marek Vasut
On 1/23/21 8:54 PM, sba...@denx.de wrote: The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC internal delay based on the PHY mode. [...] Applied t

[GIT] Pull request: u-boot-dfu (23.01.2021)

2021-01-23 Thread Lukasz Majewski
Dear Marek, Please find a set of DFU/Gadget related fixes and improvements. This is a first batch of them as I was not able to prepare the PR earlier (and yes I do apologize for the delay/lack of PRs sent earlier). More patches will be pulled in following PRs. This set is not causing any CI issue

[PATCH] dm: replace auto_alloc_size with auto

2021-01-23 Thread Dario Binacchi
The auto_alloc_size members of struct driver has been renamed auto. Signed-off-by: Dario Binacchi --- include/dm/device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/dm/device.h b/include/dm/device.h index f5b4cd6876..e665558444 100644 --- a/include/dm/device.h +

[PATCH] Replace video_uc_platdata with video_uc_plat

2021-01-23 Thread Dario Binacchi
The video_uc_platdata structure no longer exists. It has been renamed video_uc_plat. Signed-off-by: Dario Binacchi --- drivers/video/Kconfig | 4 ++-- drivers/video/nexell_display.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/Kconfig b/drivers/v

[PATCH 1/1] efi_loader: correct block IO alignment check

2021-01-23 Thread Heinrich Schuchardt
If the field Media->IoAlign of the EFI block IO protocol is zero, no alignment is required. Our code required 4 GiB alignment in this case. Don't check buffer alignment if Media->IoAlign == 0. Fixes: f59f0825e8b9 ("efi_loader: parameter checks BLOCK_IO_PROTOCOL") Signed-off-by: Heinrich Schuchard

[PATCH 11/11] test: pinmux: add test for 'pinctrl-single' driver

2021-01-23 Thread Dario Binacchi
The test adds two pinmux nodes to the device tree, one to test when a register changes only one pin's mux (pinctrl-single,pins), and the other to test when more than one pin's mux is changed (pinctrl-single,bits). This required replacing the controller's register access functions when the driver is

[PATCH 10/11] pinctrl: single: add get_pin_muxing operation

2021-01-23 Thread Dario Binacchi
It allows to display the muxing of a given pin. Inspired by more recent versions of the Linux driver, in addition to the address and the value of the configuration register I added the pin function retrieved from the DT. In doing so, the information displayed does not depend on the platform, being

[PATCH 08/11] pinctrl: single: add get_pins_count operation

2021-01-23 Thread Dario Binacchi
It returns the number of selectable pins. Signed-off-by: Dario Binacchi --- drivers/pinctrl/pinctrl-single.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index eb69e53096..21a3bbaaa7 100644 --- a/

[PATCH 09/11] pinctrl: single: add get_pin_name operation

2021-01-23 Thread Dario Binacchi
It returns the name of the requested pin. Signed-off-by: Dario Binacchi --- drivers/pinctrl/pinctrl-single.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index 21a3bbaaa7..04e2b00f7e 100644 --- a/driver

[PATCH 07/11] pinctrl: single: use function pointer for register access

2021-01-23 Thread Dario Binacchi
The patch allows you to call the read/write functions set during probing without having to check the type of access at runtime. It also adds functions for 8-bit registers access. Signed-off-by: Dario Binacchi --- drivers/pinctrl/pinctrl-single.c | 98 1 file cha

[PATCH 05/11] pinctrl: single: check "register-width" DT property

2021-01-23 Thread Dario Binacchi
In more recent versions of the Linux kernel the driver's probe function returns an error if the "pinctrl-single,register-width" DT property is missing. The lack of this information, in fact, does not allow to know whether to access the registers of the controller at 8, 16 or 32 bits. Signed-off-by

[PATCH 06/11] pinctrl: single: change function mask default value

2021-01-23 Thread Dario Binacchi
The patch is inspired by more recent versions of the Linux driver. Replacing the default value 0x of the function mask with 0 is certainly more conservative in case the "pinctrl-single,function-mask" DT property is missing. Signed-off-by: Dario Binacchi --- drivers/pinctrl/pinctrl-singl

[PATCH 04/11] pinctrl: single: get register area size by device API

2021-01-23 Thread Dario Binacchi
Use dev_read_addr_size to get size of the controller's register area. Signed-off-by: Dario Binacchi --- drivers/pinctrl/pinctrl-single.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index cec00e2

[PATCH 03/11] pinctrl: single: fix debug messages formatting

2021-01-23 Thread Dario Binacchi
The printf '%pa' format specifier appends the '0x' prefix to the displayed address. Furthermore, the offset variable is displayed with the '%x' format specifier instead of '%pa'. Signed-off-by: Dario Binacchi --- drivers/pinctrl/pinctrl-single.c | 28 1 file changed

[PATCH 02/11] pinctrl: single: fix the loop counter variable type

2021-01-23 Thread Dario Binacchi
The patch changes the variable 'n' type from phys_addr_t to int. Signed-off-by: Dario Binacchi --- drivers/pinctrl/pinctrl-single.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index c9a6c272bf..4

[PATCH 01/11] pinctrl: single: fix format of structure documentation

2021-01-23 Thread Dario Binacchi
U-Boot adopted the kernel-doc annotation style. Signed-off-by: Dario Binacchi --- drivers/pinctrl/pinctrl-single.c | 45 +--- 1 file changed, 36 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index 20c3

[PATCH 00/11] Add support for pinmux status command on beaglebone

2021-01-23 Thread Dario Binacchi
The series was born from the need to check the pinmux setting of a peripheral on a beaglebone board. I then ran the 'pinmux status -a' command but it failed because some operations (get_pin_muxing, get_pin_name and get_pins_count) were missing in the 'pinctrl-single' driver. The patch series can

[PATCH 1/1] efi_selftest: test EFI_BLOCK_IO_PROTOCOL.Media->LastBlock

2021-01-23 Thread Heinrich Schuchardt
The field Media->LastBlock of the EFI_BLOCK_IO_PROTOCOL must be filled with the index of the last logical block (LBA) for the block device that our test driver provides. After calling ConnectController() U-Boot exposes the block IO protocol for the partition check that the value of Media->LastBloc

Re: [PATCH v4 58/59] acpi: Add more documentation for struct acpi_gpio

2021-01-23 Thread Simon Glass
Hi Andy, On Thu, 29 Oct 2020 at 06:22, Andy Shevchenko wrote: > > On Tue, Sep 22, 2020 at 12:45:43PM -0600, Simon Glass wrote: > > Add some documentation provided by Andy Shevchenko to describe how to > > use struct acpi_gpio. > > Thanks! > > I see Bin already applied this, perhaps follow up fix

[PATCH] acpi: Tidy up documentation for struct acpi_gpio

2021-01-23 Thread Simon Glass
Some comments were provided after this patch was applied. Address them. Signed-off-by: Simon Glass --- include/acpi/acpi_device.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/acpi/acpi_device.h b/include/acpi/acpi_device.h index ed4acd912a1..2c8846250b6 1

Re: [PATCH 1/1] doc: update Kernel documentation build system

2021-01-23 Thread Tom Rini
On Sat, Jan 23, 2021 at 12:46:23PM -0500, Tom Rini wrote: > On Fri, Jan 01, 2021 at 01:21:11AM +0100, Heinrich Schuchardt wrote: > > > Update the docomentation build system according to Linux v5.11-rc1. > > > > With this patch we can build the HTML documentation using either of > > Sphinx 2 and S

Re: [PATCH 1/1] doc: move README.menu to HTML documentation

2021-01-23 Thread Tom Rini
On Mon, Jan 18, 2021 at 09:06:03PM +0100, Heinrich Schuchardt wrote: > Convert README.menu to reStructured text and add it to the HTML > documentation. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/3] doc: move test/py/README.md to HTML documentation

2021-01-23 Thread Tom Rini
On Mon, Jan 18, 2021 at 08:24:03PM +0100, Heinrich Schuchardt wrote: > Convert test/py/README.md to restructured text and add it to the generated > HTML documentation. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc D

Re: [PATCH 2/3] doc: move test/README to HTML documentation

2021-01-23 Thread Tom Rini
On Mon, Jan 18, 2021 at 08:24:02PM +0100, Heinrich Schuchardt wrote: > Move test/README to the 'Develop U-Boot' chapter of the HTML documentation. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signa

Re: [PATCH 1/3] doc: structure doc/develop/index.rst

2021-01-23 Thread Tom Rini
On Mon, Jan 18, 2021 at 08:24:01PM +0100, Heinrich Schuchardt wrote: > Provide sub-chapters for 'Develop U-Boot' > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] doc: update help message

2021-01-23 Thread Tom Rini
On Thu, Jan 14, 2021 at 12:04:04PM +0100, Patrick Delaunay wrote: > Update the help message used for 'make help': > > Documentation targets: > Linux kernel internal documentation in different formats from ReST: > => > U-Boot documentation in different formats from ReST: > > Signed-off-

Re: [PATCH 1/1] doc: update Kernel documentation build system

2021-01-23 Thread Tom Rini
On Fri, Jan 01, 2021 at 01:21:11AM +0100, Heinrich Schuchardt wrote: > Update the docomentation build system according to Linux v5.11-rc1. > > With this patch we can build the HTML documentation using either of > Sphinx 2 and Sphinx 3. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon

Re: [PATCH] doc: FIT image: Clarify format and simplify syntax

2021-01-23 Thread Tom Rini
On Tue, Dec 15, 2020 at 01:15:43PM -0600, Alexandru Gagniuc wrote: > ** Introduction > > There are currently four ways to load an OS image with u-boot > 1. SPL -> u-boot -> bootm > 2. SPL blue falcon mode > 3. "Basic" FIT image (CONFIG_LOAD_FIT) > 4. "Full-featured" FIT image (CONFIG_LOAD

Re: [PATCH v2 3/4] mkimage: Move padding commands outside of FIT_SIGNATURE

2021-01-23 Thread Tom Rini
On Tue, Dec 08, 2020 at 02:42:15PM +1030, Joel Stanley wrote: > These commands were disabled when CONFIG_FIT_SIGNATURE is disabled, but > they do not depend on crypto support so they can be unconditionally > enabled. > > Signed-off-by: Joel Stanley Applied to u-boot/master, thanks! -- Tom s

Re: [PATCH v2 2/4] image-fit: Fix FIT_CIPHER linking

2021-01-23 Thread Tom Rini
On Tue, Dec 08, 2020 at 02:42:14PM +1030, Joel Stanley wrote: > When CONFIG_FIT_CIPHER=y and CONFIG_FIT_SIGNATURE=n is there is no > implementation of image_get_host_blob for mkimage/dumpimage: > > /usr/bin/ld: tools/common/image-cipher.o: in function > `fit_image_decrypt_data': > image-cipher

Re: [PATCH v2 1/4] tools/Makefile: FIT_CIPHER requires libssl

2021-01-23 Thread Tom Rini
On Tue, Dec 08, 2020 at 02:42:13PM +1030, Joel Stanley wrote: > If CONFIG_FIT_CIPHER is enabled without CONFIG_FIT_SIGNATURE then > mkimage/dumpimage will fail to link: > > /usr/bin/ld: tools/common/image-cipher.o: in function > `fit_image_decrypt_data': > image-cipher.c:(.text+0x9a): undefine

Re: [PATCH] tools: env: return error if ubi_update_start() fails

2021-01-23 Thread Tom Rini
On Mon, Nov 30, 2020 at 12:11:32PM +0100, Martin Hundebøll wrote: > The UBI_IOCVOLUP ioctl can fail if exclusive access to the volume isn't > obtained. If this happens, the flush operation doesn't return error, > leaving the caller without knowledge of missing flush. > > Fix this by forwarding th

Re: [PATCH 2/2] tools: image-host: add support for several sub-images

2021-01-23 Thread Tom Rini
On Tue, Nov 24, 2020 at 02:39:48PM +0100, Philippe Reynes wrote: > The propoerty sign-images points to images in the configuration > node. But thoses images may references severals "sub-images" (for > example for images loadable). This commit adds the support of > severals sub-images. > > Signed-

Re: [PATCH 1/2] tools: image-host: clean function fit_config_get_hash_list

2021-01-23 Thread Tom Rini
On Tue, Nov 24, 2020 at 02:39:47PM +0100, Philippe Reynes wrote: > This commit creates a function fit_config_add_hash that will be > used in the next commit to support several 'sub-images'. > > Signed-off-by: Philippe Reynes > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom

Re: please pull u-boot-samsung master

2021-01-23 Thread Tom Rini
On Fri, Jan 22, 2021 at 04:45:30PM +0900, Minkyu Kang wrote: > Dear Tom, > > The following changes since commit ee6726be4f0dccb612f0193c62ca149164c8a5af: > > Merge tag 'ti-v2021.04-rc1' of > https://gitlab.denx.de/u-boot/custodians/u-boot-ti (2021-01-12 09:32:48 > -0500) > > are available in

[PATCH v2 8/8] bootm: Fix duplicate debugging in bootm_process_cmdline()

2021-01-23 Thread Simon Glass
These two returns use the same string so are not distinguishable with LOG_ERROR_RETURN. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) common/bootm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/bootm.c b/common/bootm.c index 8298693900d..48a5b04cd7a

[PATCH v2 7/8] sandbox: Write out bloblist when existing

2021-01-23 Thread Simon Glass
Sandbox provides a way to write out its emulated memory on exit. This makes it possible to pass a bloblist from one phase (e.g. SPL) to the next. However the bloblist is not closed off, so the checksum is generally invalid. Fix this by finishing up the bloblist before writing the memory file. Sig

[PATCH v2 6/8] sandbox: Avoid using malloc() for system state

2021-01-23 Thread Simon Glass
This state is not accessible to the running U-Boot but at present it is allocated in the emulated SDRAM. This doesn't seem very useful. Adjust it to allocate from the OS instead. The RAM buffer is currently not free, but should be, so add that into state_uninit(). Update the comment for os_free()

[PATCH v2 5/8] sandbox: Add os_realloc()

2021-01-23 Thread Simon Glass
We provide os_malloc() and os_free() but not os_realloc(). Add this, following the usual semantics. Also update os_malloc() to behave correctly when passed a zero size. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to add os_realloc() arch/sandbox/cpu/os.c | 38

[PATCH v2 4/8] s5p4418_nanopi2: Drop dead code

2021-01-23 Thread Simon Glass
This code is still using the old command typedef. It was not noticed since this file is not currently built. It is using a non-existent option in the Makefile. Drop this file since it is not needed for correct operation. Signed-off-by: Simon Glass --- Changes in v2: - Drop the file instead of f

[PATCH v2 2/8] binman: Indicate how to make binman verbose

2021-01-23 Thread Simon Glass
Add notes about how to make binman produce verbose logging when building. Add a comment on how to do this. Signed-off-by: Simon Glass --- (no changes since v1) Makefile| 1 + tools/binman/README | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Mak

[PATCH v2 3/8] doc: Add a note about how to produce 'md' output using hexdump

2021-01-23 Thread Simon Glass
Comparing a hex dump on the U-Boot command line with the contents of a file on the host system is fairly easy and convenient to do manually if it is small. But the format used hexdump by default differs from that shown by U-Boot. Add a note about how to make them the same. (For large dumps, writin

[PATCH v2 1/8] spl: Drop duplicate 'Jumping to U-Boot' message

2021-01-23 Thread Simon Glass
This is printed twice but we only need one message, since there is very little processing in between them. Drop the first one. Signed-off-by: Simon Glass --- (no changes since v1) common/spl/spl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 12b0

[PATCH v2 0/8] Various minor fixes

2021-01-23 Thread Simon Glass
This series collects a few minor fixes and improvements that have been hanging around in a branch for a while. Changes in v2: - Drop the file instead of fixing it up - Add new patch to add os_realloc() - Drop unnecessary check before calling os_free() - Update the comment for os_free() - Also free

Re: [PATCH 5/5] x86: coral: Enable CONFIG_BOOTARGS_SUBST

2021-01-23 Thread Simon Glass
Enable this option so that the boot-script substitutions of %U works as expected. With this, it can boot into Chrome OS. Signed-off-by: Simon Glass --- configs/chromebook_coral_defconfig | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm, thanks!

Re: [PATCH 01/10] dtoc: binman: Drop Python 2 code

2021-01-23 Thread Simon Glass
Drop a few more Python 2 relics that are no-longer needed. Signed-off-by: Simon Glass --- tools/binman/fmap_util.py | 4 ++-- tools/dtoc/fdt.py | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 02/10] patman: Correct lz4 compression parameters

2021-01-23 Thread Simon Glass
At present on large files, lz4 uses a larger block size (e.g. 256KB) than the 64KB supported by the U-Boot decompression implementation. Also it is optimised for maximum compression speed, producing larger output than we would like. Update the parameters to correct these problems. Signed-off-by:

Re: [PATCH 08/10] binman: Allow vblock to include devicetree blobs

2021-01-23 Thread Simon Glass
At present if a devicetree blob is included in a vblock it does not deal with updates. This is because the vblock is created once at the start and does not have a method to update itself later, after all the entry contents are finalised. Fix this by adjusting how the vblock is created. Also simpl

Re: [PATCH 10/10] binman: Allow for skip_at_start when reading entries

2021-01-23 Thread Simon Glass
The offset of an entry needs to be adjusted by its skip-at-start value. This is currently missing when reading entry data. Fix it. Signed-off-by: Simon Glass --- tools/binman/etype/section.py | 10 ++ tools/binman/ftest.py | 19 +++ tools/

Re: [PATCH 09/10] binman: Support alignment of files

2021-01-23 Thread Simon Glass
When packing files it is sometimes useful to align the start of each file, e.g. if the flash driver can only access 32-bit-aligned data. Provides a new property to support this. Signed-off-by: Simon Glass --- tools/binman/etype/files.py | 4 tools/binman/ftest.py

Re: [PATCH 1/1] sandbox: fix sandbox_cmdline_cb_test_fdt()

2021-01-23 Thread Simon Glass
On Fri, 25 Dec 2020 at 08:04, Heinrich Schuchardt wrote: > > fmt does not foresee any parameter. > > Signed-off-by: Heinrich Schuchardt > --- > arch/sandbox/cpu/start.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass Applied to u-boot-dm, thanks!

Re: [PATCH 1/1] x86: typo segement

2021-01-23 Thread Simon Glass
On Tue, Dec 22, 2020 at 2:53 PM Heinrich Schuchardt wrote: > > %s/segement/segment/ > > Signed-off-by: Heinrich Schuchardt > --- > arch/x86/cpu/i386/cpu.c | 2 +- > arch/x86/cpu/start.S| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng Applied to u-boot-dm,

Re: [PATCH 2/5] tpm: cr50: Add a better description and more debug

2021-01-23 Thread Simon Glass
Update the TPM description to include the interrupt mechanicm since this is useful to know. Also add a warning if the TPM cannot be found and a debug line if it succeeds. Signed-off-by: Simon Glass --- drivers/tpm/cr50_i2c.c | 22 ++ 1 file changed, 18 insertions(+), 4 delet

Re: [PATCH 4/5] x86: coral: Update an unused pin to reduce power

2021-01-23 Thread Simon Glass
GPIO_25 is not used on coral, so set it up in deep sleep. Signed-off-by: Simon Glass --- arch/x86/dts/chromebook_coral.dts | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm, thanks!

Re: [PATCH] doc/sandbox: improve formatting of command line options

2021-01-23 Thread Simon Glass
On Wed, 30 Dec 2020 at 10:10, Heinrich Schuchardt wrote: > > Show the command line options in bold. > > Signed-off-by: Heinrich Schuchardt > --- > doc/arch/sandbox.rst | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > Reviewed-by: Simon Glass Applied to

Re: [PATCH 3/5] tpm: cr50: Rename driver to work with of-platdata

2021-01-23 Thread Simon Glass
Update the driver name to match the compatible string, so it can work with of-platdata. Signed-off-by: Simon Glass --- drivers/tpm/cr50_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 1/5] tpm: cr50: Check for valid locality

2021-01-23 Thread Simon Glass
When the Cr50 starts up it doesn't have a valid locality. The driver sets it to -1 to indicate that. Tracking this allows cr50_i2c_cleanup() to avoid releasing a locality that was not claimed. However the helper functions that generate the flags use a u8 type which cannot support -1, so they retur

Re: [PATCH 03/10] binman: Update the TODO list

2021-01-23 Thread Simon Glass
Two of the items have been completed and I thought of another one. Update the list. Signed-off-by: Simon Glass --- tools/binman/README | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 06/10] binman: Support finding symbols in sub-sections

2021-01-23 Thread Simon Glass
At present binman only supports resolving symbols in the same section as the binary that uses it. This is quite limited because we often need to group entries into different sections. Enhance the algorithm to search the entire image for symbols. Signed-off-by: Simon Glass --- tools/binman/elf.

Re: [PATCH 05/10] binman: Fix a few file comments

2021-01-23 Thread Simon Glass
Two files have the wrong comment at the top of them. Fix this. Signed-off-by: Simon Glass --- tools/binman/etype/u_boot_spl_bss_pad.py | 1 - tools/binman/etype/u_boot_spl_nodtb.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 04/10] binman: Show the size when writing entries

2021-01-23 Thread Simon Glass
Update the log output to show the size, since this is useful information. Signed-off-by: Simon Glass --- tools/binman/control.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH 07/10] binman: Support reading an image with entry args

2021-01-23 Thread Simon Glass
Normally when an entry is created, any entry arguments it has are required to be provided, so it can actually generate its contents correctly. However when an existing image is read, Entry objects are created for each of the entries in the image. This happens as part of the process of reading the

[PATCH v3 11/11] tpm: Allow disabling platform hierarchy with TPM2

2021-01-23 Thread Simon Glass
With TPM2 we don't actually lock the TPM once verified boot is finished. Instead we disable the platform hierarchy which serves the same purpose. Add an implementation of this so we can safely boot into the kernel. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add defini

[PATCH v3 10/11] tpm: Add TPM2 support for write_lock

2021-01-23 Thread Simon Glass
Implement this API function for TPM2. Signed-off-by: Simon Glass --- (no changes since v1) include/tpm-v2.h | 12 lib/tpm-v2.c | 23 +++ lib/tpm_api.c| 2 +- 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/include/tpm-v2.h b/include/tpm-

[PATCH v3 05/11] tpm: Switch TPMv1 over to use the new API

2021-01-23 Thread Simon Glass
Take over the plain 'tpm_...' functions for use by the new TPM API. Rename all the TPMv1 functions so they are called from the API. Update the TPMv1 functions so that they are called from the API. Change existing users to use the tpm1_ prefix so they don't need to go through the API, which might i

[PATCH v3 09/11] tpm: Add TPM2 support for read/write values

2021-01-23 Thread Simon Glass
Implement this API function for TPM2. Signed-off-by: Simon Glass --- (no changes since v1) include/tpm-common.h | 3 ++ include/tpm-v2.h | 38 lib/tpm-v2.c | 84 lib/tpm_api.c| 4 +-- 4 files changed, 127 i

[PATCH v3 08/11] tpm: Add an implementation of define_space

2021-01-23 Thread Simon Glass
Add support for this so that the TPM can be set up for use with Chromium OS verified boot. Signed-off-by: Simon Glass --- Changes in v3: - Add a comment to the offset and fix up the value include/tpm-v2.h | 18 ++ lib/tpm-v2.c | 48 ++

[PATCH v3 07/11] tpm: Reduce duplication in a few functions

2021-01-23 Thread Simon Glass
Update tpm2_clear() and tpm2_pcr_extend() so that the command size is not repeated twice. Add a small comment to the latter. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add comments for the offset value lib/tpm-v2.c | 13 - 1 file changed, 8 insertions(+)

  1   2   >