Thanks, Leo, I'll check that.
-
Green
On Thu, Mar 25, 2021 at 11:19 AM Leo Liang wrote:
> Hi Green,
>
> On Mon, Mar 22, 2021 at 03:11:08PM +0800, Green Wan wrote:
> > I found I didn't clean the folder before I ran the build test. The
> changes
> > below for board/sifive/unmatched/Makefile was
On 25/03/2021 01:38, Simon Glass wrote:
> Hi Matthias,
>
> On Thu, 18 Mar 2021 at 00:30, wrote:
>>
>> From: Matthias Brugger
>>
>> When no string is present in a table, next_ptr points to the same
>> location as eos. When calculating the string table length, we would only
>> reserve one \0.
Hi Green,
On Mon, Mar 22, 2021 at 03:11:08PM +0800, Green Wan wrote:
> I found I didn't clean the folder before I ran the build test. The changes
> below for board/sifive/unmatched/Makefile was missing. Sorry about that.
>
> -obj-y += hifive-unmatched-fu740.o
> +obj-y += unmatched.o
>
> -
>
Just want to point out that TF-A currently already supports a (very simple)
mechanism like this:
https://review.trustedfirmware.org/plugins/gitiles/TF-A/trusted-firmware-a/+/refs/heads/master/include/export/lib/bl_aux_params/bl_aux_params_exp.h
eHi Marek,
On Thu, 25 Mar 2021 at 13:46, Marek Behun wrote:
>
> On Thu, 25 Mar 2021 13:38:13 +1300
> Simon Glass wrote:
>
> > Hi Marek,
> >
> > On Wed, 17 Mar 2021 at 04:19, Marek Behun wrote:
> > >
> > > Simon, Heiko, Bin,
> > >
> > > Pratyush discovered that the solution implemented by the
Hi Sean,
On Thu, 25 Mar 2021 at 13:54, Sean Anderson wrote:
>
> On 3/24/21 8:38 PM, Simon Glass wrote:
> > Hi Sean,
> >
> > On Thu, 11 Mar 2021 at 18:15, Sean Anderson wrote:
> >>
> >> strlcpy should always return the number of bytes copied. We were
> >> accidentally missing the nul-terminator.
> Subject: Re: [PATCH 02/26] imx8mm_evk: Update to latest LPDDR4 script
>
> On Fri, Mar 19, 2021 at 12:26 AM Peng Fan (OSS)
> wrote:
> >
> > From: Ye Li
> >
> > Update LPDDR4 script to sync with v2020.04 u-boot
> >
> > Signed-off-by: Ye Li
>
> Peng,
>
> The commit log does not make sense. I
On 3/24/21 8:38 PM, Simon Glass wrote:
Hi Sean,
On Thu, 11 Mar 2021 at 18:15, Sean Anderson wrote:
strlcpy should always return the number of bytes copied. We were
accidentally missing the nul-terminator. We also always used to return a
non-zero value, even if we did not actually copy
On 3/11/21 12:15 AM, Sean Anderson wrote:
strlcpy should always return the number of bytes copied. We were
accidentally missing the nul-terminator. We also always used to return a
It looks like I was a bit bullish in assuming a mistake. After reviewing
the man page, it looks like the
On Thursday 25 March 2021 13:39:28 Simon Glass wrote:
> This probably should have been done a while back since it is a core
> system. Add a migration deadline of later this year, to catch the
> stragglers.
>
> Signed-off-by: Simon Glass
>
> ---
>
> Changes in v3:
> - s/'network'/I2C/ again
>
On Thu, 25 Mar 2021 13:38:13 +1300
Simon Glass wrote:
> Hi Marek,
>
> On Wed, 17 Mar 2021 at 04:19, Marek Behun wrote:
> >
> > Simon, Heiko, Bin,
> >
> > Pratyush discovered that the solution implemented by the patch
> > regmap: fix a serious pointer casting bug
> > is wrong. The
Hi Matthias,
On Thu, 18 Mar 2021 at 00:30, wrote:
>
> From: Matthias Brugger
>
> When no string is present in a table, next_ptr points to the same
> location as eos. When calculating the string table length, we would only
> reserve one \0. By spec a SMBIOS table has to end with two \0\0 when no
This probably should have been done a while back since it is a core
system. Add a migration deadline of later this year, to catch the
stragglers.
Signed-off-by: Simon Glass
---
Changes in v3:
- s/'network'/I2C/ again
Changes in v2:
- s/'network'/I2C/
Makefile | 11
On Thu, 11 Mar 2021 at 18:16, Sean Anderson wrote:
>
> strn(cat|cpy) has a bad habit of not nul-terminating the destination,
> resulting in constructions like
>
> strncpy(foo, bar, sizeof(foo) - 1);
> foo[sizeof(foo) - 1] = '\0';
>
> However, it is very easy to forget about this
Hi Vagrant,
On Sun, 7 Mar 2021 at 11:50, Vagrant Cascadian wrote:
>
> It seems like commit:
>
> 3f04db891a353f4b127ed57279279f851c6b4917 image: Check for unit addresses in
> FIT
>
> Broke test/image/test-imagetools.sh.
>
> I get the impression test-imagetools.sh is more-or-less unmaintained and
Hi Sean,
On Thu, 11 Mar 2021 at 18:15, Sean Anderson wrote:
>
> This test is adapted from glibc, which is very concerned about alignment.
> It also tests strlcpy by dependency.
>
> Signed-off-by: Sean Anderson
> ---
>
> Changes in v2:
> - New
>
> test/lib/Makefile | 1 +
>
Hi Sean,
On Thu, 11 Mar 2021 at 18:15, Sean Anderson wrote:
>
> strlcpy should always return the number of bytes copied. We were
> accidentally missing the nul-terminator. We also always used to return a
> non-zero value, even if we did not actually copy anything.
>
> Fixes: 23cd138503
On Thu, 11 Mar 2021 at 18:15, Sean Anderson wrote:
>
> This introduces strlcat, which provides a safer interface than strncat. It
> never copies more than its size bytes, including the terminating nul. In
> addition, it never reads past dest[size - 1], even if dest is not
> nul-terminated.
>
>
This probably should have been done a while back since it is a core
system. Add a migration deadline of later this year, to catch the
stragglers.
Signed-off-by: Simon Glass
---
Changes in v2:
- s/'network'/I2C/
Makefile | 11 +++
doc/driver-model/migration.rst |
Hi Marek,
On Wed, 17 Mar 2021 at 04:19, Marek Behun wrote:
>
> Simon, Heiko, Bin,
>
> Pratyush discovered that the solution implemented by the patch
> regmap: fix a serious pointer casting bug
> is wrong. The cpu_to_le32() / le32_to_cpu() shifts data to the correct
> position, but on big
Hi Pali,
On Thu, 25 Mar 2021 at 12:23, Pali Rohár wrote:
>
> On Thursday 25 March 2021 12:00:14 Simon Glass wrote:
> > This probably should have been done a while back since it is a core
> > system. Add a migration deadline of later this year, to catch the
> > stragglers.
> >
> > Signed-off-by:
Document SRC_GPR10 PERSIST_SECONDARY_BOOT functionality. This is useful for
reliable bootloader A/B updates, as it permits switching between two copies
of bootloader at different offsets of the same storage. The switch happens
in case one copy is corrupted OR can be enforced by user. This
On 3/24/21 5:26 PM, Simon Glass wrote:
Driver model uses quite strong conventions on error codes, but these are
currently not clearly documented. Add a description of the commonly used
errors.
Signed-off-by: Simon Glass
---
Changes in v3:
- Add updates based on feedback from Sean Anderson
On Thursday 25 March 2021 12:00:14 Simon Glass wrote:
> This probably should have been done a while back since it is a core
> system. Add a migration deadline of later this year, to catch the
> stragglers.
>
> Signed-off-by: Simon Glass
>
> ---
>
> Makefile | 11
This probably should have been done a while back since it is a core
system. Add a migration deadline of later this year, to catch the
stragglers.
Signed-off-by: Simon Glass
---
Makefile | 11 +++
doc/driver-model/migration.rst | 8
2 files changed, 19
On Wed, 24 Mar 2021 16:36:10 +
Stefan Chulski wrote:
> > > > > > SGMII uses the same coding as 1000base-x, but the latter works
> > > > > > only with one speed (1000mbps), while the former can also work
> > > > > > in 10mbps and 100mbps (by repeating each byte 100 or 10 times,
> >
Hi Harb,
On Wed, 24 Mar 2021 at 11:39, Harb Abdulhamid OS <
abdulha...@os.amperecomputing.com> wrote:
> Hello Folks,
>
> Appreciate the feedback and replies on this. Glad to see that there is
> interest in this topic.
>
>
>
> I try to address the comments/feedback from Francois and Simon
Hi,
What do people think of setting up a bug tracker on gitlab.com or
github.com? They both allow anyone to register and thus file bugs.
Another option is to use source.denx.de but that would require
allowing anyone to register so is probably a non-starter.
For guthub one advantage is that we
On Wed, Mar 24, 2021 at 09:54:06PM +, Harm Berntsen wrote:
> On Wed, 2021-03-24 at 17:22 -0400, Tom Rini wrote:
> > On Wed, Mar 24, 2021 at 09:11:01PM +, Harm Berntsen wrote:
> > > On Thu, 2021-02-11 at 15:06 -0500, Tom Rini wrote:
> > > > On Wed, Feb 10, 2021 at 09:09:56PM -0800, Rick
+U-Boot Mailing List
On Wed, 3 Mar 2021 at 03:44, Heinrich Schuchardt wrote:
>
> On 02.03.21 14:30, scan-ad...@coverity.com wrote:
> > Hi,
> >
> > Please find the latest report on new defect(s) introduced to Das U-Boot
> > found with Coverity Scan.
> >
> > 2 new defect(s) introduced to Das
On Wed, 2021-03-24 at 17:22 -0400, Tom Rini wrote:
> On Wed, Mar 24, 2021 at 09:11:01PM +, Harm Berntsen wrote:
> > On Thu, 2021-02-11 at 15:06 -0500, Tom Rini wrote:
> > > On Wed, Feb 10, 2021 at 09:09:56PM -0800, Rick Thomas wrote:
> > > >
> > > >
> > > > On Wed, Feb 10, 2021, at 8:57 PM,
It is useful to have a board with unit tests enabled, to check that this
does not break.
Let's choose snow, since it is not under active development and it is
glorious.
Signed-off-by: Simon Glass
---
configs/snow_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git
Due to a recent change, tests are limited to running on sandbox only.
Correct this so that any architecture can run them.
Signed-off-by: Simon Glass
Reported-by: Sean Anderson
Fixes: c79705ea938 ("test: Move dm_test_init() into test-main.c")
---
include/test/test.h | 9 +
Add a bus driver for this and use it to configure the bus parameters for
the Ethernet interface. Drop the old pre-driver-model code.
Switch over to use driver model for Ethernet.
Signed-off-by: Simon Glass
---
arch/arm/Kconfig | 1 +
Update the code to use -ENOSYS, which is the correct error code for an
unimplemented system call in U-Boot.
Also we should not check for a missing operations array as this is not
permitted. For now this can be covered by an assert().
Signed-off-by: Simon Glass
---
(no changes since v1)
We don't need to check -ENOTSUPP since this is not used for this purpose
in U-Boot. Update the code accordingly.
Signed-off-by: Simon Glass
Reviewed-by: Sean Anderson
---
(no changes since v1)
drivers/core/simple-pm-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Update clk_composite_set_parent() to use -ENOSYS, which is the correct
error code for U-Boot. Also rearrange the code so that the error condition
is clearly indicated and the function runs to the end in the normal case,
since this is the common style in U-Boot.
Signed-off-by: Simon Glass
When CMD_TLV_EEPROM is not enabled, use -ENOSYS, which is the correct
error code for U-Boot.
Signed-off-by: Simon Glass
---
(no changes since v1)
include/tlv_eeprom.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/tlv_eeprom.h b/include/tlv_eeprom.h
index
At present some drivers use -ENOSUPP to indicate that an unknown or
unsupported clock is used. Most use -EINVAL, indicating an invalid value,
so convert everything to that.
Signed-off-by: Simon Glass
Acked-by: Sean Anderson
Reviewed-by: Stefan Roese
---
(no changes since v2)
Changes in v2:
Update spi_controller_dma_map_mem_op_data() to use -ENOSYS, which is the
correct error code for U-Boot.
Signed-off-by: Simon Glass
---
(no changes since v1)
include/spi-mem.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/spi-mem.h b/include/spi-mem.h
index
Update usb_gadget_release() to use -ENOSYS, which is the correct error
code for U-Boot.
Signed-off-by: Simon Glass
---
(no changes since v1)
drivers/usb/gadget/udc/udc-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/udc-uclass.c
Update this function to use -ENOSPC which is more commly used when a buffer
runs out of space.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Add new patch for acpi_get_path()
drivers/core/acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Driver model uses quite strong conventions on error codes, but these are
currently not clearly documented. Add a description of the commonly used
errors.
Signed-off-by: Simon Glass
---
Changes in v3:
- Add updates based on feedback from Sean Anderson
Changes in v2:
- Add a patch to document
A few places use -ENOTSUPP when they should use -ENOSYS. In two cases both
are used. This little series tidies this up and documents the conventions.
Changes in v3:
- Add updates based on feedback from Sean Anderson
Changes in v2:
- Add a patch to document the common error codes
- Add new patch
On Fri, Mar 19, 2021 at 12:31 AM Peng Fan (OSS) wrote:
>
> From: Ye Li
>
> Users reported LPDDR4 MR12 value is set to 0 during PHY training,
> not the value from FSP timing structure, which cause compliance test failed.
> The root cause is the CATrainOpt[0] is set to 1 in 2D FSP timing
> but not
On Wed, Mar 24, 2021 at 09:11:01PM +, Harm Berntsen wrote:
> On Thu, 2021-02-11 at 15:06 -0500, Tom Rini wrote:
> > On Wed, Feb 10, 2021 at 09:09:56PM -0800, Rick Thomas wrote:
> > >
> > >
> > > On Wed, Feb 10, 2021, at 8:57 PM, Vagrant Cascadian wrote:
> > > > On 2021-02-10, Rick Thomas
On Fri, Mar 19, 2021 at 12:26 AM Peng Fan (OSS) wrote:
>
> From: Ye Li
>
> Update LPDDR4 script to sync with v2020.04 u-boot
>
> Signed-off-by: Ye Li
Peng,
The commit log does not make sense. I believe you want to say
something like 'Update LPDDR4 script to sync with version of the
NXP
On Thu, 2021-02-11 at 15:06 -0500, Tom Rini wrote:
> On Wed, Feb 10, 2021 at 09:09:56PM -0800, Rick Thomas wrote:
> >
> >
> > On Wed, Feb 10, 2021, at 8:57 PM, Vagrant Cascadian wrote:
> > > On 2021-02-10, Rick Thomas wrote:
> > > > I have not recently (since before 2019) done anything more than
Hi Sean,
On Thu, 25 Mar 2021 at 05:00, Sean Anderson wrote:
>
> On 3/23/21 1:40 AM, Simon Glass wrote:
> > HI Sean,
> >
> > On Tue, 23 Mar 2021 at 17:45, Sean Anderson wrote:
> >>
> >> On 3/23/21 12:14 AM, Simon Glass wrote:
> >>> Driver model uses quite strong conventions on error codes, but
Hello,
I realized, that "ums 0 mmc 0" is not working without executing "usb
start" in advance. That's because "ums" does not enable the clock and
deassert the USB reset. Is that by purpose? At least "usb start" was not
necessary with v2016.11.
Wolfgang
Which files we generate depends on the setting of OF_PLATDATA_INST in the
build. This might change between builds, but the build directory may be
reused.
Leaving old files around is confusing and switching the OF_PLATDATA_INST
setting does not necessarily regenerate the files, e.g. if the
There are actually two generated files but only one is currently mentioned
in the Makefile as a dependency. Put them both in a Makefile variable and
use that instead, to avoid inconsistency.
Signed-off-by: Simon Glass
---
Changes in v2:
- Add a comment to the endif
scripts/Makefile.spl | 11
At present all possible files are generated, even if some of them just
have a header and an empty body. It is better to generate only the files
that are needed, so that the two types of build (based on the setting of
OF_PLATDATA_INST) can be mutually exclusive.
This is intended to fix a strange
When OF_PLATDATA_INST is enabled, we need dt-uclass.c and dt-device.c for
the build to work. When OF_PLATDATA_INST is not enabled, we only need
dt-plat.c
Update the Makefile rules to indicate this.
At present all files are generated and compiled regardless of which are
actually needed.
Since the dst_dir rule always runs, it causes a rebuild of the of-platdata
files even if not needed.
Create the directory inside the rule instead.
Signed-off-by: Simon Glass
---
(no changes since v1)
scripts/Makefile.spl | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
At present the build rule for pylibfdt depends on _libfdt.so but modern
Python versions add a different suffix to the output file, resulting in
something like _libfdt.cpython-38-x86_64-linux-gnu.so
The result is that pylibfdt is rebuilt every time.
Rename the file the standard name so that the
The recent of-platdata implementation has caused an occasional error in
CI, possibly due to the transition between !OF_PLATDATA_INST and
OF_PLATDATA_INST.
The problems seems to be due to a generated file (C or object file) not
being regenerated when the setting changes.
This series take two
On 19.03.21 00:55, Heinrich Schuchardt wrote:
> Multiple DFU entities may share the same SPI device. We must make sure that
> the SPI device is only freed once.
>
> When using the driver model it is not necessary to free the SPI device.
>
> Signed-off-by: Heinrich Schuchardt
> ---
>
On Wed, 24 Mar 2021 15:06:34 +0100
Stefan Roese wrote:
> From: Igal Liberman
>
> This patch adds support for running RX training using new command called
> "rx_training"
> Usage:
> rx_training - rx_training
>
> RX training allows to improve link quality (for SFI mode)
> by running training
Please be also aware the we have the following patch U-Boot
commit 545591132aa701ff1262bb309fbcd0c3ff0acd75
Author: Marek Behún
Date: Wed Aug 19 11:57:25 2020 +0200
arm64: dts: armada-3720-espressobin: fix COMPHY nodes
This commit fixes initialization of COMPHY on EspressoBin.
> > > > > SGMII uses the same coding as 1000base-x, but the latter works
> > > > > only with one speed (1000mbps), while the former can also work
> > > > > in 10mbps and 100mbps (by repeating each byte 100 or 10 times,
> respectively).
> > > > >
> > > > > Then there is 2500base-x, which is the
On 3/23/21 1:40 AM, Simon Glass wrote:
HI Sean,
On Tue, 23 Mar 2021 at 17:45, Sean Anderson wrote:
On 3/23/21 12:14 AM, Simon Glass wrote:
Driver model uses quite strong conventions on error codes, but these are
currently not clearly documented. Add a description of the commonly used
Add signature with crc32 value for all images in binman node for FIT
image in device tree. And, enable FIT signature checking for Stratix10
and Agilex ATF and VAB sdmmc boot.
Signed-off-by: Siew Chin Lim
---
arch/arm/dts/socfpga_soc64_fit-u-boot.dtsi | 30 +-
On Mär 24 2021, Heinrich Schuchardt wrote:
> And foo is obviously "changed between the setjmp invocation and longjmp
> call".
>
> The current version of the patch is:
> https://patchwork.ozlabs.org/project/uboot/patch/20210323181127.32411-3-xypron.g...@gmx.de/
>
> So I guess we have to declare
On Wednesday 24 March 2021 16:39:22 Stefan Roese wrote:
> On 24.03.21 16:04, Kostya Porotchkin wrote:
> > Hi, Pali,
> >
> > > -Original Message-
> > > From: Pali Rohár
> > > Sent: Wednesday, March 24, 2021 16:43
> > > To: Stefan Roese
> > > Cc: u-boot@lists.denx.de; Nadav Haklai ;
On 24.03.21 16:04, Kostya Porotchkin wrote:
Hi, Pali,
-Original Message-
From: Pali Rohár
Sent: Wednesday, March 24, 2021 16:43
To: Stefan Roese
Cc: u-boot@lists.denx.de; Nadav Haklai ; Kostya
Porotchkin ; Marek Behún ;
Grzegorz Jaszczyk ; Igal Liberman ;
Baruch Siach
Subject: [EXT]
Hi, Pali,
> -Original Message-
> From: Pali Rohár
> Sent: Wednesday, March 24, 2021 16:43
> To: Stefan Roese
> Cc: u-boot@lists.denx.de; Nadav Haklai ; Kostya
> Porotchkin ; Marek Behún ;
> Grzegorz Jaszczyk ; Igal Liberman ;
> Baruch Siach
> Subject: [EXT] Re: [PATCH v1 02/23] phy:
TCG PC Client Platform Firmware Profile Spec mandates that an S-CRTM
event for the version identifier using the event type EV_S_CRTM_VERSION
must be measured.
So since we are trying to add more conformance into U-Boot, let's add
the event using U_BOOT_VERSION_STRING, extend PCR[0] accordingly and
On Wednesday 24 March 2021 15:06:28 Stefan Roese wrote:
> diff --git a/arch/arm/dts/armada-3720-espressobin.dts
> b/arch/arm/dts/armada-3720-espressobin.dts
> index 96a4b3d95b88..3cea5218d2b3 100644
> --- a/arch/arm/dts/armada-3720-espressobin.dts
> +++ b/arch/arm/dts/armada-3720-espressobin.dts
On Wed, Mar 24, 2021 at 11:04:18AM +0100, Kory Maincent wrote:
> This commit enables using the extension board detection mechanism on
> CHIP boards
>
> Signed-off-by: Kory Maincent
Acked-by: Maxime Ripard
Maxime
signature.asc
Description: PGP signature
Hi,
On Wed, Mar 24, 2021 at 11:04:17AM +0100, Kory Maincent wrote:
> Add the extension_board_scan specific function to scan the information
> of the EEPROM on one-wire and fill the extension struct.
> Add the Kconfig symbol to enable the needs to detect DIPs.
>
> Signed-off-by: Kory Maincent
>
On Wed, Mar 24, 2021 at 11:04:16AM +0100, Kory Maincent wrote:
> This patch changes the functioning of the detection of w1 devices.
> The old way was a comparison between detected w1 and the ones described in
> the device tree. Now it will just look for the driver matching the family
> id of the
Current code doesn't free the efi allocated memory in case the protocol
failed to install
Fixes: c8d0fd582576 ("efi_loader: Introduce eventlog support for TCG2_PROTOCOL")
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_tcg2.c | 21 +
1 file changed, 17 insertions(+),
Hi,
On Wed, Mar 24, 2021 at 11:04:12AM +0100, Kory Maincent wrote:
> This patch adds a new "extension" command, which aims at detecting
> extension boards connected to the hardware platform, and apply the
> Device Tree overlays that describe the hardware present on those
> extension boards.
>
>
On Wed, Mar 24, 2021 at 04:35:42AM +, Priyanka Jain wrote:
> Dear Tom,
>
> Please find my pull-request for u-boot-fsl-qoriq/master
> https://github.com/u-boot/u-boot/pull/58
>
> Summary
> Bug fixes related to FSL-IFC, watchdog
> layerscape-pcie, flexspi, T2080rdb.
>
> priyankajain
On Tue, Mar 23, 2021 at 07:38:51AM +, Tan, Ley Foon wrote:
> Hi Tom
>
> Please pull one fix for v2021.04-rc5.
>
> Thanks.
>
> Regards
> Ley Foon
>
> The following changes since commit 1f9c3f13f6ad8595a0fb5ab2cb830583cdc0b60a:
>
> Merge tag 'efi-2021-04-rc5-2' of
>
From: Igal Liberman
Currently, we don't pass id for SGMII 0/1.
A bug in comphy selector configuration was found (in comphy
firmware), after fixing it, SGMII0/1 have different configuration,
so we need to pass the ID the firmware.
Signed-off-by: Igal Liberman
Reviewed-by: Grzegorz Jaszczyk
On Wed, Mar 24, 2021 at 11:04:11AM +0100, Kory Maincent wrote:
> Move the fdt_valid function to fdt_support.
> This changes allow to be able to test the validity of a devicetree in
> other c files.
>
> Update code syntax.
>
> Signed-off-by: Kory Maincent
> Reviewed-by: Tom Rini
Reviewed-by:
From: Igal Liberman
It helps ATF to determine who called power off
function (U-boot/Linux) and act accordingly
Signed-off-by: Igal Liberman
Reviewed-by: Grzegorz Jaszczyk
Signed-off-by: Stefan Roese
---
drivers/phy/marvell/comphy_cp110.c | 4 ++--
1 file changed, 2 insertions(+), 2
From: Grzegorz Jaszczyk
According to Design Reference Specification the PHY PLL and Calibration
register from PHY0 are shared for multi-port PHY. PLL control registers
inside other PHY channels are not used.
This commit reworks utmi device tree nodes in a way that common PHY PLL
registers are
From: Christine Gharzuzi
- the default value of comphy pipe selector is set to PCIe (x4)
in case of unconnected comphy the default value remains 0x4
which may lead to several issues with comphy initialization.
- this patch adds SMC call that powers off the comphy lane in case of
From: Igal Liberman
Signed-off-by: Igal Liberman
Signed-off-by: Stefan Roese
---
doc/device-tree-bindings/phy/mvebu_comphy.txt | 68 +++
1 file changed, 68 insertions(+)
create mode 100644 doc/device-tree-bindings/phy/mvebu_comphy.txt
diff --git
From: Grzegorz Jaszczyk
New products can contain up to 6 usb ports, therefore allow to initialize
all relevant UTMI PHYs.
Signed-off-by: Grzegorz Jaszczyk
Reviewed-by: Kostya Porotchkin
Signed-off-by: Stefan Roese
---
drivers/phy/marvell/comphy_core.h | 2 +-
1 file changed, 1
From: Grzegorz Jaszczyk
Signed-off-by: Grzegorz Jaszczyk
Reviewed-by: Igal Liberman
Signed-off-by: Stefan Roese
---
drivers/phy/marvell/comphy_a3700.h | 1 -
drivers/phy/marvell/comphy_core.h | 50 --
drivers/phy/marvell/comphy_cp110.c | 5 -
drivers/phy/marvell/comphy_hpipe.h | 720
From: Grzegorz Jaszczyk
- Add additional step which enables the Impedance and PLL calibration.
- Enable old squelch detector instead of the new analog squelch detector
circuit and update host disconnect threshold value.
- Update LS TX driver strength coarse and fine adjustment values.
From: Grzegorz Jaszczyk
Now the comphy configuration is handled in atf, therefore there is no
need to configure phy or pipe selector in u-boot, it is configured by
atf for each particular pair: lane and mode.
Signed-off-by: Grzegorz Jaszczyk
Reviewed-by: Igal Liberman
Signed-off-by: Stefan
From: Igal Liberman
In CP115, comphy4 can be configured into SFI port1
(in addition to SFI0). This patch adds the option
described above.
In addition, rename all existing SFI/XFI references:
COMPHY_TYPE_SFI --> COMPHY_TYPE_SFI0
No functional change for exsiting configuration.
Signed-off-by:
From: Igal Liberman
Signed-off-by: Igal Liberman
Signed-off-by: Stefan Roese
---
drivers/phy/marvell/comphy_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/phy/marvell/comphy_core.c
b/drivers/phy/marvell/comphy_core.c
index b29decd82693..45dba738662c
From: Grzegorz Jaszczyk
Replace the XFI training with appropriate SMC call, so the firmware will
perform exact initialization.
Update Stefan 2021-03-23:
Move comphy_smc() function to an earlier place - necessary for the
mainline merge.
Signed-off-by: Grzegorz Jaszczyk
Signed-off-by: Stefan
From: Igal Liberman
Add UTMI analog parameters initialization values according to
latest ETP.
Signed-off-by: Igal Liberman
Signed-off-by: Stefan Roese
---
drivers/phy/marvell/comphy_cp110.c | 9 +++--
drivers/phy/marvell/utmi_phy.h | 5 -
2 files changed, 7 insertions(+), 7
From: Igal Liberman
This patch adds support for running RX training using new command called
"rx_training"
Usage:
rx_training - rx_training
RX training allows to improve link quality (for SFI mode)
by running training sequence between us and the link partner,
this allows to reach better link
From: Igal Liberman
Currently, all comphy definitions are PHY_TYPE_XX and PHY_SPEEED_XX.
Those definition might be confused with MDIO PHY definitions.
This patch does the following changes:
- PHY_TYPE_XX --> COMPHY_TYPE_XX
- PHY_SPEED_XX --> COMPHY_SPEED_XX
This improves readability, no
From: Grzegorz Jaszczyk
Replace the comphy initialization for USB with appropriate SMC call,
so the firmware will execute required serdes configuration.
Signed-off-by: Grzegorz Jaszczyk
Signed-off-by: Stefan Roese
---
drivers/phy/marvell/comphy_cp110.c | 133 ++---
1
From: Igal Liberman
If fdtdec_get_int can't find speed, set COMPHY_SPEED_INVALID
If fdtdec_get_int can't find type, set COMPHY_TYPE_INVALID
Move the error print if phy-type is invalid
Add continue to the probe loop (in a case of invalid phy)
Cosmetic changes
Signed-off-by: Igal Liberman
From: Grzegorz Jaszczyk
Replace the comphy initialization for RXAUI with appropriate SMC call,
so the firmware will execute required serdes configuration.
Signed-off-by: Grzegorz Jaszczyk
Reviewed-by: Igal Liberman
Signed-off-by: Stefan Roese
---
drivers/phy/marvell/comphy_cp110.c | 184
From: Igal Liberman
In get_speed_string() we have an array (speed_strings[])
which includes all possible speed strings.
This array size and content must be aligned to the speed
defines in comphy_data.h.
This patch adds missing 5.125G speed, aligns speed_strings[]
and fixes incorrect printing
From: Marcin Wojtas
Even if comphy types of SATA2/SATA3/SGMII3 and comphy speeds of
1.5G/3G/6.25G were referenced in the driver non configuration (dts)
was using it.
This patch removes unused definitions.
Signed-off-by: Grzegorz Jaszczyk
Signed-off-by: Konstantin Porotchkin
Signed-off-by:
From: Igal Liberman
This allows the lower level driver access to comphy map data
(required for RX training support, which is introduced
in the following patches).
Signed-off-by: Igal Liberman
Signed-off-by: Stefan Roese
---
drivers/phy/marvell/comphy_core.c | 20 ++--
This patchset adds the missing SERDES patches from the Marvell U-Boot
SDK U-Boot version. This is done in preparation for the integration
of the Octeon TX2 CN913x support, which uses the updated version of
this code.
Thanks,
Stefan
Christine Gharzuzi (1):
phy: marvell: fix handling of
From: jinghua
- For some Marvell SoCs, like armada-3700, there are both
USB host and device controller, but on PHY level the
configuration is the same.
- The new type supports both USB device and USB host
- This patch is cherry-picked from u-boot-2015 as-is.
Signed-off-by: jinghua
1 - 100 of 158 matches
Mail list logo
