[PATCH 1/1] doc: extension.rst missing in doc/usage/index.rst

2021-05-15 Thread Heinrich Schuchardt
'make htmldocs' results in a build warning checking consistency... doc/usage/extension.rst: WARNING: document isn't included in any toctree Add the document to the index. Fixes: 2f84e9cf06d3 ("cmd: add support for a new "extension" command") Signed-off-by: Heinrich Schuchardt ---

[PATCH 1/1] doc: extension.rst missing in doc/usage/index.rst

2021-05-15 Thread Heinrich Schuchardt
'make htmldocs' results in a build warning checking consistency... doc/usage/extension.rst: WARNING: document isn't included in any toctree Add the document to the index. Fixes: 2f84e9cf06d3 ("cmd: add support for a new "extension" command") Signed-off-by: Heinrich Schuchardt ---

Re: [PATCH 13/27] ppc: Remove sbc8548 boards

2021-05-15 Thread Paul Gortmaker
[[PATCH 13/27] ppc: Remove sbc8548 boards] On 14/05/2021 (Fri 21:34) Tom Rini wrote: > These boards have not been converted to CONFIG_DM_PCI by the deadline and are > also missing conversion to CONFIG_DM. Remove them. > > Cc: Paul Gortmaker Ack - kernel removal was queued several months ago,

Re: [PATCH 07/27] ppc: Remove sbc8349 board

2021-05-15 Thread Paul Gortmaker
[[PATCH 07/27] ppc: Remove sbc8349 board] On 14/05/2021 (Fri 21:34) Tom Rini wrote: > This board has not been converted to CONFIG_DM_MMC by the deadline. > Remove it. > > Cc: Paul Gortmaker Ack - this was removed in the linux-kernel already. Thanks, Paul. -- > Signed-off-by: Tom Rini > ---

Re: [PATCHv2] net: convert TFTP_TSIZE to proper Kconfig option

2021-05-15 Thread Tom Rini
On Sat, May 15, 2021 at 11:07:44PM +0300, Ramon Fried wrote: > On Wed, May 12, 2021 at 11:03 AM Tero Kristo wrote: > > > > TFTP transfer size can be used to re-size the TFTP progress bar on > > single line based on the server reported file size. The support for > > this has been around from 2019,

Re: [PATCHv2] net: convert TFTP_TSIZE to proper Kconfig option

2021-05-15 Thread Ramon Fried
On Wed, May 12, 2021 at 11:03 AM Tero Kristo wrote: > > TFTP transfer size can be used to re-size the TFTP progress bar on > single line based on the server reported file size. The support for > this has been around from 2019, but it was never converted to proper > Kconfig. > > While adding this

Re: [PATCH v2 01/16] sandbox: net: Ensure host name is always a valid string

2021-05-15 Thread Ramon Fried
On Fri, May 14, 2021 at 4:40 AM Simon Glass wrote: > > At present if ifname is exactly IFNAMSIZ characters then it will result > in an unterminated string. Fix this by using strlcpy() instead. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 316358) > --- > > Changes in v2: > - Put

Re: [PATCH 10/12] net: ti: am65-cpsw-nuss: Add a new compatible for AM64

2021-05-15 Thread Ramon Fried
On Mon, May 10, 2021 at 5:37 PM Vignesh Raghavendra wrote: > > Add a new compatible to support AM64 SoC > > Signed-off-by: Vignesh Raghavendra > --- > drivers/net/ti/am65-cpsw-nuss.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ti/am65-cpsw-nuss.c

Re: [PATCH 09/12] net: ti: am65-cpsw-nuss: Don't cache disabled port ID

2021-05-15 Thread Ramon Fried
On Mon, May 10, 2021 at 5:37 PM Vignesh Raghavendra wrote: > > Currently driver may end up caching disabled port ID as active > interface. Fix this by bailing out earlier in case port is marked > disabled in the DT. > > Signed-off-by: Vignesh Raghavendra > --- > drivers/net/ti/am65-cpsw-nuss.c

Re: [PATCH 08/12] net: ti: am65-cpsw-nuss: Prepare to support non primary ext port

2021-05-15 Thread Ramon Fried
On Mon, May 10, 2021 at 5:36 PM Vignesh Raghavendra wrote: > > CPSW NUSS IP on K3 SoCs can have more than one external port (upto 8) > Therefore increase AM65_CPSW_CPSWNU_MAX_PORTS to 9 (8 ext + 1 Root port) > as preparation to allow any one of the 8 ports to be used as ethernet > interface in

[PATCH v2] part: Add check for NULL dev_part_str

2021-05-15 Thread Sean Anderson
Some callers (e.g. cmd/fs.c) of fs_set_blk_dev may use a NULL dev_part_str. While blk_get_device_part_str handles this fine, part_get_info_by_dev_and_name does not. This fixes commands crashing when implicitly using bootdevice. The unit test has also been updated to set bootdevice to a known

Re: [PATCH] dm: Add check for NULL dev_part_str

2021-05-15 Thread Sean Anderson
On 5/15/21 1:55 PM, Heinrich Schuchardt wrote: On 5/15/21 6:36 PM, Sean Anderson wrote: Some callers (e.g. cmd/fs.c) of fs_set_blk_dev may use a NULL dev_part_str. While blk_get_device_part_str handles this fine, part_get_info_by_dev_and_name does not. This fixes commands crashing when

Re: [PATCH] dm: Add check for NULL dev_part_str

2021-05-15 Thread Heinrich Schuchardt
On 5/15/21 6:36 PM, Sean Anderson wrote: Some callers (e.g. cmd/fs.c) of fs_set_blk_dev may use a NULL dev_part_str. While blk_get_device_part_str handles this fine, part_get_info_by_dev_and_name does not. This fixes commands crashing when implicitly using bootdevice. Fixes: 7194527b6a ("cmd:

[PATCH 1/1] sandbox: correct determination of the text base

2021-05-15 Thread Heinrich Schuchardt
os_find_text_base() assumes that first line of /proc/self/maps holds information about the text. Hence we must call the function before calling os_malloc() which calls mmap(0x1000,). Failure to do so has led to incorrect values for pc_reloc when an exception was reported => exception

[BUG] [PATCH v4 7/9] sandbox: Avoid using malloc() for system state

2021-05-15 Thread Heinrich Schuchardt
On 2/6/21 5:57 PM, Simon Glass wrote: This state is not accessible to the running U-Boot but at present it is allocated in the emulated SDRAM. This doesn't seem very useful. Adjust it to allocate from the OS instead. The RAM buffer is currently not freed, but should be, so add that into

Re: [PATCH] dm: Add check for NULL dev_part_str

2021-05-15 Thread Sean Anderson
Re: [PATCH] dm: Add check for NULL dev_part_str This should probably be "part: ..." On 5/15/21 12:36 PM, Sean Anderson wrote: Some callers (e.g. cmd/fs.c) of fs_set_blk_dev may use a NULL dev_part_str. While blk_get_device_part_str handles this fine, part_get_info_by_dev_and_name does not.

[PATCH] dm: Add check for NULL dev_part_str

2021-05-15 Thread Sean Anderson
Some callers (e.g. cmd/fs.c) of fs_set_blk_dev may use a NULL dev_part_str. While blk_get_device_part_str handles this fine, part_get_info_by_dev_and_name does not. This fixes commands crashing when implicitly using bootdevice. Fixes: 7194527b6a ("cmd: fs: Use part_get_info_by_dev_and_name_or_num

Re: [PATCH 1/1] sandbox: ensure that state->ram_buf is in low memory

2021-05-15 Thread Simon Glass
Hi Heinrich, On Sat, 15 May 2021 at 09:33, Heinrich Schuchardt wrote: > > On 5/15/21 5:19 PM, Simon Glass wrote: > > Hi Heinrich, > > > > On Fri, 14 May 2021 at 18:34, Heinrich Schuchardt > > wrote: > >> > >> Am 14. Mai 2021 22:44:32 MESZ schrieb Simon Glass : > >>> Hi Heinrich, > >>> > >>> On

[PATCH 1/1] smbios: error handling for invalid addresses

2021-05-15 Thread Heinrich Schuchardt
SMBIOS tables only support 32bit addresses. If we don't have memory here handle the error gracefully: * on x86_64 fail to start U-Boot * during UEFI booting ignore the missing table Signed-off-by: Heinrich Schuchardt --- arch/x86/lib/tables.c | 13 +++--

Re: [PATCH 1/1] sandbox: ensure that state->ram_buf is in low memory

2021-05-15 Thread Heinrich Schuchardt
On 5/15/21 5:19 PM, Simon Glass wrote: Hi Heinrich, On Fri, 14 May 2021 at 18:34, Heinrich Schuchardt wrote: Am 14. Mai 2021 22:44:32 MESZ schrieb Simon Glass : Hi Heinrich, On Fri, 14 May 2021 at 00:11, Heinrich Schuchardt wrote: On 5/14/21 1:56 AM, Simon Glass wrote: Hi Heinrich, On

Re: [PATCH RFC 05/10] image: rsa: Move verification algorithm to a linker list

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 13:46, Alexandru Gagniuc wrote: > > Move the RSA verification crytpo_algo structure out of the > crypto_algos array, and into a linker list. > > Although it appears we are adding an #ifdef to rsa-verify.c, the gains > outweigh this small inconvenience. This is because

Re: [PATCH RFC 06/10] image: image-sig.c: Remove crypto_algos array

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 13:46, Alexandru Gagniuc wrote: > > Crytographic algorithms (currently RSA), are stored in linker lists. > The crypto_algos array is unused, so remove it, and any logic > associated with it. > > Signed-off-by: Alexandru Gagniuc > --- > common/image-sig.c | 13

Re: [PATCH RFC 01/10] common: Move host-only logic in image-sig.c to separate file

2021-05-15 Thread Simon Glass
Hi Alexandru, On Fri, 14 May 2021 at 13:46, Alexandru Gagniuc wrote: > > image-sig.c is used to map a hash or crypto algorithm name to a > handler of that algorithm. There is some similarity between the host > and target variants, with the differences worked out by #ifdefs. The > purpose of this

Re: [PATCH RFC 02/10] common: image-sig.c: Remove host-specific logic and #ifdefs

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 13:46, Alexandru Gagniuc wrote: > > Remove any ifdefs in image-sig.c that were previously used to > differentiate from the host code. Note that all code dedicated to > relocating ->sign() and ->add_verify_data)_ can be safely removed, > as signing is not supported

Re: [PATCH RFC 04/10] [UNTESTED] image: Add support for relocating crypto_algos in linker lists

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 13:46, Alexandru Gagniuc wrote: > > Function pointers from crypto_algos array are relocated, when > NEEDS_MANUAL_RELOC is set. This relocation doesn't happen if the algo > is placed in a linker list. Implement this relocation. > > Signed-off-by: Alexandru Gagniuc > --- >

Re: [PATCH] hash: Kconfig option for SHA512 hardware acceleration

2021-05-15 Thread Simon Glass
Hi Heinrich, On Fri, 14 May 2021 at 03:17, Heinrich Schuchardt wrote: > > Commit a479f103dc1c ("hash: Allow for SHA512 hardware implementations") > defined function definitions for hardware accelerated SHA384 and SHA512. > If CONFIG_SHA_HW_ACCEL=y, these functions are used. > > We already have

Re: [PATCH RFC 03/10] image: Add support for placing crypto_algo in linker lists

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 13:46, Alexandru Gagniuc wrote: > > The purpose of this change is to enable crypto algorithms to be placed > in linker lists, rather than be declared as a static array. The goal > is to remove the crypto_algos array in a subsequent patch. > > Create a new linker list named

Re: [PATCH 1/1] hash: revert Allow for SHA512 hardware implementations

2021-05-15 Thread Simon Glass
Hi Heinrich, On Wed, 12 May 2021 at 11:01, Heinrich Schuchardt wrote: > > We don't have a hardware implementation of SHA384 and SHA512 for any board. > > We don't expect to ever have a hardware implementation for ALL boards that > have a hardware implementation for SHA1 and SHA512. So we cannot

Re: [PATCH] dm: core: fix no null pointer detection in ofnode_get_addr_size_index()

2021-05-15 Thread Simon Glass
On Thu, 13 May 2021 at 01:38, chenguanqiao wrote: > > From: Chen Guanqiao > > Fixed a defect of a null pointer being discovered by Coverity Scan: >CID 331544: Null pointer dereferences (REVERSE_INULL) >Null-checking "size" suggests that it may be null, but it has already been >

Re: [PATCH v2 16/50] image: Add Kconfig options for FIT in the host build

2021-05-15 Thread Simon Glass
Hi Alex, On Fri, 14 May 2021 at 09:12, Alex G. wrote: > > > > On 5/13/21 6:56 PM, Simon Glass wrote: > > Hi Alex, > > > > On Thu, 13 May 2021 at 10:21, Alex G. wrote: > >> > >> > >> > >> On 5/12/21 12:30 PM, Simon Glass wrote: > >>> Hi Alex, > >>> > >>> On Wed, 12 May 2021 at 10:18, Alex G.

Re: [PATCH v2 37/50] image: Drop IMAGE_ENABLE_SIGN/VERIFY defines

2021-05-15 Thread Simon Glass
Hi Alex, On Fri, 14 May 2021 at 15:17, Alex G. wrote: > > > > On 5/14/21 3:44 PM, Simon Glass wrote: > > Hi Alex, > > > > On Fri, 14 May 2021 at 14:38, Alex G. wrote: > >> > >> > >> > >> On 5/6/21 9:24 AM, Simon Glass wrote: > >>> Add host Kconfigs for FIT_SIGN and RSA_VERIFY. With these we can

Re: [PATCH 2/2] phy: meson-axg-mipi: Access parent ofnode through dev_ofnode()

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 14:54, Alper Nebi Yasak wrote: > > With commit 84a42ae36683 ("dm: core: Rename device node to indicate it > is private") and commit f10643cf8a4c ("dm: core: Access device ofnode > through functions") accesses to the "node" member were replaced with > dev_ofnode(). Also

Re: [PATCH RFC 08/10] lib: rsa: Remove #ifdefs from rsa.h

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 13:46, Alexandru Gagniuc wrote: > > It is no longer necessary to implement rsa_() functions as no-ops > depending on config options. It is merely sufficient to provide the > prototypes, as the rsa code is no longer linked when unused. > > Signed-off-by: Alexandru Gagniuc >

Re: [PATCH v2 47/50] image: Remove some #ifdefs from image-fit and image-fit-sig

2021-05-15 Thread Simon Glass
Hi Alex, On Fri, 14 May 2021 at 15:50, Alex G. wrote: > > > > On 5/6/21 9:24 AM, Simon Glass wrote: > > Drop the #ifdefs which are easy to remove without refactoring. > > > > Signed-off-by: Simon Glass > > --- > > > > (no changes since v1) > > > > common/Kconfig.boot| 10 ++ > >

Re: [PATCH RFC 10/10] image: Eliminate IMAGE_ENABLE_VERIFY_ECDSA macro

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 13:46, Alexandru Gagniuc wrote: > > This macro is no longer needed for code flow or #ifdefs. Remove it. > > Signed-off-by: Alexandru Gagniuc > --- > include/image.h | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH RFC 09/10] image: Eliminate IMAGE_ENABLE_VERIFY macro

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 13:46, Alexandru Gagniuc wrote: > > This macro is no longer needed for code flow or #ifdefs. Remove it. > > Signed-off-by: Alexandru Gagniuc > --- > include/image.h | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH RFC 07/10] lib: ecdsa: Remove #ifdefs from ecdsa.h

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 13:46, Alexandru Gagniuc wrote: > > It is no longer necessary to implement ecdsa_() functions as no-ops > depending on config options. It is merely sufficient to provide the > prototypes, as the ecdsa code is no longer linked when unused. > > Signed-off-by: Alexandru

Re: [PATCH 1/1] sandbox: fix sandbox_reset()

2021-05-15 Thread Simon Glass
On Wed, 12 May 2021 at 10:39, Heinrich Schuchardt wrote: > > state_uninit() and dm_uninit() are mutually exclusive: > > state_uninit() prints via drivers. So it cannot be executed after > dm_uninit(). > > dm_uninit() requires memory. So it cannot be executed after state_uninit() > which releases

Re: [PATCH 2/2] firmware: scmi: fix sandbox and related test since clock discovery

2021-05-15 Thread Simon Glass
On Wed, 12 May 2021 at 08:55, Etienne Carriere wrote: > > Since SCMI clock are discovered because of integration in the CCF, > update SCMI emulation in sandbox accordingly. Sandbox must emulate all > clocks exposed by SCMI server since CCF clock discovery will query all > of them even if some

Re: [PATCH 1/2] clk: scmi: register all scmi clock by name with CCF

2021-05-15 Thread Simon Glass
Hi, On Wed, 12 May 2021 at 08:55, Etienne Carriere wrote: > > From: Patrick Delaunay > > This patch implements SCMI APIs to retrieve the number and the name of > SCMI clocks using SCMI_PROTOCOL_ATTRIBUTES messages. > > Signed-off-by: Gabriel Fernandez > Signed-off-by: Patrick Delaunay >

Re: [PATCH 21/27] ppc: Remove sbc8641d board

2021-05-15 Thread Simon Glass
Hi Tom, On Fri, 14 May 2021 at 20:48, Tom Rini wrote: > > This board has not been converted to CONFIG_DM_PCI by the deadline and is > also missing conversion to CONFIG_DM. Remove it. This is also the last > of the ARCH_MPC8641/MPC8610 platforms, so remove that support as well. > > Cc: Paul

Re: [PATCH 1/1] sandbox: ensure that state->ram_buf is in low memory

2021-05-15 Thread Simon Glass
Hi Heinrich, On Fri, 14 May 2021 at 18:34, Heinrich Schuchardt wrote: > > Am 14. Mai 2021 22:44:32 MESZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Fri, 14 May 2021 at 00:11, Heinrich Schuchardt > >wrote: > >> > >> On 5/14/21 1:56 AM, Simon Glass wrote: > >> > Hi Heinrich, > >> > > >> > On

Re: [PATCH 1/2] phy: meson-axg-mipi: Rename "priv_auto_alloc_size" to "priv_auto"

2021-05-15 Thread Simon Glass
On Fri, 14 May 2021 at 14:54, Alper Nebi Yasak wrote: > > With commit 41575d8e4c33 ("dm: treewide: Rename auto_alloc_size members > to be shorter") "priv_auto_alloc_size" was renamed to "priv_auto". Apply > the rename to these two drivers as well. > > Fixes: 4547551aa019 ("phy: Add Amlogic AXG

Re: [PATCH] ARM: integrator: Drop PCI support

2021-05-15 Thread Tom Rini
On Sat, May 15, 2021 at 02:44:19PM +0200, Linus Walleij wrote: > We didn't convert the Integrator to use DM for PCI in > time, and we don't use it either so let's just drop > PCI support from the Integrator. > > Signed-off-by: Linus Walleij Thanks! Reviewed-by: Tom Rini -- Tom

[PATCH] ARM: integrator: Drop PCI support

2021-05-15 Thread Linus Walleij
We didn't convert the Integrator to use DM for PCI in time, and we don't use it either so let's just drop PCI support from the Integrator. Signed-off-by: Linus Walleij --- board/armltd/integrator/Makefile| 1 - board/armltd/integrator/integrator.c| 1 -

[BUG] [PATCH v2 1/3] cmd: fs: Use part_get_info_by_dev_and_name_or_num to parse partitions

2021-05-15 Thread Heinrich Schuchardt
On 4/13/21 12:53 AM, Sean Anderson wrote: This allows using dev#partlabel syntax. Signed-off-by: Sean Anderson Since this patch was merged as commit 7194527b the command 'ls host' leads to a segmentation violation: => host bind 0 ../sandbox.img => setenv bootdevice 0:1 => ls host

Re: [PATCH 03/27] arm: Remove integratorap* boards

2021-05-15 Thread Linus Walleij
On Sat, May 15, 2021 at 3:34 AM Tom Rini wrote: > These boards have not been converted to CONFIG_DM_PCI by the deadline. > Remove them. > > Cc: Linus Walleij > Signed-off-by: Tom Rini > --- > I haven't fully streamlined things for integatorcp-only, in case you > wish to do the DM_PCI migration

Re: [PULL] u-boot-sh/master

2021-05-15 Thread Tom Rini
On Fri, May 14, 2021 at 10:15:08PM +0200, Marek Vasut wrote: > The following changes since commit 59a2b9e605c5a5e2dff35506a13b51f33d3051b4: > > Merge tag 'u-boot-imx-20210502' of > https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2021-05-11 12:23:11 > -0400) > > are available in the Git

Re: [PULL u-boot] Please pull u-boot-amlogic-20210514

2021-05-15 Thread Tom Rini
On Fri, May 14, 2021 at 05:58:03PM +0200, Neil Armstrong wrote: > Hi Tom, > > please find a few dwmac meson8b glue fixes, dwc3 meson-g12a probe fix and the > missing stuff > to have HDMI working on the Beelink GTKing/King-Pro boards. > > The CI job is at >

Re: [PULL] u-boot-riscv/master

2021-05-15 Thread Tom Rini
On Fri, May 14, 2021 at 07:10:10PM +0800, Leo Liang wrote: > Hi Tom, > > CI result: > https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/7504 > > The following changes since commit 530c8d4af2e18c6142ab7cac6f11dd92c02b2bc9: > > Merge branch >

Re: Please pull u-boot-marvell/master

2021-05-15 Thread Tom Rini
On Sat, May 15, 2021 at 10:03:29AM +0200, Stefan Roese wrote: > Hi Tom, > > On 13.05.21 17:37, Tom Rini wrote: > > On Thu, May 13, 2021 at 12:21:38PM +0200, Stefan Roese wrote: > > > > > Hi Tom, > > > > > > please pull the next batch of Marvell Armada related patches. Here the > > > summary

[PATCH 1/1] doc: man-page for size command

2021-05-15 Thread Heinrich Schuchardt
Provide a man-page for the size command. Signed-off-by: Heinrich Schuchardt --- doc/usage/index.rst | 1 + doc/usage/size.rst | 40 2 files changed, 41 insertions(+) create mode 100644 doc/usage/size.rst diff --git a/doc/usage/index.rst

Re: Please pull u-boot-marvell/master

2021-05-15 Thread Stefan Roese
Hi Tom, On 13.05.21 17:37, Tom Rini wrote: On Thu, May 13, 2021 at 12:21:38PM +0200, Stefan Roese wrote: Hi Tom, please pull the next batch of Marvell Armada related patches. Here the summary log: - Add base support for