Re: [PATCH v2 0/9] efi_loader: capsule: improve capsule authentication support

Heinrich, On Sun, Aug 01, 2021 at 11:40:14AM +0200, Heinrich Schuchardt wrote: > On 7/27/21 11:10 AM, AKASHI Takahiro wrote: > > As I proposed and discussed in [1] and [2], I have made a couple of > > improvements on the current implementation of capsule update in this > > patch set. > > > > *

Re: [PATCH v2 4/9] efi_loader: ease the file path check for public key

On Sun, Aug 01, 2021 at 11:35:15AM +0200, Heinrich Schuchardt wrote: > On 7/27/21 11:10 AM, AKASHI Takahiro wrote: > > The check for CONFIG_EFI_CAPSULE_KEY_PATH: > > ifeq ("$(wildcard $(EFI_CAPSULE_KEY_PATH))","") > > does not allow users to specify a relative path for including a public > >

Re: [PATCH v2 5/9] test/py: efi_capsule: add image authentication test

On Sun, Aug 01, 2021 at 11:38:16AM +0200, Heinrich Schuchardt wrote: > On 7/27/21 11:10 AM, AKASHI Takahiro wrote: > > Add a couple of test cases against capsule image authentication > > for capsule-on-disk, where only a signed capsule file with the verified > > signature will be applied to the

[PATCH] ARM: omap3: evm: Enable booting 'fitImage' with DEFAULT_FIT_TI_ARGS

This commit uses the existing DEFAULT_MMC_TI_ARGS and DEFAULT_FIT_TI_ARGS defintions to replace the 'mmc*' environment variables in the configuration. The check for the 'boot_fit' is handled like the 'am335x_*' boards with 'CONFIG_BOOTCOMMAND'. Signed-off-by: Derald D. Woods ---

Re: [PATCH v2 1/9] tools: mkeficapsule: add firmwware image signing

Heinrich, On Sun, Aug 01, 2021 at 11:21:55AM +0200, Heinrich Schuchardt wrote: > On 7/27/21 11:10 AM, AKASHI Takahiro wrote: > > With this enhancement, mkeficapsule will be able to sign a capsule > > file when it is created. A signature added will be used later > > in the verification at FMP's

Re: [PATCH 1/2] x86: queensbay: Optimize disable_igd() a little

Hi Simon, On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > Hi Bin, > > On Sat, 31 Jul 2021 at 07:17, Bin Meng wrote: > > > > Initialize igd and sdvo to NULL so that we don't need to test the > > return value of dm_pci_bus_find_bdf() later. > > > > Signed-off-by: Bin Meng > > --- > > > >

Re: [PATCH v2 02/32] ppc: Remove UCP1020 board

On Sun, Aug 01, 2021 at 06:54:15PM -0600, Simon Glass wrote: > This board has not been converted to CONFIG_DM_PCI by the deadline. > Remove it. > > Leave the Kconfig options to avoid warnings on other boards. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Update to mention DM_PCI

Re: [PATCH 7/7] x86: fsp: Only FSP2 has INIT_PHASE_END_FIRMWARE

Hi Simon, On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > Hi Bin, > > On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > > > For FSP1, there is no such INIT_PHASE_END_FIRMWARE. > > > > Fixes: 7c73cea44290 ("x86: Notify the FSP of the 'end firmware' event") > > Signed-off-by: Bin Meng > >

Re: [PATCH 1/7] x86: fsp: Don't program MTRR for DRAM

Hi Simon, On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > Hi Bin, > > On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > > > This actually reverts the following 2 commits: > > > > commit 427911001809 ("x86: Set up the MTRR for SDRAM") > > commit d46c0932a9d4 ("x86: fsp: Adjust calculations

Re: [PATCH 6/7] x86: cmd: hob: Fix display of resource type for system memory

On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > > > The resource type for system memory is currently displayed as > > "unknown", which is wrong. > > > > Fixes: 51af144eb7a0 ("x86: Allow showing details about a HOB entry") > > Signed-off-by:

Re: [PATCH 5/7] x86: cmd: hob: Fix the command usage and help messages

On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > > > At present the hob command usage and help messages are messed up > > in a single line. They should be separated. > > > > This was a regression introduced when [seq] and [-v] were added > >

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

Hi Walter, On Sun, 1 Aug 2021 at 20:45, Walter Lozano wrote: > > Hi Simon, > > Thanks for checking this bug, I'm glad that you were able to come with > fix quickly. I have some questions, I hope that you find some time to > help me understand. > > On 7/28/21 10:23 PM, Simon Glass wrote: > > The

Re: [PATCH 4/7] x86: mtrr: Abort if requested size is not power of 2

On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > > > The size parameter of mtrr_add_request() and mtrr_set_next_var() > > shall be power of 2, otherwise the logic creates a mask that does > > not meet the requirement of IA32_MTRR_PHYSMASK

Re: [PATCH 2/3] dtoc: Fix widening an int array to an int

Hi Walter, On Sun, 1 Aug 2021 at 20:45, Walter Lozano wrote: > > Hi Simon, > > I know you already merged this one but I have some doubts I would like > to check with you. > > On 7/28/21 10:23 PM, Simon Glass wrote: > > An int array can hold a single int so we should not need to do anything > >

Re: [PATCH 3/7] x86: mtrr: Skip MSRs that were already programmed in mtrr_commit()

On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > > > At present mtrr_commit() programs the MTRR MSRs starting from > > index 0, which may overwrite MSRs that were already programmed > > by previous boot stage or FSP. > > > > Switch to call

Re: [PATCH 2/7] x86: mtrr: Do not clear the unused ones in mtrr_commit()

On Mon, Aug 2, 2021 at 3:19 AM Simon Glass wrote: > > On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > > > Current mtrr_commit() logic assumes that MTRR MSRs are programmed > > consecutively from index 0 to its maximum number, and whenever it > > detects an unused one, it clears all other MTRRs

Re: [PATCH] Revert "efi_capsule: Move signature from DTB to .rodata"

Hi Ilias, On Sun, 1 Aug 2021 at 20:28, Ilias Apalodimas wrote: > > Hi Simon, > > On Sun, Aug 01, 2021 at 07:46:21PM -0600, Simon Glass wrote: > > This was unfortunately applied despite much discussion about it being > > the wrong way to implement this feature. > > No this was applied *before*

Re: [PATCH 2/3] dtoc: Fix widening an int array to an int

Hi Simon, I know you already merged this one but I have some doubts I would like to check with you. On 7/28/21 10:23 PM, Simon Glass wrote: An int array can hold a single int so we should not need to do anything in the widening operation. However due to a quirk in the code, an int[3] widened

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

Hi Simon, Thanks for checking this bug, I'm glad that you were able to come with fix quickly. I have some questions, I hope that you find some time to help me understand. On 7/28/21 10:23 PM, Simon Glass wrote: The current name is confusing because the logic is actually backwards from what

Re: [PATCH] Revert "efi_capsule: Move signature from DTB to .rodata"

Hi Simon, On Sun, Aug 01, 2021 at 07:46:21PM -0600, Simon Glass wrote: > This was unfortunately applied despite much discussion about it being > the wrong way to implement this feature. No this was applied *before* the discussion, not despite. > > Revert it before too many other things are

[PATCH] Revert "efi_capsule: Move signature from DTB to .rodata"

This was unfortunately applied despite much discussion about it being the wrong way to implement this feature. Revert it before too many other things are built on top of it. This reverts commit ddf67daac39de76d2697d587148f4c2cb768f492. Signed-off-by: Simon Glass ---

[PATCH v5 11/12] vpl: Add Kconfig options for VPL

Add VPL versions of commonly used Kconfig options. Signed-off-by: Simon Glass --- Changes in v5: - Rebase this patch on mainline (for GPIO and MISC Kconfig renames) Changes in v4: - Add options for blk, core, misc and tpl also - Add VPL_SIZE_LIMIT Kconfig | 10 ++

[PATCH v3 4/5] treewide: Use 16-bit unicode strings

At present we use wide characters for unicode but this is not necessary. Change the code to use the 'u' literal instead. This helps to fix build warnings for sandbox on rpi. Note: This applies tree-wide Signed-off-by: Simon Glass --- Changes in v3: - Add a new patch to change non-EFI

[PATCH v2 23/32] pci: arm: mvebu: Drop DM_PCI check from

We don't need this check anymore since when PCI is enabled, driver model is always used. Use CONFIG_PCI instead. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/mach-mvebu/arm64-common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v3 1/5] checkpatch: Support wide strings

From: Joe Perches Allow prefixing typical strings with L for wide strings and u for unicode strings. Signed-off-by: Joe Perches Signed-off-by: Simon Glass --- This was found on LKML: https://lore.kernel.org/lkml/1508280192.6530.31.ca...@perches.com/T/ It likely wasn't applied because it did

[PATCH v2 31/32] pci: Drop DM_PCI

This option has not effect now. Drop it, using PCI instead where needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/Kconfig | 1 - arch/arm/Kconfig | 2 +- arch/arm/mach-imx/mx6/Kconfig| 2 +- arch/mips/Kconfig

[PATCH v2 30/32] pci: Drop PCI_INDIRECT_BRIDGE

This does not work with driver model so can be removed. Signed-off-by: Simon Glass --- (no changes since v1) README | 3 -- drivers/pci/Makefile| 1 - drivers/pci/pci_indirect.c | 71 -

[PATCH v2 26/32] pci: Drop pci_init_board()

With the conversion to driver model, this is not needed now. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) board/cavium/thunderx/thunderx.c | 7 -- board/freescale/mpc8349emds/pci.c| 73 -- board/freescale/mpc837xerdb/Makefile | 1 -

[PATCH v2 32/32] pci: Drop migration method

Migration is complete. Drop the message. Signed-off-by: Simon Glass --- (no changes since v1) doc/develop/driver-model/migration.rst | 9 - 1 file changed, 9 deletions(-) diff --git a/doc/develop/driver-model/migration.rst b/doc/develop/driver-model/migration.rst index

[PATCH v3 2/5] efi: Use 16-bit unicode strings

At present we use wide characters for unicode but this is not necessary. Change the code to use the 'u' literal instead. This helps to fix build warnings for sandbox on rpi. Signed-off-by: Simon Glass Suggested-by: Heinrich Schuchardt Reviewed-by: Heinrich Schuchardt --- Changes in v3: -

[PATCH v2 20/32] pci: Drop DM_PCI check from bios_emul

We don't need these checks anymore since when PCI is enabled, driver model is always used. Drop them. Signed-off-by: Simon Glass --- (no changes since v1) drivers/bios_emulator/atibios.c | 98 - drivers/bios_emulator/bios.c| 39 -

[PATCH v2 24/32] pci: sata_sil: Drop DM_PCI checks

We don't need these checks anymore since when PCI is enabled, driver model is always used. Drop them. Signed-off-by: Simon Glass --- (no changes since v1) drivers/ata/sata_sil.c | 8 drivers/ata/sata_sil.h | 4 2 files changed, 12 deletions(-) diff --git

[PATCH v2 25/32] distro_bootcmd: Drop DM_PCI check

We don't need this check anymore since when PCI is enabled, driver model is always used. Signed-off-by: Simon Glass --- (no changes since v1) include/config_distro_bootcmd.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/config_distro_bootcmd.h

[PATCH v2 21/32] net: Drop DM_PCI check from designware driver

We don't need this check anymore since when PCI is enabled, driver model is always used. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/net/designware.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git

[PATCH v2 22/32] pci: imx: Drop DM_PCI check from cpu driver

We don't need this check anymore since when PCI is enabled, driver model is always used. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/mach-imx/cpu.c | 4 include/pci.h | 4 2 files changed, 8 deletions(-) diff --git a/arch/arm/mach-imx/cpu.c

[PATCH v2 29/32] ppc: Drop t4qds and b4860qds references

These boards have been removed. Drop the config file and other references. Signed-off-by: Simon Glass --- (no changes since v1) .azure-pipelines.yml | 4 +- doc/board/freescale/b4860qds.rst | 453 --- doc/board/freescale/index.rst| 1 -

[PATCH v2 09/32] pci: freescale: Drop old code

Drop this old pre-driver model code. Signed-off-by: Simon Glass --- (no changes since v1) board/freescale/common/cds_pci_ft.c | 59 -- board/freescale/common/p_corenet/Makefile | 1 - board/freescale/common/p_corenet/pci.c | 25 -

[PATCH v2 28/32] ppc: Drop idt8t49n222a_serdes_clk driver

This is not used. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) board/freescale/common/Makefile | 1 - .../common/idt8t49n222a_serdes_clk.c | 208 -- .../common/idt8t49n222a_serdes_clk.h | 106 - 3 files changed, 315

[PATCH v2 08/32] pci: powerpc: Drop old code

Drop the old pre-driver model code from these drivers. Signed-off-by: Simon Glass --- (no changes since v1) arch/powerpc/cpu/mpc83xx/pci.c| 160 - arch/powerpc/cpu/mpc85xx/Makefile | 1 - arch/powerpc/cpu/mpc85xx/pci.c| 191 -- 3

[PATCH v2 27/32] pci: ppc: Drop ftpci100 driver

This is not used in U-Boot at present. Drop it and related config options. Signed-off-by: Simon Glass --- (no changes since v1) arch/nds32/include/asm/arch-ag102/ag102.h | 2 - drivers/pci/Makefile | 1 - drivers/pci/pci_ftpci100.c| 319

[PATCH v2 12/32] pci: acpi: Drop DM_PCI check from ahci

We don't need these checks anymore since when PCI is enabled, driver model is always used. Drop them. Signed-off-by: Simon Glass --- (no changes since v1) drivers/ata/ahci.c | 55 -- include/ahci.h | 4 2 files changed, 59 deletions(-)

[PATCH v3 5/5] RFC: treewide: Drop -fshort-char

Now that we use the 'u' prefix on unicode strings we don't need this option. Drop it. Note: This doesn't actually work and throws lots of warnings. Signed-off-by: Simon Glass --- (no changes since v1) Makefile | 2 +- arch/arm/config.mk| 2 +- arch/x86/config.mk| 2 +-

[PATCH v2 14/32] ppc: malta: Drop use of DM_PCI

Now that DM_PCI is always enabled we don't need to check it. Drop this old code. Signed-off-by: Simon Glass --- Changes in v2: - Fix tag to 'mips' from 'ppc' board/imgtec/malta/malta.c | 67 -- 1 file changed, 67 deletions(-) diff --git

[PATCH v2 10/32] pci: dm: core: Drop DM_PCI check from devfdt_get_addr_pci()

We don't need this check anymore since when PCI is enabled, driver model is always used. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/fdtaddr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/core/fdtaddr.c b/drivers/core/fdtaddr.c index

[PATCH v2 2/3] doc: Update devicedocs including how to add tweaks

This file is about 10 years old and the updates have not covered everything that has changed, particularly in the last few years. Update the information and add mention of the u-boot.dtsi files. Signed-off-by: Simon Glass --- Changes in v2: - Update many, many things as suggested by Heinrich

[PATCH v2 1/3] doc: Move devicetree control doc to rST

Move this to rST format, largely unchanged to start with. Add an index for this topic, as well as an empty intro. Note this patch does not include updates! Is it just a conversion to the new format. See the next patch. Signed-off-by: Simon Glass --- Changes in v2: - Add a comment about updates

[PATCH v2 3/3] doc: Add a note about why devicetree is used

This question comes up every now and then with people coming from Linux. Add some notes about it so we can point to it in the mailing list. Signed-off-by: Simon Glass --- Changes in v2: - Updates based on suggestions from Heinrich doc/develop/devicetree/control.rst | 2 ++

[PATCH v3 3/5] sandbox: Detect the host bit size automatically

At present if you build sandbox on a 32-bit host a lot of errors are produced. This is because CONFIG_HOST_64BIT is enabled by default. It is quite annoying to have to change that manually before building sandbox. It is also quite confusing for new users. Add a way to detect the setting and add

[PATCH v3 0/5] Fix compiler warnings for 32-bit ARM

These were noticed when building sandbox on a Raspberry Pi 400, which uses 32-bit linux. To make this work, I enabled CONFIG_HOST_32BIT in 'make menuconfig'. It would be nice if that were automatic, since we have the logic already in arch/sandbox/config.mk So this series adds that. It also

[PATCH v2 19/32] pci: scsi: pci: Drop DM_PCI check from scsi

We don't need this check anymore since when PCI is enabled, driver model is always used. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/scsi/scsi.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index

[PATCH v2 18/32] pci: imx: Drop use of DM_PCI

Now that DM_PCI is always enabled we don't need to check it. Drop this old code. Signed-off-by: Simon Glass --- (no changes since v1) drivers/pci/pcie_imx.c | 81 -- 1 file changed, 81 deletions(-) diff --git a/drivers/pci/pcie_imx.c

[PATCH v2 11/32] ppc: Drop DM_PCI from config files

Now that DM_PCI is always enabled we don't need to check it. Drop this old code. Signed-off-by: Simon Glass --- (no changes since v1) include/configs/MPC8548CDS.h | 16 include/configs/P1010RDB.h | 28 include/configs/P2041RDB.h | 17

[PATCH v2 17/32] pci: msc01: Drop use of DM_PCI

Now that DM_PCI is always enabled we don't need to check it. Drop this old code. Signed-off-by: Simon Glass --- (no changes since v1) drivers/pci/pci_msc01.c | 64 - 1 file changed, 64 deletions(-) diff --git a/drivers/pci/pci_msc01.c

[PATCH v2 16/32] pci: gt64120: Drop use of DM_PCI

Now that DM_PCI is always enabled we don't need to check it. Drop this old code. Signed-off-by: Simon Glass --- (no changes since v1) drivers/pci/pci_gt64120.c | 64 --- 1 file changed, 64 deletions(-) diff --git a/drivers/pci/pci_gt64120.c

[PATCH v2 15/32] ppc: socrates: Drop use of DM_PCI

Now that DM_PCI is always enabled we don't need to check it. Drop this old code. Signed-off-by: Simon Glass --- (no changes since v1) board/socrates/socrates.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/board/socrates/socrates.c b/board/socrates/socrates.c index

[PATCH v2 13/32] pci: usb: Drop DM_PCI from ohci

Now that DM_PCI is always enabled we don't need to check it. Drop this old condition and update the comment. Signed-off-by: Simon Glass --- (no changes since v1) drivers/usb/host/ohci-hcd.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

On 7/29/21 6:58 PM, Tom Rini wrote: [...] so when did rcar3 introduce something there that shouldn't be reserved? And you had phrased this to me on IRC as about reserving spot for ATAGS, and that not being needed of course on arm64. But that's not what's going on. Perhaps the answer is that

[PATCH v2 06/32] pci: Drop DM_PCI check from pci_common

We don't need this check anymore since when PCI is enabled, driver model is always used. Signed-off-by: Simon Glass --- (no changes since v1) drivers/pci/pci_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci_common.c b/drivers/pci/pci_common.c

[PATCH v2 07/32] ppc: Drop CONFIG_SYS_PCI_SUBSYS_VENDORID

This is not used. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) include/configs/MPC8349EMDS.h | 1 - include/configs/MPC8349EMDS_SDRAM.h | 1 - include/configs/MPC837XERDB.h | 1 - include/configs/MPC8540ADS.h| 1 - include/configs/MPC8560ADS.h| 1 -

[PATCH v2 02/32] ppc: Remove UCP1020 board

This board has not been converted to CONFIG_DM_PCI by the deadline. Remove it. Leave the Kconfig options to avoid warnings on other boards. Signed-off-by: Simon Glass --- Changes in v2: - Update to mention DM_PCI instead board/Arcturus/ucp1020/Kconfig | 28 +-

[PATCH v2 05/32] pci: Drop DM_PCI check from fdtdec

We don't need this check anymore since when PCI is enabled, driver model is always used. Sadly this doesn't work with nds32 for some reason to do with the toolchain. Add a work-around for that. Signed-off-by: Simon Glass --- (no changes since v1) lib/fdtdec.c | 10 -- 1 file changed,

[PATCH v2 04/32] pci: Remove guard around compatibility functions

This prevents use of IS_ENABLED() in other files. Functions should be visible in headers even if they are not available at link time. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) include/pci.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH v2 03/32] pci: Drop old code from header file

We don't need this code anymore since when PCI is enabled, driver model is always used. Signed-off-by: Simon Glass --- (no changes since v1) include/pci.h | 60 +++ 1 file changed, 3 insertions(+), 57 deletions(-) diff --git a/include/pci.h

[PATCH v2 00/32] pci: Drop all pre-driver model code

The hard work to actually enable DM_PCI everywhere was done recently. This series attempts to drop most of the code that it no-longer needed now that PCI has been converted to driver model. It also drops the UCP1020 board since it has various unique build issues. It doesn't even support driver

[PATCH v2 01/32] pci: Drop old code from pci command

Drop the pre-driver model code from this file. Signed-off-by: Simon Glass --- (no changes since v1) cmd/pci.c | 212 -- 1 file changed, 212 deletions(-) diff --git a/cmd/pci.c b/cmd/pci.c index e53b7c858c6..8cfa5bbdaa7 100644 ---

Re: [PATCH v2 4/5] efi: Use 16-bit unicode strings

Hi Tom, On Sun, 1 Aug 2021 at 17:46, Tom Rini wrote: > > On Sun, Aug 01, 2021 at 04:54:49PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Sat, 31 Jul 2021 at 21:28, Tom Rini wrote: > > > > > > On Sun, Jul 18, 2021 at 09:36:42PM -0400, Tom Rini wrote: > > > > On Mon, Jul 19, 2021 at

Re: [PATCH 1/3 v2] efi_capsule: Move signature from DTB to .rodata

Hi, On Thu, 22 Jul 2021 at 14:54, Ilias Apalodimas wrote: > > Hi Simon, > > On Thu, Jul 22, 2021 at 10:46:40AM -0600, Simon Glass wrote: > > > > > > > >> In some platforms the key is derived from the relocated DTB, > > > > > > > >> which we > > [...] > > > > > > > > >> can overwrite. But I'll

Re: [PATCH v2 4/5] efi: Use 16-bit unicode strings

On Sun, Aug 01, 2021 at 04:54:49PM -0600, Simon Glass wrote: > Hi Tom, > > On Sat, 31 Jul 2021 at 21:28, Tom Rini wrote: > > > > On Sun, Jul 18, 2021 at 09:36:42PM -0400, Tom Rini wrote: > > > On Mon, Jul 19, 2021 at 03:07:50AM +0200, Heinrich Schuchardt wrote: > > > > On 7/19/21 3:01 AM, Tom

Re: [PATCH v3 2/7] mmc: sdhci: Change prototype of set_delay to return errors

On 7/30/21 9:28 PM, Ashok Reddy Soma wrote: > set_delay() has return type as void. If there are any errors while > setting tapdelay's it won't be able to return them. > > Change the prototype of set_delay() in sdhci_ops structure and return > the errors from wherever it is called. > >

Re: [PATCH v3 1/7] mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay

On 7/30/21 9:28 PM, Ashok Reddy Soma wrote: > Change return type of arasan_sdhci_set_tapdelay() to int, to facilitate > returning errors. Get return values from input and output set clock phase > functions inside arasan_sdhci_set_tapdelay() and return those errors. > > Signed-off-by: T Karthik

Re: [PATCH] btrfs: Use default subvolume as filesystem root

On 2021/8/2 上午4:52, Matwey V. Kornilov wrote: BTRFS volume consists of a number of subvolumes which can be mounted separately from each other. The top-level subvolume always exists even if no subvolumes were created manually. A subvolume can be denoted as the default subvolume i.e. the

Re: [PATCH v2 6/9] sandbox: add config for efi capsule authentication test

Simon, On Sun, Aug 01, 2021 at 01:00:20PM -0600, Simon Glass wrote: > Hi Takahiro, > > On Sat, 31 Jul 2021 at 22:29, AKASHI Takahiro > wrote: > > > > Simon, > > > > On Sat, Jul 31, 2021 at 10:59:32AM -0600, Simon Glass wrote: > > > Hi Takahiro, > > > > > > On Tue, 27 Jul 2021 at 03:12, AKASHI

Re: [PATCH v2 4/5] efi: Use 16-bit unicode strings

Hi Tom, On Sat, 31 Jul 2021 at 21:28, Tom Rini wrote: > > On Sun, Jul 18, 2021 at 09:36:42PM -0400, Tom Rini wrote: > > On Mon, Jul 19, 2021 at 03:07:50AM +0200, Heinrich Schuchardt wrote: > > > On 7/19/21 3:01 AM, Tom Rini wrote: > > > > On Mon, Jul 19, 2021 at 02:41:46AM +0200, Heinrich

Re: [PATCH] mkimage: clarify error message for empty input files

On Sun, Aug 1, 2021 at 3:23 PM Thomas Hebb wrote: > > Currently, an empty imput file causes `mmap()` to fail, and you get an Whoops, s/imput/input/. Didn't catch this before sending it out. > error like "mkimage: Can't read file.img: Invalid argument", which is > extremely unintuitive and hard

[PATCH] mkimage: clarify error message for empty input files

Currently, an empty imput file causes `mmap()` to fail, and you get an error like "mkimage: Can't read file.img: Invalid argument", which is extremely unintuitive and hard to diagnose if you don't know what to look for. Add an explicit check for an empty file and provide a clear error message

[PATCH] patman: Avoid blank lines between tags

In some cases 'patman status' leaves a blank line between the sign-off and the tags it collects from patchwork. Fix this and add a test. Signed-off-by: Simon Glass --- tools/patman/func_test.py | 23 ++- tools/patman/patchstream.py | 7 ++- 2 files changed, 28

Re: [PATCH v3 00/16] misc: Some more misc patches

Hi Bin, On Thu, 15 Jul 2021 at 05:51, Bin Meng wrote: > > Hi Simon, > > On Wed, Jul 14, 2021 at 11:47 PM Simon Glass wrote: > > > > Hi Bin, > > > > On Sun, 27 Jun 2021 at 17:51, Simon Glass wrote: > > > > > > Various issues were discovered in getting Chromium OS verified boot > > > running on

Re: [PATCH v2] mmc: Add support for enumerating MMC card in a given mode using mmc command

Hi Aswath, On 7/30/21 9:26 PM, Aswath Govindraju wrote: > Add support for enumerating MMC card in a given mode using mmc rescan and > mmc dev commands. The speed mode is provided as the last argument in these > commands and is indicated using the index from enum bus_mode in > include/mmc.h. A

[PATCH 1/1] doc: add graphviz imagemagick as build dependencies

'make htmldocs' requires graphviz and imagemagick (at least with Sphinx 3.5.4). Signed-off-by: Heinrich Schuchardt --- doc/build/gcc.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/build/gcc.rst b/doc/build/gcc.rst index 8ffb4e3447..a596487612 100644 ---

Re: [PATCH] doc: board: Move j721e document to doc/board/ti/ directory

On Sun, Aug 01, 2021 at 11:10:43PM +0200, Heinrich Schuchardt wrote: > > > On 8/1/21 10:37 PM, Tom Rini wrote: > > On Sun, Aug 01, 2021 at 10:03:59PM +0200, Heinrich Schuchardt wrote: > > > Dear Kishon, > > > > > > your merged patch 8baeeecbe305 ("doc: board: Move j721e document to > > >

Re: [PATCH v3 01/15] lib: Add memdup()

On 8/1/21 11:00 PM, Simon Glass wrote: Add a function to duplicate a memory region, a little like strdup(). Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add a patch to introduce a memdup() function include/linux/string.h | 13 + lib/string.c

Re: [PATCH v2 3/4] sf: doc: Add documentation for the 'sf' command

Hi Heinrich, On Sun, 1 Aug 2021 at 13:56, Heinrich Schuchardt wrote: > > > > On 8/1/21 8:02 PM, Simon Glass wrote: > > This command is fairly complicated so documentation is useful. > > Unfortunately I an not sure how the MTD side of things works and cannot > > find information about that. > > >

Re: U-Boot zboot on x86-64 VirtualBox UEFI.

Hi Christian, On Sat, 26 Jun 2021 at 12:30, Simon Glass wrote: > > Hi Christian, > > On Fri, 11 Jun 2021 at 23:59, Christian Melki > wrote: > > > > On 6/11/21 3:40 PM, Simon Glass wrote: > > > +Heinrich Schuchardt > > > > > > Hi Christian, > > > > > > On Fri, 11 Jun 2021 at 07:30, Christian

[PATCH v3 4/4] sf: Provide a command to access memory-mapped SPI

Add a new 'sf mmap' function to show the address of a SPI offset, if the hardware supports it. This is useful on x86 systems. Signed-off-by: Simon Glass --- Changes in v3: - Add configuration and return value also arch/Kconfig | 2 ++ cmd/Kconfig | 8 ++ cmd/sf.c | 35

[PATCH v3 3/4] sf: doc: Add documentation for the 'sf' command

This command is fairly complicated so documentation is useful. Unfortunately I an not sure how the MTD side of things works and cannot find information about that. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Many fixes as suggested by Heinrich doc/usage/index.rst |

[PATCH v3 2/4] sf: Tidy up code to avoid #ifdef

Update this code to use IS_ENABLED() instead. Signed-off-by: Simon Glass --- (no changes since v1) cmd/sf.c | 32 ++-- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/cmd/sf.c b/cmd/sf.c index 46346fb9d43..d4f5ecee38c 100644 --- a/cmd/sf.c +++

[PATCH v3 1/4] command: Use a constant pointer for the help

This text should never change during execution, so it makes sense to use a const char * so that it can be declared as const in the code. Update struct cmd_tbl with a const char * pointer for 'help'. We cannot make usage const because of the bmode command, used on mx53ppd for example.

[PATCH v3 0/4] sf: Add documentation and an 'sf mmap' command

This little series adds documentation and a few other tidy-ups to the 'sf' command. It also provides a way to access memory-mapped SPI via the command line. Changes in v3: - Add configuration and return value also Changes in v2: - Explain why 'usage' cannot be const - Many fixes as suggested by

Re: [PATCH] doc: board: Move j721e document to doc/board/ti/ directory

On 8/1/21 10:37 PM, Tom Rini wrote: On Sun, Aug 01, 2021 at 10:03:59PM +0200, Heinrich Schuchardt wrote: Dear Kishon, your merged patch 8baeeecbe305 ("doc: board: Move j721e document to doc/board/ti/ directory") leads to 'make html' build errors: doc/board/index.rst:6: WARNING: toctree

[PATCH v3 13/15] image: Create a function to do manual relocation

Rather than adding an #ifdef and open-coding this calculation, add a helper function to handle it. Use this in the image code. Signed-off-by: Simon Glass --- (no changes since v1) common/image.c | 33 +++-- include/relocate.h | 24 +++- 2

[PATCH v3 15/15] image: Remove ifdefs around image_setup_linux() el at

Drop some more ifdefs in image-board.c and also the FPGA part of bootm.c which calls into it. Signed-off-by: Simon Glass --- Changes in v3: - Pick up only the first part of the original v2 series common/bootm.c | 16 common/image-board.c | 11 +++ 2 files

[PATCH v3 14/15] image: Avoid #ifdefs for manual relocation

Add a macro to handle manually relocating a pointer. Update the iamge code to use this to avoid needing #ifdefs. This also fixes a bug where the 'done' flag was not set. Signed-off-by: Simon Glass --- (no changes since v1) common/image-sig.c | 40 ++--

[PATCH v3 10/15] image: Split board code out into its own file

To avoid a large #ifdef in the image.c file, move the affected code into a separate file. Avoid any style fix-ups for easier review. Those are in the next patch. Signed-off-by: Simon Glass --- (no changes since v1) common/Makefile | 2 +- common/image-board.c | 925

[PATCH v3 11/15] image: Fix up checkpatch warnings in image-board.c

Tidy up the warnings. Signed-off-by: Simon Glass --- (no changes since v1) common/image-board.c | 142 ++- 1 file changed, 72 insertions(+), 70 deletions(-) diff --git a/common/image-board.c b/common/image-board.c index 0c4e32e14e4..5d3eafb5245 100644

[PATCH v3 12/15] image: Split host code out into its own file

To avoid having #ifdefs in a few functions which are completely different in the board and host code, create a new image-host.c file. Signed-off-by: Simon Glass --- (no changes since v1) common/image-board.c | 17 + common/image-host.c | 27 +++

[PATCH v3 09/15] image: Update image_decomp() to avoid ifdefs

Adjust this function so that preprocessor macros are not needed. With this, the host build uses more of the same header files as the target build. Rather than definining CONFIG_SYS_MALLOC_LEN, add a CONSERVE_MEMORY define, since that is the purpose of the value. This appears to have no impact on

[PATCH v3 07/15] image: Update zstd to avoid reporting error twice

The zstd implementation prints the error in image_decomp() which is incorrect and does not match other algorithms. Drop this and let the caller report the error. Signed-off-by: Simon Glass --- (no changes since v1) common/image.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-)

[PATCH v3 08/15] gzip: Avoid use of u64

The gzip API uses the u64 type in it, which is not available in the host build. This makes it impossible to include the header file. We could make this type available, but it seems unnecessary. Limiting the compression size to that of the 'unsigned long' type seems good enough. On 32-bit machines

[PATCH v3 06/15] image: Avoid switch default in image_decomp()

At present this function is full of preprocessor macros. Adjust it to check for an unsupported algorithm after the switch(). This will allow us to drop the macros. Fix up the return-value path and an extra blank line while we are here. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v3 04/15] zstd: Create a function for use from U-Boot

The existing zstd API requires the same sequence of calls to perform its task. Create a helper for U-Boot, to avoid code duplication, as is done with other compression algorithms. Make use of of this from the image code. Note that the zstd code lacks a test in test/compression.c and this should

  1   2   >