Re: [PATCH v3 1/2] imx8mm-evk: Generate a single bootable flash.bin again

2021-08-19 Thread Heiko Thiery
Hi Fabio, Am Do., 19. Aug. 2021 um 21:28 Uhr schrieb Fabio Estevam : > > After the conversion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch > to use binman to pack images"), it is necessary to flash both flash.bin and > u-boot.itb to get a bootable system. Prior to this commit, only

Re: [PATCH v3 2/2] Makefile: Clean the i.MX8MM artifacts

2021-08-19 Thread Heiko Thiery
Hi Fabio, Am Do., 19. Aug. 2021 um 21:28 Uhr schrieb Fabio Estevam : > > Clean the binaries generated by binman on imx8mm-evk: > spl.* mkimage*.mkimage imx-boot.* > > Reported-by: Frieder Schrempf > Signed-off-by: Fabio Estevam > --- > Changes since v2: > - None. Newly introducedin this series.

Re: [PATCH 00/28] Initial implementation of bootmethod/bootflow

2021-08-19 Thread AKASHI Takahiro
Hi Simon, On Thu, Aug 19, 2021 at 08:25:33AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 19 Aug 2021 at 07:59, Tom Rini wrote: > > > > On Wed, Aug 18, 2021 at 09:45:33PM -0600, Simon Glass wrote: > > > > > Bootmethod and bootflow provide a built-in way for U-Boot to > > > automatically

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-19 Thread Paul Liu
Hi Frieder, I think I might have found a reason. The problem might be that the board_get_usable_ram_top() doesn't subtract the memory used by optee. Optee on imx8m uses the end of the memory. It is passed by arguments. VERBOSE: Argument #1 = 0x7e00 VERBOSE: Argument #2 = 0x200 So if I

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-19 Thread Paul Liu
Hi Frieder, I'll confirm it. But I guess you are correct. I'll send a patch soon when I implement this right. Yours, Paul On Thu, 19 Aug 2021 at 15:14, Frieder Schrempf wrote: > On 19.08.21 02:27, Fabio Estevam wrote: > > [Adding Marek] > > > > On Wed, Aug 18, 2021 at 6:39 PM Fabio Estevam

[PATCH] Kconfig: Use spaces not tabs in Kconfig entires

2021-08-19 Thread Tom Rini
While the Kconfig language seems to accept either form of whitespace, we use a space throughout the project, except in these spots. Signed-off-by: Tom Rini --- arch/arm/mach-exynos/Kconfig | 2 +- board/freescale/mx6memcal/Kconfig | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH v3 2/2] Makefile: Clean the i.MX8MM artifacts

2021-08-19 Thread Fabio Estevam
Clean the binaries generated by binman on imx8mm-evk: spl.* mkimage*.mkimage imx-boot.* Reported-by: Frieder Schrempf Signed-off-by: Fabio Estevam --- Changes since v2: - None. Newly introducedin this series. Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v3 1/2] imx8mm-evk: Generate a single bootable flash.bin again

2021-08-19 Thread Fabio Estevam
After the conversion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch to use binman to pack images"), it is necessary to flash both flash.bin and u-boot.itb to get a bootable system. Prior to this commit, only flash.bin was needed. Such new requirement breaks existing distro mechanisms to

Re: [PATCH] imx8mm-evk: Generate a single bootable flash.bin again

2021-08-19 Thread Marcel Ziswiler
On Wed, 2021-08-18 at 09:19 -0300, Fabio Estevam wrote: > After the conversion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch > to use binman to pack images"), it is necessary to flash both flash.bin and > u-boot.itb to get a bootable system. Prior to this commit, only flash.bin > was

[PATCH] astro_mcf5373l: Rework ASTRO_ID logic

2021-08-19 Thread Tom Rini
Rather than using CONFIG namespace for logic internal to include/configs/astro_mcf5373l.h to select ASTRO_ID (and populate the default environment), strip CONFIG from the various options used and set. Signed-off-by: Tom Rini --- include/configs/astro_mcf5373l.h | 14 +++--- 1 file

[PATCH] mpc83xx: Update comment

2021-08-19 Thread Tom Rini
Update the comment here to refer to PCI_CONFIG_ADDRESS rather than CONFIG_ADDRESS. Signed-off-by: Tom Rini --- include/mpc83xx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/mpc83xx.h b/include/mpc83xx.h index 71cffa1b0fc8..0275b3184ea3 100644 ---

Re: [PATCH] imx8mm-evk: Generate a single bootable flash.bin again

2021-08-19 Thread Marcel Ziswiler
Hi Fabio and Frieder On Thu, 2021-08-19 at 15:58 -0300, Fabio Estevam wrote: > Hi Frieder, > > On Thu, Aug 19, 2021 at 3:52 PM Frieder Schrempf > wrote: > > > I tried to adapt this for my own board, but I needed to change the > > following in the imximage.cfg for the > > build to pass. Did

Re: [PATCH] imx8mm-evk: Generate a single bootable flash.bin again

2021-08-19 Thread Frieder Schrempf
On 19.08.21 20:58, Fabio Estevam wrote: > Hi Frieder, > > On Thu, Aug 19, 2021 at 3:52 PM Frieder Schrempf > wrote: > >> I tried to adapt this for my own board, but I needed to change the following >> in the imximage.cfg for the build to pass. Did you test this? >> >> -LOADER

[PATCH] video: Remove ati_radeon_fb

2021-08-19 Thread Tom Rini
This driver is currently unused. Remove. Signed-off-by: Tom Rini --- drivers/video/Makefile|1 - drivers/video/ati_ids.h | 211 drivers/video/ati_radeon_fb.c | 761 - drivers/video/ati_radeon_fb.h | 282 - include/radeon.h | 1988

status="ok" treated as disabled by DM

2021-08-19 Thread Roger Quadros
Hi, If the device tree node has status="ok" then the u-boot DM will treat the device as disabled. There are still quite many devices using "ok" instead of "okay" or no status and those devices will not be bound. What is the right fix? 1) make u-boot DM to treat satus="ok" as enabled. 2) fix

[PATCH 10/16] Convert CONFIG_SYS_I2C_MXC et al to Kconfig

2021-08-19 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SYS_I2C_MXC CONFIG_SYS_I2C_MXC_I2C1 CONFIG_SYS_I2C_MXC_I2C2 CONFIG_SYS_I2C_MXC_I2C3 CONFIG_SYS_I2C_MXC_I2C4 Signed-off-by: Tom Rini --- README| 17 arch/arm/Kconfig

[PATCH] spi: altera_spi: Do not abuse CONFIG namespace

2021-08-19 Thread Tom Rini
The value CONFIG_ALTERA_SPI_IDLE_VAL is never re-defined by a board. Rename this to ALTERA_SPI_IDLE_VAL. Signed-off-by: Tom Rini --- drivers/spi/altera_spi.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/altera_spi.c b/drivers/spi/altera_spi.c index

[PATCH] global: Remove dead code that starts with CONFIG_[0-9A]

2021-08-19 Thread Tom Rini
This removes a number of spots of dead code based on symbols that start with CONFIG_[0-9] or CONFIG_A. Signed-off-by: Tom Rini --- arch/powerpc/cpu/mpc83xx/pcie.c | 144 -- arch/powerpc/include/asm/processor.h | 4 - board/freescale/mpc8349emds/mpc8349emds.c

Re: [PATCH] imx8mm-evk: Generate a single bootable flash.bin again

2021-08-19 Thread Fabio Estevam
Hi Frieder, On Thu, Aug 19, 2021 at 3:52 PM Frieder Schrempf wrote: > I tried to adapt this for my own board, but I needed to change the following > in the imximage.cfg for the build to pass. Did you test this? > > -LOADER mkimage.flash.mkimage 0x7E1000 > +LOADER

[PATCH] i8042: Do not abuse CONFIG namespace

2021-08-19 Thread Tom Rini
This driver uses the CONFIG namespace to set the chips internal CONFIG namespace related bits. However, CONFIG is reserved for the top-level Kconfig based configuration system. Use CFG as the namespace here instead to avoid pollution. Signed-off-by: Tom Rini --- drivers/input/i8042.c | 4

Re: [PATCH] imx8mm-evk: Generate a single bootable flash.bin again

2021-08-19 Thread Frieder Schrempf
Hi Fabio, On 18.08.21 16:07, Frieder Schrempf wrote: > On 18.08.21 14:19, Fabio Estevam wrote: >> After the conversion to binman in commit 8996e6b7c6a1 ("imx8mm_evk: switch >> to use binman to pack images"), it is necessary to flash both flash.bin and >> u-boot.itb to get a bootable system. Prior

[PATCH] ppc: Rework some hard-coded BOOTCOMMANDS

2021-08-19 Thread Tom Rini
There are an assortment of hard-coded CONFIG_BOOTCOMMAND options in some board headers. Rework these so that they do not add to the CONFIG namespace. Signed-off-by: Tom Rini --- include/configs/MPC8349EMDS.h | 4 ++-- include/configs/MPC8349EMDS_SDRAM.h | 4 ++--

[PATCH] arm: Migrate GICV2 / GICV3 to Kconfig

2021-08-19 Thread Tom Rini
Migrate CONFIG_GICV2 and CONFIG_GICV3 to Kconfig. We still have the GIC related registers that need to be handled more cleanly but start by moving this symbol to Kconfig. Signed-off-by: Tom Rini --- arch/arm/Kconfig | 10 ++

[PATCH] nand: vf610_nfc: Do not abuse CONFIG namespace

2021-08-19 Thread Tom Rini
This driver uses the CONFIG namespace to set the chips internal CONFIG namespace related bits. However, CONFIG is reserved for the top-level Kconfig based configuration system. Use CFG as the namespace here instead to avoid pollution. Signed-off-by: Tom Rini ---

Re: [PATCH 00/28] Initial implementation of bootmethod/bootflow

2021-08-19 Thread Tom Rini
On Thu, Aug 19, 2021 at 08:25:33AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 19 Aug 2021 at 07:59, Tom Rini wrote: > > > > On Wed, Aug 18, 2021 at 09:45:33PM -0600, Simon Glass wrote: > > > > > Bootmethod and bootflow provide a built-in way for U-Boot to > > > automatically boot > > > an

Re: [PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits for 64bit systems

2021-08-19 Thread Tom Rini
On Thu, Aug 19, 2021 at 06:31:25PM +0200, Michal Simek wrote: > > > On 8/19/21 6:18 PM, Tom Rini wrote: > > On Thu, Aug 19, 2021 at 06:01:39PM +0200, Michal Simek wrote: > >> Hi Andre, > >> > >> On 8/19/21 5:56 PM, Andre Przywara wrote: > >>> On 8/19/21 12:19 PM, Michal Simek wrote: > >>> > >>>

Re: [PATCH 08/10] arm64: dts: Make sure that all DTBs are 64bit aligned for 64bit systems

2021-08-19 Thread Michal Simek
Hi Andre, On 8/19/21 6:10 PM, Andre Przywara wrote: > On 8/19/21 12:19 PM, Michal Simek wrote: > > Hi Michal, > >> DTBs for 64bit systems should be also 64bit aligned. > > What does "align" mean here, exactly? This is about generating .dtb > *files*, right? dtc makes sure that the internal

Re: [PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits for 64bit systems

2021-08-19 Thread Michal Simek
On 8/19/21 6:18 PM, Tom Rini wrote: > On Thu, Aug 19, 2021 at 06:01:39PM +0200, Michal Simek wrote: >> Hi Andre, >> >> On 8/19/21 5:56 PM, Andre Przywara wrote: >>> On 8/19/21 12:19 PM, Michal Simek wrote: >>> >>> Hi, >>> Enabling MULTI_DTB_FIT and DTB_RESELECT can end up with multi DTBs

Re: [PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits for 64bit systems

2021-08-19 Thread Tom Rini
On Thu, Aug 19, 2021 at 06:01:39PM +0200, Michal Simek wrote: > Hi Andre, > > On 8/19/21 5:56 PM, Andre Przywara wrote: > > On 8/19/21 12:19 PM, Michal Simek wrote: > > > > Hi, > > > >> Enabling MULTI_DTB_FIT and DTB_RESELECT can end up with multi DTBs in FIT > >> image placed and aligned only

Re: [PATCH 08/10] arm64: dts: Make sure that all DTBs are 64bit aligned for 64bit systems

2021-08-19 Thread Andre Przywara
On 8/19/21 12:19 PM, Michal Simek wrote: Hi Michal, DTBs for 64bit systems should be also 64bit aligned. What does "align" mean here, exactly? This is about generating .dtb *files*, right? dtc makes sure that the internal structures are properly aligned, so what else should be aligned

Re: [PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits for 64bit systems

2021-08-19 Thread Michal Simek
Hi Andre, On 8/19/21 5:56 PM, Andre Przywara wrote: > On 8/19/21 12:19 PM, Michal Simek wrote: > > Hi, > >> Enabling MULTI_DTB_FIT and DTB_RESELECT can end up with multi DTBs in FIT >> image placed and aligned only by 32bits (4bytes). For 64bit systems there >> is 64bit (8bytes) alignment

Re: A mea culpa undefined reference in v2021.10-rc2, padding_algos, linker lists

2021-08-19 Thread Simon Glass
Hi Alex, On Wed, 18 Aug 2021 at 13:11, Alex G. wrote: > > Hi Simon, > > I'm seeing an undefined reference to padding_pkcs_15_verify with > v2021.10-rc2. It happens when enabling FIT_SIGNATURE. I've tracked it > down to the following two commits: > > commit 92c960bc1d ("lib: rsa: Remove #ifdefs

Re: [PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits for 64bit systems

2021-08-19 Thread Andre Przywara
On 8/19/21 12:19 PM, Michal Simek wrote: Hi, Enabling MULTI_DTB_FIT and DTB_RESELECT can end up with multi DTBs in FIT image placed and aligned only by 32bits (4bytes). For 64bit systems there is 64bit (8bytes) alignment required. That's why make sure that fit-dtb.blob and u-boot.itb as our

[PATCH v2 6/6] doc: Add documentation for the Arm vexpress board configs

2021-08-19 Thread Peter Hoyes
From: Peter Hoyes Create a new documentation section for Arm Ltd boards with a sub-page for the vexpress board (FVP-A, FVP-R and Juno). Document how the armv8_switch_to_el1 environment variable can be used to switch between booting from S-EL2/S-EL1 at runtime on the BASER_FVP. Signed-off-by:

[PATCH v2 5/6] arm: Use armv8_switch_to_el1 env to switch to EL1

2021-08-19 Thread Peter Hoyes
From: Peter Hoyes Use the environment variable armv8_switch_to_el1 to determine whether to switch to EL1 at runtime. This is an alternative to the CONFIG_ARMV8_SWITCH_TO_EL1 compile-time option. The environment variable will be ineffective if the ARMV8_MULTIENTRY config is used. This is

[PATCH v2 4/6] vexpress64: Add BASER_FVP vexpress board variant

2021-08-19 Thread Peter Hoyes
From: Peter Hoyes The BASER_FVP board variant is implemented on top of the BASE_FVP board config (which, in turn, is based on the Juno Versatile Express board config). They all share a similar memory map - for BASER_FVP the map is inverted from the BASE_FVP

[PATCH v2 3/6] armv8: Add ARMv8 MPU configuration logic

2021-08-19 Thread Peter Hoyes
From: Peter Hoyes Armv8r64 is the first Armv8 platform that only has a PMSA at the current exception level. The architecture supplement for Armv8r64 describes new fields in ID_AA64MMFR0_EL1 which can be used to detect whether a VMSA or PMSA is present. These fields are RES0 on Armv8a. Add logic

[PATCH v2 2/6] armv8: Ensure EL1&0 VMSA is enabled

2021-08-19 Thread Peter Hoyes
From: Peter Hoyes On Armv8-R, the EL1&0 memory system architecture is configurable as a VMSA or PMSA, and resets to an "architecturally unknown" value. Add code to armv8_switch_to_el1_m which detects whether the MSA at EL1&0 is configurable using the id_aa64mmfr0_el1 register MSA fields. If it

[PATCH v2 1/6] armv8: Disable pointer authentication traps for EL1

2021-08-19 Thread Peter Hoyes
From: Peter Hoyes The use of ARMv8.3 pointer authentication (PAuth) is governed by fields in HCR_EL2, which trigger a 'trap to EL2' if not enabled. The reset value of these fields is 'architecturally unknown' so we must ensure that the fields are enabled (to disable the traps) if we are entering

[PATCH v2 0/6] Armv8r64 + BASER_FVP board support

2021-08-19 Thread Peter Hoyes
From: Peter Hoyes Add support for the Armv8r64 architecture and the BASER_FVP, which uses the Armv8r64 architecture. The Armv8r64 architecture has the following features: * No non-secure exception levels * Highest exception level is always S-EL2 * There is only a PMSA at S-EL2, which

Re: [PATCH 1/2] armv8: Disable pointer authentication traps for EL1

2021-08-19 Thread Andre Przywara
On 8/13/21 1:22 PM, Peter Hoyes wrote: Hi, From: Peter Hoyes The use of ARMv8.3 pointer authentication (PAuth) is governed by fields in HCR_EL2, which trigger a 'trap to EL2' if not enabled. The reset value of these fields is 'architecturally unknown' so we must ensure that the fields are

[PATCH] board: atmel: sama7g5ek: avoid rewriting of configured CONFIG_BOOTCOMMAND

2021-08-19 Thread Eugen Hristev
Rewrite the CONFIG_BOOTCOMMAND only if it's not previously configured from defconfig file. This allows the user to select from defconfig/menuconfig the desired boot command. Adjust the current board defconfigs to reflect the default booting command for the specific ENV configuration.

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > - programming errors > - security errors where user input is insufficiently checked > > IMO the former should not be present if you have sufficient tests and > trying to catch them in the field at runtime is not very kind to your > users. Wow. I think

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Simon Glass
Hi, On Thu, 19 Aug 2021 at 08:16, Wolfgang Denk wrote: > > Dear Tom, > > In message <20210819130806.GW858@bill-the-cat> you wrote: > > > > > So we have now a policy to wave through code, and ask others to > > > clean it up later? That's ... sad. > > > > No, we continue to have the policy of

Re: [PATCH 00/28] Initial implementation of bootmethod/bootflow

2021-08-19 Thread Simon Glass
Hi Tom, On Thu, 19 Aug 2021 at 07:59, Tom Rini wrote: > > On Wed, Aug 18, 2021 at 09:45:33PM -0600, Simon Glass wrote: > > > Bootmethod and bootflow provide a built-in way for U-Boot to automatically > > boot > > an Operating System without custom scripting and other customisation: > > > > -

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Wolfgang Denk
Dear Tom, In message <20210819130806.GW858@bill-the-cat> you wrote: > > > So we have now a policy to wave through code, and ask others to > > clean it up later? That's ... sad. > > No, we continue to have the policy of expecting reviewers to follow the > whole discussion and relevant

Re: [PULL] u-boot-riscv/master

2021-08-19 Thread Tom Rini
On Thu, Aug 19, 2021 at 04:56:39PM +0800, Leo Liang wrote: > Hi Tom, > > The following changes since commit a0da2dda4ed9d0aee5265e9cd8876734f9f80e09: > > Prepare v2021.10-rc2 (2021-08-16 14:18:45 -0400) > > are available in the Git repository at: > >

Re: [PATCH 00/28] Initial implementation of bootmethod/bootflow

2021-08-19 Thread Tom Rini
On Wed, Aug 18, 2021 at 09:45:33PM -0600, Simon Glass wrote: > Bootmethod and bootflow provide a built-in way for U-Boot to automatically > boot > an Operating System without custom scripting and other customisation: > > - bootmethod - a method to scan a device to find bootflows (owned by

[PATCH] xilinx: zynqmp: Enable gpio-key/button driver

2021-08-19 Thread Michal Simek
Enable button uclass and also gpio-key driver by default. Signed-off-by: Michal Simek --- configs/xilinx_zynqmp_virt_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/xilinx_zynqmp_virt_defconfig b/configs/xilinx_zynqmp_virt_defconfig index ea65563a1f2d..f516ab62d3c8

[PATCH] Revert "configs: synquacer: Make U-Boot binary position independent"

2021-08-19 Thread Masami Hiramatsu
This reverts commit f7e16bb0c5362c9b01d7e6e96bf6c77fd6b3d89e, since the U-Boot doesn't boot if it is booted directly from SPI-NOR with CONFIG_POSITION_INDEPENDENT=y. Unless fixing this issue, it is better to revert this change. Signed-off-by: Masami Hiramatsu ---

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Tom Rini
On Thu, Aug 19, 2021 at 03:03:46PM +0200, Wolfgang Denk wrote: > Dear Tom, > > In message <20210819123540.GV858@bill-the-cat> you wrote: > > > > Since I literally just sent this in another email you couldn't have seen > > yet, I'll repeat it here. Feel free to follow up to this with a series >

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Wolfgang Denk
Dear Tom, In message <20210819123540.GV858@bill-the-cat> you wrote: > > Since I literally just sent this in another email you couldn't have seen > yet, I'll repeat it here. Feel free to follow up to this with a series > to further update things, Wolfgang. So we have now a policy to wave

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Tom Rini
On Thu, Aug 19, 2021 at 02:32:01PM +0200, Wolfgang Denk wrote: > Dear Rasmus, > > In message <62540f7b-0e07-8759-8e12-125527c2e...@prevas.dk> you wrote: > > > > >> +static int gpio_wdt_reset(struct udevice *dev) > > >> +{ > > >> +struct gpio_wdt_priv *priv = dev_get_priv(dev); > > >> + >

Re: [PATCH v5 09/12] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-19 Thread Tom Rini
On Thu, Aug 19, 2021 at 01:10:54PM +0200, Wolfgang Denk wrote: > Dear Rasmus, > > In message <4798abb5-07d9-fa88-931f-dbaff951e...@prevas.dk> you wrote: > > >> > > >> +ret = uclass_get(UCLASS_WDT, ); > > >> +if (ret) { > > >> +log_debug("Error getting UCLASS_WDT:

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Wolfgang Denk
Dear Rasmus, In message <62540f7b-0e07-8759-8e12-125527c2e...@prevas.dk> you wrote: > > >> +static int gpio_wdt_reset(struct udevice *dev) > >> +{ > >> + struct gpio_wdt_priv *priv = dev_get_priv(dev); > >> + > >> + priv->state = !priv->state; > > > > Potential NULL pointer dereference. > >

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Rasmus Villemoes
On 19/08/2021 13.46, Wolfgang Denk wrote: > Dear Rasmus, > > again: error handling. > > In message <20210819095706.3585923-11-rasmus.villem...@prevas.dk> you wrote: >> >> diff --git a/drivers/watchdog/gpio_wdt.c b/drivers/watchdog/gpio_wdt.c >> new file mode 100644 >> index

Re: [PATCH v1 7/7] i2c: stm32f7: compute i2cclk only one time

2021-08-19 Thread Patrice CHOTARD
HI Patrick On 8/3/21 12:05 PM, Patrice Chotard wrote: > From: Patrick Delaunay > > Compute i2cclk only one time in stm32_i2c_compute_timing() > and remove setup parameter (accessible in i2c_priv). > > Signed-off-by: Patrick Delaunay > > Signed-off-by: Patrice Chotard > --- > >

Re: [PATCH v1 6/7] i2c: stm32f7: add support for DNF i2c-digital-filter binding

2021-08-19 Thread Patrice CHOTARD
HI Patrick On 8/3/21 12:05 PM, Patrice Chotard wrote: > From: Patrick Delaunay > > Add the support for the i2c-digital-filter binding, allowing to enable > the digital filter via the device-tree and indicate its value in the DT > > Signed-off-by: Patrick Delaunay > Signed-off-by: Patrice

Re: [PATCH v1 5/7] i2c: stm32f7: fix configuration of the digital filter

2021-08-19 Thread Patrice CHOTARD
HI Patrick On 8/3/21 12:05 PM, Patrice Chotard wrote: > From: Patrick Delaunay > > The digital filter related computation are present in the driver > however the programming of the filter within the IP is missing. > The maximum value for the DNF is wrong and should be 15 instead of 16. > >

Re: [PATCH v1 4/7] i2c: stm32f7: support DT binding i2c-analog-filter

2021-08-19 Thread Patrice CHOTARD
Hi Patrick On 8/3/21 12:05 PM, Patrice Chotard wrote: > From: Patrick Delaunay > > Replace driver internally coded enabling/disabling of the > analog-filter with the DT binding "i2c-analog-filter". > > Signed-off-by: Patrick Delaunay > Signed-off-by: Patrice Chotard > --- > >

Re: [PATCH v1 3/7] arm: dts: stm32: Add i2c-analog-filter property in I2C nodes for stm32h743

2021-08-19 Thread Patrice CHOTARD
Hi Patrick On 8/3/21 12:05 PM, Patrice Chotard wrote: > Add i2c-analog-filter property in I2C nodes to enable analog > filter feature. > > Signed-off-by: Patrice Chotard > --- > > arch/arm/dts/stm32h743.dtsi | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH v1 2/7] arm: dts: stm32: Add i2c-analog-filter property in I2C nodes for stm32f746

2021-08-19 Thread Patrice CHOTARD
Hi Patrick On 8/3/21 12:05 PM, Patrice Chotard wrote: > Add i2c-analog-filter property in I2C nodes to enable analog > filter feature. > > Signed-off-by: Patrice Chotard > --- > > arch/arm/dts/stm32f746.dtsi | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH v1 1/7] i2c: stm32f7: move driver data of each instance in a privdata

2021-08-19 Thread Patrice CHOTARD
HI Patrick On 8/3/21 12:05 PM, Patrice Chotard wrote: > From: Patrick Delaunay > > Today all the I2C instance point on the same global > variable stm32_i2c_setup according the compatible: i2c_priv->setup = > pointer to the same driver data. > > This patch changes this driver data

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Wolfgang Denk
Dear Rasmus, again: error handling. In message <20210819095706.3585923-11-rasmus.villem...@prevas.dk> you wrote: > > diff --git a/drivers/watchdog/gpio_wdt.c b/drivers/watchdog/gpio_wdt.c > new file mode 100644 > index 00..982a66b3f9 > --- /dev/null > +++ b/drivers/watchdog/gpio_wdt.c >

Re: [PATCH v6 09/12] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-19 Thread Wolfgang Denk
Dear Rasmus, In message <20210819095706.3585923-10-rasmus.villem...@prevas.dk> you wrote: > > diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt-uclass.c > index 5b1c0df5d6..7570710c4d 100644 > --- a/drivers/watchdog/wdt-uclass.c > +++ b/drivers/watchdog/wdt-uclass.c > @@ -61,20

Re: [PATCH v6 07/12] watchdog: wdt-uclass.c: add wdt_stop_all() helper

2021-08-19 Thread Wolfgang Denk
Dear Rasmus, again: error handling. In message <20210819095706.3585923-8-rasmus.villem...@prevas.dk> you wrote: > > --- a/drivers/watchdog/wdt-uclass.c > +++ b/drivers/watchdog/wdt-uclass.c > @@ -116,6 +116,31 @@ int wdt_stop(struct udevice *dev) > return ret; > } > > +int

Re: status="ok" treated as disabled by DM

2021-08-19 Thread Nishanth Menon
On 14:03-20210819, Roger Quadros wrote: > Hi, > > If the device tree node has status="ok" then the u-boot DM will treat the > device as disabled. > There are still quite many devices using "ok" instead of "okay" or no status > and those devices wi

Re: [PATCH v6 05/12] watchdog: wdt-uclass.c: keep track of each device's running state

2021-08-19 Thread Wolfgang Denk
Dear Rasmus, please check your patches for proper error handling. In message <20210819095706.3585923-6-rasmus.villem...@prevas.dk> you wrote: > ... > diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt-uclass.c > index 0a1f43771c..358fc68e27 100644 > ---

Re: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env

2021-08-19 Thread Wolfgang Denk
Dear Priyanka, In message you wrote: > > I agree we cant add copyright for minor changes. > > But this file already contains Freescale (now merged into NXP) copyright. > Zhiqiang is updating to latest copyright text used by NXP(Freescale) with > proper year. > I hope this is fine. Hm... I

Re: [PATCH 05/16] am43xx: Drop non-DM_I2C code

2021-08-19 Thread Lokesh Vutla
On 19/08/21 8:42 am, Tom Rini wrote: > On this platform, we have DM_I2C and SPL_DM_I2C always enabled. > Remove legacy options. > > Cc: Lokesh Vutla > Signed-off-by: Tom Rini Acked-by: Lokesh Vutla Thanks and regards, Lokesh

[PATCH 09/10] xilinx: zynqmp: Generate different u-boot.itb for MULTI_DTB_FIT

2021-08-19 Thread Michal Simek
When MULTI_DTB_FIT is enabled fit-dtb.blob fit image is created which contain all DTBs listed by CONFIG_OF_LIST. And with DTB_RELESELECT there is a need to handle it as one file with DTBs in it not as separate DTBs in u-boot.its/itb. That's why extend mkimage_fit_atf.sh to generate u-boot.itb

[PATCH 10/10] xilinx: common: Enabling generic function for DT reselection

2021-08-19 Thread Michal Simek
U-Boot support board detection at run time and based on it change DT. This feature is implemented for SOM Kria platforms which contain two eeproms which contain information about SOM module and CC (Carrier card). Full U-Boot starts with minimal DT file defined by CONFIG_DEFAULT_DEVICE_TREE which

[PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits for 64bit systems

2021-08-19 Thread Michal Simek
Enabling MULTI_DTB_FIT and DTB_RESELECT can end up with multi DTBs in FIT image placed and aligned only by 32bits (4bytes). For 64bit systems there is 64bit (8bytes) alignment required. That's why make sure that fit-dtb.blob and u-boot.itb as our primary target images for Xilinx ZynqMP are all

[PATCH 08/10] arm64: dts: Make sure that all DTBs are 64bit aligned for 64bit systems

2021-08-19 Thread Michal Simek
DTBs for 64bit systems should be also 64bit aligned. Signed-off-by: Michal Simek --- arch/arm/dts/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index 537c96bf5b35..8d4fc333ea7a 100644 --- a/arch/arm/dts/Makefile +++

[PATCH 05/10] xilinx: Add support for generic board detection

2021-08-19 Thread Michal Simek
Add support for changing DT at run time. It is done via board_detection() which returns platform_id and platform_version which can be used via board_name_decode() to compose board_local_name string which corresponds with DT which is should be used. Signed-off-by: Michal Simek ---

[PATCH 06/10] xilinx: zynqmp: Check that DT is 64bit aligned

2021-08-19 Thread Michal Simek
DT needs to be 64bit aligned. If it is not fdt64_to_cpu will fail when try to read information about reserved memory. The system ends in exception without any clue what's going it. That's why detect not aligned DT and panic to show where the issue is coming from. Signed-off-by: Michal Simek ---

[PATCH 04/10] xilinx: common: Free allocated structure

2021-08-19 Thread Michal Simek
There is no need to keep fru_content around. Free this space. Signed-off-by: Michal Simek --- board/xilinx/common/board.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c index 44c8aa5eefbb..2aecb14d8e27

[PATCH 02/10] xilinx: Use variable for passing board_name

2021-08-19 Thread Michal Simek
Use variable which points to DEVICE_TREE by default. The reason for this change is to enable DTB_RESELECT and MULTI_DTB_FIT where board detection can be used for change DTB at run time. That's why there must be reference in board_fit_config_name_match() via variable instead of hardcoding it which

[PATCH 00/10] xilinx: Add support for DTB reselection

2021-08-19 Thread Michal Simek
Hi, this series add support for board or board+cc runtime DT selection. EEPROM memory is read and based on that decoded if this is legacy/fru based format and proper DTB is used. There is a need to have all DTBs 64bit aligned. If you don't have it you will end up in exception. But one patch in

[PATCH 01/10] xilinx: fru: Replace spaces with \0 in detected name

2021-08-19 Thread Michal Simek
FRU spec expected \0 for unused symbols but unfortunately a lot of boards are using spaces instead of \0. That's why after saving it to desc->name name is checked again and all spaces are converted to \0. This will ensure that names can be used for string manipulations like concatenation.

[PATCH 03/10] xilinx: common: Change board_info[] handling

2021-08-19 Thread Michal Simek
Origin code was allocating only pointers to struct xilinx_board_description and there was separate allocation for structure self and freeing in case of failure. The code is directly allocating space for all structures by one calloc to simlify logic. Signed-off-by: Michal Simek ---

Re: [PATCH v5 09/12] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-19 Thread Wolfgang Denk
Dear Rasmus, In message <4798abb5-07d9-fa88-931f-dbaff951e...@prevas.dk> you wrote: > >> > >> + ret = uclass_get(UCLASS_WDT, ); > >> + if (ret) { > >> + log_debug("Error getting UCLASS_WDT: %d\n", ret); > >> + return 0; > >> + } > > > > Here the error goes silent, so we

[PATCH 3/3] cmd: add acmconsole command

2021-08-19 Thread Loic Poulain
This command allows to start CDC ACM function and redirect console (stdin, stdout, stderr) to USB (acmconsole start). The console can then be accessed through the USB host for debugging purpose. The host can stop the session (acmconsole stop) to revert back console to serial and unregister CDC ACM

[PATCH 2/3] usb: gadget: Add CDC ACM function

2021-08-19 Thread Loic Poulain
Add support for CDC ACM using the new UDC and gadget API. This protocol can be used for serial over USB data transfer and is widely supported by various OS (GNU/Linux, MS-Windows, OSX...). The usual purpose of such link is to access device debug console and can be useful for products not exposing

[PATCH 1/3] lib/circbuf: Make circbuf selectable symbol

2021-08-19 Thread Loic Poulain
It is currenly only used from usbtty driver but make it properly selectable via Kconfig symbol, for future usage. Signed-off-by: Loic Poulain --- lib/Kconfig | 3 +++ lib/Makefile | 8 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/Kconfig b/lib/Kconfig index

Re: [PATCH 04/11] btrfs: Suppress the message about missing filesystem

2021-08-19 Thread Qu Wenruo
On 2021/8/19 上午11:40, Simon Glass wrote: This message comes up a lot when scanning filesystems. It suggests to the user that there is some sort of error, but in fact there is no reason to expect that a particular partition has a btrfs filesystem. Other filesystems don't print this error.

Re: [PATCH 5/7] imx: makefile: drop the use of imx8mimage.sh

2021-08-19 Thread Frieder Schrempf
On 16.08.21 05:48, Peng Fan (OSS) wrote: > From: Peng Fan > > After switch to use binman, no need to use the bash script > to check file exsiting or not. And there is bug that > the script will be executed everytime Makefile is used which is > confusing people. > > Signed-off-by: Peng Fan For

Re: [PATCH 04/11] btrfs: Suppress the message about missing filesystem

2021-08-19 Thread Marek Behún
On Wed, 18 Aug 2021 21:40:26 -0600 Simon Glass wrote: > This message comes up a lot when scanning filesystems. It suggests to the > user that there is some sort of error, but in fact there is no reason to > expect that a particular partition has a btrfs filesystem. Other > filesystems don't

Re: [PATCH 09/11] sandbox: Add a way to map a file into memory

2021-08-19 Thread Marek Behún
On Wed, 18 Aug 2021 21:40:31 -0600 Simon Glass wrote: > It is useful to map a file into memory so that it can be accessed using > simple pointers. Add a function to support this. > > Signed-off-by: Simon Glass > +int os_map_file(const char *pathname, int os_flags, void **bufp, int *sizep) >

Re: [PATCH 08/11] sandbox: Add a way to find the size of a file

2021-08-19 Thread Marek Behún
On Wed, 18 Aug 2021 21:40:30 -0600 Simon Glass wrote: > Add a function to return the size of a file. This is useful in situations > where we need to allocate memory for it before reading it. > > Signed-off-by: Simon Glass Reviewed-by: Marek Behún

[PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Rasmus Villemoes
A rather common kind of external watchdog circuit is one that is kept alive by toggling a gpio. Add a driver for handling such a watchdog. The corresponding linux driver apparently has support for some watchdog circuits which can be disabled by tri-stating the gpio, but I have never actually

[PATCH v6 11/12] sandbox: add test of wdt_gpio driver

2021-08-19 Thread Rasmus Villemoes
It seems that no other test has claimed gpio_a:7 yet, so use that. The only small wrinkle is modifying the existing wdt test to use uclass_get_device_by_driver() since we now have two UCLASS_WDT instances in play, so it's a little more robust to fetch the device by driver and not merely

[PATCH v6 12/12] sandbox: add test of wdt-uclass' watchdog_reset()

2021-08-19 Thread Rasmus Villemoes
Check that the watchdog_reset() implementation in wdt-uclass behaves as expected: - resets all activated watchdog devices - leaves unactivated/stopped devices alone - that the rate-limiting works, with a per-device threshold Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Signed-off-by:

[PATCH v6 07/12] watchdog: wdt-uclass.c: add wdt_stop_all() helper

2021-08-19 Thread Rasmus Villemoes
Since the watchdog_dev member of struct global_data is going away in favor of the wdt-uclass handling all watchdog devices, prepare for that by adding a helper to call wdt_stop() on all known devices. If an error is encountered, still do wdt_stop() on remaining devices, but remember and return

[PATCH v6 08/12] board: x530: switch to wdt_stop_all()

2021-08-19 Thread Rasmus Villemoes
Since the gd->watchdog_dev member is going away, switch to using the new wdt_stop_all() helper. While here, clean up the preprocessor conditional: The ->watchdog_dev member is actually guarded by CONFIG_WDT [disabling that in x530_defconfig while keeping CONFIG_WATCHDOG breaks the build], and in

[PATCH v6 06/12] sandbox: disable CONFIG_WATCHDOG_AUTOSTART

2021-08-19 Thread Rasmus Villemoes
For the unit tests, it is more convenient if the tests are in charge of when the watchdog devices are started and stopped, so prevent wdt-uclass from doing it automatically. Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Signed-off-by: Rasmus Villemoes --- configs/sandbox64_defconfig | 1

[PATCH v6 09/12] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-19 Thread Rasmus Villemoes
A board can have and make use of more than one watchdog device, say one built into the SOC and an external gpio-petted one. Having wdt-uclass only handle the first is both a little arbitrary and unexpected. So change initr_watchdog() so we visit (probe) all DM watchdog devices, and call the

[PATCH v6 05/12] watchdog: wdt-uclass.c: keep track of each device's running state

2021-08-19 Thread Rasmus Villemoes
As a step towards handling all DM watchdogs in watchdog_reset(), use a per-device flag to keep track of whether the device has been started instead of a bit in gd->flags. We will still need that bit to know whether we are past initr_watchdog() and hence have populated gd->watchdog_dev -

[PATCH v6 04/12] watchdog: wdt-uclass.c: refactor initr_watchdog()

2021-08-19 Thread Rasmus Villemoes
In preparation for handling all DM watchdogs in watchdog_reset(), pull out the code which handles starting (or not) the gd->watchdog_dev device. Include the device name in various printfs. Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Signed-off-by: Rasmus Villemoes ---

[PATCH v6 03/12] watchdog: wdt-uclass.c: neaten UCLASS_DRIVER definition

2021-08-19 Thread Rasmus Villemoes
The addition of .pre_probe and .per_device_auto made this look bad. Fix it. Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Signed-off-by: Rasmus Villemoes --- drivers/watchdog/wdt-uclass.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

  1   2   >