Re: [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err

2021-10-26 Thread Sean Anderson
On 10/6/21 8:05 AM, Stefan Agner wrote: dev_err seems to be moved to different header file. Include dm/device_compat.h file to compile properly. Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros") Signed-off-by: Stefan Agner --- Changes in v2: - Correctly place

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 20:48, Pali Rohár wrote: On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: On 26.10.21 14:40, Pali Rohár wrote: My another guess there could be a problem is usage of stack. Maybe it is possible that register with stack pointer is not initialized after the full transfer when

an off-by-one error in dm_test_rtc_set_get()?

2021-10-26 Thread Bin Meng
Hi Simon, gitlab reported the following test error below: === FAILURES === __ test_ut[ut_dm_rtc_set_get] __ test/py/tests/test_ut.py:43: in test_ut assert output.endswith('Failures:

Re: [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err

2021-10-26 Thread Bin Meng
On Wed, Oct 6, 2021 at 8:05 PM Stefan Agner wrote: > > dev_err seems to be moved to different header file. Include > dm/device_compat.h file to compile properly. > > Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros") > Signed-off-by: Stefan Agner > --- > > Changes in

Re: [PATCH] x86: Fix i8254 ifdef include guard

2021-10-26 Thread Bin Meng
On Wed, Oct 27, 2021 at 11:08 AM Bin Meng wrote: > > On Thu, Oct 21, 2021 at 5:31 AM Alistair Delva wrote: > > > > When building U-Boot with clang, it notices that the i8254.h include > > guard does not work correctly due to a typo. Fix it. > > > > Signed-off-by: Alistair Delva > > Cc: Simon

Re: [PATCH] x86: chromebook_coral: fix C block comment

2021-10-26 Thread Bin Meng
On Wed, Oct 27, 2021 at 11:07 AM Bin Meng wrote: > > On Thu, Oct 21, 2021 at 5:31 AM Alistair Delva wrote: > > > > Fix a warning seen when compiling this dts file. > > > > Signed-off-by: Alistair Delva > > Cc: Simon Glass > > Cc: Bin Meng > > --- > > arch/x86/dts/chromebook_coral.dts | 1 + >

Re: [PATCH v1 1/1] x86: tangier: Replace Method() by Name() for _STA object

2021-10-26 Thread Bin Meng
On Wed, Oct 27, 2021 at 11:05 AM Bin Meng wrote: > > On Wed, Oct 20, 2021 at 8:51 PM Andy Shevchenko > wrote: > > > > There is no point to use Method() for the constant. > > Replace it with Name() defined object. For the _STA > > case it saves 3 bytes per each entry. > > > > Before: 2881 > >

Re: [PATCH v2 0/2] pxe_utils: Fix arguments to x86 zboot

2021-10-26 Thread Bin Meng
On Wed, Oct 20, 2021 at 3:18 PM Zhaofeng Li wrote: > > Hi Simon, > > Thanks for your review! I have added a second patch to perform the > cleanup that you mentioned in the review, so the actual "fix" patch > stays minimal and easy to review. > > I agree that calling the bootm and zboot code

Re: [PATCH] x86: Fix i8254 ifdef include guard

2021-10-26 Thread Bin Meng
On Thu, Oct 21, 2021 at 5:31 AM Alistair Delva wrote: > > When building U-Boot with clang, it notices that the i8254.h include > guard does not work correctly due to a typo. Fix it. > > Signed-off-by: Alistair Delva > Cc: Simon Glass > Cc: Bin Meng > --- > arch/x86/include/asm/i8254.h | 2 +-

Re: [PATCH] x86: chromebook_coral: fix C block comment

2021-10-26 Thread Bin Meng
On Thu, Oct 21, 2021 at 5:31 AM Alistair Delva wrote: > > Fix a warning seen when compiling this dts file. > > Signed-off-by: Alistair Delva > Cc: Simon Glass > Cc: Bin Meng > --- > arch/x86/dts/chromebook_coral.dts | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng

Re: [PATCH v1 1/1] x86: tangier: Replace Method() by Name() for _STA object

2021-10-26 Thread Bin Meng
On Wed, Oct 20, 2021 at 8:51 PM Andy Shevchenko wrote: > > There is no point to use Method() for the constant. > Replace it with Name() defined object. For the _STA > case it saves 3 bytes per each entry. > > Before: 2881 > After: 2833 > > Signed-off-by: Andy Shevchenko > --- >

Re: [PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-26 Thread Bin Meng
Hi Andy, On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko wrote: > > There are two PCB designs in the wild which use the opposite > signaling for SD card detect. This makes U-Boot working in one case > and failing in the other. Quirk this out by disconnecting SD card > detect pin from the PCB by

Re: [PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

2021-10-26 Thread Bin Meng
Hi Andy, On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko wrote: > > We would need to quirk out Card Detect case and for that we allow > configuring SD/SDIO family of pins. > > Signed-off-by: Andy Shevchenko > --- > arch/x86/cpu/tangier/pinmux.c | 39 ++- > 1

Re: [PATCH 2/2] dt-bindings: u-boot: Add an initial binding for config

2021-10-26 Thread Rob Herring
On Sun, Oct 24, 2021 at 9:39 AM Simon Glass wrote: > > Hi Mark, > > On Thu, 21 Oct 2021 at 02:51, Mark Kettenis wrote: > > > > > From: Simon Glass > > > Date: Wed, 20 Oct 2021 16:44:41 -0600 > > > > > > Hi Rob, > > > > > > On Mon, 18 Oct 2021 at 16:26, Rob Herring wrote: > > > > > > > > On

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-26 Thread Bin Meng
On Sun, Oct 17, 2021 at 2:26 AM Ramon Fried wrote: > > On Wed, Sep 29, 2021 at 4:32 PM Vladimir Oltean > wrote: > > > > On Wed, Sep 29, 2021 at 01:50:44PM +0800, Bin Meng wrote: > > > set_promisc() call accepts the parameter of a bool type. Make it > > > clear by using true instead of 1. > > >

Re: [PATCH 1/1] env: superfluous check before free()

2021-10-26 Thread Tom Rini
On Tue, Oct 26, 2021 at 12:41:59AM +0200, Heinrich Schuchardt wrote: > Free() checks if its argument in NULL. There is no need for the caller to > do the same. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] dfu: Sort Kconfig entries alphabetically

2021-10-26 Thread Tom Rini
On Tue, Oct 26, 2021 at 12:37:05AM +0200, Marek Vasut wrote: > The DFU_MTD Kconfig entry is in the wrong position, move it into the > correct alphabetically sorted position. No functional change. > > Signed-off-by: Marek Vasut > Cc: Lukasz Majewski > Cc: Patrice Chotard > Cc: Patrick Delaunay

Re: [PATCH] lib: uuid: fix the test on RNG device presence

2021-10-26 Thread Tom Rini
On Fri, Oct 22, 2021 at 05:05:47PM +0200, Patrick Delaunay wrote: > Correct the test on RNG device presence,when ret is equal to 0, > before to call dm_rng_read function. > > Without this patch the RNG device is not used when present (when ret == 0) > or a data abort occurs in dm_rng_read when

Re: [PATCH] common: Kconfig.boot: add config SPL_FIT_RSASSA_PSS

2021-10-26 Thread Tom Rini
On Fri, Oct 15, 2021 at 11:35:03AM +0200, Philippe Reynes wrote: > The padding pss is only supported on u-boot and tools since > commit 2bbed3ff8c7f ("image: Use Kconfig to enable FIT_RSASSA_PSS on host") > > This commit adds the config SPL_FIT_RSASSA_PSS to support > the padding pss in the SPL.

Re: [PATCH] lib: rsa: rsa-verify: also check that padding is not NULL

2021-10-26 Thread Tom Rini
On Fri, Oct 15, 2021 at 11:28:47AM +0200, Philippe Reynes wrote: > This commit adds a check on the padding in the function rsa_verify_key > to avoid using a NULL pointer. > > Signed-off-by: Philippe Reynes > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH] firmware: scmi: fix struct layout for scmi_clk_rate_set_in

2021-10-26 Thread Tom Rini
On Wed, Oct 13, 2021 at 04:00:04PM +0200, Clément Léger wrote: > First two fields are reversed compared to what is expected by the SCMI > specification. > > Signed-off-by: Clément Léger > Fixes: 60388844836 ("clk: add clock driver for SCMI agents") Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] cmd: nand biterr - Add support for nand biterr command

2021-10-26 Thread Tom Rini
On Tue, Jun 29, 2021 at 12:46:11PM +0530, Balamanikandan Gunasundar wrote: > The command shall be used to induce bit errors in the nand page > manually. The code flips a bit in the specified offset without > changing the ECC. This helps to see how the software handles the > error. > > The patch

Pull request for efi-2022-01-rc1-2

2021-10-26 Thread Heinrich Schuchardt
The following changes since commit 397b35f09794e40d62d5e4f53992e2a711dc8be1: Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-sunxi (2021-10-25 12:09:57 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git

[BUG] binman does not check signature of toolchain

2021-10-26 Thread Heinrich Schuchardt
Downloading binaries and executing without checking the authenticity is at least unwise. When binman downloads GCC it should also download and verify the GPG signatures. Additionally binman could hold a list of the SHA256 hashes of all binaries in question for a further check. Best

Re: [PATCH1/1]sqfs: sqfs_tokenize() should fill the tokens list instead of free items

2021-10-26 Thread Tom Rini
On Sat, Oct 16, 2021 at 10:19:48AM +0800, Jincheng Wang wrote: > We can delete two lines of code to avoid double free bug, but still a wild > pointers bug. > > A test for wild pointers: > sqfsls host 0 1//2/3//4/5 > > Fill the tokens list can solve it well. > > > Signed-off-by: Jincheng

Re: [PATCH v2 13/41] dm: core: Add a way to obtain a string list

2021-10-26 Thread Ilias Apalodimas
On Sun, 24 Oct 2021 at 02:26, Simon Glass wrote: > > At present we support reading a string list a string at a time. Apart > from being inefficient, this makes it impossible to separate reading of > the devicetree into the of_to_plat() method where it belongs, since any > code which needs access

Re: [PATCH v4 2/4] efi_loader: add UEFI GPT measurement

2021-10-26 Thread Heinrich Schuchardt
On 10/26/21 10:27, Masahisa Kojima wrote: This commit adds the UEFI GPT disk partition topology measurement required in TCG PC Client Platform Firmware Profile Specification Signed-off-by: Masahisa Kojima --- Changes in v4: - update commit message - return EFI_SUCCESS if device path is NULL

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Pali Rohár
On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: > On 26.10.21 14:40, Pali Rohár wrote: > > My another guess there could be a problem is usage of stack. Maybe it is > > possible that register with stack pointer is not initialized after the > > full transfer when going to execute main image.

patch for rpi3 on FreeBSD

2021-10-26 Thread Mike Karels
Hi, I have volunteered to coordinate a patch to u-boot for the Raspberry Pi 3 on FreeBSD. The problem is that with u-boot-2021.07 and the current MMC overlay, the SD card slot is renumbered. The SD card does not configure, and the installation card doesn't boot. The following patch to

[PATCH] configs: sama5d2 boards: add DM and GPIO commands

2021-10-26 Thread Eugen Hristev
From: Mihai Sain Add dm command for driver model low level access and gpio command for query and control gpio pins. Signed-off-by: Mihai Sain --- configs/sama5d27_som1_ek_mmc1_defconfig| 2 ++ configs/sama5d27_som1_ek_mmc_defconfig | 2 ++

Re: [PATCH v3 2/2] cmd: brcm: netXtreme commands

2021-10-26 Thread Roman Bacik
On Tue, Oct 26, 2021 at 9:52 AM Marek Behún wrote: > > On Tue, 26 Oct 2021 09:40:44 -0700 > Roman Bacik wrote: > > > On Tue, Oct 26, 2021 at 9:02 AM Roman Bacik > > wrote: > > > > > > On Tue, Oct 26, 2021 at 8:55 AM Marek Behún wrote: > > > > > > > > On Tue, 26 Oct 2021 08:14:28 -0700 > > > >

Re: [PATCH v3 2/2] cmd: brcm: netXtreme commands

2021-10-26 Thread Marek Behún
On Tue, 26 Oct 2021 09:40:44 -0700 Roman Bacik wrote: > On Tue, Oct 26, 2021 at 9:02 AM Roman Bacik wrote: > > > > On Tue, Oct 26, 2021 at 8:55 AM Marek Behún wrote: > > > > > > On Tue, 26 Oct 2021 08:14:28 -0700 > > > Roman Bacik wrote: > > > > > > > Hi Marek, > > > > > > > > We do not want

Re: [PATCH v3 2/2] cmd: brcm: netXtreme commands

2021-10-26 Thread Marek Behún
On Tue, 26 Oct 2021 09:02:54 -0700 Roman Bacik wrote: > On Tue, Oct 26, 2021 at 8:55 AM Marek Behún wrote: > > > > On Tue, 26 Oct 2021 08:14:28 -0700 > > Roman Bacik wrote: > > > > > Hi Marek, > > > > > > We do not want this driver to be automatically probed. It is not needed > > > all the

Re: [PATCH v3 2/2] cmd: brcm: netXtreme commands

2021-10-26 Thread Roman Bacik
On Tue, Oct 26, 2021 at 9:02 AM Roman Bacik wrote: > > On Tue, Oct 26, 2021 at 8:55 AM Marek Behún wrote: > > > > On Tue, 26 Oct 2021 08:14:28 -0700 > > Roman Bacik wrote: > > > > > Hi Marek, > > > > > > We do not want this driver to be automatically probed. It is not needed > > > all the time

Re: [PATCH v3 2/2] cmd: brcm: netXtreme commands

2021-10-26 Thread Roman Bacik
On Tue, Oct 26, 2021 at 8:55 AM Marek Behún wrote: > > On Tue, 26 Oct 2021 08:14:28 -0700 > Roman Bacik wrote: > > > Hi Marek, > > > > We do not want this driver to be automatically probed. It is not needed > > all the time and also slows down the boot time. We have stripped down > > everything

Re: [PATCH v5 02/26] doc: Add documentation about devicetree usage

2021-10-26 Thread François Ozog
On Tue, 26 Oct 2021 at 17:27, Simon Glass wrote: > Hi François, > > On Tue, 26 Oct 2021 at 08:31, François Ozog > wrote: > > > > Hi Simon, > > > > On Tue, 26 Oct 2021 at 02:25, Simon Glass wrote: > >> > >> At present some of the ideas and techniques behind devicetree in U-Boot > >> are

Re: [PATCH v3 2/2] cmd: brcm: netXtreme commands

2021-10-26 Thread Marek Behún
On Tue, 26 Oct 2021 08:14:28 -0700 Roman Bacik wrote: > Hi Marek, > > We do not want this driver to be automatically probed. It is not needed > all the time and also slows down the boot time. We have stripped down > everything else to bare minimum. > Thanks, > > Roman Hi Roman, OK, that is

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 17:34, Marek Behún wrote: On Tue, 26 Oct 2021 17:25:10 +0200 Stefan Roese wrote: On 26.10.21 17:20, Marek Behún wrote: On Tue, 26 Oct 2021 17:13:05 +0200 Stefan Roese wrote: Here is now just hangs forever. No output from main U-Boot proper at all. This happed every time,

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Marek Behún
On Tue, 26 Oct 2021 17:25:10 +0200 Stefan Roese wrote: > On 26.10.21 17:20, Marek Behún wrote: > > On Tue, 26 Oct 2021 17:13:05 +0200 > > Stefan Roese wrote: > > > >> Here is now just hangs forever. No output from main U-Boot proper at > >> all. This happed every time, when the baudrate is

Re: [PATCH v5 26/26] fdt: Don't call board_fdt_blob_setup() without OF_BOARD

2021-10-26 Thread Simon Glass
Hi Ilias, On Tue, 26 Oct 2021 at 07:56, Ilias Apalodimas wrote: > > Hi Simon, > > As I said here [1], this is moving on an entirely different direction I had > in mind. I'd much prefer starting the discussions for a solution that > allows us to scale. I am missing the point here. Is there

Re: [PATCH v5 02/26] doc: Add documentation about devicetree usage

2021-10-26 Thread Simon Glass
Hi François, On Tue, 26 Oct 2021 at 08:31, François Ozog wrote: > > Hi Simon, > > On Tue, 26 Oct 2021 at 02:25, Simon Glass wrote: >> >> At present some of the ideas and techniques behind devicetree in U-Boot >> are assumed, implied or unsaid. Add some documentation to cover how >> devicetree

Re: [PATCH v5 02/26] doc: Add documentation about devicetree usage

2021-10-26 Thread Simon Glass
Hi Ilias, On Tue, 26 Oct 2021 at 08:06, Ilias Apalodimas wrote: > > Hi Simon, > > > + > > [...] > > > +This is why `CONFIG_OF_SEPARATE` should always be used when building > > U-Boot. > > +The `CONFIG_OF_EMBED` option embeds the devicetree somewhere in the U-Boot > > ELF > > +image as rodata,

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 17:20, Marek Behún wrote: On Tue, 26 Oct 2021 17:13:05 +0200 Stefan Roese wrote: Here is now just hangs forever. No output from main U-Boot proper at all. This happed every time, when the baudrate is changed, meaning a non 115200 -B is passed to kwboot. I checked with 115201 and

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Marek Behún
On Tue, 26 Oct 2021 17:13:05 +0200 Stefan Roese wrote: > Here is now just hangs forever. No output from main U-Boot proper at > all. This happed every time, when the baudrate is changed, meaning a > non 115200 -B is passed to kwboot. I checked with 115201 and here no > U-Boot proper output is

RE: [PATCH v3 2/2] cmd: brcm: netXtreme commands

2021-10-26 Thread Roman Bacik
> -Original Message- > From: Marek Behún > Sent: Tuesday, October 26, 2021 6:18 AM > To: Roman Bacik > Cc: U-Boot Mailing List ; Bharat Gooty > ; Aswath Govindraju govindr...@ti.com>; Bin Meng ; Franck > LENORMAND ; Heinrich Schuchardt > ; Kory Maincent ; > Michal Simek ; Patrick

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 16:48, Pali Rohár wrote: On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: On 26.10.21 14:40, Pali Rohár wrote: On Tuesday 26 October 2021 13:09:42 Stefan Roese wrote: On 26.10.21 11:06, Pali Rohár wrote: Now I found logical error in kwboot code which handles

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Pali Rohár
On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: > On 26.10.21 14:40, Pali Rohár wrote: > > On Tuesday 26 October 2021 13:09:42 Stefan Roese wrote: > > > On 26.10.21 11:06, Pali Rohár wrote: > > > > > > > > > > > > > Now I found logical error in kwboot code which handles retransmission

Re: [PATCH v5 02/26] doc: Add documentation about devicetree usage

2021-10-26 Thread François Ozog
Hi Simon, On Tue, 26 Oct 2021 at 02:25, Simon Glass wrote: > At present some of the ideas and techniques behind devicetree in U-Boot > are assumed, implied or unsaid. Add some documentation to cover how > devicetree is build, how it can be modified and the rules about using > the various

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 14:40, Pali Rohár wrote: On Tuesday 26 October 2021 13:09:42 Stefan Roese wrote: On 26.10.21 11:06, Pali Rohár wrote: Now I found logical error in kwboot code which handles retransmission of the last header packet. State of "baudrate change" is cleared on every retransmission.

Re: [PATCH v5 02/26] doc: Add documentation about devicetree usage

2021-10-26 Thread Ilias Apalodimas
Hi Simon, > + [...] > +This is why `CONFIG_OF_SEPARATE` should always be used when building U-Boot. > +The `CONFIG_OF_EMBED` option embeds the devicetree somewhere in the U-Boot > ELF > +image as rodata, meaning that it is hard to find it and it cannot increase in > +size. > + > +When

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 15:06, Marek Behún wrote: On Tue, 26 Oct 2021 14:40:48 +0200 Pali Rohár wrote: What is happening here? I do not know. But as Marek told me that observed same issue and replacing USB-UART cable by another decreased transfer time. So I think that issue is somewhere in USB-UART

Re: [PATCH v5 26/26] fdt: Don't call board_fdt_blob_setup() without OF_BOARD

2021-10-26 Thread Ilias Apalodimas
Hi Simon, As I said here [1], this is moving on an entirely different direction I had in mind. I'd much prefer starting the discussions for a solution that allows us to scale. FWIW I think the current code is still not clean for my taste. Commit 3b595da441cf ("fdtdec: allow board to provide fdt

Re: [PATCH v3 1/1] arm: spl: prepare for jumping to OPTEE

2021-10-26 Thread Tom Rini
On Wed, Oct 20, 2021 at 03:12:06PM +0300, Oleksandr Suvorov wrote: > From: Ricardo Salveti > > Make sure to (if applicable) flush the D-cache, invalidate I-cache, > and disable MMU and caches before jumping to OPTEE. > This fixes the SDP->SPL->OPTEE boot flow on iMX6Q and most likely on > some

Re: [PATCH] loads: Block writes into LMB reserved areas of U-Boot

2021-10-26 Thread Tom Rini
On Sun, Oct 10, 2021 at 11:52:41PM +0200, marek.va...@gmail.com wrote: > From: Marek Vasut > > The loads srec loading may overwrite piece of U-Boot accidentally. > Prevent that by using LMB to detect whether upcoming write would > overwrite piece of reserved U-Boot code, and if that is the

Re: [PATCH v2] env: mmc: Add support for redundant env in both eMMC boot partitions

2021-10-26 Thread Tom Rini
On Sun, Oct 17, 2021 at 07:23:36PM +0200, Marek Vasut wrote: > Currently the MMC environment driver supports storing redundant environment > only in one eMMC partition at different offsets. This is sub-optimal, since > if this one boot partition is erased, both copies of environment are lost. >

Re: [PATCH 1/2] env: mmc: Add missing eMMC bootpart restoration to env erase

2021-10-26 Thread Tom Rini
On Wed, Oct 06, 2021 at 06:29:53PM +0200, Marek Vasut wrote: > If the environment is stored in eMMC hardware boot partition, the environment > driver first stores the currently selected eMMC boot partition, then does the > requested operation, and then restores the original boot partition

Re: [PATCH] dfu: dfu_sf: Read the SPI flash in 16 MiB chunks

2021-10-26 Thread Tom Rini
On Tue, Sep 14, 2021 at 05:26:51AM +0200, Marek Vasut wrote: > Not all SPI flashes and controllers can do continuous transfer longer > than 16 MiB, so perform the DFU read in 16 MiB chunks. > > Signed-off-by: Marek Vasut > Cc: Lukasz Majewski > Reviewed-by: Lukasz Majewski Applied to

Re: [PATCH v3 0/3] Add SPL build support for RK3568

2021-10-26 Thread Kever Yang
Hi Peter,     This add SPL support for RK3568, and the ATF support is a function support int the ATF in rockchip platform, so if this chip works, them it will of course support ATF like other rockchip SoCs. Thanks, - Kever On 2021/10/26 下午4:09, Peter Robinson wrote: Hi Nico, Is this

Re: [PATCH v3 2/2] cmd: brcm: netXtreme commands

2021-10-26 Thread Marek Behún
On Mon, 25 Oct 2021 16:44:44 -0700 Roman Bacik wrote: > From: Bharat Gooty > > Following netXtreme commands are supported: > probe, remove. > > Signed-off-by: Bharat Gooty > > Signed-off-by: Roman Bacik Hi Roman, why do you need to have custom command for probing / removing the driver?

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Marek Behún
On Tue, 26 Oct 2021 14:40:48 +0200 Pali Rohár wrote: > What is happening here? I do not know. But as Marek told me that > observed same issue and replacing USB-UART cable by another decreased > transfer time. So I think that issue is somewhere in USB-UART > transmitter. My guess is that USB-UART

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Pali Rohár
On Tuesday 26 October 2021 13:09:42 Stefan Roese wrote: > On 26.10.21 11:06, Pali Rohár wrote: > > > > > Now I found logical error in kwboot code which handles retransmission of > > the last header packet. State of "baudrate change" is cleared on every > > retransmission. Please apply following

[PATCH] Remove LYNX KDI remainders

2021-10-26 Thread Thomas Huth
The last board that used to set CONFIG_LYNXKDI has been removed in commit 242836a893ae ("powerpc: ppc4xx: remove pcs440ep support"), doc/README.lynxkdi only talks about a MPC8260 board being supported, and the mpc8260 support has been removed four years ago in commit 2eb48ff7a210d ("powerpc, 8260:

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-26 Thread Ilias Apalodimas
Hi Simon, A bit late to the party, sorry! [...] > > > > I really want to see what the binary case looks like since we could then > > kill off rpi_{3,3_b,4}_defconfig and I would need to see if we could > > then also do a rpi_arm32_defconfig too. > > > > I want to see less device trees in U-Boot

[PATCH v5] sandbox: Remove OF_HOSTFILE

2021-10-26 Thread Ilias Apalodimas
OF_HOSTFILE is used on sandbox configs only. Although it's pretty unique and not causing any confusions, we are better of having simpler config options for the DTB. So let's replace that with the existing OF_BOARD. U-Boot would then have only three config options for the DTB origin. -

Re: [PATCH v4] sandbox: Remove OF_HOSTFILE

2021-10-26 Thread Ilias Apalodimas
On Tue, 26 Oct 2021 at 00:17, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 04:07:21PM +0300, Ilias Apalodimas wrote: > > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > > unique and not causing any confusions, we are better of having simpler > > config options for the DTB.

[PATCH v3 1/2] net: brcm: netXtreme driver

2021-10-26 Thread Roman Bacik
From: Bharat Gooty Broadcom bnxt L2 driver support. Used by the Broadcom iproc platforms. Signed-off-by: Bharat Gooty Reviewed-by: Ramon Fried Signed-off-by: Roman Bacik --- Changes in v3: - change printf to debug in display_banner - remove get/set/print mac/speed - remove

Re: Re: [PATCH v3 0/3] Add SPL build support for RK3568

2021-10-26 Thread nico.ch...@rock-chips.com
Hi Peter, The scripts that package the ATF and other components are subject to further updates to the patch, which is not currently available in the submitted patch. Nico -- nico.ch...@rock-chips.com >Hi Nico, > >Is this expected to work with Arm Trusted Firmware or

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 11:06, Pali Rohár wrote: Now I found logical error in kwboot code which handles retransmission of the last header packet. State of "baudrate change" is cleared on every retransmission. Please apply following diff, so state variables are initialized only once. diff --git

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-26 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > > We need the space between the bootargs. > > > > Exactly like that, and for the case where you want to append something > > _without_ an extra space there's the .=3D operator I also suggested. > > Do you have a link to the docs for that? > > Perhaps we

RE: breakpoint not working in do_mmc_read (using qemu)

2021-10-26 Thread Chan Kim
Hi, (for those who don't know how to stop at breakpoints after relocation..) I came back to this problem today and found https://shenki.github.io/debugging-u-boot-after-relocation/. So by doing in gdb, b relocation_done (after you stop at relocation_done), print /x ((gd_t *)$r9)->relocaddr $1

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Pali Rohár
On Tuesday 26 October 2021 10:45:09 Stefan Roese wrote: > On 26.10.21 10:33, Pali Rohár wrote: > > On Monday 25 October 2021 17:15:14 Stefan Roese wrote: > > > Hi Pali, > > > > > > On 25.10.21 16:42, Pali Rohár wrote: > > > > On Monday 25 October 2021 16:39:44 Stefan Roese wrote: > > > > > Hi

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 10:33, Pali Rohár wrote: On Monday 25 October 2021 17:15:14 Stefan Roese wrote: Hi Pali, On 25.10.21 16:42, Pali Rohár wrote: On Monday 25 October 2021 16:39:44 Stefan Roese wrote: Hi Marek, On 25.10.21 15:12, Marek Behún wrote: From: Marek Behún Hello Stefan, these are

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Pali Rohár
On Monday 25 October 2021 17:15:14 Stefan Roese wrote: > Hi Pali, > > On 25.10.21 16:42, Pali Rohár wrote: > > On Monday 25 October 2021 16:39:44 Stefan Roese wrote: > > > Hi Marek, > > > > > > On 25.10.21 15:12, Marek Behún wrote: > > > > From: Marek Behún > > > > > > > > Hello Stefan, > > >

[PATCH v4 4/4] efi_loader: add DeployedMode and AuditMode variable measurement

2021-10-26 Thread Masahisa Kojima
This commit adds the DeployedMode and AuditMode variable measurement required in TCG PC Client Platform Firmware Profile Specification. Signed-off-by: Masahisa Kojima --- Changes in v4: - use table and loop - update commit message Changes in v3: - read variable first, then mesure the variable

[PATCH v4 3/4] efi_loader: simplify tcg2_measure_secure_boot_variable()

2021-10-26 Thread Masahisa Kojima
This commit simplifies tcg2_measure_secure_boot_variable() using secure_variables table. Signed-off-by: Masahisa Kojima --- Newly added in v4 lib/efi_loader/efi_tcg2.c | 60 --- 1 file changed, 18 insertions(+), 42 deletions(-) diff --git

[PATCH v4 2/4] efi_loader: add UEFI GPT measurement

2021-10-26 Thread Masahisa Kojima
This commit adds the UEFI GPT disk partition topology measurement required in TCG PC Client Platform Firmware Profile Specification Signed-off-by: Masahisa Kojima --- Changes in v4: - update commit message - return EFI_SUCCESS if device path is NULL - use memalign() Changes in v3: -

[PATCH v4 1/4] efi_loader: add SMBIOS table measurement

2021-10-26 Thread Masahisa Kojima
TCG PC Client Platform Firmware Profile Specification requires to measure the SMBIOS table that contains static configuration information (e.g. Platform Manufacturer Enterprise Number assigned by IANA, platform model number, Vendor and Device IDs for each SMBIOS table). The device- and

[PATCH v4 0/4] Enhance Measured Boot

2021-10-26 Thread Masahisa Kojima
This patch series add the following measurement mandated in the TCG PC Client PFP Specification. - SMBIOS tables - GPT disk partition topology - AuditMode and Deployed mode Masahisa Kojima (4): efi_loader: add SMBIOS table measurement efi_loader: add UEFI GPT measurement efi_loader:

Re: [PATCH v3 0/3] Add SPL build support for RK3568

2021-10-26 Thread Peter Robinson
Hi Nico, Is this expected to work with Arm Trusted Firmware or some other TF? Could we have some docs/details for how to test this? Peter > This series adds support for the rk3568 SOC, SPL load next-stage image from > eMMC will be supported after this series of patches. > > Changes in v3: >

Re: [PATCH] introduce CONFIG_DEVICE_TREE_INCLUDES

2021-10-26 Thread Rasmus Villemoes
On 26/10/2021 03.28, Simon Glass wrote: > Hi Rasmus, > > On Tue, 28 Sept 2021 at 02:57, Rasmus Villemoes > wrote: >> >> The build system already automatically looks for and includes an >> in-tree *-u-boot.dtsi when building the control .dtb. However, there >> are some things that are awkward to

Re: [PATCH] arm: dts: stm32mp15: alignment with v5.15-rc6

2021-10-26 Thread Patrice CHOTARD
Hi Patrick On 10/21/21 11:54 AM, Patrick Delaunay wrote: > Device tree alignment with Linux kernel v5.15-rc6 > - Set {bitclock,frame}-master phandles on ST DKx > - Add coprocessor detach mbox on stm32mp15x-dkx boards > - Add coprocessor detach mbox on stm32mp157c-ed1 board > > Signed-off-by:

Re: [PATCH v4 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset

2021-10-26 Thread liao jaime
> > On 25/10/21 12:30PM, Jagan Teki wrote: > > On Mon, Oct 18, 2021 at 11:54 AM JaimeLiao wrote: > > > > > > Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from > > > 8D-8D-8D > > > in the begging of probe. > > > > > > Command extension type is not standardized across flash

Re: [PATCH v4 4/4] mtd: spi-nor-core: Add support for Macronix Octal flash

2021-10-26 Thread liao jaime
> > On 18/10/21 02:24PM, JaimeLiao wrote: > > Adding Macronix Octal flash for Octal DTR support. > > > > The octaflash series can be divided into the following types: > > > > MX25 series : Serial NOR Flash. > > MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) > > LM/UM series

Re: [PATCH v4 3/4] mtd: spi-nor-core: set 4byte opcode when possible

2021-10-26 Thread liao jaime
> > On 18/10/21 02:24PM, JaimeLiao wrote: > > Following linux kernel to check address width and 4byte flag to enable > > 4byte opcode setting. > > > > Signed-off-by: JaimeLiao > > --- > > drivers/mtd/spi/spi-nor-core.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git

[PATCH v4 16/16] update CAAM MAINTAINER

2021-10-26 Thread Gaurav Jain
Signed-off-by: Gaurav Jain --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5069f18806..12a304bcb6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1276,3 +1276,10 @@ T: git https://source.denx.de/u-boot/u-boot.git F:

[PATCH v4 15/16] PPC: Enable Job ring driver model in U-Boot

2021-10-26 Thread Gaurav Jain
removed sec_init() call and CONFIG_FSL_CAAM from defconfig. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain Reviewed-by: Priyanka Jain --- arch/powerpc/cpu/mpc85xx/Kconfig | 44 +++

[PATCH v4 14/16] PPC: Add crypto node in device tree

2021-10-26 Thread Gaurav Jain
device tree imported from linux kernel. c500bee1c5b2 (tag: v5.14-rc4) Linux 5.14-rc4 Signed-off-by: Gaurav Jain Reviewed-by: Priyanka Jain --- arch/powerpc/dts/p2041si-post.dtsi | 1 + arch/powerpc/dts/p3041si-post.dtsi | 1 + arch/powerpc/dts/p4080si-post.dtsi | 1 +

[PATCH v4 13/16] Layerscape: Enable Job ring driver model in U-Boot.

2021-10-26 Thread Gaurav Jain
LS(1021/1012/1028/1043/1046/1088/2088), LX2160, LX2162 platforms are enabled with JR driver model. removed sec_init() call from board files. removed CONFIG_FSL_CAAM from defconfig files. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain

[PATCH v4 12/16] Layerscape: Add crypto node in device tree

2021-10-26 Thread Gaurav Jain
LS(1021/1012/1028/1043/1046/1088/2088), LX2160 - updated device tree Signed-off-by: Gaurav Jain Reviewed-by: Priyanka Jain --- arch/arm/dts/fsl-ls1012a.dtsi | 46 ++- arch/arm/dts/fsl-ls1043a.dtsi | 45 +-

[PATCH v4 09/16] i.MX8: Add crypto node in device tree

2021-10-26 Thread Gaurav Jain
i.MX8(QM/QXP) - updated device tree for supporting DM in SPL. disabled use of JR1 in SPL and uboot, as JR1 is reserved for SECO FW. Signed-off-by: Gaurav Jain Reviewed-by: Ye Li --- arch/arm/dts/fsl-imx8dx.dtsi | 61 +++- arch/arm/dts/fsl-imx8qm-mek-u-boot.dtsi

[PATCH v4 11/16] crypto/fsl: Fix kick_trng

2021-10-26 Thread Gaurav Jain
From: Ye Li fix hwrng performance issue in kernel. Signed-off-by: Ye Li Acked-by: Gaurav Jain > --- drivers/crypto/fsl/jr.c | 109 ++-- include/fsl_sec.h | 1 + 2 files changed, 94 insertions(+), 16 deletions(-) diff --git a/drivers/crypto/fsl/jr.c

[PATCH v4 10/16] crypto/fsl: i.MX8: Enable Job ring driver model in SPL and U-Boot.

2021-10-26 Thread Gaurav Jain
i.MX8(QM/QXP) - added support for JR driver model. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain Signed-off-by: Horia Geantă Reviewed-by: Ye Li --- arch/arm/Kconfig | 3 +++

[PATCH v4 08/16] i.MX7ULP: Enable Job ring driver model in U-Boot.

2021-10-26 Thread Gaurav Jain
added crypto node in device tree. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain Reviewed-by: Ye Li --- arch/arm/Kconfig | 2 +- arch/arm/dts/imx7ulp.dtsi| 24

[PATCH v4 07/16] i.MX7: Enable Job ring driver model in U-Boot.

2021-10-26 Thread Gaurav Jain
i.MX7D - added support for JR driver model. removed sec_init() call, sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain Reviewed-by: Ye Li --- arch/arm/Kconfig | 2 +- arch/arm/mach-imx/mx7/Kconfig | 3 +++

[PATCH v4 06/16] i.MX6: Enable Job ring driver model in U-Boot.

2021-10-26 Thread Gaurav Jain
i.MX6,i.MX6SX,i.MX6UL - added support for JR driver model. removed sec_init() call, sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain Reviewed-by: Ye Li --- arch/arm/mach-imx/mx6/Kconfig | 20

[PATCH v4 05/16] mx6sabre: Remove unnecessary SPL configs

2021-10-26 Thread Gaurav Jain
From: Ye Li Because we don't use SPL_DM on mx6sabresd and mx6sabreauto, so it is unnecessary to have SPL DTB related configs and SPL_OF_CONTROL enabled. Signed-off-by: Ye Li Reviewed-by: Fabio Estevam Reviewed-by: Gaurav Jain --- configs/mx6sabreauto_defconfig | 2 --

[PATCH v4 04/16] crypto/fsl: i.MX8M: Enable Job ring driver model in SPL and U-Boot.

2021-10-26 Thread Gaurav Jain
i.MX8MM/MN/MP/MQ - added support for JR driver model. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain Reviewed-by: Ye Li --- arch/arm/Kconfig | 2 +- arch/arm/include/asm/arch-imx8m/imx-regs.h | 1 +

[PATCH v4 03/16] i.MX8M: crypto: updated device tree for supporting DM in SPL

2021-10-26 Thread Gaurav Jain
disabled use of JR0 in SPL and uboot, as JR0 is reserved for secure boot. Signed-off-by: Gaurav Jain Reviewed-by: Ye Li --- arch/arm/dts/imx8mm-evk-u-boot.dtsi | 18 +- arch/arm/dts/imx8mm.dtsi | 1 + arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 18

[PATCH v4 02/16] crypto/fsl: Add CAAM support for bkek, random number generation

2021-10-26 Thread Gaurav Jain
added api and descriptor for blob key encryption key(bkek) generation. added api for random number generation. Signed-off-by: Gaurav Jain Signed-off-by: Ji Luo Reviewed-by: Ye Li --- drivers/crypto/fsl/desc.h | 5 +++ drivers/crypto/fsl/fsl_blob.c | 82 +++

[PATCH v4 01/16] crypto/fsl: Add support for CAAM Job ring driver model

2021-10-26 Thread Gaurav Jain
added device tree support for job ring driver. sec is initialized based on job ring information processed from device tree. Signed-off-by: Gaurav Jain Reviewed-by: Ye Li --- cmd/Kconfig | 1 + drivers/crypto/fsl/Kconfig | 7 + drivers/crypto/fsl/Makefile | 4 +-

  1   2   >