[PATCH 3/5] firmware: scmi: mailbox transport: use plat data, not priv data

2021-11-07 Thread Etienne Carriere
Change SCMI mailbox transport drivers to use platform data rather than private data for channel reference since it only stores platform data retrieved from the DT. Consequently the probe handler is replaced with a of_to_plat handler. Cc: Simon Glass Cc: Patrice Chotard Cc: Patrick Delaunay

[PATCH 4/5] firmware: scmi: smccc transport: use plat data, not priv data

2021-11-07 Thread Etienne Carriere
Change SCMI smccc transport drivers to use platform data rather than private data for channel reference since it only stores platform data retrieved from the DT. Consequently the probe handler is replaced with a of_to_plat handler. Cc: Simon Glass Cc: Patrice Chotard Cc: Patrick Delaunay

[PATCH 5/5] firmware: scmi: smccc transport: simplify probe sequence

2021-11-07 Thread Etienne Carriere
Minor simplification in scmi_smccc_probe() exit sequence. Cc: Simon Glass Cc: Patrice Chotard Cc: Patrick Delaunay Signed-off-by: Etienne Carriere --- Changes since v1: - No change. Patch re-send. --- drivers/firmware/scmi/smccc_agent.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH 2/5] firmware: scmi: mailbox transport: fix probe failure implementation

2021-11-07 Thread Etienne Carriere
Correct scmi mailbox probe function that can't free the scmi channel instance since its auto-allocated by the device model framework. Cc: Simon Glass Cc: Patrice Chotard Cc: Patrick Delaunay Signed-off-by: Etienne Carriere --- Changes since v1: - No change. Patch re-send. ---

[PATCH 1/5] firmware: scmi: fix description of an API function

2021-11-07 Thread Etienne Carriere
Correct inline comment describing API function devm_scmi_process_msg(). Signed-off-by: Etienne Carriere --- include/scmi_agent.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/scmi_agent.h b/include/scmi_agent.h index f1be9ff209..ed40c7360a 100644 ---

Re: [PATCH 14/14] [HACK] configs: stm32mp15: enable earlyprintk

2021-11-07 Thread Etienne Carriere
Dear ML, My apologies for this series. I intended to post only the 5 first ones. Please discard those 14 patches. I'll close all of them through patchwork and will re-send a corrected series. Regards, Etienne On Thu, 4 Nov 2021 at 15:23, Etienne Carriere wrote: > > Increase

Re: [PATCH v4 09/34] efi: Add EFI uclass for media

2021-11-07 Thread AKASHI Takahiro
On Sun, Nov 07, 2021 at 09:43:22AM -0700, Simon Glass wrote: > Hi Heinrich, > > On Sun, 7 Nov 2021 at 01:21, Heinrich Schuchardt wrote: > > > > > > > > On 11/4/21 04:09, Simon Glass wrote: > > > At present UCLASS_EFI is used to represent an EFI filesystem among other > > > things. The

Re: [PATCH v5 02/11] tools: mkeficapsule: add firmwware image signing

2021-11-07 Thread AKASHI Takahiro
Heinrich, On Fri, Nov 05, 2021 at 06:35:08PM +0900, AKASHI Takahiro wrote: > On Fri, Nov 05, 2021 at 11:35:00AM +0900, AKASHI Takahiro wrote: > > On Thu, Nov 04, 2021 at 08:02:40PM -0600, Simon Glass wrote: > > > Hi Takahiro, > > > > > > On Thu, 4 Nov 2021 at 19:04, AKASHI Takahiro > > >

Re: [RFC 07/22] dm: blk: add UCLASS_PARTITION

2021-11-07 Thread AKASHI Takahiro
On Fri, Nov 05, 2021 at 10:12:16AM -0600, Simon Glass wrote: > Hi Takahiro, > > On Thu, 4 Nov 2021 at 20:49, AKASHI Takahiro > wrote: > > > > On Thu, Nov 04, 2021 at 08:02:05PM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Tue, 2 Nov 2021 at 01:43, Heinrich Schuchardt > > > wrote: > > >

Re: [PATCH v6 03/12] tools: mkeficapsule: add firmwware image signing

2021-11-07 Thread AKASHI Takahiro
On Sun, Nov 07, 2021 at 07:53:24AM +0100, Heinrich Schuchardt wrote: > On 11/2/21 01:55, AKASHI Takahiro wrote: > > With this enhancement, mkeficapsule will be able to sign a capsule > > file when it is created. A signature added will be used later > > in the verification at FMP's SetImage() call.

Re: [PATCH v6 02/12] tools: mkeficapsule: rework the code a little bit

2021-11-07 Thread AKASHI Takahiro
On Sun, Nov 07, 2021 at 07:35:04AM +0100, Heinrich Schuchardt wrote: > On 11/2/21 01:55, AKASHI Takahiro wrote: > > Abstract common routines to make the code easily understandable. > > No functional change. > > > > Signed-off-by: AKASHI Takahiro > > Reviewed-by: Simon Glass > > --- > >

Re: [PATCH v5 05/11] test/py: efi_capsule: add image authentication test

2021-11-07 Thread AKASHI Takahiro
On Fri, Nov 05, 2021 at 10:12:20AM -0600, Simon Glass wrote: > Hi Takahiro, > > On Thu, 4 Nov 2021 at 21:24, AKASHI Takahiro > wrote: > > > > On Thu, Nov 04, 2021 at 08:02:37PM -0600, Simon Glass wrote: > > > Hi Takahiro, > > > > > > On Thu, 4 Nov 2021 at 19:21, AKASHI Takahiro > > > wrote: >

[PATCH 19/20] Remove CONFIG_SERIAL_MULTI

2021-11-07 Thread Tom Rini
This symbol has been functionally dead for a long time. Remove the last and recent re-introductions of setting it, and update the whitelist so it will not be re-introduced again. Signed-off-by: Tom Rini --- arch/arm/include/asm/arch-bcmcygnus/configs.h | 1 - include/configs/p2571.h

[PATCH 17/20] Convert CONFIG_MACB to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_MACB Signed-off-by: Tom Rini --- configs/axm_defconfig | 2 +- configs/corvus_defconfig | 2 +- configs/ethernut5_defconfig | 2 ++ configs/gurnard_defconfig | 2 +-

[PATCH 20/20] Convert CONFIG_LAST_STAGE_INIT to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_LAST_STAGE_INIT Signed-off-by: Tom Rini --- configs/cortina_presidio-asic-base_defconfig | 1 + configs/cortina_presidio-asic-emmc_defconfig | 1 + configs/cortina_presidio-asic-pnand_defconfig | 1 + configs/octeontx2_95xx_defconfig

[PATCH 14/20] Convert CONFIG_IMX_BOOTAUX et al to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_IMX_BOOTAUX CONFIG_IMX_THERMAL Signed-off-by: Tom Rini --- configs/imx8mq_cm_defconfig | 1 + configs/imx8mq_evk_defconfig| 1 + configs/imx8mq_phanbell_defconfig | 1 + configs/pico-imx8mq_defconfig | 1 +

[PATCH 18/20] Convert CONFIG_PL011_SERIAL et al to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_PL011_SERIAL CONFIG_PL01X_SERIAL Signed-off-by: Tom Rini --- README | 4 configs/lx2160aqds_tfa_SECURE_BOOT_defconfig | 1 + configs/lx2160aqds_tfa_defconfig | 1 +

[PATCH 16/20] Convert CONFIG_MD5 to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_MD5 Signed-off-by: Tom Rini --- configs/SBx81LIFKW_defconfig | 1 + configs/SBx81LIFXCAT_defconfig | 1 + include/configs/SBx81LIFKW.h | 1 - include/configs/SBx81LIFXCAT.h | 1 - 4 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 12/20] Convert CONFIG_I2C_EDID et al to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_I2C_EDID CONFIG_I2C_EEPROM Signed-off-by: Tom Rini --- README | 5 - configs/gwventana_emmc_defconfig | 1 + configs/gwventana_gw5904_defconfig | 1 + configs/gwventana_nand_defconfig | 1 +

[PATCH 13/20] # This is a combination of 2 commits. # This is the 1st commit message:

2021-11-07 Thread Tom Rini
Convert CONFIG_SYS_PROMPT et al to Kconfig This converts the following to Kconfig: CONFIG_SYS_PROMPT CONFIG_SYS_PROMPT_HUSH_PS2 Signed-off-by: Tom Rini --- configs/imx8mq_evk_defconfig | 1 + configs/s5p4418_nanopi2_defconfig| 1 + include/configs/apalis-imx8x.h | 1 -

[PATCH 11/20] Convert CONFIG_PHYLIB et al to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_PHYLIB CONFIG_PHY_ATHEROS CONFIG_PHY_GIGE CONFIG_MII Signed-off-by: Tom Rini --- configs/brppt2_defconfig | 1 + configs/imx8mq_evk_defconfig | 2 ++ configs/imx8mq_phanbell_defconfig

[PATCH 15/20] Convert CONFIG_MX6 et al to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_MX6 CONFIG_MX7 Signed-off-by: Tom Rini --- include/configs/mx6_common.h | 4 include/configs/mx7_common.h | 4 2 files changed, 8 deletions(-) diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h index

[PATCH 10/20] Convert CONFIG_MISC_INIT_F et al to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_MISC_INIT_F CONFIG_MISC_INIT_R Signed-off-by: Tom Rini --- configs/kmcent2_defconfig | 1 + configs/ls1088aqds_tfa_defconfig| 1 + configs/sama5d2_icp_mmc_defconfig | 1 + configs/sama5d2_icp_qspiflash_defconfig |

[PATCH 09/20] Convert CONFIG_TRACE et al to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_TRACE CONFIG_TRACE_BUFFER_SIZE CONFIG_TRACE_EARLY CONFIG_TRACE_EARLY_ADDR CONFIG_TRACE_EARLY_SIZE Signed-off-by: Tom Rini --- include/configs/exynos5-common.h | 8 include/configs/sandbox.h| 8 2 files

[PATCH 08/20] Convert CONFIG_SYS_CONSOLE_IS_IN_ENV to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SYS_CONSOLE_IS_IN_ENV Signed-off-by: Tom Rini --- README | 4 configs/ci20_mmc_defconfig | 1 + include/configs/ci20.h | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/README b/README index

[PATCH 07/20] Convert CONFIG_ENV_IS_IN_SPI_FLASH et al to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_ENV_IS_IN_SPI_FLASH CONFIG_ENV_IS_NOWHERE CONFIG_ENV_OFFSET CONFIG_ENV_OVERWRITE CONFIG_ENV_SECT_SIZE CONFIG_SYS_MMC_ENV_DEV CONFIG_SYS_MMC_ENV_PART Signed-off-by: Tom Rini --- configs/cgtqmx8_defconfig| 1 +

[PATCH 06/20] Convert CONFIG_FSL_USDHC to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_FSL_USDHC Signed-off-by: Tom Rini --- configs/imx8mm-cl-iot-gate-optee_defconfig | 2 +- configs/imx8mm-cl-iot-gate_defconfig | 2 +- configs/imx8mm_evk_defconfig | 2 +- configs/imx8mn_ddr4_evk_defconfig | 2 +-

[PATCH 05/20] Convert CONFIG_FSL_LAYERSCAPE to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_FSL_LAYERSCAPE Signed-off-by: Tom Rini --- arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 2 ++ include/configs/lx2160a_common.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig

[PATCH 03/20] Convert CONFIG_DOS_PARTITION to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_DOS_PARTITION Signed-off-by: Tom Rini --- configs/SBx81LIFKW_defconfig | 1 + configs/SBx81LIFXCAT_defconfig | 1 + configs/bcm7260_defconfig | 1 + configs/bcm7445_defconfig | 1 + include/configs/SBx81LIFKW.h | 1 -

[PATCH 04/20] Convert CONFIG_BITBANGMII to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_BITBANGMII Signed-off-by: Tom Rini --- configs/r8a779a0_falcon_defconfig | 1 + include/configs/falcon.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/r8a779a0_falcon_defconfig

[PATCH 02/20] Convert CONFIG_E1000 to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_E1000 Signed-off-by: Tom Rini --- README | 7 --- configs/clearfog_gt_8k_defconfig| 1 + configs/mvebu_crb_cn9130_defconfig | 1 + configs/mvebu_db_armada8k_defconfig | 1 +

[PATCH 01/20] Convert CONFIG_ARCH_CPU_INIT to Kconfig

2021-11-07 Thread Tom Rini
This converts the following to Kconfig: CONFIG_ARCH_CPU_INIT Signed-off-by: Tom Rini --- configs/s5p4418_nanopi2_defconfig | 1 + include/configs/s5p4418_nanopi2.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/s5p4418_nanopi2_defconfig

[PATCH] drivers: musb_gadget: Save endpoint desc to usb_ep->desc

2021-11-07 Thread qianfanguijin
From: qianfan Zhao Fix fastboot flash bug. If the downloading file size is equal to the partition size, "fastboot flash" can't work, at least in sunxi platform, because used an uninitalized point: ep->desc. Reproduce: fastboot flash loader1 spl/sunxi-spl.bin. Signed-off-by: qianfan Zhao ---

[v2, PATCH] lib: sparse: Make CHUNK_TYPE_RAW buffer aligned

2021-11-07 Thread qianfanguijin
From: qianfan Zhao CHUNK_TYPE_RAW buffer is not aligned, and flash sparse images by fastboot will report "Misaligned operation" if DCACHE is enabled. Flashing Sparse Image CACHE: Misaligned operation at range [8428, 84001028] CACHE: Misaligned operation at range [84001034, 84002034] CACHE:

Re: [PATCH] lib: sparse: Make CHUNK_TYPE_RAW buffer aligned

2021-11-07 Thread qianfan
在 2021/11/5 23:06, Sean Anderson 写道: Hi quanfan, Thanks for the patch. I had something similar in mind. On 11/5/21 1:46 AM, qianfangui...@qq.com wrote: From: qianfan Zhao CHUNK_TYPE_RAW buffer is not aligned, and flash sparse images by fastboot will report "Misaligned operation" if DCACHE

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-07 Thread Tony Dinh
Hi Pali, On Sun, Nov 7, 2021 at 4:58 PM Tony Dinh wrote: > > Hi Pali, > > Looks like it is working! But in a weird way. Please see my responses > in between, and also in the test log below. > > On Sun, Nov 7, 2021 at 3:45 PM Pali Rohár wrote: > > > > Hello! > > > > On Sunday 07 November 2021

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-07 Thread Tony Dinh
Hi Pali, Looks like it is working! But in a weird way. Please see my responses in between, and also in the test log below. On Sun, Nov 7, 2021 at 3:45 PM Pali Rohár wrote: > > Hello! > > On Sunday 07 November 2021 12:56:37 Tony Dinh wrote: > > Hi Pali, > > > > I've applied your patch, and ran

Re: [PATCH v2 0/1] add selftest for EFI_TCG2_PROTOCOL and Measured Boot

2021-11-07 Thread Masahisa Kojima
Hi Heinrich, On Sun, 7 Nov 2021 at 17:30, Heinrich Schuchardt wrote: > > On 11/4/21 11:45, Masahisa Kojima wrote: > > This patch adds the selftest for the EFI_TCG2_PROTOCOL and > > Measured Boot flow. > > This selftest is verified on qemu with swtpm on both 32-bit arm > > and arm64. > > > > This

Testing pci_mvebu.c with Kirkwood SoCs

2021-11-07 Thread Pali Rohár
Hello! On Sunday 07 November 2021 12:56:37 Tony Dinh wrote: > Hi Pali, > > I've applied your patch, and ran some tests. Looks like we got to the > bind, but it was not probing (or the probe died silently). Later, I > tried pci enum and got some errors during probing. It looks like that

[PATCH 8/8 v6] MAINTAINERS: Add entry for TPM drivers

2021-11-07 Thread Ilias Apalodimas
TPM drivers have currently no maintainers. Add myself since I contributed the TIS implementation. Reviewed-by: Heinrich Schuchardt Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH 5/8 v6] tpm: Use the new API on tpm2 spi driver

2021-11-07 Thread Ilias Apalodimas
Convert our SPI TPM driver and use the newly added API Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- drivers/tpm/Makefile | 2 +- drivers/tpm/tpm2_tis_spi.c | 447 +++-- 2 files changed, 32 insertions(+), 417 deletions(-) diff --git

[PATCH 6/8 v6] configs: Enable tpmv2 mmio on qemu for arm/arm64

2021-11-07 Thread Ilias Apalodimas
A previous commit is adding an MMIO TPMv2 driver. Include in the default qemu arm configs, since we plan on using them on EFI testing Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- configs/qemu_arm64_defconfig | 2 ++ configs/qemu_arm_defconfig | 2 ++ 2 files changed, 4

[PATCH 7/8 v6] doc: qemu: Add instructions for swtpm usage

2021-11-07 Thread Ilias Apalodimas
A previous patch added support for an mmio based TPM. Add an example in QEMU on it's usage Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- doc/board/emulation/qemu-arm.rst | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH 4/8 v6] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-07 Thread Ilias Apalodimas
Add support for devices that expose a TPMv2 though MMIO. Apart from those devices, we can use the driver in our QEMU setups and test TPM related code which is difficult to achieve using the sandbox driver (e.g test the EFI TCG2 protocol). It's worth noting that a previous patch added TPMv2 TIS

[PATCH 3/8 v6] tpm2: Introduce TIS tpm core

2021-11-07 Thread Ilias Apalodimas
There's a lot of code duplication in U-Boot right now. All the TPM TIS compatible drivers we have at the moment have their own copy of a TIS implementation. So let's create a common layer which implements the core TIS functions. Any driver added from now own, which is compatible with the TIS

[PATCH 2/8 v6] tpm: refactor function names for LPC based TPMs

2021-11-07 Thread Ilias Apalodimas
With the upcoming TPM2 API, some of the function names are part of the new header file. So switch conflicting driver defined function names and defines. Signed-off-by: Ilias Apalodimas --- drivers/tpm/tpm_tis_lpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/8 v6] tpm: refactor function names and macros for infineon v1.2 TPM

2021-11-07 Thread Ilias Apalodimas
With the upcoming TPM2 API, some of the function names are part of the new header file. So switch conflicting driver defined function names and defines. Signed-off-by: Ilias Apalodimas --- drivers/tpm/tpm_tis_infineon.c | 34 +- 1 file changed, 17 insertions(+),

[PATCH 0/8 v6] TPM cleanups and MMIO driver

2021-11-07 Thread Ilias Apalodimas
Hi! This is the update for [1]. Changes since v5: - Fixed 2 tpmv1.2 drivers. Some of the internal driver functions were conflicting with the new API Changes since v4: - renamed struct udevice *udev -> struct udevice *dev - added comments on struct tpm_tis_phy_ops - removed duplicate defines

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-07 Thread Tony Dinh
Hi Pali, I've applied your patch, and ran some tests. Looks like we got to the bind, but it was not probing (or the probe died silently). Later, I tried pci enum and got some errors during probing. Here is the log (I added some debug printf to drivers/pci/pci_mvebu.c and drivers/core/device.c to

Pull request for efi-2022-01-rc2

2021-11-07 Thread Heinrich Schuchardt
The following changes since commit 52207514ba419a69a8105d16997b025f966c8879: Merge branch '2021-11-05-Kconfig-syncs' (2021-11-05 15:38:46 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2022-01-rc2 for you to fetch changes up

Re: [PATCH 0/6 v5] TPM cleanups and MMIO driver

2021-11-07 Thread Heinrich Schuchardt
Building snow_defconfig fails: AR drivers/watchdog/built-in.o drivers/tpm/tpm_tis_infineon.c:53: warning: "TPM_ACCESS" redefined 53 | #define TPM_ACCESS(l) (0x | ((l) << 4)) | In file included from drivers/tpm/tpm_tis_infineon.c:34: drivers/tpm/tpm_tis.h:75:

Re: rk3399-gru-kevin: issues on bringup

2021-11-07 Thread Alper Nebi Yasak
On 06/11/2021 06:16, Simon Glass wrote: > On Tue, 2 Nov 2021 at 17:05, Simon Glass wrote: >> On Mon, 1 Nov 2021 at 17:25, Alper Nebi Yasak >> wrote: >>> Most of the patches are small config and dts changes that I've grouped >>> by whatever effect they have. Should I squash them into one commit

Read from TPM2 NV Index

2021-11-07 Thread Harshvardhan Patel
Hi All, I am working with Infineon TPM SLB9670 connected to a Raspberry Pi 4 via the GPIO Header. I want to perform a simple NV Index read operation from NV Index 1 in U-Boot. This NV Index was defined and written to in Linux userspace using tpm2-tools (following the man page here -

Re: [PATCH v4 09/34] efi: Add EFI uclass for media

2021-11-07 Thread Simon Glass
Hi Heinrich, On Sun, 7 Nov 2021 at 01:21, Heinrich Schuchardt wrote: > > > > On 11/4/21 04:09, Simon Glass wrote: > > At present UCLASS_EFI is used to represent an EFI filesystem among other > > things. The description of this uclass is "EFI managed devices" which is > > pretty vague. The only

Re: [PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-07 Thread Simon Glass
Hi Andy, On Sat, 6 Nov 2021 at 01:59, Andy Shevchenko wrote: > > > > On Saturday, November 6, 2021, Simon Glass wrote: >> >> Hi Andy, >> >> On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko >> wrote: >> > >> > Compiler is not happy: >> > >> > common/image-board.c: In function ‘boot_get_kbd’: >> >

[PATCH 2/3] arm: socfpga: arria10: Reset MPFE NoC after program periph / combined RBF

2021-11-07 Thread sin . hui . kho
From: Tien Fong Chee This patch triggers warm reset to recover the MPFE NoC from corruption due to high frequency transient clock output from HPS EMIF IOPLL at VCO startup after peripheral RBF is programmed. Signed-off-by: Tien Fong Chee Signed-off-by: Sin Hui Kho ---

[PATCH 3/3] arm: socfpga: arria10: Enable double peripheral RBF configuration

2021-11-07 Thread sin . hui . kho
From: Tien Fong Chee Double peripheral RBF configuration are needed on some devices or boards to stabilize the IO configuration system. Signed-off-by: Tien Fong Chee Signed-off-by: Sin Hui Kho --- arch/arm/mach-socfpga/include/mach/misc.h | 2 ++ arch/arm/mach-socfpga/misc_arria10.c |

[PATCH 1/3] arm: socfpga: arria10: Setting image magic value to romcode initswstate reg

2021-11-07 Thread sin . hui . kho
From: Tien Fong Chee The romcode_initswstate register need to be set with FSBL_IMAGE_IS_VALID value if the current FSBL image is found valid, otherwise BootROM will look for next subsequent valid FSBL image when warm reset is triggered. Signed-off-by: Tien Fong Chee Signed-off-by: Sin Hui Kho

Re: [RFC 0/2] Do not stop with an error when mkimage fails

2021-11-07 Thread Wolfgang Denk
Dear Heiko, In message you wrote: > > > > While converting to binman for an imx8mq board, it has been found that > > > building in the u-boot CI fails. This is because an imx8mq requires an > > > external binary (signed_hdmi_imx8m.bin). If this file cannot be found > > > mkimage fails. To work

Re: [PATCH v2 1/1] efi_selftest: add selftest for EFI_TCG2_PROTOCOL and Measured Boot

2021-11-07 Thread Heinrich Schuchardt
On 11/7/21 11:16, Heinrich Schuchardt wrote: On 11/4/21 11:45, Masahisa Kojima wrote: This commit adds the missing EFI_TCG2_PROTOCOL selftest and Measured Boot selftest in lib/efi_selftest. This selftest includes PE/COFF image measurement test, some PCR values are different in each

[BUG] tcg2 measurement fails(0x800000000000000e) if BootOrder not defined

2021-11-07 Thread Heinrich Schuchardt
Hello Masahisa, The UEFI specification does not require that BootOrder is defined. Instead /EFI/BOOT/BOOT.EFI will be booted if not BootOrder is defined. Currently tcg2 measurement fails with EFI_NOT_FOUND in this case. Please, correct tcg2_measure_boot_variable() to correctly handle booting

Re: [PATCH 0/6 v5] TPM cleanups and MMIO driver

2021-11-07 Thread Ilias Apalodimas
Hi Heinrich, On Sun, 7 Nov 2021 at 12:54, Heinrich Schuchardt wrote: > > > > On 11/5/21 20:05, Ilias Apalodimas wrote: > > Hi! > > This is the update for [1]. > > > > Changes since v4: > > - renamed struct udevice *udev -> struct udevice *dev > > - added comments on struct tpm_tis_phy_ops > > -

Re: [PATCH v2 1/1] efi_selftest: add selftest for EFI_TCG2_PROTOCOL and Measured Boot

2021-11-07 Thread Heinrich Schuchardt
On 11/4/21 11:45, Masahisa Kojima wrote: This commit adds the missing EFI_TCG2_PROTOCOL selftest and Measured Boot selftest in lib/efi_selftest. This selftest includes PE/COFF image measurement test, some PCR values are different in each architecture. With that, this commit also adds the

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-07 Thread Heinrich Schuchardt
On 11/6/21 14:53, Tom Rini wrote: On Sat, Nov 06, 2021 at 04:55:44AM +0100, Heinrich Schuchardt wrote: On 11/6/21 02:52, Andre Przywara wrote: On Fri, 5 Nov 2021 18:56:34 -0400 Tom Rini wrote: On Fri, Nov 05, 2021 at 09:38:50PM +0100, Heinrich Schuchardt wrote: On 11/5/21 20:17, Tom

Re: [PATCH 0/6 v5] TPM cleanups and MMIO driver

2021-11-07 Thread Heinrich Schuchardt
On 11/5/21 20:05, Ilias Apalodimas wrote: Hi! This is the update for [1]. Changes since v4: - renamed struct udevice *udev -> struct udevice *dev - added comments on struct tpm_tis_phy_ops - removed duplicate defines from tpm2_tis_spi driver (now in tpm_tis.h) - moved API function

Re: [PATCH v8 1/2] net: brcm: netXtreme driver

2021-11-07 Thread Pali Rohár
Hello! When sending a new version of patch, try to put into CC reviewers of previous versions, so they can approve new version (if objections were fixed). Not everybody is following all emails on mailing list as there are lot of emails... On Friday 05 November 2021 15:36:51 Roman Bacik wrote: >

Re: [PATCH v2 0/1] add selftest for EFI_TCG2_PROTOCOL and Measured Boot

2021-11-07 Thread Heinrich Schuchardt
On 11/4/21 11:45, Masahisa Kojima wrote: This patch adds the selftest for the EFI_TCG2_PROTOCOL and Measured Boot flow. This selftest is verified on qemu with swtpm on both 32-bit arm and arm64. This commit adds the pre-build binary for the PE/COFF image It seems that you have been compiling

Re: [PATCH v4 09/34] efi: Add EFI uclass for media

2021-11-07 Thread Heinrich Schuchardt
On 11/4/21 04:09, Simon Glass wrote: At present UCLASS_EFI is used to represent an EFI filesystem among other things. The description of this uclass is "EFI managed devices" which is pretty vague. The only driver that uses this uclass is in fact not a real U-Boot driver, since its operations

Re: [PATCH v4 08/34] efi: Add video support to the app

2021-11-07 Thread Heinrich Schuchardt
On 11/4/21 04:09, Simon Glass wrote: The current EFI video driver only works when running in the stub. In that case the stub calls boot services (before jumping to U-Boot proper) and copies the graphics info over to the efi table. This is necessary because the stub exits boot services before

Re: [PATCH v4 07/34] efi: Add a way to obtain boot services in the app

2021-11-07 Thread Heinrich Schuchardt
On 11/4/21 04:09, Simon Glass wrote: Add a function to return this information along with a stub for the efi_info_get() function, since calling it otherwise hangs U-Boot. Signed-off-by: Simon Glass --- (no changes since v1) include/efi.h | 8 +++- efi.h is used both by efi_loader

Re: [PATCH v4 06/34] x86: Don't duplicate global_ptr in 64-bit EFI app

2021-11-07 Thread Heinrich Schuchardt
On 11/4/21 04:09, Simon Glass wrote: This variable is already defined by the EFI code. Drop the duplicate definition when building a 64-bit EFI app. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt

Re: [PATCH v4 01/34] efi: Add a script to build an image for testing on UEFI

2021-11-07 Thread Heinrich Schuchardt
On 11/4/21 04:09, Simon Glass wrote: It is quite complicated to run U-Boot on QEMU since we have four different builds and they must use different versions of qemu and the UEFI binaries. Add a script to help. It requires U-Boot itself to be built. Once that is done you can use this script to

Re: [PATCH v6 03/12] tools: mkeficapsule: add firmwware image signing

2021-11-07 Thread Heinrich Schuchardt
On 11/2/21 01:55, AKASHI Takahiro wrote: With this enhancement, mkeficapsule will be able to sign a capsule file when it is created. A signature added will be used later in the verification at FMP's SetImage() call. To do that, We need specify additional command parameters: -monotonic-cout

Re: [PATCH v6 02/12] tools: mkeficapsule: rework the code a little bit

2021-11-07 Thread Heinrich Schuchardt
On 11/2/21 01:55, AKASHI Takahiro wrote: Abstract common routines to make the code easily understandable. No functional change. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- tools/mkeficapsule.c | 219 ++- 1 file changed, 155