Re: [RESEND PATCH] usb: mtu3: flush cache for the first GPD when allocate GPD ring

2021-11-12 Thread Chunfeng Yun
Hi Marek, On Thu, 2021-10-21 at 13:33 +0800, Chunfeng Yun wrote: > When allocate the GPD ring, and tell its address to the controller, > then > the driver starts or resumes the QMU, the controller will try to > access > the first GPD, so need flush the first one to avoid wrong GPD status. > > Rep

Re: [RESEND PATCH] usb: mtu3: flush cache for the first GPD when allocate GPD ring

2021-11-12 Thread Chunfeng Yun
Hi Marek, On Thu, 2021-10-21 at 13:33 +0800, Chunfeng Yun wrote: > When allocate the GPD ring, and tell its address to the controller, > then > the driver starts or resumes the QMU, the controller will try to > access > the first GPD, so need flush the first one to avoid wrong GPD status. > > Rep

Re: [RESEND PATCH] usb: mtu3: flush cache for the first GPD when allocate GPD ring

2021-11-12 Thread Chunfeng Yun
Hi Marek, On Thu, 2021-10-21 at 13:33 +0800, Chunfeng Yun wrote: > When allocate the GPD ring, and tell its address to the controller, > then > the driver starts or resumes the QMU, the controller will try to > access > the first GPD, so need flush the first one to avoid wrong GPD status. > > Rep

Re: [RESEND PATCH] usb: mtu3: flush cache for the first GPD when allocate GPD ring

2021-11-12 Thread Chunfeng Yun
Hi Marek, On Thu, 2021-10-21 at 13:33 +0800, Chunfeng Yun wrote: > When allocate the GPD ring, and tell its address to the controller, > then > the driver starts or resumes the QMU, the controller will try to > access > the first GPD, so need flush the first one to avoid wrong GPD status. > > Rep

Re: [PATCH] pinctrl: meson: Correct the driver GPIO declaration

2021-11-12 Thread Tom Rini
On Fri, Nov 12, 2021 at 07:00:34PM -0700, Simon Glass wrote: > This should use the provided U_BOOT_DRIVER() macro so that the driver gets > added to the appropriate linker list. Fix it. > > Signed-off-by: Simon Glass > Fixes: 7c9dcfed50f ("pinctrl: meson: rework gx pmx function") Doesn't build

Re: [PATCH 00/16] tools: Add support for signing devicetree blobs

2021-11-12 Thread Simon Glass
Hi Heinrich, On Fri, 12 Nov 2021 at 17:02, Heinrich Schuchardt wrote: > > > > On 11/12/21 20:49, François Ozog wrote: > > Hi Simon > > > > Le ven. 12 nov. 2021 à 20:36, Simon Glass > > a écrit : > > > > At present mkimage supports signing FITs, the standard U-Boot i

Re: [PATCH v4 09/34] efi: Add EFI uclass for media

2021-11-12 Thread Simon Glass
Hi Heinrich, On Mon, 8 Nov 2021 at 08:58, Simon Glass wrote: > > Hi Heinrich, > > On Mon, 8 Nov 2021 at 08:39, Heinrich Schuchardt wrote: > > > > > > > > On 11/8/21 06:29, AKASHI Takahiro wrote: > > > On Sun, Nov 07, 2021 at 09:43:22AM -0700, Simon Glass wrote: > > >> Hi Heinrich, > > >> > > >>

Re: [PATCH v4 0/5] sf: Add documentation and an 'sf mmap' command

2021-11-12 Thread Simon Glass
Hi Jagan, On Sun, 19 Sept 2021 at 15:49, Simon Glass wrote: > > This little series adds documentation and a few other tidy-ups to the > 'sf' command. > > It also provides a way to access memory-mapped SPI via the command line. > > Changes in v4: > - Split out the 'const' change into a separate pa

[PATCH 2/2] ARM: dts: stm32: Auto-detect DHSOM with uSD level translator

2021-11-12 Thread Marek Vasut
The uSD level translator on DHSOM and Avenger96 are optional, however it is possible to auto-detect it. This is done by setting SD CMD line high, and then testing whether signal level on CK line matches the signal level on CKIN line. If so, the uSD level translator is present, otherwise it is not p

[PATCH 1/2] mmc: stm32_sdmmc2: Add support for probing bus voltage level translator

2021-11-12 Thread Marek Vasut
Add support for testing whether bus voltage level translator is present and operational. This is useful on systems where the bus voltage level translator is optional, as the translator can be auto-detected by the driver and the feedback clock functionality can be disabled if it is not present. The

[PATCH] ARM: stm32: Enable KSZ90x1 PHY driver on DHCOR

2021-11-12 Thread Marek Vasut
Enable KSZ9x01 PHY driver in DHCOR common configuration, since the AV96 board has this PHY populated on the PCB. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick Delaunay --- configs/stm32mp15_dhcor_basic_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/stm32mp

[PATCH] ARM: dts: stm32: Add custom PHY reset bindings on AV96

2021-11-12 Thread Marek Vasut
The ethernet PHY must be reset on AV96, however DWMAC currently does not support the MDIO-bus PHY GPIO reset bindings and the ethernet MAC PHY reset property is going away on next DT sync. Add PHY specific reset bindings to trigger the PHY reset and fix sporadic ethernet malfunctions, until the nex

[PATCH] ARM: stm32: Fix SoM and board coding strap GPIO handling on DHSOM

2021-11-12 Thread Marek Vasut
The variables retaining the strap values have to be initialized, always, make it so. Moreover, free the requested GPIO list at the end to avoid wasting memory. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick Delaunay --- board/dhelectronics/dh_stm32mp1/board.c | 14 ++ 1

[PATCH] ARM: stm32: Increase PHY auto-negotiation timeout to 20s on DHSOM

2021-11-12 Thread Marek Vasut
The Micrel PHYs on known DHSOM based boards take a while to come out of reset, increase the auto-negotiation timeout to prevent it from timing out in case the ethernet is used right after the board was reset. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick Delaunay --- include/confi

[PATCH] ARM: stm32: Add update_sf script to install U-Boot into SF on DHSOM

2021-11-12 Thread Marek Vasut
Add script to read U-Boot from SD card and write it to matching locations in the SPI NOR, thus making the SPI NOR bootable. The script erases the entire SPI NOR, including U-Boot environment, to make sure the installation is clean. To retain environment from current running U-Boot, run 'saveenv' af

[PATCH] ARM: stm32: Increase USB power-good delay on DHSOM

2021-11-12 Thread Marek Vasut
The USB hub on STM32MP1 DHCOM boards needs to wait a bit longer until the USB Vbus is stable. Increase the USB power-good delay to 1 s. This adds default-undefined STM32MP_BOARD_EXTRA_ENV variable into stm32mp15_common.h to reduce duplication in board-specific config files adding custom environmen

[PATCH] net: dwc_eth_qos: Enable clock in probe

2021-11-12 Thread Marek Vasut
Enable DWC IP clock in driver probe, so the MII access is possible even outside of active network transfers. This is particularly useful when using 'mii' or 'mdio' commands to explore PHY state, neither of which works with DWMAC currently due to the disabled clock. Signed-off-by: Marek Vasut Cc:

[PATCH] net: eth-phy: Handle gpio_request_by_name() return value

2021-11-12 Thread Marek Vasut
The gpio_request_by_name() returns zero in case of success, however the conditional return value check in gpio_request_by_name() checks only for (ret != -ENOENT) and if the condition is true, returns ret outright. This leads to a situation where successful gpio_request_by_name() return leads to im

[PATCH] pinctrl: meson: Correct the driver GPIO declaration

2021-11-12 Thread Simon Glass
This should use the provided U_BOOT_DRIVER() macro so that the driver gets added to the appropriate linker list. Fix it. Signed-off-by: Simon Glass Fixes: 7c9dcfed50f ("pinctrl: meson: rework gx pmx function") --- drivers/pinctrl/meson/pinctrl-meson-gx-pmx.c | 2 +- drivers/pinctrl/meson/pinctr

Re: [PATCH 20/20] Convert CONFIG_LAST_STAGE_INIT to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:51PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_LAST_STAGE_INIT > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 19/20] Remove CONFIG_SERIAL_MULTI

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:50PM -0500, Tom Rini wrote: > This symbol has been functionally dead for a long time. Remove the last > and recent re-introductions of setting it, and update the whitelist so > it will not be re-introduced again. > > Signed-off-by: Tom Rini Applied to u-boot/maste

Re: [PATCH 18/20] Convert CONFIG_PL011_SERIAL et al to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:49PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_PL011_SERIAL >CONFIG_PL01X_SERIAL > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 17/20] Convert CONFIG_MACB to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:48PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_MACB > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 16/20] Convert CONFIG_MD5 to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:47PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_MD5 > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 15/20] Convert CONFIG_MX6 et al to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:46PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_MX6 >CONFIG_MX7 > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 14/20] Convert CONFIG_IMX_BOOTAUX et al to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:45PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_IMX_BOOTAUX >CONFIG_IMX_THERMAL > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 13/20] Convert CONFIG_SYS_PROMPT et al to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:44PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_SYS_PROMPT >CONFIG_SYS_PROMPT_HUSH_PS2 > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 12/20] Convert CONFIG_I2C_EDID et al to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:43PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_I2C_EDID >CONFIG_I2C_EEPROM > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 11/20] Convert CONFIG_PHYLIB et al to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:42PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_PHYLIB >CONFIG_PHY_ATHEROS >CONFIG_PHY_GIGE >CONFIG_MII > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 08/20] Convert CONFIG_SYS_CONSOLE_IS_IN_ENV to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:39PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_SYS_CONSOLE_IS_IN_ENV > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 10/20] Convert CONFIG_MISC_INIT_F et al to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:41PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_MISC_INIT_F >CONFIG_MISC_INIT_R > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 09/20] Convert CONFIG_TRACE et al to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:40PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_TRACE >CONFIG_TRACE_BUFFER_SIZE >CONFIG_TRACE_EARLY >CONFIG_TRACE_EARLY_ADDR >CONFIG_TRACE_EARLY_SIZE > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! --

Re: [PATCH 07/20] Convert CONFIG_ENV_IS_IN_SPI_FLASH et al to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:38PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_ENV_IS_IN_SPI_FLASH >CONFIG_ENV_IS_NOWHERE >CONFIG_ENV_OFFSET >CONFIG_ENV_OVERWRITE >CONFIG_ENV_SECT_SIZE >CONFIG_SYS_MMC_ENV_DEV >CONFIG_SYS_MMC_ENV_PART > > Si

Re: [PATCH 06/20] Convert CONFIG_FSL_USDHC to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:37PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_FSL_USDHC > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 05/20] Convert CONFIG_FSL_LAYERSCAPE to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:36PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_FSL_LAYERSCAPE > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 04/20] Convert CONFIG_BITBANGMII to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:35PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_BITBANGMII > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 03/20] Convert CONFIG_DOS_PARTITION to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:34PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_DOS_PARTITION > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 02/20] Convert CONFIG_E1000 to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:33PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_E1000 > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 01/20] Convert CONFIG_ARCH_CPU_INIT to Kconfig

2021-11-12 Thread Tom Rini
On Sun, Nov 07, 2021 at 10:59:32PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_ARCH_CPU_INIT > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 00/16] tools: Add support for signing devicetree blobs

2021-11-12 Thread Heinrich Schuchardt
On 11/12/21 20:49, François Ozog wrote: Hi Simon Le ven. 12 nov. 2021 à 20:36, Simon Glass mailto:s...@chromium.org>> a écrit : At present mkimage supports signing FITs, the standard U-Boot image type. Various people are opposed to using FIT since: just to be sure: I am not one

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-12 Thread Tony Dinh
On Fri, Nov 12, 2021 at 2:42 PM Pali Rohár wrote: > > On Friday 12 November 2021 13:46:29 Tony Dinh wrote: > > Hi Stefan & Pali, > > > > On Fri, Nov 12, 2021 at 7:06 AM Pali Rohár wrote: > > > > > > On Friday 12 November 2021 15:36:31 Stefan Roese wrote: > > > > On 11/11/21 22:10, Pali Rohár wrot

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-12 Thread Pali Rohár
On Friday 12 November 2021 13:46:29 Tony Dinh wrote: > Hi Stefan & Pali, > > On Fri, Nov 12, 2021 at 7:06 AM Pali Rohár wrote: > > > > On Friday 12 November 2021 15:36:31 Stefan Roese wrote: > > > On 11/11/21 22:10, Pali Rohár wrote: > > > > On Wednesday 10 November 2021 16:04:20 Tony Dinh wrote:

Re: [PATCH] phy: rockchip: inno-usb2: fix hang when multiple controllers exit

2021-11-12 Thread Simon Glass
Hi, On Sat, 23 Oct 2021 at 12:19, Icenowy Zheng wrote: > > 在 2021-10-23星期六的 13:23 -0400,Siva Mahadevan写道: > > Icenowy Zheng wrote: > > > The OHCI and EHCI controllers are both bound to the same PHY. They > > > will > > > both do init and power_on operations when the controller is brought > > > up

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-12 Thread Tony Dinh
Also probably a new Kirkwood udevice is needed in drivers/usb/host/xhci-mvebu.c (if armada-380-xhci is not appropriate). static const struct udevice_id xhci_usb_ids[] = { { .compatible = "marvell,armada3700-xhci" }, { .compatible = "marvell,armada-380-xhci" }, { .compatible

Re: [PATCH v2 2/4] mtd: spi-nor-core: macronix: Add support for mx66lm1g45g

2021-11-12 Thread Pratyush Yadav
On 04/11/21 01:49AM, Tudor Ambarus wrote: > mx66lm1g45g supports just 1-1-1, 8-8-8 and 8d-8d-8d modes. > Tested in 1-1-1 and 8d-8d-8d modes using microchip's Octal SPI IP. > > Signed-off-by: Tudor Ambarus > --- > drivers/mtd/spi/Kconfig| 8 > drivers/mtd/spi/spi-nor-core.c | 74 +++

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-12 Thread Tony Dinh
Hi Stefan & Pali, On Fri, Nov 12, 2021 at 7:06 AM Pali Rohár wrote: > > On Friday 12 November 2021 15:36:31 Stefan Roese wrote: > > On 11/11/21 22:10, Pali Rohár wrote: > > > On Wednesday 10 November 2021 16:04:20 Tony Dinh wrote: > > > > I've also tried mdelay(3000), just to be sure. The result

Re: [BUG] RockPro64 not booting since 3ae64582fb

2021-11-12 Thread Alper Nebi Yasak
On 12/11/2021 19:39, Tom Rini wrote: > On Fri, Nov 12, 2021 at 11:35:15AM +0300, Aleksei wrote: > >> Hi U-boot developers, >> I'm booting RockPro64 by writing compiled u-boot-rockchip.bin to SD card >> offset >> 64 as described in doc/board/rockchip/rockchip.rst. There is a USB flash >> drive >>

Re: [PATCH v2 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2021-11-12 Thread Vagrant Cascadian
On 2021-11-11, Patrick Wildt wrote: > On Thu, Nov 11, 2021 at 12:21:26PM +0100, Patrick Wildt wrote: >> On Wed, Nov 10, 2021 at 02:26:54PM -0800, Vagrant Cascadian wrote: >> > On 2021-09-02, Patrick Wildt wrote: >> > > The MNT Reform 2 is a modular DIY laptop. In its initial version it >> > > is b

Re: [PATCH 00/16] tools: Add support for signing devicetree blobs

2021-11-12 Thread François Ozog
Hi Simon Le ven. 12 nov. 2021 à 20:36, Simon Glass a écrit : > At present mkimage supports signing FITs, the standard U-Boot image type. > > Various people are opposed to using FIT since: > just to be sure: I am not one of those. > > a) it requires adding support for FIT into other bootloaders,

[PATCH 00/16] tools: Add support for signing devicetree blobs

2021-11-12 Thread Simon Glass
At present mkimage supports signing FITs, the standard U-Boot image type. Various people are opposed to using FIT since: a) it requires adding support for FIT into other bootloaders, notably UEFI b) it requires packaging a kernel in this standard U-Boot format, meaning that distros must run

[PATCH 16/16] tools: Add man pages for fdt_sign and fdt_check_sign

2021-11-12 Thread Simon Glass
Add some documentation for these tools, along with a MAINTAINER entry. Signed-off-by: Simon Glass --- MAINTAINERS | 7 +++ doc/fdt_check_sign.1 | 74 + doc/fdt_sign.1 | 111 +++ 3 files changed, 192 insertions

[PATCH 13/16] tools: Add a new tool to sign FDT blobs

2021-11-12 Thread Simon Glass
This works similarly to FIT signing except that it signs the entire FDT (with a few exclusions), rather than just FIT configurations or images. Also it is a stand-alone tool rather than being part of mkimage. The signature is added to the FDT so it can be checked later, to ensure that no modifica

[PATCH 14/16] tools: Add a new tool to check FDT-blob signatures

2021-11-12 Thread Simon Glass
Add a stand-alone (from mkimage) tool that checks signatures in an FDT blob. Signed-off-by: Simon Glass --- tools/Makefile | 6 +- tools/fdt-host.c | 20 tools/fdt_check_sign.c | 85 ++ tools/fdt_host.h | 19 +++ tools/image-fdt-sig.c | 254 +++

[PATCH 15/16] test: Add a test for FDT signing

2021-11-12 Thread Simon Glass
Add a test which checks that signing and checking work, including signing an FDT twice. Signed-off-by: Simon Glass --- test/py/tests/test_fdt_sign.py | 83 test/py/tests/test_vboot.py | 21 ++-- test/py/tests/vboot/sign-fdt.dts | 23 + test/py

[PATCH 12/16] tools: mkimage: Show where signatures/keys are written

2021-11-12 Thread Simon Glass
At present mkimage displays the node information but it is not clear what signing action was taken. Add a message that shows it. For now it only supports showing a single signing action, since that is the common case. Sample: Signature written to 'sha1-basic/test.fit', node '/configurat

[PATCH 11/16] tools: Pass public-key node through to caller

2021-11-12 Thread Simon Glass
Update the two functions that call add_verify_data() so that the caller can see the node that was written to. Signed-off-by: Simon Glass --- tools/image-host.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/tools/image-host.c b/tools/image-host

[PATCH 10/16] image: Return destination node for add_verify_data() method

2021-11-12 Thread Simon Glass
It is useful to know where the verification data was written. Update the API to return this. Signed-off-by: Simon Glass --- include/image.h | 3 ++- include/u-boot/ecdsa.h | 5 +++-- include/u-boot/rsa.h| 5 +++-- lib/ecdsa/ecdsa-libcrypto.c | 4 ++-- lib/rsa/rsa-sign.c

[PATCH 09/16] tools: Pass the key blob around

2021-11-12 Thread Simon Glass
At present we rely on the key blob being in the global_data fdt_blob pointer. This is true in U-Boot but not with tools. For clarity, pass the parameter around. Signed-off-by: Simon Glass --- boot/image-fit-sig.c | 31 ++- boot/image-fit.c | 12 +++- comm

[PATCH 07/16] tools: Avoid confusion between keys and signatures

2021-11-12 Thread Simon Glass
We should be consistent in using the term 'signature' to describe a value added to sign something and 'key' to describe the key that can be used to verify the signature. Tidy up the code to stick to this. Add some comments to fit_config_verify_key() and its callers while we are here. Signed-off-

[PATCH 08/16] tools: Tidy up argument order in fit_config_check_sig()

2021-11-12 Thread Simon Glass
Put the parent node first in the parameters as this is more natural. Also add a comment to explain what is going on. Signed-off-by: Simon Glass --- boot/image-fit-sig.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/boot/image-fit-sig.c b/bo

[PATCH 05/16] tools: Improve comments in signing functions

2021-11-12 Thread Simon Glass
Add some more comments to explain what is going on in the signing functions. Fix two repeated typos. Signed-off-by: Simon Glass --- include/image.h| 2 +- tools/fdt_host.h | 8 tools/image-host.c | 98 +++--- 3 files changed, 85 insertions(+)

[PATCH 04/16] tools: Avoid leaving extra data at the end of copied files

2021-11-12 Thread Simon Glass
The copyfile() implementation has strange behaviour if the destination file already exists. Update it to ensure that any existing data in the destination file is dropped. Signed-off-by: Simon Glass --- tools/fit_common.c | 2 +- tools/fit_common.h | 2 ++ 2 files changed, 3 insertions(+), 1 del

[PATCH 06/16] tools: Drop unused name in image-host

2021-11-12 Thread Simon Glass
The name is created but never used. Drop it. Signed-off-by: Simon Glass --- tools/image-host.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/image-host.c b/tools/image-host.c index 73d35f3eee3..e4322d323a2 100644 --- a/tools/image-host.c +++ b/tools/image-host.c

[PATCH 03/16] tools: Move copyfile() into a common file

2021-11-12 Thread Simon Glass
This function is useful in other places. Move it to a common file. Signed-off-by: Simon Glass --- tools/fit_common.c | 56 ++ tools/fit_common.h | 11 + tools/fit_image.c | 56 -- 3 files changed, 6

[PATCH 02/16] fit_check_sign: Update help to mention the key is in a dtb

2021-11-12 Thread Simon Glass
The key is inside a dtb file, so tweak the help to make that clear. Signed-off-by: Simon Glass --- tools/fit_check_sign.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/fit_check_sign.c b/tools/fit_check_sign.c index 5573842d251..3d1d33fdab1 100644 --- a/tools/fit

[PATCH 01/16] rsa: Add debugging for failure cases

2021-11-12 Thread Simon Glass
Add some more debugging to make it easier to see what is being tried and what fails. Fix a few comment styles while here. Signed-off-by: Simon Glass --- lib/rsa/rsa-verify.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-ver

[PATCH v2 10/11] mmc: fsl_esdhc_imx: replace most #ifdefs by IS_ENABLED()

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit 52faec31827ec1a1837977e29c067424426634c5 ] Make the code cleaner and drop the old-style #ifdef constructs where it is possible. Signed-off-by: Michael Walle Signed-off-by: Sean Anderson --- (no changes since v1) drivers/mmc/fsl_esdhc_imx.c | 209 +--

[PATCH v2 11/11] mmc: fsl_esdhc_imx: set sysctl register for clock initialization

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit 263ddfc3454ead3a988adef39b962479adce2b28 ] The initial clock setting should be through sysctl register only, while the mmc_set_clock() will call mmc_set_ios() introduce other configurations like bus width, mode, and so on. Signed-off-by: Yangbo Lu Reviewed-by: Jaehoon Chung S

[PATCH v2 08/11] mmc: fsl_esdhc_imx: use dma-mapping API

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit b1ba1460a445bcc67972a617625d0349e4f22b31 ] Use the dma_{map,unmap}_single() calls. These will take care of the flushing and invalidation of caches. Signed-off-by: Michael Walle Signed-off-by: Sean Anderson --- (no changes since v1) drivers/mmc/fsl_esdhc_imx.c | 50

[PATCH v2 09/11] mmc: fsl_esdhc_imx: simplify esdhc_setup_data()

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit 7e48a028a42c111ba38a90b86e5f57dace980fa0 ] First, we need the waterlevel setting for PIO mode only. Secondy, both DMA setup code is identical for both directions, except for the data pointer. Thus, unify them. Signed-off-by: Michael Walle Signed-off-by: Sean Anderson --- (no

[PATCH v2 07/11] mmc: fsl_esdhc_imx: simplify 64bit check for SDMA transfers

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit da86e8cfcb03ed5c1d8e0718bc8bc8583e60ced8 ] SDMA can only do DMA with 32 bit addresses. This is true for all architectures (just doesn't apply to 32 bit ones). Simplify the code and remove unnecessary CONFIG_FSL_LAYERSCAPE. Also make the error message more concise. Signed-off-b

[PATCH v2 05/11] mmc: fsl_esdhc_imx: drop redundant code for non-removable feature

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit commit 08197cb8dff7cd097ab07a325093043c39d19bbd ] Drop redundant code for non-removable feature. "non-removable" property has been read in mmc_of_parse(). Signed-off-by: Yangbo Lu Signed-off-by: Sean Anderson --- (no changes since v1) drivers/mmc/fsl_esdhc_imx.c | 28 +

[PATCH v2 06/11] mmc: fsl_esdhc_imx: fix mmc->clock with actual clock

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit 30f6444d024a74ee48aa6969c1531aecd3c59deb ] Fix mmc->clock with actual clock which is divided by the controller, and record it with priv->clock. Signed-off-by: Yangbo Lu Signed-off-by: Sean Anderson --- (no changes since v1) drivers/mmc/fsl_esdhc_imx.c | 1 + 1 file changed

[PATCH v2 03/11] mmc: fsl_esdhc_imx: fix voltage validation

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit 5b05fc0310cd933acf76ee661577c6b07a95e684 ] Voltage validation should be done by CMD8. Current comparison between mmc_cfg voltages and host voltage capabilities is meaningless. So drop current comparison and let voltage validation is through CMD8. Signed-off-by: Yangbo Lu Signe

[PATCH v2 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] This patch is to clean up bus width setting code. - For DM_MMC, remove getting "bus-width" from device tree. This has been done in mmc_of_parse(). - For non-DM_MMC, move bus width configuration from fsl_esdhc_init() to fsl_esdhc_i

[PATCH v2 02/11] mmc: fsl_esdhc_imx: remove redundant DM_MMC checking

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit 2913926f3b3dec282f8773e3c02377c9600d8267 ] Remove redundant DM_MMC checking which is already in DM_MMC conditional compile block. Signed-off-by: Yangbo Lu Signed-off-by: Sean Anderson --- (no changes since v1) drivers/mmc/fsl_esdhc_imx.c | 2 -- 1 file changed, 2 deletions

[PATCH v2 01/11] mmc: fsl_esdhc_imx: make BLK as hard requirement of DM_MMC

2021-11-12 Thread Sean Anderson
[ fsl_esdhc commit 41dec2fe99512e941261594f522b2e7d485c314b ] U-boot prefers DM_MMC + BLK for MMC. Now eSDHC driver has already support it, so let's force to use it. - Drop non-BLK support for DM_MMC introduced by below patch. 66fa035 mmc: fsl_esdhc: fix probe issue without CONFIG_BLK enabled

[PATCH v2 00/11] fsl_esdhc_imx: port several patches from fsl_esdhc

2021-11-12 Thread Sean Anderson
This series ports some of the patches from fsl_esdhc to fsl_esdhc_imx. Because these drivers share a common lineage, many of these patches apply with minor changes. For each one, I have noted the originating commit in the style of linux stable backports. In fa33d20749 ("mmc: split fsl_esdhc driver

Re: [PATCH v10 3/9] env: Allow U-Boot scripts to be placed in a .env file

2021-11-12 Thread Daniel Golle
On Thu, Oct 21, 2021 at 09:08:46PM -0600, Simon Glass wrote: > At present U-Boot environment variables, and thus scripts, are defined > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > to this file and dealing with quoting and newlines is harder than it > should be. It wou

Re: [PATCH u-boot-marvell 09/11] phy: marvell: a3700: Convert to official DT bindings in COMPHY driver

2021-11-12 Thread Marek Behún
On Fri, 12 Nov 2021 14:29:54 +0100 Stefan Roese wrote: > On 11/3/21 03:02, Marek Behún wrote: > > From: Pali Rohár > > > > Convert A3720 common PHY driver to official DT bindings. > > > > This puts us closer to be able to synchronize A3720 device-trees with > > those from Linux. > > > > Signe

Re: [PATCH u-boot-marvell 03/11] fdt_support: Remove fdt_alloc_phandle() in favor of fdt_generate_phandle()

2021-11-12 Thread Marek Behún
On Fri, 12 Nov 2021 13:42:29 +0100 Stefan Roese wrote: > On 11/3/21 03:02, Marek Behún wrote: > > From: Marek Behún > > > > Commit f0921f5098d ("fdt: Sync up to the latest libfdt") introduced > > fdt_generate_phandle() in libfdt, making fdt_alloc_phandle() obsolete in > > fdt_support. > > > >

Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: enable A385 watchdog before disabling MCU watchdog

2021-11-12 Thread Tom Rini
On Fri, Nov 12, 2021 at 05:40:42PM +0100, Pali Rohár wrote: > On Friday 12 November 2021 11:31:38 Tom Rini wrote: > > On Fri, Nov 12, 2021 at 02:44:15PM +0100, Stefan Roese wrote: > > > On 11/9/21 17:14, Marek Behún wrote: > > > > From: Pali Rohár > > > > > > > > Commit aeb0ca64dbb5 ("arm: mvebu:

Re: [PATCH] cmd: pxe_utils: sysboot: add label override support

2021-11-12 Thread Amjad Ouled-Ameur
Hi Simon, On 06/11/2021 01:18, Amjad Ouled-Ameur wrote: Hi Simon, On 05/11/2021 03:02, Simon Glass wrote: Hi Amjad, On Fri, 22 Oct 2021 at 09:55, Amjad Ouled-Ameur wrote: This will allow consumers to choose a pxe label at runtime instead of having to prompt the user. One good use-case for t

Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: enable A385 watchdog before disabling MCU watchdog

2021-11-12 Thread Pali Rohár
On Friday 12 November 2021 11:31:38 Tom Rini wrote: > On Fri, Nov 12, 2021 at 02:44:15PM +0100, Stefan Roese wrote: > > On 11/9/21 17:14, Marek Behún wrote: > > > From: Pali Rohár > > > > > > Commit aeb0ca64dbb5 ("arm: mvebu: turris_omnia: disable MCU watchdog in > > > SPL when booting over UART"

Re: [BUG] RockPro64 not booting since 3ae64582fb

2021-11-12 Thread Tom Rini
On Fri, Nov 12, 2021 at 11:35:15AM +0300, Aleksei wrote: > Hi U-boot developers, > I'm booting RockPro64 by writing compiled u-boot-rockchip.bin to SD card > offset > 64 as described in doc/board/rockchip/rockchip.rst. There is a USB flash drive > plugged into USB2 port containing ext4 filesystem

Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: enable A385 watchdog before disabling MCU watchdog

2021-11-12 Thread Tom Rini
On Fri, Nov 12, 2021 at 02:44:15PM +0100, Stefan Roese wrote: > On 11/9/21 17:14, Marek Behún wrote: > > From: Pali Rohár > > > > Commit aeb0ca64dbb5 ("arm: mvebu: turris_omnia: disable MCU watchdog in > > SPL when booting over UART") disabled MCU watchdog when booting over > > UART to ensure tha

Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: enable A385 watchdog before disabling MCU watchdog

2021-11-12 Thread Stefan Roese
On 11/12/21 16:23, Pali Rohár wrote: On Friday 12 November 2021 14:44:15 Stefan Roese wrote: On 11/9/21 17:14, Marek Behún wrote: From: Pali Rohár Commit aeb0ca64dbb5 ("arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART") disabled MCU watchdog when booting over UART

Re: [PATCH u-boot-marvell 01/10] pci: pci_mvebu: Wait 100ms for Link Up in mvebu_pcie_probe()

2021-11-12 Thread Stefan Roese
On 11/12/21 16:44, Pali Rohár wrote: On Friday 12 November 2021 14:59:31 Stefan Roese wrote: On 11/11/21 16:35, Marek Behún wrote: From: Pali Rohár Function mvebu_pcie_probe() configures PCIe controller and sometimes it takes some time for PCIe card to bring link up. Delay mvebu_pcie_probe()

Re: [PATCH v1 1/1] usb: doc: Fix spelling issues in README.usb

2021-11-12 Thread Andy Shevchenko
On Fri, Nov 12, 2021 at 5:44 PM Marek Vasut wrote: > On 11/12/21 4:37 PM, Andy Shevchenko wrote: > > Fix spelling issues in README.usb. > > I'll let Tom do expert review on this and pick it if that's fine. That will work for me, thanks! > btw as a separate patch, would you be willing to convert

Re: [PATCH u-boot-marvell 01/10] pci: pci_mvebu: Wait 100ms for Link Up in mvebu_pcie_probe()

2021-11-12 Thread Pali Rohár
On Friday 12 November 2021 14:59:31 Stefan Roese wrote: > On 11/11/21 16:35, Marek Behún wrote: > > From: Pali Rohár > > > > Function mvebu_pcie_probe() configures PCIe controller and sometimes it > > takes some time for PCIe card to bring link up. Delay mvebu_pcie_probe() > > for 100ms to ensure

Re: [PATCH v1 1/1] usb: doc: Fix spelling issues in README.usb

2021-11-12 Thread Marek Vasut
On 11/12/21 4:37 PM, Andy Shevchenko wrote: Fix spelling issues in README.usb. I'll let Tom do expert review on this and pick it if that's fine. btw as a separate patch, would you be willing to convert this to RST format? diff --git a/doc/README.usb b/doc/README.usb index 05c62c3413c5..650a6

Re: [PATCH] rtc: ds1337: fix compatible string typo

2021-11-12 Thread Tom Rini
On Fri, Nov 05, 2021 at 02:46:50PM +0100, Clemens Gruber wrote: > The driver supports the ds1339 as well, which was probably intended by > the author but prevented by a typo. Fix the typo. > > Signed-off-by: Clemens Gruber Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [PATCH] boards: siemens: iot2050: Ignore network errors during bootstage tracking

2021-11-12 Thread Tom Rini
On Wed, Nov 03, 2021 at 03:12:30PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > We need to filter out NET_ETH_START errors because we have to enable > networking in order to propagate the MAC addresses to the DT while there > is no network driver for the prueth in U-Boot yet. > > Signed-off-

Re: [PATCH] boards: siemens: iot2050: Re-enable bootstage reporting

2021-11-12 Thread Tom Rini
On Wed, Nov 03, 2021 at 03:11:53PM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > This got lost while fixing up the condition in > board/siemens/iot2050/board.c > > Fixes: b55881dd ("bootstage: Add SPL support") > Signed-off-by: Jan Kiszka > Reviewed-by: Simon Glass Applied to u-boot/master

Re: [PATCH] ARM: dts: am335x-chiliboard: add /chosen/tick-timer

2021-11-12 Thread Tom Rini
On Tue, Nov 02, 2021 at 02:41:06PM +0100, Marcin Niestroj wrote: > Commit 4b2be78ab66c ("time: Fix get_ticks being non-monotonic") has > broken boot on chiliboard platform, as it requires '/chosen/tick-timer' > in device-tree. This resulted in following panic message: > > Could not initialize t

Re: [PATCH] Remove LYNX KDI remainders

2021-11-12 Thread Tom Rini
On Tue, Oct 26, 2021 at 02:31:18PM +0200, Thomas Huth wrote: > The last board that used to set CONFIG_LYNXKDI has been removed in > commit 242836a893ae ("powerpc: ppc4xx: remove pcs440ep support"), > doc/README.lynxkdi only talks about a MPC8260 board being supported, > and the mpc8260 support has

Re: [PATCH v3 18/18] pxe: Allow calling the pxe_get logic directly

2021-11-12 Thread Tom Rini
On Thu, Oct 14, 2021 at 12:48:11PM -0600, Simon Glass wrote: > Refactor this code so that we can call the 'pxe get' command without going > through the command-line interpreter. This makes it easier to get the > information we need, without going through environment variables. > > Signed-off-by:

Re: [PATCH] get_maintainer.pl: add .get_maintainer.conf

2021-11-12 Thread Tom Rini
On Sun, Oct 31, 2021 at 11:38:12PM +0100, Michael Walle wrote: > Since commit e57c7c5c4282 ("get_maintainer.pl: update from Linux kernel > v5.13-rc6") only the top level MAINTAINERS file is used. This is because > this commit (accidentally) disabled the search of MAINTAINERS files > (find_maintain

Re: [PATCH] Azure: Move to windows-2019

2021-11-12 Thread Tom Rini
On Sun, Oct 31, 2021 at 01:24:42PM -0400, Tom Rini wrote: > As per https://github.com/actions/virtual-environments/issues/4312 the > Windows-2016 environments are scheduled for deprecation and removal in > early 2022. Move to windows-2019 now to avoid this (Visual Studio 2019 > is included here,

Re: [PATCH v3 14/18] lib: Add a function to convert a string to a hex value

2021-11-12 Thread Tom Rini
On Thu, Oct 14, 2021 at 12:48:07PM -0600, Simon Glass wrote: > Add an xtoa() function, similar to itoa() but for hex instead. > > Signed-off-by: Simon Glass > Reviewed-by: Artem Lapkin > Tested-by: Artem Lapkin Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signa

  1   2   >