[PATCH 7/7] clk: Make clk_free return void

2022-01-15 Thread Sean Anderson
Most callers of this function do not check the return value, and it is unclear what action they should take if it fails. If a function is freeing multiple clocks, it should not stop just because the first one failed. Since the callbacks can no longer fail, just convert the return type to void.

[PATCH 6/7] spi: dw: Don't check clk_free

2022-01-15 Thread Sean Anderson
This function always succeeds, so don't check its return value. Signed-off-by: Sean Anderson --- drivers/spi/designware_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/designware_spi.c b/drivers/spi/designware_spi.c index 742121140d..9b9933b439 100644 ---

[PATCH 4/7] phy: bcm63xx: Don't check clk_free

2022-01-15 Thread Sean Anderson
This function always succeeds, so don't check its return value. Signed-off-by: Sean Anderson --- drivers/phy/bcm6318-usbh-phy.c | 4 +--- drivers/phy/bcm6348-usbh-phy.c | 4 +--- drivers/phy/bcm6368-usbh-phy.c | 8 ++-- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git

[PATCH 5/7] spi: bcm63xx: Don't check clk_free

2022-01-15 Thread Sean Anderson
This function always succeeds, so don't check its return value. Signed-off-by: Sean Anderson --- drivers/spi/bcm63xx_hsspi.c | 8 ++-- drivers/spi/bcm63xx_spi.c | 4 +--- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/spi/bcm63xx_hsspi.c

[PATCH 3/7] net: bcm63xx: Don't check clk_free

2022-01-15 Thread Sean Anderson
This function always succeeds, so don't check its return value. Signed-off-by: Sean Anderson --- drivers/net/bcm6348-eth.c | 6 +- drivers/net/bcm6368-eth.c | 6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/net/bcm6348-eth.c b/drivers/net/bcm6348-eth.c

[PATCH 1/7] clk: Make rfree return void

2022-01-15 Thread Sean Anderson
When freeing a clock there is not much we can do if there is an error, and most callers do not actually check the return value. Even e.g. checking to make sure that clk->id is valid should have been done in request() in the first place (unless someone is messing with the driver behind our back).

[PATCH 2/7] dma: bcm6348: Don't check clk_free

2022-01-15 Thread Sean Anderson
This function always succeeds, so don't check its return value. Signed-off-by: Sean Anderson --- drivers/dma/bcm6348-iudma.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/dma/bcm6348-iudma.c b/drivers/dma/bcm6348-iudma.c index c04aa55cb4..4fc650272d 100644

[PATCH 0/7] clk: Make clk_free return void

2022-01-15 Thread Sean Anderson
clk_free cleans up resources allocated by clk_request et. al. It returns an error code, but it really shouldn't. Much like regular free(), there is typically no way to handle an error, and errors from clk_free shouldn't prevent progress in the rest of the program. Make clk_free (and rfree) return

Re: [PATCH 00/11] Add support for SUNIV and F1C100s.

2022-01-15 Thread Jesse Taube
On 1/10/22 00:13, Tnze Jdao wrote: I tested this patch and tried to run it on my LicheePi Nano. It works, but I found there is WARNINGs when compile the code: --- include/configs/sunxi-common.h:128:0: warning: "CONFIG_ENV_SECT_SIZE" redefined #define CONFIG_ENV_SECT_SIZE 0x1000 Ah I

[PATCH v3 1/1] clk: Add clk_get_by_name_optional

2022-01-15 Thread Sean Anderson
This adds a helper function for clk_get_by_name in cases where the clock is optional. Hopefully this helps point driver writers in the right direction. Also convert some existing users. Signed-off-by: Sean Anderson Reviewed-by: Neil Armstrong Reviewed-by: Simon Glass --- Changes in v3: - Fix

[PATCH v3 0/1] clk: Clean up optional helpers, and add API docs to HTML

2022-01-15 Thread Sean Anderson
This cleans up the various optional helpers for clocks, and adds a new one. While we're at it, also convert the existing API docs to our HTML documentation. The rest of this series has been applied, but the former patch 5 had an error, so I did not apply it. I have fixed it in this revision.

Re: [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV

2022-01-15 Thread Dhananjay Phadke
On 1/14/2022 6:04 AM, Angus Ainslie wrote:   }, +    { +    INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024,  32, +    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | +    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) +    }, Shouldn't this be w25q16jvm, which seems to be

Re: [PATCH v2 0/5] clk: Clean up optional helpers, and add API docs to HTML

2022-01-15 Thread Sean Anderson
On Wed, 22 Dec 2021 12:11:09 -0500, Sean Anderson wrote: > This cleans up the various optional helpers for clocks, and adds a new one. > While we're at it, also convert the existing API docs to our HTML > documentation. > > Changes in v2: > - Clean up the argument list and descriptions > -

Re: (subset) [PATCH v2 1/2] clk: cdce9xx: Convert .of_xlate to .request

2022-01-15 Thread Sean Anderson
On Wed, 15 Dec 2021 11:47:17 -0500, Sean Anderson wrote: > This xlate function just performs some checking. We can do this in > request() instead and use the default xlate. > > Applied, thanks! [1/2] clk: cdce9xx: Convert .of_xlate to .request commit:

Re: [PATCH] clk: versaclock: Remove xlate function

2022-01-15 Thread Sean Anderson
On Wed, 1 Dec 2021 15:13:17 -0500, Sean Anderson wrote: > This function is the same as the default xlate. Remove it. > > Applied, thanks! [1/1] clk: versaclock: Remove xlate function commit: e4e8e01a194e256f2b85b9f97b52d93dde5238f5 Best regards, -- Sean Anderson

Re: [PATCH] clk: Remove no-op request and rfree callbacks

2022-01-15 Thread Sean Anderson
On Wed, 1 Dec 2021 14:51:00 -0500, Sean Anderson wrote: > These callbacks are optional. Remove ones which do nothing. > > Applied, thanks! [1/1] clk: Remove no-op request and rfree callbacks commit: 460970faec567f9285199140c6e5dbe2112bb843 Best regards, -- Sean Anderson

Re: [PATCH 0/3] clk: Some build infrastructure cleanups

2022-01-15 Thread Sean Anderson
On Wed, 15 Dec 2021 11:36:17 -0500, Sean Anderson wrote: > This makes some minor clean ups to the clock build infrastructure. > > > Sean Anderson (3): > clk: Alphabetize Makefile > clk: Alphabetize Kconfig > clk: Rename ICS8N3QV01 to CLK_ICS8N3QV01 > > [...] Applied, thanks! [1/3] clk:

Please pull u-boot-net/next

2022-01-15 Thread Ramon Fried
Hi Tom, Please pull the latest changes from u-boot-net/next branch which include: * PXE label override support * Fastboot UDP configurable port * new phy driver: TI DP83869HM * and few minor fixes to dsa. The following changes since commit 0dadad6d7c5769d6258baeaf1b8db843b0dfa01f: Merge tag

[PATCH 1/1] mkimage: struct stat.st_size may not be long

2022-01-15 Thread Heinrich Schuchardt
The component st_size of struct stat is of type off_t. Depending on the system printing it it with %ld leads to a warning: tools/mkimage.c:438:54: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'off_t' {aka 'long long int'} [-Wformat=] 438 | "%s: Bad

Re: [BUG] sandbox: NO_SDL=1 gcc: error: arch/sandbox/cpu/sdl.o: No such file or directory

2022-01-15 Thread Heinrich Schuchardt
On 1/13/22 14:41, Simon Glass wrote: Hi Heinrich, On Mon, 10 Jan 2022 at 16:22, Heinrich Schuchardt wrote: Hello Simon, compiling with SDL fails on Alpine Linux: https://gitlab.alpinelinux.org/alpine/aports/-/issues/13411 So I tried NO_SDL: make sandbox_defconfig NO_SDL=1 make menuconfig

Re: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk

2022-01-15 Thread Simon Glass
On Fri, 14 Jan 2022 at 10:35, Pali Rohár wrote: > > If image backend provides verify_header callback then call it after writing > image to disk. This ensures that written image is correct. > > Signed-off-by: Pali Rohár > --- > tools/mkimage.c | 41 + > 1

Re: [PATCH v4 2/6] clk: actions: Add SD/MMC clocks

2022-01-15 Thread Sean Anderson
On 11/28/21 6:32 AM, Amit Singh Tomar wrote: From: Amit Singh Tomar This commit adds SD/MMC clocks, and provides .set/get_rate callbacks for SD/MMC device present on Actions OWL S700 SoCs. Signed-off-by: Amit Singh Tomar --- Changes since v3: * No change. Changes since v2: *

Re: [PATCH v4 1/6] clk: actions: Introduce dummy get/set_rate callbacks

2022-01-15 Thread Sean Anderson
On 11/28/21 6:32 AM, Amit Singh Tomar wrote: From: Amit Singh Tomar This commit introduces get/set_rate callbacks, these are dummy at the moment, and can be used to get/set clock for various devices based on the clk id. Signed-off-by: Amit Singh Tomar --- Changes since v3: * No

Re: [PATCH v2 3/6] clk: sunxi: v3s: fix tabs / spaces

2022-01-15 Thread Sean Anderson
Hi Andre, On 5/26/21 7:16 PM, Andre Przywara wrote: On Sun, 23 May 2021 01:17:29 +0200 Andreas Rehn wrote: align CLK_USB_PHY0 with tabs Signed-off-by: Andreas Rehn Reviewed-by: Andre Przywara Cheers, Andre P.S. Please send a whole v2 series next time, to make this easier to sort out

Re: [PATCH v7 07/19] rockchip: rk3066: fix assigned-clocks rk3066_clk_set_rate

2022-01-15 Thread Sean Anderson
On 1/11/22 4:18 PM, Johan Jonker wrote: The rk3066 cru node has a number of assigned-clocks properties that call the .set_rate() function. Add them to the list so that they return a 0 instead of -ENOENT. Signed-off-by: Johan Jonker --- drivers/clk/rockchip/clk_rk3066.c | 9 + 1 file

Re: [PATCH v7 04/19] rockchip: rk3066: add clock driver for rk3066 soc

2022-01-15 Thread Sean Anderson
On 1/11/22 4:18 PM, Johan Jonker wrote: From: Paweł Jarosz Add clock driver for rk3066 platform. Can you comment a bit on what you support? For example, it seems like there are some clocks which are fixed at particular frequencies. Why did you choose those? Which clocks can be set freely? A

Re: [PATCH] net: fastboot: make UDP port net: configurable

2022-01-15 Thread Ramon Fried
On Sat, Jan 15, 2022 at 1:58 PM Ramon Fried wrote: > > On Thu, Jan 13, 2022 at 2:02 PM Heiko Schocher wrote: > > > > Hello Christian, > > > > On 13.01.22 08:40, Christian Gmeiner wrote: > > > The fastboot protocol uses per default the UDP port 5554. In some cases > > > it might be needed to

Re: [PATCH v3] net: fsl: Fix busy flag polling register

2022-01-15 Thread Ramon Fried
On Wed, Jan 12, 2022 at 12:50 PM Camelia Alexandra Groza (OSS) wrote: > > > -Original Message- > > From: U-Boot On Behalf Of Markus Koch > > Sent: Tuesday, January 11, 2022 20:23 > > To: Camelia Alexandra Groza ; > > joe.hershber...@ni.com; rfried@gmail.com > > Cc: Madalin Bucur

Re: [PATCH] net: eth-phy: Demote missing phy-handle log message to debug

2022-01-15 Thread Ramon Fried
On Sun, Jan 2, 2022 at 11:19 AM Ramon Fried wrote: > > On Sat, Jan 1, 2022 at 9:12 PM Marek Vasut wrote: > > > > Reduce the missing phy-handle log message to debug message. It is > > possible for ethernet DT node to have no phy-handle e.g. in case > > of a fixed-link connection. Furthermore,

Re: [PATCH] net: phy: add TI DP83869HM ethernet driver

2022-01-15 Thread Ramon Fried
On Wed, Dec 29, 2021 at 9:26 PM Ramon Fried wrote: > > On Wed, Dec 22, 2021 at 9:58 AM Christian Gmeiner > wrote: > > > > From: Dominic Rath > > > > This driver is based on an older downstream TI kernel, with > > changes and cleanups to work with mainline device-tree bindings. > > > >

Re: [PATCH 2/2] net: dsa: sja1105: fix device id detection

2022-01-15 Thread Ramon Fried
On Sat, Jan 15, 2022 at 6:48 PM Ramon Fried wrote: > > On Sun, Dec 5, 2021 at 1:01 AM Vladimir Oltean > wrote: > > > > The sja1105_check_device_id() function contains logic to work without > > changing the device tree on reworked boards, one of which I have (the > > NXP LS1021A-TSN normally has

Re: [PATCH 2/2] net: dsa: sja1105: fix device id detection

2022-01-15 Thread Ramon Fried
On Sun, Dec 5, 2021 at 1:01 AM Vladimir Oltean wrote: > > The sja1105_check_device_id() function contains logic to work without > changing the device tree on reworked boards, one of which I have (the > NXP LS1021A-TSN normally has a SJA1105T, but I have a version with a > resoldered SJA1105Q

Re: [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2022-01-15 Thread Ramon Fried
On Sat, Jan 15, 2022 at 6:46 PM Ramon Fried wrote: > > On Sun, Dec 5, 2021 at 1:01 AM Vladimir Oltean > wrote: > > > > If the DSA API is going to allow drivers to do things such as: > > > > - phy_config in dsa_ops :: port_probe > > - phy_startup in dsa_ops :: port_enable > > > > then it would

Re: [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2022-01-15 Thread Ramon Fried
On Sun, Dec 5, 2021 at 1:01 AM Vladimir Oltean wrote: > > If the DSA API is going to allow drivers to do things such as: > > - phy_config in dsa_ops :: port_probe > - phy_startup in dsa_ops :: port_enable > > then it would actually be good if the ->port_probe() method would > actually be called

Re: [PATCH v2] cmd: pxe_utils: sysboot: add label override support

2022-01-15 Thread Ramon Fried
On Tue, Dec 14, 2021 at 11:11 AM Ramon Fried wrote: > > On Mon, Dec 13, 2021 at 1:27 PM Art Nikpal wrote: > > > > On Sat, Nov 13, 2021 at 9:09 PM Amjad Ouled-Ameur > > wrote: > > > > > > This will allow consumers to choose a pxe label at runtime instead of > > > having to prompt the user. One

Re: [PATCH] Revert "net: gem: Disable broadcast setting"

2022-01-15 Thread Ramon Fried
On Fri, Jan 14, 2022 at 2:15 PM Michal Simek wrote: > > This reverts commit eafdcda4a854932c0319656de7bf3f017f17ae67. > > The main reason is that QEMU is using BOOTP protocol which is sending DHCP > Offer to a broadcast address that's why it can't be disabled. > DHCP protocol has no issue because

Re: [PATCH] net: gem: Workaround gmii2rgmii bridge DT node issue

2022-01-15 Thread Ramon Fried
On Fri, Jan 14, 2022 at 2:08 PM Michal Simek wrote: > > From: Ashok Reddy Soma > > For configurations with gmii2rgmii and external phy the DT nodes link > should be gem->gmii2rgmii->phy. But due to limitation in Linux driver > the DT is mentioned as gem->phy and gmii2rgmii->phy as shown in below

Re: [PATCH v3 2/3] kconfig: Add support for conditional values

2022-01-15 Thread Simon Glass
+U-Boot Mailing List to update patchwork so 'patman status' works On Fri, 14 Jan 2022 at 21:52, Rasmus Villemoes wrote: > > (Sorry for formatting, on phone) > > At present if an optional Kconfig value needs to be used it must be > bracketed by #ifdef. For example, with this Kconfig setup: > >

Re: [PATCH] arm:dts:k3-am64-sk: EMIF tool update to 0.8.0 with 1333MTs for lpddr4

2022-01-15 Thread Tom Rini
On Mon, Nov 29, 2021 at 05:34:49PM +0530, Sinthu Raja wrote: > From: Sinthu Raja > > EMIF tool for AM64 SK is now updated to 0.8.0 that includes > * disabled Write DQ training > * improve CA ODT to 60 ohms > > The lpddr4 enabled with periodic WDQ training is causing periodic 26us > stall. This

Re: [PATCH 1/1] video: mxsfb: fix pixel clock polarity

2022-01-15 Thread Fabio Estevam
Hi Sébastien, [Adding Anatolij] On Fri, Nov 26, 2021 at 1:49 PM Sébastien Szymanski wrote: > > DISPLAY_FLAGS_PIXDATA_NEGEDGE means the controller drives the data on > pixel clocks falling edge. That is DOTCLK_POL=0 (default) not 1. > > The same change has been made on the Linux's driver: >

Re: [PATCH] spi: mxc_spi: remove redundant code in spi_xchg_single()

2022-01-15 Thread Fabio Estevam
On Sat, Nov 6, 2021 at 12:11 PM wrote: > > From: Haolin Li > > The value of cnt is overwritten without being used. > > Signed-off-by: Haolin Li Reviewed-by: Fabio Estevam

Re: [PATCH 1/1] configs: opos6uldev: update to have screen working at power on

2022-01-15 Thread Fabio Estevam
Hi Sébastien, On Fri, Nov 26, 2021 at 1:49 PM Sébastien Szymanski wrote: > > Signed-off-by: Sébastien Szymanski Please provide a commit log. Thanks

Re: [PATCH] ARM: imx6: dh-imx6: Add update_sf script to install U-Boot into SF

2022-01-15 Thread Fabio Estevam
On Sat, Nov 27, 2021 at 11:52 PM Marek Vasut wrote: > > Add script to read U-Boot from SD card and write it to matching > locations in the SPI NOR, thus making the SPI NOR bootable. > > Signed-off-by: Marek Vasut > Cc: Christoph Niedermaier > Cc: Stefano Babic Reviewed-by: Fabio Estevam

Re: [PATCH v2 0/2] imx8mn-smm-s2/pro: Add iMX8MN BSH SMM S2 boards

2022-01-15 Thread Fabio Estevam
On Mon, Jan 3, 2022 at 6:11 PM Ariel D'Alessandro wrote: > > Gentle ping. Can we get this merged? Looks good to me: Reviewed-by: Fabio Estevam

Re: [PATCH v2 1/2] imx8m: add regs used by GPMI

2022-01-15 Thread Fabio Estevam
On Tue, Nov 23, 2021 at 2:43 PM Ariel D'Alessandro wrote: > > From: Michael Trimarchi > > Add regs used by GPMI > > Signed-off-by: Michael Trimarchi > Signed-off-by: Ariel D'Alessandro Reviewed-by: Fabio Estevam

Re: [PATCH 1/1] imx8mm-cl-iot-gate-optee: add CONFIG_SPL_MMC and CONFIG_SPL_SERIAL

2022-01-15 Thread Fabio Estevam
On Mon, Nov 15, 2021 at 6:44 AM Ying-Chun Liu wrote: > > From: "Ying-Chun Liu (PaulLiu)" > > Previously these two options are called CONFIG_SPL_MMC_SUPPORT > and CONFIG_SPL_SERIAL_SUPPORT. During the transition they are > removed by accident. Thus adding them back. > > Signed-off-by: Ying-Chun

Re: [PATCH] ARM: imx8m: support env in fat and ext4

2022-01-15 Thread Fabio Estevam
On Wed, Oct 20, 2021 at 4:16 PM Ricardo Salveti wrote: > > Change boot device logic to also allow environment stored in fat and in > ext4 when booting from SD or from eMMC. > > As the boot device check for SD and for eMMC was depending on > ENV_IS_IN_MMC being defined, change the ifdef blocks at

Re: [PATCH] imx: spl: Fix typo BMODE_EMI -> BMODE_EIM

2022-01-15 Thread Fabio Estevam
On Wed, Dec 1, 2021 at 6:03 AM Harald Seiler wrote: > > The interface for NOR/OneNAND is called "EIM" not "EMI". Fix this. > > Signed-off-by: Harald Seiler Reviewed-by: Fabio Estevam

Re: [PATCH] mx6: Use imx6_src_get_boot_mode() to check boot device

2022-01-15 Thread Fabio Estevam
On Wed, Dec 1, 2021 at 6:11 AM Harald Seiler wrote: > > Use imx6_src_get_boot_mode() instead of manually reading SBMR1. The > existing function has proper handling for software overrides of the > bootdevice which can happen, for example, when booting from an alternate > source using `bmode`. > >

Re: [PATCH] imx: nandbcb: Fix printf format in write_fcb

2022-01-15 Thread Fabio Estevam
On Wed, Oct 20, 2021 at 6:13 AM Pali Rohár wrote: > > Correct printf format for unsigned long long is %llx and not %llxx. > > Signed-off-by: Pali Rohár Reviewed-by: Fabio Estevam

Re: [PATCH] mxs: power: Change sequence of enabling DCDC switches

2022-01-15 Thread Fabio Estevam
On Wed, Oct 13, 2021 at 10:40 AM Lukasz Majewski wrote: > > The imx28 uses following voltage supplies hierarchy: > > VDD_5V (VDD_BAT) -> VDDIO -> VDDA -> VDDMEM > \-> VDDD > > One shall first enable DCDC on the parent source (VDDIO) and then > follow with its

Re: [PATCH] imx8mm-venice-gw7902: fix M2_RST# gpio pinmux

2022-01-15 Thread Fabio Estevam
On Wed, Oct 6, 2021 at 5:13 PM Tim Harvey wrote: > > Fix the invalid gw7902 M2_RST# gpio pinmux. > > Signed-off-by: Tim Harvey Reviewed-by: Fabio Estevam

Re: [PATCH] arm: imx: imx8mq: add support to get values for more clocks

2022-01-15 Thread Fabio Estevam
Hi Heiko, On Thu, Sep 9, 2021 at 9:59 AM Heiko Thiery wrote: > > Return the root clock values for MXC_CSPI_CLK, MXC_I2C_CLK, > MXC_UART_CLK and MXC_QSPI_CLK. > > At least for the I2C clock the missing support leads to a wrong > configured I2C frequency. The expected value is 100kHz but the

Re: [PATCH] gpio: mxc_gpio: Fix i.MX8M GPIO output status read

2022-01-15 Thread Fabio Estevam
Hi Harm and Ye Li, On Fri, Aug 13, 2021 at 11:35 AM Harm Berntsen wrote: > > Currently the driver gets value from PSR register, but this register is > only for input mode. For output mode, it always returns 0, not the value > we set for output. > > This patch changes to use DR register, which

Re: [PATCH] lib: Kconfig: fix PHANDLE_CHECK_SEQ position outside of menu

2022-01-15 Thread Tom Rini
On Tue, Jan 04, 2022 at 06:20:19PM +0200, Eugen Hristev wrote: > CONFIG_PHANDLE_CHECK_SEQ is outside of the menu 'Library routines' > thus it's invisible in menuconfig and cannot be selected. > Fix this by moving the 'endmenu' after the PHANDLE_CHECK_SEQ definition > > Fixes: c589132a1d ("fdt:

Re: [PATCH] env: fat: Add new lines at the end of print statements

2022-01-15 Thread Tom Rini
On Sun, Jan 02, 2022 at 11:38:35AM +, Peter Robinson wrote: > Add some new line feeds at the end of print messages to make things > easier to read on the console. The other env options do this so > this is just an omission for FAT env. > > Signed-off-by: Peter Robinson Applied to

Re: [PATCH v3] phy: Track power-on and init counts in uclass

2022-01-15 Thread Tom Rini
On Thu, Dec 30, 2021 at 10:36:51PM +0300, Alper Nebi Yasak wrote: > On boards using the RK3399 SoC, the USB OHCI and EHCI controllers share > the same PHY device instance. While these controllers are being stopped > they both attempt to power-off and deinitialize it, but trying to > power-off the

Re: [PATCH 1/1] ARM: qemu-arm: Fix build fail with boot devices disabled

2022-01-15 Thread Tom Rini
On Wed, Dec 29, 2021 at 02:30:04PM +0100, Piotr Kubik wrote: > BOOT_TARGET_DEVICES should only be added if the corresponding u-boot > command is enabled otherwise the build will fail. > > Signed-off-by: Piotr Kubik Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH] phy: nop-phy: Enable reset-gpios support

2022-01-15 Thread Tom Rini
On Wed, Dec 22, 2021 at 08:04:30AM -0600, Adam Ford wrote: > Some usb-nop-xceiv devices use a gpio to put them in and > out of reset. Add a reset function to put them into that > state. This is similar to how Linux handles the > usb-nop-xceiv driver. > > Signed-off-by: Adam Ford > > diff

Re: [PATCH] armv8: apple: Disable PSCI reset

2022-01-15 Thread Tom Rini
On Tue, Dec 21, 2021 at 05:31:50PM +0100, Mark Kettenis wrote: > Apple's ARMv8 cores don't implement EL3 and therefore don't > provide a PSCI implementation. So don't attempt to use > PSCI to reset on machines using Apple SoCs. > > Signed-off-by: Mark Kettenis Applied to u-boot/master,

Re: [PATCH] BRCMNAND: Fix reporting of uncorrectable errors on subpages during page read

2022-01-15 Thread Tom Rini
On Mon, Dec 20, 2021 at 08:15:47PM -0800, Joel Peshkin wrote: > Previously, a subpage with an uncorrectable error followed by a subpage > with a correctable error would return an erroneous correctable status. > > Signed-off-by: Joel Peshkin > Cc: Simon Glass > Reviewed-by: Simon Glass

Re: [PATCH] cmd: adc: Report return value on error

2022-01-15 Thread Tom Rini
On Mon, Dec 20, 2021 at 06:23:45PM -0500, Samuel Dionne-Riel wrote: > Reporting the return value should always be done on error conditions, > this way the developer can start debugging issues with more knowledge > in-hand. > > Signed-off-by: Samuel Dionne-Riel Applied to u-boot/master, thanks!

Re: [PATCH] lib: export vsscanf

2022-01-15 Thread Tom Rini
On Mon, Dec 20, 2021 at 06:19:16PM -0500, Samuel Dionne-Riel wrote: > The function was missing from exports, even though it loooks like the > intent of the implementation in sscanf.c was to have it exported. > > Signed-off-by: Samuel Dionne-Riel > Cc: Simon Glass > Reviewed-by: Simon Glass

Re: [PATCH] checkpatch: report ERROR only on disabling of fdt and initrd relocation

2022-01-15 Thread Tom Rini
On Wed, Dec 15, 2021 at 02:23:52PM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang > > Let the check pass when patches have these patterns in their context. > > Signed-off-by: Hou Zhiqiang Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] nvme: Do not allocate 8kB buffer on stack

2022-01-15 Thread Tom Rini
On Thu, Dec 09, 2021 at 11:06:39AM +0100, Pali Rohár wrote: > Calling 'nvme scan' followed by 'nvme detail' crashes U-Boot on Turris > Omnia with the following error: > > undefined instruction > pc : [<0a00>] lr : [<7ff80bfc>] > reloc pc : [<8a8c>]lr : [<00840bfc>] >

Re: [PATCH] test: test_lsblk: Mark as sandbox specific

2022-01-15 Thread Tom Rini
On Tue, Nov 30, 2021 at 03:33:53PM +0100, Patrick Delaunay wrote: > This test checks for output specific to the sandbox blk device > "sandbox_host_blk", mark it as sandbox specific. > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v3] pci: Work around PCIe link training failures

2022-01-15 Thread Tom Rini
On Sat, Nov 20, 2021 at 11:03:30PM +, Maciej W. Rozycki wrote: > Attempt to handle cases with a downstream port of a PCIe switch where > link training never completes and the link continues switching between > speeds indefinitely with the data link layer never reaching the active > state. >

Re: [PATCH v4] lib: sparse: Make CHUNK_TYPE_RAW buffer aligned

2022-01-15 Thread Tom Rini
On Tue, Nov 16, 2021 at 09:35:38AM +0800, qianfangui...@qq.com wrote: > From: qianfan Zhao > > CHUNK_TYPE_RAW buffer is not aligned, and flash sparse images by > fastboot will report "Misaligned operation" if DCACHE is enabled. > > Flashing Sparse Image > CACHE: Misaligned operation at range

Re: [PATCH] net: fastboot: make UDP port net: configurable

2022-01-15 Thread Ramon Fried
On Thu, Jan 13, 2022 at 2:02 PM Heiko Schocher wrote: > > Hello Christian, > > On 13.01.22 08:40, Christian Gmeiner wrote: > > The fastboot protocol uses per default the UDP port 5554. In some cases > > it might be needed to change the used port. The fastboot utility provides > > a way to

Re: [PATCH] pci: pci_mvebu: Add support for Kirkwood PCIe controllers

2022-01-15 Thread Stefan Roese
On 1/13/22 14:28, Pali Rohár wrote: Kirkwood uses macros KW_DEFADR_PCI_MEM and KW_DEFADR_PCI_IO for base address of PCIe mappings. Size of PCIe windows is not defined in any macro yet, so export them in new KW_DEFADR_PCI_MEM_SIZE and KW_DEFADR_PCI_IO_SIZE macros. Kirkwood arch code already maps

Re: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk

2022-01-15 Thread Stefan Roese
On 1/14/22 18:34, Pali Rohár wrote: If image backend provides verify_header callback then call it after writing image to disk. This ensures that written image is correct. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- tools/mkimage.c | 41

Re: [PATCH v9 9/9] efi: Tidy up some comments in efi header

2022-01-15 Thread Heinrich Schuchardt
On 1/4/22 11:51, Simon Glass wrote: Document the return value in efi_init(). Fix up @sizep in efi_info_get(). Use Return: instead of @return Signed-off-by: Simon Glass --- Reviewed-by: Heinrich Schuchardt

Re: [PATCH 8/9] doc: add include/dm/of*.h to the HTML documentation

2022-01-15 Thread Heinrich Schuchardt
On 1/12/22 10:53, Patrick Delaunay wrote: Correct Sphinx style comments in include/dm/ofnode.h and add the device tree node API to the HTML documentation; the ofnode functions are compatible with Live tree or with flat device tree. Signed-off-by: Patrick Delaunay --- Reviewed-by: Heinrich

Re: [PATCH 9/9] doc: add include/dm/fdtaddr.h to the HTML documentation

2022-01-15 Thread Heinrich Schuchardt
On 1/12/22 10:55, Patrick Delaunay wrote: Correct Sphinx style comments in include/dm/fdtaddr.h and add the devfdt API to the HTML documentation; these functions are NOT compatible with live tree. Signed-off-by: Patrick Delaunay Reviewed-by: Heinrich Schuchardt

Re: [PATCH 7/9] doc: add include/dm/read.h to the HTML documentation

2022-01-15 Thread Heinrich Schuchardt
On 1/12/22 10:53, Patrick Delaunay wrote: Correct Sphinx style comments in include/dm/read.h and add the device read from device tree API to the HTML documentation. Signed-off-by: Patrick Delaunay Reviewed-by: Heinrich Schuchardt

Re: [PATCH 6/9] doc: add include/dm/devres.h to the HTML documentation

2022-01-15 Thread Heinrich Schuchardt
On 1/12/22 10:53, Patrick Delaunay wrote: Correct Sphinx style comments in include/dm/devres.h and add the driver model device resource API, devres_*(), to the HTML documentation. Signed-off-by: Patrick Delaunay --- Reviewed-by: Heinrich Schuchardt

Re: [PATCH 5/9] doc: add include/dm/device.h to the HTML documentation

2022-01-15 Thread Heinrich Schuchardt
On 1/12/22 10:53, Patrick Delaunay wrote: Correct Sphinx style comments in include/dm/device.h and add the driver model device API to the HTML documentation. Signed-off-by: Patrick Delaunay --- doc/api/dm.rst | 5 ++ include/dm/device.h | 209

Re: [PATCH 2/9] doc: add include/dm/root.h to the HTML documentation

2022-01-15 Thread Heinrich Schuchardt
On 1/12/22 10:53, Patrick Delaunay wrote: Correct Sphinx style comments in include/dm/devres.h and add the associated driver model API to the HTML documentation. Signed-off-by: Patrick Delaunay Reviewed-by: Heinrich Schuchardt

Re: [PATCH 1/9] doc: add include/dm/uclass.h to the HTML documentation

2022-01-15 Thread Heinrich Schuchardt
On 1/12/22 10:53, Patrick Delaunay wrote: Correct Sphinx style comments in include/dm/uclass.h and add the driver model UCLASS API to the HTML documentation. Signed-off-by: Patrick Delaunay --- doc/api/dm.rst | 9 ++ doc/api/index.rst | 1 + include/dm/uclass.h | 75