[PATCH v2 3/3] defconfig: Enable DM_PMIC and DM PMIC_TPS65217 on AM335x EVM board

2022-03-11 Thread Lukasz Majewski
As this board now supports DM_I2C, it is safe for it to also use the DM converted PMIC tps65217 driver. Signed-off-by: Lukasz Majewski --- Changes in v2: - Move the Kconfig definition for PMIC to patch, which adds support for DM configs/am335x_boneblack_vboot_defconfig | 3 +++

[PATCH v2 2/3] power: pmic: Provide DM_PMIC support for tps65217 driver

2022-03-11 Thread Lukasz Majewski
The tps65217 PMIC driver is used with am335x SoC based designs. It is used in the SPL (MLO) as well, so the DM conversion only is for u-boot proper. This driver only allows simple reading/writing/dumping of the content of its registers and requires the DM_I2C for proper operation.

[PATCH v2 1/3] power: Rename CONFIG_POWER_TPS65217 with CONFIG_PMIC_TPS65217

2022-03-11 Thread Lukasz Majewski
Up till now the CONFIG_POWER_TPS65217 has been defined in several header files for am335x SoC. This patch renames it to CONFIG_PMIC_TPS65217, which better reflects the role of this IC circuit. Moreover, new CONFIG_PMIC_TPS65217 has been introduced in Kconfig to be used with boards, which both

Re: [PATCH v2 26/28] serial: dm: Add support for puts

2022-03-11 Thread Sean Anderson
On 3/12/22 12:02 AM, Simon Glass wrote: Hi Sean, On Thu, 10 Mar 2022 at 13:51, Sean Anderson wrote: Some serial drivers can be vastly more efficient when printing multiple characters at once. Non-DM serial has had a puts option for these sorts of drivers; implement it for DM serial as well.

Re: [PATCH] env: Avoid using a leftover text-environment file

2022-03-11 Thread Sean Anderson
On 3/12/22 12:37 AM, Simon Glass wrote: If include/generated/environment.h exists (perhaps leftover from a build of another board) it is used, even if the board currently being built does not have a text environment. This causes a build error. Fix it by emptying the file if it should not be

Re: [BUG] include/generated/environment.h included incorrectly

2022-03-11 Thread Simon Glass
Hi Sean, On Thu, 24 Feb 2022 at 22:30, Sean Anderson wrote: > > > Hi Simon, > > > > include/generated/environment.h is still included if it exists, even if > > CONFIG_USE_DEFAULT_ENV_FILE is not set. To reproduce this, build a board > > which uses this config (such as sandbox), and then build a

[PATCH] env: Avoid using a leftover text-environment file

2022-03-11 Thread Simon Glass
If include/generated/environment.h exists (perhaps leftover from a build of another board) it is used, even if the board currently being built does not have a text environment. This causes a build error. Fix it by emptying the file if it should not be there. Fixes:

Re: [PATCH v1 11/11] [RFC] rockchip: rk356x: attempt to fix ram detection

2022-03-11 Thread Simon Glass
Hi Peter, On Fri, 11 Mar 2022 at 20:54, Peter Geis wrote: > > On Fri, Mar 11, 2022 at 9:25 PM Simon Glass wrote: > > > > Hi Peter, > > > > On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > > > > > This patch attempts to fix ram detection on rk3568. > > > Prior to this, the rk3568 incorrectly

Re: [PATCH v2 1/1] cmd: add serial console support for the cls command

2022-03-11 Thread Simon Glass
Hi Heinrich, On Fri, 11 Mar 2022 at 00:06, Heinrich Schuchardt wrote: > > On 2/11/22 21:29, Simon Glass wrote: > > On Fri, 11 Feb 2022 at 10:11, Heinrich Schuchardt > > wrote: > >> > >> Currently the cls command does not support the serial console > >> > >> The screen can be cleared in the

Re: [PATCH v1 01/11] clk: rockchip: rk3568: fix reset handler

2022-03-11 Thread Simon Glass
Hi Peter, On Fri, 11 Mar 2022 at 20:32, Peter Geis wrote: > > On Fri, Mar 11, 2022 at 9:25 PM Simon Glass wrote: > > > > Hi Peter, > > > > On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > > > > > The reset handler for rk3568 is missing its private data. This leads to > > > an abort when a

Re: [PATCH 2/5] tbs2910: Disable ext4 write

2022-03-11 Thread Simon Glass
Hi Tom, On Fri, 11 Mar 2022 at 21:04, Tom Rini wrote: > > On Fri, Mar 11, 2022 at 07:24:41PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 11 Mar 2022 at 12:58, Tom Rini wrote: > > > > > > On Fri, Mar 11, 2022 at 12:10:02PM -0700, Simon Glass wrote: > > > > > > > This board is right up

Re: [PATCH v2 26/28] serial: dm: Add support for puts

2022-03-11 Thread Simon Glass
Hi Sean, On Thu, 10 Mar 2022 at 13:51, Sean Anderson wrote: > > Some serial drivers can be vastly more efficient when printing multiple > characters at once. Non-DM serial has had a puts option for these sorts > of drivers; implement it for DM serial as well. > > Because we have to add carriage

Re: [PATCH v3 22/26] rockchip: evb-rk3288: Drop raw-image support

2022-03-11 Thread Simon Glass
Hi Alper, On Thu, 10 Mar 2022 at 12:36, Alper Nebi Yasak wrote: > > On 06/03/2022 06:19, Simon Glass wrote: > > This boards uses SPL_FIT so does not need to support loading a raw image. > > This sounds OK to me, but... > > > Drop it to avoid binman trying to insert a symbol which has no value. >

Re: [PATCH] WIP: Nokia RX-51: Convert to CONFIG_DM_VIDEO

2022-03-11 Thread Simon Glass
Hi Pali, On Fri, 11 Mar 2022 at 11:58, Pali Rohár wrote: > > On Wednesday 09 March 2022 23:20:11 Anatolij Gustschin wrote: > > Hi Pali, > > > > On Wed, 9 Mar 2022 20:44:50 +0100 > > Pali Rohár p...@kernel.org wrote: > > > > > On Sunday 06 March 2022 11:44:22 Simon Glass wrote: > > > > Hi Pali, >

Re: [PATCH v2 14/25] binman: Allow mkimage to use a non-zero fake-blob size

2022-03-11 Thread Simon Glass
Hi Alper, On Thu, 10 Mar 2022 at 12:36, Alper Nebi Yasak wrote: > > On 06/03/2022 06:08, Simon Glass wrote: > > On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak > > wrote: > >>> def ObtainContents(self): > >>> +# Use a non-zero size for any fake files to keep mkimage happy > >>>

Re: [PATCH v2 12/25] binman: Change how faked blobs are created

2022-03-11 Thread Simon Glass
Hi Alper, On Thu, 10 Mar 2022 at 12:36, Alper Nebi Yasak wrote: > > On 06/03/2022 06:08, Simon Glass wrote: > > On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak > > wrote: > >> On 24/02/2022 02:00, Simon Glass wrote: > >>> +- Put faked files into a separate subdir and remove them on start-up, to

Re: [PATCH][RFC] image: fdt: Fix DT relocation handling with multiple DRAM banks with gap

2022-03-11 Thread Simon Glass
Hi Marek, On Fri, 11 Mar 2022 at 19:41, Marek Vasut wrote: > > On 3/12/22 03:24, Simon Glass wrote: > > Hi Marek, > > > > On Wed, 21 Jul 2021 at 18:05, Marek Vasut wrote: > >> > >> The current implementation of boot_relocate_fdt() places DT at the > >> highest usable DRAM address, which is

Re: [PATCH] video: sandbox: fix missing shim definition of sandbox_sdl_remove_display()

2022-03-11 Thread Simon Glass
On Fri, 11 Mar 2022 at 11:52, Vladimir Oltean wrote: > > When CONFIG_SANDBOX_SDL=n, sandbox_sdl_set_bpp() from > drivers/video/sandbox_sdl.c > calls sandbox_sdl_remove_display() in arch/sandbox/cpu/sdl.c, but this > isn't compiled in. A shim definition is missing, leading to a > compilation

Re: [PATCH v3 00/19] efi_loader: more tightly integrate UEFI disks to driver model

2022-03-11 Thread Simon Glass
Hi Soeren, On Fri, 11 Mar 2022 at 15:43, Soeren Moch wrote: > > > > On 09.03.22 16:33, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 9 Mar 2022 at 07:25, Tom Rini wrote: > >> On Tue, Mar 08, 2022 at 08:10:38PM -0700, Simon Glass wrote: > >>> Hi Tom, > >>> > >>> On Tue, 8 Mar 2022 at 20:00, Tom

Re: [PATCH 2/5] tbs2910: Disable ext4 write

2022-03-11 Thread Simon Glass
Hi Soeren, On Fri, 11 Mar 2022 at 15:57, Soeren Moch wrote: > > > > On 11.03.22 20:10, Simon Glass wrote: > > This board is right up against the size limit. Drop ext4 writing to give > > it some more space. > > > > Signed-off-by: Simon Glass > NAK. > > At least for now. > We should not randomly

[PATCH 8/8] Convert CONFIG_ATMEL_LEGACY to Kconfig

2022-03-11 Thread Tom Rini
This converts the following to Kconfig: CONFIG_ATMEL_LEGACY Cc: Eugen Hristev Signed-off-by: Tom Rini --- arch/arm/mach-at91/Kconfig | 3 +++ configs/at91sam9260ek_dataflash_cs0_defconfig | 1 + configs/at91sam9260ek_dataflash_cs1_defconfig | 1 +

[PATCH 3/8] Convert CONFIG_AT91SAM9G20EK et al to Kconfig

2022-03-11 Thread Tom Rini
This converts the following to Kconfig: CONFIG_AT91SAM9G20EK CONFIG_AT91SAM9260EK CONFIG_AT91SAM9G20EK_2MMC Cc: Eugen Hristev Signed-off-by: Tom Rini --- board/atmel/at91sam9260ek/Kconfig | 15 +++ configs/at91sam9260ek_dataflash_cs0_defconfig | 1 +

[PATCH 6/8] atmel: Remove CONFIG_AT91SAM9G45_LCD_BASE

2022-03-11 Thread Tom Rini
This variable is used once and is noted as board-specific. Use the value directly with a comment. Cc: Eugen Hristev Signed-off-by: Tom Rini --- board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c | 3 ++- include/configs/at91sam9m10g45ek.h | 2 -- 2 files changed, 2 insertions(+), 3

[PATCH 7/8] Convert CONFIG_AT91_GPIO_PULLUP to Kconfig

2022-03-11 Thread Tom Rini
This converts the following to Kconfig: CONFIG_AT91_GPIO_PULLUP Cc: Eugen Hristev Signed-off-by: Tom Rini --- arch/arm/mach-at91/Kconfig| 4 configs/axm_defconfig | 1 + configs/corvus_defconfig | 1 + configs/gurnard_defconfig | 1 + configs/smartweb_defconfig

[PATCH 5/8] atmel: Remove CONFIG_AT91SAM9G45EKES

2022-03-11 Thread Tom Rini
This symbol is used only once, and in comparison with an unset symbol, so drop it. Cc: Eugen Hristev Signed-off-by: Tom Rini --- board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c | 4 include/configs/at91sam9m10g45ek.h | 2 -- 2 files changed, 6 deletions(-) diff --git

[PATCH 4/8] Convert CONFIG_AT91SAM9G10EK et al to Kconfig

2022-03-11 Thread Tom Rini
This converts the following to Kconfig: CONFIG_AT91SAM9G10EK CONFIG_AT91SAM9261EK CONFIG_AT91SAM9G10 Cc: Eugen Hristev Signed-off-by: Tom Rini --- board/atmel/at91sam9261ek/Kconfig | 14 ++ configs/at91sam9261ek_dataflash_cs0_defconfig | 1 +

[PATCH 2/8] Convert CONFIG_AT91SAM9260 et al to Kconfig

2022-03-11 Thread Tom Rini
This converts the following to Kconfig: CONFIG_AT91SAM9260 CONFIG_AT91SAM9G20 CONFIG_AT91SAM9XE CONFIG_AT91SAM9261 CONFIG_AT91SAM9263 CONFIG_AT91SAM9G45 CONFIG_AT91SAM9M10G45 CONFIG_AT91SAM9N12 CONFIG_AT91SAM9RL CONFIG_AT91SAM9X5 CONFIG_SAM9X60 CONFIG_SAMA7G5

[PATCH 1/8] Convert CONFIG_AM335X_USB0 et al to Kconfig

2022-03-11 Thread Tom Rini
This converts the following to Kconfig: CONFIG_AM335X_USB0 CONFIG_AM335X_USB0_MODE CONFIG_AM335X_USB1 CONFIG_AM335X_USB1_MODE We do this by introducing specific options for static configuration of USB0/USB1 in SPL rather than defining CONFIG_AM335X_USBx_MODE to the enum value being

Re: [PATCH 2/5] tbs2910: Disable ext4 write

2022-03-11 Thread Tom Rini
On Fri, Mar 11, 2022 at 07:24:41PM -0700, Simon Glass wrote: > Hi Tom, > > On Fri, 11 Mar 2022 at 12:58, Tom Rini wrote: > > > > On Fri, Mar 11, 2022 at 12:10:02PM -0700, Simon Glass wrote: > > > > > This board is right up against the size limit. Drop ext4 writing to give > > > it some more

Re: [PATCH v1 11/11] [RFC] rockchip: rk356x: attempt to fix ram detection

2022-03-11 Thread Peter Geis
On Fri, Mar 11, 2022 at 9:25 PM Simon Glass wrote: > > Hi Peter, > > On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > > > This patch attempts to fix ram detection on rk3568. > > Prior to this, the rk3568 incorrectly detected 8gb ram as 2gb. > > On top of this, the board panics when u-boot

Re: [PATCH v1 10/11] rockchip: rk3568: add dwc3 otg support

2022-03-11 Thread Peter Geis
On Fri, Mar 11, 2022 at 9:25 PM Simon Glass wrote: > > On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > > > Add the required platform data to the rk3568 chip config, in order to > > support dwc3 otg on this chip. > > > > Signed-off-by: Peter Geis > > --- > >

Re: [PATCH v1 06/11] rockchip: handle bootrom recovery mode in spl

2022-03-11 Thread Peter Geis
On Fri, Mar 11, 2022 at 9:25 PM Simon Glass wrote: > > Hi Peter, > > On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > > > Fixup the bootrom recovery mode code to function in spl, so we can > > handle recovery mode in case u-boot loading is broken. > > > > Signed-off-by: Peter Geis > > --- >

Re: [PATCH v1 07/11] rockchip: rk3568: add boot device detection

2022-03-11 Thread Peter Geis
On Fri, Mar 11, 2022 at 9:25 PM Simon Glass wrote: > > Hi Peter, > > On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > > > Enable rk3568 spl to detect which device it was booted from. > > > > Signed-off-by: Peter Geis > > --- > > arch/arm/mach-rockchip/rk3568/rk3568.c | 8 > > 1

Re: [PATCH v1 01/11] clk: rockchip: rk3568: fix reset handler

2022-03-11 Thread Peter Geis
On Fri, Mar 11, 2022 at 9:25 PM Simon Glass wrote: > > Hi Peter, > > On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > > > The reset handler for rk3568 is missing its private data. This leads to > > an abort when a reset is triggered. > > > > Add the missing dev_set_priv to the rk3568 clk

Re: [PATCH 2/3] lib: rsa: Leverage existing data buffer instead of systematic copy

2022-03-11 Thread Simon Glass
Hi, On Wed, 9 Mar 2022 at 02:28, SESA644425 wrote: > > Prior to introduction of modifications in rsassa_pss functions > related to padding verification, doing a pass to reduce memory > consumption of function by replacing memory copies of parts of > const buffer by pointers to the original

Re: [PATCH v4 3/8] tpm: rng: Add driver model interface for TPM RNG device

2022-03-11 Thread Simon Glass
Hi Sughosh, On Wed, 9 Mar 2022 at 05:28, Sughosh Ganu wrote: > > The TPM device has a builtin random number generator(RNG) > functionality. Expose the RNG functions of the TPM device to the > driver model so that they can be used by the EFI_RNG_PROTOCOL if the > protocol is installed. > > Also

Re: [PATCH v4 4/8] tpm: Add the RNG child device

2022-03-11 Thread Simon Glass
Hi Sughosh, On Wed, 9 Mar 2022 at 05:28, Sughosh Ganu wrote: > > The TPM device comes with the random number generator(RNG) > functionality which is built into the TPM device. Add logic to add the > RNG child device in the TPM uclass post probe callback. > > The RNG device can then be used to

Re: [PATCH v3 8/8] test: rng: Add a UT testcase for the rng command

2022-03-11 Thread Simon Glass
Hi Sughosh, On Tue, 8 Mar 2022 at 23:18, Sughosh Ganu wrote: > > hi Simon, > > On Wed, 9 Mar 2022 at 08:06, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Fri, 4 Mar 2022 at 06:35, Sughosh Ganu wrote: > > > > > > The 'rng' command dumps a number of random bytes on the console. Add a > > >

Re: [PATCH 3/3] lib: rsa: Update function padding_pss_verify (any-salt)

2022-03-11 Thread Simon Glass
On Wed, 9 Mar 2022 at 02:28, SESA644425 wrote: > > Modify function to support any salt length instead of max > length only. Function now detects salt length by parsing > the content of db buffer. Note that it works with (but is > not limited to) zero-length, digest-length and max-length > >

Re: [PATCH 1/3] lib: rsa: Fix const-correctness of rsassa_pss functions

2022-03-11 Thread Simon Glass
On Wed, 9 Mar 2022 at 02:28, SESA644425 wrote: > > Prior to introduction of modifications in rsassa_pss functions > related to padding verification, doing a pass to update > const-correctness in targeted functions to comply with > coding-rules and avoid const-cast > > Signed-off-by: SESA644425

Re: [PATCH 3/3] ARM: dts: ast2600: Add PWM to device tree

2022-03-11 Thread Simon Glass
On Mon, 7 Mar 2022 at 20:02, Billy Tsai wrote: > > Add the PWM node and enable it for AST2600 EVB > > Signed-off-by: Billy Tsai > --- > arch/arm/dts/ast2600-evb.dts | 20 > arch/arm/dts/ast2600.dtsi| 15 +++ > 2 files changed, 35 insertions(+) >

Re: [PATCH v1 1/1] wdt: nuvoton: Add support for Nuvoton

2022-03-11 Thread Simon Glass
Hi, On Tue, 8 Mar 2022 at 01:51, jimliu2 wrote: > > Add watchdog controller driver for NPCM7xx/npcm8xx > > Signed-off-by: jimliu2 Do you have a real name? > --- > drivers/watchdog/Kconfig| 6 ++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/npcm_wdt.c | 119

Re: [PATCH 2/3] pinctrl: Add the pinctrl setting for PWM.

2022-03-11 Thread Simon Glass
On Mon, 7 Mar 2022 at 20:02, Billy Tsai wrote: > > This patchs add the signal description array for PWM pinctrl settings. > > Signed-off-by: Billy Tsai > --- > arch/arm/dts/ast2600.dtsi| 80 +++ > drivers/pinctrl/aspeed/pinctrl_ast2600.c | 120

Re: [PATCH v2 08/10] tpm: Add the RNG child device

2022-03-11 Thread Simon Glass
Hi Sughosh, On Sun, 6 Mar 2022 at 00:03, Sughosh Ganu wrote: > > hi Simon, > > On Sun, 6 Mar 2022 at 08:37, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Fri, 4 Mar 2022 at 06:44, Sughosh Ganu wrote: > > > > > > hi Simon, > > > > > > On Fri, 4 Mar 2022 at 08:07, Simon Glass wrote: > > > >

Re: [PATCH 1/3] pwm: Add Aspeed ast2600 PWM support

2022-03-11 Thread Simon Glass
On Mon, 7 Mar 2022 at 20:02, Billy Tsai wrote: > > This patch add the support of PWM controller which can be found at aspeed > ast2600 soc. The pwm supoorts up to 16 channels and it's part function > of multi-function device "pwm-tach controller". > > Signed-off-by: Billy Tsai > --- >

Re: [PATCH v2 1/2] video: Allow drivers to allocate the frame buffer themselves

2022-03-11 Thread Simon Glass
On Wed, 9 Mar 2022 at 12:46, Pali Rohár wrote: > > When plat->base is set by driver then skip frame buffer reservation and > allocation. > > Signed-off-by: Pali Rohár > --- > drivers/video/video-uclass.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > Reviewed-by: Simon Glass

[PATCH v1 2/2] imx: imxrt1050-evk: Add documentation for SPI boot

2022-03-11 Thread Jesse Taube
Adds documentation for SPI boot. Signed-off-by: Jesse Taube --- doc/board/nxp/imxrt1050-evk.rst | 41 + 1 file changed, 41 insertions(+) diff --git a/doc/board/nxp/imxrt1050-evk.rst b/doc/board/nxp/imxrt1050-evk.rst index c1fb48f0cd..0838a04871 100644 ---

[PATCH v1 1/2] imx: imxrt1050-evk: Add support for SPI flash booting

2022-03-11 Thread Jesse Taube
This add some macros to change addresses to use flexspi. This commit adds support for booting the imxrt1050-evk from spi. It adds imximage config and the ability for SPL to boot from NOR. Signed-off-by: Jesse Taube --- .../freescale/imxrt1050-evk/imximage-nor.cfg | 42 +++

Re: [PATCH][RFC] image: fdt: Fix DT relocation handling with multiple DRAM banks with gap

2022-03-11 Thread Marek Vasut
On 3/12/22 03:24, Simon Glass wrote: Hi Marek, On Wed, 21 Jul 2021 at 18:05, Marek Vasut wrote: The current implementation of boot_relocate_fdt() places DT at the highest usable DRAM address, which is calculated as: env_get_bootm_low() + env_get_bootm_mapsize() which by default becomes

Re: [PATCH] lib/acpi: Enable QEMU special cases for ARM

2022-03-11 Thread Simon Glass
On Sun, 27 Feb 2022 at 07:10, Alexander Graf wrote: > > With QEMU, we receive ACPI tables from the hypervisor rather than build > them ourselves in U-Boot. That logic however hard codes the target to the > x86 QEMU target, leaving ARM out on the fun. > > Let's add the ARM QEMU config as well to

Re: [PATCH v10 7/9] doc: Improve environment documentation further

2022-03-11 Thread Simon Glass
Hi Heinrich, On Sat, 23 Oct 2021 at 02:23, Heinrich Schuchardt wrote: > > On 10/22/21 05:08, Simon Glass wrote: > > Make various other updates suggested during review of the rST conversion. > > > > Signed-off-by: Simon Glass > > Suggested-by: Heinrich Schuchardt > > --- > > > > Changes in v10:

Re: [PATCH 2/4] ramfb: Add driver for ramfb display

2022-03-11 Thread Simon Glass
Hi Alex, On Sun, 27 Feb 2022 at 07:40, Alexander Graf wrote: > > QEMU implements multiple ways to expose graphics output to the virt > machine, but most of them are incompatible with hardware virtualization. > > The one that does work reliably is ramfb. It's a very simple mechanism > in which

Re: [PATCH v1 08/11] rockchip: rk3568: enable automatic clock gating

2022-03-11 Thread Simon Glass
On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > Enable automatic clock gating on rk3568, which solves a 7c temperature > difference on SoQuartz compared to downstream. > > Signed-off-by: Peter Geis > --- > arch/arm/mach-rockchip/rk3568/rk3568.c | 23 +++ > 1 file

Re: [PATCH 2/2] configs: rock-pi-4: Enable OP-TEE secure os support

2022-03-11 Thread Simon Glass
On Mon, 21 Feb 2022 at 09:13, Peter Griffin wrote: > > Signed-off-by: Peter Griffin > --- > configs/rock-pi-4-rk3399_defconfig | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Simon Glass

[PATCH v1] clk: imxrt: Use dts for anatop base address

2022-03-11 Thread Jesse Taube
In Linux IMX and IMXRT use the device tree to hold the anatop address. The anatop is used in clock drivers as it controls the internal PLLs This will move the macro from asm/arch-imxrt to the device tree. This presumably should also be done with the other IMX boards as well. Signed-off-by: Jesse

Re: [PATCH 2/2] Add option to use -Og

2022-03-11 Thread Simon Glass
On Tue, 22 Feb 2022 at 10:20, Sean Anderson wrote: > > This adds support for using -Og when building U-Boot. According to the > gcc man page: > > > -Og should be the optimization level of choice for the standard > > edit-compile-debug cycle, offering a reasonable level of optimization > > while

Re: [PATCH 2/2] bootcount: Add pmic pfuze100 bootcount driver

2022-03-11 Thread Simon Glass
Hi Philip, On Fri, 25 Feb 2022 at 06:56, Philip Oberfichtner wrote: > > Use the MEMA - MEMD registers on the PFUZE100 as bootcount > registers. > > Based on work from Heiko Schocher . > Signed-off-by: Philip Oberfichtner > > --- > > drivers/bootcount/Kconfig | 7 ++ >

Re: [PATCH 14/18] Make ASYMMETRIC_KEY_TYPE depend on FIT_SIGNATURE

2022-03-11 Thread Simon Glass
Hi Takahiro, On Mon, 28 Feb 2022 at 21:22, AKASHI Takahiro wrote: > > Simon, > > On Mon, Feb 28, 2022 at 12:08:31PM -0700, Simon Glass wrote: > > Add this dependency to avoid a build error if FIT_SIGNATURE is not > > enabled. > > I doubt it. > With qemu_arm64_defconfig & ASYMMETRIC_KEY_TYPE &

Re: [PATCH 1/4] qfw: Add WRITE definition

2022-03-11 Thread Simon Glass
On Sun, 27 Feb 2022 at 07:40, Alexander Graf wrote: > > The QEMU fw_cfg device supports writing entries as well. Add the constant > define for it so that we can leverage write functionality later. > > Signed-off-by: Alexander Graf > --- > include/qfw.h | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH v2 12/12] rockchip: fix boot_devices constants

2022-03-11 Thread Simon Glass
Hi Johan, On Thu, 3 Mar 2022 at 07:37, Johan Jonker wrote: > > Hi Simon, > > Thank you for your test report. > As I don't always have the hardware, could the board maintainers help me > identify u-boot specific property differences with Linux that need to be > moved to a dtsi file. > > Will send

Re: [PATCH] qfw: Allocate ACPI memory using efi logic

2022-03-11 Thread Simon Glass
Hi Alex, On Sun, 27 Feb 2022 at 07:23, Alexander Graf wrote: > > When we allocate ACPI tables dynamically as part of the qfw ACPI loading > code and then later want to boot a UEFI target using them, we need to make > sure that the UEFI logic is aware that these memory regions are ACPI, so > that

Re: [PATCH V3] Makefile: Sort u-boot-initial-env output

2022-03-11 Thread Simon Glass
On Tue, 1 Mar 2022 at 01:42, Christoph Niedermaier wrote: > > This will sort the default environment file generated by > "make u-boot-initial-env", but won't sort the default > environment in the compiled u-boot binary. The file > u-boot-initial-env is considered to use for the userpace >

Re: [PATCH 1/2] Split CONFIG_CC_OPTIMIZE_FOR_SIZE into two configs

2022-03-11 Thread Simon Glass
On Tue, 22 Feb 2022 at 10:20, Sean Anderson wrote: > > This adds a separate CONFIG_CC_OPTIMIZE_FOR_SPEED option in a choice, > in preparation for adding another optimization option. Also convert SH's > makefile to use this new option. > > Signed-off-by: Sean Anderson > --- > > Kconfig

Re: [PATCH V2] Makefile: Sort u-boot-initial-env output

2022-03-11 Thread Simon Glass
On Fri, 25 Feb 2022 at 15:10, Christoph Niedermaier wrote: > > This will sort the default environment file generated by > "make u-boot-initial-env", but won't sort the default > environment in the compiled u-boot binary. The file > u-boot-initial-env is considered to use for the userpace >

Re: [PATCH 06/14] misc: Add support for nvmem cells

2022-03-11 Thread Simon Glass
Hi Sean, On Thu, 3 Mar 2022 at 10:45, Sean Anderson wrote: > > Hi Simon, > > On 3/1/22 9:58 AM, Simon Glass wrote: > > Hi Sean, > > > > On Mon, 28 Feb 2022 at 09:43, Sean Anderson wrote: > >> > >> > >> > >> On 2/26/22 1:36 PM, Simon Glass wrote: > >> > Hi Sean, > >> > > >> > On Mon, 7 Feb 2022

Re: [PATCH] qfw: Do not include tables.h on arm

2022-03-11 Thread Simon Glass
Hi Alex, On Sun, 27 Feb 2022 at 07:18, Alexander Graf wrote: > > asm/tables.h does not exist on ARM and I did not need it to make the > code compile successfully. Let's not include it there. > > Signed-off-by: Alexander Graf > > --- > > Maybe someone with more insight into the qfw code could

Re: [PATCH] console: Implement flush() function

2022-03-11 Thread Simon Glass
Hi Pali, On Wed, 23 Feb 2022 at 06:34, Pali Rohár wrote: > > On certain places it is required to flush output print buffers to ensure > that text strings were sent to console or serial devices. For example when > printing message that U-Boot is going to boot kernel or when U-Boot is > going to

Re: two questions on verified boot

2022-03-11 Thread Simon Glass
Hi Rasmus, On Thu, 27 Jan 2022 at 08:41, Rasmus Villemoes wrote: > > On 27/01/2022 16.06, Simon Glass wrote: > > Hi Rasmus, > > > > On Sun, 21 Nov 2021 at 07:55, Rasmus Villemoes > > wrote: > >> > >> (1) When one wants to get rid of CONFIG_LEGACY_IMAGE_FORMAT, one also > >> has to wrap any boot

Re: [PATCH v1 11/11] [RFC] rockchip: rk356x: attempt to fix ram detection

2022-03-11 Thread Simon Glass
Hi Peter, On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > This patch attempts to fix ram detection on rk3568. > Prior to this, the rk3568 incorrectly detected 8gb ram as 2gb. > On top of this, the board panics when u-boot accesses ram above 4gb. > > Fix this by correcting ram detection in

Re: [PATCH v1 10/11] rockchip: rk3568: add dwc3 otg support

2022-03-11 Thread Simon Glass
On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > Add the required platform data to the rk3568 chip config, in order to > support dwc3 otg on this chip. > > Signed-off-by: Peter Geis > --- > arch/arm/mach-rockchip/rk3568/rk3568.c | 29 ++ > 1 file changed, 29

Re: [PATCH v1 09/11] rockchip: move dwc3 config to chip specific handler

2022-03-11 Thread Simon Glass
On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > The dwc3 code in the mach-rockchip board file is specific to the rk3399. > Move it to the rk3399 chip specific code. > > Signed-off-by: Peter Geis > --- > arch/arm/mach-rockchip/board.c | 24 - >

Re: [PATCH v1 06/11] rockchip: handle bootrom recovery mode in spl

2022-03-11 Thread Simon Glass
Hi Peter, On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > Fixup the bootrom recovery mode code to function in spl, so we can > handle recovery mode in case u-boot loading is broken. > > Signed-off-by: Peter Geis > --- > arch/arm/mach-rockchip/Makefile| 6 +++--- >

Re: [PATCH v1 07/11] rockchip: rk3568: add boot device detection

2022-03-11 Thread Simon Glass
Hi Peter, On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > Enable rk3568 spl to detect which device it was booted from. > > Signed-off-by: Peter Geis > --- > arch/arm/mach-rockchip/rk3568/rk3568.c | 8 > 1 file changed, 8 insertions(+) > Reviewed-by: Simon Glass I think a better

Re: [PATCH v1 01/11] clk: rockchip: rk3568: fix reset handler

2022-03-11 Thread Simon Glass
Hi Peter, On Mon, 21 Feb 2022 at 18:31, Peter Geis wrote: > > The reset handler for rk3568 is missing its private data. This leads to > an abort when a reset is triggered. > > Add the missing dev_set_priv to the rk3568 clk driver. > > Fixes: 4a262feba3a5 ("rockchip: rk3568: add clock driver") >

Re: [PATCH] fit: display proper node on error

2022-03-11 Thread Simon Glass
Hi Angelo, On Mon, 25 Oct 2021 at 15:11, Angelo Dureghello wrote: > > Hi, > > On Sun, Oct 24, 2021 at 9:53 PM Simon Glass wrote: >> >> Hi Alex, >> >> On Wed, 6 Oct 2021 at 10:00, Alex G. wrote: >> > >> > + Simon >> > >> > On 10/6/21 10:47 AM, Angelo Dureghello wrote: >> > > Fix final error

Re: [PATCH v3 12/12] rockchip: fix boot_devices constants

2022-03-11 Thread Simon Glass
Hi Johan, On Thu, 3 Mar 2022 at 16:53, Johan Jonker wrote: > > The DT node name pattern in mmc-controller.yaml for mmc > is "^mmc(@.*)?$". The Rockchip mmc nodes have been synced > with Linux, so update the boot_devices constants as well. > > Signed-off-by: Johan Jonker > Reviewed-by: Simon

Re: [PATCH] test/py: efi_capsule: Handle expected reset after capsule on disk

2022-03-11 Thread Simon Glass
Hi Takahiro, On Fri, 18 Feb 2022 at 18:16, AKASHI Takahiro wrote: > > On Fri, Feb 18, 2022 at 02:48:54PM +0100, Heinrich Schuchardt wrote: > > On 2/18/22 03:16, Masami Hiramatsu wrote: > > > Hi Simon, > > > > > > Thank you for your reply. > > > > > > 2022年2月18日(金) 2:56 Simon Glass : > > > > > >

Re: [PATCH 3/5] rcar3_salvator-x: Drop EFI_LOADER

2022-03-11 Thread Simon Glass
Hi Tom, On Fri, 11 Mar 2022 at 13:21, Tom Rini wrote: > > On Fri, Mar 11, 2022 at 12:10:03PM -0700, Simon Glass wrote: > > > This board is too close to the limit to enable this feature. Drop it. > > > > Signed-off-by: Simon Glass > > --- > > > > configs/rcar3_salvator-x_defconfig | 2 +- > > 1

Re: [PATCH 2/5] tbs2910: Disable ext4 write

2022-03-11 Thread Simon Glass
Hi Tom, On Fri, 11 Mar 2022 at 12:58, Tom Rini wrote: > > On Fri, Mar 11, 2022 at 12:10:02PM -0700, Simon Glass wrote: > > > This board is right up against the size limit. Drop ext4 writing to give > > it some more space. > > > > Signed-off-by: Simon Glass > > I would really like to see what

Re: [PATCH v2 23/41] bootstd: Add support for bootflows

2022-03-11 Thread Simon Glass
Hi Ilias, On Wed, 27 Oct 2021 at 01:37, Ilias Apalodimas wrote: > > Hi Simon, > > > + > > [...] > > > +/* error codes used to signal running out of things */ > > +enum { > > + BF_NO_MORE_PARTS= -ESHUTDOWN, > > + BF_NO_MORE_DEVICES = -ENODEV, > > +}; > > + > > +static const

Re: [PATCH][RFC] image: fdt: Fix DT relocation handling with multiple DRAM banks with gap

2022-03-11 Thread Simon Glass
Hi Marek, On Wed, 21 Jul 2021 at 18:05, Marek Vasut wrote: > > The current implementation of boot_relocate_fdt() places DT at the > highest usable DRAM address, which is calculated as: > env_get_bootm_low() + env_get_bootm_mapsize() > which by default becomes gd->ram_base + gd->ram_size. > >

Re: [PATCH] dm: core: Check flags before removing devices

2022-03-11 Thread Simon Glass
Hi Marek, On Fri, 11 Feb 2022 at 08:24, Marek Vasut wrote: > > On 2/11/22 16:05, Simon Glass wrote: > > Hi Marek, > > Hi, > > >> Calling device_chld_remove() before flags_remove() means all devices > >> get removed no matter whether they should be removed late or not. This > >> breaks teardown

Re: [RESEND RFC PATCH v2 3/4] test: unit test for u16_strlcat()

2022-03-11 Thread Simon Glass
On Thu, 24 Feb 2022 at 18:31, Masahisa Kojima wrote: > > Provide a unit test for function u16_strlcat(). > > Signed-off-by: Masahisa Kojima > --- > Newly created in v2. > > test/unicode_ut.c | 45 + > 1 file changed, 45 insertions(+) Reviewed-by:

Re: [RESEND RFC PATCH v2 2/4] lib/charset: add u16_strlcat() function

2022-03-11 Thread Simon Glass
Hi Masahisa, On Thu, 24 Feb 2022 at 18:31, Masahisa Kojima wrote: > > Provide u16 string version of strlcat(). > > Signed-off-by: Masahisa Kojima > --- > Changes in v2: > - implement u16_strlcat(with the destination buffer size in argument) > instead of u16_strcat > > include/charset.h | 15

[PATCH 2/2] env: Drop the unncessary protocol mention in autoload

2022-03-11 Thread Simon Glass
Drop this text at the end since it already mentions bootp and dhcp. Signed-off-by: Simon Glass Suggested-by: Heinrich Schuchardt --- doc/usage/environment.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/usage/environment.rst b/doc/usage/environment.rst index

[PATCH 1/2] env: Move the doc comment to the code

2022-03-11 Thread Simon Glass
This doesn't really make much sense in the documentation. Add a code comment instead. Suggested-by: Heinrich Schuchardt Signed-off-by: Simon Glass --- common/autoboot.c | 5 + doc/usage/environment.rst | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/5] tbs2910: Disable ext4 write

2022-03-11 Thread Soeren Moch
On 11.03.22 20:10, Simon Glass wrote: This board is right up against the size limit. Drop ext4 writing to give it some more space. Signed-off-by: Simon Glass NAK. At least for now. We should not randomly disable user visible functionality and not without investigating other possible

Re: [PATCH v3 00/19] efi_loader: more tightly integrate UEFI disks to driver model

2022-03-11 Thread Soeren Moch
On 09.03.22 16:33, Simon Glass wrote: Hi Tom, On Wed, 9 Mar 2022 at 07:25, Tom Rini wrote: On Tue, Mar 08, 2022 at 08:10:38PM -0700, Simon Glass wrote: Hi Tom, On Tue, 8 Mar 2022 at 20:00, Tom Rini wrote: On Tue, Mar 08, 2022 at 07:32:59PM -0700, Simon Glass wrote: Hi Tom, On Tue,

Re: [PATCH 3/5] rcar3_salvator-x: Drop EFI_LOADER

2022-03-11 Thread Tom Rini
On Fri, Mar 11, 2022 at 12:10:03PM -0700, Simon Glass wrote: > This board is too close to the limit to enable this feature. Drop it. > > Signed-off-by: Simon Glass > --- > > configs/rcar3_salvator-x_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v1] MAINTAINERS: add rockchip regex for more files and directories

2022-03-11 Thread Jagan Teki
On Fri, Dec 24, 2021 at 10:41 PM Johan Jonker wrote: > > The current files and directories with wildcard patterns for > Rockchip patches in MAINTAINERS is not always complete. > Add the regex for DT related files and a generic regex for > catching some other forgotten cases, so that the

Re: [PATCH v3 4/4] rockchip: rk3399: Add support for chromebook_kevin

2022-03-11 Thread Jagan Teki
On Fri, Dec 24, 2021 at 7:14 PM Alper Nebi Yasak wrote: > > From: "Marty E. Plummer" > > Add support for Kevin, an RK3399-based convertible chromebook that is > very similar to Bob. This patch is mostly based on existing support for > Bob, with only minor changes for Kevin-specific things. > >

Re: [PATCH v3 3/4] rockchip: bob: Enable more configs

2022-03-11 Thread Jagan Teki
On Fri, Dec 24, 2021 at 7:14 PM Alper Nebi Yasak wrote: > > This patch enables some configs that should be working on the Bob board, > based on what is observed to work on the Kevin board. > > The Bob board uses an Embedded DisplayPort panel compatible with the > simple panel and Rockchip eDP

Re: [PATCH 2/5] tbs2910: Disable ext4 write

2022-03-11 Thread Tom Rini
On Fri, Mar 11, 2022 at 12:10:02PM -0700, Simon Glass wrote: > This board is right up against the size limit. Drop ext4 writing to give > it some more space. > > Signed-off-by: Simon Glass I would really like to see what LTO does here instead of removing functionality. I'm sure it shrinks

Re: [PATCH v3 1/4] rockchip: gru: Set up SoC IO domain registers

2022-03-11 Thread Jagan Teki
On Fri, Dec 24, 2021 at 7:14 PM Alper Nebi Yasak wrote: > > The RK3399 SoC needs to know the voltage value provided by some > regulators, which is done by setting relevant register bits. Configure > these the way other RK3399 boards do, but with the same values as are > set in the equivalent code

Re: No u-boot-rockchip pull request sent or merged for v2022.04

2022-03-11 Thread Alper Nebi Yasak
On 11/03/2022 22:25, Alper Nebi Yasak wrote: > On 11/03/2022 22:01, Tom Rini wrote: >> On Fri, Mar 11, 2022 at 09:56:59PM +0300, Alper Nebi Yasak wrote: >>> On 11/03/2022 21:18, Simon Glass wrote: Apler, would you be interested in being a co-maintainer for Rockchip? >>> >>> I can try. Not

Re: [PATCH v3] spi: spi_flash_probe_bus_cs() rely on DT for spi speed and mode

2022-03-11 Thread Jagan Teki
Hi Patrice, On Mon, Mar 7, 2022 at 11:20 PM Patrice Chotard wrote: > > Since commit e2e95e5e2542 ("spi: Update speed/mode on change") > when calling "sf probe" or "env save" on SPI flash, > spi_set_speed_mode() is called twice. > > spi_get_bus_and_cs() > |--> spi_claim_bus() > |

Re: [PATCH v3 1/3] rockchip: Kconfig: Enable SPL support for rk3568

2022-03-11 Thread Jagan Teki
On Tue, Oct 26, 2021 at 8:13 AM Nico Cheng wrote: > > Enable SPL support in Kconfig and add some related option in > rk3568_common.h > > Signed-off-by: Nico Cheng > Signed-off-by: Jason Zhu > --- Reviewed-by: Jagan Teki

Re: [PATCH v2 2/2] clk: imx8mq: Add a clock driver for the imx8mq

2022-03-11 Thread Angus Ainslie
On 2022-03-11 11:19, Marek Vasut wrote: On 3/11/22 19:41, Angus Ainslie wrote: On 2022-03-11 10:05, Marek Vasut wrote: On 3/11/22 18:02, Angus Ainslie wrote: On 2022-03-11 08:57, Marek Vasut wrote: On 3/11/22 17:35, Angus Ainslie wrote: All of the PLLs and clocks are initialized so the

Re: [PATCH v4 0/3] mtd: Support slc-mode for NTC CHIP

2022-03-11 Thread Jagan Teki
On Thu, Mar 10, 2022 at 8:57 PM Chris Morgan wrote: > > On Thu, Mar 10, 2022 at 05:30:17PM +0530, Jagan Teki wrote: > > Hi Chris, > > > > On Thu, Jan 20, 2022 at 6:44 PM Jagan Teki > > wrote: > > > > > > On Fri, Dec 17, 2021 at 12:14 AM Chris Morgan > > > wrote: > > > > > > > > From: Chris

Re: [RFC PATCH v1 5/6] rockchip: rk3318: add a95x-z2-rk3318_defconfig file

2022-03-11 Thread Jagan Teki
On Thu, Jul 1, 2021 at 12:20 AM Johan Jonker wrote: > > This commit adds the default configuration file and relevant description > for A95X Z2 board > > Signed-off-by: Johan Jonker > --- > board/rockchip/evb_rk3328/MAINTAINERS | 6 ++ > configs/a95x-z2-rk3318_defconfig | 102 >

  1   2   >