Does enabling the Driver Model makes the boot slower ?

2022-04-03 Thread Abder
Hi, Recently I have worked on porting an imx6 based board's u-boot2014 to u-boot2020 and I enabled all the used drivers to use DM: GPIO, ETH, USB, SPI, MMC, WDT, MTD and REGULATOR. However, I noticed that the boot of the new u-boot is somehow slower than the old one (not by much though) ! Person

Re: [PATCH v4 06/11] efi_loader: bootmgr: add booting from removable media

2022-04-03 Thread Masahisa Kojima
On Sat, 2 Apr 2022 at 15:12, Heinrich Schuchardt wrote: > > On 3/24/22 14:54, Masahisa Kojima wrote: > > From: AKASHI Takahiro > > > > Under the current implementation, booting from removable media using > > a architecture-specific default image name, say BOOTAA64.EFI, is > > supported only in di

Re: [PATCH v4 00/11] enable menu-driven boot device selection

2022-04-03 Thread Masahisa Kojima
Hi Heinrich, On Sat, 2 Apr 2022 at 14:48, Heinrich Schuchardt wrote: > > On 3/24/22 14:54, Masahisa Kojima wrote: > > This patch series adds the menu-driven boot device selection, > > by extending the existing "bootmenu" to include UEFI and distro_boot > > related entries, and supports menu-drive

Re: [PATCH 3/3] efi_loader: setting boot device

2022-04-03 Thread Heinrich Schuchardt
Am 4. April 2022 07:40:16 MESZ schrieb Kyle Evans : >On Mon, Apr 4, 2022 at 12:09 AM Heinrich Schuchardt wrote: >> >> Am 3. April 2022 23:08:33 MESZ schrieb Kyle Evans : >> > On Tue, Jan 12, 2021 at 1:59 PM Heinrich Schuchardt >> > wrote: >> >> >> >> Up to now the bootefi command used the last f

Re: [PATCH 3/3] efi_loader: setting boot device

2022-04-03 Thread Kyle Evans
On Mon, Apr 4, 2022 at 12:09 AM Heinrich Schuchardt wrote: > > Am 3. April 2022 23:08:33 MESZ schrieb Kyle Evans : > > On Tue, Jan 12, 2021 at 1:59 PM Heinrich Schuchardt > > wrote: > >> > >> Up to now the bootefi command used the last file loaded to determine the > >> boot partition. This has l

Re: [PATCH 3/3] efi_loader: setting boot device

2022-04-03 Thread Heinrich Schuchardt
Am 3. April 2022 23:08:33 MESZ schrieb Kyle Evans : > On Tue, Jan 12, 2021 at 1:59 PM Heinrich Schuchardt > wrote: >> >> Up to now the bootefi command used the last file loaded to determine the >> boot partition. This has led to errors when the fdt had been loaded from >> another partition after

Re: [PATCH 06/25] s5p_goni, smdkc100: Move some environment settings out of CONFIG

2022-04-03 Thread Minkyu Kang
2022년 3월 31일 (목) 07:09, Tom Rini 님이 작성: > A number of CONFIG options are used on these platforms as part of the > default environment. Set some of these more directly and in other > cases, just reference them directly. > > Cc: Jaehoon Chung > Cc: Minkyu Kang > Signed-off-by: Tom Rini > --- >

Re: [PATCH v2 00/23] sunxi: Add and use a pinctrl driver

2022-04-03 Thread Samuel Holland
Hi Andre, On 4/3/22 7:54 PM, Andre Przywara wrote: > On Thu, 17 Mar 2022 22:53:57 -0500 > Samuel Holland wrote: > > Hi Samuel, > >> This series resolves some longstanding TODOs by implementing a pinctrl >> driver for sunxi platforms and converting DM drivers to use it. > > So as mentioned befo

Re: [PATCH v2] Add ethernet0 alias in Nanopi NEO's device tree

2022-04-03 Thread Andre Przywara
On Sat, 26 Mar 2022 13:09:10 +0100 Baltazár Radics wrote: Hi Baltazár, > This is required to enable automatic MAC address generation. For the records, this should rather be marked as a sync from the Linux tree, where this was conveniently merged just recently. In the long run we should see if

Re: [PATCH v2 00/23] sunxi: Add and use a pinctrl driver

2022-04-03 Thread Andre Przywara
On Thu, 17 Mar 2022 22:53:57 -0500 Samuel Holland wrote: Hi Samuel, > This series resolves some longstanding TODOs by implementing a pinctrl > driver for sunxi platforms and converting DM drivers to use it. So as mentioned before, this is a huge step forward, and helps to remove some dodgy and

Re: [PATCH] env: Fix avoid using a leftover text-environment file

2022-04-03 Thread Sean Anderson
On 4/3/22 7:17 PM, Marek Vasut wrote: Clean build ends up generating the following error, add -f switch to rm to mitigate it: " rm: cannot remove 'include/generated/env.in': No such file or directory " Fixes: f432eb6d8a9 ("env: Avoid using a leftover text-environment file") Cc: Sean Anderson Cc

[PATCH] led: Configure LED default-state on boot

2022-04-03 Thread Marek Vasut
In case the DT LED subnode contains "default-state" property set to either "on" or "off", probe the LED driver and configure the LED state automatically. Signed-off-by: Marek Vasut Cc: Alex Nemirovsky Cc: Patrick Delaunay Cc: Philippe Reynes Cc: Sean Anderson Cc: Simon Glass Cc: Steven Lawra

[PATCH 6/6] led: gpio: Drop duplicate OF "label" property parsing

2022-04-03 Thread Marek Vasut
The OF "label" property parsing is now handled in LED core, drop the duplicate implementation from this driver. Signed-off-by: Marek Vasut Cc: Alex Nemirovsky Cc: Patrick Delaunay Cc: Philippe Reynes Cc: Sean Anderson Cc: Simon Glass Cc: Steven Lawrance --- drivers/led/led_gpio.c | 8 -

[PATCH 5/6] led: cortina: Drop duplicate OF "label" property parsing

2022-04-03 Thread Marek Vasut
The OF "label" property parsing is now handled in LED core, drop the duplicate implementation from this driver. Signed-off-by: Marek Vasut Cc: Alex Nemirovsky Cc: Patrick Delaunay Cc: Philippe Reynes Cc: Sean Anderson Cc: Simon Glass Cc: Steven Lawrance --- drivers/led/led_cortina.c | 11 -

[PATCH 4/6] led: bcm6858: Drop duplicate OF "label" property parsing

2022-04-03 Thread Marek Vasut
The OF "label" property parsing is now handled in LED core, drop the duplicate implementation from this driver. Signed-off-by: Marek Vasut Cc: Alex Nemirovsky Cc: Patrick Delaunay Cc: Philippe Reynes Cc: Sean Anderson Cc: Simon Glass Cc: Steven Lawrance --- drivers/led/led_bcm6858.c | 12 -

[PATCH 2/6] led: bcm6328: Drop duplicate OF "label" property parsing

2022-04-03 Thread Marek Vasut
The OF "label" property parsing is now handled in LED core, drop the duplicate implementation from this driver. Signed-off-by: Marek Vasut Cc: Alex Nemirovsky Cc: Patrick Delaunay Cc: Philippe Reynes Cc: Sean Anderson Cc: Simon Glass Cc: Steven Lawrance --- drivers/led/led_bcm6328.c | 12 -

[PATCH 3/6] led: bcm6358: Drop duplicate OF "label" property parsing

2022-04-03 Thread Marek Vasut
The OF "label" property parsing is now handled in LED core, drop the duplicate implementation from this driver. Signed-off-by: Marek Vasut Cc: Alex Nemirovsky Cc: Patrick Delaunay Cc: Philippe Reynes Cc: Sean Anderson Cc: Simon Glass Cc: Steven Lawrance --- drivers/led/led_bcm6358.c | 12 -

[PATCH 1/6] led: Move OF "label" property parsing to core

2022-04-03 Thread Marek Vasut
Every driver in drivers/led/ currently does some form of "label" OF property parsing in its bind() callback. Move this label parsing to LED core, since this "label" OF property is a generic property. This permits code deduplication in subseuqent patches. Signed-off-by: Marek Vasut Cc: Alex Nemiro

[PATCH] env: Fix avoid using a leftover text-environment file

2022-04-03 Thread Marek Vasut
Clean build ends up generating the following error, add -f switch to rm to mitigate it: " rm: cannot remove 'include/generated/env.in': No such file or directory " Fixes: f432eb6d8a9 ("env: Avoid using a leftover text-environment file") Cc: Sean Anderson Cc: Simon Glass Cc: Tom Rini --- Makefi

[PATCH v4 07/12] rockchip: timer: dw-apb-timer: fix whitespace in U_BOOT_DRIVER structure

2022-04-03 Thread Johan Jonker
The line with .of_to_plat in the U_BOOT_DRIVER structure of dw-apb-timer.c is not aligned with the rest. Add an extra TAB to fix the whitespace. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass --- drivers/timer/dw-apb-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH v4 10/12] rockchip: serial: restyle the serial_rockchip.c driver

2022-04-03 Thread Johan Jonker
The ns16550.c driver has the following conditions for .of_match: CONFIG_IS_ENABLED(OF_REAL) For Rockchip SoCs with TPL/SPL and platform data that need serial support the serial_rockchip.c driver was made. It copies this data and then calls ns16550_serial_probe(). With the addition of yet an other

[PATCH v4 12/12] rockchip: serial: Kconfig: add select SYS_NS16550 to config ROCKCHIP_SERIAL

2022-04-03 Thread Johan Jonker
The Rockchip serial driver depends on an enabled NS16550 driver, so add select SYS_NS16550 to config ROCKCHIP_SERIAL. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass --- drivers/serial/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconf

[PATCH v4 01/12] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig

2022-04-03 Thread Johan Jonker
Move ROCKCHIP_STIMER_BASE to Kconfig. Signed-off-by: Johan Jonker --- Changed V4: rebase remove depends on rk3188/rk3066 must now disable ROCKCHIP_STIMER in defconfig with defconfig there is more flexibility for other SoC types Changed V3: add ROCKCHIP_STIMER --- arch/arm/mach-rockch

[PATCH v4 11/12] rockchip: serial: move driver alias to serial_rockchip.c

2022-04-03 Thread Johan Jonker
The Rockchip uart DT nodes have "snps,dw-apb-uart" as fall back string. The driver ns16550.c has CONFIG_IS_ENABLED(OF_REAL) as condition to of_match and does not copy dtplat data. For TPL/SPL the driver serial_rockchip.c is used. Move driver alias to correct driver. Signed-off-by: Johan Jonker Re

[PATCH v4 09/12] rockchip: mmc: rockchip_dw_mmc: add rk3066/rk3188 support

2022-04-03 Thread Johan Jonker
The Rockchip SoCs rk3066/rk3188 have mmc DT nodes with as compatible string "rockchip,rk2928-dw-mshc". Add support to the existing driver with help of a DM_DRIVER_ALIAS. This type needs a permanent enabled fifo. The other Rockchip SoCs not always have the property "fifo-mode" in the TPL/SPL DT nod

[PATCH v4 02/12] rockchip: spl: change call condition rockchip_stimer_init()

2022-04-03 Thread Johan Jonker
The Rockchip SoCs rk3066/rk3188 have no CONFIG_ROCKCHIP_STIMER_BASE defined. Currently only rk3188 has an exception. Make this more generic and call the function rockchip_stimer_init() only when CONFIG_ROCKCHIP_STIMER_BASE is available. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass --- C

[PATCH v4 08/12] rockchip: mmc: rockchip_dw_mmc: fix ciu clock index

2022-04-03 Thread Johan Jonker
The document rockchip-dw-mshc.yaml decribes a maximum of 4 clocks. In the rockchip_dw_mmc driver the clock name in use was "fixed" to "ciu" with index 1, but later reverted back to index 0. The clock drivers can handle both, but the calling driver should submit correct data as a standard practice.

[PATCH v4 06/12] rockchip: timer: add OF_PLATDATA support for dw-apb-timer

2022-04-03 Thread Johan Jonker
The Rockchip rk3066 SoC has 3 dw-apb-timer nodes. U-boot is compiled with OF_PLATDATA TPL/SPL options, so add OF_PLATDATA support for the dw-apb-timer. Also change driver name to be able to compile with U-boot scripts. No reset OF_PLATDATA support was added, because the rk3066 nodes don't need/have

[PATCH v4 05/12] rockchip: tpl: use IS_ENABLED for timer_init() call condition

2022-04-03 Thread Johan Jonker
Not all Rockchip SoC models use the ARM arch timer. Call the function timer_init() only when CONFIG_SYS_ARCH_TIMER is available. Use the call condition IS_ENABLED to increase build coverage and make the code easier to read. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass --- arch/arm/mach-

[PATCH v4 04/12] rockchip: spl: replace ifdef by IS_ENABLED for timer_init() call condition

2022-04-03 Thread Johan Jonker
Not all Rockchip SoC models use the ARM arch timer. Call the function timer_init() only when CONFIG_SYS_ARCH_TIMER is available. Replace the ifdef call condition by IS_ENABLED to increase build coverage and make the code easier to read. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass --- a

[PATCH v4 03/12] rockchip: tpl: change call condition rockchip_stimer_init()

2022-04-03 Thread Johan Jonker
The Rockchip SoCs rk3066/rk3188 have no CONFIG_ROCKCHIP_STIMER_BASE defined. Currently only rk3188 has an exception. Make this more generic and call the function rockchip_stimer_init() only when CONFIG_ROCKCHIP_STIMER_BASE is available. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass --- C

[PATCH v4 00/12] Prepare RK3066 U-boot support

2022-04-03 Thread Johan Jonker
This patch serie combines a number of cleanups and fixes that are needed in preparation of Rockchip RK3066 U-boot support. The common TPL/SPL files contain support for 2 timers that are not used in the early models. Change there call condition. As we are there also increase the build coverage. Th

[PATCH] ARM: imx: Enable instruction cache early on on i.MX8M

2022-04-03 Thread Marek Vasut
Enable instruction cache early on to speed up the boot process on i.MX8M. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- arch/arm/mach-imx/imx8m/soc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8

Re: [PATCH 3/3] efi_loader: setting boot device

2022-04-03 Thread Kyle Evans
On Tue, Jan 12, 2021 at 1:59 PM Heinrich Schuchardt wrote: > > Up to now the bootefi command used the last file loaded to determine the > boot partition. This has led to errors when the fdt had been loaded from > another partition after the EFI binary. > > Before setting the boot device from a lo

Re: The contradictory nature of spl_nand_fit_read

2022-04-03 Thread Dario Binacchi
Hi Sean, > Il 01/04/2022 23:43 Michael Nazzareno Trimarchi > ha scritto: > > > Hi Sean > > On Fri, Apr 1, 2022 at 8:53 PM Sean Anderson wrote: > > > > > > > > On 4/1/22 2:46 PM, Sean Anderson wrote: > > > Hi all, > > > > > > I don't understand how spl_nand_fit_read is supposed to work. This

[PATCH] env: do not fail on non-existing env.in file

2022-04-03 Thread Andrey Zhizhikin
If include/generated/env.in does not exist, which is a typical case for clean build, quiet_cmd_gen_envp command tries to delete this file unconditionally. This produces following warning during the build: ENVPinclude/generated/env.in rm: cannot remove 'include/generated/env.in': No such file

[PATCH 7/8] test: Fix pointer overrun in dm_test_devm_regmap()

2022-04-03 Thread Andrew Scull
This tests calls regmap_read() which takes a uint pointer as an output parameter. The test was passing a pointer to a u16 which resulted in an overflow when the output was written. Fix this by following the regmap_read() API and passing a uint pointer instead. Signed-off-by: Andrew Scull Cc: Simo