Re: [PATCH 1/1] sandbox: cast to pointer from integer of different size

2022-06-28 Thread Simon Glass
On Sun, Jun 12, 2022 at 7:25 PM Heinrich Schuchardt wrote: > > Building sandbox_defconfig on ARMv7 with HOST_32BIT=y results in: > > drivers/misc/qfw_sandbox.c:51:25: warning: > cast to pointer from integer of different size [-Wint-to-pointer-cast] >51 | void *address = (void *)be64_to

Re: [PATCH v2 5/8] spl: binman: Add config options for binman symbols in VPL

2022-06-28 Thread Simon Glass
The SPL code declares binman symbols for U-Boot phases depending on CONFIG_IS_ENABLED(BINMAN_UBOOT_SYMBOLS). This config exists for SPL and TPL, also add a version for VPL. Signed-off-by: Alper Nebi Yasak --- Changes in v2: - Update VPL configs for the new BINMAN_UBOOT_SYMBOLS common/spl/Kconf

Re: [PATCH v2 7/8] spl: binman: Disable u_boot_any symbols for i.MX8M boards

2022-06-28 Thread Simon Glass
The i.MX8M boards use partially specified binman images which have an SPL entry without a U-Boot entry. This would normally cause an error due to the 'u_boot_any' binman symbols declared by BINMAN_UBOOT_SYMBOLS requiring a U-Boot-like entry in the same image as the SPL. However, a problem in the A

Re: [PATCH v2 6/8] spl: binman: Check at runtime if binman symbols were filled in

2022-06-28 Thread Simon Glass
Binman lets us declare symbols in SPL/TPL that refer to other entries in the same binman image as them. These symbols are filled in with the correct values while binman assembles the images, but this is done in-memory only. Symbols marked as optional can be filled with BINMAN_SYM_MISSING as an erro

Re: [PATCH v2 8/8] armv8: u-boot-spl.lds: mark __image_copy_start as symbol

2022-06-28 Thread Simon Glass
From: Peng Fan In arch/arm/lib/sections.c there is below code: char __image_copy_start[0] __section(".__image_copy_start"); But actually 'objdump -t spl/u-boot-spl' not able to find out symbol '__image_copy_start' for binman update image-pos/size. So update link file Signed-off-by: Peng Fan Re

Re: [PATCH 0/8] u-boot: fs: add generic unaligned read handling

2022-06-28 Thread Sean Anderson
On 6/28/22 3:28 AM, Qu Wenruo wrote: [BACKGROUND] Unlike FUSE/Kernel which always pass aligned read range, U-boot fs code just pass the request range to underlying fses. Under most case, this works fine, as U-boot only really needs to read the whole file (aka, 0 for both offset and len, len will

Re: [u-boot-test-hooks PATCH 0/2] Aspeed updates

2022-06-28 Thread Tom Rini
On Fri, 24 Jun 2022 12:04:18 +0930, Joel Stanley wrote: > This updates the configuration for the aspeed machines, adding support > for the ast2600. > > Joel Stanley (2): > ast2500: Simplify Qemu command line > travis-ci: Add Aspeed AST2600 Qemu configuration > > [...] Applied, thanks! [1/2]

[PATCH sunxi/next] spi: sunxi: use XCH status to detect in-progress transfer

2022-06-28 Thread Icenowy Zheng
The current detection of RX FIFO depth seems to be not reliable, and XCH will self-clear when a transfer is done. Check XCH bit when polling for transfer finish. Signed-off-by: Icenowy Zheng --- drivers/spi/spi-sunxi.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff -

Re: [PATCH 3/5] config/ast2600: Disable hash hardware accel

2022-06-28 Thread Steven Lee
The 06/27/2022 18:06, Joel Stanley wrote: > On Mon, 27 Jun 2022 at 08:48, Steven Lee wrote: > > > > Hi Joel, > > > > I was wondering if you could share the commit hash of u-boot you tested. > > I would like to test it on qemu. > > I recommend using master with the patch that fixes FIT hash checki

Re: [PATCH RFC 2/8] fs: always get the file size in _fs_read()

2022-06-28 Thread Qu Wenruo
On 2022/6/28 20:36, Huang Jianan wrote: Hi, wenruo, 在 2022/6/28 15:28, Qu Wenruo 写道: For _fs_read(), @len == 0 means we read the whole file. And we just pass @len == 0 to make each filesystem to handle it. In fact we have info->size() call to properly get the filesize. So we can not only c

Re: [PATCH RFC 2/8] fs: always get the file size in _fs_read()

2022-06-28 Thread Huang Jianan
Hi, wenruo, 在 2022/6/28 15:28, Qu Wenruo 写道: For _fs_read(), @len == 0 means we read the whole file. And we just pass @len == 0 to make each filesystem to handle it. In fact we have info->size() call to properly get the filesize. So we can not only call info->size() to grab the file_size for l

Re: [PATCH v2 2/2] imx: kontron-sl-mx8mm: Enable PCA9450 regulator driver and fix SD card access

2022-06-28 Thread Fabio Estevam
On Mon, Jun 27, 2022 at 8:01 AM Frieder Schrempf wrote: > > From: Frieder Schrempf > > Currently accessing the SD card on USDHC2 fails with: > > => mmc dev 1 > Card did not respond to voltage select! : -110 > > This is due to the fact that UHS modes are enabled in the defconfig > and the devicetr

Re: [PATCH v2 1/2] pmic: pca9450: Add optional SD_VSEL GPIO for LDO5

2022-06-28 Thread Fabio Estevam
On Mon, Jun 27, 2022 at 8:01 AM Frieder Schrempf wrote: > > From: Frieder Schrempf > > LDO5 has two separate control registers. LDO5CTRL_L is used if the > input signal SD_VSEL is low and LDO5CTRL_H if it is high. > The current driver implementation only uses LDO5CTRL_H. To make this > work on bo

Re: [PATCH v5 08/23] FWU: Add boot time checks as highlighted by the FWU specification

2022-06-28 Thread Sughosh Ganu
hi Etienne, On Thu, 23 Jun 2022 at 18:02, Etienne Carriere wrote: > > Hi Sughosh, > > On Thu, 23 Jun 2022 at 11:46, Sughosh Ganu wrote: > > > > hi Etienne, > > > > On Tue, 21 Jun 2022 at 16:26, Etienne Carriere > > wrote: > > > > > > Hi Sughosh, > > > > > > On Thu, 9 Jun 2022 at 14:31, Sughosh

Re: [PATCH v5 03/23] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-06-28 Thread Sughosh Ganu
hi Etienne, On Tue, 21 Jun 2022 at 16:26, Etienne Carriere wrote: > > Hello Sughosh, > > On Thu, 9 Jun 2022 at 14:30, Sughosh Ganu wrote: > > > > In the FWU Multi Bank Update feature, the information about the > > updatable images is stored as part of the metadata, on a separate > > partition. A

Re: [PATCH v5 03/23] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-06-28 Thread Sughosh Ganu
hi Patrick, Apologies for the late reply. I had missed out replying to the review comments on this patch. There are some review comments on the Synquacer patches which need to be taken care of by another engineer. Once those review comments are taken care of, I will be sending the next version. On

Re: [PATCH] mtd: spi-nor-core: Implement spi_nor_read_sfdp_dma_unsafe() for sfdp parse

2022-06-28 Thread Pratyush Yadav
On 03/06/22 12:31PM, Vaishnav Achath wrote: > During SFDP header parse and BFPT parse, structures in stack are used > to perform spi_nor_read_sfdp() which expects a dma-safe buffer. > > This commit introduces spi_nor_read_sfdp_dma_unsafe() to wrap > spi_nor_read_sfdp() using a kmalloc'ed bounce bu

Re: [PATCH v1] usb: host: nuvoton: Add nuvoton NPCM7xx ehci/ohci driver

2022-06-28 Thread Marek Vasut
On 6/28/22 05:49, Jim Liu wrote: Hi Marek Hi, Thank you for your reminder. Dell is use novuton uboot git repo now. and request us upstream it. npcm7xx normal defconfig is poleg_evb_defconfig, so all people use this config to build uboot. and poleg_evb_defconfig is in uboot master now. I sep

Re: [PATCH v3] powerpc: mpc85xx: Set TEXT_BASE addresses to real base values

2022-06-28 Thread Pali Rohár
On Thursday 23 June 2022 08:34:58 Tom Rini wrote: > On Thu, Jun 23, 2022 at 01:29:10PM +0200, Pali Rohár wrote: > > On Thursday 16 June 2022 14:19:44 Pali Rohár wrote: > > > Currently CONFIG_SPL_TEXT_BASE and CONFIG_SYS_TEXT_BASE addresses are > > > manually increased by 0x1000 due to .bootpg secti

[PATCH RFC 8/8] fs: erofs: add unaligned read range handling

2022-06-28 Thread Qu Wenruo
I'm not an expert on erofs, but my quick glance didn't expose any special handling on unaligned range, thus I think the U-boot erofs driver doesn't really support unaligned read range. This patch will add erofs_get_blocksize() so erofs can benefit from the generic unaligned read support. Cc: Huan

[PATCH RFC 7/8] fs: ubifs: rely on higher layer to do unaligned read

2022-06-28 Thread Qu Wenruo
Currently ubifs doesn't support unaligned read offset, thanks to the recent _fs_read() work to handle unaligned read, we only need to implement ubifs_get_blocksize() to take advantage of it. Now ubifs can do unaligned read without any problem. Signed-off-by: Qu Wenruo --- fs/fs.c

[PATCH RFC 6/8] fs: sandboxfs: add sandbox_fs_get_blocksize()

2022-06-28 Thread Qu Wenruo
This is to make sandboxfs to report blocksize it supports for _fs_read() to handle unaligned read. Unlike all other fses, sandboxfs can handle unaligned read/write without any problem since it's calling read()/write(), which doesn't bother the blocksize at all. This change is mostly to make testi

[PATCH RFC 5/8] fs: fat: rely on higher layer to get block aligned read range

2022-06-28 Thread Qu Wenruo
Just implement fat_get_blocksize() for fat, so that fat_read_file() always get a block aligned read range. Unfortunately I'm not experienced enough to cleanup the fat code, thus further cleanup is appreciated. Cc: Tom Rini Signed-off-by: Qu Wenruo --- fs/fat/fat.c | 13 + fs/fs.c

[PATCH RFC 4/8] fs: ext4: rely on _fs_read() to pass block aligned range into ext4fs_read_file()

2022-06-28 Thread Qu Wenruo
Since _fs_read() is handling the unaligned read internally, ext4 driver only need to handle block aligned read. Unfortunately I'm not familiar with ext4 and its driver, thus not confident enough to cleanup all the unaligned read related code. So here we will have some dead code, and any help to c

[PATCH RFC 3/8] fs: btrfs: move the unaligned read code to _fs_read() for btrfs

2022-06-28 Thread Qu Wenruo
Unlike FUSE or kernel, U-boot filesystem code makes the underly fs code to handle the unaligned read (aka, read range is not aligned to fs block size). This makes underlying fs code harder to implement, as unlike FUSE/kernel code, now they have to handle unaligned read all by themselves. This pat

[PATCH RFC 2/8] fs: always get the file size in _fs_read()

2022-06-28 Thread Qu Wenruo
For _fs_read(), @len == 0 means we read the whole file. And we just pass @len == 0 to make each filesystem to handle it. In fact we have info->size() call to properly get the filesize. So we can not only call info->size() to grab the file_size for len == 0 case, but also detect invalid @len (e.g.

[PATCH RFC 1/8] fs: fat: unexport file_fat_read_at()

2022-06-28 Thread Qu Wenruo
That function is only utilized inside fat driver, unexport it. Signed-off-by: Qu Wenruo --- fs/fat/fat.c | 4 ++-- include/fat.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index df9ea2c028fc..dcceccbcee0a 100644 --- a/fs/fat/fat.c +++ b/fs

[PATCH 0/8] u-boot: fs: add generic unaligned read handling

2022-06-28 Thread Qu Wenruo
[BACKGROUND] Unlike FUSE/Kernel which always pass aligned read range, U-boot fs code just pass the request range to underlying fses. Under most case, this works fine, as U-boot only really needs to read the whole file (aka, 0 for both offset and len, len will be later determined using file size).

Re: [PATCH 18/20] kmcoge5ne: Move BFTIC3 CONFIG references to their usage

2022-06-28 Thread Heiko Schocher
Hello Tom, On 25.06.22 17:02, Tom Rini wrote: > We only reference CONFIG_SYS_BFTIC3_BASE in one location. Move the > comment to where we reference it, and use the value directly. > > Cc: Holger Brunck > Cc: Heiko Schocher > Signed-off-by: Tom Rini > --- > board/keymile/km83xx/km83xx.c | 6 ++

<    1   2