Re: [PATCH v3 2/4] rockchip: rk-3399: rock-pi-4: dts: Add XTX SPI NOR 4MiB Flash chip in Rock Pi 4 boards from rev 1.4 on.

2022-08-26 Thread Kever Yang
On 2022/7/20 23:41, Xavier Drudis Ferran wrote: Configure Rock Pi 4 to boot from SPI NOR Flash. Based on flash chip, board documentation and tests, this is the fastest I could use it. This seems to be the minimum necessary configuration for Rock Pi 4 to be able to boot from SPI NOR Flash.

Re: [PATCH 2/2] rockchip: rk3399: sync spl_boot_devices_tbl and boot_devices node paths

2022-08-26 Thread Kever Yang
On 2022/7/15 23:15, Quentin Schulz wrote: From: Quentin Schulz While technically not a bug, let's have some consistency in paths returned by u-boot,spl-boot-order look-up and the one saved in u-boot,spl-boot-device by syncing spl_boot_devices_tbl and boot_devices node paths. Cc: Quentin

Re: [PATCH 1/2] rockchip: rk3399: fix incorrect boot-device in u-boot,spl-boot-device

2022-08-26 Thread Kever Yang
On 2022/7/15 23:15, Quentin Schulz wrote: From: Quentin Schulz On RK3399, mmc0 is eMMC and mmc1 is SD card, c.f. console: MMC: mmc@fe32: 1, mmc@fe33: 0 In arch/arm/mach-rockchip/spl-boot-order.c:board_boot_order, the boot_device (BOOT_DEVICE_*) value is gotten from

Re: [PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper

2022-08-26 Thread Kever Yang
Hi Michal, Quentin, Xavier, On 2022/7/18 21:01, Quentin Schulz wrote: Hi Michal, On 7/18/22 13:00, Michal Suchánek wrote: On Mon, Jul 18, 2022 at 11:09:56AM +0200, Xavier Drudis Ferran wrote: El Mon, Jul 18, 2022 at 10:33:18AM +0200, Quentin Schulz deia: Hi Xavier, On 7/15/22 18:30,

Re: [PATCH] rockchip: rk3308: fix same-as-spl boot order

2022-08-26 Thread Kever Yang
On 2022/7/14 22:18, John Keeping wrote: Rockchip SoCs need the boot_devices array defined in order to map the bootloader's value to a U-Boot device. Implement this for rk3308. Signed-off-by: John Keeping Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH] rockchip: rk3308: fix rockchip_dnl_key_pressed() on roc-cc

2022-08-26 Thread Kever Yang
On 2022/7/14 22:09, John Keeping wrote: Commit 6aa4fe3912 ("dm: core: Rename and fix uclass_get_by_name_len()") changed uclass_get_device_by_name() to an exact match when previously it behaved as a prefix match. The roc-cc code relied on this prefix match by only specifying part of the device

Re: [PATCH] arm: dts: rockchip: rk3399: usb: ehci: Fix EHCI probe in rk3399 to access peripherals by USB 2.

2022-08-26 Thread Kever Yang
Hi Xavier, On 2022/7/2 02:59, Xavier Drudis Ferran wrote: arch/arm/dts/rk3399.dtsi has a node usb_host0_ehci: usb@fe38 { compatible = "generic-ehci"; with clocks: clocks = < HCLK_HOST0>, < HCLK_HOST0_ARB>, <>; The first 2 refer to nodes with class

[PATCH v4 2/2] image-fit: don't set compression if it can't be read

2022-08-26 Thread Daniel Golle
fit_image_get_comp() should not set value -1 in case it can't read the compression node. Instead, leave the value untouched in that case as it can be absent and a default value previously defined by the caller of fit_image_get_comp() should be used. As a result the warning message WARNING:

[PATCH v4 1/2] bootm: fix typo imape_comp -> image_comp

2022-08-26 Thread Daniel Golle
Chage variable name 'imape_comp' to the supposedly intended name 'image_comp'. Signed-off-by: Daniel Golle --- v4: add missing name replacement boot/bootm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index 86dbfbcfed..63c79a9cfc

[PATCH v3 2/2] image-fit: don't set compression if it can't be read

2022-08-26 Thread Daniel Golle
fit_image_get_comp() should not set value -1 in case it can't read the compression node. Instead, leave the value untouched in that case as it can be absent and a default value previously defined by the caller of fit_image_get_comp() should be used. As a result the warning message WARNING:

[PATCH v3 1/2] bootm: fix typo imape_comp -> image_comp

2022-08-26 Thread Daniel Golle
Chage variable name 'imape_comp' to the supposedly intended name 'image_comp'. Signed-off-by: Daniel Golle --- boot/bootm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index 86dbfbcfed..4de573e24e 100644 --- a/boot/bootm.c +++

Re: [PATCH] drivers: ram: rockchip: Fix dram channels calculation for rk3399

2022-08-26 Thread Kever Yang
On 2022/5/15 14:11, pengp...@foxmail.com wrote: From: Han Pengfei Only add the dram channel when we finally setup it successfully at the last step. Signed-off-by: Han Pengfei Reviewed-by: Kever Yang Thanks, - Kever --- drivers/ram/rockchip/sdram_rk3399.c | 4 ++-- 1 file changed, 2

Re: [PATCH] rockchip: rk3399: boot_devices: fix eMMC node name

2022-08-26 Thread Kever Yang
On 2022/7/11 22:15, Quentin Schulz wrote: From: Quentin Schulz When idbloader.img is flashed on the eMMC, the SPL still tries to load from SPI-NOR first. This is due to an incorrect look-up in the Device Tree. Since commit 822556a93459 ("arm: dts: sync the Rockhip 3399 SoCs from Linux"),

Please pull u-boot-dm

2022-08-26 Thread Simon Glass
Hi Tom, https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/13234 The following changes since commit aea087a665c447dfb89bf2113cad74ad53fa17a0: Merge https://source.denx.de/u-boot/custodians/u-boot-marvell (2022-08-23 15:44:54 -0400) are available in the Git repository at:

Re: [PATCH] binman: Sort tests and rework test-file numbers

2022-08-26 Thread Simon Glass
On Tue, 23 Aug 2022 at 04:46, Stefan Herbrechtsmeier wrote: > > From: Stefan Herbrechtsmeier > > Tests should be in order of the test-file numbers. Sort the tests > according to the test-file numbers and rework the test-file numbers to > eliminate duplicate numbers. > > Signed-off-by: Stefan

Re: [RFC PATCH] Rename disto_[pxe_]getfile to distro_[pxe_]getfile

2022-08-26 Thread Simon Glass
On Fri, 26 Aug 2022 at 18:21, Simon Glass wrote: > > On Fri, 26 Aug 2022 at 07:15, Dario Binacchi > wrote: > > > > Replace 'disto' with 'distro' since they are all functions about distro > > booting. > > > > Signed-off-by: Dario Binacchi > > > > --- > > > > boot/bootmeth_distro.c | 6 +++--- >

Re: [PATCH 1/2] binman: Mention split-elf in the main docs

2022-08-26 Thread Simon Glass
Since we are talking about ATF, add mention of this new feature too. Signed-off-by: Simon Glass --- tools/binman/binman.rst | 4 1 file changed, 4 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH v2 01/11] doc: Build documentation in parallel

2022-08-26 Thread Simon Glass
+Heinrich Schuchardt On Sat, 13 Aug 2022 at 11:41, Simon Glass wrote: > > With the addition of the revision stats this now takes over a minute. Use > a parallel build to reduce it a bit (24 seconds for me). > > Series-changes; 2 > - Use '-j auto' instead > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH 1/2] patman: Fix version table

2022-08-26 Thread Simon Glass
One of the changes to the version table was made by mistake. Fix it. Signed-off-by: Simon Glass --- tools/patman/patman.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH 2/2] patman: Tidy up unnecessary blank lines and numbers

2022-08-26 Thread Simon Glass
Quite a few blank lines are not needed here. Drop these and use the # mechanism to number paragraphs. Signed-off-by: Simon Glass --- tools/patman/patman.rst | 45 ++--- 1 file changed, 15 insertions(+), 30 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 2/2] binman: Document how to handle dependent images

2022-08-26 Thread Simon Glass
Binman does not support this properly at present. Add documentation about it including a work-around. Signed-off-by: Simon Glass --- tools/binman/binman.rst | 50 + 1 file changed, 50 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH] dm: core: fix a typo in help text

2022-08-26 Thread Simon Glass
On Sun, 21 Aug 2022 at 07:45, Sergei Antonov wrote: > > Signed-off-by: Sergei Antonov > --- > cmd/dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass (but please always add a commit message) > Applied to u-boot-dm, thanks!

Re: [PATCH 1/1] boot: simplify bootmeth_vbe_simple_ft_fixup()

2022-08-26 Thread Simon Glass
On Tue, 23 Aug 2022 at 02:32, Heinrich Schuchardt wrote: > > Don't assign a value to a variable if it is not used afterwards. > Move variables to the code fragment where they are used. > > Addresses-Coverity: CID 356243 ("Code maintainability issues (UNUSED_VALUE)") > Signed-off-by: Heinrich

Re: [PATCH 1/1] boot: fix vbe_find_first_device()

2022-08-26 Thread Simon Glass
On Tue, 23 Aug 2022 at 02:25, Heinrich Schuchardt wrote: > > uclass_find_first_device() may return NULL if no device for the uclass > exists. Handle this case gracefully. > > Addresses-Coverity: CID 356244 ("Null pointer dereferences (FORWARD_NULL)") > Signed-off-by: Heinrich Schuchardt > --- >

Re: [PATCH] vbe: Enable command only with BOOTSTD_FULL

2022-08-26 Thread Simon Glass
On Tue, 23 Aug 2022 at 20:14, Simon Glass wrote: > > Avoid enabling this command by default. This saves about 1KB of code > space. > > Signed-off-by: Simon Glass > --- > > cmd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to u-boot-dm, thanks!

Re: Question about uboot initialisation

2022-08-26 Thread Simon Glass
Hi Aubin, On Fri, 26 Aug 2022 at 06:41, momo aubin wrote: > > Dear all, > > > Is there any way that allows us to know that uboot has initialised all his > peripherals before starting loading kernel ? > > The goal of this check is to reset the board in case of bad initialisation > and choose a

Re: [PATCH 4/4] arm: dts: chameleonv3: Add 270-2 variant

2022-08-26 Thread Simon Glass
Hi Paweł, On Fri, 26 Aug 2022 at 01:54, Paweł Anikiel wrote: > > Add devicetree for chameleonv3 with the 270-2I2-D11E variant of the > Mercury+ AA1 module > > Signed-off-by: Paweł Anikiel > --- > arch/arm/dts/Makefile| 1 + >

Re: [PATCH] corenet_ds.h: Remove

2022-08-26 Thread Simon Glass
On Fri, 26 Aug 2022 at 08:53, Tom Rini wrote: > > This was missed when removing the platform. > > Signed-off-by: Tom Rini > --- > include/configs/corenet_ds.h | 369 --- > 1 file changed, 369 deletions(-) > delete mode 100644 include/configs/corenet_ds.h >

Re: [PATCH v5 1/8] binman: add support for skipping file concatenation for mkimage

2022-08-26 Thread Simon Glass
Hi Quentin, On Fri, 26 Aug 2022 at 09:37, Quentin Schulz wrote: > > From: Quentin Schulz > > Some image types handled by mkimage require the datafiles to be passed > independently (-d data1:data2) for specific handling of each. A > concatenation of datafiles prior to passing them to mkimage

Re: [PATCH v2] image-fit: don't set compression if it can't be read

2022-08-26 Thread Simon Glass
Hi Daniel, On Fri, 26 Aug 2022 at 15:28, Daniel Golle wrote: > > fit_image_get_comp() should not set value -1 in case it can't read > the compression node. Instead, leave the value untouched in that case > as it can be absent and a default value previously defined by the > caller of

Re: [PATCH v9 08/15] event: Add an event for main_loop

2022-08-26 Thread Simon Glass
On Fri, 26 Aug 2022 at 03:58, Sughosh Ganu wrote: > > Add an event type EVT_MAIN_LOOP that can be used for registering > events that need to be run after the platform has been initialised and > before the main_loop function is called. > > Signed-off-by: Sughosh Ganu > --- > Changes since V8: New

Re: [PATCH v5 8/8] rockchip: add u-boot-rockchip-spi.bin image for booting from SPI-NOR flash

2022-08-26 Thread Simon Glass
On Fri, 26 Aug 2022 at 09:37, Quentin Schulz wrote: > > From: Quentin Schulz > > This new image is similar to u-boot-rockchip.bin except that it's > destined to be flashed on SPI-NOR flashes. > > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz > --- > > v3: > - added filename property so

Re: [PATCH v5 2/8] binman: allow user-defined filenames for mkimage entry

2022-08-26 Thread Simon Glass
On Fri, 26 Aug 2022 at 09:37, Quentin Schulz wrote: > > From: Quentin Schulz > > mkimage entry currently creates a file whose name is derived from the > section name containing said entry. > > Let's allow the user to define a filename for the mkimage-generated > binary by using the 'filename' DT

Re: [PATCH v5 6/8] rockchip: simplify binman image dependencies addition to INPUTS

2022-08-26 Thread Simon Glass
On Fri, 26 Aug 2022 at 09:37, Quentin Schulz wrote: > > From: Quentin Schulz > > By factoring SPL check in the first condition, this makes the checks a > bit less convoluted and more readable. > > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz > --- > > v4: > - fixed wrong place for endif

Re: [PATCH v5 7/8] rockchip: allow to build SPI images even without HAS_ROM option

2022-08-26 Thread Simon Glass
On Fri, 26 Aug 2022 at 09:37, Quentin Schulz wrote: > > From: Quentin Schulz > > This prepares for the creation of a u-boot-rockchip-spi.bin image > similar to u-boot-rockchip.bin to the exception it's destined for > SPI-NOR flashes instead of MMC storage medium. > > Cc: Quentin Schulz >

Re: [PATCH 1/2] Revert "i2c: fix stack buffer overflow vulnerability in i2c md command"

2022-08-26 Thread Simon Glass
On Fri, 26 Aug 2022 at 15:16, Marek Vasut wrote: > > This reverts commit 8f8c04bf1ebbd2f72f1643e7ad9617dafa6e5409. > > The commit is largely wrong and breaks most of i2c command functionality. > The problem described in the aforementioned commit commit message is valid, > however the commit

Re: [PATCH v5 3/8] rockchip: remove binman temporary files when cleaning

2022-08-26 Thread Simon Glass
On Fri, 26 Aug 2022 at 09:37, Quentin Schulz wrote: > > From: Quentin Schulz > > Binman mkimage entry generates temporary files so let's remove them > when calling `make clean`. > > Fixes: 9b312e26fc77 ("rockchip: Enable building a SPI ROM image on jerry") > Cc: Quentin Schulz > Reported-by:

Re: [RFC PATCH] Rename disto_[pxe_]getfile to distro_[pxe_]getfile

2022-08-26 Thread Simon Glass
On Fri, 26 Aug 2022 at 07:15, Dario Binacchi wrote: > > Replace 'disto' with 'distro' since they are all functions about distro > booting. > > Signed-off-by: Dario Binacchi > > --- > > boot/bootmeth_distro.c | 6 +++--- > boot/bootmeth_pxe.c | 6 +++--- > doc/develop/bootstd.rst | 2 +- >

Re: [PATCH] usb: Add delay for control messages to reach usb stick

2022-08-26 Thread Simon Glass
Hi, On Fri, 26 Aug 2022 at 13:37, Janne Grunau wrote: > > Hej, > > On 2022-08-25 23:35:33 -0600, Ashok Reddy Soma wrote: > > We are seeing timing issues with transcend usb sticks. These devices > > seems to require more time than regular devices for the control messages > > to reach device. Add

Re: [RFC PATCH] clk: fix clk_get_rate() always return ulong

2022-08-26 Thread Simon Glass
Hi, On Fri, 26 Aug 2022 at 08:00, Sean Anderson wrote: > > On 8/26/22 6:31 AM, Julien Masson wrote: > > According to clk_ops struct definition, the callback `get_rate()` > > return current clock rate value as ulong. > > `clk_get_rate()` should handle the clock rate returned as ulong also. > > >

Re: [PATCH 2/2] i2c: fix stack buffer overflow vulnerability in i2c md command

2022-08-26 Thread Tim Harvey
On Fri, Aug 26, 2022 at 3:21 PM Tim Harvey wrote: > > On Fri, Aug 26, 2022 at 2:16 PM Marek Vasut wrote: > > > > This reinstates fix from commit 8f8c04bf1ebbd2f72f1643e7ad9617dafa6e5409 > > without the changes unrelated to the actual fix. Avoid the underflow by > > setting only nbytes and

Re: [PATCH 2/2] i2c: fix stack buffer overflow vulnerability in i2c md command

2022-08-26 Thread Tim Harvey
On Fri, Aug 26, 2022 at 2:16 PM Marek Vasut wrote: > > This reinstates fix from commit 8f8c04bf1ebbd2f72f1643e7ad9617dafa6e5409 > without the changes unrelated to the actual fix. Avoid the underflow by > setting only nbytes and linebytes as unsigned integers. > > Signed-off-by: Marek Vasut > Cc:

[PATCH v2] image-fit: don't set compression if it can't be read

2022-08-26 Thread Daniel Golle
fit_image_get_comp() should not set value -1 in case it can't read the compression node. Instead, leave the value untouched in that case as it can be absent and a default value previously defined by the caller of fit_image_get_comp() should be used. As a result the warning message WARNING:

[PATCH] ARM: imx: Enable SPL GPIO hog on i.MX8M Plus DHCOM

2022-08-26 Thread Marek Vasut
Enable GPIO hog support in SPL to match the GPIO hog support in U-Boot proper. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: uboot-imx --- configs/imx8mp_dhcom_pdk2_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 2/2] i2c: fix stack buffer overflow vulnerability in i2c md command

2022-08-26 Thread Marek Vasut
This reinstates fix from commit 8f8c04bf1ebbd2f72f1643e7ad9617dafa6e5409 without the changes unrelated to the actual fix. Avoid the underflow by setting only nbytes and linebytes as unsigned integers. Signed-off-by: Marek Vasut Cc: Heiko Schocher Cc: Nicolas Iooss Cc: Simon Glass Cc: Tim

[PATCH 1/2] Revert "i2c: fix stack buffer overflow vulnerability in i2c md command"

2022-08-26 Thread Marek Vasut
This reverts commit 8f8c04bf1ebbd2f72f1643e7ad9617dafa6e5409. The commit is largely wrong and breaks most of i2c command functionality. The problem described in the aforementioned commit commit message is valid, however the commit itself does many more changes unrelated to fixing that one problem

Re: [PATCH] image-fit: don't set compression if it can't be read

2022-08-26 Thread Tom Rini
On Mon, Aug 15, 2022 at 12:38:27PM +0200, Daniel Golle wrote: > fit_image_get_comp() should not set value -1 in case it can't read > the compression node. Instead, leave the value untouched in that case > as it can be absent and a default value previously defined by the > caller of

Re: [PATCH] Makefile: Use relative paths for debugging symbols.

2022-08-26 Thread Tom Rini
On Thu, Aug 18, 2022 at 10:31:34AM -0700, Vagrant Cascadian wrote: > From: Vagrant Cascadian > > The KBUILD_CFLAGS and KBUILD_AFLAGS variables are adjusted to use > -ffile-prefix-map and --debug-prefix-map, respectively, to use > relative paths for occurrences of __FILE__ and debug paths. > >

Re: [PATCH] usb: Add delay for control messages to reach usb stick

2022-08-26 Thread Janne Grunau
Hej, On 2022-08-25 23:35:33 -0600, Ashok Reddy Soma wrote: > We are seeing timing issues with transcend usb sticks. These devices > seems to require more time than regular devices for the control messages > to reach device. Add 1ms delay before sending control message to fix > trancend device

Re: [PATCH 13/13] qcs404evb_defconfig: Enable USB configs

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:21PM +0530, Sumit Garg wrote: > Enable USB config options along with its dependencies like PHY, RESET, > PMIC GPIO etc. config options. > > Signed-off-by: Sumit Garg Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] arm: total_compute: enable psci

2022-08-26 Thread Tom Rini
On Tue, Aug 09, 2022 at 03:56:52PM +0530, Davidson K wrote: > psci is used for system reset > > Signed-off-by: Davidson K Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 12/13] board: qcs404-evb: Enable USB3 specific PMIC GPIO

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:20PM +0530, Sumit Garg wrote: > For USB3 host controller to detect devices on the bus it is required to > enable a PMIC GPIO: usb_vbus_boost_pin. So enable that during board > specific initialization. > > And since this PMIC GPIO parsing is quite u-boot specific, so

Re: [PATCH 11/13] dts: qcs404-evb: Add PMIC GPIO controller node

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:19PM +0530, Sumit Garg wrote: > PMIC GPIOs are special GPIOs which are accessible through SPMI bus. So > add corresponding DT nodes. > > Signed-off-by: Sumit Garg Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 10/13] gpio: qcom_pmic: Add support for GPIO LV/MV subtype

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:18PM +0530, Sumit Garg wrote: > GPIO LV (low voltage)/MV (medium voltage) subtypes have different > features and register mappings than 4CH/8CH subtypes. Add support > for LV and MV subtypes. > > With GPIO LV/MV subtype available, add "qcom,pms405-gpio" compatible >

Re: [PATCH 09/13] pmic: Convert pm8916 driver to a generic Qcom PMIC driver

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:17PM +0530, Sumit Garg wrote: > Since both pm8916.c and pm8916_gpio.c are already supporting multiple > Qcom SoCs, it makes sense to rename these drivers to pmic_qcom.c and > qcom_pmic_gpio.c respectively. Also, these driver can be extended to > support additional

Re: [PATCH 08/13] dts: qcs404-evb: Add USB controller and PHY nodes

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:16PM +0530, Sumit Garg wrote: > QCS404 SoC provides support for two USB controllers: one USB3 and the > other one being USB2. The USB3 controller supports further 2 PHY: one high > speed PHY and the other super speed PHY. The USB2 controller supports a > single high

Re: [PATCH 07/13] clocks: qcs404: Add support for USB clocks

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:15PM +0530, Sumit Garg wrote: > Add support for USB controller and PHY clocks for QCS404 SoC. > > Signed-off-by: Sumit Garg Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 06/13] clocks: qcom: Add clock enable callback support

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:14PM +0530, Sumit Garg wrote: > Drivers like USB, ethernet etc. uses ".enable" hook to enable clocks. > So add corresponding support for Qcom clock drivers. > > Signed-off-by: Sumit Garg Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 05/13] dts: qcs404-evb: Add reset controller node

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:13PM +0530, Sumit Garg wrote: > Signed-off-by: Sumit Garg Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 04/13] reset: qcom: Add support for QCS404 SoC reset table

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:12PM +0530, Sumit Garg wrote: > Signed-off-by: Sumit Garg Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 03/13] reset: Convert ipq4019 driver to a generic Qcom driver

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:11PM +0530, Sumit Garg wrote: > Since the base functionality remains the same for a reset driver on Qcom > SoCs, so leverage that to convert ipq4019 specific reset driver to a > generic Qcom reset driver. With that one just need to provide SoC specific > reset table.

Re: [PATCH 02/13] phy: Add support for drivers to enable USB on QCS404 SoC

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:10PM +0530, Sumit Garg wrote: > QCS404 SoC supports two types of PHY, one supports high speed mode or > USB2 PHY and the other supports super speed mode or USB3 PHY. So add > corresponding PHY drivers. > > Signed-off-by: Sumit Garg Applied to u-boot/next, thanks!

Re: [PATCH 01/13] phy: Move qcom SoCs specific phy drivers to qcom folder

2022-08-26 Thread Tom Rini
On Thu, Aug 04, 2022 at 07:57:09PM +0530, Sumit Garg wrote: > Signed-off-by: Sumit Garg Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] configs: j721s2_evm_a72_defconfig: fix the bootcmd

2022-08-26 Thread Tom Rini
On Tue, Aug 02, 2022 at 06:38:14PM +0530, Jayesh Choudhary wrote: > Remove the main_cpsw0_qsgmii_phyinit variable from the boot > command as there is no ethernet firmware in j721s2. > > Fixes: 8886341aa670 ('configs: j721s2_evm_a72_defconfig: Add A72 specific > defconfig') > Signed-off-by:

Re: [PATCH v2 2/2] arm: dts: qcom: Sync pinctrl DT nodes with Linux bindings

2022-08-26 Thread Tom Rini
On Wed, Jul 27, 2022 at 01:52:04PM +0530, Sumit Garg wrote: > Currently for all Qcom SoCs/boards there are separate compatibles for > GPIO and pinctrl. But this is inconsistent with official (upstream) Linux > bindings which requires only a single compatible "qcom,-pinctrl" > and there is no such

Re: [PATCH v2 1/2] pinctrl: sdm845: Remove redundant CONFIG_SDM845 check

2022-08-26 Thread Tom Rini
On Wed, Jul 27, 2022 at 01:52:03PM +0530, Sumit Garg wrote: > DT compatible is sufficient to make platform specific differentiation, > so remove redundant CONFIG_SDM845 check. > > Signed-off-by: Sumit Garg > Reviewed-by: Ramon Fried Applied to u-boot/next, thanks! -- Tom signature.asc

Re: [PATCH 4/4] firmware: ti_sci: Move ACK checking to ti_sci_do_xfer() function

2022-08-26 Thread Tom Rini
On Mon, Jul 25, 2022 at 08:25:06PM -0500, Andrew Davis wrote: > We can check if the message was acknowledged in the common > ti_sci_do_xfer() which lets us remove it from after each call to this > function. This simplifies the code and reduces binary size. > > Signed-off-by: Andrew Davis

Re: [PATCH 3/4] firmware: ti_sci: Remove inline keyword from functions

2022-08-26 Thread Tom Rini
On Mon, Jul 25, 2022 at 08:25:05PM -0500, Andrew Davis wrote: > The inline hint is not needed here, the compiler will do the right thing > based on if we are compiling for speed or for code size. In this case the > inline causes this function to be placed inside each callsite which is > not the

Re: [PATCH 2/4] firmware: ti_sci: Factor out message alloc failed message

2022-08-26 Thread Tom Rini
On Mon, Jul 25, 2022 at 08:25:04PM -0500, Andrew Davis wrote: > We don't need to print the same message in every location, just > print it in the function that fails and remove all the extra > message printouts. > > Signed-off-by: Andrew Davis Applied to u-boot/next, thanks! -- Tom

Re: [PATCH 1/4] firmware: ti_sci: Reduce output on ti_sci_do_xfer error

2022-08-26 Thread Tom Rini
On Mon, Jul 25, 2022 at 08:25:03PM -0500, Andrew Davis wrote: > This ti_sci_do_xfer() function already prints out the reason for the > failure, and the caller of each of these functions should also notify > the user of the failed task. Remove this extra level of error message. > > Signed-off-by:

[PATCH v2 6/8] imx8mp: synchronise device tree with linux

2022-08-26 Thread Marcel Ziswiler
From: Marcel Ziswiler Synchronise device tree with linux v6.0-rc1. Signed-off-by: Marcel Ziswiler --- (no changes since v1) arch/arm/dts/imx8mp-dhcom-pdk2.dts | 27 +++-- arch/arm/dts/imx8mp-dhcom-som.dtsi | 20 +--- arch/arm/dts/imx8mp-evk.dts | 126

[PATCH v2 8/8] imx8mm: synchronise device tree with linux

2022-08-26 Thread Marcel Ziswiler
From: Marcel Ziswiler Synchronise device tree with linux v6.0-rc1. Signed-off-by: Marcel Ziswiler --- (no changes since v1) arch/arm/dts/imx8mm-beacon-baseboard.dtsi | 4 +- arch/arm/dts/imx8mm-evk.dtsi | 43 +++ arch/arm/dts/imx8mm-icore-mx8mm.dtsi | 12

[PATCH v2 7/8] imx8mn: synchronise device tree with linux

2022-08-26 Thread Marcel Ziswiler
From: Marcel Ziswiler Synchronise device tree with linux v6.0-rc1. Signed-off-by: Marcel Ziswiler --- (no changes since v1) arch/arm/dts/imx8mn-beacon-baseboard.dtsi | 4 +- arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi| 2 +- .../dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi | 2 +-

[PATCH v2 4/8] imx8ulp: synchronise device tree with linux

2022-08-26 Thread Marcel Ziswiler
From: Marcel Ziswiler Synchronise device tree with linux v6.0-rc1. Signed-off-by: Marcel Ziswiler --- Changes in v2: - imx8ulp: Re-added s400_mu device tree node. arch/arm/dts/imx8ulp-evk-u-boot.dtsi | 15 +- arch/arm/dts/imx8ulp-evk.dts | 191 +-

[PATCH v2 0/8] arm: dts: imx: sync device trees with upstream linux kernel part 1

2022-08-26 Thread Marcel Ziswiler
From: Marcel Ziswiler This series synchronises them imx device trees with the upstream Linux kernel (v6.0-rc1). I split it into two parts. This is part 1. It also fixes a few issues as discussed during/after the pre-mature application of my first series [1]. I am not touching kontron-sl-mx6ul

[PATCH v2 3/8] imxrt1050: synchronise device tree with linux

2022-08-26 Thread Marcel Ziswiler
From: Marcel Ziswiler Synchronise device tree with linux v6.0-rc1. Signed-off-by: Marcel Ziswiler --- Changes in v2: - imxrt1050: Re-added DDR timings aka semc node as pointed out by Fabio. Thanks! arch/arm/dts/imxrt1050-evk-u-boot.dtsi | 155 ++--

[PATCH v2 5/8] imx8mq: synchronise device tree with linux

2022-08-26 Thread Marcel Ziswiler
From: Marcel Ziswiler Synchronise device tree with linux v6.0-rc1. Signed-off-by: Marcel Ziswiler --- (no changes since v1) arch/arm/dts/imx8mq-evk.dts | 43 + arch/arm/dts/imx8mq-u-boot.dtsi | 10 ++-- arch/arm/dts/imx8mq.dtsi | 15

[PATCH v2 2/8] imxrt1020: fix lpuart issue in common u-boot device tree

2022-08-26 Thread Marcel Ziswiler
From: Marcel Ziswiler Fix lpuart issue in common U-Boot device tree. Signed-off-by: Marcel Ziswiler --- (no changes since v1) arch/arm/dts/imxrt1020-evk-u-boot.dtsi | 7 --- arch/arm/dts/imxrt1020-evk.dts | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 1/8] vf610: synchronise device tree with linux

2022-08-26 Thread Marcel Ziswiler
From: Marcel Ziswiler Synchronise device tree with linux v6.0-rc1 plus the recent DDR pinmux addition still being in-flight. Signed-off-by: Marcel Ziswiler --- (no changes since v1) arch/arm/dts/vf610-pinfunc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC PATCH v1 3/9] clk: renesas: add R906G032 driver

2022-08-26 Thread Ralph Siemsen
On Tue, Aug 23, 2022 at 12:14:31AM -0400, Sean Anderson wrote: Regarding the unused fields (scon, mirack, mistat): I am not really sure what their purpose is. Maybe there is some value in having them. I'll try to find out more information about them. If we do decide to drop them, I would like

[PATCH v5 8/8] rockchip: add u-boot-rockchip-spi.bin image for booting from SPI-NOR flash

2022-08-26 Thread Quentin Schulz
From: Quentin Schulz This new image is similar to u-boot-rockchip.bin except that it's destined to be flashed on SPI-NOR flashes. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- v3: - added filename property so that idblaoder-spi.img binary is generated by binman, as per community

[PATCH v5 7/8] rockchip: allow to build SPI images even without HAS_ROM option

2022-08-26 Thread Quentin Schulz
From: Quentin Schulz This prepares for the creation of a u-boot-rockchip-spi.bin image similar to u-boot-rockchip.bin to the exception it's destined for SPI-NOR flashes instead of MMC storage medium. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- arch/arm/dts/rk3288-u-boot.dtsi | 2 +-

[PATCH v5 6/8] rockchip: simplify binman image dependencies addition to INPUTS

2022-08-26 Thread Quentin Schulz
From: Quentin Schulz By factoring SPL check in the first condition, this makes the checks a bit less convoluted and more readable. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- v4: - fixed wrong place for endif for ARM32 boards, Makefile | 9 ++--- 1 file changed, 2

[PATCH v5 5/8] rockchip: generate u-boot-rockchip.bin with binman for ARM64 boards

2022-08-26 Thread Quentin Schulz
From: Quentin Schulz This allows to build u-boot-rockchip.bin binary with binman for Rockchip ARM64 boards instead of the legacy Makefile way. Cc: Quentin Schulz Reviewed-by: Simon Glass Signed-off-by: Quentin Schulz --- v4: - added Reviewed-by, Makefile | 26

[PATCH v5 4/8] rockchip: generate idbloader.img content for u-boot-rockchip.bin with binman for ARM

2022-08-26 Thread Quentin Schulz
From: Quentin Schulz idbloader.img content - currently created by way of Makefile - can be created by binman directly. So let's do that for Rockchip ARM platforms. Cc: Quentin Schulz Reviewed-by: Simon Glass Signed-off-by: Quentin Schulz --- v4: - added Reviewed-by, v3: - moved spl back

[PATCH v5 3/8] rockchip: remove binman temporary files when cleaning

2022-08-26 Thread Quentin Schulz
From: Quentin Schulz Binman mkimage entry generates temporary files so let's remove them when calling `make clean`. Fixes: 9b312e26fc77 ("rockchip: Enable building a SPI ROM image on jerry") Cc: Quentin Schulz Reported-by: Johan Jonker Signed-off-by: Quentin Schulz --- added in v3

[PATCH v5 2/8] binman: allow user-defined filenames for mkimage entry

2022-08-26 Thread Quentin Schulz
From: Quentin Schulz mkimage entry currently creates a file whose name is derived from the section name containing said entry. Let's allow the user to define a filename for the mkimage-generated binary by using the 'filename' DT property. Cc: Quentin Schulz Signed-off-by: Quentin Schulz ---

[PATCH v5 1/8] binman: add support for skipping file concatenation for mkimage

2022-08-26 Thread Quentin Schulz
From: Quentin Schulz Some image types handled by mkimage require the datafiles to be passed independently (-d data1:data2) for specific handling of each. A concatenation of datafiles prior to passing them to mkimage wouldn't work. That is the case for rkspi for example which requires page

[PATCH v5 0/8] migrate u-boot-rockchip.bin to binman and generate an image for SPI

2022-08-26 Thread Quentin Schulz
From: Quentin Schulz This migrates the generation of u-boot-rockchip.bin from Makefile to binman completely. This also adds support for generating the same kind of image than u-boot-rockchip.bin but for SPI flashes (specifically, a different image type generated by mkimage is necessary, in

Re: [PATCH] distroboot: ubifs: Add support for specifying UBI header offset

2022-08-26 Thread Tom Rini
On Thu, Aug 25, 2022 at 03:52:20PM +0200, Pali Rohár wrote: > On Monday 08 August 2022 12:10:27 Tom Rini wrote: > > On Sun, Aug 07, 2022 at 09:04:22PM +0200, Pali Rohár wrote: > > > > > Some UBI partitions may use non-standard UBI header offset. For attaching > > > these UBI partitions it is

Re: [RFC PATCH v2 9/9] tools: spkgimage: add Renesas SPKG format

2022-08-26 Thread Ralph Siemsen
On Mon, Aug 22, 2022 at 11:42:54PM -0400, Sean Anderson wrote: +static int spkgimage_check_image_types(uint8_t type) +{ + return type == IH_TYPE_RENESAS_SPKG ? 0 : 1; This function is not necessary if you only support one type. Without this function, mkimage kept telling me that my

Re: [U-Boot] [PATCH 00/10] Add pruss and pru support for am33xx and am57xx

2022-08-26 Thread Tom Rini
On Wed, Jul 27, 2022 at 03:27:47PM -0400, Greg Leonberg wrote: > This series adds support for the pruss/pru_rproc drivers on am33xx and > am57xx SoCs. > > All PRU interfaces pru0 and pru1 are supported on am33xx. > All PRU interfaces pru0, pru1, pru2, and pru3 are supported on am57xx. > >

Re: Broken commit de47ff536363289f92f85ed1e4901724d238432d

2022-08-26 Thread Tom Rini
On Wed, Aug 17, 2022 at 11:29:08AM +0200, Pali Rohár wrote: > On Monday 08 August 2022 09:37:22 Tom Rini wrote: > > On Mon, Aug 08, 2022 at 09:51:49AM +0200, Marek Behún wrote: > > > On Fri, 5 Aug 2022 18:20:19 -0400 > > > Tom Rini wrote: > > > > > > > On Fri, Aug 05, 2022 at 10:17:01PM +0200,

[PATCH] corenet_ds.h: Remove

2022-08-26 Thread Tom Rini
This was missed when removing the platform. Signed-off-by: Tom Rini --- include/configs/corenet_ds.h | 369 --- 1 file changed, 369 deletions(-) delete mode 100644 include/configs/corenet_ds.h diff --git a/include/configs/corenet_ds.h

Re: [PATCH v3 0/8] U-boot: fs: add generic unaligned read offset handling

2022-08-26 Thread Tom Rini
On Mon, Aug 15, 2022 at 07:45:11PM +0800, Qu Wenruo wrote: > [CHANGELOG] > v3: > - Fix an error that we always return 0 actread bytes for unsupported fses > For unsupported fses, we should also populate @total_read. > Or we will just read the data but still return 0 for actually bytes. > >

Re: [PATCH] spl: introduce SPL_XIP to config

2022-08-26 Thread Sean Anderson
On 8/26/22 4:44 AM, Nikita Shubin wrote: From: Nikita Shubin U-Boot and SPL don't necessary share the same location, so we might end with U-Boot SPL in read-only memory (XIP) and U-Boot in read-write memory. In case of non XIP boot mode, we rely on such variables as "hart_lottery" and

Re: [RFC PATCH] clk: fix clk_get_rate() always return ulong

2022-08-26 Thread Sean Anderson
On 8/26/22 6:31 AM, Julien Masson wrote: According to clk_ops struct definition, the callback `get_rate()` return current clock rate value as ulong. `clk_get_rate()` should handle the clock rate returned as ulong also. Otherwise we may have invalid/truncated clock rate value returned by

Re: [PATCH 3/3] exports: Fix export of SPI access functions

2022-08-26 Thread Wolfgang Denk
Dear Paul, In message <20220505153242.1598807-4-paul.bar...@sancloud.com> you wrote: > * With CONFIG_DM_SPI defined, spi_get_bus_and_cs needs to be used > instead of spi_setup_slave to configure a SPI bus. As spi_setup_slave is > already present in the export list it is reasonable to also export

Re: [PATCH 1/3] Licenses: Clarify exceptions for standalone apps

2022-08-26 Thread Wolfgang Denk
Dear Paul Barker, In message <20220505153242.1598807-2-paul.bar...@sancloud.com> you wrote: > On 2010-01-27, an email [1] was sent to the mailing list by Wolfgang > Denk which clarified the intended licensing exceptions for standalone > applications. As the "export.h" header and the "stubs.c"

[RFC PATCH] Rename disto_[pxe_]getfile to distro_[pxe_]getfile

2022-08-26 Thread Dario Binacchi
Replace 'disto' with 'distro' since they are all functions about distro booting. Signed-off-by: Dario Binacchi --- boot/bootmeth_distro.c | 6 +++--- boot/bootmeth_pxe.c | 6 +++--- doc/develop/bootstd.rst | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git

  1   2   >