Re: [PATCH v10 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-09-27 Thread Sughosh Ganu
On Mon, 26 Sept 2022 at 19:37, Jassi Brar wrote: > > On Mon, Sep 26, 2022 at 5:08 AM Sughosh Ganu wrote: > > > > On Mon, 26 Sept 2022 at 08:29, Jassi Brar wrote: > > > . > > > > +static int fwu_boottime_checks(void *ctx, struct event *event) > > > > +{ > > > > + int ret; > > > > +

Re: [PATCH v10 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-09-27 Thread Sughosh Ganu
On Mon, 26 Sept 2022 at 20:12, Jassi Brar wrote: > > On Mon, Sep 26, 2022 at 5:00 AM Sughosh Ganu wrote: > > > > On Mon, 26 Sept 2022 at 08:28, Jassi Brar wrote: > > > > > > > > > > . > > > > +/** > > > > + * fwu_revert_boot_index() - Revert the active index in the FWU > > > > metadata > >

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-27 Thread Sughosh Ganu
On Mon, 26 Sept 2022 at 20:24, Jassi Brar wrote: > > On Mon, Sep 26, 2022 at 4:01 AM Sughosh Ganu wrote: > > On Mon, 26 Sept 2022 at 08:25, Jassi Brar wrote: > > > > . > > > > > > > > +static __maybe_unused efi_status_t fwu_post_update_process(bool > > > > fw_accept_os) > > > > +{ > > > > +

[PATCH] watchdog: gpio_wdt: use __udelay() to avoid recursion

2022-09-27 Thread Rasmus Villemoes
The udelay() function in lib/time.c contains a WATCHDOG_RESET() call. The only reason this doesn't lead to a catastrophic infinite recursion is due to the rate-limiting in wdt-uclass.c: if (time_after_eq(now, priv->next_reset)) { priv->next_reset = now + pri

[PATCH] ARM: zynq: Point via nvmem0 alias to eeprom on zc702/zc706

2022-09-27 Thread Michal Simek
EEPROM stores identification information about board like a board name, revision, serial number and ethernet MAC address. U-Boot is capable to read nvmemX aliases and read/display provided information when nvmem alias link is described. Signed-off-by: Michal Simek --- arch/arm/dts/zynq-zc702.dt

[PATCH] xilinx: zynq: Enable early eeprom decoding

2022-09-27 Thread Michal Simek
Xilinx Zynq evaluation boards have factory program content in eeprom. Enable reading and decoding eeprom content to get information about board name, revision and especially getting ethernet mac address. Signed-off-by: Michal Simek --- board/xilinx/zynq/board.c | 3 +++ 1 file changed, 3 insert

Re: [PATCH] watchdog: gpio_wdt: use __udelay() to avoid recursion

2022-09-27 Thread Stefan Roese
Hi Rasmus, (add Pali to Cc) On 27.09.22 09:45, Rasmus Villemoes wrote: The udelay() function in lib/time.c contains a WATCHDOG_RESET() call. The only reason this doesn't lead to a catastrophic infinite recursion is due to the rate-limiting in wdt-uclass.c: if (time_after_eq(now

[PATCH] fdt_support: cosmetic: remove fdt_fixup_nor_flash_size prototype

2022-09-27 Thread Patrick Delaunay
Remove prototype for the removed function fdt_fixup_nor_flash_size. This patch has no impact as the function is never used. Fixes: 98f705c9cefd ("powerpc: remove 4xx support") Signed-off-by: Patrick Delaunay --- include/fdt_support.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/

Re: [PATCH] configs: increase SYS_MALLOC_F_LEN for STM32 MCU's board

2022-09-27 Thread Patrick DELAUNAY
Hi, On 9/26/22 17:59, Patrice Chotard wrote: Some STM32 MCU's board need their SYS_MALLOC_F_LEN value enlarged to avoid the "alloc space exhausted" error message during their boot process. Use the default SYS_MALLOC_F_LEN value which is set to 0x2000 in Kconfig. Signed-off-by: Patrice Chotard

[PATCH v1 0/2] Add support for Nuvoton NPCM845 BMC

2022-09-27 Thread Jim Liu
The Nuvoton Arbel NPCM8XX SoC is a fourth-generation BMC. The NPCM8XX computing subsystem comprises a quadcore ARM Cortex A35 ARM-V8 architecture. Some of the Arbel NPCM8XX peripherals are based on Poleg NPCM7XX. This patchset was tested on the Arbel NPCM8XX evaluation board. And DTS is base on

[PATCH v1 2/2] clk: nuvoton: Add support for NPCM845

2022-09-27 Thread Jim Liu
Add clock controller driver for NPCM845 Signed-off-by: Jim Liu --- drivers/clk/nuvoton/Makefile | 1 + drivers/clk/nuvoton/clk_npcm8xx.c | 98 +++ 2 files changed, 99 insertions(+) create mode 100644 drivers/clk/nuvoton/clk_npcm8xx.c diff --git a/drivers/clk/n

[PATCH v1 1/2] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

2022-09-27 Thread Jim Liu
Add basic support for the Nuvoton NPCM845 EVB (Arbel). Signed-off-by: Jim Liu --- arch/arm/dts/Makefile | 1 + arch/arm/dts/nuvoton-common-npcm8xx.dtsi | 170 ++ arch/arm/dts/nuvoton-npcm845-evb.dts | 30 arch/arm/dts/nuvoton-npcm845.

[PATCH] apalis/colibri_imx6/-imx6ull/_imx7: update env memory layout

2022-09-27 Thread Marcel Ziswiler
From: Marcel Ziswiler Update the distro config env memory layout for the Apalis iMX6, Colibri iMX6, Colibri iMX6ULL and Colibri iMX7: - loadaddr=0x8420 allows for 64MB area for uncompressing (ie FIT images) - fdt_addr_r = loadaddr + 64MB : allows for 64MB kernel - scriptaddr = fdt_addr_r +

[PATCH 1/4] autoboot: make sure watchdog device(s) are handled with keyed autoboot

2022-09-27 Thread Rasmus Villemoes
Currently, AUTOBOOT_KEYED and its variant AUTOBOOT_ENCRYPTION are broken when one has an external always-running watchdog device with a timeout shorter than the configured boot delay (in my case, I have a gpio-wdt one with a timeout of 1 second), because we fail to call WATCHDOG_RESET() in the loop

[PATCH 0/4] handle watchdogs during keyed autoboot

2022-09-27 Thread Rasmus Villemoes
The fix and explanation is in the first patch, which I hope can make it into v2022.10, it should be rather uncontroversial. The second patch may make sense on its own, but is not at all urgent and can be considered a mere suggestion, but it was convenient for making the following two patches less

[PATCH 2/4] watchdog: introduce a u-boot,autostart property

2022-09-27 Thread Rasmus Villemoes
This is a companion to u-boot,noautostart. If one has a single watchdog device that one does want to have auto-started, but several others that one doesn't, the only way currently is to set the CONFIG_WATCHDOG_AUTOSTART and then use the opt-out for the majority. The main motivation for this is to

[PATCH 3/4] sandbox: add SIGALRM-based watchdog device

2022-09-27 Thread Rasmus Villemoes
In order to test that U-Boot actually maintains the watchdog device(s) during long-running busy-loops, such as those where we wait for the user to stop autoboot, we need a watchdog device that actually does something during those loops; we cannot test that behaviour via the DM test framework. So i

[PATCH 4/4] sandbox.dtsi: add a sandbox,alarm-wdt instance

2022-09-27 Thread Rasmus Villemoes
In order to test that we properly handle watchdog(s) during the "wait for the user to interrupt autoboot" phase, we need a watchdog device to be watching us. Signed-off-by: Rasmus Villemoes --- arch/sandbox/dts/sandbox.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/sandbox/d

[PATCH] watchdog: max6370: use __udelay() to avoid recursion

2022-09-27 Thread Pali Rohár
The udelay() function in lib/time.c contains a WATCHDOG_RESET() call. So use __udelay() in max6370_wdt.c to prevent recursion. Fixes: 0a095fc53b15 ("watchdog: Add MAX6370 watchdog timer driver") Signed-off-by: Pali Rohár --- drivers/watchdog/max6370_wdt.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] watchdog: gpio_wdt: use __udelay() to avoid recursion

2022-09-27 Thread Pali Rohár
On Tuesday 27 September 2022 10:00:00 Stefan Roese wrote: > The max6370_wdt.c driver has the same problem AFAICT. Pali, could you > please take a look a this? Done, here is patch: https://patchwork.ozlabs.org/project/uboot/patch/20220927101919.6999-1-p...@kernel.org/

Re: [PATCH] watchdog: max6370: use __udelay() to avoid recursion

2022-09-27 Thread Stefan Roese
On 27.09.22 12:19, Pali Rohár wrote: The udelay() function in lib/time.c contains a WATCHDOG_RESET() call. So use __udelay() in max6370_wdt.c to prevent recursion. Fixes: 0a095fc53b15 ("watchdog: Add MAX6370 watchdog timer driver") Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks,

Re: [PATCH 1/4] autoboot: make sure watchdog device(s) are handled with keyed autoboot

2022-09-27 Thread Stefan Roese
On 27.09.22 11:54, Rasmus Villemoes wrote: Currently, AUTOBOOT_KEYED and its variant AUTOBOOT_ENCRYPTION are broken when one has an external always-running watchdog device with a timeout shorter than the configured boot delay (in my case, I have a gpio-wdt one with a timeout of 1 second), because

Re: [PATCH] fs: btrfs: remove the usage of undeclared fs_mutex variable

2022-09-27 Thread Qu Wenruo
On 2022/9/27 17:55, Pankaj Raghav wrote: This line probably got in by mistake as there is no fs_mutex member in the btrfs_fs_info struct. Signed-off-by: Pankaj Raghav Which branch is the code based on? I don't believe it's upstream, as such compiling error should be exposed very easily.

Re: [PATCH] fs: btrfs: remove the usage of undeclared fs_mutex variable

2022-09-27 Thread Qu Wenruo
On 2022/9/27 18:39, Qu Wenruo wrote: On 2022/9/27 17:55, Pankaj Raghav wrote: This line probably got in by mistake as there is no fs_mutex member in the btrfs_fs_info struct. Signed-off-by: Pankaj Raghav Which branch is the code based on? I don't believe it's upstream, as such compilin

Re: [PATCH] fs: btrfs: remove the usage of undeclared fs_mutex variable

2022-09-27 Thread Qu Wenruo
On 2022/9/27 18:49, Pankaj Raghav wrote: Which branch is the code based on? I actually cloned it from u-boot github master. https://github.com/u-boot/u-boot/blob/f117c54cc83e3c519883edb5a48062644d38c443/fs/btrfs/disk-io.c#L785 I don't believe it's upstream, as such compiling error shoul

[PATCH v3 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-09-27 Thread samuel . obuch
From: Samuel Obuch Use __raw_read* and __raw_write* functions to ensure read/write is passed to the memory-mapped regions, as non-volatile accesses may get optimised out. Signed-off-by: Samuel Obuch --- drivers/net/xilinx_emaclite.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-

[PATCH v3 1/3] net: emaclite: enable for more architectures

2022-09-27 Thread samuel . obuch
From: Samuel Obuch Function ioremap_nocache seems to be defined only for MIPS and Microblaze architectures. Therefore, the function call in the emaclite driver causes this driver to be unusable with other architectures, for example RISC-V. Use ioremap function instead of ioremap_nocache, and inc

[PATCH v3 3/3] net: emaclite: fix handling for IP packets with specific lengths

2022-09-27 Thread samuel . obuch
From: Samuel Obuch The maximum length is capped similarly to the emaclite_send function. Avoid integer underflow for values of ip->ip_len < 30, the minimum length of an IP packet is 21 bytes. Signed-off-by: Samuel Obuch --- drivers/net/xilinx_emaclite.c | 4 +++- 1 file changed, 3 insertions(+

Re: [PATCH] configs: socfpga: Add CONFIG_NET_RANDOM_ETHADDR=y to SOCFPGA defconfig

2022-09-27 Thread Dinh Nguyen
On 9/25/22 09:37, teik.heng.ch...@intel.com wrote: From: Tien Fong Chee Ethernet initialization is only work with properly set MAC addresses. Hence, this config is required to create the random MAC addresses for Ethernet initialization. Signed-off-by: Tien Fong Chee Signed-off-by: Teik Hen

[PATCH] board: altera: c5/a10/a5/stratix10: remove Chin Liang as maintainer

2022-09-27 Thread Dinh Nguyen
Chin Liang is no longer actively maintaining this project. Signed-off-by: Dinh Nguyen --- board/altera/arria10-socdk/MAINTAINERS | 1 - board/altera/arria5-socdk/MAINTAINERS| 1 - board/altera/cyclone5-socdk/MAINTAINERS | 1 - board/altera/stratix10-socdk/MAINTAINERS | 1 - 4 files change

Re: [PATCH v4 1/1] blk: Rename if_type to uclass_id

2022-09-27 Thread Simon Glass
Use the word 'uclass' instead of 'if_type' to complete the conversion. Signed-off-by: Simon Glass --- Changes in v4: - Fix comments from Takahiro Akashi missed on the previous revision Changes in v3: - Drop previously applied patches - Rebase on -next after EFI changes Changes in v2: - Use con

[PATCH] rockchip: rk3399: add ethaddr and serial# init, enable for R4S

2022-09-27 Thread Christian Kohlschütter
Some RK3399 boards, such as newer revisions of NanoPi R4S, do not provide an EEPROM chip containing a globally unique MAC address. Currently, this means that a randomly generated temporary MAC address may be generated each time the device is rebooted, leading to ARP cache issues and other confusin

Re: [PATCH] rockchip: rk3399: add ethaddr and serial# init, enable for R4S

2022-09-27 Thread Christian Kohlschütter
> On 26. Sep 2022, at 13:59, Chen-Yu Tsai wrote: > > On Mon, Sep 26, 2022 at 7:53 PM Christian Kohlschütter > wrote: >> >> Some RK3399 boards, such as newer revisions of NanoPi R4S, do not >> provide an EEPROM chip containing a globally unique MAC address. >> >> Currently, this means that a r

Re: [PATCH] usb: common: Detect USB storage media with "miscellaneous" USB devices

2022-09-27 Thread Christian Kohlschütter
On 26. Sep 2022, at 01:45, Marek Vasut wrote: > > On 9/25/22 16:46, Christian Kohlschütter wrote: >> When detecting USB storage devices, we currently skip everything that is >> not marked as "undefined device class". >> Composite devices such as tinyusb's CDC+MSC identify as "miscellaneous" >> (

[PATCH] fs: btrfs: remove the usage of undeclared fs_mutex variable

2022-09-27 Thread Pankaj Raghav
This line probably got in by mistake as there is no fs_mutex member in the btrfs_fs_info struct. Signed-off-by: Pankaj Raghav --- fs/btrfs/disk-io.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 8043abc1bd..c80f8e8028 100644 --- a/fs/btrfs/dis

Re: [PATCH] fs: btrfs: remove the usage of undeclared fs_mutex variable

2022-09-27 Thread Pankaj Raghav
> Which branch is the code based on? > I actually cloned it from u-boot github master. https://github.com/u-boot/u-boot/blob/f117c54cc83e3c519883edb5a48062644d38c443/fs/btrfs/disk-io.c#L785 > I don't believe it's upstream, as such compiling error should be exposed > very easily. > Actually, I

Re: [PATCH v10 03/15] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-09-27 Thread Etienne Carriere
Hello Sughosh and all, On Mon, 26 Sept 2022 at 10:46, Sughosh Ganu wrote: > > hi Ilias, > > On Thu, 22 Sept 2022 at 14:16, Ilias Apalodimas > wrote: > > > > Hi Sughosh > > > > On Thu, Sep 15, 2022 at 01:44:39PM +0530, Sughosh Ganu wrote: > > > In the FWU Multi Bank Update feature, the informatio

Re: [PATCH v10 07/15] FWU: STM32MP1: Add support to read boot index from backup register

2022-09-27 Thread Etienne Carriere
On Thu, 15 Sept 2022 at 10:15, Sughosh Ganu wrote: > > The FWU Multi Bank Update feature allows the platform to boot the > firmware images from one of the partitions(banks). The first stage > bootloader(fsbl) passes the value of the boot index, i.e. the bank > from which the firmware images were b

Re: [PATCH] configs: increase SYS_MALLOC_F_LEN for STM32 MCU's board

2022-09-27 Thread Patrice CHOTARD
On 9/27/22 10:39, Patrick DELAUNAY wrote: > Hi, > > On 9/26/22 17:59, Patrice Chotard wrote: >> Some STM32 MCU's board need their SYS_MALLOC_F_LEN value enlarged >> to avoid the "alloc space exhausted" error message during their boot >> process. >> Use the default SYS_MALLOC_F_LEN value which i

[PATCH] ARM: zynq: Define rtc alias on zc702/zc706

2022-09-27 Thread Michal Simek
Define rtc alias on zc702/zc706 boards. Signed-off-by: Michal Simek --- arch/arm/dts/zynq-zc702.dts | 3 ++- arch/arm/dts/zynq-zc706.dts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/zynq-zc702.dts b/arch/arm/dts/zynq-zc702.dts index 99ee87bb2453..f04129fd

Re: [PATCH v10 03/15] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-09-27 Thread Ilias Apalodimas
Hey Etiennem [...] > > > > + uint *secondary_mpart) > > > > +{ > > > > + int i, ret; > > > > + u32 mdata_parts; > > > > + efi_guid_t part_type_guid; > > > > + struct disk_partition info; > > > > + const efi_guid_t fwu_mdata_guid = FWU_MDATA_GUID;

[PULL] Pull request for u-boot next / v2022.10 = u-boot-stm32-20220927

2022-09-27 Thread Patrice CHOTARD
Hi Tom, Please pull the STM32 related fixes for u-boot/next, v2022.10: u-boot-stm32-20220927 CI status: https://source.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/13610 Thanks Patrice The following changes since commit ebdd6afa543324648138f780a648b8fb65d488eb: Merge branch 'nex

Re: [PATCH v10 15/15] FWU: doc: Add documentation for the FWU feature

2022-09-27 Thread Etienne Carriere
Hello Sughosh, Thanks for the documentation. See comments on few typos found (with help of my editor) and suggestions. Best regards, Etienne On Thu, 15 Sept 2022 at 10:16, Sughosh Ganu wrote: > > Add documentattion for the FWU Multi Bank Update feature. The document s/documentattion/documenta

Re: [PATCH v1] gpio: adp5585: add gpio driver for ADP5585 I/O Expander Controller

2022-09-27 Thread Fabio Estevam
Hi Alice, On Tue, Sep 6, 2022 at 6:37 AM Alice Guo (OSS) wrote: > > From: Alice Guo Please add a commit log. > Signed-off-by: Alice Guo > --- a/arch/arm/include/asm/arch-imx9/gpio.h > +++ b/arch/arm/include/asm/arch-imx9/gpio.h > @@ -6,6 +6,8 @@ > #ifndef __ASM_ARCH_IMX9_GPIO_H > #define _

Re: [PATCH v2] configs: imx8m: Enable CONFIG_ARMV8_CRYPTO support

2022-09-27 Thread Fabio Estevam
Hi Loic, On Thu, Sep 22, 2022 at 6:19 AM Loic Poulain wrote: > > This enables armv8 crypto extension usage for SHA1/SHA256. > > Which speed up sha1/sha256 operations, about 10x faster with > a imx8mm evk for a 20MiB kernel hash verification (12ms vs 165ms). > > Signed-off-by: Loic Poulain Great

Re: [PATCH] pico-imx7d: add baseboard SD card boot detect

2022-09-27 Thread Fabio Estevam
On Sun, Aug 21, 2022 at 7:31 PM wrote: > > Migrate SD card boot detection from Technexion u-boot for pico-imx7d SoM. > > From ecd4f6ecbec290c63504f7ec3a9b478425235d14 Mon Sep 17 00:00:00 2001 > From: "Benjamin Szőke" > > Date: Sun, 21 Aug 2022 21:08:55 +0200 > Subject: [PATCH] pico-imx7d: add ba

Re: [PATCH 0/4] clk-imx8mm: Reduce SPL binary size

2022-09-27 Thread Michael Nazzareno Trimarchi
Hi Fabio On Mon, Sep 26, 2022 at 6:40 PM Fabio Estevam wrote: > > Reduce the SPL binary size by building some clocks only for the > non-SPL case, such as Ethernet and PWM and by also building ECSPI > and QSPI when their respective drivers are enabled. > > On a imx8mm_evk_defconfig the following S

Re: [PATCH 0/4] clk-imx8mm: Reduce SPL binary size

2022-09-27 Thread Fabio Estevam
Hi Michael, On 27/09/2022 09:24, Michael Nazzareno Trimarchi wrote: Fabio Estevam (4): clk-imx8mm: Only build PWM clocks in non-SPL code clk-imx8mm: Move CLK_ENET_AXI to the non-SPL section I'm not really convinced of those two. I mean with should maybe think about some different approa

Re: [PATCH] watchdog: gpio_wdt: use __udelay() to avoid recursion

2022-09-27 Thread Stefan Roese
On 27.09.22 09:45, Rasmus Villemoes wrote: The udelay() function in lib/time.c contains a WATCHDOG_RESET() call. The only reason this doesn't lead to a catastrophic infinite recursion is due to the rate-limiting in wdt-uclass.c: if (time_after_eq(now, priv->next_reset)) {

Re: [PATCH] watchdog: max6370: use __udelay() to avoid recursion

2022-09-27 Thread Stefan Roese
On 27.09.22 12:19, Pali Rohár wrote: The udelay() function in lib/time.c contains a WATCHDOG_RESET() call. So use __udelay() in max6370_wdt.c to prevent recursion. Fixes: 0a095fc53b15 ("watchdog: Add MAX6370 watchdog timer driver") Signed-off-by: Pali Rohár Applied to u-boot-watchdog/master

Re: [PATCH 1/4] autoboot: make sure watchdog device(s) are handled with keyed autoboot

2022-09-27 Thread Stefan Roese
On 27.09.22 11:54, Rasmus Villemoes wrote: Currently, AUTOBOOT_KEYED and its variant AUTOBOOT_ENCRYPTION are broken when one has an external always-running watchdog device with a timeout shorter than the configured boot delay (in my case, I have a gpio-wdt one with a timeout of 1 second), because

Please pull u-boot-watchdog/master

2022-09-27 Thread Stefan Roese
Hi Tom, please pull the following watchdog related last minute fixes: - autoboot: make sure watchdog device(s) are handled with keyed autoboot (Rasmus) - gpio_wdt: use __udelay() to avoid recursion (Rasmus) - watchdog: max6370: u

Re: [GIT PULL] xilinx patches for v2023.01-rc1 (round 2)

2022-09-27 Thread Tom Rini
On Mon, Sep 26, 2022 at 04:03:28PM +0200, Michal Simek wrote: > Hi Tom, > > please pull the following patches to your tree. It is the second round with > small updates but especially adding new Xilinx SOC. > CI loop doesn't show any issue. > > Thanks, > Michal > > > The following changes since

Re: [PULL] u-boot-riscv/next

2022-09-27 Thread Tom Rini
On Mon, Sep 26, 2022 at 07:39:22AM +, Leo Liang wrote: > Hi Tom, > > The following changes since commit 435596d57f8beedf36b5dc858fe7ba9d6c03334b: > > Merge tag 'u-boot-imx-20220922' of > https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2022-09-22 10:29:29 > -0400) > > are available

Re: [PULL] Pull request for u-boot next / v2022.10 = u-boot-stm32-20220927

2022-09-27 Thread Patrice CHOTARD
Tom Sorry, this PR is not dedicated for v2022.10 as indicated in the subject but for v2023.01. Patrice On 9/27/22 14:00, Patrice CHOTARD wrote: > Hi Tom, > > Please pull the STM32 related fixes for u-boot/next, v2022.10: > u-boot-stm32-20220927 > > CI status: > htt

Re: [PATCH 0/4] clk-imx8mm: Reduce SPL binary size

2022-09-27 Thread Michael Nazzareno Trimarchi
Hi Fabio On Tue, Sep 27, 2022 at 2:29 PM Fabio Estevam wrote: > > Hi Michael, > > On 27/09/2022 09:24, Michael Nazzareno Trimarchi wrote: > > >> Fabio Estevam (4): > >> clk-imx8mm: Only build PWM clocks in non-SPL code > >> clk-imx8mm: Move CLK_ENET_AXI to the non-SPL section > > > > I'm not

Re: [PATCH 0/4] clk-imx8mm: Reduce SPL binary size

2022-09-27 Thread Fabio Estevam
Hi Michael, On Tue, Sep 27, 2022 at 10:38 AM Michael Nazzareno Trimarchi wrote: > When Dario wrote the Ti clock, he was using the dtsi. One idea can be > understand if this approch > cost less in term of space in the SPL Care to submit a patch series with your proposal?

Re: [PATCH 0/4] clk-imx8mm: Reduce SPL binary size

2022-09-27 Thread Michael Nazzareno Trimarchi
Hi Fabio On Tue, Sep 27, 2022 at 3:44 PM Fabio Estevam wrote: > > Hi Michael, > > On Tue, Sep 27, 2022 at 10:38 AM Michael Nazzareno Trimarchi > wrote: > > > When Dario wrote the Ti clock, he was using the dtsi. One idea can be > > understand if this approch > > cost less in term of space in the

Re: [PULL] Pull request for u-boot next / v2022.10 = u-boot-stm32-20220927

2022-09-27 Thread Tom Rini
On Tue, Sep 27, 2022 at 02:00:14PM +0200, Patrice CHOTARD wrote: > Hi Tom, > > Please pull the STM32 related fixes for u-boot/next, v2022.10: > u-boot-stm32-20220927 > > CI status: > https://source.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/13610 > >

[PATCH] imx6: Remove extra quotes in fdtfile environment variable

2022-09-27 Thread Ariel D'Alessandro
After commit 395110284b56 ("nitrogen6x: Populate FDTFILE at build-time for all platforms") iMX.6Q Sabrelite fails to boot due to a bad fdtfile string: Retrieving file: /dtbs/5.18.0-0.deb11.4-armmp/"imx6q-sabrelite".dtb ** File not found /dtbs/5.18.0-0.deb11.4-armmp/"imx6q-sabrelite".dtb ** CO

Re: [PATCH] imx6: Remove extra quotes in fdtfile environment variable

2022-09-27 Thread Fabio Estevam
Hi Ariel, On Tue, Sep 27, 2022 at 11:14 AM Ariel D'Alessandro wrote: > > After commit 395110284b56 ("nitrogen6x: Populate FDTFILE at build-time > for all platforms") iMX.6Q Sabrelite fails to boot due to a bad fdtfile > string: > > Retrieving file: /dtbs/5.18.0-0.deb11.4-armmp/"imx6q-sabrelite"

Re: [PATCH] imx6: Remove extra quotes in fdtfile environment variable

2022-09-27 Thread Ariel D'Alessandro
Hi Fabio, On 9/27/22 11:20, Fabio Estevam wrote: > Hi Ariel, > > On Tue, Sep 27, 2022 at 11:14 AM Ariel D'Alessandro > wrote: >> >> After commit 395110284b56 ("nitrogen6x: Populate FDTFILE at build-time >> for all platforms") iMX.6Q Sabrelite fails to boot due to a bad fdtfile >> string: >> >>

[PATCH v2] nitrogen6x: Remove extra quotes in fdtfile

2022-09-27 Thread Ariel D'Alessandro
After commit 395110284b56 ("nitrogen6x: Populate FDTFILE at build-time for all platforms") iMX.6Q Sabrelite fails to boot due to a bad fdtfile string: Retrieving file: /dtbs/5.18.0-0.deb11.4-armmp/"imx6q-sabrelite".dtb ** File not found /dtbs/5.18.0-0.deb11.4-armmp/"imx6q-sabrelite".dtb ** CO

[PATCH] rk3399: r4s: Derive local MAC address if EEPROM is missing

2022-09-27 Thread Christian Kohlschütter
Some RK3399 boards, such as newer revisions of NanoPi R4S, do not provide an EEPROM chip containing a globally unique MAC address. Currently, this means that a randomly generated temporary MAC address may be generated each time the device is rebooted, leading to ARP cache issues and other confusin

Re: [PATCH] rockchip: rk3399: add ethaddr and serial# init, enable for R4S

2022-09-27 Thread Christian Kohlschütter
> Following up with "[PATCH] rockchip: rk3399: add ethaddr and serial# init, > enable for R4S", which enables these settings in > configs/nanopi-r4s-rk3399_defconfig. > > This doesn't look any different from what you already sent. > > ChenYu Following up with "[PATCH] rk3399: r4s: Derive local

Re: [PATCH] rockchip: rk3399: add ethaddr and serial# init, enable for R4S

2022-09-27 Thread Christian Kohlschütter
Please disregard (duplicate patch) Following up with "[PATCH] rk3399: r4s: Derive local MAC address if EEPROM is missing". Cheers, Christian

[PATCH v2] apalis/colibri_imx6/-imx6ull/_imx7: update env memory layout

2022-09-27 Thread Marcel Ziswiler
From: Marcel Ziswiler Update the distro config env memory layout for the Apalis iMX6, Colibri iMX6, Colibri iMX6ULL and Colibri iMX7: - loadaddr=0x8420 (resp. 0x1420 on them i.MX 6) allows for 64MB area for uncompressing (ie FIT images) - fdt_addr_r = loadaddr + 64MB : allows for 64MB

Re: [PATCH] Makefile: Disable PLATFORM_LIBGCC for LLVM toolchain

2022-09-27 Thread Tom Rini
On Mon, Sep 26, 2022 at 08:47:47PM +, Alistair Delva wrote: > The LLVM toolchain does not have or need libgcc, so do not require > it to exist on the library path. Even if "-print-libgcc-file-name" > returned the empty string, -lgcc would be specified. > > This leaves CONFIG_USE_PRIVATE_LIBGC

Re: [PATCH v10 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-09-27 Thread Jassi Brar
On Tue, Sep 27, 2022 at 2:14 AM Sughosh Ganu wrote: > > On Mon, 26 Sept 2022 at 20:12, Jassi Brar wrote: > > > > On Mon, Sep 26, 2022 at 5:00 AM Sughosh Ganu > > wrote: > > > > > > On Mon, 26 Sept 2022 at 08:28, Jassi Brar > > > wrote: > > > > > > > > > > > > > > . > > > > > +/** > > > >

Re: [PATCH] Makefile: Disable PLATFORM_LIBGCC for LLVM toolchain

2022-09-27 Thread Alistair Delva
Hi Tom, On Tue, Sep 27, 2022 at 8:57 AM Tom Rini wrote: > > On Mon, Sep 26, 2022 at 08:47:47PM +, Alistair Delva wrote: > > > The LLVM toolchain does not have or need libgcc, so do not require > > it to exist on the library path. Even if "-print-libgcc-file-name" > > returned the empty string

Re: [PATCH v2] nitrogen6x: Remove extra quotes in fdtfile

2022-09-27 Thread Troy Kisky
On 9/27/2022 7:24 AM, Ariel D'Alessandro wrote: > After commit 395110284b56 ("nitrogen6x: Populate FDTFILE at build-time > for all platforms") iMX.6Q Sabrelite fails to boot due to a bad fdtfile > string: > > Retrieving file: /dtbs/5.18.0-0.deb11.4-armmp/"imx6q-sabrelite".dtb > ** File not fou

Re: [PATCH] Makefile: Disable PLATFORM_LIBGCC for LLVM toolchain

2022-09-27 Thread Tom Rini
On Tue, Sep 27, 2022 at 09:29:51AM -0700, Alistair Delva wrote: > Hi Tom, > > On Tue, Sep 27, 2022 at 8:57 AM Tom Rini wrote: > > > > On Mon, Sep 26, 2022 at 08:47:47PM +, Alistair Delva wrote: > > > > > The LLVM toolchain does not have or need libgcc, so do not require > > > it to exist on t

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-27 Thread Jassi Brar
On Tue, Sep 27, 2022 at 2:22 AM Sughosh Ganu wrote: > > On Mon, 26 Sept 2022 at 20:24, Jassi Brar wrote: > > > > On Mon, Sep 26, 2022 at 4:01 AM Sughosh Ganu > > wrote: > > > On Mon, 26 Sept 2022 at 08:25, Jassi Brar > > > wrote: > > > > > > . > > > > > > > > > > +static __maybe_unused ef

Re: [PATCH] Makefile: Disable PLATFORM_LIBGCC for LLVM toolchain

2022-09-27 Thread Nick Desaulniers
On Tue, Sep 27, 2022 at 9:30 AM Alistair Delva wrote: > > Hi Tom, > > On Tue, Sep 27, 2022 at 8:57 AM Tom Rini wrote: > > > > On Mon, Sep 26, 2022 at 08:47:47PM +, Alistair Delva wrote: > > > > > The LLVM toolchain does not have or need libgcc, so do not require > > > it to exist on the libra

Re: [PATCH] tools: kwboot: Change KWBOOT_MSG_RSP_TIMEO_AXP to 10ms

2022-09-27 Thread Pali Rohár
On Friday 19 August 2022 10:20:46 Pali Rohár wrote: > On Friday 19 August 2022 09:43:59 Stefan Roese wrote: > > Testing on the theadorable Armada XP platform has shown, thaz using the > > current value of 1000ms as response timeout does not result in reliable > > booting via kwboot. Using 10ms seem

Re: [PATCH] Makefile: Disable PLATFORM_LIBGCC for LLVM toolchain

2022-09-27 Thread Tom Rini
On Tue, Sep 27, 2022 at 12:41:15PM -0400, Tom Rini wrote: > On Tue, Sep 27, 2022 at 09:29:51AM -0700, Alistair Delva wrote: > > Hi Tom, > > > > On Tue, Sep 27, 2022 at 8:57 AM Tom Rini wrote: > > > > > > On Mon, Sep 26, 2022 at 08:47:47PM +, Alistair Delva wrote: > > > > > > > The LLVM toolch

Re: Please pull u-boot-watchdog/master

2022-09-27 Thread Tom Rini
On Tue, Sep 27, 2022 at 02:48:09PM +0200, Stefan Roese wrote: > Hi Tom, > > please pull the following watchdog related last minute fixes: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH] dm: blk: Add probe in blk_first_device/blk_next_device

2022-09-27 Thread Michal Suchanek
The description claims that the device is probed but it isn't. Add the device_probe() call. Also consolidate the iteration into one function. Fixes: 8a5cbc065d ("dm: blk: Use uclass_find_first/next_device() in blk_first/next_device()") Signed-off-by: Michal Suchanek --- Resent separately dri

[PATCH] dm: core: Document return value of device bind functions

2022-09-27 Thread Michal Suchanek
These functions use device_bind_with_driver_data internally, copy the return value description. Signed-off-by: Michal Suchanek --- Resent separately include/dm/lists.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dm/lists.h b/include/dm/lists.h index fc3b4ae585..97236f8fa0 1006

[PATCH] dm: core: Add note about device_probe idempotence

2022-09-27 Thread Michal Suchanek
device_probe returns early when the device is already activated. Add a note to the documentation that it can be used on already activated devices. Signed-off-by: Michal Suchanek --- Resent separately include/dm/device-internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH] dm: pci: Fix doc typo first -> next

2022-09-27 Thread Michal Suchanek
pci_find_first_device description says it can be used for iteration with itself but it should really be with pci_find_next_device Signed-off-by: Michal Suchanek --- Resent separately include/pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/pci.h b/include/pci.h

[PATCH v5 01/15] dm: core: Fix uclass_probe_all to really probe all devices

2022-09-27 Thread Michal Suchanek
uclass_probe_all uses uclass_first_device/uclass_next_device assigning the return value. The interface for getting meaningful error is uclass_first_device_check/uclass_next_device_check, use it. Also do not stop iteration when an error is encountered. Probing all devices includes those that happe

[PATCH v5 02/15] dm: treewide: Do not opencode uclass_probe_all()

2022-09-27 Thread Michal Suchanek
We already have a function for probing all devices of a specific class, use it. Signed-off-by: Michal Suchanek --- drivers/cpu/cpu-uclass.c | 20 drivers/virtio/virtio-uclass.c | 15 +-- test/dm/core.c | 17 +++-- test/test-main.

[PATCH v5 03/15] dm: pci: Fix device PCI iteration

2022-09-27 Thread Michal Suchanek
When there is no PCI bus uclass_first_device will return no bus and no error which will result in pci_find_first_device calling skip_to_next_device with no bus, and the bus is only checked at the end of the while cycle, not the beginning. Also stop dealing with the return value of uclass_first_dev

[PATCH v5 04/15] bootstd: Fix listing boot devices

2022-09-27 Thread Michal Suchanek
bootdev_list() uses uclass_*_device_err() to iterate devices. However, the only value _err adds is returning an error when the device pointer is null, and that's checked anyway. Also there is some intent to report errors, and that's what uclass_*_device_check() is for, use it. Also print the symb

[PATCH v5 06/15] stdio: Fix class iteration in stdio_add_devices()

2022-09-27 Thread Michal Suchanek
There is a complaint in the code that iterates keyboards that we don't have the _check variant of class iterator but we in fact do, use it. In the code that iterates video devices there is an attempt to print errors but the simple iterator does not return a device when there is an error. Use the _

[PATCH v5 05/15] usb: ether: Fix error handling in usb_ether_init

2022-09-27 Thread Michal Suchanek
The code checks the return value from uclass_first_device as well as that the device exists but it passes on the return value which may be zero if there are no gadget devices. Just check that a device was returned and return -ENODEV otherwise. Also remove the dev variable which is not really used

[PATCH v5 09/15] cmd: List all uclass devices regardless of probe error

2022-09-27 Thread Michal Suchanek
There are a few commands that iterate uclass with uclass_first_device/uclass_next_device or the _err variant. Use the _check class iterator variant to get devices that fail to probe as well, and print the status. Signed-off-by: Michal Suchanek --- cmd/adc.c | 22 ++ cm

[PATCH v5 07/15] video: ipuv3: Fix error handling when getting the display

2022-09-27 Thread Michal Suchanek
The code checks that uclass_first_device returned a device but the returned value that is assigned is never used. Use uclass_first_device_err instead, and move the error return outside of the if block. Fixes: f4ec1ae08e ("mxc_ipuv3_fb.c: call display_enable") Signed-off-by: Michal Suchanek --- d

[PATCH v5 11/15] dm: treewide: Use uclass_next_device_err when accessing second device

2022-09-27 Thread Michal Suchanek
There are a couple users of uclass_next_device return value that get the first device by other means and use uclass_next_device assuming the following device in the uclass is related to the first one. Use uclass_next_device_err because the return value from uclass_next_device will be removed in a

[PATCH v5 10/15] dm: treewide: Use uclass_first_device_err when accessing one device

2022-09-27 Thread Michal Suchanek
There is a number of users that use uclass_first_device to access the first and (assumed) only device in uclass. Some check the return value of uclass_first_device and also that a device was returned which is exactly what uclass_first_device_err does. Some are not checking that a device was retur

[PATCH v5 12/15] dm: blk: Do not use uclass_next_device_err

2022-09-27 Thread Michal Suchanek
blk_first_device_err/blk_next_device_err uses uclass_first_device_err/uclass_next_device_err for device iteration. Although the function names superficially match the return value from uclass_first_device_err/uclass_next_device_err is never used meaningfully, and uclass_first_device/uclass_next_de

[PATCH v5 14/15] dm: treewide: Do not use the return value of simple uclass iterator

2022-09-27 Thread Michal Suchanek
uclass_first_device/uclass_next_device return value will be removed, don't use it. With the current implementation bus is equivalent to !ret. It i redundant to check both, ret check can be replaced with bus check, and ret check inside the iteration is dead code. Signed-off-by: Michal Suchanek --

[PATCH v5 08/15] w1: Fix bus counting in w1_get_bus

2022-09-27 Thread Michal Suchanek
Use uclass_first_device_check/uclass_next_device_check to correctly count buses that fail to probe. Fixes: d3e19cf919 ("w1: Add 1-Wire uclass") Signed-off-by: Michal Suchanek --- drivers/w1/w1-uclass.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/driv

[PATCH v5 13/15] dm: core: Switch uclass_*_device_err to use uclass_*_device_check

2022-09-27 Thread Michal Suchanek
The _err variant iterators use the simple iterators without suffix as basis. However, there is no user that uclass_next_device_err for iteration, many users of uclass_first_device_err use it to get the first and (assumed) only device of an uclass, and a couple that use uclass_next_device_err to ge

[PATCH v5 15/15] dm: core: Do not stop uclass iteration on error

2022-09-27 Thread Michal Suchanek
When probing a device fails NULL pointer is returned, and following devices in uclass list cannot be iterated. Skip to next device on error instead. With that the only condition under which these simple iteration functions return error is when the dm is not initialized at uclass_get time. This is

Re: [PATCH 04/10] timer: cadence-ttc: Add timer_early functions

2022-09-27 Thread Simon Glass
On Mon, 26 Sept 2022 at 08:11, Stefan Roese wrote: > > Hi Simon, > Hi Michal, > > On 25.09.22 16:15, Simon Glass wrote: > > Hi Stefan, > > > > On Wed, 21 Sept 2022 at 08:06, Stefan Roese wrote: > >> > >> Currently this timer driver provides timer_get_boot_us() to support the > >> BOOTSTAGE functi

Re: [PATCH 07/10] board_f/r: Allow selection of CONFIG_TIMER_EARLY w/o CONFIG_TIMER

2022-09-27 Thread Simon Glass
Hi Stefan, On Mon, 26 Sept 2022 at 07:52, Stefan Roese wrote: > > Hi Simon, > > On 25.09.22 16:15, Simon Glass wrote: > > Hi Stefan, > > > > On Wed, 21 Sept 2022 at 08:06, Stefan Roese wrote: > >> > >> The early timer functions provided via CONFIG_TIMER_EARLY don't need > >> CONFIG_TIMER to be e

Re: [PATCH v2 1/8] dm: fpga: Introduce new uclass

2022-09-27 Thread Simon Glass
Hi Alex, On Mon, 26 Sept 2022 at 00:14, Alexander Dahl wrote: > > Hello Simon, > > Am Sun, Sep 25, 2022 at 08:15:38AM -0600 schrieb Simon Glass: > > Hi Michal, > > > > On Thu, 22 Sept 2022 at 05:45, Michal Simek wrote: > > > > > > > > > > > > On 9/22/22 13:35, Simon Glass wrote: > > > > Hi, > >

Re: [PATCH] fdt_support: cosmetic: remove fdt_fixup_nor_flash_size prototype

2022-09-27 Thread Simon Glass
On Tue, 27 Sept 2022 at 02:18, Patrick Delaunay wrote: > > Remove prototype for the removed function fdt_fixup_nor_flash_size. > This patch has no impact as the function is never used. > > Fixes: 98f705c9cefd ("powerpc: remove 4xx support") > Signed-off-by: Patrick Delaunay > --- > > include/fdt

  1   2   >