Re: [PATCH v11 15/15] FWU: doc: Add documentation for the FWU feature

2022-10-04 Thread Takahiro Akashi
On Tue, Oct 04, 2022 at 12:10:27PM +0530, Sughosh Ganu wrote: > hi Takahiro, > > On Tue, 4 Oct 2022 at 08:24, Takahiro Akashi > wrote: > > > > Sughosh, > > > > On Wed, Sep 28, 2022 at 02:59:56PM +0530, Sughosh Ganu wrote: > > > Add documentation for the FWU Multi Bank Update feature. The documen

Re: [PATCH 1/3] cmd/sbi: format RustSBI version number

2022-10-04 Thread Leo Liang
Hi Sean, On Tue, Oct 04, 2022 at 02:23:33AM -0400, Sean Anderson wrote: > On 10/1/22 03:39, Heinrich Schuchardt wrote: > > The SBI command can print out the version number of the SBI implementation. > > Choose the correct output format for RustSBI. > > > > Signed-off-by: Heinrich Schuchardt > > -

Re: [PATCH v12 06/15] FWU: Add helper functions for accessing FWU metadata

2022-10-04 Thread Ilias Apalodimas
Hi Sughosh [...] > > > + > > > +static int fwu_alt_num_for_dfu_dev(struct dfu_entity *dfu, int dev_num, > > > + int part, unsigned char dfu_dev, > > > + u8 *alt_num) > > > +{ > > > + int ret; > > > + > > > + switch(dfu_

Re: [PATCH v12 08/15] event: Add an event for main_loop

2022-10-04 Thread Ilias Apalodimas
Hi Sughosh Didn't I add my r-b for this one i the previous version? Thanks /Ilias On Mon, 3 Oct 2022 at 17:25, Sughosh Ganu wrote: > > Add an event type EVT_MAIN_LOOP that can be used for registering > events that need to be run after the platform has been initialised and > before the main_loop

Re: [PATCH v11 15/15] FWU: doc: Add documentation for the FWU feature

2022-10-04 Thread Ilias Apalodimas
Akashi-san > > > > + > > > > +* FWU metadata 1 > > > > +* U-Boot 1 > > > > +* OP-TEE 1 > > > > +* FWU metadata 2 > > > > +* OP-TEE 2 > > > > +* U-Boot 2 > > > > +* ESP > > > > +* rootfs > > > > + > > > > +When generating the partitions, a few aspects need to be taken care > > > > +of. Each GPT pa

[PATCH v2 0/3] sbi/cmd: improve output formatting

2022-10-04 Thread Heinrich Schuchardt
* correctly format the version number for RustSBI * provide an error message if the SBI does not implement the 'SBI Base Functionality' extension. * provide user friendly short texts for the legacy extensions v2: remove spurious '+' in first patch Heinrich Schuchardt (3): cmd/sbi: for

[PATCH v2 1/3] cmd/sbi: format RustSBI version number

2022-10-04 Thread Heinrich Schuchardt
The SBI command can print out the version number of the SBI implementation. Choose the correct output format for RustSBI. Signed-off-by: Heinrich Schuchardt Reviewed-by: Rick Chen --- v2: remove spurious '+' from inserted line --- cmd/riscv/sbi.c | 1 + 1 file changed, 1 insertion(+) d

[PATCH v2 2/3] cmd/sbi: error message for failure to get spec version

2022-10-04 Thread Heinrich Schuchardt
If calling 'Get SBI specification version' fails, write an error message and return CMD_RET_FAILURE. Signed-off-by: Heinrich Schuchardt Reviewed-by: Rick Chen --- v2: no change --- cmd/riscv/sbi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cmd/riscv/sbi.c

[PATCH v2 3/3] cmd/sbi: user friendly short texts

2022-10-04 Thread Heinrich Schuchardt
In the sbi command use the same short texts for the legacy extensions as the SBI specification 1.0.0. Signed-off-by: Heinrich Schuchardt Reviewed-by: Rick Chen --- v2: no change --- cmd/riscv/sbi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cm

[PATCH 1/1] efi_driver: simplify efi_uc_stop(), call efi_free_pool()

2022-10-04 Thread Heinrich Schuchardt
We have exported efi_free_pool(). There is no need to use EFI_CALL(). Signed-off-by: Heinrich Schuchardt --- lib/efi_driver/efi_uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_driver/efi_uclass.c b/lib/efi_driver/efi_uclass.c index 5a285aad89..6ccba07b29 1006

Re: [PATCH 1/1] efi_driver: simplify efi_uc_stop(), call efi_free_pool()

2022-10-04 Thread Ilias Apalodimas
On Tue, 4 Oct 2022 at 13:53, Heinrich Schuchardt wrote: > > We have exported efi_free_pool(). There is no need to use EFI_CALL(). > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_driver/efi_uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_driver/efi

[PATCH v4 1/5] imx8m: USDHC3 base address definition for i.MX8MP

2022-10-04 Thread Martyn Welch
The i.MX8MP also has USDHC3, allow access to the relvant base address definition. Signed-off-by: Martyn Welch --- Changes in v2: - None Changes in v3: - None Changes in v4: - None arch/arm/include/asm/arch-imx8m/imx-regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 3/5] drivers: power: pmic: Add support for rn5t568 PMIC

2022-10-04 Thread Martyn Welch
Add support for the rn5t568 PMIC to the rn5t567 driver. Signed-off-by: Martyn Welch --- Changes in v2: - None Changes in v3: - None Changes in v4: - None drivers/power/pmic/rn5t567.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/power/pmic/rn5t567.c b/drivers/power/pmic/rn5t

[PATCH v4 4/5] drivers: power: pmic: Enable use of rn5t567 PMIC in SPL

2022-10-04 Thread Martyn Welch
The support added later in this series tweaks the PMIC voltages in the SPL. Enable support for the rn5t567 in SPL builds to allow this to be done cleanly. Signed-off-by: Martyn Welch Reviewed-by: Simon Glass --- Changes in v3: - New patch (replaces addition of legacy support for rn5t567) Chan

[PATCH v4 2/5] ARM: imx: imx8mp: Enable support for i2c5 and i2c6 on i.MX8MP

2022-10-04 Thread Martyn Welch
The i.MX8MP SoC contains 2 more i2c buses. Add support for the configuration of these buses. Signed-off-by: Martyn Welch --- Changes in v2: - None Changes in v3: - None Changes in v4: - None arch/arm/include/asm/arch-imx8m/imx-regs.h | 4 arch/arm/mach-imx/i2c-mxv7.c |

[PATCH v4 5/5] arm: imx8mp: Initial MSC SM2S iMX8MP support

2022-10-04 Thread Martyn Welch
Add support for the MSC SM2S-IMX8PLUS SMARC Module. Tested in conjunction with the MSC SM2-MB-EP1 Mini-ITX Carrier Board. Signed-off-by: Martyn Welch --- Changes in v2: - Renamed FDT to closer match kernel - Sync with kernel FDT - Update for changes made in U-Boot Changes in v3: - Use imx8m

[PATCH] arm: dts: rockchip: rk356x: sync with Linux 6.0

2022-10-04 Thread FUKAUMI Naoki
prepare for rk3566 based board Signed-off-by: FUKAUMI Naoki --- arch/arm/dts/rk3566.dtsi | 35 + arch/arm/dts/rk3568-evb-u-boot.dtsi |2 +- arch/arm/dts/rk3568-pinctrl.dtsi |9 + arch/arm/dts/rk3568.dtsi | 848 +---

[PATCH] arm64: zynqmp: Fix compiler warnings in mp.c

2022-10-04 Thread Venkatesh Yadav Abbarapu
make W=1 generates the following warning in cpu_disable, cpu_status and cpu_release functions. arch/arm/mach-zynqmp/mp.c:166:16: warning: comparison of unsigned expression in '>= 0' is always true [-Wtype-limits] 166 | if (nr >= ZYNQMP_CORE_APU0 && nr <= ZYNQMP_CORE_APU3) { |

[PATCH] spi: zynqmp_qspi: Mark zynqmp_qspi_set_tapdelay() as static

2022-10-04 Thread Venkatesh Yadav Abbarapu
Fix the following sparse and compile time warning triggered with W=1: drivers/spi/zynqmp_gqspi.c:286:6: warning: no previous prototype for 'zynqmp_qspi_set_tapdelay' [-Wmissing-prototypes] Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/spi/zynqmp_gqspi.c | 2 +- 1 file changed, 1 insertio

[PATCH] xilinx: common: Add zynq_board_read_rom_ethaddr() declaration

2022-10-04 Thread Venkatesh Yadav Abbarapu
board.c defines zynq_board_read_rom_ethaddr(), but neglected to include its declaration, causing the following sparse and compile time warnings: board/xilinx/common/board.c:56:5: warning: no previous prototype for 'zynq_board_read_rom_ethaddr' [-Wmissing-prototypes] Include asm/arch/sys_proto.h,

[PATCH] xilinx: common: Add print_cpuinfo() declaration

2022-10-04 Thread Venkatesh Yadav Abbarapu
cpu-info.c defines print_cpuinfo(), but neglected to include its declaration, causing the following sparse and compile time warnings: board/xilinx/common/cpu-info.c:10:5: warning: no previous prototype for 'print_cpuinfo' [-Wmissing-prototypes] Include init.h, which includes the missing declarati

[PATCH] soc: xilinx: zynqmp: Mark soc_xilinx_zynqmp_get_machine() as static

2022-10-04 Thread Venkatesh Yadav Abbarapu
Fix the following sparse and compile time warning triggered with W=1: drivers/soc/soc_xilinx_zynqmp.c:288:5: warning: no previous prototype for 'soc_xilinx_zynqmp_get_machine' [-Wmissing-prototypes] Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/soc/soc_xilinx_zynqmp.c | 2 +- 1 file chan

[PATCH v1 3/3] configs: verdin-imx8mp: enable caam

2022-10-04 Thread Andrejs Cainikovs
This change enables Cryptographic Accelerator and Assurance Module. Signed-off-by: Andrejs Cainikovs --- configs/verdin-imx8mp_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/verdin-imx8mp_defconfig b/configs/verdin-imx8mp_defconfig index 5d0c57c52e4..dc77c8de076 100644 ---

[PATCH v1 2/3] verdin-imx8mp: spl: initialize caam

2022-10-04 Thread Andrejs Cainikovs
This change initializes Cryptographic Accelerator and Assurance Module. Signed-off-by: Andrejs Cainikovs --- board/toradex/verdin-imx8mp/spl.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/board/toradex/verdin-imx8mp/spl.c b/board/toradex/verdin-imx8mp/spl.c index 6f1931ffaca

[PATCH v1 0/3] verdin-imx8mp: enable caam

2022-10-04 Thread Andrejs Cainikovs
This patch series enables Cryptographic Accelerator and Assurance Module (aka CAAM) on verdin-imx8mp SoM. Andrejs Cainikovs (3): arm: dts: verdin-imx8mp: enable caam in SPL verdin-imx8mp: spl: initialize caam configs: verdin-imx8mp: enable caam arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dt

[PATCH v1 1/3] arm: dts: verdin-imx8mp: enable caam in SPL

2022-10-04 Thread Andrejs Cainikovs
CAAM is initialized in SPL, so relevant device tree nodes needs to be updated. Signed-off-by: Andrejs Cainikovs --- arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/dts/imx8mp-verdin-wifi-dev-u-boot.dtsi b/arch/arm/dt

[PATCH] xilinx: zynqmp: change the type of multiboot variable

2022-10-04 Thread Venkatesh Yadav Abbarapu
In function ‘set_dfu_alt_info’ a comparison of a u8 value against 0 is done. Since it is always false, change the signature of this function to use an `int` instead, which match the type used in caller: `multi_boot()`. Fix the following warning triggered with W=1: board/xilinx/zynqmp/zynqmp.c:651

Re: [PATCH v2 0/1] dm: fpga: Introduce new uclass

2022-10-04 Thread Michal Simek
On 9/30/22 14:04, Alexander Dahl wrote: Hei hei, tried to address all the feedback I got from Simon, thanks for that. Build tested on Debian GNU/Linux 11 (bullseye) on arch amd64, tried on i386 first, but got some nasty errors there (see IRC backlog). Tried in sandbox console, and everythin

Re: [PATCH v2 1/3] riscv: implement __ashldi3, __lshrdi3

2022-10-04 Thread Andreas Schwab
On Okt 01 2022, Heinrich Schuchardt wrote: > On 32bit RISC-V calls to __ashrdi3 and __lshrdi3 are generated. > These functions are normally provided by glibc but U-Boot is freestanding They are defined by libgcc, not glibc. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196

Re: [PATCH 04/10] timer: cadence-ttc: Add timer_early functions

2022-10-04 Thread Michal Simek
Hi Stefan, On 9/30/22 15:45, Stefan Roese wrote: Hi Michal, On 30.09.22 14:02, Michal Simek wrote: Hi Simon and Stefan, On 9/28/22 03:54, Simon Glass wrote: Hi Simon, Hi Michal, On 25.09.22 16:15, Simon Glass wrote: Hi Stefan, On Wed, 21 Sept 2022 at 08:06, Stefan Roese wrote: Currentl

Re: [PATCH] xilinx: zynq: Enable early eeprom decoding

2022-10-04 Thread Michal Simek
út 27. 9. 2022 v 9:56 odesílatel Michal Simek napsal: > > Xilinx Zynq evaluation boards have factory program content in eeprom. > Enable reading and decoding eeprom content to get information about board > name, revision and especially getting ethernet mac address. > > Signed-off-by: Michal Simek

Re: [PATCH] ARM: zynq: Point via nvmem0 alias to eeprom on zc702/zc706

2022-10-04 Thread Michal Simek
út 27. 9. 2022 v 9:55 odesílatel Michal Simek napsal: > > EEPROM stores identification information about board like a board name, > revision, serial number and ethernet MAC address. U-Boot is capable to read > nvmemX aliases and read/display provided information when nvmem alias link > is describe

Re: [PATCH] ARM: zynq: Define rtc alias on zc702/zc706

2022-10-04 Thread Michal Simek
út 27. 9. 2022 v 13:50 odesílatel Michal Simek napsal: > > Define rtc alias on zc702/zc706 boards. > > Signed-off-by: Michal Simek > --- > > arch/arm/dts/zynq-zc702.dts | 3 ++- > arch/arm/dts/zynq-zc706.dts | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/dt

Re: [PATCH] xilinx: zynqmp: Load pmufw configuration before checking access

2022-10-04 Thread Michal Simek
pá 30. 9. 2022 v 9:36 odesílatel Michal Simek napsal: > > Before this patch you could see in the log: > U-Boot SPL 2022.10-rc5 (Sep 29 2022 - 15:29:27 +0200) > PMUFW: v1.1 > Loading new PMUFW cfg obj (32 bytes) > PMUFW: No permission to change config object > Loading new PMUFW cfg obj (2032 byte

Re: [PATCH] firmware: zynqmp: Change loadable config object from APU_0 to OCM_BANK_0

2022-10-04 Thread Michal Simek
pá 30. 9. 2022 v 9:37 odesílatel Michal Simek napsal: > > From: Ashok Reddy Soma > > To check dynamic loading of config object, currently APU_0 is used. > Suggestion from pmwfw team is to load OCM_BANK_0 and check for > XST_PM_NO_ACCESS error only to skip future config objects. Other errors > sho

Re: [PATCH v3 1/3] net: emaclite: enable for more architectures

2022-10-04 Thread Michal Simek
On 9/27/22 13:21, samuel.ob...@codasip.com wrote: From: Samuel Obuch Function ioremap_nocache seems to be defined only for MIPS and Microblaze architectures. Therefore, the function call in the emaclite driver causes this driver to be unusable with other architectures, for example RISC-V. U

Re: [PATCH] xilinx: common: Fix static checker warnings

2022-10-04 Thread Michal Simek
On 9/26/22 08:52, Venkatesh Yadav Abbarapu wrote: Avoid signed extension for uuid and byte. Eliminate the below smatch warnings: board/xilinx/common/board.c:128 xilinx_eeprom_legacy_cleanup() warn: impossible condition '(byte == 255) => ((-128)-127 == 255)' board/xilinx/common/board.c:466 bo

Re: [PATCH] mmc: Fix static checker warnings

2022-10-04 Thread Michal Simek
On 9/29/22 06:52, Venkatesh Yadav Abbarapu wrote: Correct pointer dereferencing check to be more consistent. Eliminate the below smatch warning: drivers/mmc/mmc.c:3118 mmc_init_device() warn: variable dereferenced before check 'm' (see line 3116) Signed-off-by: Venkatesh Yadav Abbarapu ---

[RFC 1/1] cmd: add command to dump EFI block devices

2022-10-04 Thread Heinrich Schuchardt
Provide a command to dump * all block devices * the protocol interfaces installed on these * the open protocol information Signed-off-by: Heinrich Schuchardt --- When working on the EFI DM integration this command will us help to better understand the setup. We might want to add some of the out

Re: [PATCH] net: Fix static checker warnings

2022-10-04 Thread Michal Simek
On 9/29/22 06:56, Venkatesh Yadav Abbarapu wrote: Here are the smatch warning messages: drivers/net/xilinx_axi_emac.c:324 axiemac_phy_init() error: 'phydev' dereferencing possible ERR_PTR() drivers/net/zynq_gem.c:340 zynq_phy_init() error: 'priv->phydev' dereferencing possible ERR_PTR() Fix

Re: [PATCH 0/3] Read mmc "power-domains" id from DT and use for firmware calls

2022-10-04 Thread Michal Simek
On 9/30/22 11:25, Ashok Reddy Soma wrote: In this patch series - Existing node_id is u8, change it to u32 to accommodate Versal node_id - Read "power-domains" id from DT and use in all firmware calls in place of node_id. - Remove static values of node_id which are set based on "device_id" -

Re: [PATCH 1/2] arm64: versal: Add qspi flash mini u-boot configuration

2022-10-04 Thread Michal Simek
On 9/30/22 10:55, Ashok Reddy Soma wrote: Add configuration file for mini u-boot configuration which runs on a smaller footprint from on chip memory(OCM). This configuration has required CONFIG's enabled to support qspi flash and uses DCC terminal for console output. Signed-off-by: Ashok Redd

[PATCH 1/1] cmd: simplify command efidebug

2022-10-04 Thread Heinrich Schuchardt
Currently we have subcommands 'efidebug dh' which shows protocols per handle and 'efidebug devices' which shows the device path. None shows which U-Boot device matches the handle. Change 'efidebug dh' to show the device path and the U-Boot device if any is associated with the handle. Remove 'efid

Re: [PATCH] gpio-uclass: fix gpio lookup by label

2022-10-04 Thread Rasmus Villemoes
On 04/10/2022 01.49, Simon Glass wrote: > On Mon, 3 Oct 2022 at 03:03, Rasmus Villemoes > wrote: >> >> Matching anything that just happens to have the sought-for label as a >> prefix is wrong. For example, if the board designer has designated 10 >> lines for debug purposes, named "debug1" through

[PATCH 1/1] efi_driver: carve out function to create block device

2022-10-04 Thread Heinrich Schuchardt
* Carve out function efi_bl_create_block_device() from efi_bl_bind(). * Add a check for U-Boot devices to efi_bl_bind(). Signed-off-by: Heinrich Schuchardt --- lib/efi_driver/efi_block_device.c | 32 --- lib/efi_driver/efi_uclass.c | 9 - 2 files change

[PATCH v2 0/6] eficonfig: add UEFI Secure Boot key maintenance interface

2022-10-04 Thread Masahisa Kojima
This series adds the UEFI Secure Boot key maintenance interface to the eficonfig command. User can enroll and delete the PK, KEK, db and dbx. This series is based on the u-boot/next branch since 'eficonfig' command is not merged in u-boot/master. Source code can be cloned with: $ git clone https:

[PATCH v2 1/6] eficonfig: refactor eficonfig_select_file_handler()

2022-10-04 Thread Masahisa Kojima
eficonfig_select_file_handler() is commonly used to select the file. eficonfig_display_select_file_option() intends to add the additional menu mainly to clear the selected file information. eficonfig_display_select_file_option() is not necessary for the file selection process, so it should be outsi

[PATCH v2 2/6] eficonfig: expose append entry function

2022-10-04 Thread Masahisa Kojima
This commit exposes the eficonfig menu entry append function. Signed-off-by: Masahisa Kojima --- newly created in v2 cmd/eficonfig.c | 32 +--- include/efi_config.h | 5 + 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/cmd/eficonfig.c b/cm

[PATCH v2 4/6] eficonfig: add "Show/Delete Signature Database" menu entry

2022-10-04 Thread Masahisa Kojima
This commit adds the menu-driven interface to show and delete the signature database. EFI Signature Lists can contain the multiple signature entries, this menu can delete the indivisual entry. If the PK is enrolled and UEFI Secure Boot is in User Mode or Deployed Mode, user can not delete the ex

[PATCH v2 5/6] test/eficonfig: support secure boot key maintenance menu

2022-10-04 Thread Masahisa Kojima
eficonfig test is get aligned with the addition of secure boot key management menu. Signed-off-by: Masahisa Kojima --- newly created in v2 test/py/tests/test_eficonfig/test_eficonfig.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/py/tests/test_eficonfig/test_efic

[PATCH v2 3/6] eficonfig: add UEFI Secure Boot Key enrollment interface

2022-10-04 Thread Masahisa Kojima
This commit adds the menu-driven UEFI Secure Boot Key enrollment interface. User can enroll the PK, KEK, db and dbx by selecting EFI Signature Lists file. After the PK is enrolled, UEFI Secure Boot is enabled and EFI Signature Lists file must be signed by KEK or PK. Signed-off-by: Masahisa Kojima

[PATCH v2 6/6] test: add test for eficonfig secure boot key management

2022-10-04 Thread Masahisa Kojima
Provide a unit test for the eficonfig secure boot key management menu. Signed-off-by: Masahisa Kojima --- newly created in v2 test/py/tests/test_eficonfig/conftest.py | 84 +++- test/py/tests/test_eficonfig/defs.py | 14 + .../test_eficonfig/test_eficonfig_sbkey.py| 472

Re: [PATCH 04/10] timer: cadence-ttc: Add timer_early functions

2022-10-04 Thread Stefan Roese
Hi Michal, (adding Kever & Philipp to Cc) On 04.10.22 13:49, Michal Simek wrote: Hi Stefan, On 9/30/22 15:45, Stefan Roese wrote: Hi Michal, On 30.09.22 14:02, Michal Simek wrote: Hi Simon and Stefan, On 9/28/22 03:54, Simon Glass wrote: Hi Simon, Hi Michal, On 25.09.22 16:15, Simon Glas

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Tim Harvey
On Mon, Oct 3, 2022 at 5:39 PM Fabio Estevam wrote: > > Hi Tim, > > On Mon, Oct 3, 2022 at 9:23 PM Tim Harvey wrote: > > > Where are you setting your active port? By default eth0 is active and > > thats the cpu uplink. If you have a network connection on lan3 port > > you would need to 'setenv et

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Fabio Estevam
Hi Tim, On Tue, Oct 4, 2022 at 12:26 PM Tim Harvey wrote: > Fabio, > > Thanks for testing this. I'll submit a v5 shortly with your rb tag and > support for 6320: Thanks for including the 6320 model! > Was there an error path you found in drivers/net/mv88e6xxx.c that > should print an error to

Re: [PATCH 04/10] timer: cadence-ttc: Add timer_early functions

2022-10-04 Thread Simon Glass
Hi, On Tue, 4 Oct 2022 at 05:50, Michal Simek wrote: > > Hi Stefan, > > On 9/30/22 15:45, Stefan Roese wrote: > > Hi Michal, > > > > On 30.09.22 14:02, Michal Simek wrote: > >> Hi Simon and Stefan, > >> > >> On 9/28/22 03:54, Simon Glass wrote: > Hi Simon, > Hi Michal, > > On

Re: [PATCH v2 6/6] test: add test for eficonfig secure boot key management

2022-10-04 Thread Simon Glass
Hi Masahisa, On Tue, 4 Oct 2022 at 08:36, Masahisa Kojima wrote: > > Provide a unit test for the eficonfig secure boot key > management menu. > > Signed-off-by: Masahisa Kojima > --- > newly created in v2 > > test/py/tests/test_eficonfig/conftest.py | 84 +++- > test/py/tests/test_eficonf

[PATCH 1/1] doc: documentation of EFI driver binding protocol

2022-10-04 Thread Heinrich Schuchardt
* Convert code comments in include/efi_driver.h to Sphinx style. * Add include/efi_driver.h to the HTML documentation. Signed-off-by: Heinrich Schuchardt --- doc/api/efi.rst | 6 ++ include/efi_driver.h | 19 --- 2 files changed, 18 insertions(+), 7 deletions(-) diff -

Re: [RFC 1/1] cmd: add command to dump EFI block devices

2022-10-04 Thread Simon Glass
Hi Heinrich, On Tue, 4 Oct 2022 at 06:34, Heinrich Schuchardt wrote: > > Provide a command to dump > > * all block devices > * the protocol interfaces installed on these > * the open protocol information > > Signed-off-by: Heinrich Schuchardt > --- > When working on the EFI DM integration this c

Re: [PATCH] gpio-uclass: fix gpio lookup by label

2022-10-04 Thread Simon Glass
Hi Rasmus, On Tue, 4 Oct 2022 at 07:43, Rasmus Villemoes wrote: > > On 04/10/2022 01.49, Simon Glass wrote: > > On Mon, 3 Oct 2022 at 03:03, Rasmus Villemoes > > wrote: > >> > >> Matching anything that just happens to have the sought-for label as a > >> prefix is wrong. For example, if the board

Re: [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support

2022-10-04 Thread Paul Barker
On 03/10/2022 13:05, Paul Barker wrote: > On 26/09/2022 14:52, Heinrich Schuchardt wrote: >> On 9/21/22 18:06, Paul Barker wrote: >>> + >>> +    log_debug("Added EFI_SPI_IO_PROTOCOL for %s with guid " >>> +  >>> "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x\n", >>>

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Fabio Estevam
Hi Tim, On Tue, Oct 4, 2022 at 1:25 PM Fabio Estevam wrote: > > Hi Tim, > > On Tue, Oct 4, 2022 at 12:26 PM Tim Harvey wrote: > > > Fabio, > > > > Thanks for testing this. I'll submit a v5 shortly with your rb tag and > > support for 6320: > > Thanks for including the 6320 model! > > > Was there

[PATCH v5 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-10-04 Thread Tim Harvey
This series adds a DSA driver for the MV88E6xxx based on drivers/net/phy/mv88e61xx and uses it in the gwventana_gw5904_defconfig. The hope is that the other three boards that use the MV88E61xx driver can move to this as well eventually so that we can remove the non-dm driver and the 4 Kconfig opti

[PATCH v5 2/8] net: dsa: move cpu port probe to dsa_post_probe

2022-10-04 Thread Tim Harvey
In order to ensure that a DSA driver probe gets called before dsa_ops->port_probe move the port_probe of the cpu_port to a post-probe function. Signed-off-by: Tim Harvey Reviewed-by: Ramon Fried Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v5: - added Fabio's rb tag v4: - no c

[PATCH v5 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-10-04 Thread Tim Harvey
Allow rcv() and xmit() dsa driver ops to be optional in case a driver does not care to mangle a packet as in U-Boot only one network port is enabled at a time and thus no packet mangling is necessary. Suggested-by: Vladimir Oltean Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-

[PATCH v5 3/8] net: dsa: ensure dsa driver has proper ops

2022-10-04 Thread Tim Harvey
Add a function to sanity check a dsa driver having proper ops. Suggested-by: Vladimir Oltean Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v5: - added Fabio's rb tag v4: - no changes v3: - added Vladimir's rb tag v2: new patch --- net/dsa-uclass.c |

[PATCH v5 6/8] net: fec: add support for DM_MDIO

2022-10-04 Thread Tim Harvey
Add support for DM_MDIO by registering a UCLASS_MDIO driver and attempting to use it. This is necessary if wanting to use a DSA driver for example hanging off of the FEC MAC. Care is taken to fallback to non DM_MDIO mii bus as several boards define DM_MDIO without having the proper device-tree con

[PATCH v5 1/8] net: mdio-uclass: scan for dm mdio children on post-bind

2022-10-04 Thread Tim Harvey
If a DM_MDIO driver is used we need to scan the subnodes as well. Signed-off-by: Tim Harvey Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried Reviewed-by: Fabio Estevam --- v5: - added Fabio's rb tag v4: - no changes v3: - no changes v2: - added Ramon's rb tag --- net/mdio-uclass.c

[PATCH v5 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Tim Harvey
Add MV88E61XX DSA support: - update dt: U-Boot dsa driver requires different device-tree syntax than the linux driver in order to link the dsa ports to the mdio bus. - update defconfig - replace mv88e61xx_hw_reset weak override with board_phy_config support for mv88e61xx configuration that

[PATCH v5 7/8] net: add MV88E61xx DSA driver

2022-10-04 Thread Tim Harvey
Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. Cc: Marek Behún Cc: Vladimir Oltean Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v5: - added support for MV88E6320 - added Fabio's rb tag v4: - rename to mv88e6xxx - sort includes

[PATCH v5 5/8] net: ksz9477: remove unnecessary xmit and recv functions

2022-10-04 Thread Tim Harvey
Remove the unnecessary xmit and recv functions. Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v5: - added Fabio's rb tag v4: - no changes v3: - added Vladimir's rb tag v2: new patch --- drivers/net/ksz9477.c | 23 --- 1 file change

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Tim Harvey
On Tue, Oct 4, 2022 at 9:47 AM Fabio Estevam wrote: > > Hi Tim, > > On Tue, Oct 4, 2022 at 1:25 PM Fabio Estevam wrote: > > > > Hi Tim, > > > > On Tue, Oct 4, 2022 at 12:26 PM Tim Harvey wrote: > > > > > Fabio, > > > > > > Thanks for testing this. I'll submit a v5 shortly with your rb tag and >

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Fabio Estevam
Hi Tim, On 04/10/2022 13:50, Tim Harvey wrote: Fabio, I just sent a v5 before seeing this. I think all we are waiting for on this series is for Vladimir to ok the dt changes as I believe I have finally done the right thing there now. If I need to do a v6 I'll add this in, otherwise I'll send

[PATCH 1/1] efi_driver: reformat efi_block_device.c

2022-10-04 Thread Heinrich Schuchardt
* use Sphinx documentation style * correct indentation Signed-off-by: Heinrich Schuchardt --- lib/efi_driver/efi_block_device.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/efi_driver/efi_block_device.c b/lib/efi_driver/efi_block_device.c index

Re: [RFC 1/1] cmd: add command to dump EFI block devices

2022-10-04 Thread Heinrich Schuchardt
On 10/4/22 18:30, Simon Glass wrote: Hi Heinrich, On Tue, 4 Oct 2022 at 06:34, Heinrich Schuchardt wrote: Provide a command to dump * all block devices * the protocol interfaces installed on these * the open protocol information Signed-off-by: Heinrich Schuchardt --- When working on the EF

[PATCH 1/1] efi_driver: provide driver binding protocol to bind function

2022-10-04 Thread Heinrich Schuchardt
DisconnectController() is based on the open protocol information created when the driver opens a protocol with BY_CHILD_CONTROLLER or BY_DRIVER. To create an open protocol information it is required to supply the handle of the driver as agent handle. This information is available as field DriverBi

Re: [PATCH v3 1/3] efi_loader: Add SPI I/O protocol support

2022-10-04 Thread Heinrich Schuchardt
On 10/4/22 18:31, Paul Barker wrote: On 03/10/2022 13:05, Paul Barker wrote: On 26/09/2022 14:52, Heinrich Schuchardt wrote: On 9/21/22 18:06, Paul Barker wrote: + +    log_debug("Added EFI_SPI_IO_PROTOCOL for %s with guid " +  "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x

Re: [PATCH v2] cmd: pxe: add alias devicetree-overlay for fdtoverlays

2022-10-04 Thread Edoardo Tomelleri
Hello, is there any issue remaining with this patch? Will this be accepted for 2022.10 release? Thanks, Edoardo Il giorno mer 21 set 2022 alle ore 15:41 Edoardo Tomelleri ha scritto: > > No problem, I noticed that I forgot to update the link when you asked > to add it to the commit message. > > I

Re: [RFC 1/1] cmd: add command to dump EFI block devices

2022-10-04 Thread Simon Glass
Hi Heinrich, On Tue, 4 Oct 2022 at 11:01, Heinrich Schuchardt wrote: > > On 10/4/22 18:30, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 4 Oct 2022 at 06:34, Heinrich Schuchardt > > wrote: > >> > >> Provide a command to dump > >> > >> * all block devices > >> * the protocol interfaces inst

[RFC 1/1] efi_loader: fix open protocol information for block device

2022-10-04 Thread Heinrich Schuchardt
If OpenProtocol() is called without an agent handle, no open protocol information is generated. With the patch we actually see the link between partition an its block device when printing the open protocol information: 1b2452f0 (host0) protocol: 964e5b21-6459-11d2-8e39-00a0c969723b -

[PATCH 1/1] doc: typo 'it it' in doc/develop/package/index.rst

2022-10-04 Thread Heinrich Schuchardt
%s/it it/it/ Signed-off-by: Heinrich Schuchardt --- doc/develop/package/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop/package/index.rst b/doc/develop/package/index.rst index 9374be2e62..4f448313f9 100644 --- a/doc/develop/package/index.rst +++ b/doc/de

Re: [PATCH v1 0/3] verdin-imx8mp: enable caam

2022-10-04 Thread Marcel Ziswiler
Hi Andrejs On Tue, 2022-10-04 at 13:06 +0200, Andrejs Cainikovs wrote: > This patch series enables Cryptographic Accelerator and > Assurance Module (aka CAAM) on verdin-imx8mp SoM. > > Andrejs Cainikovs (3): >   arm: dts: verdin-imx8mp: enable caam in SPL >   verdin-imx8mp: spl: initialize caam >

Re: [PATCH 1/1] doc: typo 'it it' in doc/develop/package/index.rst

2022-10-04 Thread Simon Glass
On Tue, 4 Oct 2022 at 14:05, Heinrich Schuchardt wrote: > > %s/it it/it/ > > Signed-off-by: Heinrich Schuchardt > --- > doc/develop/package/index.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH v5 2/8] net: dsa: move cpu port probe to dsa_post_probe

2022-10-04 Thread Vladimir Oltean
On Tue, Oct 04, 2022 at 09:49:12AM -0700, Tim Harvey wrote: > diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c > index 5b7046432ff3..a37e76e25a8f 100644 > --- a/net/dsa-uclass.c > +++ b/net/dsa-uclass.c > @@ -466,7 +466,6 @@ static int dsa_pre_probe(struct udevice *dev) > +static int dsa_post_probe

[PATCH v3] schemas: Add schema for U-Boot driver model 'phase tags'

2022-10-04 Thread Simon Glass
Until recently it has not been possible to add any U-Boot-specific properties to the device tree schema. Now that it is somewhat separated from Linux and people are feeling the enormous pain of the bifurcated schema, it seems like a good time to add this and other U-Boot-specific bindings. U-Boot

Re: [PATCH v5 7/8] net: add MV88E61xx DSA driver

2022-10-04 Thread Vladimir Oltean
Please also rewrite "61xx" from the commit message into "6xxx". On Tue, Oct 04, 2022 at 09:49:17AM -0700, Tim Harvey wrote: > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > Cc: Marek BehĂșn > Cc: Vladimir Oltean > Signed-off-by: Tim Harvey > Reviewed-by: Vladimir Olte

Re: [PATCH v5 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Vladimir Oltean
On Tue, Oct 04, 2022 at 09:49:18AM -0700, Tim Harvey wrote: > Add MV88E61XX DSA support: > - update dt: U-Boot dsa driver requires different device-tree syntax >than the linux driver in order to link the dsa ports to the mdio bus. Not really correct. Better said, U-Boot requires a more restri

Re: [PATCH 1/1] cmd: simplify command efidebug

2022-10-04 Thread AKASHI Takahiro
Heinrich, On Tue, Oct 04, 2022 at 03:40:32PM +0200, Heinrich Schuchardt wrote: > Currently we have subcommands 'efidebug dh' which shows protocols per > handle and 'efidebug devices' which shows the device path. None shows which > U-Boot device matches the handle. If you know how a device path di

Re: [PATCH] avb: Extend support to non-eMMC interfaces

2022-10-04 Thread Simon Glass
On Mon, 26 Sept 2022 at 16:02, Alistair Delva wrote: > > From: Jiyong Park > > Previously Android AVB supported block devices only on eMMC. This change > eliminates the restriction by using the generic block driver model. > > The `avb init' command is modified to accept another parameter which >

Re: [PATCH] x86: Fix i8259 ifdef include guard

2022-10-04 Thread Simon Glass
On Mon, 26 Sept 2022 at 16:23, Alistair Delva wrote: > > When building U-Boot with clang, it notices that the i8259.h include > guard does not work correctly due to a typo. Fix it. > > Signed-off-by: Alistair Delva > Cc: Simon Glass > Cc: Bin Meng > Cc: Nick Desaulniers > --- > arch/x86/inclu

Re: [PATCH 1/2] sandbox: Initialize sysreset before relocation

2022-10-04 Thread Simon Glass
On Sun, 25 Sept 2022 at 07:27, Michal Suchanek wrote: > > Without this the early sysreset code cannot be tested. > > Signed-off-by: Michal Suchanek > --- > > arch/sandbox/dts/sandbox.dtsi | 1 + > arch/sandbox/dts/test.dts | 2 ++ > 2 files changed, 3 insertions(+) > Reviewed-by: Simon Glas

Re: [PATCH 2/2] common: board_f: Print information for all sysresets

2022-10-04 Thread Simon Glass
On Sun, 25 Sept 2022 at 07:27, Michal Suchanek wrote: > > Boards can have multiple sysresets, iterate all when printing sysreset > info. > > Also print the symbolic error when reporting sysreset failure. Please no > > Fixes: 23471aed5c ("board_f: Add reset status printing") > Signed-off-by: Mic

Re: [PATCH v3 1/6] net: mvneta: Add support for AlleyCat5

2022-10-04 Thread Ramon Fried
On Wed, Sep 21, 2022 at 8:00 AM Chris Packham wrote: > > Add support for the AlleyCat5 SoC. This lacks the mbus from the other > users of the mvneta.c driver so a new compatible string is needed to > allow for a different window configuration. > > Signed-off-by: Chris Packham > Reviewed-by: Stefa

Re: [PATCH v1] verdin-imx8mm: verdin-imx8mp: drop obsolete net/phy configs

2022-10-04 Thread Ramon Fried
On Wed, Sep 21, 2022 at 2:34 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Drop obsolete networking/PHY related configuration defines. > > Signed-off-by: Marcel Ziswiler > > --- > > include/configs/verdin-imx8mm.h | 3 --- > include/configs/verdin-imx8mp.h | 8 > 2 files chan

Re: [PATCH 1/2] net: ti: cpsw-mdio: Add workaround for errata i2329

2022-10-04 Thread Ramon Fried
On Thu, Sep 22, 2022 at 12:51 PM Ravi Gunasekaran wrote: > > In certain TI SoCs, on the CPSW and ICSS peripherals, there is > a possibility that the MDIO interface returns corrupt data on > MDIO reads or writes incorrect data on MDIO writes. There is also > a possibility for the MDIO interface to

Re: [PATCH 2/2] net: ti: am65-cpsw-nuss: Enable MDIO manual mode

2022-10-04 Thread Ramon Fried
On Thu, Sep 22, 2022 at 12:51 PM Ravi Gunasekaran wrote: > > For the TI SoCs affected by errata i2329, enable MDIO manual > mode by default > > Signed-off-by: Ravi Gunasekaran > --- > drivers/net/ti/am65-cpsw-nuss.c | 23 ++- > 1 file changed, 22 insertions(+), 1 deletion(-)

Re: [PATCH 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-10-04 Thread Ramon Fried
On Fri, Sep 23, 2022 at 12:36 PM Michal Simek wrote: > > Hi, > > On 9/23/22 11:17, Samuel Obuch wrote: > > Hi, I tested both versions to be sure, but the results are as can be > > expected: > > > > 1. both __raw_readl/__raw_writel and readl/writel functions work ok on > > riscv - > > only the or

Re: [PATCH v2 2/3] net: emaclite: fix xemaclite_alignedread/write functions

2022-10-04 Thread Ramon Fried
On Fri, Sep 23, 2022 at 3:31 PM wrote: > > From: Samuel Obuch > > Use __raw_read* and __raw_write* functions to ensure read/write > is passed to the memory-mapped regions, as non-volatile accesses > may get optimised out. > > Signed-off-by: Samuel Obuch > --- > drivers/net/xilinx_emaclite.c | 9

Re: [PATCH v2 3/3] net: emaclite: fix handling for IP packets with specific lengths

2022-10-04 Thread Ramon Fried
On Fri, Sep 23, 2022 at 3:31 PM wrote: > > From: Samuel Obuch > > The maximum length is capped similarly to the emaclite_send function. > Avoid integer underflow for values of ip->ip_len < 30, the minimum > length of an IP packet is 21 bytes. > > Signed-off-by: Samuel Obuch > --- > drivers/net/

Re: [PATCH v3] schemas: Add schema for U-Boot driver model 'phase tags'

2022-10-04 Thread Sean Anderson
On 10/4/22 19:22, Simon Glass wrote: Until recently it has not been possible to add any U-Boot-specific properties to the device tree schema. Now that it is somewhat separated from Linux and people are feeling the enormous pain of the bifurcated schema, it seems like a good time to add this and o

  1   2   >