RE: [PATCH v2 22/45] dm: mmc: Allow sandbox emulator to build without writes

2022-10-16 Thread 정재훈
> -Original Message- > From: Simon Glass [mailto:s...@chromium.org] > Sent: Thursday, October 13, 2022 9:29 PM > To: U-Boot Mailing List > Cc: Tom Rini ; Simon Glass ; Jaehoon > Chung > ; Marek Vasut ; Pavel Herrmann > ; > Peng Fan > Subject: [PATCH v2 22/45] dm: mmc: Allow sandbox

RE: [PATCH v2 21/45] dm: blk: mmc: Tidy up some Makefile rules for SPL

2022-10-16 Thread 정재훈
> -Original Message- > From: Simon Glass [mailto:s...@chromium.org] > Sent: Thursday, October 13, 2022 9:29 PM > To: U-Boot Mailing List > Cc: Tom Rini ; Simon Glass ; Andrew > Scull > ; Heinrich Schuchardt ; Jaehoon Chung > ; Marek Vasut ; Mark Kettenis > ; Pavel > Herrmann ; Peng

Re: [PATCH v3 6/6] test: add test for eficonfig secure boot key management

2022-10-16 Thread Masahisa Kojima
Hi Heinrich, On Sat, 15 Oct 2022 at 13:48, Heinrich Schuchardt wrote: > > On 10/15/22 03:10, Simon Glass wrote: > > Hi Ilias, > > > > On Fri, 14 Oct 2022 at 09:59, Ilias Apalodimas > > wrote: > >> > >> Hi Simon, > >> > >> On Fri, 14 Oct 2022 at 18:56, Simon Glass wrote: > >>> > >>> Hi, > >>> >

Re: [PATCH] riscv: ae350: Check firmware_fdt_addr header

2022-10-16 Thread Leo Liang
Hi Rick, On Thu, Oct 13, 2022 at 01:24:20PM +0800, Rick Chen wrote: > Check firmware_fdt_addr header to see if it is a valid > fdt blob. > > Signed-off-by: Rick Chen > --- > board/AndesTech/ax25-ae350/ax25-ae350.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM! Could you send it

Re: Pull request for efi-2023-01-rc1-3

2022-10-16 Thread Tom Rini
On Sun, Oct 16, 2022 at 02:18:23PM +0200, Heinrich Schuchardt wrote: > The following changes since commit 0e49f5c26caf9972137a474065afd4bdfe5ec062: > > Merge branch '2022-10-12-additional-fixes' (2022-10-12 15:12:42 -0400) > > are available in the Git repository at: > >

Re: [PATCH] riscv: andes_plic.c: use modified IPI scheme

2022-10-16 Thread Rick Chen
> From: Peter Yu-Chien Lin(林宇謙) > Sent: Friday, October 14, 2022 3:00 PM > To: u-boot@lists.denx.de > Cc: Leo Yu-Chi Liang(梁育齊) ; Rick Jian-Zhi Chen(陳建志) > ; Peter Yu-Chien Lin(林宇謙) > Subject: [PATCH] riscv: andes_plic.c: use modified IPI scheme > > The IPI scheme in OpenSBI has been updated to

Re: [PATCH] riscv: qemu: spl: Fix booting Linux kernel with OpenSBI 1.0+

2022-10-16 Thread Rick Chen
> From: Bin Meng > Sent: Monday, October 17, 2022 12:42 AM > To: Rick Jian-Zhi Chen(陳建志) ; Leo Yu-Chi Liang(梁育齊) > ; u-boot@lists.denx.de > Cc: fal...@tinylab.org; Yangjie Zhang > Subject: [PATCH] riscv: qemu: spl: Fix booting Linux kernel with OpenSBI 1.0+ > > Since OpenSBI commit bf3ef53bb7f5

[PATCH 1/1] sandbox: typo Fictionnal

2022-10-16 Thread Heinrich Schuchardt
%s/Fictionnal/Fictional/ Signed-off-by: Heinrich Schuchardt --- board/sandbox/sandbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/sandbox/sandbox.c b/board/sandbox/sandbox.c index ca9a2ca5b1..38cfa0832d 100644 --- a/board/sandbox/sandbox.c +++

Re: [PATCH 6/6] net: tftp: sanitize tftp block size, especially for TX

2022-10-16 Thread Ramon Fried
On Fri, Oct 14, 2022 at 8:44 PM Rasmus Villemoes wrote: > > U-Boot does not support IP fragmentation on TX (and unless > CONFIG_IP_DEFRAG is set, neither on RX). So the blocks we send must > fit in a single ethernet packet. > > Currently, if tftpblocksize is set to something like 5000 and I >

Re: [PATCH 5/6] net: tftp: use IS_ENABLED(CONFIG_NET_TFTP_VARS) instead of #if

2022-10-16 Thread Ramon Fried
On Fri, Oct 14, 2022 at 8:44 PM Rasmus Villemoes wrote: > > Nothing inside this block depends on NET_TFTP_VARS to be set to parse > correctly. Switch to C if() in preparation for adding code before > this (to avoid a declaration-after-statement warning). What's the motivation here ? The #ifdef is

Re: [PATCH 1/6] net: improve check for no IP options

2022-10-16 Thread Ramon Fried
On Fri, Oct 14, 2022 at 8:43 PM Rasmus Villemoes wrote: > > There's no reason we should accept an IP packet with a malformed IHL > field. So ensure that it is exactly 5, not just <= 5. > > Signed-off-by: Rasmus Villemoes > --- > net/net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 2/2] net: dwc_eth_qos: Add support for bulk RX descriptor cleaning

2022-10-16 Thread Ramon Fried
On Sun, Oct 9, 2022 at 6:51 PM Marek Vasut wrote: > > Add new desc_per_cacheline property which lets a platform run RX descriptor > cleanup after every power-of-2 - 1 received packets instead of every packet. > This is useful on platforms where (axi_bus_width EQOS_AXI_WIDTH_n * DMA DSL >

Re: [PATCH 1/2] net: dwc_eth_qos: Split TX and RX DMA rings

2022-10-16 Thread Ramon Fried
On Sun, Oct 9, 2022 at 6:51 PM Marek Vasut wrote: > > Separate TX and RX DMA rings to make their handling slightly clearer. > This is a preparatory patch for bulk RX descriptor flushing. > > Signed-off-by: Marek Vasut > --- > Cc: Joe Hershberger > Cc: Patrice Chotard > Cc: Patrick Delaunay >

Re: [PATCH v2 1/1] k210: fix k210_pll_calc_config()

2022-10-16 Thread Sean Anderson
On 10/16/22 12:12, Heinrich Schuchardt wrote: The k210 driver is selected by sandbox_defconfig. Building the sandbox on 32bit systems fails with: test/dm/k210_pll.c: In function ‘dm_test_k210_pll_calc_config’: include/linux/bitops.h:11:38: warning: left shift count >= width of type

[PATCH] riscv: qemu: spl: Fix booting Linux kernel with OpenSBI 1.0+

2022-10-16 Thread Bin Meng
Since OpenSBI commit bf3ef53bb7f5 ("firmware: Enable FW_PIC by default"), OpenSBI runs directly at the load address without any code movement. This causes the SPL version of QEMU 'virt' U-Boot does not boot Linux kernel anymore. In that case, OpenSBI is loaded and runs at 0x8100, and it

[PATCH v2 1/1] k210: fix k210_pll_calc_config()

2022-10-16 Thread Heinrich Schuchardt
The k210 driver is selected by sandbox_defconfig. Building the sandbox on 32bit systems fails with: test/dm/k210_pll.c: In function ‘dm_test_k210_pll_calc_config’: include/linux/bitops.h:11:38: warning: left shift count >= width of type [-Wshift-count-overflow] 11 | #define BIT(nr)

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Michal Suchánek
Hello, On Sun, Oct 16, 2022 at 05:02:38PM +0200, Heinrich Schuchardt wrote: > > > On 10/16/22 16:57, Sean Anderson wrote: > > On 10/16/22 10:50, Heinrich Schuchardt wrote: > > > > > > > > > On 10/16/22 16:48, Sean Anderson wrote: > > > > On 10/16/22 10:40, Heinrich Schuchardt wrote: > > > > >

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 16:57, Sean Anderson wrote: On 10/16/22 10:50, Heinrich Schuchardt wrote: On 10/16/22 16:48, Sean Anderson wrote: On 10/16/22 10:40, Heinrich Schuchardt wrote: On 10/16/22 16:19, Sean Anderson wrote: On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51,

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Sean Anderson
On 10/16/22 10:50, Heinrich Schuchardt wrote: On 10/16/22 16:48, Sean Anderson wrote: On 10/16/22 10:40, Heinrich Schuchardt wrote: On 10/16/22 16:19, Sean Anderson wrote: On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 16:48, Sean Anderson wrote: On 10/16/22 10:40, Heinrich Schuchardt wrote: On 10/16/22 16:19, Sean Anderson wrote: On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: k210

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Sean Anderson
On 10/16/22 10:40, Heinrich Schuchardt wrote: On 10/16/22 16:19, Sean Anderson wrote: On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: k210 is 64bit but the driver and tests are also

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 16:19, Sean Anderson wrote: On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: k210 is 64bit but the driver and tests are also built in sandbox, and that can be built 32bit.

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Sean Anderson
On 10/16/22 07:46, Heinrich Schuchardt wrote: On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: k210 is 64bit but the driver and tests are also built in sandbox, and that can be built 32bit. BIT(32) does not work on 32bit, shift

Re: [PATCH 1/1] k210: fix k210_pll_calc_config()

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 09:10, Heinrich Schuchardt wrote: The k210 driver is selected by sandbox_defconfig. Building the sandbox on 32bit systems fails with: test/dm/k210_pll.c: In function ‘dm_test_k210_pll_calc_config’: include/linux/bitops.h:11:38: warning: left shift count >= width of type

Pull request for efi-2023-01-rc1-3

2022-10-16 Thread Heinrich Schuchardt
The following changes since commit 0e49f5c26caf9972137a474065afd4bdfe5ec062: Merge branch '2022-10-12-additional-fixes' (2022-10-12 15:12:42 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2023-01-rc1-3 for you to fetch

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 09:51, Michal Suchánek wrote: On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: k210 is 64bit but the driver and tests are also built in sandbox, and that can be built 32bit. BIT(32) does not work on 32bit, shift before subtraction to fit into 32bit integer with

Re: [EXT] [REGRESSION]: v2022.07: SHA256 hash is broken on imx8m series with CAAM enabled

2022-10-16 Thread Fabio Estevam
Hi Andrey, On Sun, Oct 16, 2022 at 7:17 AM ZHIZHIKIN Andrey wrote: > Yes, but this was not picked up... At least, I do not see it applied on the > master. > > From the entire series [1], the patch that shall solve the issue is [2], and > it is > the one I do not see applied onto master.

RE: [EXT] [REGRESSION]: v2022.07: SHA256 hash is broken on imx8m series with CAAM enabled

2022-10-16 Thread ZHIZHIKIN Andrey
Hello Fabio, > -Original Message- > From: U-Boot On Behalf Of Fabio Estevam > Sent: Friday, October 14, 2022 9:38 PM > To: ZHIZHIKIN Andrey > Cc: Rasmus Villemoes ; Peng Fan > ; Gaurav Jain ; > u-boot@lists.denx.de; > feste...@denx.de; sba...@denx.de; Michael Walle ; Tommaso > Merciai

Re: [PATCH v2 2/5] Makefile: Correct a missing FORCE on the binman rule

2022-10-16 Thread Pali Rohár
On Tuesday 11 October 2022 23:35:22 Masahiro Yamada wrote: > On Tue, Oct 11, 2022 at 11:16 PM Simon Glass wrote: > > > > This is required for if_changed to work correctly. Add it. > > > > Signed-off-by: Simon Glass > > Reviewed-by: Pali Rohár > > --- > > > > (no changes since v1) > > > >

Re: [RFC 1/1] tools: Dockerfile for armv7

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 09:43, Heinrich Schuchardt wrote: Provide an armv7 docker environment to build and test the sandbox. Signed-off-by: Heinrich Schuchardt --- I have been discussing with Simon, if we can test sandbox_defconfig build on arm in a docker container. This RFC is just a small step on the

Re: [PATCH v2] efi_loader: remove efi_delete_handle on loadfile2

2022-10-16 Thread Heinrich Schuchardt
On 10/16/22 10:36, Ilias Apalodimas wrote: Loadfile2 code is installing two protocols on it's own handle and uses efi_delete_handle() to clean it up on failure(s). However commit 05c4c9e21ae6 ("efi_loader: define internal implementations of install/uninstallmultiple") prepares the ground for

Re: [PATCH] efi_loader: remove efi_delete_handle on loadfile2

2022-10-16 Thread Ilias Apalodimas
Hi Heinrich, [...] > > -void efi_initrd_deregister(void) > > +efi_status_t efi_initrd_deregister(void) > > { > > + efi_status_t ret; > > + > > if (!efi_initrd_handle) > > - return; > > + return EFI_SUCCESS; > > > > - efi_delete_handle(efi_initrd_handle); > > +

[PATCH v2] efi_loader: remove efi_delete_handle on loadfile2

2022-10-16 Thread Ilias Apalodimas
Loadfile2 code is installing two protocols on it's own handle and uses efi_delete_handle() to clean it up on failure(s). However commit 05c4c9e21ae6 ("efi_loader: define internal implementations of install/uninstallmultiple") prepares the ground for us to clean up efi_elete_handle() used in

Re: [PATCH] clk: k210: Fix error calculation on 32bit

2022-10-16 Thread Michal Suchánek
On Thu, Oct 13, 2022 at 10:34:29PM +0200, Michal Suchanek wrote: > k210 is 64bit but the driver and tests are also built in sandbox, and > that can be built 32bit. > > BIT(32) does not work on 32bit, shift before subtraction to fit into > 32bit integer with BIT values. Also see

Re: [PATCH] efi_loader: remove efi_delete_handle on loadfile2

2022-10-16 Thread Heinrich Schuchardt
On 10/15/22 23:35, Ilias Apalodimas wrote: Loadfile2 code is installing two protocols on it's own handle and uses efi_delete_handle() to clean it up on failure(s). However commit 05c4c9e21ae6 ("efi_loader: define internal implementations of install/uninstallmultiple") prepares the ground

[RFC 1/1] tools: Dockerfile for armv7

2022-10-16 Thread Heinrich Schuchardt
Provide an armv7 docker environment to build and test the sandbox. Signed-off-by: Heinrich Schuchardt --- I have been discussing with Simon, if we can test sandbox_defconfig build on arm in a docker container. This RFC is just a small step on the path to it. --- tools/docker.arm/Dockerfile |

Re: [PATCH 1/1] sandbox: make sandbox system reset configurable

2022-10-16 Thread Heinrich Schuchardt
On 10/15/22 14:04, Michal Suchánek wrote: Hello, On Sat, Oct 15, 2022 at 10:39:19AM +0200, Heinrich Schuchardt wrote: To test the watchdog system reset we need to disable the default sandbox system reset. The following settings provide the reset command via watchdog on the sandbox:

[PATCH 1/1] k210: fix k210_pll_calc_config()

2022-10-16 Thread Heinrich Schuchardt
The k210 driver is selected by sandbox_defconfig. Building the sandbox on 32bit systems fails with: test/dm/k210_pll.c: In function ‘dm_test_k210_pll_calc_config’: include/linux/bitops.h:11:38: warning: left shift count >= width of type [-Wshift-count-overflow] 11 | #define BIT(nr)