Re: [PATCH 1/1] efi_loader: fix handling of DHCP acknowledge

2022-11-29 Thread Heinrich Schuchardt
On 11/30/22 08:37, Ilias Apalodimas wrote: Hi Heinrich, On Sat, Nov 26, 2022 at 05:10:56PM +0100, Heinrich Schuchardt wrote: The dhcp command may be executed after the first UEFI command. We should still update the EFI_PXE_BASE_CODE_PROTOCOL. Don't leak content of prior acknowledge

Re: [PATCH 1/1] efi_loader: fix handling of DHCP acknowledge

2022-11-29 Thread Ilias Apalodimas
Hi Heinrich, On Sat, Nov 26, 2022 at 05:10:56PM +0100, Heinrich Schuchardt wrote: > The dhcp command may be executed after the first UEFI command. > We should still update the EFI_PXE_BASE_CODE_PROTOCOL. > > Don't leak content of prior acknowledge packages. > > Handle out of memory. > The

Re: [PATCH 1/1] efi_loader: don't use EFI_LOADER_DATA internally

2022-11-29 Thread Ilias Apalodimas
On Tue, Nov 29, 2022 at 06:35:40PM +0100, Heinrich Schuchardt wrote: > On 11/29/22 16:38, Ilias Apalodimas wrote: > > Hi Heinrich, > > > > On Tue, 29 Nov 2022 at 17:04, Heinrich Schuchardt > > wrote: > > > > > > Memory allocated by U-Boot for internal usage should be > > >

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-29 Thread Neha Malcom Francis
Hi Tom On 29/11/22 19:01, Tom Rini wrote: On Tue, Nov 29, 2022 at 03:10:12PM +0300, Matwey V. Kornilov wrote: вт, 29 нояб. 2022 г. в 09:50, Neha Malcom Francis : EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out whether addressing is 1-byte or 2-byte. There are currently

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-29 Thread Neha Malcom Francis
Hi Matwey On 29/11/22 17:40, Matwey V. Kornilov wrote: вт, 29 нояб. 2022 г. в 09:50, Neha Malcom Francis : EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out whether addressing is 1-byte or 2-byte. There are currently different behaviours seen across boards as documented in

Re: [TF-A] [RFC] Proposed location to host the firmware handoff specification.

2022-11-29 Thread Julius Werner
Okay, FWIW I created a pull request with my suggestions here: https://github.com/FirmwareHandoff/firmware_handoff/pull/4 That should make it easier to discuss specific details, hopefully. As I was looking at the header size and format more closely I noticed that the checksum calculation and some

Re: [PATCH] usb: gadget: dfu: Fix the unchecked length field

2022-11-29 Thread Sultan Khan
Almost, but not quite. USB_DIR_IN is 0x80, USB_DIR_OUT is just 0, so testing (ctrl->bRequestType & USB_DIR_OUT) is meaningless. Instead, the test for an OUT transfer should be !(ctrl->bRequestType & USB_DIR_IN). Sultan > On Nov 29, 2022, at 6:05 PM, Fabio Estevam wrote: > > Hi Sultan, > >

Re: [TF-A] [RFC] Proposed location to host the firmware handoff specification.

2022-11-29 Thread Simon Glass
Hi, On Wed, 30 Nov 2022 at 14:52, Julius Werner wrote: > > Hi Jose, > > Apologies for the late response, I had to find some time to dig back > into this topic first. > > > The proposal is that the tag assignments are handled via a PR to [1]. > > A PR should provide reasoning for the proposed

Re: [TF-A] [RFC] Proposed location to host the firmware handoff specification.

2022-11-29 Thread Julius Werner
Hi Jose, Apologies for the late response, I had to find some time to dig back into this topic first. > The proposal is that the tag assignments are handled via a PR to [1]. > A PR should provide reasoning for the proposed entry layout as well as a > description of the use-case being serviced. >

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-29 Thread Tim Harvey
On Tue, Nov 29, 2022 at 4:11 PM Vladimir Oltean wrote: > > On Tue, Nov 29, 2022 at 02:53:15PM -0800, Tim Harvey wrote: > > On Mon, Nov 28, 2022 at 7:58 AM Tom Rini wrote: > > > > > > On Thu, Oct 27, 2022 at 05:49:33PM -0700, Tim Harvey wrote: > > > > > > > Allow rcv() and xmit() dsa driver ops

Re: [PATCH] riscv: use imply instead of select for SPL_SEPARATE_BSS

2022-11-29 Thread Rick Chen
> From: Zong Li > Sent: Tuesday, November 29, 2022 10:02 AM > To: Sean Anderson > Cc: s...@chromium.org; michal.si...@amd.com; sean.ander...@seco.com; Leo > Yu-Chi Liang(梁育齊) ; Rick Jian-Zhi Chen(陳建志) > ; u-boot@lists.denx.de > Subject: Re: [PATCH] riscv: use imply instead of select for

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-29 Thread Vladimir Oltean
On Tue, Nov 29, 2022 at 02:53:15PM -0800, Tim Harvey wrote: > On Mon, Nov 28, 2022 at 7:58 AM Tom Rini wrote: > > > > On Thu, Oct 27, 2022 at 05:49:33PM -0700, Tim Harvey wrote: > > > > > Allow rcv() and xmit() dsa driver ops to be optional in case a driver > > > does not care to mangle a packet

Re: [PATCH v4] schemas: Add schema for U-Boot driver model 'phase tags'

2022-11-29 Thread Simon Glass
Hi Rob, ping for any comments? - Simon On Wed, 23 Nov 2022 at 12:59, Simon Glass wrote: > > Hi Rob, > > On Tue, 15 Nov 2022 at 14:56, Simon Glass wrote: > > > > Hi Rob, > > > > On Mon, 14 Nov 2022 at 10:44, Rob Herring wrote: > > > > > > +Ilias, Bill and Joakim > > > > > > On Sat, Nov 12,

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-29 Thread Tom Rini
On Tue, Nov 29, 2022 at 02:53:15PM -0800, Tim Harvey wrote: > On Mon, Nov 28, 2022 at 7:58 AM Tom Rini wrote: > > > > On Thu, Oct 27, 2022 at 05:49:33PM -0700, Tim Harvey wrote: > > > > > Allow rcv() and xmit() dsa driver ops to be optional in case a driver > > > does not care to mangle a packet

Re: [PATCH] usb: gadget: dfu: Fix the unchecked length field

2022-11-29 Thread Fabio Estevam
Hi Sultan, On Tue, Nov 29, 2022 at 4:49 PM Sultan Khan wrote: > > While I haven't yet gotten around to trying DFU with this patch applied, my > guess as to the issue would be the checks of the form "if (ctrl-> > bRequestType == USB_DIR_OUT)" or "if (ctrl->bRequestType == USB_DIR_IN)". > The

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-29 Thread Tim Harvey
On Mon, Nov 28, 2022 at 7:58 AM Tom Rini wrote: > > On Thu, Oct 27, 2022 at 05:49:33PM -0700, Tim Harvey wrote: > > > Allow rcv() and xmit() dsa driver ops to be optional in case a driver > > does not care to mangle a packet as in U-Boot only one network port is > > enabled at a time and thus no

Re: [PATCH] usb: gadget: dfu: Fix the unchecked length field

2022-11-29 Thread Marek Vasut
On 11/29/22 20:49, Sultan Khan wrote: While I haven't yet gotten around to trying DFU with this patch applied, my guess as to the issue would be the checks of the form "if (ctrl-> bRequestType == USB_DIR_OUT)" or "if (ctrl->bRequestType == USB_DIR_IN)". The bRequestType field contains many flag

Re: [PATCH] usb: gadget: dfu: Fix the unchecked length field

2022-11-29 Thread Sultan Khan
While I haven't yet gotten around to trying DFU with this patch applied, my guess as to the issue would be the checks of the form "if (ctrl-> bRequestType == USB_DIR_OUT)" or "if (ctrl->bRequestType == USB_DIR_IN)". The bRequestType field contains many flag bits other than the direction bit. The

[PATCH] configs: set CONFIG_LMB_MAX_REGIONS=64 for all mt798[16] boards

2022-11-29 Thread Daniel Golle
With recently added wireless offloading features in Linux [1] the number of reserved memory regions with MediaTek SoCs supporting offloading wireless-to-Ethernet traffic grew beyond the default (8) which breaks booting Linux: ERROR: Failed to allocate 0xa6ac bytes below 0xc000. device tree -

Re: [PATCH 1/1] efi_loader: don't use EFI_LOADER_DATA internally

2022-11-29 Thread Heinrich Schuchardt
On 11/29/22 16:38, Ilias Apalodimas wrote: Hi Heinrich, On Tue, 29 Nov 2022 at 17:04, Heinrich Schuchardt wrote: Memory allocated by U-Boot for internal usage should be EFI_BOOT_SERVICES_DATA or _CODE or EFI_RUNTIME_SERVICES_DATA or _CODE. Agreed, EFI_LOADER_DATA should be for EFI apps.

Re: [u-boot][PATCH 05/14] mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based correction

2022-11-29 Thread Tom Rini
On Tue, Nov 29, 2022 at 04:25:13PM +0100, Dario Binacchi wrote: > Hi Roger, > > On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: > > > > The BCH detection hardware can generate ECC bytes for multiple > > sectors in one go. Use that feature. > > > > correct() only corrects one sector at a

Re: [PATCH 1/1] efi_loader: don't use EFI_LOADER_DATA internally

2022-11-29 Thread François-Frédéric Ozog
Reviewed-by: François-Frédéric Ozog I confirm the patch addresses the issue Le 29/11/2022 16:04, « Heinrich Schuchardt » a écrit : Memory allocated by U-Boot for internal usage should be EFI_BOOT_SERVICES_DATA or _CODE or EFI_RUNTIME_SERVICES_DATA or _CODE. Reported-by:

Re: [PATCH 1/1] efi_loader: don't use EFI_LOADER_DATA internally

2022-11-29 Thread Ilias Apalodimas
Hi Heinrich, On Tue, 29 Nov 2022 at 17:04, Heinrich Schuchardt wrote: > > Memory allocated by U-Boot for internal usage should be > EFI_BOOT_SERVICES_DATA or _CODE or EFI_RUNTIME_SERVICES_DATA or _CODE. Agreed, EFI_LOADER_DATA should be for EFI apps. > > Reported-by: François-Frédéric Ozog >

Re: [u-boot][PATCH 05/14] mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based correction

2022-11-29 Thread Dario Binacchi
Hi Roger, On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: > > The BCH detection hardware can generate ECC bytes for multiple > sectors in one go. Use that feature. > > correct() only corrects one sector at a time so we need to call it > repeatedly for each sector. > > Signed-off-by: Roger

[PATCH] arm64: zynqmp: Do not enable IPI by default

2022-11-29 Thread Michal Simek
ZynqMP mini configurations are not using IPI driver and enabling this is adding additional ~1200 Bytes (depends on configuration). This ends up in situation that there is no enough space in OCM for relocation that's why disable this driver for all mini configurations. Signed-off-by: Michal Simek

[PATCH 1/1] efi_loader: don't use EFI_LOADER_DATA internally

2022-11-29 Thread Heinrich Schuchardt
Memory allocated by U-Boot for internal usage should be EFI_BOOT_SERVICES_DATA or _CODE or EFI_RUNTIME_SERVICES_DATA or _CODE. Reported-by: François-Frédéric Ozog Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 2 +- lib/efi_loader/efi_memory.c | 4 ++-- 2 files changed, 3

Re: [PATCH v4 00/17] IPv6 support

2022-11-29 Thread Vyacheslav Mitrofanov V
I'll fix it soon and send new patchset! Thanks! От: Tom Rini Отправлено: 29 ноября 2022 г. 16:49:48 Кому: Vyacheslav Mitrofanov V Копия: rfried@gmail.com; joe.hershber...@ni.com; w...@denx.de; u-boot@lists.denx.de; judge.pack...@gmail.com; li...@yadro.com;

Re: [PATCH v4 00/17] IPv6 support

2022-11-29 Thread Tom Rini
On Tue, Nov 29, 2022 at 08:39:36AM +, Vyacheslav Mitrofanov V wrote: > Tom, maybe it is better to change configs add ifdefs or do sth else to > exclude them from the build if IPV6 is not configured? There's two parts to this, yes. Sandbox needs to enable ipv6 so that the tests are run, and

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-29 Thread Tom Rini
On Tue, Nov 29, 2022 at 03:10:12PM +0300, Matwey V. Kornilov wrote: > вт, 29 нояб. 2022 г. в 09:50, Neha Malcom Francis : > > > > EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out > > whether addressing is 1-byte or 2-byte. There are currently different > > behaviours seen across

Re: [u-boot][PATCH 06/14] mtd: rawnand: nand_base: Allow base driver to be used in SPL without nand_bbt

2022-11-29 Thread Roger Quadros
Hi Michael, On 28/11/2022 16:27, Michael Nazzareno Trimarchi wrote: > Hi > > On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: >> >> nand_bbt.c is not being built with the nand_base driver during SPL >> build. This results in build failures if we try to access any nand_bbt >> related

[PATCH] ARM: zynq: Add missing twd timer for mini configurations

2022-11-29 Thread Michal Simek
The commit b7e0750d8872 ("zynq: Convert arm twd timer to DM driver") switched timer to DM but missing to add nodes to all mini configurations. Based on it missing timer end up in non functional system where any delay doesn't work. Signed-off-by: Michal Simek --- arch/arm/dts/zynq-cse-nand.dts

[PATCH v4 5/5] rockchip: add support for PX30 Ringneck SoM on Haikou Devkit

2022-11-29 Thread Quentin Schulz
From: Quentin Schulz The PX30-µQ7 (Ringneck) is a system-on-module featuring the Rockchip PX30 in a micro Qseven-compatible form-factor. PX30-µQ7 features: * CPU: quad-core Cortex-A35 * DRAM: 2GB dual-channel * eMMC: onboard eMMC * SD/MMC * TI DP83825I

[PATCH v4 4/5] arm64: dts: rockchip: sync px30 DTSI with Linux kernel next-20221114

2022-11-29 Thread Quentin Schulz
From: Quentin Schulz Sync the px30 dtsi from Linux kernel next-20221114. Cc: Quentin Schulz Reviewed-by: Kever Yang Signed-off-by: Quentin Schulz --- arch/arm/dts/px30.dtsi | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git

[PATCH v4 3/5] rockchip: px30: insert u-boot, spl-boot-device into U-Boot device tree

2022-11-29 Thread Quentin Schulz
From: Quentin Schulz It is possible to boot U-Boot proper from a different storage medium than the one used by the BOOTROM to load the SPL. This information is stored in the u-boot,spl-boot-device Device Tree property and is accessible from U-Boot proper so that it has knowledge at runtime where

[PATCH v4 2/5] rockchip: px30: list possible SPL boot devices

2022-11-29 Thread Quentin Schulz
From: Quentin Schulz BOOTROM sets a bit in a CPU register so that the software can know from where the first stage bootloader was booted. One use case for this is to specify the default loading medium for U-Boot proper to match the one used by the BOOTROM to load the SPL (same-as-spl in

[PATCH v4 1/5] rockchip: px30: fix CONFIG_IRAM_BASE

2022-11-29 Thread Quentin Schulz
From: Quentin Schulz The IRAM on PX30 (or Int_MEM in datasheet) starts at 0xff0e and not 0xff02 as rightfully stated in the FIXME comment. Let's fix it so that BROM_BOOTSOURCE_ID_ADDR points to the correct address for PX30. Fixes: 46281a76bee3 ("rockchip: add core px30 headers") Cc:

[PATCH v4 0/5] add support for Theobroma Systems PX30-µQ7 (Ringneck) with Haikou devkit

2022-11-29 Thread Quentin Schulz
From: Quentin Schulz The PX30-uQ7 (Ringneck) SoM is a µQseven-compatible (40mmx70mm, MXM-230 connector) system-on-module from Theobroma Systems[1], featuring the Rockchip PX30. It provides the following feature set: * up to 4GB DDR4 * up to 128GB on-module eMMC (with 8-bit 1.8V interface) * SD

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-29 Thread Matwey V. Kornilov
вт, 29 нояб. 2022 г. в 09:50, Neha Malcom Francis : > > EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out > whether addressing is 1-byte or 2-byte. There are currently different > behaviours seen across boards as documented in commit bf6376642fe8 > ("board: ti: common:

[PATCH] spi: cadence-qspi: Remove condition for calling enable linear mode

2022-11-29 Thread Ashok Reddy Soma
cadence_qspi_apb_enable_linear_mode() has a weak function defined, so no need to gaurd this under if (CONFIG_IS_ENABLED(ARCH_VERSAL)). In cadence_qspi_apb_write_execute(), enable linear mode is called twice by mistake, remove extra one. Signed-off-by: Ashok Reddy Soma ---

Re: [PATCH 01/17] android: boot: rename andr_img_hdr -> andr_boot_img_hdr_v0_v1_v2

2022-11-29 Thread Safae Ouajih
On Mon, 28 Nov 2022 11:08:20 -0500 Sean Anderson wrote: > On 11/26/22 11:59, Safae Ouajih wrote: > > [You don't often get email from soua...@baylibre.com. Learn why this is > > important at https://aka.ms/LearnAboutSenderIdentification ] > > > > Android introduced boot header version 3 or 4. >

[PATCH] arm64: versal-net: Enable defconfig for Micron octal flashes

2022-11-29 Thread Michal Simek
From: Ashok Reddy Soma Micron mt35 series octal flashes are under config option CONFIG_SPI_FLASH_MT35XU. Enable it in default defconfig for octal flashes to be detected. Signed-off-by: Ashok Reddy Soma Signed-off-by: Michal Simek --- configs/xilinx_versal_net_virt_defconfig | 1 + 1 file

Re: [PATCH v2 3/5] efi_loader: utility function to check the variable name is "Boot####"

2022-11-29 Thread Masahisa Kojima
Hi Ilias, On Tue, 29 Nov 2022 at 16:33, Ilias Apalodimas wrote: > > On Mon, Nov 28, 2022 at 09:45:07PM +0900, Masahisa Kojima wrote: > > Some commands need to enumerate the existing UEFI load > > option variable("Boot"). This commit transfers some code > > from cmd/efidebug.c to

Re: [v1] spl: nand: allow partial nand page reads during nand_spl_load_image

2022-11-29 Thread Dario Binacchi
Hi Colinn On Fri, Nov 18, 2022 at 1:08 PM Dario Binacchi wrote: > > Hi Colin, > > On Tue, Nov 15, 2022 at 5:35 PM Colin Foster > wrote: > > > > The nand_spl_load_image function was guaranteed to read an entire block > > into RAM, regardless of how many bytes were to be read. This is > >

Re: [PATCH] serial: ns16550: Enable clocks during probe

2022-11-29 Thread Stefan Roese
On 11/28/22 06:48, Samuel Holland wrote: If the UART bus or baud clock has a gate, it must be enabled before the UART can be used. Signed-off-by: Samuel Holland --- drivers/serial/ns16550.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/serial/ns16550.c

Re: [PATCH v4 00/17] IPv6 support

2022-11-29 Thread Vyacheslav Mitrofanov V
Tom, maybe it is better to change configs add ifdefs or do sth else to exclude them from the build if IPV6 is not configured? Thanks! От: Vyacheslav Mitrofanov V Отправлено: 29 ноября 2022 г. 11:35:13 Кому: Tom Rini Копия: rfried@gmail.com;

Re: [PATCH v4 00/17] IPv6 support

2022-11-29 Thread Vyacheslav Mitrofanov V
Hello Tom! I tested this problem and I think it is necessary to set CONFIG_IPV6. Without that option tests fail. Thanks! От: Tom Rini Отправлено: 28 ноября 2022 г. 18:34:58 Кому: Vyacheslav Mitrofanov V Копия: rfried@gmail.com; joe.hershber...@ni.com;