Re: [PATCH 1/1] efi_loader: fix handling of DHCP acknowledge

2022-11-30 Thread Ilias Apalodimas
Hi Henrich On Wed, 30 Nov 2022 at 14:45, Heinrich Schuchardt wrote: > > On 11/30/22 09:44, Ilias Apalodimas wrote: > > On Wed, Nov 30, 2022 at 08:50:07AM +0100, Heinrich Schuchardt wrote: > >> > >> > >> On 11/30/22 08:37, Ilias Apalodimas wrote: > >>> Hi Heinrich, > >>> > >>> On Sat, Nov 26,

Re: [PATCH 1/1] doc: board: typo GIUD Microchip MPFS Icicle Kit doc

2022-11-30 Thread Bin Meng
On Thu, Dec 1, 2022 at 1:03 AM Heinrich Schuchardt wrote: > > %s/GIUD/GUID/ > > Fixes: 9e550e18305f ("doc: board: Add Microchip MPFS Icicle Kit doc") > Signed-off-by: Heinrich Schuchardt > --- > doc/board/microchip/mpfs_icicle.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

unsubscribe

2022-11-30 Thread Chan Kim

Re: [PATCH 1/1] configs: imx8mp_evk: revert to old ram settings

2022-11-30 Thread Fabio Estevam
On Mon, Nov 28, 2022 at 8:45 AM Manoj Sai wrote: > > The 'commit 864ac2cf383e ("board: imx8mp: Add Engicam > i.Core MX8M Plus EDIMM2.2 Starter Kit")' has changed the imx8mp evk ram > settings from 6GB ram to 2GB. > > This changeset reverts the above change. > > Signed-off-by: Manoj Sai >

Re: [PATCH 1/1] configs: imx8mp_evk: revert to old ram settings

2022-11-30 Thread Peng Fan
On 11/28/2022 7:45 PM, Manoj Sai wrote: The 'commit 864ac2cf383e ("board: imx8mp: Add Engicam i.Core MX8M Plus EDIMM2.2 Starter Kit")' has changed the imx8mp evk ram settings from 6GB ram to 2GB. This changeset reverts the above change. Signed-off-by: Manoj Sai Reported-by : Peter Bergin

Re: [PATCH v9 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-11-30 Thread Vladimir Oltean
On Wed, Nov 30, 2022 at 03:27:04PM -0800, Tim Harvey wrote: > That's the same head that I based them off of and I just did the > following and it worked fine: > cd /tmp > git clone git://git.denx.de/u-boot.git > cd u-boot > wget https://patchwork.ozlabs.org/series/330704/mbox/ -O mbox > git am

Re: [PATCH v9 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-11-30 Thread Tim Harvey
On Wed, Nov 30, 2022 at 2:30 PM Vladimir Oltean wrote: > > On Wed, Nov 30, 2022 at 09:42:43AM -0800, Tim Harvey wrote: > > This series adds a DSA driver for the MV88E6xxx based on > > drivers/net/phy/mv88e61xx and uses it in the gwventana_gw5904_defconfig. > > I can't apply the patches on the

Re: [PATCH v9 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-11-30 Thread Vladimir Oltean
On Wed, Nov 30, 2022 at 09:42:43AM -0800, Tim Harvey wrote: > This series adds a DSA driver for the MV88E6xxx based on > drivers/net/phy/mv88e61xx and uses it in the gwventana_gw5904_defconfig. I can't apply the patches on the current master, am I doing something wrong? $ git reset --hard

Re: [PATCH] dfu: Call backend specific dfu_fill_*() only if enabled

2022-11-30 Thread Marek Vasut
On 11/30/22 11:44, Patrick DELAUNAY wrote: Hi Marek, On 11/28/22 20:39, Marek Vasut wrote: The dfu_fill_*() functions are available only if the matching backend is enabled. Add missing CONFIG_IS_ENABLED() guard for each backend to prevent build errors, in case such a backend is enabled in

Re: [PATCH] usb: gadget: dfu: Fix check of transfer direction

2022-11-30 Thread Sultan Khan
Reviewed-by: Sultan Qasim Khan On Wed, Nov 30, 2022 at 2:02 PM Fabio Estevam wrote: > On Wed, Nov 30, 2022 at 3:55 PM wrote: > > > > From: Hugo SIMELIERE > > > > Commit fbce985e28eaca3af82afecc11961aadaf971a7e to fix CVE-2022-2347 > > blocks DFU usb requests. > > The verification of the

Re: [PATCH] usb: gadget: dfu: Fix check of transfer direction

2022-11-30 Thread Fabio Estevam
On Wed, Nov 30, 2022 at 3:55 PM wrote: > > From: Hugo SIMELIERE > > Commit fbce985e28eaca3af82afecc11961aadaf971a7e to fix CVE-2022-2347 > blocks DFU usb requests. > The verification of the transfer direction was done by an equality > but it is a bit mask. > > Signed-off-by: Hugo SIMELIERE

Re: [PATCH] usb: gadget: dfu: Fix check of transfer direction

2022-11-30 Thread Fabio Estevam
Adding Marek and Sultan On Wed, Nov 30, 2022 at 3:55 PM wrote: > > From: Hugo SIMELIERE > > Commit fbce985e28eaca3af82afecc11961aadaf971a7e to fix CVE-2022-2347 > blocks DFU usb requests. > The verification of the transfer direction was done by an equality > but it is a bit mask. > >

[PATCH 1/1] mvebu: fix end-of-array check

2022-11-30 Thread Derek LaHousse
Properly seek the end of default_environment variables. The current algorithm overwrites from the second variable. This replacement finds the end of the array of strings. Stomped variables include "board", "soc", "loadaddr". These can be seen on a "env default -a" after patch, but they are not

[PATCH] usb: gadget: dfu: Fix check of transfer direction

2022-11-30 Thread hsimeliere . opensource
From: Hugo SIMELIERE Commit fbce985e28eaca3af82afecc11961aadaf971a7e to fix CVE-2022-2347 blocks DFU usb requests. The verification of the transfer direction was done by an equality but it is a bit mask. Signed-off-by: Hugo SIMELIERE --- drivers/usb/gadget/f_dfu.c | 8 1 file

[PATCH v9 7/8] net: add MV88E6xxx DSA driver

2022-11-30 Thread Tim Harvey
Add a DSA driver for the MV88E6xxx compatible Ethernet switches. Cc: Marek Behún Cc: Vladimir Oltean Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v9: - no changes v8: - remove energy-detect low-power mode config v7: - rebase on master - update

[PATCH v9 6/8] net: fec: add support for DM_MDIO

2022-11-30 Thread Tim Harvey
Add support for DM_MDIO by registering a UCLASS_MDIO driver and attempting to use it. This is necessary if wanting to use a DSA driver for example hanging off of the FEC MAC. Care is taken to fallback to non DM_MDIO mii bus as several boards define DM_MDIO without having the proper device-tree

[PATCH v9 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-11-30 Thread Tim Harvey
Add MV88E61XX DSA support: - update dt to provide internal MDIO bus and port handles. U-Boot requires a more restrictive subset of the dt bindings required by Linux for the sake of simplifying code - update defconfig to remove old driver and enable new one - replace mv88e61xx_hw_reset

[PATCH v9 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-30 Thread Tim Harvey
Allow rcv() and xmit() dsa driver ops to be optional in case a driver does not care to mangle a packet as in U-Boot only one network port is enabled at a time and thus no packet mangling is necessary. Suggested-by: Vladimir Oltean Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean

[PATCH v9 3/8] net: dsa: ensure dsa driver has proper ops

2022-11-30 Thread Tim Harvey
Add a function to sanity check a dsa driver having proper ops. Suggested-by: Vladimir Oltean Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v9: - no changes v8: - no changes v7: - no changes v6: - no changes v5: - added Fabio's rb tag v4: - no

[PATCH v9 5/8] net: ksz9477: remove unnecessary xmit and recv functions

2022-11-30 Thread Tim Harvey
Remove the unnecessary xmit and recv functions. Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v9: - no changes v8: - no changes v7: - no changes v6: - no changes v5: - added Fabio's rb tag v4: - no changes v3: - added Vladimir's rb tag v2: new

[PATCH v9 2/8] net: dsa: move cpu port probe to dsa_post_probe

2022-11-30 Thread Tim Harvey
In order to ensure that a DSA driver probe gets called before dsa_ops->port_probe move the port_probe of the cpu_port to a post-probe function. Signed-off-by: Tim Harvey Reviewed-by: Ramon Fried Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v9: - no changes v8: - no changes

[PATCH v9 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-11-30 Thread Tim Harvey
This series adds a DSA driver for the MV88E6xxx based on drivers/net/phy/mv88e61xx and uses it in the gwventana_gw5904_defconfig. The hope is that the other three boards that use the MV88E61xx driver can move to this as well eventually so that we can remove the non-dm driver and the 4 Kconfig

[PATCH v9 1/8] net: mdio-uclass: scan for dm mdio children on post-bind

2022-11-30 Thread Tim Harvey
If a DM_MDIO driver is used we need to scan the subnodes as well. Signed-off-by: Tim Harvey Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried Reviewed-by: Fabio Estevam --- v9: - no changes v8: - no changes v7: - no changes v6: - no changes v5: - added Fabio's rb tag v4: - no

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-30 Thread Tim Harvey
On Wed, Nov 30, 2022 at 9:25 AM Vladimir Oltean wrote: > > On Tue, Nov 29, 2022 at 04:58:33PM -0800, Tim Harvey wrote: > > Yes, it makes sense. How about the following patch instead: > > > > diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c > > index 211a991cdd0d..1ae9adc66eda 100644 > > ---

Re: [PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-11-30 Thread Vladimir Oltean
On Tue, Nov 29, 2022 at 04:58:33PM -0800, Tim Harvey wrote: > Yes, it makes sense. How about the following patch instead: > > diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c > index 211a991cdd0d..1ae9adc66eda 100644 > --- a/net/dsa-uclass.c > +++ b/net/dsa-uclass.c > @@ -142,6 +142,9 @@ static

[PATCH 1/1] doc: board: typo GIUD Microchip MPFS Icicle Kit doc

2022-11-30 Thread Heinrich Schuchardt
%s/GIUD/GUID/ Fixes: 9e550e18305f ("doc: board: Add Microchip MPFS Icicle Kit doc") Signed-off-by: Heinrich Schuchardt --- doc/board/microchip/mpfs_icicle.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/board/microchip/mpfs_icicle.rst

[PATCH] net: eth-uclass: change state before stop() in eth_halt()

2022-11-30 Thread Niel Fourie
In eth_halt(), change the private uclass state before calling stop() instead of afterwards, to avoid writing to memory which may have been freed during stop(). In the ethernet gadget implementation, the gadget device gets probed during start() and removed during stop(), which includes freeing

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-30 Thread Tom Rini
On Wed, Nov 30, 2022 at 06:38:43PM +0300, Matwey V. Kornilov wrote: > ср, 30 нояб. 2022 г. в 18:36, Robert Nelson : > > > > > >>> Tested on J721E, J7200, DRA7xx, AM64x > > > >> > > > >> I'll try to test this on the AM335x boards I have as soon as possible. > > > > > > > > I wonder if we should

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-30 Thread Matwey V. Kornilov
ср, 30 нояб. 2022 г. в 18:36, Robert Nelson : > > > >>> Tested on J721E, J7200, DRA7xx, AM64x > > >> > > >> I'll try to test this on the AM335x boards I have as soon as possible. > > > > > > I wonder if we should re-factor this code a bit and not have a single > > > ti_i2c_eeprom_get but instead

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-30 Thread Robert Nelson
> >>> Tested on J721E, J7200, DRA7xx, AM64x > >> > >> I'll try to test this on the AM335x boards I have as soon as possible. > > > > I wonder if we should re-factor this code a bit and not have a single > > ti_i2c_eeprom_get but instead build for whichever sets of quirks a given > > family of

Re: [PATCH] board_init: Convert CONFIG_MALLOC_F_ADDR to Kconfig

2022-11-30 Thread Tom Rini
On Sun, Nov 13, 2022 at 08:39:36PM +0100, Marek Vasut wrote: > On 9/1/22 23:18, Tom Rini wrote: > > On Sat, Jul 09, 2022 at 03:08:04AM +0200, Marek Vasut wrote: > > > > > Convert CONFIG_MALLOC_F_ADDR to Kconfig. > > > > > > The CL IoT gate board used MALLOC_F_ADDR 0x912000 on i.MX8M Mini unlike

Re: [PATCH] MAINTAINERS: add RaspberryPi co-maintainer

2022-11-30 Thread Tom Rini
On Wed, Nov 30, 2022 at 02:21:31PM +, Peter Robinson wrote: > On Wed, Nov 30, 2022 at 11:57 AM wrote: > > > > From: Matthias Brugger > > > > Peter accpeted to step up as a co-maintainer for the RPis. > > Reflect that in the corresponding MAINTAINERS files. > > > > Signed-off-by: Matthias

Re: [PATCH] MAINTAINERS: add RaspberryPi co-maintainer

2022-11-30 Thread Peter Robinson
On Wed, Nov 30, 2022 at 11:57 AM wrote: > > From: Matthias Brugger > > Peter accpeted to step up as a co-maintainer for the RPis. > Reflect that in the corresponding MAINTAINERS files. > > Signed-off-by: Matthias Brugger Reviewed-by: Peter Robinson I suspect I'll need some setup around

Re: [PATCH 1/1] efi_loader: fix handling of DHCP acknowledge

2022-11-30 Thread Heinrich Schuchardt
On 11/30/22 09:44, Ilias Apalodimas wrote: On Wed, Nov 30, 2022 at 08:50:07AM +0100, Heinrich Schuchardt wrote: On 11/30/22 08:37, Ilias Apalodimas wrote: Hi Heinrich, On Sat, Nov 26, 2022 at 05:10:56PM +0100, Heinrich Schuchardt wrote: The dhcp command may be executed after the first UEFI

Re: [PATCH v2 1/1] efi_loader: don't use EFI_LOADER_DATA internally

2022-11-30 Thread Ilias Apalodimas
Thanks Heinrich On Wed, 30 Nov 2022 at 14:11, Heinrich Schuchardt wrote: > > EFI_LOADER_DATA/CODE is reserved for EFI applications. > Memory allocated by U-Boot for internal usage should be > EFI_BOOT_SERVICES_DATA or _CODE or EFI_RUNTIME_SERVICES_DATA or _CODE. > > Reported-by:

[PATCH v2 1/1] efi_loader: don't use EFI_LOADER_DATA internally

2022-11-30 Thread Heinrich Schuchardt
EFI_LOADER_DATA/CODE is reserved for EFI applications. Memory allocated by U-Boot for internal usage should be EFI_BOOT_SERVICES_DATA or _CODE or EFI_RUNTIME_SERVICES_DATA or _CODE. Reported-by: François-Frédéric Ozog Signed-off-by: Heinrich Schuchardt Reviewed-by: François-Frédéric Ozog ---

[PATCH] MAINTAINERS: add RaspberryPi co-maintainer

2022-11-30 Thread matthias . bgg
From: Matthias Brugger Peter accpeted to step up as a co-maintainer for the RPis. Reflect that in the corresponding MAINTAINERS files. Signed-off-by: Matthias Brugger --- MAINTAINERS | 1 + board/raspberrypi/rpi/MAINTAINERS | 1 + 2 files changed, 2 insertions(+) diff

Re: [PATCH] dfu: Call backend specific dfu_fill_*() only if enabled

2022-11-30 Thread Patrick DELAUNAY
Hi Marek, On 11/28/22 20:39, Marek Vasut wrote: The dfu_fill_*() functions are available only if the matching backend is enabled. Add missing CONFIG_IS_ENABLED() guard for each backend to prevent build errors, in case such a backend is enabled in U-Boot and not in SPL or vice versa.

[PATCH] dfu: Make DFU virtual backend SPL friendly

2022-11-30 Thread Patrick Delaunay
Define stub for dfu_*_virt function in SPL, because CONFIG_SPL_DFU_VIRT is not defined. This patch avoids compilation issue in dfu_fill_entity() when CONFIG_SPL_DFU is activated because the dfu_fill_entity_virt() function is not available. Fixes: ec44cace4b8d2 ("dfu: add DFU virtual backend")

Re: [PATCH] dfu: Call backend specific dfu_fill_*() only if enabled

2022-11-30 Thread Patrice CHOTARD
Hi Marek On 11/28/22 20:39, Marek Vasut wrote: > The dfu_fill_*() functions are available only if the matching backend is > enabled. Add missing CONFIG_IS_ENABLED() guard for each backend to prevent > build errors, in case such a backend is enabled in U-Boot and not in SPL > or vice versa. > >

Re: [PATCH 1/1] efi_loader: fix handling of DHCP acknowledge

2022-11-30 Thread Ilias Apalodimas
On Wed, Nov 30, 2022 at 08:50:07AM +0100, Heinrich Schuchardt wrote: > > > On 11/30/22 08:37, Ilias Apalodimas wrote: > > Hi Heinrich, > > > > On Sat, Nov 26, 2022 at 05:10:56PM +0100, Heinrich Schuchardt wrote: > > > The dhcp command may be executed after the first UEFI command. > > > We

Re: [u-boot][PATCH 05/14] mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based correction

2022-11-30 Thread Dario Binacchi
Hi Tom, On Tue, Nov 29, 2022 at 5:18 PM Tom Rini wrote: > > On Tue, Nov 29, 2022 at 04:25:13PM +0100, Dario Binacchi wrote: > > Hi Roger, > > > > On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: > > > > > > The BCH detection hardware can generate ECC bytes for multiple > > > sectors in one