Re: [PATCH 1/4] ARM: stm32: Fix ECDSA authentication with Dcache enabled

2022-12-05 Thread Patrice CHOTARD
On 12/6/22 03:33, Marek Vasut wrote: > In case Dcache is enabled while the ECDSA authentication function is > called via BootROM ROM API, the CRYP DMA might pick stale version of > data from DRAM. Disable Dcache around the BootROM call to avoid this > issue. > > Signed-off-by: Marek Vasut >

Re: [PATCH 1/3] ARM: stm32: Enable assorted ST specific commands on DHSOM

2022-12-05 Thread Patrice CHOTARD
Hi On 12/6/22 03:35, Marek Vasut wrote: > Enable the stm32prog, stm32key, stboard commands on DHSOM. > Those can be used e.g. to implement verified boot. > > Signed-off-by: Marek Vasut > --- > Cc: Patrice Chotard > Cc: Patrick Delaunay > --- > configs/stm32mp15_dhcom_basic_defconfig | 4

Re: [PATCH 2/3] ARM: stm32: Increment boot counter in SPL on DHSOM

2022-12-05 Thread Patrice CHOTARD
Hi On 12/6/22 03:35, Marek Vasut wrote: > Increment the boot counter already in U-Boot SPL instead of incrementing > it only later in U-Boot proper. This can be used by SPL to boot either of > two U-Boot copies and improve redundancy of software on the platform, e.g. > in case of full A/B update

Re: [PATCH 3/3] ARM: stm32: Increment WDT by default on DHSOM

2022-12-05 Thread Patrice CHOTARD
Hi Marek On 12/6/22 03:35, Marek Vasut wrote: > Enable watchdog timer on the DHSOM by default, both in U-Boot proper and > in SPL. This can be used in combination with boot counter by either SPL > or U-Boot proper to boot either copy of system software, e.g. in case of > full A/B update strategy.

[PATCH] net: ipv6: Fix link-partner MAC address assignment

2022-12-05 Thread Viacheslav Mitrofanov
MAC address of a link-partner is not saved for future use because of bad condition of if statement. Moreover it can potentially cause to NULL-pointer dereference. Signed-off-by: Viacheslav Mitrofanov --- net/ndisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ndisc.c

[PATCH] net: ipv6: Add missing break into IPv6 protocol handler

2022-12-05 Thread Viacheslav Mitrofanov
IPv6 protocol handler is not terminated with a break statment. It can lead to running unexpected code. Signed-off-by: Viacheslav Mitrofanov --- net/net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/net.c b/net/net.c index 1c39acc493..57da9bda85 100644 --- a/net/net.c +++ b/net/net.c

Re: [PATCH v5 04/19] net: ipv6: Add Neighbor Discovery Protocol (NDP)

2022-12-05 Thread Vyacheslav Mitrofanov V
On Tue, 2022-12-06 at 03:14 +0100, Daniel Schwierzeck wrote: > «Внимание! Данное письмо от внешнего адресата!» > > On 12/2/22 10:18, Viacheslav Mitrofanov wrote: > > Implement basic of NDP. It doesn't include such things as Router > > Solicitation, Router Advertisement and Redirect. It just has >

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-05 Thread Stefan Roese
Hi Pali, On 12/5/22 19:18, Pali Rohár wrote: On Monday 05 December 2022 12:42:44 Stefan Roese wrote: Hi! On 12/4/22 11:39, Pali Rohár wrote: Hello! I would suggest to change description of the patch from "mvebu: fix end-of-array check" to something like: "arm: mvebu: Espressobin:

Re: [RFC PATCH 16/17] arm: sunxi: add Allwinner T113s devicetree stub

2022-12-05 Thread Icenowy Zheng
在 2022-12-06星期二的 00:45 +,Andre Przywara写道: > This adds the basic SoC .dtsi devicetree stub for the Allwinner T113s > SoC. This shares a die with the Allwinner D1 SoC (with RISC-V cores), > but uses two Cortex-A7 cores instead of the T-HEAD C906 RISC-V core. > > Include the existing D1

Re: [PATCH] timer: Kconfig: add clint timer support

2022-12-05 Thread Stefan Roese
Hi chenzhipeng, On 12/6/22 04:16, chenzhipeng wrote: add the clint timer device configuration item to Kconfig Signed-off-by: chenzhipeng --- drivers/timer/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/timer/Kconfig b/drivers/timer/Kconfig index

Re: [PATCH v5 3/3] board: qemu-riscv: enable semihosting

2022-12-05 Thread Kautuk Consul
Hi, On Mon, Dec 5, 2022 at 8:46 PM Sean Anderson wrote: > > On 12/5/22 00:51, Kautuk Consul wrote: > > Hi, > > > > On Sat, Dec 3, 2022 at 9:44 AM Bin Meng wrote: > >> > >> On Fri, Sep 23, 2022 at 3:03 PM Kautuk Consul > >> wrote: > >> > > >> > To enable semihosting we also need to enable the

Re: [PATCH v5 09/19] net: ipv6: Incorporate IPv6 support into u-boot net subsystem

2022-12-05 Thread Vyacheslav Mitrofanov V
On Tue, 2022-12-06 at 03:13 +0100, Daniel Schwierzeck wrote: > «Внимание! Данное письмо от внешнего адресата!» > > On 12/2/22 10:18, Viacheslav Mitrofanov wrote: > > Add net_ip6_handler (an IPv6 packet handler) into net_loop. Add > > neighbor discovery mechanism into network init process. That is

Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2022-12-05 Thread Icenowy Zheng
在 2022-12-06星期二的 00:45 +,Andre Przywara写道: > Allwinner seems to typically stick to a common MMIO memory map for > several SoCs, but from time to time does some breaking changes, which > also introduce new generations of some peripherals. The last time > this > happened with the H6, which apart

Re: [TF-A] [RFC] Proposed location to host the firmware handoff specification.

2022-12-05 Thread Julius Werner
It seems like some of us still have very different opinions about how this handoff structure should and shouldn't be used, which I really think need to be worked out and then codified in the spec before we can call the document final, because otherwise no firmware project can trust that it is safe

Re: [PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation

2022-12-05 Thread Kever Yang
Hi Tom, On 2022/12/6 06:25, Tom Rini wrote: On Mon, Dec 05, 2022 at 09:35:41PM +, Peter Robinson wrote: On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek wrote: The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.

Re: [PATCHv2 010/149] rsa-verify: Rework host check for CONFIG_RSA_VERIFY_WITH_PKEY

2022-12-05 Thread AKASHI Takahiro
On Sun, Dec 04, 2022 at 05:37:06PM -0500, Tom Rini wrote: > While we do not want to use CONFIG_RSA_VERIFY_WITH_PKEY on the host, we > cannot undef the symbol in this manner. As this ends up being a test > within another function we can use !tools_build() as a test here. > > Cc: Simon Glass >

Re: [PATCH] Makefile: With BINMAN_ALLOW_MISSING=1 don't error on missing

2022-12-05 Thread Simon Glass
Hi Tom, On Tue, 6 Dec 2022 at 15:03, Tom Rini wrote: > > When the user builds with BINMAN_ALLOW_MISSING=1 they're explicitly > setting the flag to allow for additional binaries to be missing and so > have acknowledged the output might not work. In this case we want to > default to not passing a

[PATCH 3/3] ARM: stm32: Increment WDT by default on DHSOM

2022-12-05 Thread Marek Vasut
Enable watchdog timer on the DHSOM by default, both in U-Boot proper and in SPL. This can be used in combination with boot counter by either SPL or U-Boot proper to boot either copy of system software, e.g. in case of full A/B update strategy. Signed-off-by: Marek Vasut --- Cc: Patrice Chotard

[PATCH 2/3] ARM: stm32: Increment boot counter in SPL on DHSOM

2022-12-05 Thread Marek Vasut
Increment the boot counter already in U-Boot SPL instead of incrementing it only later in U-Boot proper. This can be used by SPL to boot either of two U-Boot copies and improve redundancy of software on the platform, e.g. in case of full A/B update strategy. Signed-off-by: Marek Vasut --- Cc:

[PATCH 1/3] ARM: stm32: Enable assorted ST specific commands on DHSOM

2022-12-05 Thread Marek Vasut
Enable the stm32prog, stm32key, stboard commands on DHSOM. Those can be used e.g. to implement verified boot. Signed-off-by: Marek Vasut --- Cc: Patrice Chotard Cc: Patrick Delaunay --- configs/stm32mp15_dhcom_basic_defconfig | 4 configs/stm32mp15_dhcor_basic_defconfig | 4 2 files

[PATCH 4/4] ARM: stm32: Make ECDSA authentication available to U-Boot

2022-12-05 Thread Marek Vasut
With U-Boot having access to ROM API call table, it is possible to use the ROM API call it authenticate e.g. signed kernel fitImages using the BootROM ECDSA support. Make this available by pulling the ECDSA BootROM call support from SPL-only guard. Signed-off-by: Marek Vasut --- Cc: Alexandru

[PATCH 3/4] ARM: stm32: Pass ROM API table pointer to U-Boot proper

2022-12-05 Thread Marek Vasut
The ROM API table pointer is no longer accessible from U-Boot, fix this by passing the ROM API pointer through. This makes it possible for U-Boot to call ROM API functions to authenticate payload like signed fitImages. Signed-off-by: Marek Vasut --- Cc: Alexandru Gagniuc Cc: Patrice Chotard

[PATCH 2/4] ARM: stm32: Factor out save_boot_params

2022-12-05 Thread Marek Vasut
The STM32MP15xx platform currently comes with two incompatible implementations of save_boot_params() weak function override. Factor the save_boot_params() implementation into common cpu.c code and provide accessors to read out both ROM API table address and DT address from any place in the code

[PATCH 1/4] ARM: stm32: Fix ECDSA authentication with Dcache enabled

2022-12-05 Thread Marek Vasut
In case Dcache is enabled while the ECDSA authentication function is called via BootROM ROM API, the CRYP DMA might pick stale version of data from DRAM. Disable Dcache around the BootROM call to avoid this issue. Signed-off-by: Marek Vasut --- Cc: Alexandru Gagniuc Cc: Patrice Chotard Cc:

Re: [PATCH v5 04/19] net: ipv6: Add Neighbor Discovery Protocol (NDP)

2022-12-05 Thread Daniel Schwierzeck
On 12/2/22 10:18, Viacheslav Mitrofanov wrote: Implement basic of NDP. It doesn't include such things as Router Solicitation, Router Advertisement and Redirect. It just has Neighbor Solicitation and Neighbor Advertisement. Only these two features are used in u-boot IPv6. Implementation of

Re: [PATCH v5 09/19] net: ipv6: Incorporate IPv6 support into u-boot net subsystem

2022-12-05 Thread Daniel Schwierzeck
On 12/2/22 10:18, Viacheslav Mitrofanov wrote: Add net_ip6_handler (an IPv6 packet handler) into net_loop. Add neighbor discovery mechanism into network init process. That is the main step to run IPv6 in u-boot. Now u-boot is capable to use NDP and handle IPv6 packets. Signed-off-by:

Re: [PATCH 01/38] power: pmic: Guard non-DM_PMIC drivers with a check for POWER_LEGACY

2022-12-05 Thread Tom Rini
On Sat, Nov 19, 2022 at 06:45:08PM -0500, Tom Rini wrote: > As we have more legacy PMIC drivers to move to Kconfig, guard them all > with POWER_LEGACY or SPL_POWER_LEGACY. Do the same kind of check for > building the drivers too. This also means that we need to resort the > list slightly in the

Re: [PATCH 01/17] global: Move remaining CONFIG_SYS_NOR_* to CFG_SYS_NOR_*

2022-12-05 Thread Tom Rini
On Wed, Nov 16, 2022 at 01:10:25PM -0500, Tom Rini wrote: > The rest of the unmigrated CONFIG symbols in the CONFIG_SYS_NOR > namespace do not easily transition to Kconfig. In many cases they likely > should come from the device tree instead. Move these out of CONFIG > namespace and in to CFG

Re: [PATCH 01/10] Convert CONFIG_SYS_NAND_DBW_8 et al to Kconfig

2022-12-05 Thread Tom Rini
On Sat, Nov 12, 2022 at 05:36:42PM -0500, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_SYS_NAND_DBW_8 >CONFIG_SYS_NAND_DBW_16 > > Note that all instances of the code check for CONFIG_SYS_NAND_DBW_16 > being defined, and then "else" to CONFIG_SYS_NAND_DBW_8 whereas

[PATCH] Makefile: With BINMAN_ALLOW_MISSING=1 don't error on missing

2022-12-05 Thread Tom Rini
When the user builds with BINMAN_ALLOW_MISSING=1 they're explicitly setting the flag to allow for additional binaries to be missing and so have acknowledged the output might not work. In this case we want to default to not passing a non-zero exit code. Cc: Simon Glass Reported-by: Peter Robinson

PSU initialization code on zynqmp platforms

2022-12-05 Thread Graeme Smecher
Hi Michal, (Well, that's embarassing. Sending again with a useful subject.) I'm bringing up u-boot on a custom zynqmp platform. For the PSU initialization, I can start with the psu_init_gpl.[ch] files embedded in the .xsa generated by Vivado. However, these are pretty flawed [1, 2]. What is

Re: [v1] spl: nand: allow partial nand page reads during nand_spl_load_image

2022-12-05 Thread Colin Foster
On Tue, Nov 29, 2022 at 10:00:19AM +0100, Dario Binacchi wrote: > Hi Colinn > > On Fri, Nov 18, 2022 at 1:08 PM Dario Binacchi > wrote: > > > > Hi Colin, > > > > On Tue, Nov 15, 2022 at 5:35 PM Colin Foster > > wrote: > > > > > > The nand_spl_load_image function was guaranteed to read an entire

[RFC PATCH 17/17] sunxi: add preliminary MangoPi MQ-R board support

2022-12-05 Thread Andre Przywara
This includes a preliminary basic DT and a defconfig to get the board booted. Although there is some DRAM code based on some disassembly, it is not ready yet, so the SPL doesn't really work, and needs some help from awboot. Signed-off-by: Andre Przywara --- arch/arm/dts/Makefile

[RFC PATCH 15/17] riscv: dts: allwinner: Add the D1/D1s SoC devicetree

2022-12-05 Thread Andre Przywara
From: Samuel Holland D1 (aka D1-H), D1s (aka F133), R528, and T113 are a family of SoCs based on a single die, or at a pair of dies derived from the same design. D1 and D1s contain a single T-HEAD Xuantie C906 CPU, whereas R528 and T113 contain a pair of Cortex-A7's. D1 and R528 are the full

[RFC PATCH 16/17] arm: sunxi: add Allwinner T113s devicetree stub

2022-12-05 Thread Andre Przywara
This adds the basic SoC .dtsi devicetree stub for the Allwinner T113s SoC. This shares a die with the Allwinner D1 SoC (with RISC-V cores), but uses two Cortex-A7 cores instead of the T-HEAD C906 RISC-V core. Include the existing D1 devicetree stub, but add the ARM specific nodes, like for the

[RFC PATCH 14/17] sunxi: refactor serial base addresses to avoid asm/arch/cpu.h

2022-12-05 Thread Andre Przywara
At the moment we have each SoC's memory map defined in its own cpu.h, which is included in include/configs/sunxi_common.h. This will be a problem with the introduction of Allwinner RISC-V support. Remove the inclusion of that header file from the common config header, instead move the required

[RFC PATCH 13/17] sunxi: add early Allwinner R528/T113 SoC support

2022-12-05 Thread Andre Przywara
This adds the remaining code bits to teach U-Boot about Allwinner's newest SoC generation. This was introduced with the RISC-V based Allwinner D1 SoC, which actually shares a die with the ARM cores versions called R528 (BGA, without DRAM) and T113s (QFP, with embedded DRAM). This adds the new

[RFC PATCH 10/17] clk: sunxi: Add support for the D1 CCU

2022-12-05 Thread Andre Przywara
From: Samuel Holland Since the D1 CCU binding is defined, we can add support for its gates/resets, following the pattern of the existing drivers. Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Acked-by: Sean Anderson --- drivers/clk/sunxi/Kconfig | 6 +

[RFC PATCH 11/17] sunxi: clock: D1/R528: Enable PLL LDO during PLL1 setup

2022-12-05 Thread Andre Przywara
The D1/R528/T113s SoCs introduce a new "LDO enable" bit in the CPUX_PLL. Just enable that when we program that PLL. Signed-off-by: Andre Przywara --- arch/arm/include/asm/arch-sunxi/clock_sun50i_h6.h | 1 + arch/arm/mach-sunxi/clock_sun50i_h6.c | 12 +++- 2 files changed, 8

[RFC PATCH 09/17] pinctrl: sunxi: add Allwinner D1 pinctrl description

2022-12-05 Thread Andre Przywara
Apart from using the new pinctrl MMIO register layout, the Allwinner D1 and related SoCs still need to usual set of mux values hardcoded in U-Boot's pinctrl driver. Add the values we need so far to this list, so that DM based drivers will just work without further ado. Signed-off-by: Andre

[RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2022-12-05 Thread Andre Przywara
Allwinner seems to typically stick to a common MMIO memory map for several SoCs, but from time to time does some breaking changes, which also introduce new generations of some peripherals. The last time this happened with the H6, which apart from re-organising the base addresses also changed the

[RFC PATCH 12/17] sunxi: clock: support D1/R528 PLL6 clock

2022-12-05 Thread Andre Przywara
The PLL_PERIPH0 clock changed a bit in the D1/R528/T113s SoCs: there is new P0 divider at bits [18:16], and the M divider is 1. Add code to support this version of "PLL6". Signed-off-by: Andre Przywara --- .../include/asm/arch-sunxi/clock_sun50i_h6.h | 2 ++

[RFC PATCH 06/17] pinctrl: sunxi: move PIO_BASE into sunxi_gpio.h

2022-12-05 Thread Andre Przywara
On the Allwinner platform we were describing a quite comprehensive memory map in a per-SoC header unser arch/arm. In the old days that was used by every driver, but nowadays it should only be needed by SPL drivers (not using the DT). Many addresses in there were never used, and some are not needed

[RFC PATCH 05/17] pinctrl: sunxi: move pinctrl code and remove GPIO_EXTRA_HEADER

2022-12-05 Thread Andre Przywara
U-Boot's generic GPIO_EXTRA_HEADER is a convenience symbol to allow code to more easily include platform specific GPIO headers. This should not be needed in a DM world anymore, since the generic GPIO framework handles that nicely. For Allwinner boards we still need to deal with non-DM GPIO in the

[RFC PATCH 07/17] pinctrl: sunxi: add new D1 pinctrl support

2022-12-05 Thread Andre Przywara
For the first time since at least the Allwinner A10 SoCs, the D1 (and related cores) use a new pincontroller MMIO register layout, so we cannot use our hardcoded, fixed offsets anymore. Ideally this would all be handled by devicetree and DM drivers, but for the DT-less SPL we still need the legacy

[RFC PATCH 04/17] pinctrl: sunxi: add GPIO in/out wrappers

2022-12-05 Thread Andre Przywara
So far we were open-coding the pincontroller's GPIO output/input access in each function using that. Provide two functions that wrap that nicely, so users don't need to know about the internals, and we can abstract the new D1 pinctrl more easily. Signed-off-by: Andre Przywara ---

[RFC PATCH 02/17] sunxi: remove CONFIG_MACPWR

2022-12-05 Thread Andre Przywara
The CONFIG_MACPWR Kconfig symbol is used to point to a GPIO that enables the power for the Ethernet "MAC" (mostly PHY, really). In the DT this is described with the phy-supply property in the MAC DT node, pointing to a (GPIO controlled) regulator. Since we need Ethernet only in U-Boot proper, and

[RFC PATCH 03/17] pinctrl: sunxi: remove struct sunxi_gpio

2022-12-05 Thread Andre Przywara
So far every Allwinner SoC used the same basic pincontroller/GPIO register frame, and just differed by the number of implemented banks and pins, plus some special functionality from time to time. However the D1 and successors use a slightly different pinctrl register layout. Use that opportunity

[RFC PATCH 01/17] sunxi: remove CONFIG_SATAPWR

2022-12-05 Thread Andre Przywara
The CONFIG_SATAPWR Kconfig symbol was used to point to a GPIO that enables the power for a SATA harddisk. In the DT this is described with the target-supply property in the AHCI DT node, pointing to a (GPIO controlled) regulator. Since we need SATA only in U-Boot proper, and use a DM driver for

[RFC PATCH 00/17] sunxi: rework pinctrl and add T113s support

2022-12-05 Thread Andre Przywara
Hi, this is some early attempt at supporting the new SoC series that covers the Allwinner D1 siblings R528 and T113s. They all share the same die, although the D1 and D1s use RISC-V cores, which requires more plumbing, to use the sunxi code across two architectures. Getting the R528 support in

Re: [PATCH v2 00/25] bootstd: Add a boot menu

2022-12-05 Thread Simon Glass
Hi Heinrich (and anyone else), On Thu, 10 Nov 2022 at 15:15, Simon Glass wrote: > > Hi Heinrich, > > On Mon, 7 Nov 2022 at 16:35, Simon Glass wrote: > > > > Hi Heinrich, > > > > On Mon, 7 Nov 2022 at 12:15, Heinrich Schuchardt wrote: > > > > > > On 11/4/22 23:48, Simon Glass wrote: > > > > So

Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs

2022-12-05 Thread Simon Glass
Hi Tom, On Tue, 6 Dec 2022 at 12:56, Tom Rini wrote: > > On Tue, Dec 06, 2022 at 12:55:08PM +1300, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 6 Dec 2022 at 12:46, Tom Rini wrote: > > > > > > On Mon, Dec 05, 2022 at 11:43:24PM +, Peter Robinson wrote: > > > > On Mon, Dec 5, 2022 at 11:35

Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs

2022-12-05 Thread Tom Rini
On Tue, Dec 06, 2022 at 12:55:08PM +1300, Simon Glass wrote: > Hi Tom, > > On Tue, 6 Dec 2022 at 12:46, Tom Rini wrote: > > > > On Mon, Dec 05, 2022 at 11:43:24PM +, Peter Robinson wrote: > > > On Mon, Dec 5, 2022 at 11:35 PM Tom Rini wrote: > > > > > > > > On Mon, Dec 05, 2022 at

Re: [PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation

2022-12-05 Thread Simon Glass
Hi, On Tue, 6 Dec 2022 at 11:25, Tom Rini wrote: > > On Mon, Dec 05, 2022 at 09:35:41PM +, Peter Robinson wrote: > > On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek wrote: > > > > > > The i2c locks up when initialized before relocation, and it stays broken > > > in Linux as well breaking

Re: [RFC 1/1] sound: allow waveform selection

2022-12-05 Thread Simon Glass
Hi Heinrich, On Mon, 5 Dec 2022 at 13:38, Heinrich Schuchardt wrote: > > * Allow the sound command to select the sine or the square waveform. > * Allow to play multiple tones with one command. > * Adjust documentation. > * Adjust unit test. > > Signed-off-by: Heinrich Schuchardt > --- > This

Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs

2022-12-05 Thread Simon Glass
Hi Tom, On Tue, 6 Dec 2022 at 12:46, Tom Rini wrote: > > On Mon, Dec 05, 2022 at 11:43:24PM +, Peter Robinson wrote: > > On Mon, Dec 5, 2022 at 11:35 PM Tom Rini wrote: > > > > > > On Mon, Dec 05, 2022 at 11:29:30PM +, Peter Robinson wrote: > > > > On Mon, Dec 5, 2022 at 11:23 PM Tom

Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs

2022-12-05 Thread Peter Robinson
On Mon, Dec 5, 2022 at 11:46 PM Tom Rini wrote: > > On Mon, Dec 05, 2022 at 11:43:24PM +, Peter Robinson wrote: > > On Mon, Dec 5, 2022 at 11:35 PM Tom Rini wrote: > > > > > > On Mon, Dec 05, 2022 at 11:29:30PM +, Peter Robinson wrote: > > > > On Mon, Dec 5, 2022 at 11:23 PM Tom Rini

Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs

2022-12-05 Thread Tom Rini
On Mon, Dec 05, 2022 at 11:43:24PM +, Peter Robinson wrote: > On Mon, Dec 5, 2022 at 11:35 PM Tom Rini wrote: > > > > On Mon, Dec 05, 2022 at 11:29:30PM +, Peter Robinson wrote: > > > On Mon, Dec 5, 2022 at 11:23 PM Tom Rini wrote: > > > > > > > > On Mon, Dec 05, 2022 at 11:13:03PM

Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs

2022-12-05 Thread Peter Robinson
On Mon, Dec 5, 2022 at 11:35 PM Tom Rini wrote: > > On Mon, Dec 05, 2022 at 11:29:30PM +, Peter Robinson wrote: > > On Mon, Dec 5, 2022 at 11:23 PM Tom Rini wrote: > > > > > > On Mon, Dec 05, 2022 at 11:13:03PM +, Peter Robinson wrote: > > > > On Thu, Nov 10, 2022 at 2:17 AM Simon Glass

Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs

2022-12-05 Thread Tom Rini
On Mon, Dec 05, 2022 at 11:29:30PM +, Peter Robinson wrote: > On Mon, Dec 5, 2022 at 11:23 PM Tom Rini wrote: > > > > On Mon, Dec 05, 2022 at 11:13:03PM +, Peter Robinson wrote: > > > On Thu, Nov 10, 2022 at 2:17 AM Simon Glass wrote: > > > > > > > > Buildman should consider a build as a

Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs

2022-12-05 Thread Peter Robinson
On Mon, Dec 5, 2022 at 11:23 PM Tom Rini wrote: > > On Mon, Dec 05, 2022 at 11:13:03PM +, Peter Robinson wrote: > > On Thu, Nov 10, 2022 at 2:17 AM Simon Glass wrote: > > > > > > Buildman should consider a build as a success (with warnings) if missing > > > blobs have been dealt with by

Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs

2022-12-05 Thread Tom Rini
On Mon, Dec 05, 2022 at 11:13:03PM +, Peter Robinson wrote: > On Thu, Nov 10, 2022 at 2:17 AM Simon Glass wrote: > > > > Buildman should consider a build as a success (with warnings) if missing > > blobs have been dealt with by binman, even though buildman itself returns > > and error code

Re: [PATCH v5 10/16] buildman: Detect binman reporting missing blobs

2022-12-05 Thread Peter Robinson
On Thu, Nov 10, 2022 at 2:17 AM Simon Glass wrote: > > Buildman should consider a build as a success (with warnings) if missing > blobs have been dealt with by binman, even though buildman itself returns > and error code overall. This is how other warnings are dealt with. > > We cannot easily

Re: [PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation

2022-12-05 Thread Tom Rini
On Mon, Dec 05, 2022 at 09:35:41PM +, Peter Robinson wrote: > On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek wrote: > > > > The i2c locks up when initialized before relocation, and it stays broken > > in Linux as well breaking the ability to boot Linux. > > > > The i2c bus and pmic was not

Re: [PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation

2022-12-05 Thread Peter Robinson
On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek wrote: > > The i2c locks up when initialized before relocation, and it stays broken > in Linux as well breaking the ability to boot Linux. > > The i2c bus and pmic was not actually used in pre-reloc before > commit ad607512f575 ("power: pmic: rk8xx:

Re: [PATCH] sunxi: define SYS_MONITOR_LEN in Kconfig, not _defconfig

2022-12-05 Thread Jernej Škrabec
Dne sreda, 23. november 2022 ob 23:51:17 CET je Andre Przywara napisal(a): > Commit 08574ed339fb ("Convert CONFIG_SYS_MONITOR_LEN to Kconfig") moved > the definition of said config variable from the common sunxi header to > *every board's* defconfig. > This is a platform choice, not board

[ANN] U-Boot v2023.01-rc3 released

2022-12-05 Thread Tom Rini
Hey all, Now that we're back on schedule, here's -rc3. Since -rc2 I've pulled in a lot of network changes that've been outstanding, and with maybe one exception that's done now. I hope we can stay in a fairly narrow stabilization patch flow now, and to that end I'm also opening up -next. With

Re: [PATCH v5 01/19] net: ipv6: Add IPv6 basic primitives

2022-12-05 Thread Tom Rini
On Fri, Dec 02, 2022 at 12:17:58PM +0300, Viacheslav Mitrofanov wrote: > This patch is a collection of basic primitives that are prerequisite for > further IPv6 implementation. > > There are structures definition such as IPv6 header, UDP header > (for TFTP), ICMPv6 header. There are auxiliary

Re: [PATCH v2] fastboot: Add OEM run command

2022-12-05 Thread Sean Anderson
On 12/5/22 14:04, Patrick DELAUNAY wrote: > Hi, > > On 12/2/22 22:03, Sean Anderson wrote: >> This adds the UUU UCmd functionality as an OEM command. While the >> fastboot tool allows sending arbitrary commands as long as they are >> prefixed with "oem". This allows running generic U-Boot

Re: [PATCH v2] arm: dts: rockchip: rk3399: usb: ehci: Fix EHCI probe in rk3399 to access peripherals by USB 2.

2022-12-05 Thread Marek Vasut
On 12/5/22 19:54, Xavier Drudis Ferran wrote: arch/arm/dts/rk3399.dtsi has a node usb_host0_ehci: usb@fe38 { compatible = "generic-ehci"; with clocks: clocks = < HCLK_HOST0>, < HCLK_HOST0_ARB>, <>; The first 2 refer to nodes with class UCLASS_CLK, but

Re: [PATCH v2] fastboot: Add OEM run command

2022-12-05 Thread Patrick DELAUNAY
Hi, On 12/2/22 22:03, Sean Anderson wrote: This adds the UUU UCmd functionality as an OEM command. While the fastboot tool allows sending arbitrary commands as long as they are prefixed with "oem". This allows running generic U-Boot commands over fastboot without UUU, which is especially useful

[PATCH v2] arm: dts: rockchip: rk3399: usb: ehci: Fix EHCI probe in rk3399 to access peripherals by USB 2.

2022-12-05 Thread Xavier Drudis Ferran
arch/arm/dts/rk3399.dtsi has a node usb_host0_ehci: usb@fe38 { compatible = "generic-ehci"; with clocks: clocks = < HCLK_HOST0>, < HCLK_HOST0_ARB>, <>; The first 2 refer to nodes with class UCLASS_CLK, but has class UCLASS_PHY. u2phy0: usb2phy@e450 {

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-05 Thread Pali Rohár
On Monday 05 December 2022 12:42:44 Stefan Roese wrote: > Hi! > > On 12/4/22 11:39, Pali Rohár wrote: > > Hello! > > > > I would suggest to change description of the patch from > > > >"mvebu: fix end-of-array check" > > > > to something like: > > > >"arm: mvebu: Espressobin: fix

Re: [PATCH] net: eth-uclass: change state before stop() in eth_halt()

2022-12-05 Thread Marek Vasut
On 12/5/22 16:33, Niel Fourie wrote: Hi Marek, Hi, On 05/12/2022 13:06, Niel Fourie wrote: [...] It does however show that this patch introduces a bug -- this patch changes the order in which priv->state = ETH_STATE_PASSIVE; is assigned from _after_ the ->stop callback to _before_ the ->

Re: [PATCH] net: eth-uclass: change state before stop() in eth_halt()

2022-12-05 Thread Marek Vasut
On 12/5/22 13:06, Niel Fourie wrote: Hi, [...] How come nobody triggered this problem with regular ethernet in U-Boot ? If this is isolated to USB gadget ethernet, then please do not hack around this in core networking code, but rather fix the USB ethernet gadget itself. It seems that

Re: [TF-A] [RFC] Proposed location to host the firmware handoff specification.

2022-12-05 Thread Simon Glass
Hi Dan, Julius, On Tue, 6 Dec 2022 at 06:51, Dan Handley wrote: > > Hi > > Just a few comments: > > * I agree with Julius that in general it isn't feasible for firmware to > refuse to accept a TL with unknown tags. The structures are defined to help > with backwards/forwards compatibility. To

RE: [TF-A] [RFC] Proposed location to host the firmware handoff specification.

2022-12-05 Thread Dan Handley
Hi Just a few comments: * I agree with Julius that in general it isn't feasible for firmware to refuse to accept a TL with unknown tags. The structures are defined to help with backwards/forwards compatibility. To assume that all firmware is built at the same time is a special case. A

Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices

2022-12-05 Thread Fabio Estevam
On Mon, Dec 5, 2022 at 12:37 PM Tom Rini wrote: > I'm not really happy with this approach. It's not that upstream doesn't > have aliases now, it's that it has different aliases, right? That's why > they won't accept these? imx6q.dtsi does have the default mmc aliases: mmc0 = mmc1 = mmc2 =

Re: [PATCH 0/3] clang-14 fixes

2022-12-05 Thread Tom Rini
On Tue, Dec 06, 2022 at 05:11:46AM +1300, Simon Glass wrote: > Hi Tom, > > On Wed, 12 Oct 2022 at 05:13, Tom Rini wrote: > > > > On Tue, Oct 11, 2022 at 08:14:53AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sat, 8 Oct 2022 at 21:33, Simon Glass wrote: > > > > > > > > This series

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2022-12-05 Thread Marek Vasut
On 12/5/22 14:49, Miquel Raynal wrote: Hi Francesco, Hi, france...@dolcini.it wrote on Mon, 5 Dec 2022 12:26:44 +0100: On Fri, Dec 02, 2022 at 06:08:22PM +0100, Marek Vasut wrote: But here I would say this is a firmware bug and it might have to be handled like a firmware bug, i.e. with

Re: [PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description

2022-12-05 Thread Michael Nazzareno Trimarchi
Hi On Mon, Dec 5, 2022 at 5:11 PM Simon Glass wrote: > > Hi Frieder, > > On Fri, 25 Nov 2022 at 04:09, Frieder Schrempf > wrote: > > > > On 07.10.22 13:58, Fabio Estevam wrote: > > > On Fri, Oct 7, 2022 at 8:34 AM Michael Nazzareno Trimarchi > > > wrote: > > > > > >> About this change, there

Re: [PATCH 0/3] clang-14 fixes

2022-12-05 Thread Simon Glass
Hi Tom, On Wed, 12 Oct 2022 at 05:13, Tom Rini wrote: > > On Tue, Oct 11, 2022 at 08:14:53AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Sat, 8 Oct 2022 at 21:33, Simon Glass wrote: > > > > > > This series contains a few clang-14 fixes to partly resolve the problems > > > shown by [1]. > >

Re: [PATCHv2 010/149] rsa-verify: Rework host check for CONFIG_RSA_VERIFY_WITH_PKEY

2022-12-05 Thread Simon Glass
On Mon, 5 Dec 2022 at 11:37, Tom Rini wrote: > > While we do not want to use CONFIG_RSA_VERIFY_WITH_PKEY on the host, we > cannot undef the symbol in this manner. As this ends up being a test > within another function we can use !tools_build() as a test here. > > Cc: Simon Glass > Signed-off-by:

Re: [PATCH 3/3] sandbox: fix sound driver

2022-12-05 Thread Simon Glass
On Mon, 5 Dec 2022 at 09:53, Heinrich Schuchardt wrote: > > In the callback function we have to use memcpy(). Otherwise we add > the new samples on top of what is stored in the stream buffer. > > If we don't have enough data, zero out the rest of the stream buffer. > > Our sampling frequency is

Re: [PATCH 1/3] sound: function to generate sine wave

2022-12-05 Thread Simon Glass
On Mon, 5 Dec 2022 at 09:53, Heinrich Schuchardt wrote: > > Add function sound_create_sine_wave(). > > Signed-off-by: Heinrich Schuchardt > --- > drivers/sound/sound.c | 39 +++ > include/sound.h | 12 > 2 files changed, 51 insertions(+) >

Re: [PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description

2022-12-05 Thread Simon Glass
Hi Frieder, On Fri, 25 Nov 2022 at 04:09, Frieder Schrempf wrote: > > On 07.10.22 13:58, Fabio Estevam wrote: > > On Fri, Oct 7, 2022 at 8:34 AM Michael Nazzareno Trimarchi > > wrote: > > > >> About this change, there was a commit from Simon 8d38a8459b0 > >> that was renamed. You ask basically

Re: [PATCH 1/1] mvebu: fix end-of-array check

2022-12-05 Thread Simon Glass
Hi Pali, On Mon, 5 Dec 2022 at 10:51, Pali Rohár wrote: > > On Monday 05 December 2022 10:16:51 Simon Glass wrote: > > On Thu, 1 Dec 2022 at 07:55, Derek LaHousse wrote: > > > > > > Properly seek the end of default_environment variables. > > > > > > The current algorithm overwrites from the

Re: [GIT PULL] xilinx patches for v2023.01-rc3-v2

2022-12-05 Thread Tom Rini
On Mon, Dec 05, 2022 at 12:29:38PM +0100, Michal Simek wrote: > Hi Tom, > > please pull these changes to your tree. I thought that we are running > regression against upstream regularly but it looks like that it wasn't the > case. Based on internal upgrade to rc2 version we found some issues

Re: Please pull u-boot-i2c

2022-12-05 Thread Tom Rini
On Mon, Dec 05, 2022 at 08:30:53AM +0100, Heiko Schocher wrote: > Hello Tom, > > please pull from u-boot-i2c: > > The following changes since commit d2c5607edde2544e059fa871927877213f6bd532: > > Merge tag 'efi-2023-01-rc3' of > https://source.denx.de/u-boot/custodians/u-boot-efi (2022-12-04

Re: [PATCH v8 03/10] arm_ffa: introduce Arm FF-A low-level driver

2022-12-05 Thread Rob Herring
On Sun, Dec 4, 2022 at 1:22 PM Simon Glass wrote: > > Hi Rob, > > On Tue, 29 Nov 2022 at 05:22, Rob Herring wrote: > > > > On Fri, Nov 25, 2022 at 3:18 PM Simon Glass wrote: > > > > > > Hi Abdellatif, > > > > > > On Thu, 24 Nov 2022 at 06:21, Abdellatif El Khlifi > > > wrote: > > > > > > > >

Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices

2022-12-05 Thread Tom Rini
On Sat, Dec 03, 2022 at 09:23:10AM -0300, Fabio Estevam wrote: > On Fri, Dec 2, 2022 at 8:36 PM Tom Rini wrote: > > > No, upstream has different aliases and doesn't want these. That's the > > point of the above thread, right? > > Upstream is correct in not accepting new alias for this board, as

Re: [PATCH] net: eth-uclass: change state before stop() in eth_halt()

2022-12-05 Thread Niel Fourie
Hi Marek, On 05/12/2022 13:06, Niel Fourie wrote: [...] It does however show that this patch introduces a bug -- this patch changes the order in which priv->state = ETH_STATE_PASSIVE; is assigned from _after_ the ->stop callback to _before_ the -> stop callback. This breaks

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2022-12-05 Thread Miquel Raynal
Hi Francesco, france...@dolcini.it wrote on Mon, 5 Dec 2022 12:30:16 +0100: > Hello Miquel > > On Fri, Dec 02, 2022 at 06:20:02PM +0100, Francesco Dolcini wrote: > > On Fri, Dec 02, 2022 at 05:42:55PM +0100, Miquel Raynal wrote: > > > Please also do it with the NAND chip described. If, when

Re: [PATCH v5 3/3] board: qemu-riscv: enable semihosting

2022-12-05 Thread Sean Anderson
On 12/5/22 00:51, Kautuk Consul wrote: > Hi, > > On Sat, Dec 3, 2022 at 9:44 AM Bin Meng wrote: >> >> On Fri, Sep 23, 2022 at 3:03 PM Kautuk Consul >> wrote: >> > >> > To enable semihosting we also need to enable the following >> > configs in defconfigs: >> > CONFIG_SEMIHOSTING >> >

Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices

2022-12-05 Thread Detlev Casanova
On Saturday, December 3, 2022 7:23:10 A.M. EST Fabio Estevam wrote: > On Fri, Dec 2, 2022 at 8:36 PM Tom Rini wrote: > > No, upstream has different aliases and doesn't want these. That's the > > point of the above thread, right? > > Upstream is correct in not accepting new alias for this board,

Re: [PATCH v5 3/3] board: qemu-riscv: enable semihosting

2022-12-05 Thread Bin Meng
On Mon, Dec 5, 2022 at 1:51 PM Kautuk Consul wrote: > > Hi, > > On Sat, Dec 3, 2022 at 9:44 AM Bin Meng wrote: > > > > On Fri, Sep 23, 2022 at 3:03 PM Kautuk Consul > > wrote: > > > > > > To enable semihosting we also need to enable the following > > > configs in defconfigs: > > >

Re: [PATCH v1] mtd: parsers: ofpart: Fix parsing when size-cells is 0

2022-12-05 Thread Miquel Raynal
Hi Francesco, france...@dolcini.it wrote on Mon, 5 Dec 2022 12:26:44 +0100: > On Fri, Dec 02, 2022 at 06:08:22PM +0100, Marek Vasut wrote: > > But here I would say this is a firmware bug and it might have to be handled > > like a firmware bug, i.e. with fixup in the partition parser. I seem to

[PATCH 2/5] misc: socfpga_secreg: Enable register settings in DTS

2022-12-05 Thread Jit Loon Lim
From: Tien Fong Chee Enable register settings from device tree in SPL, which require high privilege access like firewall registers. This also provides user a clean interface and all register settings are centralized in one place, device tree. Signed-off-by: Tien Fong Chee Signed-off-by: Jit

[PATCH 5/5] arm: socfpga: Switch FW settings from codes to DTS

2022-12-05 Thread Jit Loon Lim
From: Tien Fong Chee Switching the firewall, and high privilege registers setting in source codes over to device tree implementation. Signed-off-by: Tien Fong Chee Signed-off-by: Jit Loon Lim --- arch/arm/Kconfig | 2 ++ arch/arm/mach-socfpga/Makefile

[PATCH 1/5] doc: dtbinding: Add doc for privilege regs settings

2022-12-05 Thread Jit Loon Lim
From: Tien Fong Chee Add a document to describe firewall and privilege register settings binding information. Signed-off-by: Tien Fong Chee Signed-off-by: Jit Loon Lim --- .../misc/socfpga_secreg.txt | 26 +++ 1 file changed, 26 insertions(+) create mode

  1   2   >