Re: [PATCH 1/1] efi_loader: use EFI_EXIT in efi_riscv_get_boot_hartid

2023-01-12 Thread Sunil V L
On Wed, Jan 11, 2023 at 07:13:01PM +0100, Heinrich Schuchardt wrote: > After calling EFI_ENTRY we have to call EFI_EXIT before returning. > > Add a missing EFI_EXIT(). > > Fixes: 1ccf87165e38 ("efi_loader: Enable RISCV_EFI_BOOT_PROTOCOL support") > Reported-by: Dave Jones > Signed-off-by: Heinri

Re: [PATCH u-boot 2/2] Makefile: Build working u-boot-dtb.bin target also for mpc85xx

2023-01-12 Thread Heiko Schocher
Hello Pali, On 12.01.23 07:27, Heiko Schocher wrote: > Hello Pali, > > On 11.01.23 19:13, Pali Rohár wrote: >> On Wednesday 11 January 2023 19:02:38 Pali Rohár wrote: >>> On Wednesday 11 January 2023 18:55:40 Pali Rohár wrote: On Wednesday 11 January 2023 09:01:37 Tom Rini wrote: > On We

Re: [PATCH 1/6] stm32mp: cosmetic: Update of bsec driver

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > Remove unnecessary return in stm32mp_bsec_write_lock and replace tab > by space for plat_auto opts. > > Signed-off-by: Patrick Delaunay > --- > > arch/arm/mach-stm32mp/bsec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > d

Re: [PATCH 2/6] stm32mp: Add OP-TEE support in bsec driver

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > When OP-TEE is used, the SMC for BSEC management are not available and > the STM32MP BSEC pseudo TA must be used (it is mandatory for STM32MP13 > and it is a new feature for STM32MP15x). > > The BSEC driver try to open a session to this PTA BS

Re: [PATCH 3/6] stm32mp: Add support of STM32MP13x in bsec driver

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > Add support for "st,stm32mp13-bsec" for STM32MP13x in the > bsec driver based on OP-TEE pseudo TA STM32MP BSEC. > > Signed-off-by: Patrick Delaunay > --- > > arch/arm/mach-stm32mp/bsec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

Re: [PATCH 4/6] configs: stm32mp13: Activate CONFIG_CMD_FUSE

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > Activate the command fuse to access on STM32MP13x OTP with > the BSEC driver. > > Signed-off-by: Patrick Delaunay > --- > > configs/stm32mp13_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/stm32mp13_defconfig b/

Re: [PATCH 6/6] configs: stm32mp13: Activate command stm32key

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > Activate the command stm32key with CONFIG_CMD_STM32KEY. > > Signed-off-by: Patrick Delaunay > --- > > configs/stm32mp13_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defc

Re: [PATCH 1/7] drivers: net: fsl-mc: remove useless assignment of variable

2023-01-12 Thread Ioana Ciornei
On Tue, Jan 10, 2023 at 07:04:00PM +0200, Ramon Fried wrote: > On Thu, Jan 5, 2023 at 5:03 PM Ioana Ciornei wrote: > > > > The cur_ptr variable is set to the start of the log buffer but then it's > > not used. Just remove the assignment altogether. > > > > Signed-off-by: Ioana Ciornei > > --- > >

[PATCH 1/4] dt-bindings: rockchip: Sync rockchip,vop2.h from Linux

2023-01-12 Thread Jagan Teki
Sync rockchip,vop2.h from linux-next, and the last commit is commit <604be85547ce> ("drm/rockchip: Add VOP2 driver") Signed-off-by: Jagan Teki --- include/dt-bindings/soc/rockchip,vop2.h | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 include/dt-bindings/soc/rockchip,v

[PATCH 2/4] arm64: dts: rockchip: rk3566: Add Radxa Compute Module 3

2023-01-12 Thread Jagan Teki
Radxa Compute Module 3(CM3) is one of the modules from a series System On Module based on the Radxa ROCK 3 series and is compatible with Raspberry Pi CM4 pinout and form factor. Specification: - Rockchip RK3566 - up to 8GB LPDDR4 - up to 128GB high performance eMMC - Optional wireless LAN, 2.4GHz

[PATCH 4/4] board: rockchip: Add Radxa Compute Module 3 IO Board

2023-01-12 Thread Jagan Teki
Radxa Compute Module 3(CM3) IO board an application board from Radxa and is compatible with Raspberry Pi CM4 IO form factor. Radxa CM3 needs to mount on top of this IO board in order to create complete Radxa CM3 IO board platform. Add support for Radxa CM3 IO Board defconfig and -u-boot.dtsi Sig

[PATCH 3/4] arm64: dts: rockchip: rk3566: Add Radxa Compute Module 3 IO

2023-01-12 Thread Jagan Teki
Radxa Compute Module 3(CM3) IO board an application board from Radxa and is compatible with Raspberry Pi CM4 IO form factor. Specification: - 1x HDMI, - 2x MIPI DSI - 2x MIPI CSI2 - 1x eDP - 1x PCIe card - 2x SATA - 2x USB 2.0 Host - 1x USB 3.0 - 1x USB 2.0 OTG - Phone jack - microSD slot - 40-pin

Re: [Uboot-stm32] [PATCH 5/6] board: st: Add support of STM32MP13x boards in stm32board cmd

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > Add board identifiers for STMicroelectronics STM32MP13x boards: > - DISCO board: MB1635 > > Signed-off-by: Patrick Delaunay > --- > > board/st/common/Kconfig | 2 +- > board/st/common/cmd_stboard.c | 7 --- > 2 files changed, 5 in

Re: U-Boot v2023.01 broken on riscv64 qemu virt platform: "fdt fixup event failed"

2023-01-12 Thread Bin Meng
On Thu, Jan 12, 2023 at 8:18 AM Tom Rini wrote: > > On Thu, Jan 12, 2023 at 01:16:43AM +0100, Heinrich Schuchardt wrote: > > On 1/12/23 01:04, Tom Rini wrote: > > > On Thu, Jan 12, 2023 at 01:01:55AM +0100, Heinrich Schuchardt wrote: > > > > On 1/12/23 00:59, Tom Rini wrote: > > > > > On Thu, Jan

Re: [PATCH v3 2/4] ARM: stm32: Factor out save_boot_params

2023-01-12 Thread Patrice CHOTARD
Hi Marek I am preparing the next STM32 U-Boot pull request, during testing, buidlman is complaining with the following warning: 03: ARM: stm32: Factor out save_boot_params arm: + stm32mp13 +../arch/arm/mach-stm32mp/boot_params.c: In function 'board_fdt_blob_setup': +../arch/

Re: [PATCH 1/1] common:autoboot:modify function parameters

2023-01-12 Thread Tom Rini
On Fri, Dec 02, 2022 at 12:53:48PM +0800, Shenlin Liang wrote: > the blob parameter of the function process_fdt_options has not been > invoked in the function body and should be changed to void type > > Signed-off-by: Shenlin Liang > Reviewed-by: Simon Glass Applied to u-boot/master, thanks!

Re: [PATCH] rtc: abx8xx: Add support for reading RAM

2023-01-12 Thread Tom Rini
On Fri, Dec 02, 2022 at 10:35:19AM -0500, Sean Anderson wrote: > This adds support for reading the battery-backed memory present on these > RTCs. This modifies the read/write methods to access the RAM instead of > raw register offsets. No one was using these in-tree, so we should be > fine changin

Re: [PATCH] reboot-mode: Add NVMEM reboot mode

2023-01-12 Thread Tom Rini
On Fri, Dec 02, 2022 at 11:03:53AM -0500, Sean Anderson wrote: > This adds an NVMEM reboot mode driver, similar to Linux's > implementation. This allows using the same device tree binding for Linux > and U-Boot in most cases. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied

Re: [PATCH] lib: rsa: cosmetic: fix building warning

2023-01-12 Thread Tom Rini
On Tue, Dec 06, 2022 at 03:41:37PM +0800, Haijun Qin wrote: > add initialization of variable 'node',this can aviod the building > warning: > > 'node' may be used uninitialized [-Wmaybe-uninitialized] > > Signed-off-by: Haijun Qin > Reviewed-by: Simon Glass Applied to u-boot/master, thanks

Re: [PATCH] cmd: mtdparts: add SYS_MTDPARTS_RUNTIME dependency on CONFIG_MTDIDS/MTDPARTS_DEFAULT

2023-01-12 Thread Tom Rini
On Thu, Dec 08, 2022 at 09:10:13AM +0100, Patrick Delaunay wrote: > The two configuration CONFIG_MTDIDS_DEFAULT and CONFIG_MTDPARTS_DEFAULT > are not needed with mtd configuration CONFIG_SYS_MTDPARTS_RUNTIME which > allows the MTDIDS and MTDPARTS to be configured at runtime. > > This patch has no

Re: [PATCH 1/1] cmd: change the return value when argc error

2023-01-12 Thread Tom Rini
On Fri, Dec 09, 2022 at 05:17:43PM +0800, Shenlin Liang wrote: > When the number of parameters is wrong, the return value should be processed > in > the same way as other cmds, return CMD_RET_USAGE so that it can print the > information. > > Signed-off-by: Shenlin Liang > Reviewed-by: Simon G

Re: [PATCH v1] test: env: add test for u-boot-initial-env creation

2023-01-12 Thread Tom Rini
On Fri, Dec 09, 2022 at 01:09:56PM +0100, Max Krummenacher wrote: > From: Max Krummenacher > > Checks that `make u-boot-initial-env` creates the text file > u-boot-initial-env and checks that it at least contains > `board=`. > > Signed-off-by: Max Krummenacher > Reviewed-by: Simon Glass Appl

Re: [PATCH 1/2] env: ubi: add support of command env erase

2023-01-12 Thread Tom Rini
On Wed, Dec 14, 2022 at 04:51:31PM +0100, Patrick Delaunay wrote: > Add support of opts erase for ubi env backend, this opts is used by > command 'env erase'. > > This command only zero-fill the env UBI volume CONFIG_ENV_UBI_VOLUME > and CONFIG_ENV_UBI_VOLUME_REDUND, so the saved environment beco

Re: [PATCH 2/2] env: add failing trace in env_erase

2023-01-12 Thread Tom Rini
On Wed, Dec 14, 2022 at 04:51:32PM +0100, Patrick Delaunay wrote: > Add trace in env save to indicate any errors to end user and avoid > silent output when the command 'env erase' is not executed as it is > done in env_save with commit 8968288cb477 ("env: add failing trace in > env_save") > > Sig

Re: [PATCH] optee: bind the TA drivers on OP-TEE node

2023-01-12 Thread Tom Rini
On Thu, Dec 15, 2022 at 09:54:52AM +0100, Patrick Delaunay wrote: > In U-Boot driver model the devices can be referenced by > phandle in the U-Boot configuration nodes. > > Without a valid node provided during the bind, the driver > associated to OP-TEE TA can't be referenced. > > For example to

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2023-01-12 Thread Tom Rini
On Thu, Dec 15, 2022 at 10:15:50AM +0100, Patrick Delaunay wrote: > Much of the fastboot code predates the introduction of Kconfig and > has quite a few #ifdefs in it which is unnecessary now that we can use > IS_ENABLED() et al. > > Signed-off-by: Patrick Delaunay > Reviewed-by: Mattijs Korpers

Re: [PATCH v3] fastboot: Add OEM run command

2023-01-12 Thread Tom Rini
On Fri, Dec 16, 2022 at 01:20:16PM -0500, Sean Anderson wrote: > This adds the UUU UCmd functionality as an OEM command. While the > fastboot tool allows sending arbitrary commands as long as they are > prefixed with "oem". This allows running generic U-Boot commands over > fastboot without UUU, w

Re: [PATCH v2 1/2] cmd: exit: Fix return value propagation out of environment scripts

2023-01-12 Thread Tom Rini
On Tue, Dec 20, 2022 at 07:25:59AM +0100, Marek Vasut wrote: > Make sure the 'exit' command as well as 'exit $val' command exits > from environment scripts immediately and propagates return value > out of those scripts fully. That means the following behavior is > expected: > > " > => setenv foo

Re: [PATCH v2 2/2] test: cmd: exit: Add unit test for exit and partly run commands

2023-01-12 Thread Tom Rini
On Tue, Dec 20, 2022 at 07:26:00AM +0100, Marek Vasut wrote: > Add a test which validates that exit from environment script works as > expected, including return value propagation and clipping to positive > integers. > > Reviewed-by: Simon Glass > Signed-off-by: Marek Vasut Applied to u-boot/m

Re: [PATCH] ARM: dts: stm32: update vbus-supply of usbphyc_port0 on stm32mp157c-ev1

2023-01-12 Thread Patrice CHOTARD
Hi Fabrice On 1/3/23 17:27, Patrick DELAUNAY wrote: > Hi, > > On 12/12/22 11:32, Fabrice Gasnier wrote: >> phy-stm32-usbphyc bindings uses a connector node with vbus-supply >> property. >> >> [backport from linux 43e55d778a6b] >> Signed-off-by: Fabrice Gasnier >> --- >> >>   arch/arm/dts/stm32mp

Re: [PATCH] fs/squashfs: Only use export table if available

2023-01-12 Thread Tom Rini
On Sun, Dec 25, 2022 at 11:05:24AM +0100, David Oberhollenzer wrote: > For a squashfs filesystem, the fragment table is followed by > the following tables: NFS export table, ID table, xattr table. > > The export and xattr tables are both completely optional, but > the ID table is mandatory. The L

Re: [PATCH 1/2] test: compression: check with trailing garbage in input

2023-01-12 Thread Tom Rini
On Wed, Dec 28, 2022 at 04:53:51PM -0600, Brandon Maier wrote: > The Linux kernel appends 4 bytes to the end of compressed kernel Images > containing the uncompressed image size. They are used to make > self-decompressing Images easier. However for archs that don't support > self-decompression, li

Re: [PATCH 2/2] test: compression: use ut_assert for errors

2023-01-12 Thread Tom Rini
On Wed, Dec 28, 2022 at 04:53:52PM -0600, Brandon Maier wrote: > Use the ut_assert macros for more useful error messages. > > Signed-off-by: Brandon Maier > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH u-boot] ata: Fix dependency for CONFIG_SATA_SIL

2023-01-12 Thread Tom Rini
On Thu, Dec 29, 2022 at 06:15:35PM +0100, Pali Rohár wrote: > sata_sil.c is PCI driver and without CONFIG_PCI is building of U-Boot failing: > > LD u-boot > ld.bfd: drivers/ata/sata_sil.o: in function `sil_exec_cmd': > drivers/ata/sata_sil.c:148: undefined reference to `dm_pci_

Re: [PATCH] fs/btrfs: handle data extents, which crosss stripe boundaries, correctly

2023-01-12 Thread Tom Rini
On Fri, Dec 30, 2022 at 09:07:05AM +0800, Qu Wenruo wrote: > [BUG] > Since btrfs supports single device RAID0 at mkfs time after btrfs-progs > v5.14, if we create a single device raid0 btrfs, and created a file > crossing stripe boundary: > > # mkfs.btrfs -m dup -d raid0 test.img > # mount te

Re: [PATCH 1/1] Dockerfile: add package texinfo

2023-01-12 Thread Tom Rini
On Fri, Dec 30, 2022 at 05:41:01AM +0100, Heinrich Schuchardt wrote: > In preparation of adding the infodocs target to our CI install the > prerequisite texinfo software package. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP s

Re: [PATCH v2 1/1] Kconfig: clean up skipping low-level initialization

2023-01-12 Thread Tom Rini
On Fri, Dec 30, 2022 at 07:41:28PM +0100, Heinrich Schuchardt wrote: > Put all entries for skipping low-level initialization into a sub-menu. > Use different titles for main U-Boot, SPL, TPL. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass > Reviewed-by: Tom Rini Applied to

Re: [PATCH] Use `grep -E` or plain `grep` instead of `egrep`

2023-01-12 Thread Tom Rini
On Sun, Jan 01, 2023 at 06:41:42PM +0200, Ville Skyttä wrote: > `egrep` has been deprecated in GNU grep since 2007, > and since 3.8 it emits obsolescence warnings: > https://git.savannah.gnu.org/cgit/grep.git/commit/?id=a9515624709865d480e3142fd959bccd1c9372d1 > Acked-by: Dhruva Gole Applied to

Re: [PATCH 1/1] Kconfig: move NXP specific stuff into a sub-menu

2023-01-12 Thread Tom Rini
On Sat, Dec 31, 2022 at 12:08:47AM +0100, Heinrich Schuchardt wrote: > Having NXP specific items in the main menu is confusing. Especially > the comment line > >*** Other functionality shared between NXP SoCs *** > > is simply misleading. > > Move all NXP stuff into a separate sub-menu. >

Re: [PATCH 1/3] usb: onboard-hub: add driver to manage onboard hub supplies

2023-01-12 Thread Patrice CHOTARD
Hi Fabrice On 1/3/23 17:34, Patrick DELAUNAY wrote: > Hi, > > On 12/12/22 11:44, Fabrice Gasnier wrote: >> The main issue the driver addresses is that a USB hub needs to be >> powered before it can be discovered. This is often solved by using >> "regulator-always-on". >> >> This driver is inspire

Re: [PATCH 2/3] configs: stm32: enable USB onboard HUB driver

2023-01-12 Thread Patrice CHOTARD
HI Fabrice On 12/12/22 11:44, Fabrice Gasnier wrote: > Activate the USB onboard HUB driver, that is used to enable the HUB supply > on STM32MP15 EVAL, DK1 and DK2 boards. > This avoids marking the 3v3 corresponding regulator as always-on. > > Signed-off-by: Fabrice Gasnier > --- > > configs/st

Re: [PATCH 3/3] ARM: dts: stm32: add support for USB2514B onboard hub on stm32mp157c-ev1

2023-01-12 Thread Patrice CHOTARD
Hi Fabrice On 12/12/22 11:44, Fabrice Gasnier wrote: > Add support for USB2514B onboard hub on stm32mp157c EV1 board. The HUB > is supplied by a 3v3 PMIC regulator. > > [backport from linux ad9591b01d24] > Signed-off-by: Fabrice Gasnier > --- > > arch/arm/dts/stm32mp157c-ev1.dts | 8 >

Re: [PATCH] adc: stm32mp15: add calibration support

2023-01-12 Thread Patrice CHOTARD
Hi OLivier On 1/3/23 18:08, Patrick DELAUNAY wrote: > Hi, > > On 12/15/22 13:51, Olivier Moysan wrote: >> Add support of offset and linear calibration for STM32MP15. >> The calibration is performed once at probe. The ADC is set in power on >> state for calibration. It remains in this state after

Re: [PATCH 1/3] ARM: dts: stm32mp15: remove clksrc include in SCMI dtsi file

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 12/14/22 16:24, Patrick Delaunay wrote: > The include file stm32mp1-clksrc.h is not necessary for the SCMI STM32MP15 > dtsi files as the clock tree is not defined in the U-Boot SCMI device tree; > these SCMI device tree only support TFABOOT with stm32mp15_defconfig, > SPL with the ba

Re: [PATCH 2/3] ARM: dts: stm32mp15: fix typo in stm32mp15xx-dkx.dtsi

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 12/14/22 16:25, Patrick Delaunay wrote: > Remove unnecessary space in device tree stm32mp15xx-dkx.dtsi. > > Signed-off-by: Patrick Delaunay > --- > > arch/arm/dts/stm32mp15xx-dkx.dtsi | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/dt

Re: [PATCH 3/3] ARM: dts: stm32: Add timer interrupts on stm32mp15

2023-01-12 Thread Patrice CHOTARD
HI Patrick On 12/14/22 16:25, Patrick Delaunay wrote: > The timer units in the stm32mp15x CPUs have interrupts, depending on the > timer flavour either one "global" or four dedicated ones. Add the irqs > to the timer units on stm32mp15x. > > Sync the DT Files with linux kernel v6.1 and with commi

Re: [PATCH 1/6] stm32mp: cosmetic: Update of bsec driver

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > Remove unnecessary return in stm32mp_bsec_write_lock and replace tab > by space for plat_auto opts. > > Signed-off-by: Patrick Delaunay > --- > > arch/arm/mach-stm32mp/bsec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > d

Re: [PATCH 2/6] stm32mp: Add OP-TEE support in bsec driver

2023-01-12 Thread Patrice CHOTARD
HI Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > When OP-TEE is used, the SMC for BSEC management are not available and > the STM32MP BSEC pseudo TA must be used (it is mandatory for STM32MP13 > and it is a new feature for STM32MP15x). > > The BSEC driver try to open a session to this PTA BS

Re: [PATCH 3/6] stm32mp: Add support of STM32MP13x in bsec driver

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > Add support for "st,stm32mp13-bsec" for STM32MP13x in the > bsec driver based on OP-TEE pseudo TA STM32MP BSEC. > > Signed-off-by: Patrick Delaunay > --- > > arch/arm/mach-stm32mp/bsec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

Re: [PATCH 4/6] configs: stm32mp13: Activate CONFIG_CMD_FUSE

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > Activate the command fuse to access on STM32MP13x OTP with > the BSEC driver. > > Signed-off-by: Patrick Delaunay > --- > > configs/stm32mp13_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/stm32mp13_defconfig b/

Re: [PATCH 6/6] configs: stm32mp13: Activate command stm32key

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/6/23 13:20, Patrick Delaunay wrote: > Activate the command stm32key with CONFIG_CMD_STM32KEY. > > Signed-off-by: Patrick Delaunay > --- > > configs/stm32mp13_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defc

Re: [Uboot-stm32] [PATCH 5/6] board: st: Add support of STM32MP13x boards in stm32board cmd

2023-01-12 Thread Patrice CHOTARD
Hi Patrick On 1/12/23 15:34, Patrice CHOTARD wrote: > Hi Patrick > > On 1/6/23 13:20, Patrick Delaunay wrote: >> Add board identifiers for STMicroelectronics STM32MP13x boards: >> - DISCO board: MB1635 >> >> Signed-off-by: Patrick Delaunay >> --- >> >> board/st/common/Kconfig | 2 +- >> b

Re: u-boot: signature check for u-boot scripts

2023-01-12 Thread Sean Anderson
On 1/11/23 01:13, Heiko Schocher wrote: > Hello Sean, > > Thanks for your answer! > > On 10.01.23 17:27, Sean Anderson wrote: >> On 1/10/23 08:18, Heiko Schocher wrote: >>> Hello Simon, > [...] >>> While writting this email ... in [3] the line >>> >>> require = "conf" >>> >>> poped into my eyes

[PATCH v3 1/6] tpm: Fix spelling for tpmu_ha union

2023-01-12 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 737e57551d..85feda3e06 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -167,7 +167

[PATCH v3 0/6] tpm: Support boot measurements

2023-01-12 Thread Eddie James
This series adds support for measuring the boot images more generically than the existing EFI support. Several EFI functions have been moved to the TPM layer. The series includes optional measurement from the bootm command. A new test case has been added for the bootm measurement to test the new p

[PATCH v3 3/6] bootm: Support boot measurement

2023-01-12 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James --- boot/Kconfig| 23 boot/bootm.c| 70 + cmd/booti.c

[PATCH v3 5/6] test: Add sandbox TPM boot measurement

2023-01-12 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James --- arch/sandbox/dts/sandbox.dtsi | 14 arch/sandbox/dts/test.dts | 13 +++ configs/sandbox_defconfig | 1 + include/test/suites.h | 1 + test/boot/Makefile

[PATCH v3 4/6] tpm: sandbox: Update for needed TPM2 capabilities

2023-01-12 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- drivers/tpm/tpm2_tis_sandbox.c | 100 - 1 file changed, 72 inse

[PATCH v3 6/6] doc: Add measured boot documentation

2023-01-12 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James --- doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 doc/usage/measured_boot.rst diff --git a/doc/usage/index.

[PATCH v3 2/6] tpm: Support boot measurements

2023-01-12 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- include/efi_t

Re: [PATCH v2 1/2] lib: zstd: update to latest Linux zstd 1.5.2

2023-01-12 Thread Maier, Brandon L Collins
Hi Tom > On Fri, Jan 06, 2023 at 11:26:36PM +, Maier, Brandon L: > > > From: Tom Rini > > > It's all not ideal, yes, but it looks like BTRFS is the main user, right > > > now, which > > > isn't widely enabled. So maybe we can look towards improving upstream a > > > bit here, if motivated. >

Re: [PATCH v2 1/2] lib: zstd: update to latest Linux zstd 1.5.2

2023-01-12 Thread Tom Rini
On Thu, Jan 12, 2023 at 04:20:45PM +, Maier, Brandon L Collins wrote: > Hi Tom > > > On Fri, Jan 06, 2023 at 11:26:36PM +, Maier, Brandon L: > > > > From: Tom Rini > > > > It's all not ideal, yes, but it looks like BTRFS is the main user, > > > > right now, wh

[PATCH v4 2/2] test: compression: add zstd uncompression test

2023-01-12 Thread Brandon Maier
Signed-off-by: Brandon Maier --- v2: - added zstd uncompression test v3: - use sizeof() instead of magic number for length --- test/Kconfig | 2 +- test/compression.c | 71 ++ 2 files changed, 72 insertions(+), 1 deletion(-) diff --git a/test/Kc

Re: [PATCH 1/3] usb: onboard-hub: add driver to manage onboard hub supplies

2023-01-12 Thread Marek Vasut
On 1/12/23 16:24, Patrice CHOTARD wrote: Hi Fabrice On 1/3/23 17:34, Patrick DELAUNAY wrote: Hi, On 12/12/22 11:44, Fabrice Gasnier wrote: The main issue the driver addresses is that a USB hub needs to be powered before it can be discovered. This is often solved by using "regulator-always-on"

Re: [PATCH 1/3] usb: onboard-hub: add driver to manage onboard hub supplies

2023-01-12 Thread Marek Vasut
On 12/12/22 11:44, Fabrice Gasnier wrote: The main issue the driver addresses is that a USB hub needs to be powered before it can be discovered. This is often solved by using "regulator-always-on". This driver is inspired by the Linux v6.1 driver. It only enables (or disables) the hub vdd (3v3)

[PATCH] vbe: Allow probing the VBE bootmeth to fail in OS fixup

2023-01-12 Thread Simon Glass
This device is created when there are no bootmeths defined in the device tree. But it cannot be probed with a device tree node. For now, ignore a probe failure. Signed-off-by: Simon Glass Reported-by: Karsten Merker Suggested-by: Heinrich Schuchardt --- boot/vbe_simple_os.c | 12

[PATCH v4 1/2] serial: mxc: Wait for TX completion before reset

2023-01-12 Thread Loic Poulain
The u-boot console may show some corrupted characters when printing in board_init() due to reset or baudrate change of the UART (probe) before the TX FIFO has been completely drained. To fix this issue, and in case UART is still running, we now try to flush the FIFO before proceeding to UART reini

[PATCH v4 2/2] serial: mxc: Speed-up character transmission

2023-01-12 Thread Loic Poulain
Instead of waiting for empty FIFO condition before writing a character, wait for non-full FIFO condition. This helps in saving several tens of milliseconds during boot (depending verbosity). Signed-off-by: Loic Poulain Tested-by: Lothar Waßmann Acked-by: Pali Rohár --- v2: fixing transfert ab

Re: [PATCH u-boot 2/2] Makefile: Build working u-boot-dtb.bin target also for mpc85xx

2023-01-12 Thread Pali Rohár
On Thursday 12 January 2023 11:50:32 Heiko Schocher wrote: > Hello Pali, > > On 12.01.23 07:27, Heiko Schocher wrote: > > Hello Pali, > > > > On 11.01.23 19:13, Pali Rohár wrote: > >> On Wednesday 11 January 2023 19:02:38 Pali Rohár wrote: > >>> On Wednesday 11 January 2023 18:55:40 Pali Rohár wr

Re: [PATCH v4 1/2] serial: mxc: Wait for TX completion before reset

2023-01-12 Thread Pali Rohár
On Thursday 12 January 2023 18:19:50 Loic Poulain wrote: > The u-boot console may show some corrupted characters when > printing in board_init() due to reset or baudrate change > of the UART (probe) before the TX FIFO has been completely > drained. > > To fix this issue, and in case UART is still

Re: [PATCH v4 1/2] serial: mxc: Wait for TX completion before reset

2023-01-12 Thread Fabio Estevam
On Thu, Jan 12, 2023 at 2:19 PM Loic Poulain wrote: > > The u-boot console may show some corrupted characters when > printing in board_init() due to reset or baudrate change > of the UART (probe) before the TX FIFO has been completely > drained. > > To fix this issue, and in case UART is still run

Re: [PATCH v4 2/2] serial: mxc: Speed-up character transmission

2023-01-12 Thread Fabio Estevam
On Thu, Jan 12, 2023 at 2:19 PM Loic Poulain wrote: > > Instead of waiting for empty FIFO condition before writing a > character, wait for non-full FIFO condition. > > This helps in saving several tens of milliseconds during boot > (depending verbosity). > > Signed-off-by: Loic Poulain > Tested-b

Re: [PATCH v3 2/4] ARM: stm32: Factor out save_boot_params

2023-01-12 Thread Marek Vasut
On 1/12/23 16:06, Patrice CHOTARD wrote: Hi Marek Hi, I am preparing the next STM32 U-Boot pull request, during testing, buidlman is complaining with the following warning: 03: ARM: stm32: Factor out save_boot_params arm: + stm32mp13 +../arch/arm/mach-stm32mp/boot_params.c: In fu

[PATCH v4 1/4] ARM: stm32: Fix ECDSA authentication with Dcache enabled

2023-01-12 Thread Marek Vasut
In case Dcache is enabled while the ECDSA authentication function is called via BootROM ROM API, the MMU tables are set up and the BootROM region is not marked as executable, so an attempt to run code from it results in a hang. Mark the BootROM region as executable as suggested by Patrick to preven

[PATCH v4 2/4] ARM: stm32: Factor out save_boot_params

2023-01-12 Thread Marek Vasut
The STM32MP15xx platform currently comes with two incompatible implementations of save_boot_params() weak function override. Factor the save_boot_params() implementation into common cpu.c code and provide accessors to read out both ROM API table address and DT address from any place in the code ins

[PATCH v4 3/4] ARM: stm32: Pass ROM API table pointer to U-Boot proper

2023-01-12 Thread Marek Vasut
The ROM API table pointer is no longer accessible from U-Boot, fix this by passing the ROM API pointer through. This makes it possible for U-Boot to call ROM API functions to authenticate payload like signed fitImages. Reviewed-by: Patrice Chotard Reviewed-by: Patrick Delaunay Signed-off-by: Mar

[PATCH v4 4/4] ARM: stm32: Make ECDSA authentication available to U-Boot

2023-01-12 Thread Marek Vasut
With U-Boot having access to ROM API call table, it is possible to use the ROM API call it authenticate e.g. signed kernel fitImages using the BootROM ECDSA support. Make this available by pulling the ECDSA BootROM call support from SPL-only guard. Reviewed-by: Patrice Chotard Reviewed-by: Patric

Re: [PATCH v4 2/2] serial: mxc: Speed-up character transmission

2023-01-12 Thread Fabio Estevam
On Thu, Jan 12, 2023 at 2:52 PM Fabio Estevam wrote: > > On Thu, Jan 12, 2023 at 2:19 PM Loic Poulain wrote: > > > > Instead of waiting for empty FIFO condition before writing a > > character, wait for non-full FIFO condition. > > > > This helps in saving several tens of milliseconds during boot

Re: [PATCH 1/7] drivers: net: fsl-mc: remove useless assignment of variable

2023-01-12 Thread Ramon Fried
On Thu, 12 Jan 2023, 12:58 Ioana Ciornei, wrote: > On Tue, Jan 10, 2023 at 07:04:00PM +0200, Ramon Fried wrote: > > On Thu, Jan 5, 2023 at 5:03 PM Ioana Ciornei > wrote: > > > > > > The cur_ptr variable is set to the start of the log buffer but then > it's > > > not used. Just remove the assignm

[PATCH 1/1] doc: build infodocs target on Gitlab CI, Azure

2023-01-12 Thread Heinrich Schuchardt
Add infodocs target to CI testing. Signed-off-by: Heinrich Schuchardt --- .azure-pipelines.yml | 5 +++-- .gitlab-ci.yml | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml index 5fe3b8751d..49fc34fbf2 100644 --- a/.azure-pi

Re: [PATCH] vbe: Allow probing the VBE bootmeth to fail in OS fixup

2023-01-12 Thread Heinrich Schuchardt
On 1/12/23 17:50, Simon Glass wrote: This device is created when there are no bootmeths defined in the device tree. But it cannot be probed with a device tree node. %s/with/without/ (Actually a node is not enough. You also need a bunch of properties, too.) Fixes: a56f663f0707 ("vbe: Add info

Re: kernel doesn't start on Odroid U2 unless setting initrd_high

2023-01-12 Thread Joost van Zwieten
On Wed, Jan 11, 2023 at 19:10, Tom Rini wrote: On Wed, Jan 11, 2023 at 10:08:59PM +0100, Joost van Zwieten wrote: On Wed, Jan 11, 2023 at 15:38, Tom Rini wrote: > On Wed, Jan 11, 2023 at 09:28:42PM +0100, Joost van Zwieten wrote: > > > > > > On Tue, Jan 10, 2023 at 18:29, Tom Rini

Re: u-boot: signature check for u-boot scripts

2023-01-12 Thread Simon Glass
Hi, On Thu, 12 Jan 2023 at 09:03, Sean Anderson wrote: > > On 1/11/23 01:13, Heiko Schocher wrote: > > Hello Sean, > > > > Thanks for your answer! > > > > On 10.01.23 17:27, Sean Anderson wrote: > >> On 1/10/23 08:18, Heiko Schocher wrote: > >>> Hello Simon, > > [...] > >>> While writting this em

Re: [PATCH v3 2/6] tpm: Support boot measurements

2023-01-12 Thread Simon Glass
Hi Eddie, On Thu, 12 Jan 2023 at 09:16, Eddie James wrote: > > Add TPM2 functions to support boot measurement. This includes > starting up the TPM, initializing/appending the event log, and > measuring the U-Boot version. Much of the code was used in the > EFI subsystem, so remove it there and us

Re: [PATCH v3 3/6] bootm: Support boot measurement

2023-01-12 Thread Simon Glass
Hi Eddie, On Thu, 12 Jan 2023 at 09:16, Eddie James wrote: > > Add a configuration option to measure the boot through the bootm > function. Add the measurement state to the booti and bootz paths > as well. > > Signed-off-by: Eddie James > --- > boot/Kconfig| 23 > boot/boot

Re: U-Boot v2023.01 broken on riscv64 qemu virt platform: "fdt fixup event failed"

2023-01-12 Thread Simon Glass
Hi Heinrich, On Wed, 11 Jan 2023 at 16:22, Heinrich Schuchardt wrote: > > On 1/11/23 20:08, Karsten Merker wrote: > > Hello, > > > > it looks like U-Boot v2023.01 is currently broken for the riscv64 > > architecture on the qemu "virt" platform; the boot process of a > > riscv64 VM fails during FD

Re: [PATCH v8 03/10] arm_ffa: introduce Arm FF-A low-level driver

2023-01-12 Thread Simon Glass
Hi Rob, On Wed, 11 Jan 2023 at 19:10, Rob Herring wrote: > > On Mon, Dec 19, 2022 at 1:21 PM Simon Glass wrote: > > > > Hi Abdellatif, > > > > On Mon, 19 Dec 2022 at 04:12, Abdellatif El Khlifi > > wrote: > > > > > > On Mon, Dec 05, 2022 at 09:49:30AM -0600, Rob Herring wrote: > > > > On Sun, D

Re: [PATCH] dm: pinctrl: Revert "pinctrl: probe pinctrl drivers during post-bind"

2023-01-12 Thread Simon Glass
Hi, On Tue, 3 Jan 2023 at 10:05, Simon Glass wrote: > > Hi Robert, > > On Fri, 30 Dec 2022 at 13:26, Robert Marko wrote: > > > > > > > > On Fri, Dec 30, 2022 at 8:02 PM Simon Glass wrote: > >> > >> Hi Pali, > >> > >> On Fri, 30 Dec 2022 at 12:02, Pali Rohár wrote: > >> > > >> > On Friday 30 De

Re: [PATCH 1/1] doc: build infodocs target on Gitlab CI, Azure

2023-01-12 Thread Simon Glass
On Thu, 12 Jan 2023 at 12:31, Heinrich Schuchardt wrote: > > Add infodocs target to CI testing. > > Signed-off-by: Heinrich Schuchardt > --- > .azure-pipelines.yml | 5 +++-- > .gitlab-ci.yml | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass

[PATCH v2] vbe: Allow probing the VBE bootmeth to fail in OS fixup

2023-01-12 Thread Simon Glass
This device is created when there are no bootmeths defined in the device tree. But it cannot be probed without a device tree node. For now, ignore a probe failure. Signed-off-by: Simon Glass Reported-by: Karsten Merker Suggested-by: Heinrich Schuchardt Fixes: a56f663f0707 ("vbe: Add info about

Re: [PATCH 1/3] sunxi: mmc: ignore card detect in SPL

2023-01-12 Thread Andre Przywara
On Sun, 8 Jan 2023 15:00:29 -0600 Samuel Holland wrote: Hi Samuel, > Thanks for helping to get rid of sunxi_name_to_gpio(). many thanks for the review, that's much appreciated. > > On 7/13/22 11:21, Andre Przywara wrote: > > The sunxi MMC code does not use the DM in the SPL, as we don't have

patman: ModuleNotFoundError

2023-01-12 Thread Tony Dinh
Hi Simon, I've updated to the latest u-boot master, and saw this error. ./tools/patman/patman --help Traceback (most recent call last): File "/usr/src/u-boot-master/./tools/patman/patman", line 23, in from patman import func_test File "/usr/src/u-boot-master/tools/patman/../patman/func_

Re: [PATCH 1/1] doc: build infodocs target on Gitlab CI, Azure

2023-01-12 Thread Tom Rini
On Thu, Jan 12, 2023 at 08:30:58PM +0100, Heinrich Schuchardt wrote: > Add infodocs target to CI testing. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH] console: Add option to keep it silent until env is loaded

2023-01-12 Thread Tom Rini
On Wed, Jul 06, 2022 at 01:19:10PM +0200, Harald Seiler wrote: > Add a config-option which forces the console to stay silent until the > proper environment is loaded from flash. > > This is important when the default environment does not silence the > console but no output must be printed when 's

Re: [PATCH v3 1/2] dm: fix probing of all devices that have u-boot, dm-pre-reloc in SPL/TPL

2023-01-12 Thread Tom Rini
On Thu, Sep 22, 2022 at 05:53:25PM +0200, Quentin Schulz wrote: > From: Quentin Schulz > > Currently, dm_probe_devices checks that the flags of the device contains > DM_FLAG_PRE_RELOC. However DM_FLAG_PRE_RELOC is a driver - and not a > device - flag. This means that the check in pre_reloc_only

Re: [PATCH v3 2/2] gpio: Get rid of gpio_hog_probe_all()

2023-01-12 Thread Tom Rini
On Thu, Sep 22, 2022 at 05:53:26PM +0200, Quentin Schulz wrote: > From: Marek Vasut > > The gpio_hog_probe_all() functionality can be perfectly well replaced by > DM_FLAG_PROBE_AFTER_BIND DM flag, which would trigger .probe() callback > of each GPIO hog driver instance after .bind() and thus con

Re: [PATCH] cmd: spi: Judge the number of added parameters

2023-01-12 Thread Tom Rini
On Tue, Dec 06, 2022 at 05:24:38PM +0800, chenzhipeng wrote: > When only sspi is entered, help information can be printed. > > Signed-off-by: chenzhipeng > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] common: spl: ram: fix return code

2023-01-12 Thread Tom Rini
On Mon, Dec 12, 2022 at 11:03:35AM +0300, Nikita Shubin wrote: > From: Nikita Shubin > > Instead of always retuning success, return actual result of > load_simple_fit_image or spl_parse_image_header, otherwise we > might end up jumping on uninitialized spl_image->entry_point. > > Signed-off-by:

Re: [PATCH v2 1/3] Uboot RNG Driver using Data Co-processor

2023-01-12 Thread Tom Rini
On Thu, Dec 22, 2022 at 09:50:27AM +0100, Kshitiz Varshney wrote: > This commit introduces Random number generator to uboot. It uses DCP > driver for number generation. > RNG driver can be invoked by using below command on uboot prompt:- >rng > > Signed-off-by: Kshitiz Varshney > Re

Re: [PATCH v2 2/3] Added dcp_rng driver initialization code

2023-01-12 Thread Tom Rini
On Thu, Dec 22, 2022 at 09:50:28AM +0100, Kshitiz Varshney wrote: > This commit initializes dcp_rng device driver inside > arch_misc_init() function. > > Signed-off-by: Kshitiz Varshney > Reviewed-by: Ye Li Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

  1   2   >