Re: [PATCH 2/2] CI: Make use of buildman requirements.txt

2023-05-04 Thread Neha Malcom Francis
Hi Tom On 04/05/23 18:32, Tom Rini wrote: On Thu, May 04, 2023 at 09:42:54AM +0530, Neha Malcom Francis wrote: Hi Tom, On 03/05/23 18:34, Tom Rini wrote: On Wed, May 03, 2023 at 11:27:20AM +0530, Neha Malcom Francis wrote: Hi Tom Thanks for these patches! On 27/04/23 01:14, Tom Rini

Re: [PATCH 1/1] arm64: dts: ti: k3-j721s2: Add reserved status in msmc

2023-05-04 Thread Kumar, Udit
On 5/3/2023 8:21 PM, Nishanth Menon wrote: On 20:17-20230503, Udit Kumar wrote: Mark atf, l3-cache and tifs node as reserved. why? (I am not reading the cover-letter for a 1 patch) My bad , I should have description in patch itself. Thanks [...] 2.34.1

Re: [EXTERNAL] [PATCH v3 25/43] x86: Pass video settings from SPL to U-Boot proper

2023-05-04 Thread Nikhil M Jain
On 05/05/23 04:28, Simon Glass wrote: When video is set up in SPL, U-Boot proper needs to use the correct parameters so it can write to the display. Put these in a bloblist so they are available to U-Boot proper. Signed-off-by: Simon Glass --- Changes in v3: - Add a tag name for the blob

[GIT PULL] please pull fsl-qoirq-2023-5-5

2023-05-04 Thread Peng Fan
Hi Tom, Please pull fsl-qoirq-2023-5-5 -- fsl-ls1088a device tree update enable DM_SERIAL for ten64 check for crypto node first in fdt_fixup_remove_jr -- CI:

Re: Pull Request / Patch: Enable Usage of ECC with DDR on AM654x

2023-05-04 Thread Tom Rini
On Thu, May 04, 2023 at 12:47:29PM +, Roytburd, Benjamin wrote: o > Hello, > > Recently, when working with the AM65x_GP_EVM development board, I found that > the U-boot source code (specifically the SPL), does not properly initialize > the DDRSS ram drivers for the AM6548. There are missing

Re: [PATCH v2 3/3] configs: j7200: Merge the HS and non-HS defconfigs

2023-05-04 Thread Tom Rini
On Thu, May 04, 2023 at 11:07:08AM +0530, Manorit Chawdhry wrote: > K3 devices have runtime type board detection. Make the default defconfig > include the secure configuration. Then remove the HS specific config. > > Non-HS devices will continue to boot due to runtime device type detection. > If

Re: [PATCH v2 2/3] Kconfig: j721s2: Change K3_MCU_SCRATCHPAD_BASE to non firewalled region

2023-05-04 Thread Tom Rini
On Thu, May 04, 2023 at 11:07:07AM +0530, Manorit Chawdhry wrote: > On K3 HS-SE devices all the firewalls are locked by default > until sysfw comes up. Rom configures some of the firewall for its usage > along with the SRAM for R5 but the PSRAM region is still locked. > > The K3 MCU Scratchpad

Re: [PATCH v2 1/3] configs: j721s2: Merge the HS and non-HS defconfigs

2023-05-04 Thread Tom Rini
On Thu, May 04, 2023 at 11:07:06AM +0530, Manorit Chawdhry wrote: > K3 devices have runtime type board detection. Make the default defconfig > include the secure configuration. Then remove the HS specific config. > > Non-HS devices will continue to boot due to runtime device type detection. > If

Re: [PATCH] arm: dts: iot2050: Include u-boot specific bits implicitly

2023-05-04 Thread Tom Rini
On Tue, Apr 25, 2023 at 09:28:23PM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Create *-u-boot.dtsi files for each target dtb of the IOT2050 series so > that we can drop the #include deviations from upstream dts[i] files > here. > > Signed-off-by: Jan Kiszka Applied to u-boot/master,

Re: [PATCH] environment: ti: Add get_fit_config command to get FIT config string

2023-05-04 Thread Tom Rini
On Tue, Apr 25, 2023 at 11:20:45AM -0500, Andrew Davis wrote: > When OE is packaging a dtb file into the FIT image it names the node based > on the dtb filename. Node names can't have "/" so it is turned into "_". > We select our FIT config using the "fdtfile" env var so we don't duplicate > the

Re: [PATCH] configs: am62x: enable secure device configs by default

2023-05-04 Thread Tom Rini
On Wed, Apr 05, 2023 at 05:40:47PM -0500, Praneeth Bajjuri wrote: > Enable the CONFIG_TI_SECURE_DEVICE by default > > Non-HS devices will continue to boot due to runtime device type detection. > > TI's security enforcing SoCs will authenticate each binary it loads by > comparing it's signature

Re: [PATCH 0/2] Update DDR configs to latest tested version

2023-05-04 Thread Tom Rini
On Tue, 25 Apr 2023 18:39:26 +0530, Neha Malcom Francis wrote: > This series aims to update the DDR dtsi files that are generated by the > Jacinto 7 DDRSS Configuration tool. > > It updates J721E and J7200 to generated files of two different versions > of the same tool as these are the latest

Re: [PATCH] k3: pmic: Clear ESM masks

2023-05-04 Thread Tom Rini
On Wed, Apr 05, 2023 at 04:24:35PM +0530, Neha Malcom Francis wrote: > ESM MCU masks must be set to 0h so that PMIC can handle errors > that require attention for example SYS_SAFETY_ERRn. The required bits > must be cleared: ESM_MCU_RST_MASK, ESM_MCU_FAIL_MASK, ESM_MCU_PIN_MASK. > > If PMIC

Re: [PATCH V9 00/14] Add splash screen support at u-boot SPL

2023-05-04 Thread Tom Rini
On Thu, May 04, 2023 at 06:40:56PM -0600, Simon Glass wrote: > Hi, > > On Thu, 20 Apr 2023 at 06:11, Nikhil M Jain wrote: > > > > To enable splash screen at SPL stage move video driver and splash screen > > framework at SPL, which will bring up image on display very quickly and > > thus have

Re: [PATCH v3 3/5] nvme: pci: Enable for SPL

2023-05-04 Thread Simon Glass
On Thu, 4 May 2023 at 03:53, Mayuresh Chitale wrote: > > Enable NVME and PCI NVMe drivers for SPL builds. Also enable PCI_PNP > for SPL which is required to auto configure the PCIe devices. > > Signed-off-by: Mayuresh Chitale > --- > drivers/Makefile | 1 + > drivers/nvme/Makefile | 2 +- >

Re: [PATCH v2 2/3] X86: Add support for distro boot

2023-05-04 Thread Simon Glass
Hi Mittelstaedt, On Wed, 3 May 2023 at 23:40, Mittelstaedt Thomas (XC-CT/EBV3) wrote: > > Hello Simon, > > I've tried out successfully the option (with BOOTSTD_FULL, with > BOOTSTD_DEFAULT it's not possible to boot) and will provide a changed patch > set soon. > Thank you for testing. What

Re: [PATCH v3 2/5] spl: blk: Support loading images from fs

2023-05-04 Thread Simon Glass
Hi Mayuresh, On Thu, 4 May 2023 at 03:53, Mayuresh Chitale wrote: > > Add a generic API to support loading of SPL payload from EXT or FAT > filesystem on a given partition of a block device. > > Signed-off-by: Mayuresh Chitale > --- > common/spl/Makefile | 1 + > common/spl/spl_blk_fs.c |

Re: [PATCH v3 1/5] spl: Add Kconfig options for NVME

2023-05-04 Thread Simon Glass
On Thu, 4 May 2023 at 03:53, Mayuresh Chitale wrote: > > Add kconfig options to enable NVME and PCI NVMe support in SPL > > Signed-off-by: Mayuresh Chitale > --- > common/spl/Kconfig | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/common/spl/Kconfig

Re: [PATCH 1/2] kbuild: add dtc as dependency on .dtb files

2023-05-04 Thread Simon Glass
On Thu, 4 May 2023 at 06:26, Rasmus Villemoes wrote: > > [Linux commit b8fc5b2157b1] > > If dtc is rebuilt, we should rebuild .dtb files with the new dtc. > > [Import notes: Back then there was no .dtbo rule in Linux's > Makefile.lib, but the current .dtbo rules in Linux also have the > $(DTC)

Re: [PATCH v2 15/18] spl: Commit MTRRs only in board_init_f_r()

2023-05-04 Thread Simon Glass
Hi Bin, On Thu, 4 May 2023 at 08:22, Bin Meng wrote: > > Hi Simon, > > On Tue, Apr 18, 2023 at 11:31 PM Simon Glass wrote: > > > > We don't need to commit the SPI-flash MTRR change immediately, since it is > > now done in the board_init_f_r(). Also this causes chromebook_link64 to > > hang. > >

Re: [PATCH V9 00/14] Add splash screen support at u-boot SPL

2023-05-04 Thread Simon Glass
Hi, On Thu, 20 Apr 2023 at 06:11, Nikhil M Jain wrote: > > To enable splash screen at SPL stage move video driver and splash screen > framework at SPL, which will bring up image on display very quickly and > thus have early display support in SPL. > > Changes in V9 > - Update as per review

Re: [PATCH v3 3/3] X86: pxeboot: bugfix: Set variable for size of initrd

2023-05-04 Thread Simon Glass
On Thu, 4 May 2023 at 07:43, wrote: > > From: Thomas Mittelstaedt > > The problem was, that zboot() didn't work because of missing > ramdisc size. > > Signed-off-by: Thomas Mittelstaedt > --- > boot/pxe_utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Fixes: 085cbdafca9

Re: [PATCH 2/2] kbuild: Allow DTB overlays to built from .dtso named source files

2023-05-04 Thread Simon Glass
On Thu, 4 May 2023 at 06:26, Rasmus Villemoes wrote: > > [Linux commit 363547d2191c] > > Currently DTB Overlays (.dtbo) are build from source files with the same > extension (.dts) as the base DTs (.dtb). This may become confusing and > even lead to wrong results. For example, a composite DTB

Re: [PATCH v3 4/5] spl: Support loading a FIT from ext FS

2023-05-04 Thread Simon Glass
Hi Mayuresh, On Thu, 4 May 2023 at 03:53, Mayuresh Chitale wrote: > > Detect a FIT when loading from an ext File system and handle it using > the FIT SPL support. > > Signed-off-by: Mayuresh Chitale > --- > common/spl/spl_ext.c | 33 + > 1 file changed, 33

Re: [PATCH v3 5/5] common: spl: Add spl NVMe boot support

2023-05-04 Thread Simon Glass
On Thu, 4 May 2023 at 03:53, Mayuresh Chitale wrote: > > Add support to load the next stage image from an NVMe disk which may > be formatted as an EXT or FAT filesystem. > > Signed-off-by: Mayuresh Chitale > --- > arch/riscv/include/asm/spl.h | 1 + > common/spl/Kconfig | 10

Re: [PATCH v3 2/3] X86: Add bootstd support

2023-05-04 Thread Simon Glass
On Thu, 4 May 2023 at 07:43, wrote: > > From: Thomas Mittelstaedt > > Enable bootstd support for U-Boot at VirtualBox described at > https://source.denx.de/u-boot/u-boot/-/blob/master/doc/develop/bootstd.rst > This is used to boot system images at Virtualbox via > - distroboot (extlinux.conf) >

Re: [PATCH v3 1/3] X86: Add support for SCSI devices

2023-05-04 Thread Simon Glass
On Thu, 4 May 2023 at 07:43, wrote: > > From: Thomas Mittelstaedt > > U-Boot at VirtualBox must load Linux and boot configuration from disk devices. > Here the discs at AHCI (scsi) bus are used to load the need boot data. > > Signed-off-by: Thomas Mittelstaedt > --- >

Re: [PATCH] scripts/Makefile.dts: tweak logic for deciding which dtbs to build

2023-05-04 Thread Simon Glass
On Thu, 4 May 2023 at 09:51, Tom Rini wrote: > > On Thu, May 04, 2023 at 01:33:08PM +0200, Rasmus Villemoes wrote: > > > The idea in 3609e1dc5f4d (dts: automatically build necessary .dtb > > files) was fine, but the implementation was suboptimal due to some > > misunderstandings on my part (and

Re: [PATCH 4/4] test: bdinfo: Add test for command bdinfo

2023-05-04 Thread Simon Glass
Hi Marek, On Thu, 4 May 2023 at 10:01, Marek Vasut wrote: > > On 5/4/23 17:51, Tom Rini wrote: > > On Sat, Apr 22, 2023 at 03:01:34PM +0200, Marek Vasut wrote: > > > >> Add test for command bdinfo . > >> > >> Signed-off-by: Marek Vasut > >> Reviewed-by: Simon Glass > >> --- > >> Cc: Jason Liu

[PATCH] ARM: stm32: Fix OF_LIST on DHCOR

2023-05-04 Thread Tom Rini
The ITS file used to build the images here lists three dtb files as being used. Today, these are built by the logic that will over-build dtb files based on SOC/etc symbols being set. To future proof this platform and be generally correct, we list all 3 of the device trees used here in OF_LIST.

[PATCH v3 27/43] pci: Adjust video BIOS debugging to be SPL-friendly

2023-05-04 Thread Simon Glass
A hex value is expected for the VGA mode. Drop the 0x prefix, which is not supported in SPL. Signed-off-by: Simon Glass --- (no changes since v1) drivers/pci/pci_rom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci_rom.c b/drivers/pci/pci_rom.c index

[PATCH v3 22/43] pci: Allow the video BIOS to work in SPL with QEMU

2023-05-04 Thread Simon Glass
QEMU emulates two common machines (Q35 and i440fx) which use mapping to determine whether RAM is present below 1MB. In order to copy the video BIOS to c we need to flip this mapping over to RAM. This does not happen automatically until SPL has finished running. Switch in RAM at these address

[PATCH v3 43/43] efi: Use the installed ACPI tables

2023-05-04 Thread Simon Glass
U-Boot sets up the ACPI tables during startup. Rather than creating a new set, install the existing ones. Create a memory-map record to cover the tables. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Drop patch to set high bits of the mtrr base register, for now

[PATCH v3 42/43] sandbox: Install ACPI tables on startup

2023-05-04 Thread Simon Glass
With x86 we set up the ACPI tables on startup so they can be examined. Do the same with sandbox, so it is consistent. Signed-off-by: Simon Glass --- (no changes since v1) board/sandbox/sandbox.c | 16 1 file changed, 16 insertions(+) diff --git a/board/sandbox/sandbox.c

[PATCH v3 41/43] sandbox: Correct header order in board file

2023-05-04 Thread Simon Glass
Fix the header order in this file. Signed-off-by: Simon Glass --- (no changes since v1) board/sandbox/sandbox.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/board/sandbox/sandbox.c b/board/sandbox/sandbox.c index 2e44bdf0df3..e72d8164ebf 100644 ---

[PATCH v3 34/43] x86: Refactor table-writing code a litlle

2023-05-04 Thread Simon Glass
The implementation of write_tables() is confusing because it uses the rom_table_start variable as the address pointer as it progresses. Rename it to rom_addr to make the code clearer. Move the rom_table_end variable into the block where it is used. Also update logging to use the ACPI category,

[PATCH v3 40/43] log: Support outputing function names in SPL

2023-05-04 Thread Simon Glass
The output is garbled when tiny printf() is used. Correct this by adding a special case. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to support outputing function names in SPL common/log_console.c | 10 -- 1 file changed, 8 insertions(+), 2

[PATCH v3 39/43] x86: Make sure that the LPC is active before SDRAM init

2023-05-04 Thread Simon Glass
Some boards need to access GPIOs to determine which SDRAM is fitted to the board, for example chromebook_link. Probe this device (if it exists) to make sure that this works as expected. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to make sure that the

[PATCH v3 32/43] fs: fat: Support reading from a larger block size

2023-05-04 Thread Simon Glass
At present it is not possible to read from some CDROM drives since the FAT sector size does not match the media's block size. Add a conversion option for this, so that reading is possible. This does increase SPL size for read-only FAT support by 25 bytes but all but 6 are covered by the previous

[PATCH v3 38/43] x86: link: Support Micron memory

2023-05-04 Thread Simon Glass
Add the required tag so that micron memory can be set up correctly. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to support Micron memory arch/x86/dts/chromebook_link.dts | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 36/43] x86: Show the number of physical address bits

2023-05-04 Thread Simon Glass
Add this information to global_data and show it with the 'bdinfo' command. For now we use CONFIG_CPU_ADDR_BITS to control the number of bits, but this could change if needed. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to show the number of physical

[PATCH v3 37/43] x86: Convert some debug statements to use logging

2023-05-04 Thread Simon Glass
Move from using debug() to log_debug() so that we don't have to use the __func__ parameter and can access other logging features. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to convert some debug statements to use logging

[PATCH v3 24/43] x86: Allow video-BIOS code to be built for SPL

2023-05-04 Thread Simon Glass
With qemu-x86_64 we need to run the video BIOS while in 32-bit mode, i.e. SPL. Add a Kconfig option for this, adjust the Makefile rules and use CONFIG_IS_ENABLED() where needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/Makefile | 7 --- arch/x86/lib/bios.c | 2

[PATCH v3 35/43] x86: Record the start and end of the tables

2023-05-04 Thread Simon Glass
The ACPI tables are special in that they are passed to EFI as a separate piece, independent of other tables. Also they can be spread over two areas of memory, e.g. with QEMU we end up with tables kept in high memory as well. Add new global_data fields to hold this information and update the

[PATCH v3 33/43] x86: Enable useful options for qemu-86_64

2023-05-04 Thread Simon Glass
This build can be used to boot standard distro builds, since these are mostly 64-bit these days. Enable some more options, so that all possible EFI UUIDs are decoded, we get a proper printf() in SPL, can search memory for tables, support the full set of standard-boot features, have full logging

[PATCH v3 31/43] fs: fat: Shrink the size of a few strings

2023-05-04 Thread Simon Glass
To save a few bytes, replace Error with ** and try to use the same string for multiple messages where possible. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Drop ** in strings and use log_err() for messages fs/fat/fat.c | 20 +++-

[PATCH v3 30/43] x86: Allow logging to be used in SPL reliably

2023-05-04 Thread Simon Glass
When global_data is relocated, log_head moves in memory, meaning that the items in that list point to the wrong place. Disable logging when making the change, then reenable it afterwards, so that logging works normally. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/spl.c

[PATCH v3 28/43] pci: Mask the ROM address in case it is already enabled

2023-05-04 Thread Simon Glass
In some cases the video ROM may have been enabled previously, such as by a previous firmware stage. Use the correct address in that case. Signed-off-by: Simon Glass --- (no changes since v1) drivers/pci/pci_rom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pci_rom.c

[PATCH v3 29/43] x86: Enable display for QEMU 64-bit

2023-05-04 Thread Simon Glass
Enable the various options needed for display to work on the qemu-x86_64 board. This includes expanding the available malloc() memory in SPL, since the PCI bus must be enumerated in order to find the video device. It also includes enabling a bloblist, so that the video parameters can be passed.

[PATCH v3 23/43] pci: Tidy up logging and reporting for video BIOS

2023-05-04 Thread Simon Glass
When running the ROM the code is not very helpful when something goes wrong. Add a little more debugging and some logging of return values to improve this. Signed-off-by: Simon Glass --- (no changes since v1) drivers/pci/pci_rom.c | 12 +--- 1 file changed, 9 insertions(+), 3

[PATCH v3 26/43] x86: Init video in SPL if enabled

2023-05-04 Thread Simon Glass
When video is required in SPL, set this up ready for use. Ignore any problems since it may be that video is not actually available and we still want to continue on to U-Boot proper in that case. Make sure that the SPL banner is only shown once. Signed-off-by: Simon Glass --- (no changes since

[PATCH v3 25/43] x86: Pass video settings from SPL to U-Boot proper

2023-05-04 Thread Simon Glass
When video is set up in SPL, U-Boot proper needs to use the correct parameters so it can write to the display. Put these in a bloblist so they are available to U-Boot proper. Signed-off-by: Simon Glass --- Changes in v3: - Add a tag name for the blob common/bloblist.c | 1 +

[PATCH v3 21/43] pci: Support autoconfig in SPL

2023-05-04 Thread Simon Glass
Allow PCI autoconfig to be handled in SPL, so that we can set it up correctly for boards which need to do this before U-Boot proper. This includes qemu-x64_64 which needs to set up the video device while in 32-bit mode. Signed-off-by: Simon Glass --- (no changes since v1) drivers/pci/Kconfig

[PATCH v3 20/43] nvme: Provide more useful debugging messages

2023-05-04 Thread Simon Glass
When scanning fails it is useful to be able to decode what went wrong. Add some debugging for this. Signed-off-by: Simon Glass --- (no changes since v1) drivers/nvme/nvme.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git

[PATCH v3 18/43] x86: Improve the trampoline in 64-bit mode

2023-05-04 Thread Simon Glass
At present this leaves the stack at the pre-relocation value. This is not ideal since we want to have U-Boot running entirely from the top of memory. In addition, the new global_data pointer is not actually used, since the global_data pointer itself is relocated, then the pre-relocation value is

[PATCH v3 19/43] Show the malloc base with the bdinfo command

2023-05-04 Thread Simon Glass
It is useful to see the base of the malloc region. This is visible when debugging but not in normal usage. Add it to the global data so that it can be shown. Signed-off-by: Simon Glass --- (no changes since v1) cmd/bdinfo.c | 1 + common/board_r.c | 7

[PATCH v3 15/43] video: Allow building video drivers for SPL

2023-05-04 Thread Simon Glass
Update the Makefile rules to allow video drivers in SPL. This is useful for 64-bit QEMU on x86, since the video BIOS can only be run from 32-bit mode (i.e. in SPL). Signed-off-by: Simon Glass --- (no changes since v1) drivers/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH v3 17/43] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

2023-05-04 Thread Simon Glass
The CMD_EFIDEBUG option enables debugging so it is reasonable to assume that all effects should be made to decode the dreaded UUIDs favoured by UEFI. Update the table to show them all when CONFIG_CMD_EFIDEBUG is enabled. Signed-off-by: Simon Glass --- (no changes since v1) lib/uuid.c | 2 +-

[PATCH v3 12/43] part: Allow setting the partition-table type

2023-05-04 Thread Simon Glass
Some devices have multiple partition types available on the same media. It is sometimes useful to see these to check that everything is working correctly. Provide a way to manually set the partition-table type, avoiding the auto-detection process. Signed-off-by: Simon Glass --- (no changes

[PATCH v3 14/43] log: Tidy up an ambiguous comment.

2023-05-04 Thread Simon Glass
Add a a bit more detail so it is clear that multiple devices are supported, but only one per driver. Signed-off-by: Simon Glass --- (no changes since v1) common/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/log.c b/common/log.c index 7cfc49bc28a..ec33b62e8a6

[PATCH v3 16/43] qfw: Set the address of the ACPI tables

2023-05-04 Thread Simon Glass
Once the ACPI tables have been set up, record their address so that it is possible to list them with 'acpi list'. Signed-off-by: Simon Glass --- (no changes since v1) drivers/misc/qfw.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/misc/qfw.c b/drivers/misc/qfw.c index

[PATCH v3 13/43] qfw: Show the file address if available

2023-05-04 Thread Simon Glass
Some files have an associated address. Show this with the 'qfw list' command so that it is possible to dump the data. Signed-off-by: Simon Glass --- (no changes since v1) cmd/qfw.c | 2 +- doc/usage/cmd/qfw.rst | 28 2 files changed, 17 insertions(+),

[PATCH v3 10/43] acpi: Add a comment to set the acpi tables

2023-05-04 Thread Simon Glass
Sometimes a previous bootloader has written ACPI tables. It is useful to be able to find and list these. Add an 'acpi set' command to set the address for these tables. Signed-off-by: Simon Glass --- (no changes since v1) cmd/acpi.c | 24 +---

[PATCH v3 11/43] bdinfo: Show the RAM top and approximate stack pointer

2023-05-04 Thread Simon Glass
These are useful pieces of information when debugging. The RAM top shows where U-Boot started allocating memory from, before it relocated. The stack pointer can be checked to ensure it is in the correct region. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Kconfig | 8

[PATCH v3 09/43] x86: Show an error when a BIOS exception occurs

2023-05-04 Thread Simon Glass
Rather than silently hanging, show an error first. This can happen when there is something wrong with the video BIOS. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Fix BINS typo - Drop the Ooops string arch/x86/lib/bios.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 07/43] x86: Show the CPU physical address size with bdinfo

2023-05-04 Thread Simon Glass
This is useful information so show it with the bdinfo command. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/bdinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/lib/bdinfo.c b/arch/x86/lib/bdinfo.c index 15390070fe8..0970efa4726 100644 ---

[PATCH v3 08/43] x86: Correct get_sp() implementation for 64-bit

2023-05-04 Thread Simon Glass
Use an assembler implementation as is done for i386, so that the results are equivalent. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/bootm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/bootm.c b/arch/x86/lib/bootm.c index

[PATCH v3 06/43] x86: Add a comment for board_init_f_r_trampoline()

2023-05-04 Thread Simon Glass
Add a comment for this function in the header. Change the function (and the one after) to use __noreturn to keep checkpatch happy. Add docs to board_init_f_r() while we are here. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add docs to board_init_f_r() too

[PATCH v3 05/43] x86: Tidy up EFI code in interrupt_init()

2023-05-04 Thread Simon Glass
The ll_boot_init() check handles the EFI case so we don't need the rest of the code. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/i386/interrupt.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/arch/x86/cpu/i386/interrupt.c

[PATCH v3 04/43] bios_emulator: Drop VIDEO_IO_OFFSET

2023-05-04 Thread Simon Glass
This is always zero in the source tree, so drop it. While we are here, add a comment to _X86EMU_env since it the symbol is actually defined twice, which can cause confusion when building. Signed-off-by: Simon Glass --- (no changes since v1) drivers/bios_emulator/biosemui.h | 18

[PATCH v3 03/43] bios_emulator: Add Kconfig and adjust Makefile for SPL

2023-05-04 Thread Simon Glass
The Kconfig for this is currently inside a particular board. Move it into the correct place and allow use in SPL, so that video can be used there if needed. Signed-off-by: Simon Glass --- (no changes since v1) board/google/Kconfig | 7 --- drivers/Kconfig | 2 ++

[PATCH v3 02/43] x86: mtrr: Add documentation

2023-05-04 Thread Simon Glass
Add documention for the x86 'mtrr' command. Signed-off-by: Simon Glass Suggested-by: Heinrich Schuchardt --- (no changes since v2) Changes in v2: - Add new patch with docs for mtrr command doc/usage/cmd/mtrr.rst | 151 + doc/usage/index.rst| 1 +

[PATCH v3 01/43] x86: Allow listing MTRRs in SPL

2023-05-04 Thread Simon Glass
Move MTRR-listing code into a common file so it can be used from SPL. Update the 'mtrr' command to call it. Use this in SPL just before adjusting the MTRRs, so we can see the state set up by the board. Only show it when debug is enabled. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v3 00/43] x86: Use qemu-x86_64 to boot EFI installers

2023-05-04 Thread Simon Glass
This series adds various minor features so that qemu-x86_64 can boot the Ubuntu 2022.04 installer using a virtio device: qemu-system-x86_64 -M pc -drive format=raw,file=root.img -bios /tmp/b/qemu-x86_64/u-boot.rom -drive if=virtio,file=ubuntu-22.04.2-desktop-amd64.iso

[PATCH v4 16/16] coreboot: Enable ms command

2023-05-04 Thread Simon Glass
This is useful when looking for tables in memory. Enable it for coreboot. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Add new patch to enable ms command configs/coreboot_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v4 14/16] nvme: Enable PCI bus mastering

2023-05-04 Thread Simon Glass
U-Boot sets up devices ready for use, but coreboot does not. Enable this so that NVMe works OK from coreboot. Signed-off-by: Simon Glass --- Changes in v4: - Split out patch to enable bus mastering drivers/nvme/nvme_pci.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v4 15/16] x86: nvme: coreboot: Enable NVMe

2023-05-04 Thread Simon Glass
Enable support for NVMe storage devices. Update the driver to enable the bus master bit, since coreboot does not do that automatically. Signed-off-by: Simon Glass --- Changes in v4: - Drop unnecessary CONFIG options - Drop patch to allow locating UARTs by device ID Changes in v2: - Drop patch

[PATCH v4 13/16] x86: coreboot: Show unimplemented sysinfo tags

2023-05-04 Thread Simon Glass
Sometimes coreboot adds new tags that U-Boot does not know about. These are silently ignored, but it is useful to at least know what we are missing. Add a way to collect this information. For Brya it shows: Unimpl. 38 41 37 34 42 40 These are: LB_TAG_PLATFORM_BLOB_VERSION

[PATCH v4 12/16] x86: coreboot: Log function names and line numbers

2023-05-04 Thread Simon Glass
Turn these options on to make it easier to debug things. Also enable dhrystone so we can get some measure of performance. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) configs/coreboot_defconfig | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v4 11/16] x86: coreboot: Scan PCI after relocation

2023-05-04 Thread Simon Glass
Enable this so that PCI devices can be used correctly without needing to do a manual scan. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) configs/coreboot_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/coreboot_defconfig

[PATCH v4 10/16] x86: coreboot: Document how to enable the debug UART

2023-05-04 Thread Simon Glass
This is not obvious so add a little note about how it works. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) doc/board/coreboot/coreboot.rst | 29 + 1 file changed, 29 insertions(+) diff --git a/doc/board/coreboot/coreboot.rst

[PATCH v4 09/16] x86: coreboot: Use a memory-mapped UART

2023-05-04 Thread Simon Glass
This is much more common on modern hardware, so default to using it. This does not affect the normal UART, but does allow the debug UART to work, since it uses serial_out_shift(), etc. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Expand commit

[PATCH v4 08/16] pci: coreboot: Don't read regions when booting

2023-05-04 Thread Simon Glass
When U-Boot is the second-stage bootloader, PCI is already set up. We cannot read the regions from the device tree. There is no point anyway, since PCI devices have already been allocated according to the regions and it is not safe for U-Boot to make any changes. Signed-off-by: Simon Glass

[PATCH v4 07/16] x86: Allow locating the UART from ACPI tables

2023-05-04 Thread Simon Glass
When coreboot does not pass a UART in its sysinfo struct, there is no easy way to find it out. Since coreboot does not actually init the serial device when serial is disabled, it is not possible to make it add this information to the sysinfo table. Add a way to obtain this information from the

[PATCH v4 05/16] acpi: Move the table-finding functions into the libary

2023-05-04 Thread Simon Glass
This is useful for other features. Move the function into library code so it can be used outside just the 'acpi' command. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v3) Changes in v3: - Avoid a build error with the ASL compiler Changes in v2: - Add new patch to

[PATCH v4 06/16] x86: coreboot: Collect the address of the ACPI tables

2023-05-04 Thread Simon Glass
At present any ACPI tables created by prior-stage firmware are ignored. It is useful to be able to view these in U-Boot. Pick this up from the sysinfo tables and display it with the cbsysinfo command. This allows the 'acpi list' command to work when booting from coreboot. Adjust the global_data

[PATCH v4 04/16] acpi: Create a new Kconfig for ACPI

2023-05-04 Thread Simon Glass
We have several Kconfig options for ACPI, but all relate to specific functions, such as generating tables and AML code. Add a new option which controls including basic ACPI library code, including the lib/acpi directory. This will allow us to add functions which are available even if table

[PATCH v4 03/16] input: Flush the keyboard buffer before resetting it

2023-05-04 Thread Simon Glass
If U-Boot is not the first-stage bootloader the keyboard may already be set up. Make sure to flush any data before trying to reset it. This avoids a long timeout / hang. Add some comments and a log category while we are here. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes

[PATCH v4 02/16] x86: Adjust search range for sysinfo table

2023-05-04 Thread Simon Glass
Avoid searching starting at 0 since this memory may not be available, e.g. if protection against NULL-pointer access is enabled. The table cannot be there anyway, since the first 1KB of memory was originally used for the interrupt table and coreboot avoids it. Start at 0x400 instead.

[PATCH v4 01/16] mtrr: Don't show an invalid CPU number

2023-05-04 Thread Simon Glass
When U-Boot did not do the MP init, we don't get an actual CPU number here. Skip printing it in that case. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Don't show an invalid CPU number on error cmd/x86/mtrr.c | 3 ++- 1 file changed, 2

[PATCH v4 00/16] x86: Various minor enhancements for coreboot

2023-05-04 Thread Simon Glass
This series includes some patches generated while getting U-Boot to boot more nicely on Brya, an Adler Lake Chromebook. This includes: - show the ACPI tables with 'acpi list' - get the UART to work even if coreboot doesn't enable it - show unimplemented sysinfo tags - fix for keyboard not working

[PATCH v3 17/17] x86: samus: Adjust TPL start and pre-reloc memory size

2023-05-04 Thread Simon Glass
Move the TPL up a little to make room for the refcode binary blob. Also increase the pre-relocation memory to make space for recent additions. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Drop patch "x86: Add on to existing MTRRs in SPL" - Add

[PATCH v3 15/17] x86: Simplify cpu_jump_to_64bit_uboot()

2023-05-04 Thread Simon Glass
This copies the cpu_call64() function to memory address and then jumps to it. This seems to work correctly even when called from SPL, which is running from SPI flash. Drop the copy as it is not needed. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v3: - Fix 'call' typo

[PATCH v3 16/17] x86: samus: Don't include audio and SATA in TPL

2023-05-04 Thread Simon Glass
These are not used in TPL so disable the drivers to save space. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/broadwell/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/cpu/broadwell/Makefile

[PATCH v3 11/17] x86: Tidy up address for loading U-Boot from SPL

2023-05-04 Thread Simon Glass
Use the binman symbols for this, to avoid hard-coding the value. We could use CONFIG_X86_OFFSET_U_BOOT for the address, but it seems better to obtain the offset and size through the same mechanism. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Add

[PATCH v3 14/17] spl: Commit MTRRs only in board_init_f_r()

2023-05-04 Thread Simon Glass
We don't need to commit the SPI-flash MTRR change immediately, since it is now done in the board_init_f_r(). Also this causes chromebook_link64 to hang, presumably since we are still running from CAR (Cache-as-RAM) in SPL. Coral handles this OK, perhaps since it is running from a different memory

[PATCH v3 13/17] x86: spl: Avoid using init_cache_f_r() from SPL

2023-05-04 Thread Simon Glass
This function is used by U-Boot proper. It does not set up MTRRs when SPL is enabled, but we do want this done when it is called from SPL. In fact it is confusing to use the same function from SPL, since there are quite a few conditions there. All init_cache_f_r() really does is commit the MTRRs

[PATCH v3 12/17] x86: Return mtrr_add_request() to its old purpose

2023-05-04 Thread Simon Glass
This function used to be for adding a list of requests to be actioned on relocation. Revert it back to this purpose, to avoid problems with boards which need control of their MTRRs (i.e. those which don't use FSP). The mtrr_set_next_var() function is available when the next free variable-MTRR

[PATCH v3 10/17] x86: spl: Show debugging for BSS

2023-05-04 Thread Simon Glass
Show the area of memory cleared for BSS, when debugging is enabled. Signed-off-by: Simon Glass --- Changes in v3: - Drop change to memset() arch/x86/lib/spl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/lib/spl.c b/arch/x86/lib/spl.c index bdf57ef7b5b..5e47ffa7db7 100644

[PATCH v3 09/17] x86: mrc: Correct SPL debug message

2023-05-04 Thread Simon Glass
SPL printf() does not normally support %#x so just use %x instead. Hex is expected in U-Boot anyway. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/lib/mrccache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/mrccache.c

  1   2   3   >