Re: [PATCH v2] ARM: imx: romapi: Fix signed integer bitwise ops misuse

Hello Marek, On 02.07.23 03:03, Marek Vasut wrote: > Bitwise operations on signed integers are not defined, > replace them with per-call checks. > > Reviewed-by: Peng Fan > Signed-off-by: Marek Vasut > --- > Cc: "NXP i.MX U-Boot Team" > Cc: Fabio Estevam > Cc: Heiko Schocher > Cc: Heinrich

Re: [PATCH] efi_driver: fix duplicate efiblk#0 issue

Hi Akashi-san, On Mon, 3 Jul 2023 at 13:32, AKASHI Takahiro wrote: > > On Mon, Jul 03, 2023 at 11:47:18AM +0900, Masahisa Kojima wrote: > > The devnum value of the blk_desc structure starts from 0, > > current efi_bl_create_block_device() function creates > > two "efiblk#0" devices for the cases

Re: [PATCH] efi_driver: fix duplicate efiblk#0 issue

On Mon, Jul 03, 2023 at 11:47:18AM +0900, Masahisa Kojima wrote: > The devnum value of the blk_desc structure starts from 0, > current efi_bl_create_block_device() function creates > two "efiblk#0" devices for the cases that blk_find_max_devnum() > returns -ENODEV and blk_find_max_devnum() returns

Re: [PATCH 5/6] arm: mvebu: Add Allied Telesis x240 board

On Mon, Jul 3, 2023 at 3:39 PM Chris Packham wrote: > > The x240 and SE240 are a series of L2+ switches from Allied Telesis. > There are a number of them in the range but as far as U-Boot is > concerned all the CPU block components are the same so there's only one > board defined. > >

[PATCH 6/6] arm: mvebu: Remove unused alias from RC AC5X dts

The sar-reg0 alias was left over from an earlier iteration of the patches adding support for this board. Remove the unused alias. Fixes: 6cc8b5db40 ("arm: mvebu: Add RD-AC5X board") Signed-off-by: Chris Packham --- arch/arm/dts/ac5-98dx35xx-rd.dts | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 5/6] arm: mvebu: Add Allied Telesis x240 board

The x240 and SE240 are a series of L2+ switches from Allied Telesis. There are a number of them in the range but as far as U-Boot is concerned all the CPU block components are the same so there's only one board defined. Signed-off-by: Chris Packham --- arch/arm/dts/Makefile |

[PATCH 4/6] mtd: nand: pxa3xx: Enable devbus/nand arbiter on Armada 8K

The CN9130 SoC (an ARMADA 8K type) has both a NAND Flash Controller and a generic local bus controller (Device Bus Controller) that share common pins. With a board design that incorporates both a NAND flash and uses the Device Bus (in our case for an SRAM) accessing the Device Bus device fails

[PATCH 3/6] mtd: nand: pxa3xx: Add support for the Marvell AC5 SoC

The NAND flash controller (NFC) on the AC5/AC5X SoC is the same as the NFC used on other Marvell SoCs. It does have the additional restriction of only supporting SDR timing modes up to 3. Signed-off-by: Chris Packham --- drivers/mtd/nand/raw/pxa3xx_nand.c | 17 ++--- 1 file changed,

[PATCH 1/6] arm: mvebu: ac5: Add nand-controller node

The AC5/AC5X SoC has a NAND flash controller. Add this to the SoC device tree. Signed-off-by: Chris Packham --- arch/arm/dts/ac5-98dx25xx.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/dts/ac5-98dx25xx.dtsi b/arch/arm/dts/ac5-98dx25xx.dtsi index

[PATCH 2/6] arm: mvebu: ac5: Define mvebu_get_nand_clock()

The NF_CLK for the AC5 SoC runs at 400MHz. There's no strapping or gating require so just add a mvebu_get_nand_clock() that returns this value. Signed-off-by: Chris Packham --- arch/arm/mach-mvebu/alleycat5/soc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 0/6] Support for AC5X NAND and AT-x240 board

This series adds support for the NAND flash controller on the AC5X SoC and adds support for the Allied Telesis x240 board. I've also included 2 unrelated changes. "arm: mvebu: Remove unused alias from RC AC5X dts" removes an unused alias from the dts. This was in the neighborhood of the x240 so I

[PATCH] efi_driver: fix duplicate efiblk#0 issue

The devnum value of the blk_desc structure starts from 0, current efi_bl_create_block_device() function creates two "efiblk#0" devices for the cases that blk_find_max_devnum() returns -ENODEV and blk_find_max_devnum() returns 0(one device found in this case). The devnum value for the "efiblk"

Re: [PATCH 09/10] doc: cmd: add documentation for scmi

On Thu, Jun 29, 2023 at 08:10:02PM +0100, Simon Glass wrote: > Hi AKASHI, > > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro > wrote: > > > > This is a help text for scmi command. > > > > Signed-off-by: AKASHI Takahiro > > --- > > doc/usage/cmd/scmi.rst | 98

Re: Pull request efi-2023-07-rc6

On Sat, Jul 01, 2023 at 08:08:33PM +0200, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit 5fa30f2351ac3c0458069896bc868eae927df410: > > smegw01: Fix wrong symbol override (2023-06-29 09:55:50 -0400) > > are available in the Git repository at: > >

Re: Current way of using pinctrl-mvebu

Answering my own question (I think) On Mon, Jul 3, 2023 at 12:10 PM Chris Packham wrote: > > Hi, > > I'm looking to upstream support for a new board with the Marvell AC5X > SoC and some NAND driver changes to support the SoC/board. I've got > things working when chain loading vendor based u-boot

Re: [PATCH 07/10] test: dm: add SCMI base protocol test

On Thu, Jun 29, 2023 at 08:09:58PM +0100, Simon Glass wrote: > Hi AKASHI, > > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro > wrote: > > > > Added is a new unit test for SCMI base protocol, which will exercise all > > the commands provided by the protocol, except SCMI_BASE_NOTIFY_ERRORS. > > $

Re: [PATCH 08/10] cmd: add scmi command for SCMI firmware

On Thu, Jun 29, 2023 at 08:10:00PM +0100, Simon Glass wrote: > Hi AKASHI, > > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro > wrote: > > > > This command, "scmi", provides a command line interface to various SCMI > > protocols. It supports at least initially SCMI base protocol with the sub > >

Re: [PATCH 01/10] firmware: scmi: implement SCMI base protocol

On Thu, Jun 29, 2023 at 08:09:45PM +0100, Simon Glass wrote: > Hi AKASHI, > > On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro > wrote: > > > > SCMI base protocol is mandatory according to the SCMI specification. > > > > With this patch, SCMI base protocol can be accessed via SCMI transport > >

Current way of using pinctrl-mvebu

Hi, I'm looking to upstream support for a new board with the Marvell AC5X SoC and some NAND driver changes to support the SoC/board. I've got things working when chain loading vendor based u-boot -> upstream u-boot but when I boot directly the NAND controller reports "pxa3xx-nand

[PATCH 2/2] board: rockchip: Add Hardkernel ODROID-M1

Hardkernel ODROID-M1 is a single board computer with a RK3568B2 SoC, a slightly modified version of the RK3568 SoC. Features tested on a ODROID-M1 8GB v1.0 2022-06-13: - SD-card boot - eMMC boot - SPI Flash boot - PCIe/NVMe/AHCI - SATA port - USB host Device tree is imported from linux v6.4.

[PATCH 1/2] ata: dwc_ahci: Fix support for other platforms

The dwc_ahci driver use platform specific defines, place the platform specific code behind a ifdef CONFIG_ARCH_OMAP2PLUS to allow build and use of the driver on Rockchip platform. Fixes: 02a4b4297901 ("drivers: block: dwc_ahci: Implement a driver for Synopsys DWC sata device") Signed-off-by:

[PATCH 0/2] board: rockchip: Add Hardkernel ODROID-M1

This series add support for Hardkernel ODROID-M1, a single board computer with a RK3568B2 SoC. First patch fixes a build issue in the dwc_ahci driver. Second patch import the device tree from linux v6.4 and add a defconfig for Hardkernel ODROID-M1. Following was tested on a ODROID-M1 8GB v1.0

Re: [PATCH] phy: phy-uclass: Add a missing error handling path

On 2023-07-02 20:47, Bhupesh Sharma wrote: > Since function 'phy_get_counts()' can return NULL, > add handling for that error path inside callers of > this function. Do you have any example where this can/has happened? Counts should never be NULL in a normal working call flow. I am a bit worried

[PATCH] ufs: Use 'TASK_TAG' to construct the ucd_req_ptr->header.dword_0

Instead of using the hard-coded value of 0x1f, use 'TASK_TAG' macro instead to construct the ucd_req_ptr->header.dword_0 This is in sync with what the Linux UFS driver does, i.e. set the byte0 equal to TASK_TAG (see [1]). Setting it to a fixed value of 0x1f is wrong as we define TASK_TAG as 0

[PATCH] phy: phy-uclass: Add a missing error handling path

Since function 'phy_get_counts()' can return NULL, add handling for that error path inside callers of this function. Signed-off-by: Bhupesh Sharma --- drivers/phy/phy-uclass.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/phy/phy-uclass.c

[PATCH 3/4] rockchip: rk356x-u-boot: Add bootph-all to common pinctrl nodes

Add bootph-all prop to common pinctrl nodes for eMMC, FSPI, SD-card and UART2 that are typically used by multiple boards. Unreferenced nodes are removed from the SPL device tree during a normal build. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 56

[PATCH 4/4] rockchip: rk356x-u-boot: Use relaxed u-boot,spl-boot-order

BootRom will try to load TPL+SPL from media in the following order: - SPI NOR Flash - SPI NAND Flash - NAND Flash - eMMC - SDMMC SPL will try to load FIT from media in the order defined in the device tree u-boot,spl-boot-order property. Change the default order to load FIT from to: - same media

[PATCH 2/4] rockchip: rk3566-radxa-cm3-io: Sync dts from linux v6.4

Sync rk3566-radxa-cm3-io.dts from linux v6.4. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3566-radxa-cm3-io.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/dts/rk3566-radxa-cm3-io.dts b/arch/arm/dts/rk3566-radxa-cm3-io.dts index d89d5263cb5e..5e4236af4fcb 100644

[PATCH 1/4] rockchip: rk356x: Sync dtsi from linux v6.4

Sync rk356x.dtsi from linux v6.4. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3568-pinctrl.dtsi | 94 arch/arm/dts/rk356x.dtsi | 14 +++-- 2 files changed, 102 insertions(+), 6 deletions(-) diff --git a/arch/arm/dts/rk3568-pinctrl.dtsi

[PATCH 0/4] rockchip: rk3568: Device Tree updates

This series sync rk356x.dtsi and rk3566-radxa-cm3-io.dts from linux v6.4, add bootph-all to common pinctrl nodes and relax FIT load order in rk356x-u-boot.dtsi. Patch 1-2 sync rk356x device tree from linux v6.4. Patch 3 move common pinctrl nodes to rk356x-u-boot.dtsi. Patch 4 change to try and

Re: [PATCH v2 2/3] X86: Add support for distro boot

Hi Thomas, On Wed, 10 May 2023 at 07:40, Mittelstaedt Thomas (XC-CT/EBV3) wrote: > > Hello Simon, > > I've integrated your patches (1-3-usb-Tidy-up-the-usb_start-flag.patch, > bootstd-Correct-default-boot-command.patch) > > The system with CONFIG_BOOTSTD_DEFAULT instead of CONFIG_BOOTSTD_FULL

Re: modified UBoot to include I2C communication

Hi Andy, On Thu, 25 May 2023 at 13:34, Andy Goh wrote: > > Dear Sir, > I am working on a project based on NXP's iMX8M mini board, to include I2C > library in the UBoot , I had browse thru UBoot website below, could anyone > kindly advise which source file to amend and what are the code to

Re: [PATCH 10/12] binman: btool: Add Xilinx Bootgen btool

Hi Lukas, On Fri, 30 Jun 2023 at 13:28, Lukas Funke wrote: > > On 30.06.2023 06:18, Simon Glass wrote: > > Hi, > > > > On Thu, 29 Jun 2023 at 15:59, wrote: > >> > >> From: Lukas Funke > >> > >> Add the Xilinx Bootgen as bintool. Xilinx Bootgen is used to create > >> bootable SPL (FSBL in

Re: [PATCH v13 04/10] arm_ffa: introduce Arm FF-A support

Hi Abdellatif, On Fri, 30 Jun 2023 at 13:49, Abdellatif El Khlifi wrote: > > Hi Simon, > > On Tue, Jun 20, 2023 at 11:27:20AM +0100, Simon Glass wrote: > > wrote: > > > > > > Add Arm FF-A support implementing Arm Firmware Framework for Armv8-A v1.0 > > > > > > The Firmware Framework for Arm

Re: [PATCH 09/10] binman: Add support for u-boot-nodtb.bin.lzma as an input binary

Hi Manoj, On Fri, 30 Jun 2023 at 13:12, Manoj Sai wrote: > > Add an entry type for u-boot-nodtb.bin.lzma, which is a LZMA compressed > raw u-boot binary and a simple test. > > Signed-off-by: Manoj Sai > Signed-off-by: Suniel Mahesh > --- > tools/binman/etype/283_u_boot_nodtb_lzma.dts | 11

Re: [PATCH 08/10] rockchip: Add GZIP compressed uboot raw binary to FIT image

Hi Manoj, On Fri, 30 Jun 2023 at 13:12, Manoj Sai wrote: > > Add GZIP compressed uboot raw binary to FIT image. > > Signed-off-by: Manoj Sai > Signed-off-by: Suniel Mahesh > --- > arch/arm/dts/rockchip-u-boot.dtsi | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [PATCH 07/10] binman: Add support for u-boot-nodtb.bin.gz as an input binary

Hi Manoj, On Fri, 30 Jun 2023 at 13:12, Manoj Sai wrote: > > Add an entry type for u-boot-nodtb.bin.gz, which is a GZIP compressed raw > u-boot > binary and a simple test. > A better way to do this is to have binman do the compression. > Signed-off-by: Manoj Sai > Signed-off-by: Suniel

Re: [PATCH 06/10] spl: fit: support for booting a LZMA-compressed U-boot raw binary

Hi Manoj, On Fri, 30 Jun 2023 at 13:12, Manoj Sai wrote: > > If LZMA Compression support is enabled, LZMA compressed U-Boot > raw binary will be at a specified RAM location which is defined > at UBOOT_COMPRESSED_BINARY_FIT_USER_DEF_ADDR and will be assign it as > the source address. > >

Re: [PATCH 05/10] Makefile: Add support to generate LZMA compressed raw u-boot binary

Hi Manoj, On Fri, 30 Jun 2023 at 13:12, Manoj Sai wrote: > > Add support for generating LZMA compressed raw u-boot binary. > > Signed-off-by: Manoj Sai > Signed-off-by: Suniel Mahesh > --- > Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Makefile b/Makefile > index

Re: [PATCH 03/10] rockchip: RAM location for the compressed U-BOOT raw binary

Hi Manoj, On Fri, 30 Jun 2023 at 13:12, Manoj Sai wrote: > > Add the support that ,if compression support is enabled in SPL > a RAM location needs to be defined as the source address where > compressed U-BOOT raw binary will be stored. > > spl_load_fit_image function takes care that, compressed

Re: [PATCH 02/10] spl: Kconfig: Address support for compressed U-BOOT raw binary

Hi Manoj, On Fri, 30 Jun 2023 at 13:12, Manoj Sai wrote: > > Add the support that ,if compression support is enabled in SPL > a location needs to be defined as the source address where > compressed U-BOOT raw binary will be stored. > > spl_load_fit_image function takes care that, compressed

Re: [PATCH 01/10] Makefile: Add support to generate GZIP compressed raw u-boot binary

Hi Manoj, On Fri, 30 Jun 2023 at 13:12, Manoj Sai wrote: > > Add support for generating a GZIP-compressed raw U-boot binary. > > Signed-off-by: Manoj Sai > Signed-off-by: Suniel Mahesh > --- > Makefile | 3 +++ > 1 file changed, 3 insertions(+) Please can you use binman to do that? We are

[PATCH 58/58] buildman: Move copy_files() out ot BuilderThread class

This does not need to be in the class. Move it out to avoid a pylint warning. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 47 + 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 54/58] buildman: Create a function to handle config and build

Move this code into a _config_and_build() function, so reduce the size of run_commit(). Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 97 + 1 file changed, 61 insertions(+), 36 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 43/58] buildman: Drop unnecessary assignment of config_out

This is already set up earlier in the function, so drop the extra assignment. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index f110137e8f6e..ad12e9ede7f4

[PATCH 57/58] buildman: Tidy up some comments in builderthread

Make sure all functions have full argument documentation. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 66 ++--- 1 file changed, 36 insertions(+), 30 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py

[PATCH 55/58] buildman: Avoid passing result into _read_done_file()

Move the creating of the result object into the function which sets it up, to simplify the code. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 56/58] buildman: Tidy up reporting of a toolchain error

Provide the text of the exception when something goes wrong. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 7 +-- tools/buildman/func_test.py | 6 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 52/58] buildman: Move code to decide output dirs

Put this in its own function to reduce the size of the run_commit() function. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 34 - 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 53/58] buildman: Move checkout code to a separate function

Put this in its own function to reduce the size of the run_commit() function Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 44/58] buildman: Start a function to set up the make arguments

Move some of this code into a new funciion, to help reduce the size of the run_commits() function. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 38 - 1 file changed, 23 insertions(+), 15 deletions(-) diff --git

[PATCH 51/58] buildman: Move code to remove old outputs

Put this in its own function to reduce the size of the run_commit() function. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 50/58] buildman: Move reading of the done file into a function

Move this logic into its own function to reduce the size of the run_commt() function. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 66 + 1 file changed, 42 insertions(+), 24 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 49/58] buildman: Move bulid code into its own function

Split this into its own function so reduce the size of run_commit(). Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 40 - 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 48/58] buildman: Move reconfigure code into its own function

Split this into its own function so reduce the size of run_commit(). Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 41 - 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 47/58] buildman: Convert config_out to string IO

This is probably a little more efficient and it allows passing the object to another function to write data. Convert config_out to use a string I/O device. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH 42/58] buildman: Correct invalid use of out_dir variable

This variable has a different meaning in the outer scrop. Use a different name to avoid confusion, or bugs. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH 46/58] buildman: Move more things into _build_args()

Move more of the argument-building code into this function. Fix a missing assignment for out_rel_dir too. Rename the function since it now builds all the arguments. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 55 - 1 file changed, 34

[PATCH 45/58] buildman: Move setting of toolchain arguments to _build_args()

Move a few more pieces to this new function. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index 47ebf4dcdd90..e7d9a29d03ef 100644 ---

[PATCH 39/58] buildman: Convert camel case in builderthread.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 8 +++--- tools/buildman/builderthread.py | 50 - 2 files changed, 29 insertions(+), 29 deletions(-) diff --git

[PATCH 41/58] buildman: Export _get_output_dir() to avoid warnings

Make this a public memory since it is used outside the class. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 8 tools/buildman/builderthread.py | 2 +- tools/buildman/test.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 40/58] buildman: Correct most pylint warnings in builderthread

Fix the easy warnings in this file. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 95 ++--- 1 file changed, 51 insertions(+), 44 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index

[PATCH 37/58] buildman: Convert camel case in builder.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 228 tools/buildman/builderthread.py | 26 ++-- tools/buildman/control.py | 13 +- tools/buildman/func_test.py | 2

[PATCH 35/58] buildman: Convert to argparse

Use argparse to parse the arguments, since OptionParser is deprecated now. Signed-off-by: Simon Glass --- tools/buildman/cmdline.py | 125 tools/buildman/control.py | 140 ++-- tools/buildman/func_test.py | 6 +-

[PATCH 38/58] buildman: Split parser creation in two

Split this into two functions to avoid a warning about too many statements. Signed-off-by: Simon Glass --- tools/buildman/cmdline.py | 44 +-- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/tools/buildman/cmdline.py

[PATCH 36/58] buildman: Convert camel case in bsettings.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/buildman/bsettings.py | 14 +++--- tools/buildman/control.py | 2 +- tools/buildman/func_test.py | 12 ++-- tools/buildman/main.py | 2 +- tools/buildman/test.py

[PATCH 34/58] buildman: Add a test for --boards

Add a simple functional test for the --boards option. Fix the example in the docs while we are here. Also improve the docs for Builder.count so it is clearer what it contains. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 3 ++- tools/buildman/buildman.rst | 2 +-

[PATCH 33/58] buildman: Correct most pylint warnings in cmdline

Tidu up warnings in this file. Signed-off-by: Simon Glass --- tools/buildman/cmdline.py | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tools/buildman/cmdline.py b/tools/buildman/cmdline.py index 3066a0b38bbf..91571a5adb1d 100644 ---

[PATCH 32/58] buildman: Convert camel case in cmdline.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/buildman/cmdline.py | 2 +- tools/buildman/func_test.py | 2 +- tools/buildman/main.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/buildman/cmdline.py

[PATCH 31/58] buildman: Create a function to get number of built commits

Move this code into a function. This removes the last pylint error in the control module. Signed-off-by: Simon Glass --- tools/buildman/control.py | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 30/58] buildman: Use get_alow_missing() directly to avoid var

Avoid an unnecessary local variable by moving this code to a function. This fixes the pylint warning about too many local variables. Signed-off-by: Simon Glass --- tools/buildman/control.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 29/58] buildman: Move getting the adjust_cfg into run_builder()

Move this into its own function to reduce the size of do_buildman(). Signed-off-by: Simon Glass --- tools/buildman/control.py | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index

[PATCH 28/58] buildman: Move checking for make into run_builder()

This is not needed until the builder is run. Move it there to reduce the size of the do_buildman() function. Signed-off-by: Simon Glass --- tools/buildman/control.py | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 26/58] buildman: Drop some unnecessary variables

Drop some variables at the end of the do_bulidman() function. Signed-off-by: Simon Glass --- tools/buildman/control.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index 3c5b7128bf20..db8377e9ac42 100644 ---

[PATCH 27/58] buildman: Adjust show_toolchain_prefix() to not return

This function does not need to return. Simplify the code by exiting immediately. Signed-off-by: Simon Glass --- tools/buildman/control.py | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index

[PATCH 25/58] buildman: Moving running of the builder into a function

Move this code into a new function. This removes the pylint warning about too many branches. Signed-off-by: Simon Glass --- tools/buildman/control.py | 56 --- 1 file changed, 35 insertions(+), 21 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 24/58] buildman: Tweak commits and show_bloat

Move setting of show_bloat to adjust_options() and adjust how the commits variable is set. Together these remove the pylint warning about too many statements. Signed-off-by: Simon Glass --- tools/buildman/control.py | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff

[PATCH 23/58] buildman: Move remaining builder properties to constructor

Do these all in the constructor, so it is consistent. Move the stray builder comment into the correct place. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 25 ++--- tools/buildman/control.py | 18 +++--- 2 files changed, 25 insertions(+), 18

[PATCH 22/58] buildman: Avoid too many returns in do_buildman()

Fix the pylint warning by using a variable instead of lots of 'return' statements. Signed-off-by: Simon Glass --- tools/buildman/control.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index

[PATCH 21/58] buildman: Move commit numbering into determine_series()

Commits are numbered for use in tests. Do this in determine_series() since it is already dealing with the series. Signed-off-by: Simon Glass --- tools/buildman/control.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 20/58] buildman: Move setting up the output dir into a function

Move this code into a separate function to reduce the size of the main do_buildman() directory. Signed-off-by: Simon Glass --- tools/buildman/control.py | 45 --- 1 file changed, 33 insertions(+), 12 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 19/58] buildman: Move counting of commits into a function

Move this code into a separate function to avoid a pylint warning in determine_series(). Signed-off-by: Simon Glass --- tools/buildman/control.py | 63 +-- 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 18/58] buildman: Build option-adjusting into a function

Create a separate function to adjust options. Also move show_actions() up as far as we can in the function. Signed-off-by: Simon Glass --- tools/buildman/control.py | 53 --- 1 file changed, 33 insertions(+), 20 deletions(-) diff --git

[PATCH 17/58] buildman: Pass option values to show_actions()

Pass in the individual values rather than the whole options object, so we can see what is needed. Signed-off-by: Simon Glass --- tools/buildman/control.py | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 16/58] buildman: Pass option values to get_action_summary()

Pass in the individual values rather than the whole options object, so we can see what is needed. Signed-off-by: Simon Glass --- tools/buildman/control.py | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 15/58] buildman: Move output-file setup into one place

Collect the two parts of the output-file handling into single place. Signed-off-by: Simon Glass --- tools/buildman/control.py | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index

[PATCH 14/58] bulldman: Set up output_dir earlier

Set up output_dir at the start of the main function, instead of updating the options.output_dir option. Signed-off-by: Simon Glass --- tools/buildman/control.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py

[PATCH 13/58] bulidman: Move toolchain handling to a functoin

Move the code for dealing with toolchains out into its own function, to reduce the size of the main function. Signed-off-by: Simon Glass --- tools/buildman/control.py | 53 --- 1 file changed, 38 insertions(+), 15 deletions(-) diff --git

[PATCH 12/58] buildman: Move Boards-object code into a function

Move the code which obtains a Boards object into its own function, to reduce the size of the main function. Signed-off-by: Simon Glass --- tools/buildman/control.py | 54 --- 1 file changed, 39 insertions(+), 15 deletions(-) diff --git

[PATCH 11/58] bulidman: Move more code to determine_series()

Move some more series-related code here, to reduce the size of the main function. Signed-off-by: Simon Glass --- tools/buildman/control.py | 82 --- 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 10/58] buildman: Move board-selection code into a function

Create a new determine_boards() function to hold the code which selects which boards to build. Signed-off-by: Simon Glass --- tools/buildman/control.py | 59 --- 1 file changed, 43 insertions(+), 16 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 09/58] buildman: Move dry-run handling higher in do_buildman()

Move this up above where the builder is created, since it no-longer makes use of the builder. Signed-off-by: Simon Glass --- tools/buildman/control.py | 88 --- 1 file changed, 45 insertions(+), 43 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 08/58] buildman: Drop use of builder in show_actions()

This function only needs the output directory from the builder. This is passed into the builder, so just pass the same value to show_actions(). The avoids needing a builder to call show_actions(). Signed-off-by: Simon Glass --- tools/buildman/control.py | 8 1 file changed, 4

[PATCH 07/58] buildman: Move logic for -A up a little

Move this up to just after the boards are calculated, so we can refactor the code now below this function. Signed-off-by: Simon Glass --- tools/buildman/control.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 05/58] buildman: Move series calculations into a separate function

Reduce the size of the do_buildman() function a little by moving the code that figures out the series into a separate function. Signed-off-by: Simon Glass --- tools/buildman/control.py | 95 +++ 1 file changed, 56 insertions(+), 39 deletions(-) diff --git

[PATCH 06/58] buildman: Move fetch-arch code into a separate function

Reduce the size of the do_buildman() function a little by moving the code that handles --fetch-arch into a separate function. Signed-off-by: Simon Glass --- tools/buildman/control.py | 49 +-- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git

[PATCH 04/58] buildman: Move full-help processing to main

This does not need any of the control features. Move it out of main to reduce the size of the do_buildman() function. For Python 3.6 the -H feature will not work, but this does not seem to be a huge problem, as it dates from 2016. Signed-off-by: Simon Glass --- tools/buildman/control.py | 11

[PATCH 02/58] buildman: Convert camel case in control.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/buildman/control.py | 31 ++- tools/buildman/func_test.py | 7 --- tools/buildman/main.py | 2 +- tools/buildman/test.py | 2 +- 4 files

[PATCH 03/58] buildman: Fix most pylint warnings in control

Tidy up the easier-to-fix pylint warnings in module 'control'. Signed-off-by: Simon Glass --- tools/buildman/control.py | 119 +--- tools/buildman/func_test.py | 2 +- 2 files changed, 70 insertions(+), 51 deletions(-) diff --git a/tools/buildman/control.py

[PATCH 01/58] buildman: Tidy up pylint warnings in main

Tidy up the various pylint warnings in module 'main'. Signed-off-by: Simon Glass --- tools/buildman/main.py | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/tools/buildman/main.py b/tools/buildman/main.py index a2ffbc9073e7..ca1beb098292 100755 ---

  1   2   >