Re: [PATCH 1/1] efi_loader: support all uclasses in device path

2023-07-18 Thread AKASHI Takahiro
On Wed, Jul 19, 2023 at 06:43:08AM +0200, Heinrich Schuchardt wrote: > On devices with multiple USB mass storage devices errors like > > Path /../USB(0x0,0x0)/USB(0x1,0x0)/Ctrl(0x0) > already installed. > > are seen. This is due to creating non-unique device paths. To uniquely > identify

Re: [PATCH 12/18] include: armv7: Enable distroboot across all configs

2023-07-18 Thread Manorit Chawdhry
Hi Simon, On 16:04-20230718, Simon Glass wrote: > Hi, > > On Mon, 17 Jul 2023 at 07:45, Nishanth Menon wrote: > > > > On 13:39-20230717, Manorit Chawdhry wrote: > > > > [...] > > > > > > > + > > > > > +#defi

[PATCH 1/1] efi_loader: support all uclasses in device path

2023-07-18 Thread Heinrich Schuchardt
On devices with multiple USB mass storage devices errors like Path /../USB(0x0,0x0)/USB(0x1,0x0)/Ctrl(0x0) already installed. are seen. This is due to creating non-unique device paths. To uniquely identify devices we must provide path nodes for all devices on the path from the root

Re: [PATCH] menu: Ignore prompt variable if timeout is != 0

2023-07-18 Thread FUKAUMI Naoki
hi, thank you for your reply! On 7/18/23 23:08, Jonas Karlman wrote: On 2023-07-14 09:36, FUKAUMI Naoki wrote: From: Manuel Traut Since 739e8361f3fe78038251216df6096a32bc2d5839, a system with the following /boot/extlinux/extlinux.conf (which sets timeout to 50) immediately boots the first

Re: [PATCH v2 1/5] rockchip: Support OP-TEE for ARM in FIT images created by binman

2023-07-18 Thread Kever Yang
On 2023/7/18 22:57, Alex Bee wrote: CONFIG_SPL_OPTEE_IMAGE option is used during DRAM size detection for Rockchip ARM platform to indicate that an OP-TEE binary was already loaded and a Trusted Execution Environment (TEE) is available in order to block/reserve a memory-region for it. This

Re: EFI breaks USB dual port detection - our observations

2023-07-18 Thread Heinrich Schuchardt
On 7/19/23 02:55, Da Xue wrote: On Tue, Jul 18, 2023 at 3:13 PM Heinrich Schuchardt mailto:xypron.g...@gmx.de>> wrote: Am 18. Juli 2023 20:37:04 MESZ schrieb Suniel Mahesh mailto:su...@amarulasolutions.com>>: >Hi, > >I am testing the USB infrastructure on a Rockchip

Re: [PATCH 1/1] part: eliminate part_get_info_by_name_type()

2023-07-18 Thread Heinrich Schuchardt
On 7/19/23 03:08, Simon Glass wrote: Hi Heinrich, On Sun, 16 Jul 2023 at 05:34, Heinrich Schuchardt wrote: Since commit 56670d6fb83f ("disk: part: use common api to lookup part driver") part_get_info_by_name_type() ignores the part_type parameter used to restrict the partition table type.

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-18 Thread Heinrich Schuchardt
On 7/19/23 03:08, Simon Glass wrote: Hi AKASHI, On Tue, 18 Jul 2023 at 18:22, AKASHI Takahiro wrote: An EFI application may create an EFI block device (EFI_BLOCK_IO_PROTOCOL) in EFI world, which in turn generates a corresponding U-Boot block device based on U-Boot's Driver Model. The latter

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-18 Thread AKASHI Takahiro
Hi Simon, On Tue, Jul 18, 2023 at 07:08:45PM -0600, Simon Glass wrote: > Hi AKASHI, > > On Tue, 18 Jul 2023 at 18:22, AKASHI Takahiro > wrote: > > > > An EFI application may create an EFI block device (EFI_BLOCK_IO_PROTOCOL) in > > EFI world, which in turn generates a corresponding U-Boot block

[PATCH] mxs: Kconfig: Remove TARGET_XFI3 symbol

2023-07-18 Thread Fabio Estevam
From: Fabio Estevam The xfi3 target has been removed by commit 539fba2c10e7 ("arm: Remove xfi3 board"), but it missed to remove an entry from the mxs Kconfig. Remove it. Signed-off-by: Fabio Estevam --- arch/arm/mach-imx/mxs/Kconfig | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [PATCH v2 3/7] binman: Report missing external blobs using error level

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 14:34, Jonas Karlman wrote: > > Print missing external blobs using error level and missing optional > external blobs using warning level. Also change to only print the header > line in color, red for missing and yellow for optional. > > Signed-off-by: Jonas Karlman > --- >

Re: [PATCH v6 2/3] binman: Allow cipher node as special section

2023-07-18 Thread Simon Glass
On Mon, 17 Jul 2023 at 01:06, wrote: > > From: Christian Taedcke > > The new encrypted etype generates a cipher node in the device tree > that should not be evaluated by binman, but still be kept in the > output device tree. > > Signed-off-by: Christian Taedcke > --- > > (no changes since v3) >

Re: [PATCH] arm: sunxi: Correct warning in board_fit_config_name_match

2023-07-18 Thread Simon Glass
Hi Tom, On Mon, 17 Jul 2023 at 13:29, Tom Rini wrote: > > When building this with clang, we get a warning about having excess > parenthesis here, or that we're incorrectly using "==" when we want "=". > Correct these by using parenthesis around our multiplication of > constants as this is what

Re: [PATCH 01/10] Makefile: Add support to generate GZIP compressed raw u-boot binary

2023-07-18 Thread Simon Glass
Hi Manoj, On Tue, 18 Jul 2023 at 01:13, Manoj Sai wrote: > > Hi Simon, > > Can you please suggest or briefly explain to me the steps to be > followed to generate the compressed u-boot-nodtb.bin.gz and > u-boot-nodtb.bin.lzma file with the help of binman , > when compression support is enabled

Re: [PATCH 3/7] xes: Remove leftover code

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 17:34, Tom Rini wrote: > > The platforms here have been removed, but the common code directory was > forgotten. Clean up. > > Signed-off-by: Tom Rini > --- > board/xes/common/Makefile| 9 - > board/xes/common/board.c | 67

Re: [PATCH v3 00/11] Sign Xilinx ZynqMP SPL/FSBL boot images using binman

2023-07-18 Thread Simon Glass
Hi, On Tue, 18 Jul 2023 at 05:53, wrote: > > From: Lukas Funke > > > This series adds two etypes to create a verified boot chain for > Xilinx ZynqMP devices. The first etype 'xilinx-fsbl-auth' is used to > create a bootable, signed image for ZynqMP boards using the Xilinx > Bootgen tool. The

Re: [PATCH 2/7] arm: Remove leftover MAINTAINERS files

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 17:34, Tom Rini wrote: > > These platforms have been removed, but the MAINTAINERS file was missed, > clean up. > > Signed-off-by: Tom Rini > --- > board/birdland/bav335x/MAINTAINERS | 13 - > board/broadcom/bcm11130/MAINTAINERS | 6 -- >

Re: [PATCH v3 09/11] binman: btool: Add Xilinx Bootgen btool

2023-07-18 Thread Simon Glass
Hi, On Tue, 18 Jul 2023 at 05:53, wrote: > > From: Lukas Funke > > Add the Xilinx Bootgen as bintool. Xilinx Bootgen is used to create > bootable SPL (FSBL in Xilinx terms) images for Zynq/ZynqMP devices. The > btool creates a signed version of the SPL. Additionally to signing the > key source

Re: [PATCH 4/7] MAINTAINERS: Add a number of "common" directories

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 17:34, Tom Rini wrote: > > A number of platforms have "common" directories that are in turn not > listed by the board MAINTAINERS file. Add these directories in many > cases. > > Signed-off-by: Tom Rini > --- > An alternative in some cases may be to have a >

Re: [PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-07-18 Thread Simon Glass
Hi Sughosh, On Mon, 17 Jul 2023 at 04:44, Sughosh Ganu wrote: > > hi Simon, > > On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > > > Add support in binman for generating capsules. The capsule parameters > > >

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-18 Thread Simon Glass
Hi AKASHI, On Tue, 18 Jul 2023 at 18:22, AKASHI Takahiro wrote: > > An EFI application may create an EFI block device (EFI_BLOCK_IO_PROTOCOL) in > EFI world, which in turn generates a corresponding U-Boot block device based > on > U-Boot's Driver Model. > The latter device, however, doesn't

Re: [PATCH 1/5] MAINTAINERS: Correct minor mistakes on some file listings

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 10:20, Tom Rini wrote: > > There are a few entries where minor mistakes mean that we don't match up > with obviously expected files, correct those. > > Signed-off-by: Tom Rini > --- > board/amlogic/u200/MAINTAINERS| 2 +- > board/broadcom/bcmns/MAINTAINERS |

Re: [PATCH v2 1/4] cmd: bind: Add unbind command with driver filter

2023-07-18 Thread Simon Glass
On Mon, 17 Jul 2023 at 05:21, Marek Vasut wrote: > > Extend the driver core to perform lookup by both OF node and driver > bound to the node. Use this to look up specific device instances to > unbind from nodes in the unbind command. One example where this is > needed is USB peripheral

Re: fdt_high default value causes unbootable kernel due to misalignment

2023-07-18 Thread Simon Glass
Hi Tim, On Tue, 18 Jul 2023 at 09:59, Tim van der Staaij | Zign wrote: > > Hello, > > When I was using U-Boot with a dart_6ul board I occasionally had fitimages > that U-Boot would attempt to boot just fine, but the kernel wouldn't actually > boot. Debugging found that this was correlated with

Re: [PATCH V6 07/10] common: spl: spl: Remove video driver

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 02:57, Nikhil M Jain wrote: > > Use config SPL_VIDEO_REMOVE to remove video driver at SPL stage before > jumping to next stage, in place of CONFIG_SPL_VIDEO, to allow user to > remove video if required. > > Signed-off-by: Nikhil M Jain > Reviewed-by: Devarsh Thakkar > ---

Re: Double free on xhci_register failure.

2023-07-18 Thread Simon Glass
+Marek Vasut On Tue, 18 Jul 2023 at 16:14, Richard Habeeb wrote: > > Hi all, > > drivers/core/device.c will call `device_free()` after xhci_register already > frees the private device data. This causes a memory corruption and crash on > my RPI4B. I believe the solution is to remove the free call

Re: [PATCH v2 2/7] binman: Update missing optional external blob warning text

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 14:34, Jonas Karlman wrote: > > Make it more clear that the missing external blob is optional in the > printed warning message. > > Signed-off-by: Jonas Karlman > --- > v2: > - New patch > > tools/binman/control.py | 2 +- > tools/binman/ftest.py | 2 +- > 2 files

Re: [PATCH v4 12/12] sandbox: capsule: Generate capsule related files through binman

2023-07-18 Thread Simon Glass
Hi Sughosh, On Mon, 17 Jul 2023 at 05:18, Sughosh Ganu wrote: > > hi Simon, > > On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > > > The EFI capsule files can now be generated as part of u-boot > > > build.

Re: [PATCH 7/7] MAINTAINERS: Add some missing directories or files

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 17:34, Tom Rini wrote: > > In a few cases we have MAINTAINERS entries that are missing obvious > paths or files. Typically this means a board directory that did not list > itself, but in a few cases we have a Kconfig file or similar. > > Signed-off-by: Tom Rini > --- >

Re: [PATCH 5/7] MAINTAINERS: Fix path typos and similar

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 17:34, Tom Rini wrote: > > We have a number of cases where the in-tree path of files and where > they presumably were when the first version of a patch were posted > differ slightly. Correct these to point at where the files are now. > > Signed-off-by: Tom Rini > --- >

Re: [PATCH v2 5/7] binman: Fix blank line usage for invalid images warning text

2023-07-18 Thread Simon Glass
Hi Jonas, On Tue, 18 Jul 2023 at 14:34, Jonas Karlman wrote: > > There is no blank line between last missing blob help message and the > header line for optional blob help messages. > > Image 'simple-bin' is missing external blobs and is non-functional: atf-bl31 > >

Re: [PATCH 4/5] sunxi: Add MAINTAINERS entry for Lctech Pi F1C200s

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 10:21, Tom Rini wrote: > > This defconfig was added without a MAINTAINERS entry, add one. > > Signed-off-by: Tom Rini > --- > board/sunxi/MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH v3 11/11] binman: etype: Add xilinx_fsbl_auth etype

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 05:53, wrote: > > From: Lukas Funke > > This adds a new etype 'xilinx-fsbl-auth'. By using this etype it is > possible to created an authenticated SPL (FSBL in Xilinx terms) for > ZynqMP boards. > > The etype uses Xilinx Bootgen tools in order to transform the SPL into > a

Re: [PATCH 1/7] arm: Remove more remnants of bcmcygnus

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 17:33, Tom Rini wrote: > > Remove some leftover files from the bcmcygnus platform. > > Signed-off-by: Tom Rini > --- > arch/arm/Kconfig | 15 +- > board/broadcom/bcm_ep/Makefile | 5 -- > board/broadcom/bcm_ep/board.c | 86

Re: [PATCH v4 32/45] fs: fat: Support reading from a larger block size

2023-07-18 Thread Simon Glass
Hi Bin, On Sun, 16 Jul 2023 at 09:19, Bin Meng wrote: > > Hi Simon, > > On Sun, Jul 16, 2023 at 7:42 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Thu, 13 Jul 2023 at 04:49, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Mon, Jun 19, 2023 at 8:02 PM Simon Glass wrote: > > > > > > > >

Re: [PATCH v6 1/3] binman: Add support for externally encrypted blobs

2023-07-18 Thread Simon Glass
On Mon, 17 Jul 2023 at 01:06, wrote: > > From: Christian Taedcke > > This adds a new etype encrypted. > > It creates a new cipher node in the related image similar to the > cipher node used by u-boot, see boot/image-cipher.c. > > Signed-off-by: Christian Taedcke > --- > > Changes in v6: > - fix

Re: [PATCH v3 10/11] binman: ftest: Add test for xilinx_fsbl_auth etype

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 05:53, wrote: > > From: Lukas Funke > > Add test for the 'xilinx_fsbl_auth' etype > > Signed-off-by: Lukas Funke > > --- > > Changes in v3: > - Improved test coverage for xilinx-fsbl-auth etype > > Changes in v2: > - Fixed typo in dts name > > tools/binman/ftest.py

Re: [PATCH v6 3/3] binman: Add tests for etype encrypted

2023-07-18 Thread Simon Glass
On Mon, 17 Jul 2023 at 01:06, wrote: > > From: Christian Taedcke > > Add tests to reach 100% code coverage for the added etype encrypted. > > Signed-off-by: Christian Taedcke > --- > > (no changes since v5) > > Changes in v5: > - add comments to test functions > > Changes in v4: > - fix failing

Re: [PATCH 6/7] MAINTAINERS: Deal with '+' in paths

2023-07-18 Thread Simon Glass
Hi Tom, On Tue, 18 Jul 2023 at 17:34, Tom Rini wrote: > > The listed paths are allowed to contain wildcards. This includes the > '+' character which we have as a literal part of the path in a few > cases. Escape the '+' here so that files are matched. > > Signed-off-by: Tom Rini > --- >

Re: [PATCH 2/5] MAINTAINERS: Add some missing defconfig files to existing entries

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 10:20, Tom Rini wrote: > > We have a few places where defconfigs were added (or renamed) and not > included in their previously listed MAINTAINERS entry, correct this. > > Signed-off-by: Tom Rini > --- > Cc: Adam Ford > Cc: Chris Packham > Cc: Jan Kiszka > Cc: Neil

Re: [PATCH 1/1] part: eliminate part_get_info_by_name_type()

2023-07-18 Thread Simon Glass
Hi Heinrich, On Sun, 16 Jul 2023 at 05:34, Heinrich Schuchardt wrote: > > Since commit 56670d6fb83f ("disk: part: use common api to lookup part > driver") part_get_info_by_name_type() ignores the part_type parameter > used to restrict the partition table type. > > omap_mmc_get_part_size() and

Re: [PATCH 3/5] rockchip: Add MAINTAINERS entry for Radxa Rock 4C+

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 10:21, Tom Rini wrote: > > This defconfig was added without a MAINTAINERS entry, add one. > > Signed-off-by: Tom Rini > --- > board/rockchip/evb_rk3399/MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH v2 1/7] binman: Update tee-os missing blob help text

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 14:34, Jonas Karlman wrote: > > Make it a little bit more clear that it is U-Boot that should be built > with TEE=/path/to/tee.bin and not OP-TEE itself. > > Signed-off-by: Jonas Karlman > --- > v2: > - New patch > > tools/binman/missing-blob-help | 2 +- > 1 file

Re: [PATCH 5/5] MAINTAINERS: Re-order CAAM section

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 10:21, Tom Rini wrote: > > This file is in alphabetical order, move CAAM up to where it should be. > > Signed-off-by: Tom Rini > --- > MAINTAINERS | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Simon Glass Please we should add a CI

Re: [PATCH v2 2/2] power: pmic: fix regulators behaviour

2023-07-18 Thread Simon Glass
Hi Svyatoslav, On Sun, 16 Jul 2023 at 07:20, Svyatoslav Ryhel wrote: > > > > 16 липня 2023 р. 16:08:10 GMT+03:00, Simon Glass > написав(-ла): > >Hi Svyatoslav, > > > >On Sat, 15 Jul 2023 at 22:08, Svyatoslav Ryhel wrote: > >> > >> > >> > >> 16 липня 2023 р. 02:40:37 GMT+03:00, Simon Glass >

Re: [PATCH v1 1/4] power: regulator: expand basic reference counter onto all uclass

2023-07-18 Thread Simon Glass
Hi, On Tue, 18 Jul 2023 at 01:39, Svyatoslav Ryhel wrote: > > вт, 18 лип. 2023 р. о 10:36 Eugen Hristev пише: > > > > Hi Svyatoslav, > > > > > > On 7/18/23 10:05, Svyatoslav Ryhel wrote: > > > Commit is based on 4fcba5d ("regulator: implement basic reference > > > counter") but expands the idea

Re: [PATCH 3/5] m68k: dts: add watchdog node

2023-07-18 Thread Simon Glass
On Tue, 18 Jul 2023 at 08:00, Angelo Dureghello wrote: > > Hi Stefan, > > On 18/07/23 2:26 PM, Stefan Roese wrote: > > On 6/25/23 21:35, Angelo Dureghello wrote: > >> Add watchdog node for the implemented mcf_wdt driver. > >> > >> Signed-off-by: Angelo Dureghello > >> --- > >>

Re: [RFC PATCH 1/3] scripts: kconfig: Add config fragment support in board/../

2023-07-18 Thread Simon Glass
Hi, On Sun, 16 Jul 2023 at 09:12, Tom Rini wrote: > > On Sat, Jul 15, 2023 at 05:40:35PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 13 Jul 2023 at 16:54, Tom Rini wrote: > > > > > > On Wed, Jul 12, 2023 at 08:00:28AM -0600, Simon Glass wrote: > > > > Hi Jason, > > > > > > > > On Tue,

Re: EFI breaks USB dual port detection - our observations

2023-07-18 Thread Da Xue
On Tue, Jul 18, 2023 at 3:13 PM Heinrich Schuchardt wrote: > > > Am 18. Juli 2023 20:37:04 MESZ schrieb Suniel Mahesh < > su...@amarulasolutions.com>: > >Hi, > > > >I am testing the USB infrastructure on a Rockchip RK3328 based > >roc-rk3328-cc target. > > > >The USB tree on the device is as

[RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-18 Thread AKASHI Takahiro
An EFI application may create an EFI block device (EFI_BLOCK_IO_PROTOCOL) in EFI world, which in turn generates a corresponding U-Boot block device based on U-Boot's Driver Model. The latter device, however, doesn't work as U-Boot proper block device due to an issue in efi_driver's implementation.

[PATCH 7/7] MAINTAINERS: Add some missing directories or files

2023-07-18 Thread Tom Rini
In a few cases we have MAINTAINERS entries that are missing obvious paths or files. Typically this means a board directory that did not list itself, but in a few cases we have a Kconfig file or similar. Signed-off-by: Tom Rini --- MAINTAINERS | 1 +

[PATCH 5/7] MAINTAINERS: Fix path typos and similar

2023-07-18 Thread Tom Rini
We have a number of cases where the in-tree path of files and where they presumably were when the first version of a patch were posted differ slightly. Correct these to point at where the files are now. Signed-off-by: Tom Rini --- board/anbernic/rgxx3_rk3566/MAINTAINERS | 4 ++--

[PATCH 6/7] MAINTAINERS: Deal with '+' in paths

2023-07-18 Thread Tom Rini
The listed paths are allowed to contain wildcards. This includes the '+' character which we have as a literal part of the path in a few cases. Escape the '+' here so that files are matched. Signed-off-by: Tom Rini --- board/k+p/kp_imx53/MAINTAINERS | 3 ++-

[PATCH 4/7] MAINTAINERS: Add a number of "common" directories

2023-07-18 Thread Tom Rini
A number of platforms have "common" directories that are in turn not listed by the board MAINTAINERS file. Add these directories in many cases. Signed-off-by: Tom Rini --- An alternative in some cases may be to have a board/$(VENDOR)/MAINTAINERS file instead and rework the listings that way.

[PATCH 2/7] arm: Remove leftover MAINTAINERS files

2023-07-18 Thread Tom Rini
These platforms have been removed, but the MAINTAINERS file was missed, clean up. Signed-off-by: Tom Rini --- board/birdland/bav335x/MAINTAINERS | 13 - board/broadcom/bcm11130/MAINTAINERS | 6 -- board/broadcom/bcm11130_nand/MAINTAINERS | 6 --

[PATCH 3/7] xes: Remove leftover code

2023-07-18 Thread Tom Rini
The platforms here have been removed, but the common code directory was forgotten. Clean up. Signed-off-by: Tom Rini --- board/xes/common/Makefile| 9 - board/xes/common/board.c | 67 board/xes/common/fsl_8xxx_clk.c | 54

[PATCH 1/7] arm: Remove more remnants of bcmcygnus

2023-07-18 Thread Tom Rini
Remove some leftover files from the bcmcygnus platform. Signed-off-by: Tom Rini --- arch/arm/Kconfig | 15 +- board/broadcom/bcm_ep/Makefile | 5 -- board/broadcom/bcm_ep/board.c | 86 -- 3 files changed, 1 insertion(+), 105 deletions(-)

Double free on xhci_register failure.

2023-07-18 Thread Richard Habeeb
Hi all, drivers/core/device.c will call `device_free()` after xhci_register already frees the private device data. This causes a memory corruption and crash on my RPI4B. I believe the solution is to remove the free call in xhci_register (

fdt_high default value causes unbootable kernel due to misalignment

2023-07-18 Thread Tim van der Staaij | Zign
Hello, When I was using U-Boot with a dart_6ul board I occasionally had fitimages that U-Boot would attempt to boot just fine, but the kernel wouldn't actually boot. Debugging found that this was correlated with the header length of the fitImage. Then I noticed this remark in

Re: [PATCH 0/8] Some fixes for the rockchip dw_mipi_dsi driver

2023-07-18 Thread Christopher Morgan
I’ve been on holiday and not able to add my Tested-By yet, I do apologize. It will probably be another week and a half before I can, but I will check these out and if they cause problems I’ll let you know/start work on a fix. Thank you. > On Jul 17, 2023, at 11:01 AM, Anatolij Gustschin

Re: [PATCH v10 3/4] Boot var automatic management for removable medias

2023-07-18 Thread Raymond Mao
Hi Heinrich, I checkouted the 'origin/removable_medias' branch from the 'EFI U-Boot Custodian Tree'. Run the secureboot test suite on the sandbox locally by './test/py/test.py --bd sandbox --build -k efi_secboot'. But there are no errors observed for 'test_signed.py'. Below is the output logs:

Re: [PATCH 12/18] include: armv7: Enable distroboot across all configs

2023-07-18 Thread Simon Glass
Hi, On Mon, 17 Jul 2023 at 07:45, Nishanth Menon wrote: > > On 13:39-20230717, Manorit Chawdhry wrote: > > [...] > > > > > + > > > > +#define BOOT_TARGET_DEVICES(func) \ > > > > + BOOT_TARGET_MMC(func) \ > > > > + BOOT_TARGET_USB(func) \ > > > > + BOOT_TARGET_PXE(func) \ > > >

[PATCH v2 7/7] Makefile: Show binman missing blob message

2023-07-18 Thread Jonas Karlman
When binman is invoked during a build of U-Boot and an external blob is missing, the user is usually presented with a generic file not found in input path message. Invoke binman with --allow-missing so that binman can show relevant missing blob help messages. Build continue to fail with missing

[PATCH v2 6/7] binman: Show filename in missing blob help message

2023-07-18 Thread Jonas Karlman
Show the filename next to the node path in missing blob help messages, also show a generic missing blob message when there was no help message for the help tag. Signed-off-by: Jonas Karlman Reviewed-by: Simon Glass --- v2: - Add test - Collect r-b tag tools/binman/control.py | 13

[PATCH v2 5/7] binman: Fix blank line usage for invalid images warning text

2023-07-18 Thread Jonas Karlman
There is no blank line between last missing blob help message and the header line for optional blob help messages. Image 'simple-bin' is missing external blobs and is non-functional: atf-bl31 /binman/simple-bin/fit/images/@atf-SEQ/atf-bl31: See the documentation for your board. You may

[PATCH v2 4/7] binman: Override CheckOptional in fit entry

2023-07-18 Thread Jonas Karlman
Missing optional blobs was not reported for generated entries, e.g. tee-os on rockchip targets. Implement a CheckOptional to fix this. After this the following can be shown: Image 'simple-bin' is missing optional external blobs but is still functional: tee-os

[PATCH v2 1/7] binman: Update tee-os missing blob help text

2023-07-18 Thread Jonas Karlman
Make it a little bit more clear that it is U-Boot that should be built with TEE=/path/to/tee.bin and not OP-TEE itself. Signed-off-by: Jonas Karlman --- v2: - New patch tools/binman/missing-blob-help | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 2/7] binman: Update missing optional external blob warning text

2023-07-18 Thread Jonas Karlman
Make it more clear that the missing external blob is optional in the printed warning message. Signed-off-by: Jonas Karlman --- v2: - New patch tools/binman/control.py | 2 +- tools/binman/ftest.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/binman/control.py

[PATCH v2 3/7] binman: Report missing external blobs using error level

2023-07-18 Thread Jonas Karlman
Print missing external blobs using error level and missing optional external blobs using warning level. Also change to only print the header line in color, red for missing and yellow for optional. Signed-off-by: Jonas Karlman --- v2: - New patch tools/binman/control.py | 18 +-

[PATCH v2 0/7] binman: Show missing blob message when building U-Boot

2023-07-18 Thread Jonas Karlman
binman currently support showing a helpful missing blob message, however only when the badly named --allow-missing flag is used. This changes so that binman is invoked with the --allow-missing flag and the helpful message can be shown by default when building U-Boot. Using the following: make

Re: EFI breaks USB dual port detection - our observations

2023-07-18 Thread Heinrich Schuchardt
Am 18. Juli 2023 20:37:04 MESZ schrieb Suniel Mahesh : >Hi, > >I am testing the USB infrastructure on a Rockchip RK3328 based >roc-rk3328-cc target. > >The USB tree on the device is as follows: > >=> usb tree >USB device tree: > 1 Hub (480 Mb/s, 0mA) > u-boot EHCI Host Controller > > 1

EFI breaks USB dual port detection - our observations

2023-07-18 Thread Suniel Mahesh
Hi, I am testing the USB infrastructure on a Rockchip RK3328 based roc-rk3328-cc target. The USB tree on the device is as follows: => usb tree USB device tree: 1 Hub (480 Mb/s, 0mA) u-boot EHCI Host Controller 1 Hub (12 Mb/s, 0mA) U-Boot Root Hub (OHCI) 1 Hub (5 Gb/s,

Re: [PATCH 2/5] MAINTAINERS: Add some missing defconfig files to existing entries

2023-07-18 Thread Adam Ford
On Tue, Jul 18, 2023 at 11:20 AM Tom Rini wrote: > > We have a few places where defconfigs were added (or renamed) and not > included in their previously listed MAINTAINERS entry, correct this. > For the beacon boards: Acked-by: Adam Ford > Signed-off-by: Tom Rini > --- > Cc: Adam Ford >

Re: [PATCH 2/5] MAINTAINERS: Add some missing defconfig files to existing entries

2023-07-18 Thread Jan Kiszka
On 18.07.23 18:20, Tom Rini wrote: > We have a few places where defconfigs were added (or renamed) and not > included in their previously listed MAINTAINERS entry, correct this. > > Signed-off-by: Tom Rini > --- > Cc: Adam Ford > Cc: Chris Packham > Cc: Jan Kiszka > Cc: Neil Armstrong > Cc:

[PATCH 5/5] MAINTAINERS: Re-order CAAM section

2023-07-18 Thread Tom Rini
This file is in alphabetical order, move CAAM up to where it should be. Signed-off-by: Tom Rini --- MAINTAINERS | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 87991cccddb6..697190558efe 100644 --- a/MAINTAINERS +++

[PATCH 4/5] sunxi: Add MAINTAINERS entry for Lctech Pi F1C200s

2023-07-18 Thread Tom Rini
This defconfig was added without a MAINTAINERS entry, add one. Signed-off-by: Tom Rini --- board/sunxi/MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS index 80e3f4be4b96..98bbd2dd25dd 100644 --- a/board/sunxi/MAINTAINERS +++

[PATCH 3/5] rockchip: Add MAINTAINERS entry for Radxa Rock 4C+

2023-07-18 Thread Tom Rini
This defconfig was added without a MAINTAINERS entry, add one. Signed-off-by: Tom Rini --- board/rockchip/evb_rk3399/MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/board/rockchip/evb_rk3399/MAINTAINERS b/board/rockchip/evb_rk3399/MAINTAINERS index

[PATCH 2/5] MAINTAINERS: Add some missing defconfig files to existing entries

2023-07-18 Thread Tom Rini
We have a few places where defconfigs were added (or renamed) and not included in their previously listed MAINTAINERS entry, correct this. Signed-off-by: Tom Rini --- Cc: Adam Ford Cc: Chris Packham Cc: Jan Kiszka Cc: Neil Armstrong Cc: Stefan Roese ---

[PATCH 1/5] MAINTAINERS: Correct minor mistakes on some file listings

2023-07-18 Thread Tom Rini
There are a few entries where minor mistakes mean that we don't match up with obviously expected files, correct those. Signed-off-by: Tom Rini --- board/amlogic/u200/MAINTAINERS| 2 +- board/broadcom/bcmns/MAINTAINERS | 2 +- board/freescale/imx93_evk/MAINTAINERS | 2 +- 3 files

[PATCH] ARM: imx: Update MAINTAINERS file on DH electronics i.MX8M Plus DHCOM

2023-07-18 Thread Marek Vasut
Make use of globs to cover all the DTs and defconfigs. Fill in missing DH u-boot list name. Signed-off-by: Marek Vasut --- Cc: Andreas Geisreiter Cc: Christoph Niedermaier Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: u-b...@dh-electronics.com Cc: u-boot@lists.denx.de ---

Re: [PATCH v10 3/4] Boot var automatic management for removable medias

2023-07-18 Thread Raymond Mao
Hi Masahisa, Thanks for the hints. Found that I was missing 'guestfs-tools' for 'virt-make-fs'. Now I am able to reproduce the failure logs that Heinrich pointed out. Thanks! Regards, Raymond On Tue, 18 Jul 2023 at 05:03, Masahisa Kojima wrote: > Hi Raymond, > > On Tue, 18 Jul 2023 at 05:23,

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-18 Thread Heinrich Schuchardt
On 13.07.23 16:35, Michal Simek wrote: Empty capsule are also allowed to be process. Without it updated images can't change their Image Acceptance state from no to yes. Is there any documentation describing the usage of empty capsule to set the image acceptance state? Best regards Heinrich

Re: [PATCH v10 3/4] Boot var automatic management for removable medias

2023-07-18 Thread Heinrich Schuchardt
On 18.07.23 11:03, Masahisa Kojima wrote: Hi Raymond, On Tue, 18 Jul 2023 at 05:23, Raymond Mao wrote: Hi Heinrich, I run 'make tests' with the patches locally but no errors observed from 'test_signed.py', below are few lines from the output console: ```

Re: [PATCH] sunxi: H6: Enable Ethernet on Orange Pi One Plus

2023-07-18 Thread Anne Macedo
On Sun, Jul 16, 2023 at 08:14:50AM +0200, Corentin Labbe wrote: > Le Sun, Jul 16, 2023 at 01:35:02AM +0100, Andre Przywara a écrit : > > On Tue, 11 Jul 2023 19:40:21 + > > Anne Macedo wrote: > > > > Hi Anne, > > > > thanks for reaching out to the list! But please try to avoid > > pushing

Re: [PATCH] sunxi: H6: Enable Ethernet on Orange Pi One Plus

2023-07-18 Thread Anne Macedo
On Sun, Jul 16, 2023 at 01:35:02AM +0100, Andre Przywara wrote: > On Tue, 11 Jul 2023 19:40:21 + > Anne Macedo wrote: > > Hi Anne, > > thanks for reaching out to the list! But please try to avoid > pushing any patches downstream (Yocto) before they are accepted > or at least discussed

[PATCH v2 5/5] optee: Support Rockchip OP-TEE binaries

2023-07-18 Thread Alex Bee
Currently the only ARM Rockchip SoC which is supported by upstream optee-os is RK322x. For all other ARM SoCs a vendor-provided OP-TEE binary has to be used to have a TEE available. Those are using a calling convension different from upstream optee-os. This introduces CONFIG_ROCKCHIP_OPTEE_BINARY

[PATCH v2 4/5] rockchip: evb_rk3229: Update/fix README

2023-07-18 Thread Alex Bee
This updates the evb_rk3229's README on howto create / use the FIT image created by binman. Also fix some wrong paths and update filenames which have changed in recent upstream optee-os versions. Signed-off-by: Alex Bee --- board/rockchip/evb_rk3229/README | 72 +---

[PATCH v2 3/5] rockchip: RK322x: Select SPL_OPTEE_IMAGE

2023-07-18 Thread Alex Bee
For RK322x series ARM SoCs the OP-TEE is non-optional, as besides the TEE it also provides the PSCI implementation, which is expected to be available by upstream linux. Select CONFIG_SPL_OPTEE_IMAGE if an FIT image is built. Signed-off-by: Alex Bee --- arch/arm/mach-rockchip/Kconfig | 1 + 1

[PATCH v2 2/5] configs: evb-rk3229: Increase SPL_STACK_R_MALLOC_SIMPLE_LEN

2023-07-18 Thread Alex Bee
An OP-TEE FIT image will fail to extract in SPL because the malloc stack size is currently limited to 0x2000 for evb-rk3229 board. In SPL we do not have to care about size limitations, since we are no longer bound to SRAM limits after DRAM initialization has been done in TPL. Use the default

[PATCH v2 1/5] rockchip: Support OP-TEE for ARM in FIT images created by binman

2023-07-18 Thread Alex Bee
CONFIG_SPL_OPTEE_IMAGE option is used during DRAM size detection for Rockchip ARM platform to indicate that an OP-TEE binary was already loaded and a Trusted Execution Environment (TEE) is available in order to block/reserve a memory-region for it. This adds a bunch of new `#if's` to

[PATCH v2 0/5] rockchip: Support OP-TEE binaries in ARM FIT images

2023-07-18 Thread Alex Bee
This adds support for OP-TEE binaries to Rockchip's ARM FIT image generation by binman. Currently there is an extra (and outdated) rockchip-optee.dtsi which can create an u-boot.itb which can also hold the OP-TEE binary. It has to be included manually in the respective SoC-specific device trees.

Re: [PATCH 3/5] m68k: dts: add watchdog node

2023-07-18 Thread Stefan Roese
Hi Angelo, On 7/18/23 15:58, Angelo Dureghello wrote: Hi Stefan, On 18/07/23 2:26 PM, Stefan Roese wrote: On 6/25/23 21:35, Angelo Dureghello wrote: Add watchdog node for the implemented mcf_wdt driver. Signed-off-by: Angelo Dureghello ---   arch/m68k/dts/M5208EVBE.dts | 5 +  

Re: [PATCH] menu: Ignore prompt variable if timeout is != 0

2023-07-18 Thread Jonas Karlman
On 2023-07-14 09:36, FUKAUMI Naoki wrote: > From: Manuel Traut > > Since 739e8361f3fe78038251216df6096a32bc2d5839, a system with the following > /boot/extlinux/extlinux.conf (which sets timeout to 50) immediately boots the > first entry in the config without displaying a boot menu. According to

Re: [PATCH 1/5] drivers: watchdog: add mcf watchdog support

2023-07-18 Thread Angelo Dureghello
Hi Stefan, thanks for the feedbacks, On 18/07/23 2:23 PM, Stefan Roese wrote: On 6/25/23 21:35, Angelo Dureghello wrote: This watchdog driver applies to the following mcf families: - mcf52x2 (5271 5275 5282) - mcf532x (5329 5373) - mcf523x (5235) Cpu's not listed for each family does not

Re: [PATCH] env: Fix default environment saving issue

2023-07-18 Thread Tom Rini
On Tue, Jul 04, 2023 at 12:16:07AM -0600, Ashok Reddy Soma wrote: > When CONFIG_SYS_REDUNDAND_ENVIRONMENT is enabled, by default env is > getting saved to redundant environment irrespective of primary env is > present or not. > > It means even if primary and redundant environment are not

Re: [PATCH] android_ab: Try backup booloader_message

2023-07-18 Thread Tom Rini
On Mon, Jul 03, 2023 at 10:07:13AM -0500, Joshua Watt wrote: > Some devices keep 2 copies of the bootloader_message in the misc > partition and write each in sequence when updating. This ensures that > there is always one valid copy of the bootloader_message. Teach u-boot > to optionally try a

Re: [PATCH v2 5/5] cmd: mbr: Force DOS driver to be used for verify

2023-07-18 Thread Tom Rini
On Mon, Jul 03, 2023 at 08:39:56AM -0500, Joshua Watt wrote: > Forces the DOS partition type driver to be used when verifying the MBR. > This is particularly useful when using a hybrid MBR & GPT layout as > otherwise MBR verification would mostly likely fail since the GPT > partitions will be

Re: [PATCH v2 4/5] dm: test: Add test for part_get_info_by_type

2023-07-18 Thread Tom Rini
On Mon, Jul 03, 2023 at 08:39:55AM -0500, Joshua Watt wrote: > Adds a test suite to ensure that part_get_info_by_type works correctly > by creating a hybrid GPT/MBR partition table and reading both. > > Signed-off-by: Joshua Watt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks!

Re: [PATCH 3/5] m68k: dts: add watchdog node

2023-07-18 Thread Angelo Dureghello
Hi Stefan, On 18/07/23 2:26 PM, Stefan Roese wrote: On 6/25/23 21:35, Angelo Dureghello wrote: Add watchdog node for the implemented mcf_wdt driver. Signed-off-by: Angelo Dureghello ---   arch/m68k/dts/M5208EVBE.dts | 5 +   arch/m68k/dts/mcf5208.dtsi  | 7 +++  

Re: [PATCH v2 3/5] disk: part: Add API to get partitions with specific driver

2023-07-18 Thread Tom Rini
On Mon, Jul 03, 2023 at 08:39:54AM -0500, Joshua Watt wrote: > Adds part_driver_get_type() API which can be used to force a specific > driver to be used when getting partition information instead of relying > on auto detection. > > Signed-off-by: Joshua Watt > Reviewed-by: Simon Glass Applied

  1   2   >