Re: [PATCH] sandbox: watchdog: Avoid an error on startup

2023-08-11 Thread Stefan Roese
On 8/10/23 17:53, Simon Glass wrote: For some time now running sandbox with -T produces an error: Core: 270 devices, 95 uclasses, devicetree: board WDT: Not starting wdt-gpio-toggle wdt_gpio wdt-gpio-level: Request for wdt gpio failed: -16 WDT: Not starting wdt@0 MMC:

[PATCH] eeprom: starfive: set eth0 mac address properly

2023-08-11 Thread Seung-Woo Kim
fdt_fixup_ethernet() sets eth0 mac address from ethaddr. Set ethaddr to environment instead of eth0addr. Signed-off-by: Seung-Woo Kim --- board/starfive/visionfive2/visionfive2-i2c-eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/starfive/visionfive2/visionfive2

[PATCH] kirkwood: dns325: Enable 2nd harddrive

2023-08-11 Thread Stefan Roese
The 2nd HD is not enabled in U-Boot on the D-Link DNS325. This patch sets the responsible GPIO to high, enabling the drive. Suggested-by: Peter Granilla Signed-off-by: Stefan Roese Cc: Tom Rini --- board/d-link/dns325/dns325.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/d-link/dns

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Sughosh Ganu
On Thu, 10 Aug 2023 at 22:47, Tom Rini wrote: > > On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sughosh Ganu wrote: > > On Thu, 10 Aug 2023 at 21:22, Tom Rini wrote: > > > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu wrote: > > > > > > > Build the mkeficapsule tool for all the sandbox

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Sughosh Ganu
hi Simon, On Thu, 10 Aug 2023 at 22:57, Simon Glass wrote: > > Hi, > > On Thu, 10 Aug 2023 at 09:52, Tom Rini wrote: > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu wrote: > > > > > Build the mkeficapsule tool for all the sandbox variants. This tool > > > will be used subsequently

Re: [PATCH] arm: mach-k3: j721s2_init: Enable memory with CONFIG_K3_J721E_DDRSS

2023-08-11 Thread Nishanth Menon
On 12:04-20230811, Dominik Haller wrote: > Make that condition more generic by checking if the memory controller > driver is enabled instead of using the EVM's config. > > Signed-off-by: Dominik Haller > --- > arch/arm/mach-k3/j721s2_init.c | 2 +- > 1 file changed,

[PATCH] corstone1000: update maintainers

2023-08-11 Thread abdellatif . elkhlifi
From: Abdellatif El Khlifi Update MAINTAINERS of corstone1000 board. Signed-off-by: Xueliang Zhong Signed-off-by: Abdellatif El Khlifi --- board/armltd/corstone1000/MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/armltd/corstone1000/MAINTAINERS b/boa

Re: [PATCH v3 3/3] X86: pxeboot: bugfix: Set variable for size of initrd

2023-08-11 Thread Bin Meng
Hi Simon, On Fri, Aug 11, 2023 at 5:33 AM Simon Glass wrote: > > Hi Bin, > > On Thu, 4 May 2023 at 18:40, Simon Glass wrote: > > > > On Thu, 4 May 2023 at 07:43, wrote: > > > > > > From: Thomas Mittelstaedt > > > > > > The problem was, that zboot() didn't work because of missing > > > ramdisc

[PATCH 1/1] net: axi_emac: Convert to ofnode functions

2023-08-11 Thread Maxim Kochetkov
FDT functions is not working when OF_LIVE is enabled. Convert fdt parsing functions to ofnode parsing functions. Signed-off-by: Maxim Kochetkov --- drivers/net/xilinx_axi_emac.c | 50 +-- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/drivers/net/

[PATCH] Add support for XMC XM25QH128C/XM25QH256C/XM25QU256C/XM25QH512C/XM25QU512C

2023-08-11 Thread SSunk
site: https://www.xmcwh.com/site/product Signed-off-by: Kankan Sun --- configs/evb-ast2600_defconfig | 1 + drivers/mtd/spi/spi-nor-ids.c | 4 2 files changed, 5 insertions(+) diff --git a/configs/evb-ast2600_defconfig b/configs/evb-ast2600_defconfig index 9244654c82..f06c0e1fe1 100644 ---

[PATCH] arm: mach-k3: j721s2_init: Enable memory with CONFIG_K3_J721E_DDRSS

2023-08-11 Thread Dominik Haller
Make that condition more generic by checking if the memory controller driver is enabled instead of using the EVM's config. Signed-off-by: Dominik Haller --- arch/arm/mach-k3/j721s2_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/j721s2_init.c b/arch/ar

Re: [PATCH v3 21/23] x86: cpu: i386: cpu: only set pci_ram_top if CONFIG_IS_ENABLED(PCI)

2023-08-11 Thread Bin Meng
On Tue, Mar 14, 2023 at 5:32 AM Troy Kisky wrote: > > This avoids an error when ifdef CONFIG_PCI is changed to > if CONFIG_IS_ENABLED(PCI) > > Signed-off-by: Troy Kisky > --- > > (no changes since v2) > > Changes in v2: > - use an accessor function gd_set_pci_ram_top > > arch/x86/cpu/i386/cpu.c

Re: [PATCH] Add support for XMC XM25QH128C/XM25QH256C/XM25QU256C/XM25QH512C/XM25QU512C

2023-08-11 Thread Simon Glass
Hi, On Fri, 11 Aug 2023 at 06:36, SSunk wrote: > > site: https://www.xmcwh.com/site/product > > Signed-off-by: Kankan Sun > --- > configs/evb-ast2600_defconfig | 1 + > drivers/mtd/spi/spi-nor-ids.c | 4 > 2 files changed, 5 insertions(+) > Can you please abbreviate the commit subject to

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Simon Glass
Hi Sughosh, On Fri, 11 Aug 2023 at 05:23, Sughosh Ganu wrote: > > hi Simon, > > On Thu, 10 Aug 2023 at 22:57, Simon Glass wrote: > > > > Hi, > > > > On Thu, 10 Aug 2023 at 09:52, Tom Rini wrote: > > > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu wrote: > > > > > > > Build the mk

Re: [PATCH] dm: core: support reading a single indexed u64 value

2023-08-11 Thread Simon Glass
Hi Ashok, On Fri, 11 Aug 2023 at 00:11, Ashok Reddy Soma wrote: > > Add helper function to allow reading a single indexed u64 value from a > device-tree property containing multiple u64 values, that is an array of > u64's. > > Signed-off-by: Ashok Reddy Soma > --- > > drivers/core/of_access.c |

Re: [PATCH v2 15/16] bootstd: Add a command to read all files for a bootflow

2023-08-11 Thread Simon Glass
Some bootflows (such as EFI and ChromiumOS) delay reading the kernel until it is needed to boot. This saves time when scanning and avoids needing to allocate memory for something that may never be used. To permit reading of these files, add a new 'bootflow read' command. Signed-off-by: Simon Glas

Re: [PATCH 16/16] bootstd: cros: Add ARM support

2023-08-11 Thread Simon Glass
Support booting ChromiumOS on ARM devices using FIT. Add an entry into the boot implementation which does not require a command line. This can be expanded over time as the bootm code is refactored. Signed-off-by: Simon Glass --- boot/Kconfig | 4 ++-- boot/bootm.c | 37

Re: [PATCH 14/16] bootstd: Allow display of the x86 setup information

2023-08-11 Thread Simon Glass
Provide an option to dump this information if available. Move the funciion prototype to the common x86 header. Allow the command line to be left out since 'bootflow info' show this itself and it is not in the correct place in memory until the kernel is actually booted. Fix a badly aligned heading

Re: [PATCH 13/16] bootstd: cros: Split up reading info and kernel

2023-08-11 Thread Simon Glass
Use the two new functions to separate reading of the ChromiumOS info from the partition from actually reading the kernel and booting it. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 96 +++- 1 file changed, 23 insertions(+), 73 deletions(-) Appl

Re: [PATCH 12/16] bootstd: cros: Add a function to read a kernel

2023-08-11 Thread Simon Glass
The code to read the ChromiumOS information from the partition is currently all in one function. Create a new function which reads the kernel, assuming that the metadata has been parsed. For now this function is not used. Future work will plumb it in. Signed-off-by: Simon Glass --- boot/bootm

Re: [PATCH 11/16] bootstd: cros: Add a function to read info from partition

2023-08-11 Thread Simon Glass
The code to read the ChromiumOS information from the partition is currently all in one function. It reads the entire kernel, which is unnecessary unless it is to be booted. Create a new function which reads just the minimum required data from the disk, then obtains what it needs from there. For n

Re: [PATCH 10/16] bootstd: Add private bootmeth data to the bootflow

2023-08-11 Thread Simon Glass
Some bootmeths need to store their own information related to the bootflow, in addition to the generic information in struct bootflow. Add a pointer for this. Signed-off-by: Simon Glass --- boot/bootflow.c| 1 + include/bootflow.h | 2 ++ 2 files changed, 3 insertions(+) Applied to u-boot-

Re: [PATCH 09/16] bootstd: cros: Add private info for ChromiumOS

2023-08-11 Thread Simon Glass
Create a new private structure to hold information gleaned from the disk. This will allow separation between reading of the bootflow information and (later) reading the whole kernel. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 55 +--- 1 file ch

Re: [PATCH 08/16] bootstd: cros: Add docs for the kernel layout

2023-08-11 Thread Simon Glass
Provide brief documentation about the ChromiumOS kernel layout. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 29 + 1 file changed, 29 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH 07/16] bootstd: Move common zimage functions to bootm.h

2023-08-11 Thread Simon Glass
We want to avoid using #ifdefs around header files and in the code. It makes sense to collect the various functions used for loading images into a single header which can be included by all architectures. The best place for this is the arch-neutral bootm.h header, so use that. Move some zimage fun

Re: [PATCH 05/16] bootstd: cros: Decode some kernel preamble fields

2023-08-11 Thread Simon Glass
Decode the kernel start and size using the structures provided. This accesses the same data, just in a cleaner way. Add some logging for some of the fields in the kernel preamble. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 54 ++-- 1 file chan

Re: [PATCH 06/16] bootstd: cros: Simplify setup and cmdline expressions

2023-08-11 Thread Simon Glass
Create a common base from which the other parts are offset and make all of the offsets related to that. This makes the code a little easier to read. Use X86_ prefixes for the two values which are x86-specific. Drop OFFSET_BASE since it is available in a header field. Drop the unnecessary 'start'

Re: [PATCH 04/16] bootstd: cros: Support a kernel on either partition

2023-08-11 Thread Simon Glass
ChromiumOS allows a kernel to be on either partition 2 or 4. Add support for scanning both and using the first one we find with a suitable signature. Record the partition which is used. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 21 ++--- 1 file changed, 14 insertion

Re: [PATCH 03/16] bootstd: cros: Bring in some ChromiumOS structures

2023-08-11 Thread Simon Glass
Add a header file with structures for booting ChromiumOS, taken from the vboot tree. Using these makes it easier to understand the code. Note that the code style has not been updated for U-Boot, with use of uint64_t, __attribute__((packed)) and one comment-style nit. This should make it easier to

Re: [PATCH 01/16] bootstd: cros: Correct reporting of I/O errors

2023-08-11 Thread Simon Glass
Return -EIO when the read failed, rather than the number of blocks read. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 02/16] bootstd: cros: Move partition reading into a function

2023-08-11 Thread Simon Glass
Move the code which reads a partition into its own function. Add a constant for the number of bytes to 'probe' at the start of the partition. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 66 +--- 1 file changed, 50 insertions(+), 16 deletions(-)

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Tom Rini
On Fri, Aug 11, 2023 at 04:29:37PM +0530, Sughosh Ganu wrote: > On Thu, 10 Aug 2023 at 22:47, Tom Rini wrote: > > > > On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sughosh Ganu wrote: > > > On Thu, 10 Aug 2023 at 21:22, Tom Rini wrote: > > > > > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh

Re: [PATCH] doc/sphinx/requirements.txt: Bump certifi up

2023-08-11 Thread Tom Rini
On Fri, Aug 11, 2023 at 08:56:38AM +0200, Heinrich Schuchardt wrote: > On 8/1/23 20:53, Tom Rini wrote: > > Upgrade certifi to the latest version, to remove e-Tugra from the root > > store. > > > > Link: > > https://groups.google.com/a/mozilla.org/g/dev-security-policy/c/C-HrP1SEq1A?pli=1 > > Sig

Re: [PATCH 1/1] armv8: Fix compilation error with SYS_DCACHE_OFF

2023-08-11 Thread Tom Rini
On Fri, Aug 11, 2023 at 11:12:28AM +0530, Bhupesh Sharma wrote: > If CONFIG_SYS_ICACHE_OFF and CONFIG_SYS_DCACHE_OFF are set, we see the > following errors while compiling u-boot: > > arch/arm/cpu/armv8/cpu.c:60: undefined reference to `icache_disable' > aarch64-linux-gnu-ld.bfd: arch/arm/cpu

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Sughosh Ganu
On Fri, 11 Aug 2023 at 19:28, Tom Rini wrote: > > On Fri, Aug 11, 2023 at 04:29:37PM +0530, Sughosh Ganu wrote: > > On Thu, 10 Aug 2023 at 22:47, Tom Rini wrote: > > > > > > On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sughosh Ganu wrote: > > > > On Thu, 10 Aug 2023 at 21:22, Tom Rini wrote: > > >

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Sughosh Ganu
hi Simon, On Fri, 11 Aug 2023 at 19:07, Simon Glass wrote: > > Hi Sughosh, > > On Fri, 11 Aug 2023 at 05:23, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Thu, 10 Aug 2023 at 22:57, Simon Glass wrote: > > > > > > Hi, > > > > > > On Thu, 10 Aug 2023 at 09:52, Tom Rini wrote: > > > > > > > >

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Simon Glass
Hi Sughosh, On Fri, 11 Aug 2023 at 08:23, Sughosh Ganu wrote: > > On Fri, 11 Aug 2023 at 19:28, Tom Rini wrote: > > > > On Fri, Aug 11, 2023 at 04:29:37PM +0530, Sughosh Ganu wrote: > > > On Thu, 10 Aug 2023 at 22:47, Tom Rini wrote: > > > > > > > > On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sug

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Sughosh Ganu
hi Simon, On Fri, 11 Aug 2023 at 19:56, Simon Glass wrote: > > Hi Sughosh, > > On Fri, 11 Aug 2023 at 08:23, Sughosh Ganu wrote: > > > > On Fri, 11 Aug 2023 at 19:28, Tom Rini wrote: > > > > > > On Fri, Aug 11, 2023 at 04:29:37PM +0530, Sughosh Ganu wrote: > > > > On Thu, 10 Aug 2023 at 22:47,

Re: [PATCH v3 3/3] X86: pxeboot: bugfix: Set variable for size of initrd

2023-08-11 Thread Bin Meng
Hi Thomas, Simon, On Fri, Aug 11, 2023 at 8:26 PM Bin Meng wrote: > > Hi Simon, > > On Fri, Aug 11, 2023 at 5:33 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Thu, 4 May 2023 at 18:40, Simon Glass wrote: > > > > > > On Thu, 4 May 2023 at 07:43, wrote: > > > > > > > > From: Thomas Mittelstae

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Tom Rini
On Fri, Aug 11, 2023 at 08:26:36AM -0600, Simon Glass wrote: > Hi Sughosh, > > On Fri, 11 Aug 2023 at 08:23, Sughosh Ganu wrote: > > > > On Fri, 11 Aug 2023 at 19:28, Tom Rini wrote: > > > > > > On Fri, Aug 11, 2023 at 04:29:37PM +0530, Sughosh Ganu wrote: > > > > On Thu, 10 Aug 2023 at 22:47, T

Re: [PATCH] net: Fix the displayed value of bytes transferred

2023-08-11 Thread Tom Rini
On Fri, Aug 11, 2023 at 10:49:23AM +0530, Siddharth Vadapalli wrote: > Ravi, > > On 10/08/23 17:00, Ravi Gunasekaran wrote: > > Siddharth, > > > > On 8/10/23 2:45 PM, Siddharth Vadapalli wrote: > >> In the case of NETLOOP_SUCCESS, the decimal value of the u32 variable > >> "net_boot_file_size" is

Re: [PATCH 1/3] fdt: common API to populate kaslr seed

2023-08-11 Thread Sean Edmond
On 2023-08-09 6:49 p.m., Simon Glass wrote: Hi Sean, On Wed, 9 Aug 2023 at 16:35, Sean Edmond wrote: On 2023-08-08 7:03 p.m., Simon Glass wrote: Hi, On Fri, 4 Aug 2023 at 17:34, wrote: From: Dhananjay Phadke fdt_fixup_kaslr_seed() will update given FDT with random seed value. Source f

[PATCH] CI: x86: coreboot: Update to latest coreboot

2023-08-11 Thread Simon Glass
Use a recent coreboot build for this test. The coreboot commit is: 6f5ead14b4 mb/google/nissa/var/joxer: Update eMMC DLL settings This is build with default settings, i.e. QEMU x86 i440fx/piix4 Add some documentation as to how to update it next time. Signed-off-by: Simon Glass --- .azure

Re: CFP open for RISC-V MC at Linux Plumbers Conference 2023

2023-08-11 Thread Atish Patra
On Mon, Jun 26, 2023 at 11:21 PM Atish Patra wrote: > > On Mon, Jun 26, 2023 at 9:08 PM Drew Fustini wrote: > > > > On Mon, Jun 19, 2023 at 12:55:39PM -0700, Atish Patra wrote: > > > The CFP for topic proposals for the RISC-V micro conference[1] 2023 is > > > open now. > > > Please submit your p

Re: [PATCH 2/5] usb: dwc2: Use regulator_set_enable_if_allowed

2023-08-11 Thread Marek Vasut
On 7/19/23 23:20, Jonas Karlman wrote: With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators. Change to use the more relaxed regulator_set_enable_if_allowed to continue if regulato

Re: [PATCH 3/5] usb: ehci-generic: Use regulator_set_enable_if_allowed

2023-08-11 Thread Marek Vasut
On 7/19/23 23:20, Jonas Karlman wrote: With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators. Change to use the more relaxed regulator_set_enable_if_allowed to continue if regulato

Re: [PATCH 2/5] usb: dwc2: Use regulator_set_enable_if_allowed

2023-08-11 Thread Jonas Karlman
On 2023-08-11 20:59, Marek Vasut wrote: > On 7/19/23 23:20, Jonas Karlman wrote: >> With the commit 4fcba5d556b4 ("regulator: implement basic reference >> counter") the return value of regulator_set_enable may be EALREADY or >> EBUSY for fixed/gpio regulators. >> >> Change to use the more relaxed r

Re: [PATCH 3/5] usb: ehci-generic: Use regulator_set_enable_if_allowed

2023-08-11 Thread Jonas Karlman
On 2023-08-11 21:00, Marek Vasut wrote: > On 7/19/23 23:20, Jonas Karlman wrote: >> With the commit 4fcba5d556b4 ("regulator: implement basic reference >> counter") the return value of regulator_set_enable may be EALREADY or >> EBUSY for fixed/gpio regulators. >> >> Change to use the more relaxed r

Re: [PATCH 0/5] Keep fixed/gpio regulator enable count in balance

2023-08-11 Thread Jonas Karlman
On 2023-07-21 08:25, Svyatoslav Ryhel wrote: > чт, 20 лип. 2023 р. о 00:20 Jonas Karlman пише: >> >> The commit 4fcba5d556b4 ("regulator: implement basic reference counter") >> have made it more important to keep fixed/gpio regulators enable/disable >> state in balance. >> >> This series fixes an

Re: [PATCH 2/2] rockchip: rk356x-u-boot: Add bootph-all to i2c0_xfer pinctrl node

2023-08-11 Thread Jonas Karlman
Hi Quentin, On 2023-08-08 11:55, Quentin Schulz wrote: > Hi Jonas, > > On 8/3/23 23:11, Jonas Karlman wrote: >> A RK8XX PMIC is typically using i2c0 on RK356x devices. Add bootph-all >> to required pinctrl nodes to simplify use of the prevent booting on >> power plug-in option in SPL. >> > > I'd

[PATCH] net: phy: broadcom: add BCM5221 phy support

2023-08-11 Thread Giulio Benetti
Add BCM5221 phy support. Sponsored by: Tekvox Inc. Cc: Jim Reinhart Cc: James Autry Cc: Matthew Maron Signed-off-by: Giulio Benetti --- drivers/net/phy/broadcom.c | 99 ++ 1 file changed, 99 insertions(+) diff --git a/drivers/net/phy/broadcom.c b/drivers/n

[PATCH] schemas: Add a schema for memory map

2023-08-11 Thread Simon Glass
The Devicespec specification skips over handling of a logical view of the memory map, pointing users to the UEFI specification. It is common to split firmware into 'Platform Init', which does the initial hardware setup and a "Payload" which selects the OS to be booted. Thus an handover interface i

[PATCH v3 1/2] schemas: Add firmware node schema

2023-08-11 Thread Simon Glass
Add a motivation and purpose for this new proposed node. Signed-off-by: Simon Glass --- (no changes since v1) dtschema/schemas/firmware.yaml | 83 ++ 1 file changed, 83 insertions(+) create mode 100644 dtschema/schemas/firmware.yaml diff --git a/dtschema/schem

[PATCH v3 2/2] schemas: Add a schema for binman

2023-08-11 Thread Simon Glass
With this version I have done with a generic name, in this case 'data', as suggested by Alper Nebi Yasak. This may be controversial, but we may as well have the dicussion now. I assume that there are no other ongoing attempts to define the layout of firmware in devicetree. Signed-off-by: Simon Gla

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Takahiro Akashi
On Fri, Aug 11, 2023 at 07:54:11PM +0530, Sughosh Ganu wrote: > hi Simon, > > On Fri, 11 Aug 2023 at 19:07, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Fri, 11 Aug 2023 at 05:23, Sughosh Ganu wrote: > > > > > > hi Simon, > > > > > > On Thu, 10 Aug 2023 at 22:57, Simon Glass wrote: > > > >

Re: [PATCH v3 10/10] MAINTAINERS: Add Broadcom Broadband SoC HS SPI drivers

2023-08-11 Thread William Zhang
Hi Tom, On 08/08/2023 07:02 PM, Tom Rini wrote: On Wed, Jun 07, 2023 at 04:37:10PM -0700, William Zhang wrote: Add entry for Broadcom Broadband SoC HS SPI drivers Signed-off-by: William Zhang Can you please rebase this rest of this series on top of current next and fix the compiler warning

[RFC PATCH 0/4] mtd: ubi: Enable accessing RO filesystems in UBI vols

2023-08-11 Thread Sam Edwards
Hi UBI maintainers, My target's rootfs is a read-only filesystem stored in a static UBI volume, mounted via a "ubiblock" device after boot. I'd also like to keep the boot files in the same filesystem, so that it's all coupled together. To that end, I'm working on a patchset so that U-Boot can read

[RFC PATCH 1/4] mtd: ubi: register UBI attachments as DM devices

2023-08-11 Thread Sam Edwards
This is in preparation for exposing static UBI volumes as block devices. A UBI uclass and driver are introduced, and a "ubi0" virtual device with the proper driver is created below whichever MTD device is attached as the active UBI partition. This virtual device will soon be the parent for the BLK

[RFC PATCH 2/4] mtd: ubi: bind block device driver for static volumes

2023-08-11 Thread Sam Edwards
This makes static UBI volumes readable as block devices, however no mechanism for selecting these volume devices yet exists. Signed-off-by: Sam Edwards --- drivers/mtd/ubi/ubi-uclass.c | 110 +++ 1 file changed, 110 insertions(+) diff --git a/drivers/mtd/ubi/ubi-

[RFC PATCH 3/4] disk: part: fall-through if "ubi" requested but ubifs not mounted

2023-08-11 Thread Sam Edwards
Since we're adding the ability to access static UBI volumes as block devices, it is no longer an error to use the "ubi" ifname with UBIFS unmounted. Ideally, the access to UBIFS should instead be called "ubifs" but it would break backwards compatibility to change this. Instead, use the UBIFS mount

[RFC PATCH 4/4] HACK: enable access to `ubi 0:volname` block devices

2023-08-11 Thread Sam Edwards
--- disk/part.c | 56 + 1 file changed, 56 insertions(+) diff --git a/disk/part.c b/disk/part.c index 1ad8277b65..85eb51429a 100644 --- a/disk/part.c +++ b/disk/part.c @@ -14,6 +14,9 @@ #include #include #include +#include +#include +#in

[PATCH 0/5] Add anti-rollback validation feature

2023-08-11 Thread seanedmond
From: Sean Edmond Adds Add anti-rollback version protection. Images with an anti-rollback counter value "arbvn" declared in the FDT will be compared against the current device anti-rollback counter value, and older images will not pass signature validation. If the image is newer, the device ant

[PATCH 1/5] drivers: security: Add security devices to driver model

2023-08-11 Thread seanedmond
From: Stephen Carlson Security devices currently implement operations to store an OS anti-rollback monotonic counter. Existing devices such as the Trusted Platform Module (TPM) already support this operation, but this uclass provides abstraction for current and future devices that may support dif

[PATCH 4/5] common: Add OS anti-rollback grace period

2023-08-11 Thread seanedmond
From: Stephen Carlson New config CONFIG_FIT_ARBVP_GRACE to add a one unit grace period to OS anti-rollback protection, allowing images with anti-rollback counters exactly one less than the platform value to still be loaded. No update to the platform anti-rollback counter will be performed in this

[PATCH 5/5] dm: test: Add a test for security driver

2023-08-11 Thread seanedmond
From: Sean Edmond Adds a test for a sandbox and TPM backed security driver. Allows for testing of anti-rollback version number get/set API using the security driver. Signed-off-by: Sean Edmond --- arch/sandbox/dts/test.dts | 8 configs/sandbox_defconfig | 3 ++ test/dm/Makefile

[PATCH 3/5] common: Add OS anti-rollback validation using security devices

2023-08-11 Thread seanedmond
From: Stephen Carlson New config CONFIG_ARBP to enable enforcement of OS anti-rollback counter during image loading. Images with an anti-rollback counter value "arbvn" declared in the FDT will be compared against the current device anti-rollback counter value, and older images will not pass sign

[PATCH 2/5] drivers: security: Add TPM2 implementation of security devices

2023-08-11 Thread seanedmond
From: Stephen Carlson This implementation of the security uclass driver allows existing TPM2 devices declared in the device tree to be referenced for storing the OS anti-rollback counter, using the TPM2 non-volatile storage API. Signed-off-by: Stephen Carlson --- MAINTAINERS

[PATCH 0/3] Allwinner R528/T113s PSCI

2023-08-11 Thread Sam Edwards
Hi list, With Andre's R528 support (hopefully) landing soon, I figure now is time to submit these patches for review. They refactor the ARMv7/sunxi PSCI implementation to allow for the new NCAT2 CPU complex control registers, and add support for the R528/T113s. Depends on series 365063. Thanks,

[PATCH 1/3] sunxi: psci: clean away preprocessor macros

2023-08-11 Thread Sam Edwards
This patch restructures psci.c to get away from the "many different function definitions switched by #ifdef" paradigm to the preferred style of having a single function definition with `if (IS_ENABLED(...))` to make the optimizer include only the appropriate function bodies instead. There are no f

[PATCH 2/3] sunxi: psci: refactor register access to separate functions

2023-08-11 Thread Sam Edwards
This is to prepare for R528, which does not have the typical "CPUCFG" block; it has a "CPUX" block which provides these same functions but is organized differently. Moving the hardware-access bits to their own functions separates the logic from the hardware so we can reuse the same logic. Signed-

[PATCH 3/3] sunxi: psci: implement PSCI on R528

2023-08-11 Thread Sam Edwards
This patch adds the necessary code to make nonsec booting and PSCI secondary core management functional on the R528/T113. Signed-off-by: Sam Edwards Tested-by: Maksim Kiselev --- arch/arm/cpu/armv7/sunxi/psci.c | 47 - arch/arm/mach-sunxi/Kconfig | 2 ++ inc

Re: [PATCH v3 10/10] MAINTAINERS: Add Broadcom Broadband SoC HS SPI drivers

2023-08-11 Thread Tom Rini
On Fri, Aug 11, 2023 at 04:57:10PM -0700, William Zhang wrote: > Hi Tom, > > On 08/08/2023 07:02 PM, Tom Rini wrote: > > On Wed, Jun 07, 2023 at 04:37:10PM -0700, William Zhang wrote: > > > > > Add entry for Broadcom Broadband SoC HS SPI drivers > > > > > > Signed-off-by: William Zhang > > > >

Re: [PATCH v1] board: rockchip: Add Bananapi R2Pro Board

2023-08-11 Thread Kever Yang
Hi Frank, On 2023/8/8 01:14, Frank Wunderlich wrote: From: Frank Wunderlich Add rk3568 based Bananapi R2 Pro board. Signed-off-by: Frank Wunderlich --- because iodomain is different to evb and now iodomain driver is sent as patch we need to separate between EVB and R2Pro else board can be br

[PATCH] spi: bcm63xx-hsspi: Fix compiler warning

2023-08-11 Thread William Zhang
When build for arm64 target, comipler reports the following warning: drivers/spi/bcm63xx_hsspi.c: In function ‘bcm63xx_hsspi_xfer_dummy_cs’: include/linux/kernel.h:184:17: warning: comparison of distinct pointer types lacks a cast 184 | (void) (&_min1 == &_min2); \ | ^~ dr

Re: [PATCH v2 1/2] arm64: dts: rockchip: Sync DT from linux-next

2023-08-11 Thread Kever Yang
Hi Jagan, On 2023/8/9 20:34, Jagan Teki wrote: Hi Kever, On Wed, 26 Jul 2023 at 13:55, Jagan Teki wrote: On Wed, 26 Jul 2023 at 13:42, Kever Yang wrote: Hi Jagan, On 2023/7/19 16:17, Jagan Teki wrote: Sync the linux-next from below commit, commit <1642bf66e270> ("arm64: dts: rockchip: add

Re: [PATCH 1/1] video: avoid build failure on veyron board

2023-08-11 Thread Kever Yang
On 2023/8/4 08:35, Alvaro Fernando García wrote: 533ad9dc avoided an overflow but causes compilation failure on 32bit boards (eg. veyron speedy) this commit uses div_u64 which has a fallback codepath for 32bit platforms Signed-off-by: Alvaro Fernando García Reviewed-by: Kever Yang Thanks

[PATCH v2] rockchip: cru: Enable cpu info support for rk3568

2023-08-11 Thread Kever Yang
From: Anton Add cru structure definition in head file to support cpu_info driver. Signed-off-by: Anton Signed-off-by: Kever Yang --- Changes in v2: Format the patch header, add commit message and signature. arch/arm/include/asm/arch-rockchip/cru.h| 2 ++ arch/arm/include/asm/arch-ro

Re: [PATCH] [*] fix RK3568 build under CONFIG_DISPLAY_CPUINFO flag

2023-08-11 Thread Kever Yang
HI Anton,     Thanks for your patch.     I will help to format the patch under the requirement of U-Boot[1] this time, but you will need to do it by yourself if you have follow up patches. Thanks, - Kever [1] https://u-boot.readthedocs.io/en/latest/develop/codingstyle.html On 2023/8/7 15

Re: [PATCH 1/2] rockchip: spl: Drop useless call to debug_uart_init

2023-08-11 Thread Kever Yang
On 2023/8/3 01:05, Massimo Pegorer wrote: Since commit 0dba45864b2a ("arm: Init the debug UART") function debug_uart_init is called in crt files _main before calling board_init_f. Therefore, there is no need to call it again inside board_init_f implementation in arm/mach-rockchip/spl.c. Signed

Re: [PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init

2023-08-11 Thread Kever Yang
On 2023/8/3 01:05, Massimo Pegorer wrote: Debug uart is no more inited in board_init_f function: remove this debug message from board_init_f. If an earliest-as-possible message after debug uart initialization is needed, enable DEBUG_UART_ANNOUNCE Kconfig option, instead. Signed-off-by: Massimo

Re: [PATCH] rockchip: MAINTAINERS: fix board name for Radxa ROCK 4C+

2023-08-11 Thread Kever Yang
On 2023/8/3 16:04, FUKAUMI Naoki wrote: align with other ROCK series. Fixes: 2b506407c8 ("rockchip: Add MAINTAINERS entry for Radxa Rock 4C+") Signed-off-by: FUKAUMI Naoki Reviewed-by: Kever Yang Thanks, - Kever --- board/rockchip/evb_rk3399/MAINTAINERS | 2 +- 1 file changed, 1 insert

Re: [PATCH v2 01/10] rockchip: allow env defines for SPL build

2023-08-11 Thread Kever Yang
On 2023/8/1 15:28, Eugen Hristev wrote: For environment in SPL, all these defines are required, otherwise build fails: [...] include/env_default.h:120:9: note: in expansion of macro ‘CFG_EXTRA_ENV_SETTINGS’ 120 | CFG_EXTRA_ENV_SETTINGS | ^~ In fil

Re: [PATCH] pinctrl: rockchip: Fix drive and input schmitt on RK3568

2023-08-11 Thread Kever Yang
Add Steven Liu, Hi Steven,     Please help to review this patch. On 2023/8/4 01:44, Jonas Karlman wrote: rk3568_set_drive configures a second reg for specific pins. Mainline linux does not do this and vendor U-Boot only run similar code when bit 14 and 15 are both 0 in PMU_GRF_SOC_CON0. The

Re: [PATCH v2 07/10] ARM: mach-rockchip: spl-boot-order: add possibility to DFU

2023-08-11 Thread Kever Yang
On 2023/8/1 15:28, Eugen Hristev wrote: Add DFU as a possible SPL boot media if the boot device is a gadget device. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/spl-boot-order.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ar

Re: [PATCH v2 06/10] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add bootph-all to gadget nodes

2023-08-11 Thread Kever Yang
Hi Eugen, On 2023/8/1 15:28, Eugen Hristev wrote: Add bootph-all to gadget nodes to have the gadget available in SPL. Does this gadget available on both USB2 and USB3? I think only USB2 is enough? Thanks, - Kever Signed-off-by: Eugen Hristev --- arch/arm/dts/rk3588-rock-5b-u-boot.dt

Re: [PATCH v2 10/10] configs: rockchip: rock5b-rk3588: enable DFU and related configs

2023-08-11 Thread Kever Yang
On 2023/8/1 15:28, Eugen Hristev wrote: Enable DFU and related configs, expand stack and buffers to hold downloaded image. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: - added # CONFIG_SPL_BINMAN_UBOOT_SYMBOLS is not set because with the configs

Re: [PATCH v2 1/4] rockchip: Add support to generate GZIP compressed U-boot binary

2023-08-11 Thread Kever Yang
Hi Manoj,     This patch need rebase, and could you please address the comment from Jonas in new version is possible. Thanks, - Kever On 2023/7/25 11:50, Manoj Sai wrote: Add support for generating a GZIP-compressed U-boot binary with the help of binman, if CONFIG_SPL_GZIP is selected. Si

Re: [PATCH 0/7] rockchip: Add GMAC support for RK3568 and RK3588

2023-08-11 Thread Kever Yang
Add David, Hi David,     Please help to review this patch set for dwc_eth_qos for rk3568/rk3588. Thanks, - Kever On 2023/8/7 08:08, Jonas Karlman wrote: This series adds a glue driver, dwc_eth_qos_rockchip, to support GMAC on RK356x and RK3588. rk_gmac_ops used in this series has been por

[PATCH] Add support for more XMC series

2023-08-11 Thread SSunk
Add XMC XM25QH128C/XM25QH256C/XM25QU256C/XM25QH512C/XM25QU512C site: https://www.xmcwh.com/site/product Signed-off-by: Kankan Sun --- configs/evb-ast2600_defconfig | 1 + drivers/mtd/spi/spi-nor-ids.c | 4 2 files changed, 5 insertions(+) diff --git a/configs/evb-ast2600_defconfig b/config

[PATCH] Add support for more XMC series

2023-08-11 Thread SSunk
Add XMC XM25QH256C/XM25QU256C/XM25QH512C/XM25QU512C site: https://www.xmcwh.com/site/product Signed-off-by: Kankan Sun --- configs/evb-ast2600_defconfig | 1 + drivers/mtd/spi/spi-nor-ids.c | 4 2 files changed, 5 insertions(+) diff --git a/configs/evb-ast2600_defconfig b/configs/evb-ast26

Re: [PATCH] kirkwood: dns325: Enable 2nd harddrive

2023-08-11 Thread Tony Dinh
On Fri, Aug 11, 2023 at 3:02 PM Stefan Roese wrote: > > The 2nd HD is not enabled in U-Boot on the D-Link DNS325. This patch > sets the responsible GPIO to high, enabling the drive. > > Suggested-by: Peter Granilla > Signed-off-by: Stefan Roese > Cc: Tom Rini > --- > board/d-link/dns325/dns325.

[PATCH v9 00/10] Enable EFI capsule generation through binman

2023-08-11 Thread Sughosh Ganu
This patch series adds support for generation of EFI capsules as part of u-boot build flow. The capsules can be generated as part of u-boot build, and this is being achieved through binman, by adding a capsule entry type. The parameters needed for capsule generation are specified as properties un

[PATCH v9 01/10] binman: bintool: Build a tool from a list of commands

2023-08-11 Thread Sughosh Ganu
Add support to build a tool from source with a list of commands. This is useful when a tool can be built with multiple commands instead of a single command. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V8: None tools/binman/bintool.py | 19 +++ 1 file

[PATCH v9 02/10] nuvoton: npcm845-evb: Add a newline at the end of file

2023-08-11 Thread Sughosh Ganu
Add a newline at the end of the dts, without which the build fails when including a dtsi file. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas --- Changes since V8: None arch/arm/dts/nuvoton-npcm845-evb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH v9 03/10] sandbox: capsule: Add keys and certificates needed for capsule update testing

2023-08-11 Thread Sughosh Ganu
Add the private keys and public key certificates which are to be used for capsule authentication while testing the EFI capsule update functionality. There are two pairs of private and public keys, good and bad. The good key pair will be used for signing capsules, whilst the bad key pair is to be us

[PATCH v9 04/10] sandbox: capsule: Enable EFI capsule module on sandbox variants

2023-08-11 Thread Sughosh Ganu
Enable the EFI capsule update code on all sandbox variants. This was already enabled on the sandbox, sandbox64 and sandbox_flattree variants. The rest of the variants also have the EFI capsule update module enabled now. With this commit, the mkeficapsule tool also gets enabled on all variants. Si

[PATCH v9 05/10] btool: mkeficapsule: Add a bintool for EFI capsule generation

2023-08-11 Thread Sughosh Ganu
Add a bintool for generating EFI capsules. This calls the mkeficapsule tool which generates the capsules. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V8: None tools/binman/btool/mkeficapsule.py | 101 + 1 file changed, 101 insertions(+) c

[PATCH v9 06/10] binman: capsule: Add support for generating EFI capsules

2023-08-11 Thread Sughosh Ganu
Add support in binman for generating EFI capsules. The capsule parameters can be specified through the capsule binman entry. Also add test cases in binman for testing capsule generation. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V8: None tools/binman/entries.rst

[PATCH v9 07/10] sandbox: binman: Add support for generating multiple images

2023-08-11 Thread Sughosh Ganu
Add support for all sandbox variants to support generating multiple images. This also requires tweaking the binman node of the sandbox_vpl variant to work with the multiple-images property. Signed-off-by: Sughosh Ganu Signed-off-by: Simon Glass --- Changes since V8: * New patch based on suggesti

[PATCH v9 08/10] sandbox: capsule: Generate capsule related files through binman

2023-08-11 Thread Sughosh Ganu
The EFI capsule files can now be generated as part of u-boot build through binman. Add capsule entry nodes for the sandbox architecture for generating the capsules. These capsules are then used for testing the EFI capsule update functionality on the sandbox platforms. Remove the corresponding logi

  1   2   >