Re: [PATCH] net: Fix the displayed value of bytes transferred

2023-08-13 Thread Siddharth Vadapalli
On 14/08/23 10:06, Siddharth Vadapalli wrote: > Hello Tom, > > On 11/08/23 21:45, Tom Rini wrote: >> On Fri, Aug 11, 2023 at 10:49:23AM +0530, Siddharth Vadapalli wrote: >>> Ravi, >>> >>> On 10/08/23 17:00, Ravi Gunasekaran wrote: ... >> >> Uh, maybe I'm just missing something, but I think

[PATCH v2 2/2] doc: printf() codes: Fix format specifier for unsigned int

2023-08-13 Thread Siddharth Vadapalli
The format specifier for the "unsigned int" variable is documented as "%d". However, it should be "%u". Thus, fix it. Fixes: f5e9035043fb ("doc: printf() codes") Reported-by: Tom Rini Signed-off-by: Siddharth Vadapalli --- doc/develop/printf.rst | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 1/2] net: Fix the displayed value of bytes transferred

2023-08-13 Thread Siddharth Vadapalli
In the case of NETLOOP_SUCCESS, the decimal value of the u32 variable "net_boot_file_size" is printed using "%d", resulting in negative values being reported for large file sizes. Fix this by using "%u" to print the decimal value corresponding to the bytes transferred. Fixes: 1411157d8578 ("net:

[PATCH v2 0/2] Fix format specifier for net_boot_file_size

2023-08-13 Thread Siddharth Vadapalli
Hello, This series fixes the format specifier for printing the decimal value of the variable "net_boot_file_size", changing it from "%d" to "%u". With the format specifier being "%d", for large file sizes, the value displayed is negative. Using "%u" fixes this. Additionally, as reported by Tom

Re: [PATCH] net: Fix the displayed value of bytes transferred

2023-08-13 Thread Siddharth Vadapalli
Hello Tom, On 11/08/23 21:45, Tom Rini wrote: > On Fri, Aug 11, 2023 at 10:49:23AM +0530, Siddharth Vadapalli wrote: >> Ravi, >> >> On 10/08/23 17:00, Ravi Gunasekaran wrote: >>> Siddharth, >>> >>> On 8/10/23 2:45 PM, Siddharth Vadapalli wrote: In the case of NETLOOP_SUCCESS, the decimal

Re: [PATCH 12/24] fs/erofs: Quieten test for filesystem presence

2023-08-13 Thread Gao Xiang
On 2023/8/13 22:26, Simon Glass wrote: At present listing a partition produces lots of errors about this filesystem: => part list mmc 4 cannot find valid erofs superblock cannot find valid erofs superblock cannot read erofs superblock: -5 [9 more similar lines] Use

Re: [PATCH] Add support for more XMC series

2023-08-13 Thread Clus Tom
Hi Simon, I'm not quite sure what you mean by v2, if it's the previous email, it only removes the XM25QH128C part of the commit message compared to the previous one. Thanks, SSunk Simon Glass 于2023年8月13日周日 21:36写道: > On Fri, 11 Aug 2023 at 21:19, SSunk wrote: > > > > Add XMC

Re: [PATCH] rockchip: rk356x: Enable poweroff command

2023-08-13 Thread Kever Yang
Hi Jonas,     Please split this patch into two patch, one for update defconfig and one for update pmic Kconfig. Thanks, - Kever On 2023/8/4 03:54, Jonas Karlman wrote: With PMIC_RK8XX, SYSRESET and CMD_POWEROFF options enabled it is possible to power down a board using the poweroff

Re: [PATCH] x86: Update cbmem driver

2023-08-13 Thread Alex Sadovsky
Dear Simon and other developers, > - cursor = cbmem_console_p->buffer_cursor++; > - if (cursor < cbmem_console_p->buffer_size) > - cbmem_console_p->buffer_body[cursor] = data; > + pos = cons->cursor++; > + if (pos < cons->size) > + cons->body[pos] = data;

Re: [PATCH v2] pinctrl: rockchip: Fix drive and input schmitt on RK3568

2023-08-13 Thread Kever Yang
On 2023/8/14 08:28, Jonas Karlman wrote: On RK3568 most pins have a configurable drive strength of level 0-5 and some pins level 0-11. When rk3568_set_drive is called with a strength value above 7 the drv value written to reg may overflow into the write enable bits, resulting in a bad

Re: [PATCH] pinctrl: rockchip: Fix drive and input schmitt on RK3568

2023-08-13 Thread Jonas Karlman
Hi Kever and Steven, On 2023-08-12 04:50, Kever Yang wrote: > Add Steven Liu, > > Hi Steven, > >     Please help to review this patch. > > > On 2023/8/4 01:44, Jonas Karlman wrote: >> rk3568_set_drive configures a second reg for specific pins. Mainline >> linux does not do this and vendor

[PATCH v2] pinctrl: rockchip: Fix drive and input schmitt on RK3568

2023-08-13 Thread Jonas Karlman
On RK3568 most pins have a configurable drive strength of level 0-5 and some pins level 0-11. When rk3568_set_drive is called with a strength value above 7 the drv value written to reg may overflow into the write enable bits, resulting in a bad configuration. This cause e.g. ethernet PHY on Radxa

RE: [PATCH] Add support for more XMC series

2023-08-13 Thread ChiaWei Wang
> From: SSunk > Sent: Saturday, August 12, 2023 11:08 AM > > Add XMC > XM25QH128C/XM25QH256C/XM25QU256C/XM25QH512C/XM25QU512C > site: https://www.xmcwh.com/site/product > > Signed-off-by: Kankan Sun Reviewed-by: Chia-Wei Wang

Re: [PATCH 1/2] drivers/mtd/nvmxip: Rework the read accessor to support 32bit systems

2023-08-13 Thread Marek Vasut
On 8/13/23 23:46, Marek Vasut wrote: Get rid of nvmxip_mmio_rawread() and just implement the readl()/readq() reader loop within nvmxip_blk_read(). Cast the destination buffer as needed and increment the read by either 4 or 8 bytes depending on if this is systemd with 32bit or 64bit physical

Re: [PATCH] usb: gadget: sdp: Option to enable SDP read register command

2023-08-13 Thread Marek Vasut
On 8/13/23 10:39, Loic Poulain wrote: The SDP read register command can be used to read any memory mapped address of the device (ddr, registers...). It can then be exploited by an attacker to access sensitive data/values, especially when running SDP from SPL, as SPL runs with highest privileges

[PATCH 5/6] ufs: Use utp_transfer_req_desc pointer in ufshcd_get_tr_ocs

2023-08-13 Thread Marek Vasut
Use utp_transfer_req_desc pointer to reference to utrdl queue instead of referencing the queue directly. This makes the code more consistent. No functional change. Signed-off-by: Marek Vasut --- Cc: Faiz Abbas --- drivers/ufs/ufs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 6/6] ufs: Implement cache management

2023-08-13 Thread Marek Vasut
Add function to flush and invalidate cache over request and response queue entries, and perform flush and optional invalidate over block layer data that are passed into the UFS layer. This makes it possible to use UFS with caches enabled. Signed-off-by: Marek Vasut --- Cc: Faiz Abbas ---

[PATCH 4/6] ufs: Pass hba pointer to ufshcd_prepare_req_desc_hdr()

2023-08-13 Thread Marek Vasut
Pass the hba pointer itself to ufshcd_prepare_req_desc_hdr() instead of duplicating utp_transfer_req_desc access at each call site. No functional change. Signed-off-by: Marek Vasut --- Cc: Faiz Abbas --- drivers/ufs/ufs.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff

[PATCH 3/6] ufs: Handle UFS 3.0 controllers

2023-08-13 Thread Marek Vasut
Extend the version check to handle UFS 3.0 controllers as well. Tested on R-Car S4 UFS 3.0 controller. Signed-off-by: Marek Vasut --- Cc: Faiz Abbas --- drivers/ufs/ufs.c | 3 ++- drivers/ufs/ufs.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/ufs.c

[PATCH 1/6] ufs: Add UFSHCD_QUIRK_BROKEN_64BIT_ADDRESS

2023-08-13 Thread Marek Vasut
Add UFSHCD_QUIRK_BROKEN_64BIT_ADDRESS for host controllers which do not support 64-bit addressing. Ported from Linux kernel commit 6554400d6f66 ("scsi: ufs: core: Add UFSHCD_QUIRK_BROKEN_64BIT_ADDRESS") with ufs_scsi_buffer_aligned() based on U-Boot generic bounce buffer. Signed-off-by: Marek

[PATCH 2/6] ufs: Add UFSHCD_QUIRK_HIBERN_FASTAUTO

2023-08-13 Thread Marek Vasut
Add UFSHCD_QUIRK_HIBERN_FASTAUTO quirk for host controllers which supports auto-hibernate the capability but only FASTAUTO mode. Ported from Linux kernel commit 2f11bbc2c7f3 ("scsi: ufs: core: Add UFSHCD_QUIRK_HIBERN_FASTAUTO") Signed-off-by: Marek Vasut --- Cc: Faiz Abbas ---

[PATCH] clk: Add GPIO-controlled clock gate driver

2023-08-13 Thread Marek Vasut
Add driver which implements GPIO-controlled clock. The GPIO is used as a gate to enable/disable the clock. This matches linux clk-gpio.c driver, however this does not implement the GPIO mux part, which in U-Boot DM would be better fit in separate driver. Signed-off-by: Marek Vasut --- Cc: Lukasz

[PATCH 1/2] blk: Add bounce buffer support to read/write operations

2023-08-13 Thread Marek Vasut
Some devices have limited DMA capabilities and require that the buffers passed to them fit specific properties. Add new optional callback which can be used at driver level to indicate whether a buffer alignment is suitable for the device DMA or not, and trigger use of generic bounce buffer

[PATCH 2/2] scsi: Add buffer_aligned check pass-through

2023-08-13 Thread Marek Vasut
Some devices have limited DMA capabilities and require that the buffers passed to them fit specific properties. Add new optional callback which can be used at driver level to indicate whether a buffer alignment is suitable for the device DMA or not. This is a pass-through callback from block

[PATCH] disk: dos: Infer MBR partition sector size from underlying drive sector size

2023-08-13 Thread Marek Vasut
Block devices with 4k sectors imply the MBR sectors are also 4k instead of regular 512B. Avoid hard-coding the 512B sector size and isntead read the current block device sector size from it, and if the sector size is larger than 512B, use the block device sector size. Signed-off-by: Marek Vasut

[PATCH] common: bouncebuf: Add missing cast to dma_addr_t

2023-08-13 Thread Marek Vasut
Fix the following warning produced on qemu-x86_64_defconfig: " common/bouncebuf.c: In function ‘bounce_buffer_stop’: common/bouncebuf.c:82:34: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 82 |

[PATCH 5/8] disk: Extend disk_blk_part_validate() with range checking

2023-08-13 Thread Marek Vasut
Check whether access is out of bounds of the partition and return an error. This way there is no danger of esp. write or erase outside of the confines of partition. Signed-off-by: Marek Vasut --- Cc: AKASHI Takahiro Cc: Abdellatif El Khlifi Cc: Bin Meng Cc: Heinrich Schuchardt Cc: Joshua

[PATCH 8/8] disk: Make blk_get_ops() internal to blk uclass

2023-08-13 Thread Marek Vasut
Move the macro into blk-uclass.c , since it is only used there. Signed-off-by: Marek Vasut --- Cc: AKASHI Takahiro Cc: Abdellatif El Khlifi Cc: Bin Meng Cc: Heinrich Schuchardt Cc: Joshua Watt Cc: Michal Suchanek Cc: Simon Glass Cc: Tobias Waldekranz --- drivers/block/blk-uclass.c | 2

[PATCH 4/8] disk: Handle partition to block device offset conversion

2023-08-13 Thread Marek Vasut
Convert the read/write/erase offset from one within a partition to one within a block device, to correctly access the data on the block device for both write and erase operations. Signed-off-by: Marek Vasut --- Cc: AKASHI Takahiro Cc: Abdellatif El Khlifi Cc: Bin Meng Cc: Heinrich Schuchardt

[PATCH 7/8] disk: Move part_create_block_devices() to blk uclass

2023-08-13 Thread Marek Vasut
Move part_create_block_devices() to blk uclass and unexpose the function. This can now be internal to the block uclass. Signed-off-by: Marek Vasut --- Cc: AKASHI Takahiro Cc: Abdellatif El Khlifi Cc: Bin Meng Cc: Heinrich Schuchardt Cc: Joshua Watt Cc: Michal Suchanek Cc: Simon Glass Cc:

[PATCH 6/8] disk: Switch part_blk_*() functions to disk_blk_*()

2023-08-13 Thread Marek Vasut
The behavior of the part_blk_*() functions is now identical to disk_blk_*() functions, switch the former to the later. Signed-off-by: Marek Vasut --- Cc: AKASHI Takahiro Cc: Abdellatif El Khlifi Cc: Bin Meng Cc: Heinrich Schuchardt Cc: Joshua Watt Cc: Michal Suchanek Cc: Simon Glass Cc:

[PATCH 3/8] disk: Simplify disk_blk_{write, erase}() using blk_{write, erase}()

2023-08-13 Thread Marek Vasut
These two functions are basically identical, just call the blk_*() functions from disk_blk_*() functions. The only difference is that the disk_blk_*() functions have to use parent block device as the udevice implementing block device operations. Add documentation on what those functions really

[PATCH 2/8] disk: Simplify disk_blk_read() using blk_read()

2023-08-13 Thread Marek Vasut
The disk_blk_read() can be simplified using blk_read(), the only things which needs to be handled are the read offset based on the partition properties, and the block device ops which are coming from the parent udevice, not the partition udevice. The later is currently not implemented correctly

[PATCH 1/8] disk: Drop always true conditional check

2023-08-13 Thread Marek Vasut
if (device_get_uclass_id(dev) == UCLASS_PARTITION) is always true, because this disk_blk_read() function calls dev_get_blk() above and checks its return value for non-NULL. The dev_get_blk() performs the same device_get_uclass_id(dev) check and returns NULL if not UCLASS_PARTITION. Drop the

[PATCH 2/2] configs: sandbox: test: dm: blk: Enable NVMXIP QSPI and update test

2023-08-13 Thread Marek Vasut
Enable NVMXIP QSPI driver on sandbox, since it is already enabled on sandbox64. Update blk tests to match. Signed-off-by: Marek Vasut --- Cc: Abdellatif El Khlifi Cc: Simon Glass --- configs/sandbox_defconfig | 1 + test/dm/blk.c | 63 +++ 2

[PATCH 1/2] drivers/mtd/nvmxip: Rework the read accessor to support 32bit systems

2023-08-13 Thread Marek Vasut
Get rid of nvmxip_mmio_rawread() and just implement the readl()/readq() reader loop within nvmxip_blk_read(). Cast the destination buffer as needed and increment the read by either 4 or 8 bytes depending on if this is systemd with 32bit or 64bit physical address. Signed-off-by: Marek Vasut ---

Re: [PATCH] x86: Update cbmem driver

2023-08-13 Thread Simon Glass
+Paul Menzel On Sun, 13 Aug 2023 at 14:10, Simon Glass wrote: > > This driver is not actually built since a Kconfig was never created for > it. > > Add a Kconfig (which is already implied by COREBOOT) and update the > implementation to avoid using unnecessary memory. Drop the #ifdef at the >

[PATCH] x86: Update cbmem driver

2023-08-13 Thread Simon Glass
This driver is not actually built since a Kconfig was never created for it. Add a Kconfig (which is already implied by COREBOOT) and update the implementation to avoid using unnecessary memory. Drop the #ifdef at the top since we can rely on Kconfig to get that right. To enable it (in addition

[PATCH] test: cpu: Handle both 32bit and 64bit CPUs

2023-08-13 Thread Marek Vasut
Handle both 32bit and 64bit systems, i.e. sandbox and sandbox64 the same way drivers/cpu/cpu_sandbox.c does, that is in case CONFIG_PHYS_64BIT is enabled, assume 64bit address width, else assume 32bit address width. This fixes ut_dm_dm_test_cpu test failure on sandbox64. Signed-off-by: Marek

[PATCH] configs: sandbox64: Enable PCI register multi-entry support

2023-08-13 Thread Marek Vasut
Align the sandbox64 defconfig with sandbox defconfig. Enable missing PCI register multi-entry support. This fixes ut_dm_dm_test_pci_bus_to_phys test . Signed-off-by: Marek Vasut --- Cc: Simon Glass --- configs/sandbox64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] configs: sandbox64: Enable clock CCF driver

2023-08-13 Thread Marek Vasut
Align the sandbox64 defconfig with sandbox defconfig. Enable missing CCF and Sandbox CCF drivers. This fixes ut_dm_dm_test_clk_ccf test . Signed-off-by: Marek Vasut --- Cc: Simon Glass --- configs/sandbox64_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 1/2] net: add hifemac Ethernet driver for HiSilicon platform

2023-08-13 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen It adds the driver for HIFEMAC Ethernet controller found on HiSilicon SoCs like Hi3798MV200. It's based on the mainstream linux driver, but quite a lot of code gets rewritten and cleaned up to adopt u-boot driver model. Signed-off-by: Yang Xiwen --- drivers/net/Kconfig |

[PATCH v2 0/2] net: add support for HiSilicon Fast Ethernet Controller driver

2023-08-13 Thread Yang Xiwen via B4 Relay
This core is found on many HiSilicon chips. This patchset adds support for it and the integrated MDIO bus. The driver code comes from linux kernel driver, downstream u-boot driver and the datasheet. It's already tested on a Hi3798MV200 based STB. Note that currently this driver can't be used for

[PATCH v2 2/2] net: add hifemac_mdio MDIO bus driver for HiSilicon platform

2023-08-13 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen It adds the driver for the internal MDIO bus of HIFEMAC Ethernet controller. It's based on the mainstream linux driver. Signed-off-by: Yang Xiwen --- drivers/net/Kconfig| 8 drivers/net/Makefile | 1 + drivers/net/hifemac_mdio.c | 116

Re: Problem upon startup with halted USB device on RaspberryPi 4

2023-08-13 Thread Michal Suchánek
Hello, On Sat, Aug 12, 2023 at 08:31:56PM +0200, Massimo Pegorer wrote: > Hi Harry, > > Il giorno lun 7 ago 2023 alle ore 11:02 Harry Waschkeit < > harry.waschk...@conplement.de> ha scritto: > > > Hi, > > > > I have a RaspberryPi 4 where on one USB port a Sierra Wireless LTE > > module (EM7455)

Re: Strange gitlab idea

2023-08-13 Thread Tom Rini
On Sat, Aug 12, 2023 at 09:14:45PM -0600, Simon Glass wrote: > Hi Tom, > > I notice that the runners are not utilised much by the QEMU jobs, > since we only run one at a time. > > I wonder if we could improve this, perhaps by using a different tag > for the QEMU ones and then having a machine

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-13 Thread Tom Rini
On Sun, Aug 13, 2023 at 07:36:45AM -0600, Simon Glass wrote: > Hi Tom, > > On Sun, 13 Aug 2023 at 06:40, Tom Rini wrote: > > > > On Sat, Aug 12, 2023 at 06:14:45PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sat, 12 Aug 2023 at 16:38, Tom Rini wrote: > > > > > > > > On Sat, Aug 12,

Re: [PATCH v1] board: rockchip: Add Bananapi R2Pro Board

2023-08-13 Thread Frank Wunderlich
Am 12. August 2023 03:50:14 MESZ schrieb Kever Yang : >Hi Frank, > >On 2023/8/8 01:14, Frank Wunderlich wrote: >> From: Frank Wunderlich >> >> Add rk3568 based Bananapi R2 Pro board. >> >> Signed-off-by: Frank Wunderlich >> --- >> because iodomain is different to evb and now iodomain driver is

[PATCH 24/24] CI: Add ChromiumOS utilities

2023-08-13 Thread Simon Glass
We need cgpt and futility for building test images. Add them. Signed-off-by: Simon Glass --- tools/docker/Dockerfile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile index 3d2b64a355f3..6e6ae9ebed40 100644 --- a/tools/docker/Dockerfile

[PATCH 23/24] bootstd: cros: Allow detection of any kernel partition

2023-08-13 Thread Simon Glass
The existing ChromiumOS bootmeth only supports reading a single kernel partition, either 2 or 4. In fact there are normally two options available. Use the GUID to detect kernel partitions, with the BOOTMETHF_ANY_PART flag, so that bootstd does not require a valid filesystem before calling the

[PATCH 22/24] uuid: Add ChromiumOS partition types

2023-08-13 Thread Simon Glass
Add some GUIDs for ChromiumOS so we can detect the partitions. Signed-off-by: Simon Glass --- include/part_efi.h | 14 ++ lib/uuid.c | 7 +++ 2 files changed, 21 insertions(+) diff --git a/include/part_efi.h b/include/part_efi.h index c68529b4dafe..59b7895b8a23 100644

[PATCH 21/24] bootstd: Support bootmeths which can scan any partition

2023-08-13 Thread Simon Glass
Some bootmeths support scanning a partition without a filesystem on it. Add a flag to support this. This will allow the ChromiumOS bootmeth to find kernel partition, which are stored in a special format, without a filesystem. Signed-off-by: Simon Glass --- boot/bootdev-uclass.c | 17

[PATCH 20/24] part: Add a fallback for part_get_bootable()

2023-08-13 Thread Simon Glass
This function can be called when partition support is disabled. Add a static inline to handle this. Signed-off-by: Simon Glass --- include/part.h | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/include/part.h b/include/part.h index

[PATCH 19/24] bootstd: Add a test for bootmeth_cros

2023-08-13 Thread Simon Glass
The ChromiumOS bootmeth has no tests at present. Before adding more features. add a basic test. This creates a disk which can be scanned by the bootmeth, so make sure things work. It is quite rudimentary, since the kernel is faked, the root disk is missing and there is no cmdline stored. Enable

[PATCH 18/24] bootstd: test: Allow binding and using any mmc device

2023-08-13 Thread Simon Glass
We currently use mmc4 for tests. Update the function which sets this up so that it can handle any device. Signed-off-by: Simon Glass --- test/boot/bootflow.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/test/boot/bootflow.c

[PATCH 17/24] bootflow: Show an empty filename when there is none

2023-08-13 Thread Simon Glass
At present 'bootflow list' shows for the filename when it is not present. Show an empty string instead, since that is more user-friendly. Signed-off-by: Simon Glass --- cmd/bootflow.c | 2 +- test/boot/bootflow.c | 22 -- 2 files changed, 13 insertions(+), 11

[PATCH 16/24] test: Move 1MB.fat32.img and 2MB.ext2.img

2023-08-13 Thread Simon Glass
These are currently created in the source directory, which is not ideal. Move them to the persistent-data directory instead. Update the test so skip validating the filename, since it now includes a full path. Signed-off-by: Simon Glass --- test/dm/host.c | 44

[PATCH 15/24] sandbox: Add a way to access persistent test files

2023-08-13 Thread Simon Glass
Some pytests create files in the persistent-data directory. It is useful to be able to access these files in C tests. Add a function which can locate a file given its leaf name, using the environment variable set up in test/py/conftest.py Signed-off-by: Simon Glass --- arch/sandbox/cpu/os.c |

[PATCH 14/24] uuid: Move function comments to header file

2023-08-13 Thread Simon Glass
These should be in the header file for easy browsing, not in the source code. Move them and add a missing Return on one of the functions. Signed-off-by: Simon Glass --- include/uuid.h | 94 ++ lib/uuid.c | 86

[PATCH 13/24] dm: core: Correct error handling when event fails

2023-08-13 Thread Simon Glass
Follow the correct path in device_probe() when and event handler fails. This avoids getting into a strange state where the device appears to be activated but is not. Signed-off-by: Simon Glass --- drivers/core/device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 12/24] fs/erofs: Quieten test for filesystem presence

2023-08-13 Thread Simon Glass
At present listing a partition produces lots of errors about this filesystem: => part list mmc 4 cannot find valid erofs superblock cannot find valid erofs superblock cannot read erofs superblock: -5 [9 more similar lines] Use debugging rather than errors when unable to find a

[PATCH 11/24] part: efi: Add debugging for the signature check

2023-08-13 Thread Simon Glass
Add a little more debugging for the initial signature check. Drop the pointless check for NULL. Also set a log category while we are here. Signed-off-by: Simon Glass --- disk/part_efi.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/disk/part_efi.c

[PATCH 10/24] part: Add an accessor for struct disk_partition sys_ind

2023-08-13 Thread Simon Glass
This field is only present when a CONFIG is set. To avoid annoying #ifdefs in the source code, add an accessor. Update the only usage. Note that the accessor is optional. It can be omitted if it is known that the option is enabled. Signed-off-by: Simon Glass --- boot/bootdev-uclass.c | 7

[PATCH 09/24] part: Add accessors for struct disk_partition type_uuid

2023-08-13 Thread Simon Glass
This field is only present when a CONFIG is set. To avoid annoying #ifdefs in the source code, add accessors. Update all code to use it. Note that the accessor is optional. It can be omitted if it is known that the option is enabled. Signed-off-by: Simon Glass --- disk/part.c | 8

[PATCH 08/24] part: Add accessors for struct disk_partition uuid

2023-08-13 Thread Simon Glass
This field is only present when a CONFIG is set. To avoid annoying #ifdefs in the source code, add accessors. Update all code to use it. Note that the accessor is optional. It can be omitted if it is known that the option is enabled. Signed-off-by: Simon Glass --- cmd/gpt.c | 10

[PATCH 07/24] part: Add comments for static functions

2023-08-13 Thread Simon Glass
Some internal functions could do with a few comments, to explain what they do. Add these, to make the code easier to follow. Signed-off-by: Simon Glass --- disk/part.c | 32 1 file changed, 32 insertions(+) diff --git a/disk/part.c b/disk/part.c index

[PATCH 05/24] part: iso: Use desc instead of dev_desc

2023-08-13 Thread Simon Glass
The dev_ prefix is a hangover from the pre-driver model days. The device is now a different thing, with driver model. Update the iso code to just use 'desc'. Signed-off-by: Simon Glass --- disk/part_iso.c | 52 - 1 file changed, 26 insertions(+),

[PATCH 06/24] part: nac: Use desc instead of dev_desc

2023-08-13 Thread Simon Glass
The dev_ prefix is a hangover from the pre-driver model days. The device is now a different thing, with driver model. Update the mac code to just use 'desc'. Signed-off-by: Simon Glass --- disk/part_mac.c | 59 ++--- 1 file changed, 27 insertions(+),

[PATCH 04/24] part: efi: Use desc instead of dev_desc

2023-08-13 Thread Simon Glass
The dev_ prefix is a hangover from the pre-driver model days. The device is now a different thing, with driver model. Update the efi code to just use 'desc'. Signed-off-by: Simon Glass --- disk/part_efi.c | 228 1 file changed, 112

[PATCH 03/24] part: dos: Use desc instead of dev_desc

2023-08-13 Thread Simon Glass
The dev_ prefix is a hangover from the pre-driver model days. The device is now a different thing, with driver model. Update the dos code to just use 'desc'. Signed-off-by: Simon Glass --- disk/part_dos.c | 61 - 1 file changed, 30 insertions(+),

[PATCH 01/24] part: Use desc instead of dev_desc

2023-08-13 Thread Simon Glass
The dev_ prefix is a hangover from the pre-driver model days. The device is now a different thing, with driver model. Update the partition code to just use 'desc', as is done with driver model. Signed-off-by: Simon Glass --- disk/part.c| 178

[PATCH 02/24] part: amiga: Use desc instead of dev_desc

2023-08-13 Thread Simon Glass
The dev_ prefix is a hangover from the pre-driver model days. The device is now a different thing, with driver model. Update the amiga code to just use 'desc'. Signed-off-by: Simon Glass --- disk/part_amiga.c | 34 +- 1 file changed, 17 insertions(+), 17

[PATCH 00/24] bootstd: Support ChromiumOS better

2023-08-13 Thread Simon Glass
This updates the ChromiumOS bootmeth to detect multiple kernel partitions on a disk. It also includes minor code improvements to the partition drivers, including accessors for the optional fields. This series also includes some other related tweaks in testing. It is available at

Re: [PATCH 1/1] common: return type board_get_usable_ram_top

2023-08-13 Thread Simon Glass
Hi Heinrich, On Sat, 12 Aug 2023 at 23:01, Heinrich Schuchardt wrote: > > board_get_usable_ram_top() returns a physical address that is stored in > gd->ram_top. The return type of the function should be phys_addr_t like the > current type of gd->ram_top. > > Signed-off-by: Heinrich Schuchardt >

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-13 Thread Simon Glass
Hi Tom, On Sun, 13 Aug 2023 at 06:40, Tom Rini wrote: > > On Sat, Aug 12, 2023 at 06:14:45PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Sat, 12 Aug 2023 at 16:38, Tom Rini wrote: > > > > > > On Sat, Aug 12, 2023 at 11:03:36AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH] docs: fix wrong usage of proftool

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 23:18, Puhan Zhou wrote: > > The usage of proftool in docs is incorrect. If proftool is used without > '-o' argument, it will show the usage like following > > $ ./sandbox/tools/proftool -m sandbox/System.map -t trace -f funcgraph > dump-ftrace >trace.dat > Must provide

Re: [PATCH 2/2] configs: sandbox64: Enable PINCTRL_SINGLE driver

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 21:32, Marek Vasut wrote: > > Align the sandbox64 defconfig with sandbox defconfig. Enable missing > PINCTRL single driver. This fixes ut_dm_dm_test_pinctrl_single test . > > Signed-off-by: Marek Vasut > --- > Cc: Simon Glass > --- > configs/sandbox64_defconfig | 1 + >

Re: [PATCH] configs: sandbox64: Enable MC34708 driver

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 20:57, Marek Vasut wrote: > > Align the sandbox64 defconfig with sandbox defconfig. Enable missing > MC34708 PMIC driver. This fixes ut_dm_dm_test_power_pmic_mc34708_get test . > > Signed-off-by: Marek Vasut > --- > Cc: Simon Glass > --- > configs/sandbox64_defconfig | 1

Re: [PATCH] test: Fix the help for the ut command

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 16:16, Marek Vasut wrote: > > Drop the 'ut' prefix, this is superfluous and not present in > any of the other ut tests. > > Signed-off-by: Marek Vasut > --- > Cc: Heinrich Schuchardt > Cc: Linus Walleij > Cc: Simon Glass > Cc: Stephen Carlson > --- > test/cmd_ut.c | 2

Re: [PATCH 1/2] test: dm: pinmux: Handle %pa in pinctrl-single mux output

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 21:32, Marek Vasut wrote: > > The pinctrl-single driver uses %pa to print register value > in its single_get_pin_muxing() output. Handle this properly > in the test based on CONFIG_PHYS_64BIT . > > Signed-off-by: Marek Vasut > --- > Cc: Simon Glass > --- >

Re: [PATCH 2/2] configs: sandbox64: Enable video 12x22 font support

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 23:15, Marek Vasut wrote: > > Align the sandbox64 defconfig with sandbox defconfig. Enable missing > 12x22 font support. This fixes ut_dm_dm_test_video_text_12x22 test . > > Signed-off-by: Marek Vasut > --- > Cc: Simon Glass > --- > configs/sandbox64_defconfig | 1 + > 1

Re: [PATCH] test: acpi: Handle both 32bit and 64bit ACPI tables

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 19:26, Marek Vasut wrote: > > Handle both 32bit and 64bit systems, i.e. sandbox and sandbox64 > the same way drivers/cpu/cpu_sandbox.c sets those ACPI tables up. > This fixes "$ ./u-boot -Tc 'ut dm dm_test_acpi_write_tables'" > test failure on sandbox64. > > Signed-off-by:

Re: [PATCH] configs: sandbox64: Enable BUTTON_ADC driver

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 21:06, Marek Vasut wrote: > > Align the sandbox64 defconfig with sandbox defconfig. Enable missing > BUTTON ADC driver. This fixes ut_dm_dm_test_button_keys_adc test . > > Signed-off-by: Marek Vasut > --- > Cc: Simon Glass > --- > configs/sandbox64_defconfig | 1 + > 1

Re: [PATCH 1/2] configs: sandbox64: Enable video 16bpp and 24bpp support

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 23:15, Marek Vasut wrote: > > Align the sandbox64 defconfig with sandbox defconfig. Enable missing > 16bpp and 24bpp video support. This fixes ut_dm_dm_test_video_bmp16 > and ut_dm_dm_test_video_bmp24 tests . > > Signed-off-by: Marek Vasut > --- > Cc: Simon Glass > --- >

Re: [PATCH] configs: sandbox64: Enable SF bootdev

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 18:16, Marek Vasut wrote: > > Align the sandbox64 defconfig with sandbox defconfig. Enable missing > SPI NOT bootdev. This fixes ut_bootstd_bootdev_test_cmd_hunt test . > > Signed-off-by: Marek Vasut > --- > Cc: Mario Six > Cc: Simon Glass > --- >

Re: [PATCH] configs: sandbox64: Increase console record size to 0x6000

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 19:18, Marek Vasut wrote: > > Align the sandbox64 defconfig with sandbox defconfig. Increase the > console record size. This fixes ut_bootstd_bootflow_cmd_scan_e . > > Signed-off-by: Marek Vasut > --- > Cc: Mario Six > Cc: Simon Glass > --- > configs/sandbox64_defconfig

Re: [PATCH] Add support for more XMC series

2023-08-13 Thread Simon Glass
On Fri, 11 Aug 2023 at 21:19, SSunk wrote: > > Add XMC XM25QH256C/XM25QU256C/XM25QH512C/XM25QU512C > site: https://www.xmcwh.com/site/product > > Signed-off-by: Kankan Sun > --- > configs/evb-ast2600_defconfig | 1 + > drivers/mtd/spi/spi-nor-ids.c | 4 > 2 files changed, 5 insertions(+)

Re: [PATCH v2 1/1] lmb: description lmb_is_reserved, lmb_is_reserved_flags

2023-08-13 Thread Simon Glass
On Sat, 12 Aug 2023 at 12:23, Heinrich Schuchardt wrote: > > * provide a description for function lmb_is_reserved() > * improve the description of funciton lmb_is_reserved_flags() > > Signed-off-by: Heinrich Schuchardt > --- > v2: > fix lmb_is_reserved description > --- > include/lmb.h

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-13 Thread Tom Rini
On Sat, Aug 12, 2023 at 06:14:45PM -0600, Simon Glass wrote: > Hi Tom, > > On Sat, 12 Aug 2023 at 16:38, Tom Rini wrote: > > > > On Sat, Aug 12, 2023 at 11:03:36AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sat, 12 Aug 2023 at 08:28, Tom Rini wrote: > > > > > > > > On Sat, Aug 12,

[PATCH] docs: fix wrong usage of proftool

2023-08-13 Thread Puhan Zhou
The usage of proftool in docs is incorrect. If proftool is used without '-o' argument, it will show the usage like following $ ./sandbox/tools/proftool -m sandbox/System.map -t trace -f funcgraph dump-ftrace >trace.dat Must provide trace data, System.map file and output file Usage: proftool

[PATCH] usb: gadget: sdp: Option to enable SDP read register command

2023-08-13 Thread Loic Poulain
The SDP read register command can be used to read any memory mapped address of the device (ddr, registers...). It can then be exploited by an attacker to access sensitive data/values, especially when running SDP from SPL, as SPL runs with highest privileges in ARM secure mode. Without read, SDP

Re: [PATCH v2 06/10] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add bootph-all to gadget nodes

2023-08-13 Thread Eugen Hristev
On 8/12/23 05:53, Kever Yang wrote: Hi Eugen, On 2023/8/1 15:28, Eugen Hristev wrote: Add bootph-all to gadget nodes to have the gadget available in SPL. Does this gadget available on both USB2 and USB3? I think only USB2 is enough? Hi Kever, This board has one USB type C that is