[PATCH v2] riscv: enable multi-range memory layout

2023-09-13 Thread Fei Wu
In order to enable PCIe passthrough on qemu riscv, the physical memory range between 3GB and 4GB is reserved. Therefore if guest has 4GB ram, two ranges are created as [2G, 3G) and [4G, 7G), currently u-boot sets ram_top to 4G - 1 if the gd->ram_top is above 4G in board_get_usable_ram_top(), but

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-13 Thread Tony Dinh
Hi Simon, On Wed, Sep 13, 2023 at 8:38 PM Simon Glass wrote: > > Hi Tom, > > On Wed, 13 Sept 2023 at 14:14, Tom Rini wrote: > > > > On Wed, Sep 13, 2023 at 12:56:53PM -0700, Tony Dinh wrote: > > > Hi Tom, > > > > > > On Wed, Sep 13, 2023 at 9:22 AM Tom Rini wrote: > > > > > > > > On Tue, Sep

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-13 Thread Simon Glass
Hi Tom, On Wed, 13 Sept 2023 at 14:14, Tom Rini wrote: > > On Wed, Sep 13, 2023 at 12:56:53PM -0700, Tony Dinh wrote: > > Hi Tom, > > > > On Wed, Sep 13, 2023 at 9:22 AM Tom Rini wrote: > > > > > > On Tue, Sep 12, 2023 at 12:38:00PM -0700, Tony Dinh wrote: > > > > > > > I've been testing the

Re: [PATCH v4 01/13] scmi: refactor the code to hide a channel from devices

2023-09-13 Thread AKASHI Takahiro
Hi Patrice, On Wed, Sep 13, 2023 at 03:31:03PM +0200, Patrice CHOTARD wrote: > On 9/12/23 08:19, AKASHI Takahiro wrote: > > The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel > > reference") added an explicit parameter, channel, but it seems to make > > the code complex. > >

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-13 Thread Tony Dinh
Hi Tom, On Wed, Sep 13, 2023 at 1:13 PM Tom Rini wrote: > > On Wed, Sep 13, 2023 at 12:56:53PM -0700, Tony Dinh wrote: > > Hi Tom, > > > > On Wed, Sep 13, 2023 at 9:22 AM Tom Rini wrote: > > > > > > On Tue, Sep 12, 2023 at 12:38:00PM -0700, Tony Dinh wrote: > > > > > > > I've been testing the

Re: [RFC PATCH 0/5] Allow for removal of DT nodes and properties

2023-09-13 Thread Rob Herring
On Fri, Sep 8, 2023 at 1:06 PM Mark Kettenis wrote: > > > From: Jassi Brar > > Date: Fri, 8 Sep 2023 09:37:12 -0500 > > > > Hi Simon, > > > > On Thu, Sep 7, 2023 at 3:08 PM Simon Glass wrote: > > > On Wed, 6 Sept 2023 at 23:20, Ilias Apalodimas > > > > > > > > > > I beg to differ. Devicetree is

Re: [PATCH v2 3/3] phy: Refactor generic_{setup, shutdown}_phy() to reduce complexity

2023-09-13 Thread Tom Rini
On Thu, Aug 31, 2023 at 11:07:11PM +, Jonas Karlman wrote: > Refactor generic_{setup,shutdown}_phy() to reduce complexity and > indentation. This have no intended functional change. > > Signed-off-by: Jonas Karlman Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v2 2/3] phy: Return success from generic_setup_phy() when phy is not found

2023-09-13 Thread Tom Rini
On Thu, Aug 31, 2023 at 11:07:10PM +, Jonas Karlman wrote: > Restore the old behavior of ehci_setup_phy() and ohci_setup_phy() to > return success when generic_phy_get_by_index() return -ENOENT. > > Fixes: 84e561407a5f ("phy: Add generic_{setup,shutdown}_phy() helpers") > Fixes: 10005004db73

Re: [PATCH v2 1/3] phy: Fix generic_setup_phy() return value on power on failure

2023-09-13 Thread Tom Rini
On Thu, Aug 31, 2023 at 11:07:08PM +, Jonas Karlman wrote: > generic_phy_exit() typically return 0 for a struct phy that has been > initialized with a generic_phy_init() call. > > generic_setup_phy() returns the value from a generic_phy_exit() call > when generic_phy_power_on() fails. This

Re: [PATCH 1/6] phy: Set phy->dev to NULL when generic_phy_get_by_name() fails

2023-09-13 Thread Tom Rini
On Thu, Aug 31, 2023 at 10:16:33PM +, Jonas Karlman wrote: > generic_phy_get_by_name() does not initialize phy->dev to NULL before > returning when dev_read_stringlist_search() fails. This can lead to an > uninitialized or reused struct phy erroneously be report as valid by >

Re: [PATCH v2] net: phy: broadcom: add support for BCM54210E

2023-09-13 Thread Tom Rini
On Sat, Aug 05, 2023 at 04:10:08PM +0200, Marek Vasut wrote: > It's Broadcom PHY simply described as single-port > RGMII 10/100/1000BASE-T PHY. It requires disabling > delay skew and GTXCLK bits. > > BCM54210E support ported from Linux kernel commit > 0fc9ae1076697 ("net: phy: broadcom: add

Re: [PATCH] net: phy: motorcomm: Add support for YT8511 PHY

2023-09-13 Thread Tom Rini
On Sat, Aug 05, 2023 at 12:35:01PM +0200, Nicolas Frattaroli wrote: > The YT8511 ethernet PHYs can be found on e.g. the SOQuartz or > the Quartz64. Add rudimentary support for them. > > Signed-off-by: Nicolas Frattaroli Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP

[PATCH] spi: nxp_fspi: reset the FLSHxCR1 registers

2023-09-13 Thread Han Xu
Reset the FLSHxCR1 registers to default value. ROM may set the register value and it affects the SPI NAND normal functions. Signed-off-by: Han Xu --- drivers/spi/nxp_fspi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/spi/nxp_fspi.c b/drivers/spi/nxp_fspi.c index

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-13 Thread Tom Rini
On Wed, Sep 13, 2023 at 12:56:53PM -0700, Tony Dinh wrote: > Hi Tom, > > On Wed, Sep 13, 2023 at 9:22 AM Tom Rini wrote: > > > > On Tue, Sep 12, 2023 at 12:38:00PM -0700, Tony Dinh wrote: > > > > > I've been testing the boostd for a few Marvell boards and seeing this > > > error on the Thecus

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-13 Thread Tony Dinh
Hi Tom, On Wed, Sep 13, 2023 at 9:22 AM Tom Rini wrote: > > On Tue, Sep 12, 2023 at 12:38:00PM -0700, Tony Dinh wrote: > > > I've been testing the boostd for a few Marvell boards and seeing this > > error on the Thecus N2350 (Marvell Armada 385, dual-core CPU). The > > "bootflow scan scsi"

[PATCH] USB: gadget: atmel: fix transfer of queued requests

2023-09-13 Thread Artur Rojek
In the existing implementation, multiple requests queued up on an endpoint are subject to getting evicted without transmission. For both control and bulk endpoints, their respective logic found in usba_control_irq()/usba_ep_irq() guarantees that TX FIFO is empty before data is sent out, and that

Re: [PATCH v1] CI: allow jobs to be run in merge requests

2023-09-13 Thread Andrejs Cainikovs
On 13/09/2023 15:21, Tom Rini wrote: > > This seems fine but please rebase on top of current -next, thanks. > Thanks for your quick review. Done in V2: https://lore.kernel.org/all/20230913141536.109844-1-andrejs.cainik...@gmail.com/ -- Best regards, Andrejs Cainikovs

Re: [PATCH 1/8] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-09-13 Thread Tom Rini
On Fri, Sep 08, 2023 at 05:29:55PM +0530, Sughosh Ganu wrote: > Add support for specifying the parameters needed for capsule > generation through a config file, instead of passing them through > command-line. Parameters for more than a single capsule file can be > specified, resulting in

Re: [PATCH 0/8] Add some more EFI capsule tooling support

2023-09-13 Thread Tom Rini
On Fri, Sep 08, 2023 at 05:29:54PM +0530, Sughosh Ganu wrote: > Recently, a set of patches were merged in next, which were adding > support for generating capsules as part of the U-Boot build. Mid way > through the review of those patches, it was decided to drop the > patches for generating

Re: [PATCH] am33xx: ignore return value from usb_ether_init()

2023-09-13 Thread Trevor Woerner
On Wed, Sep 13, 2023 at 2:32 PM Tom Rini wrote: > On Wed, Sep 13, 2023 at 08:50:49AM -0400, Trevor Woerner wrote: > > > Can this get added to the next release? I don't see it in -next. > > I was going to pick this up for v2024.01 (i.e. the next branch) > soon'ish. > Awesome, thanks! :-)

Re: [PATCH] am33xx: ignore return value from usb_ether_init()

2023-09-13 Thread Tom Rini
On Wed, Sep 13, 2023 at 08:50:49AM -0400, Trevor Woerner wrote: > Can this get added to the next release? I don't see it in -next. I was going to pick this up for v2024.01 (i.e. the next branch) soon'ish. > > On Thu, Aug 31, 2023 at 6:15 AM Michal Suchánek wrote: > > > Hello, > > > > On Wed,

Re: [PATCH 3/8] binman: capsule: Generate capsules through config file

2023-09-13 Thread Simon Glass
Hi Sughosh, On Mon, 11 Sept 2023 at 08:13, Sughosh Ganu wrote: > > hi Simon, > > On Mon, 11 Sept 2023 at 00:44, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Fri, 8 Sept 2023 at 06:00, Sughosh Ganu wrote: > > > > > > Add support in binman for generating capsules by reading the capsule > >

Re: UEFI update files missing on sandbox?

2023-09-13 Thread Simon Glass
Hi Sughosh, On Sun, 10 Sept 2023 at 13:13, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 10 Sept 2023 at 04:54, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sun, 10 Sept 2023 at 04:10, Simon Glass wrote: > > > > > > Hi Sughosh, > > > > > > I thought that all your patches were merged but

Re: bootstd: CACHE Misaligned operation errors (Marvell Armada 385)

2023-09-13 Thread Tom Rini
On Tue, Sep 12, 2023 at 12:38:00PM -0700, Tony Dinh wrote: > I've been testing the boostd for a few Marvell boards and seeing this > error on the Thecus N2350 (Marvell Armada 385, dual-core CPU). The > "bootflow scan scsi" command triggered the "CACHE: Misaligned > operation at range" error.

Re: [PATCH v2] CI: allow jobs to be run in merge requests

2023-09-13 Thread Tom Rini
On Wed, Sep 13, 2023 at 04:15:36PM +0200, Andrejs Cainikovs wrote: > From: Andrejs Cainikovs > > Out-of-tree users could run an out-of-tree CI with limited coverage, > however it is convenient to be able to run the upstream CI from time > to time. To enable that we would need to change job

Re: [PATCH v3 0/7] Port gen_compile_commands.py from Linux to U-Boot

2023-09-13 Thread Tom Rini
On Wed, Sep 13, 2023 at 03:28:07PM +0200, João Marcos Costa wrote: > Hello, > > Em sáb., 2 de set. de 2023 às 16:53, Joao Marcos Costa > escreveu: > > > Hello U-Boot community, > > > > I'm submitting a patch series that ports the gen_compile_commands.py > > script from the Linux kernel's

[PATCH v2] binman: doc: fix reference tag placement for Logging section

2023-09-13 Thread Massimo Pegorer
Move BinmanLogging reference tag after section "Signing FIT container with private key in an image" and just before section "Logging". Remove meaningless line with incomplete sentence. Fixes: 0f40e23fd22 ("binman: add documentation for binman sign option") Signed-off-by: Massimo Pegorer

[PATCH v2] CI: allow jobs to be run in merge requests

2023-09-13 Thread Andrejs Cainikovs
From: Andrejs Cainikovs Out-of-tree users could run an out-of-tree CI with limited coverage, however it is convenient to be able to run the upstream CI from time to time. To enable that we would need to change job rules to be able to run on any GitLab event. Excerpt from GitLab documentation: >

Re: [PATCHv8 03/15] net/lwip: implement dns cmd

2023-09-13 Thread Maxim Uvarov
On Wed, 13 Sept 2023 at 14:32, Simon Goldschmidt wrote: > > > On 13.09.2023 07:56, Ilias Apalodimas wrote: > > On Fri, Sep 08, 2023 at 07:53:08PM +0600, Maxim Uvarov wrote: > >> U-Boot recently got support for an alternative network stack using LWIP. > >> Replace dns command with the LWIP

Re: [PATCHv8 05/15] net/lwip: implement tftp cmd

2023-09-13 Thread Maxim Uvarov
On Wed, 13 Sept 2023 at 14:38, Simon Goldschmidt wrote: > > > On 13.09.2023 08:15, Ilias Apalodimas wrote: > >> + > >> +/* > >> + * (C) Copyright 2023 Linaro Ltd. > >> + */ > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +#include "tftp_client.h" > >>

Re: [PATCHv8 00/15] net/lwip: add lwip library for the network stack

2023-09-13 Thread Maxim Uvarov
On Wed, 13 Sept 2023 at 19:14, Tom Rini wrote: > On Wed, Sep 13, 2023 at 11:06:13AM +0100, Peter Robinson wrote: > > > >> Then if for development you need to pull he history of lwip, you > can do it with: > > > >> git pull -s subtree lwip master --allow-unrelated-histories > > > >> (but I

Re: [PATCH v4 01/13] scmi: refactor the code to hide a channel from devices

2023-09-13 Thread Patrice CHOTARD
On 9/12/23 08:19, AKASHI Takahiro wrote: > The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel > reference") added an explicit parameter, channel, but it seems to make > the code complex. > > Hiding this parameter will allow for adding a generic (protocol-agnostic) > helper

Re: [PATCH v3 0/7] Port gen_compile_commands.py from Linux to U-Boot

2023-09-13 Thread João Marcos Costa
Hello, Em sáb., 2 de set. de 2023 às 16:53, Joao Marcos Costa escreveu: > Hello U-Boot community, > > I'm submitting a patch series that ports the gen_compile_commands.py > script from the Linux kernel's sources to U-Boot. This script, originally > located in

Re: [PATCH v1] CI: allow jobs to be run in merge requests

2023-09-13 Thread Tom Rini
On Tue, Sep 12, 2023 at 01:00:22PM +0200, Andrejs Cainikovs wrote: > Out-of-tree users could run an out-of-tree CI with limited coverage, > however it is convenient to be able to run the upstream CI from time > to time. To enable that we would need to change job rules to be able > to run on any

Re: PSCI: prefetch abort with Mainline linux (even with rockchip u-boot)

2023-09-13 Thread Tim Lunn
Hi Jagan, On 10/23/22 01:35, Jagan Teki wrote: Hi Kever and Heiko, Rockchip 32-bit SoC, like rv1126 seems to depend on PSCI to bring SMP in linux. With rockchip u-boot and Mainline U-Boot the psci in linux-next triggers the abort. (note that I have added rockchip_smcc and enabled PSCI in

Re: [PATCHv8 00/15] net/lwip: add lwip library for the network stack

2023-09-13 Thread Tom Rini
On Wed, Sep 13, 2023 at 11:06:13AM +0100, Peter Robinson wrote: > > >> Then if for development you need to pull he history of lwip, you can do > > >> it with: > > >> git pull -s subtree lwip master --allow-unrelated-histories > > >> (but I think nobody will need this.) > > >> > > >> New update

Re: [PATCH] am33xx: ignore return value from usb_ether_init()

2023-09-13 Thread Trevor Woerner
Can this get added to the next release? I don't see it in -next. On Thu, Aug 31, 2023 at 6:15 AM Michal Suchánek wrote: > Hello, > > On Wed, Aug 30, 2023 at 10:49:50PM -0400, Trevor Woerner wrote: > > In 2cb43ef1c223 ("usb: ether: Fix error handling in usb_ether_init") the > error > > handling

Re: [PATCH v3 3/3] config: j7200: remove not needed power config

2023-09-13 Thread Nishanth Menon
On 10:09-20230913, Udit Kumar wrote: > For J7200, R5/SPL TI_SCI_POWER_DOMAIN should be > disabled as DM is a separate binary like other > SOC of J7* family. > > Fixes: 02dff65efe70 ("configs: j7200_evm_r5: Add initial support") > > Signed-off-b

Re: [PATCH 1/1] configs: NVMe/USB target boot devices on VisionFive 2

2023-09-13 Thread Leo Liang
On Thu, Sep 07, 2023 at 03:53:36PM +0200, Heinrich Schuchardt wrote: > Make NVMe and USB target boot devices on the StarFive VisionFive 2 board. > The boot devices are sorted by decreasing device speed. > > CONFIG_PCI_INIT_R=y is set via [1]. 'start usb' is added to CONFIG_PREBOOT > by the same

Re: [PATCH 1/1] riscv: set fdtfile on VisionFive 2

2023-09-13 Thread Leo Liang
On Thu, Sep 07, 2023 at 01:21:28PM +0200, Heinrich Schuchardt wrote: > Multiple revisions of the StarFive VisionFive 2 board exist. They can be > identified by reading their EEPROM. > > Linux uses two differently named device-tree files. To load the correct > device-tree we need to set $fdtfile

Re: [PATCH v1] rockchip: include: asm: fix entering download mode rk3066

2023-09-13 Thread Johan Jonker
Hi, Maybe put this Rockchip rk3066 patch on hold, if we can find a better solution. Any insider help is appreciated here. The idea to test BOOT_BROM_DOWNLOAD comes from 30_LPDDR2_300MHz_DD.bin Setting location 0x10080028 only breaks the inner loop. BOOT_BROM_DOWNLOAD flag is not reset. It

Re: [PATCHv8 00/15] net/lwip: add lwip library for the network stack

2023-09-13 Thread Peter Robinson
> >> Then if for development you need to pull he history of lwip, you can do > >> it with: > >> git pull -s subtree lwip master --allow-unrelated-histories > >> (but I think nobody will need this.) > >> > >> New update of the lwip net/lwip/lwip-external dir will be done with: > >> git pull -s

Re: [PATCHv8 00/15] net/lwip: add lwip library for the network stack

2023-09-13 Thread Simon Goldschmidt
On 13.09.2023 09:53, Ilias Apalodimas wrote: Hi Maxim, On Wed, 13 Sept 2023 at 10:32, Maxim Uvarov wrote: On Wed, 13 Sept 2023 at 01:27, Simon Glass wrote: Hi Maxim, On Tue, 12 Sept 2023 at 05:42, Maxim Uvarov wrote: On Fri, 8 Sept 2023 at 19:59, Tom Rini wrote: On Fri, Sep

Re: [PATCHv8 05/15] net/lwip: implement tftp cmd

2023-09-13 Thread Simon Goldschmidt
On 13.09.2023 08:15, Ilias Apalodimas wrote: + +/* + * (C) Copyright 2023 Linaro Ltd. + */ + +#include +#include +#include +#include + +#include "tftp_client.h" +#include "tftp_server.h" +#include + +#include + +#include + +static ulong daddr; +static ulong size; + +static void

Re: [PATCHv8 04/15] net/lwip: implement dhcp cmd

2023-09-13 Thread Simon Goldschmidt
On 13.09.2023 08:07, Ilias Apalodimas wrote: On Fri, Sep 08, 2023 at 07:53:09PM +0600, Maxim Uvarov wrote: + +#include +#include +#include + +#include +#include +#include "lwip/timeouts.h" + +#include +#include + +#define DHCP_WAIT_MS 2000 Is this the time we wait for a dhcp reply?

Re: [PATCHv8 03/15] net/lwip: implement dns cmd

2023-09-13 Thread Simon Goldschmidt
On 13.09.2023 07:56, Ilias Apalodimas wrote: On Fri, Sep 08, 2023 at 07:53:08PM +0600, Maxim Uvarov wrote: U-Boot recently got support for an alternative network stack using LWIP. Replace dns command with the LWIP variant while keeping the output and error messages identical. Signed-off-by:

Re: [PATCHv8 00/15] net/lwip: add lwip library for the network stack

2023-09-13 Thread Ilias Apalodimas
Hi Maxim, On Wed, 13 Sept 2023 at 10:32, Maxim Uvarov wrote: > > > > On Wed, 13 Sept 2023 at 01:27, Simon Glass wrote: >> >> Hi Maxim, >> >> On Tue, 12 Sept 2023 at 05:42, Maxim Uvarov wrote: >> > >> > On Fri, 8 Sept 2023 at 19:59, Tom Rini wrote: >> > >> > > On Fri, Sep 08, 2023 at

Re: [PATCHv8 00/15] net/lwip: add lwip library for the network stack

2023-09-13 Thread Maxim Uvarov
On Wed, 13 Sept 2023 at 01:27, Simon Glass wrote: > Hi Maxim, > > On Tue, 12 Sept 2023 at 05:42, Maxim Uvarov > wrote: > > > > On Fri, 8 Sept 2023 at 19:59, Tom Rini wrote: > > > > > On Fri, Sep 08, 2023 at 07:53:05PM +0600, Maxim Uvarov wrote: > > > > > > > Before apply these patches it is

Re: [PATCHv8 15/15] net/lwip/wget add port selection

2023-09-13 Thread Ilias Apalodimas
Hi Maxi, I'd drop this from the series. It's useful in the long run, but let's just get the minimum functionality in first Thanks /Ilias On Fri, Sep 08, 2023 at 07:53:20PM +0600, Maxim Uvarov wrote: > Allow to specify HTTP port instead of just using default for wget command. > > Signed-off-by:

Re: [PATCHv8 07/15] net/lwip: implement ping cmd

2023-09-13 Thread Ilias Apalodimas
On Fri, Sep 08, 2023 at 07:53:12PM +0600, Maxim Uvarov wrote: > U-Boot recently got support for an alternative network stack using LWIP. > Replace ping command with the LWIP variant while keeping the output and > error messages identical. ping uses lwIP contrib/apps/ping/ping.c code. > Custom

Re: [PATCHv8 06/15] net/lwip: implement wget cmd

2023-09-13 Thread Ilias Apalodimas
> 4 files changed, 128 insertions(+) > create mode 100644 net/lwip/apps/http/Makefile > create mode 100644 net/lwip/apps/http/lwip-wget.c > > diff --git a/include/net/lwip.h b/include/net/lwip.h > index c9e2982a78..85f08343fd 100644 > --- a/include/net/lwip.h > +++ b/include/net/lwip.h > @@

Re: [PATCHv8 05/15] net/lwip: implement tftp cmd

2023-09-13 Thread Ilias Apalodimas
> + > +/* > + * (C) Copyright 2023 Linaro Ltd. > + */ > + > +#include > +#include > +#include > +#include > + > +#include "tftp_client.h" > +#include "tftp_server.h" > +#include > + > +#include > + > +#include > + > +static ulong daddr; > +static ulong size; > + > +static void

Re: [PATCHv8 04/15] net/lwip: implement dhcp cmd

2023-09-13 Thread Ilias Apalodimas
On Fri, Sep 08, 2023 at 07:53:09PM +0600, Maxim Uvarov wrote: > + > +#include > +#include > +#include > + > +#include > +#include > +#include "lwip/timeouts.h" > + > +#include > +#include > + > +#define DHCP_WAIT_MS 2000 Is this the time we wait for a dhcp reply? If so we should bump it to

Re: [PATCH] riscv: enable multi-range memory layout

2023-09-13 Thread Wu, Fei
On 9/13/2023 1:05 PM, Heinrich Schuchardt wrote: > > > Am 13. September 2023 04:23:14 MESZ schrieb "Wu, Fei" : >> On 9/5/2023 6:09 PM, Fei Wu wrote: >>> In order to enable PCIe passthrough on qemu riscv, the physical memory >>> range between 3GB and 4GB is reserved. Therefore if guest has 4GB