Re: [PATCH v2 07/32] bootm: Drop arguments from bootm_start()

2023-11-17 Thread Ilias Apalodimas
On Thu, 16 Nov 2023 at 06:11, Simon Glass wrote: > > This function does not use its arguments. Drop them. > > Signed-off-by: Simon Glass > Reviewed-by: Tom Rini > --- Reviewed-by: Ilias Apalodimas > > (no changes since v1) > > boot/bootm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 dele

Re: [PATCH v2 05/32] bootstd: Add missing header file from bootdev.h

2023-11-17 Thread Ilias Apalodimas
On Thu, 16 Nov 2023 at 06:11, Simon Glass wrote: > > Add a dm/uclass-id.h to the bootdev header file, since it uses > enum uclass_id > > Signed-off-by: Simon Glass Reviewed-by: Ilias Apalodimas > --- > > (no changes since v1) > > include/bootdev.h | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [PATCH v2 04/32] treewide: Tidy up semicolon after command macros

2023-11-17 Thread Ilias Apalodimas
On Thu, 16 Nov 2023 at 06:11, Simon Glass wrote: > > The U_BOOT_CMD_COMPLETE() macro has a semicolon at the end, perhaps > inadvertently. Some code has taken advantage of this. > > Tidy this up by dropping the semicolon from the macro and adding it to > macro invocations as required. > > Signed-of

Re: [PATCH v2 01/32] arm: x86: Drop discarding of command linker-lists

2023-11-17 Thread Ilias Apalodimas
On Thu, 16 Nov 2023 at 06:11, Simon Glass wrote: > > Since we can now cleanly disable CMDLINE when needed, drop the rules > which discard the command code. It will not be built in the first > place. > > Signed-off-by: Simon Glass > Reviewed-by: Tom Rini > --- > > (no changes since v1) > > arch

Re: [PATCH 1/1] cmd: eficonfig: create shortened boot options

2023-11-17 Thread Ilias Apalodimas
Hi Heinrich On Fri, 17 Nov 2023 at 01:08, Heinrich Schuchardt wrote: > > The boot options created by eficonfig should use shortened device-paths to > avoid problems if drives are enumerated in a different sequence. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/eficonfig.c | 1 + > 1 file c

Re: [PATCH v5 2/5] fdt: kaslr seed from RNG device

2023-11-17 Thread Ilias Apalodimas
Hi Sean There are a few reviewed-by tags missing since v3/v4. Any reason you dropped those? The change log doesn't mention anything Thanks /Ilias On Fri, 17 Nov 2023 at 04:02, wrote: > > From: Dhananjay Phadke > > Add support for KASLR seed from the RNG device. Invokes dm_rng_read() > API to r

Re: [PATCH v5 3/3] net: bootp: add config option BOOTP_RANDOM_XID

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 04:48:26PM -0800, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > The new config option BOOTP_RANDOM_XID will randomize the transaction ID > for each new BOOT/DHCPv4 exchange. > > Signed-off-by: Sean Edmond Reviewed-by: Tom Rini -- Tom signature.asc

Re: [PATCH v5 2/3] net: bootp: BOOTP/DHCPv4 retransmission improvements

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 04:48:25PM -0800, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > This patch introduces 3 improvements to align with RFC 951: > - retransmission backoff interval maximum is configurable > - initial retranmission backoff interval is configurable > - transacti

Re: [PATCH v5 1/3] net: Additional fixes for dhcp option 209

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 04:48:24PM -0800, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > Addresses feedback from latest review: > - Enable option 209 by default > - Set pxelinux_configfile to NULL to avoid potential double free > - change hardcoced 209 to a define I was unclear i

[PATCH v5 3/3] net: bootp: add config option BOOTP_RANDOM_XID

2023-11-17 Thread seanedmond
From: Sean Edmond The new config option BOOTP_RANDOM_XID will randomize the transaction ID for each new BOOT/DHCPv4 exchange. Signed-off-by: Sean Edmond --- changes in v5: - fix depends for BOOTP_RANDOM_XID: "depends on CMD_BOOTP && (LIB_RAND || LIB_HW_RAND)" changes in v3: - Add depends fo

[PATCH v5 1/3] net: Additional fixes for dhcp option 209

2023-11-17 Thread seanedmond
From: Sean Edmond Addresses feedback from latest review: - Enable option 209 by default - Set pxelinux_configfile to NULL to avoid potential double free - change hardcoced 209 to a define Signed-off-by: Sean Edmond --- changes in v4: - rebase master and resolve conflicts - change commit descri

[PATCH v5 2/3] net: bootp: BOOTP/DHCPv4 retransmission improvements

2023-11-17 Thread seanedmond
From: Sean Edmond This patch introduces 3 improvements to align with RFC 951: - retransmission backoff interval maximum is configurable - initial retranmission backoff interval is configurable - transaction ID is kept the same for each BOOTP/DHCPv4 request In applications where thousands of node

[PATCH v5 0/3] BOOTP/DHCPv4 enhancements

2023-11-17 Thread seanedmond
From: Sean Edmond In our datacenter application, a single DHCP server is servicing 36000+ clients. Improvements are required to the DHCPv4 retransmission behavior to align with RFC and ensure less pressure is exerted on the server: - retransmission backoff interval maximum is configurable (env

Re: [PATCH v2] usb: dwc3-generic: Use combined glue and ctrl node for RK3588

2023-11-17 Thread Jonas Karlman
Hi Marek, On 2023-11-13 04:11, Marek Vasut wrote: > On 11/12/23 16:25, Jonas Karlman wrote: >> Like Rockchip RK3328 and RK3568, the RK3588 also have a single node to >> represent the glue and ctrl for USB 3.0. >> >> Use rk_ops as driver data to select correct ctrl node for RK3588 DWC3. >> >> Signe

[PATCH v2 4/4] rockchip: rk3588s-orangepi-5: Build SPI image

2023-11-17 Thread Jonas Karlman
Enable building of the SPI image, u-boot-rockchip-spi.bin, now that we know what bootsource id values BootRom use for SPI flash on RK3588. Fixes: 28c5f941edf7 ("board: rockchip: Add Xunlong Orange Pi 5") Signed-off-by: Jonas Karlman --- v2: - No change configs/orangepi-5-rk3588s_defconfig | 1 +

[PATCH v2 0/4] rockchip: rk3588: Fix SPI flash bootsource id values

2023-11-17 Thread Jonas Karlman
The commit fd6e425be243 ("rockchip: rk3588-rock-5b: Enable boot from SPI NOR flash") added a new BROM_BOOTSOURCE_SPINOR_RK3588 with value 6. At the time the reason for this new bootsource id value 6 was unknown. Since then the following bootsource id values have been observed on different RK3588

[PATCH v2 3/4] rockchip: rk3588-orangepi-5-plus: Build SPI image

2023-11-17 Thread Jonas Karlman
From: Slawomir Stepien Enable building of the SPI image, u-boot-rockchip-spi.bin, now that we know what bootsource id values BootRom use for SPI flash on RK3588. Fixes: b51cf8bb09b6 ("board: rockchip: Add Xunlong Orange Pi 5 Plus") Signed-off-by: Slawomir Stepien Signed-off-by: Jonas Karlman -

[PATCH v2 1/4] rockchip: rk3588: Fix boot from SPI flash

2023-11-17 Thread Jonas Karlman
The commit fd6e425be243 ("rockchip: rk3588-rock-5b: Enable boot from SPI NOR flash") added a new BROM_BOOTSOURCE_SPINOR_RK3588 with value 6. At the time the reason for this new bootsource id value 6 was unknown. We now know that the BootRom on RK3588 use different bootsource id values depending o

[PATCH v2 2/4] rockchip: rk3588-nanopc-t6: Build SPI image

2023-11-17 Thread Jonas Karlman
From: John Clark Enable building of the SPI image, u-boot-rockchip-spi.bin, now that we know what bootsource id values BootRom use for SPI flash on RK3588. Fixes: b0b8086898f8 ("board: rockchip: add FriendlyElec NanoPC-T6 rk3588 board") Signed-off-by: John Clark Signed-off-by: Jonas Karlman --

[PATCH 5/5] global: Drop common.h inclusion

2023-11-17 Thread Tom Rini
In order to make it easier to move on to dropping common.h from code directly, remove common.h inclusion from the rest of the header file which had been including it. Signed-off-by: Tom Rini --- board/BuR/common/br_resetc.h | 1 - board/CZ.NIC/turris_mox/mox_sp.h

[PATCH 4/5] sandbox: Audit config.h and common.h usage

2023-11-17 Thread Tom Rini
Remove and replace common.h and config.h in sandbox when it's not needed and add some explicit includes where needed. Signed-off-by: Tom Rini --- arch/sandbox/cpu/cache.c | 1 - arch/sandbox/cpu/cpu.c | 1 - arch/sandbox/cpu/sdl.c | 2 +- arch/sandbox/cpu/spl.c

[PATCH 3/5] arm: Partial cleanup and audit usage of

2023-11-17 Thread Tom Rini
We need to include directly when a file needs to have something such as CFG_SYS_SDRAM_SIZE referenced as this file is not automatically globally included and is most commonly indirectly included via common.h. Remove most cases of arm including config.h directly, but add it where needed. This incl

[PATCH 1/5] qe: Add to linux/immap_qe.h

2023-11-17 Thread Tom Rini
Given how we define QE_MURAM_SIZE today, this header needs to have added to it. Signed-off-by: Tom Rini --- include/linux/immap_qe.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/immap_qe.h b/include/linux/immap_qe.h index 45307f51c103..a692f5dfb373 100644 --- a/include/li

[PATCH 2/5] arc: Cleanup and audit usage of

2023-11-17 Thread Tom Rini
We need to include directly when a file needs to have something such as CFG_SYS_SDRAM_SIZE referenced as this file is not automatically globally included and is most commonly indirectly included via common.h. Remove most cases of arc including config.h directly, but add it where needed. Further c

[PATCH 2/2] doc: Update board_best_practices.rst to talk about dts files

2023-11-17 Thread Tom Rini
We do need to list device tree overlay files in a Makefile, to ensure they are built. However, everything else should be handled via one of the CONFIG options. Signed-off-by: Tom Rini --- doc/develop/board_best_practices.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/develop/boa

[PATCH 1/2] global: Clean up arch/*/dts/Makefile

2023-11-17 Thread Tom Rini
With commit 3609e1dc ("dts: automatically build necessary .dtb files") we now have logic that will ensure that all device trees needed in the binary are built automatically. Any device tree that the developer needs while working can still be built normally via make arch/.../foo.dtb so we can simply

Re: [PATCH 2/3] configs: keystone2: Do not include hardware.h

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 04:38:28PM -0600, Andrew Davis wrote: > This is a hacky way to have this file included in all source files that > include common.h, instead just include from the files that need it. > > Signed-off-by: Andrew Davis > --- > drivers/memory/ti-aemif.c| 1 + > dri

[PATCH 3/3] ARM: keystone2: Remove unneeded inclusions of common.h

2023-11-17 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/mach-keystone/clock.c| 1 - arch/arm/mach-keystone/cmd_clock.c| 2 +- arch/arm/mach-keystone/cmd_mon.c | 1 - arch/arm/mach-keystone/cmd_poweroff.c | 1 - arch/arm/mach-keystone/ddr3.c | 2 +-

[PATCH 2/3] configs: keystone2: Do not include hardware.h

2023-11-17 Thread Andrew Davis
This is a hacky way to have this file included in all source files that include common.h, instead just include from the files that need it. Signed-off-by: Andrew Davis --- drivers/memory/ti-aemif.c| 1 + drivers/soc/ti/keystone_serdes.c | 1 + include/configs/ti_armv7_keystone2.h

[PATCH 1/3] configs: keystone2: Remove unused SPL_MALLOC_F_SIZE and KEYSTONE_SPL_STACK_SIZE

2023-11-17 Thread Andrew Davis
These are leftover definitions. While here cleanup some leftover comments. Signed-off-by: Andrew Davis --- include/configs/ti_armv7_keystone2.h | 22 -- 1 file changed, 22 deletions(-) diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h

Re: [PATCH v4 0/3] [PATCH v4 0/3] [PATCH v3 0/3] BOOTP/DHCPv4 enhancements

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 01:49:22PM -0800, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > In our datacenter application, a single DHCP server is servicing 36000+ > clients. > Improvements are required to the DHCPv4 retransmission behavior to align with > RFC and ensure less pressu

Re: [PATCH v4 3/3] net: bootp: add config option BOOTP_RANDOM_XID

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 01:49:25PM -0800, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > The new config option BOOTP_RANDOM_XID will randomize the transaction ID > for each new BOOT/DHCPv4 exchange. > > Signed-off-by: Sean Edmond > --- > cmd/Kconfig | 7 +++ > net/bootp.c |

[PATCH v4 2/3] net: bootp: BOOTP/DHCPv4 retransmission improvements

2023-11-17 Thread seanedmond
From: Sean Edmond This patch introduces 3 improvements to align with RFC 951: - retransmission backoff interval maximum is configurable - initial retranmission backoff interval is configurable - transaction ID is kept the same for each BOOTP/DHCPv4 request In applications where thousands of node

[PATCH v4 1/3] net: Additional fixes for dhcp option 209

2023-11-17 Thread seanedmond
From: Sean Edmond Addresses feedback from latest review: - Enable option 209 by default - Set pxelinux_configfile to NULL to avoid potential double free - change hardcoced 209 to a define Signed-off-by: Sean Edmond --- cmd/Kconfig | 1 + cmd/pxe.c | 2 ++ net/bootp.c | 4 ++-- net/bootp.h |

[PATCH v4 0/3] [PATCH v4 0/3] [PATCH v3 0/3] BOOTP/DHCPv4 enhancements

2023-11-17 Thread seanedmond
From: Sean Edmond In our datacenter application, a single DHCP server is servicing 36000+ clients. Improvements are required to the DHCPv4 retransmission behavior to align with RFC and ensure less pressure is exerted on the server: - retransmission backoff interval maximum is configurable (env

[PATCH v4 3/3] net: bootp: add config option BOOTP_RANDOM_XID

2023-11-17 Thread seanedmond
From: Sean Edmond The new config option BOOTP_RANDOM_XID will randomize the transaction ID for each new BOOT/DHCPv4 exchange. Signed-off-by: Sean Edmond --- cmd/Kconfig | 7 +++ net/bootp.c | 31 +-- 2 files changed, 24 insertions(+), 14 deletions(-) diff --gi

[PATCH v2 4/4] bootflow: bootmeth_efi: don't free buffer

2023-11-17 Thread Shantur Rathore
bootmeth_efi doesn't allocate any buffer to load efi in any case. enable static buffer flag for all cases. Signed-off-by: Shantur Rathore --- boot/bootmeth_efi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c index 5e67afed88..

[PATCH v2 3/4] bootflow: bootmeth_efi: Handle fdt not available.

2023-11-17 Thread Shantur Rathore
While booting with efi, if fdt isn't available externally, just use the built-in one. Signed-off-by: Shantur Rathore --- boot/bootmeth_efi.c | 10 +- include/bootflow.h | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c index

[PATCH v2 2/4] bootflow: bootmeth_efi: Don't set bootdev again

2023-11-17 Thread Shantur Rathore
efi_set_bootdev is already called as part of tftp while doing dhcp_run() Doing this again crashes U-boot and we don't need to call again. Signed-off-by: Shantur Rathore --- boot/bootmeth_efi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c index 6

[PATCH v2 1/4] bootflow: bootmeth_efi: Set bootp_arch as hex

2023-11-17 Thread Shantur Rathore
bootmeth_efi sets up bootp_arch which is read later in bootp.c Currently bootp_arch is being set as integer string and being read in bootp.c as hex, this sends incorrect arch value to dhcp server which in return sends wrong file for network boot. For ARM64 UEFI Arch value is 0xb (11), here we set

[PATCH v2 0/4] bootflow: bootmeth_efi: Fix network eif boot.

2023-11-17 Thread Shantur Rathore
Currently bootmeth_efi crashes while doing a network (dhcp) boot. This patch series fixes issues and both network and disk boot works. Shantur Rathore (4): bootflow: bootmeth_efi: Set bootp_arch as hex bootflow: bootmeth_efi: Don't set bootdev again bootflow: bootmeth_efi: Handle fdt not ava

[PATCH V2 4/4] doc: board: anbernic: Update rgxx3 to add new boards

2023-11-17 Thread Chris Morgan
From: Chris Morgan Update the RGxx3 documentation to note that it now supports two new non-Anbernic boards. Also update verbiage around panel detection to note that it is no longer hard coded to the RG503. Signed-off-by: Chris Morgan --- doc/board/anbernic/rgxx3.rst | 18 -- 1

[PATCH V2 2/4] board: rockchip: Add Recovery Button for Anbernic RGxx3

2023-11-17 Thread Chris Morgan
From: Chris Morgan Add support for users to enter recovery mode by holding the function button when they power up the device. Since the device has soldered eMMC and sometimes does not expose a clk pin on the mainboard there is a small chance that a user who flashes a bad bootloader may not be ab

[PATCH V2 3/4] board: rockchip: Add support for RGB30 and RK2023 to RGxx3

2023-11-17 Thread Chris Morgan
From: Chris Morgan Add support for the Powkiddy RK2023 and RGB30 to the Anbernic RGxx3. While these devices are manufactured by Powkiddy instead of Anbernic, the hardware is so similar they can all use the same bootloader. Signed-off-by: Chris Morgan Reviewed-by: Kever Yang --- board/anbernic

[PATCH V2 0/4] Add Additional Boards and Features to RGxx3

2023-11-17 Thread Chris Morgan
From: Chris Morgan The RGxx3 is a pseudo-device for U-Boot that works for every Anbernic RGxx3 series device on the market. Add support for another series of very similar devices from Powkiddy. Changes since V1: - Update verbiage around function button to say "recovery" mode instead of calli

[PATCH V2 1/4] board: rockchip: Refactor panel auto-detect code

2023-11-17 Thread Chris Morgan
From: Chris Morgan Make the inability to detect a panel using the auto detection code not fail the entire boot process. This means that if the panel ID cannot be read we don't set an environment variable for the panel, and if an environment variable for the panel is not set we don't attempt to up

Re: [PATCH 1/4] rockchip: rk3588: Fix boot from SPI flash

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 08:53:49PM +0100, Jonas Karlman wrote: > On 2023-11-17 20:07, Tom Rini wrote: > > On Fri, Nov 17, 2023 at 01:50:58PM -0500, John Clark wrote: > >> > >> On 11/17/23 12:50 PM, Tom Rini wrote: > >>> On Fri, Nov 17, 2023 at 03:03:39PM +0100, Slawomir Stepien wrote: > On lis

Re: [PATCH 1/4] rockchip: rk3588: Fix boot from SPI flash

2023-11-17 Thread Jonas Karlman
On 2023-11-17 20:07, Tom Rini wrote: > On Fri, Nov 17, 2023 at 01:50:58PM -0500, John Clark wrote: >> >> On 11/17/23 12:50 PM, Tom Rini wrote: >>> On Fri, Nov 17, 2023 at 03:03:39PM +0100, Slawomir Stepien wrote: On lis 14, 2023 15:06, Quentin Schulz wrote: > Hi Jonas, Hi Quentin

Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

2023-11-17 Thread Tom Rini
On Wed, Nov 15, 2023 at 06:35:23PM -0700, Simon Glass wrote: > EFI applications can be very large and thus used to cause boot failures > when malloc() space was exhausted. > > A recent changed fixed this by using the kernel_addr_r environment var > as the address of the buffer. However, it still

Re: [PATCH] spl: fix TPL_SYS_MALLOC_F description

2023-11-17 Thread Tom Rini
On Tue, Nov 14, 2023 at 11:30:17AM +, John Keeping wrote: > This config option enables the malloc() pool in TPL not the SPL. Fix > the description to accurately reflect this. > > Fixes: fd8497dae54 (spl: Create proper symbols for enabling the malloc() pool) > Signed-off-by: John Keeping > R

Re: [PATCH] virtio: rng: gracefully handle 0 byte returns

2023-11-17 Thread Tom Rini
On Tue, Nov 07, 2023 at 04:09:00PM +, Andre Przywara wrote: > According to the virtio v1.x "entropy device" specification, a virtio-rng > device is supposed to always return at least one byte of entropy. > However the virtio v0.9 spec does not mention such a requirement. > > The Arm Fixed Vir

Re: [PATCH v1 2/2] imx: spl_imx_romapi: fix emmc fast boot mode case

2023-11-17 Thread Tom Rini
On Thu, Oct 26, 2023 at 09:32:20AM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > This fixes a regression in the eMMC fast boot mode case where the buffer > was missing 464 bytes. > > The code figures out how many bytes must at least be fetched to honor > the current read, rounds tha

Re: [PATCH 3/3] Revert "arm64: Use FEAT_HAFDBS to track dirty pages when available"

2023-11-17 Thread Tom Rini
On Fri, Oct 27, 2023 at 01:23:54PM +1300, Chris Packham wrote: > This reverts commit 6cdf6b7a340db4ddd008516181de7e08e3f8c213. This is > part of a series trying to make use of the arm64 hardware features for > tracking dirty pages. Unfortunately this series causes problems for the > AC5/AC5X SoCs.

Re: [PATCH 1/3] Revert "armv8: enable HAFDBS for other ELx when FEAT_HAFDBS is present"

2023-11-17 Thread Tom Rini
On Fri, Oct 27, 2023 at 01:23:52PM +1300, Chris Packham wrote: > This reverts commit c1da6fdb5c239b432440721772d993e63cfdeb20. This is > part of a series trying to make use of the arm64 hardware features for > tracking dirty pages. Unfortunately this series causes problems for the > AC5/AC5X SoCs.

Re: [PATCH 2/3] Revert "arm64: Use level-2 for largest block mappings when FEAT_HAFDBS is present"

2023-11-17 Thread Tom Rini
On Fri, Oct 27, 2023 at 01:23:53PM +1300, Chris Packham wrote: > This reverts commit 836b8d4b205d2175b57cb9ef271e638b0c116e89. This is > part of a series trying to make use of the arm64 hardware features for > tracking dirty pages. Unfortunately this series causes problems for the > AC5/AC5X SoCs.

Re: [PATCH v1 1/2] imx: spl_imx_romapi: fix comment about stream(usb) download failure

2023-11-17 Thread Tom Rini
On Thu, Oct 26, 2023 at 09:32:19AM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Fix comment about Stream(USB) download failure. > > Fixes: 1cbebc786276 ("imx: add rom api support") > Signed-off-by: Marcel Ziswiler > Reviewed-by: Fabio Estevam Applied to u-boot/master, thanks! -

Re: [PATCH 0/3] Revert HAFDBS changes

2023-11-17 Thread Tom Rini
On Fri, Nov 10, 2023 at 06:38:40PM +1300, Chris Packham wrote: > On Fri, 10 Nov 2023, 10:33 am Tom Rini, wrote: > > > On Fri, Oct 27, 2023 at 01:22:37PM -0400, Tom Rini wrote: > > > On Fri, Oct 27, 2023 at 10:49:47AM +0100, Pierre-Clément Tosi wrote: > > > > Hi Chris, > > > > > > > > On Fri, Oct

Re: [PATCH 1/4] rockchip: rk3588: Fix boot from SPI flash

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 01:50:58PM -0500, John Clark wrote: > > On 11/17/23 12:50 PM, Tom Rini wrote: > > On Fri, Nov 17, 2023 at 03:03:39PM +0100, Slawomir Stepien wrote: > > > On lis 14, 2023 15:06, Quentin Schulz wrote: > > > > Hi Jonas, > > > Hi Quentin > > > > > > > On 11/12/23 11:26, Jonas

Re: [PATCH 1/4] rockchip: rk3588: Fix boot from SPI flash

2023-11-17 Thread John Clark
On 11/17/23 12:50 PM, Tom Rini wrote: On Fri, Nov 17, 2023 at 03:03:39PM +0100, Slawomir Stepien wrote: On lis 14, 2023 15:06, Quentin Schulz wrote: Hi Jonas, Hi Quentin On 11/12/23 11:26, Jonas Karlman wrote: The commit fd6e425be243 ("rockchip: rk3588-rock-5b: Enable boot from SPI NOR fl

Re: [PATCH 14/15] board: ti: Add j721e_beagleboneai64_* config fragments and env file

2023-11-17 Thread Andrew Davis
On 11/17/23 8:27 AM, Romain Naour wrote: Hello Andrew, All, Le 03/11/2023 à 20:20, Andrew Davis a écrit : On 11/3/23 2:06 PM, Nishanth Menon wrote: On 13:51-20231103, Andrew Davis wrote: On 11/2/23 7:38 PM, Nishanth Menon wrote: Add defconfig fragments for J721E based BeagleBone AI-64 and co

Re: [PATCH 1/4] rockchip: rk3588: Fix boot from SPI flash

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 03:03:39PM +0100, Slawomir Stepien wrote: > On lis 14, 2023 15:06, Quentin Schulz wrote: > > Hi Jonas, > > Hi Quentin > > > On 11/12/23 11:26, Jonas Karlman wrote: > > > The commit fd6e425be243 ("rockchip: rk3588-rock-5b: Enable boot from SPI > > > NOR flash") added a new

Re: [PATCH v2 06/32] bootstd: Introduce programmable boot

2023-11-17 Thread Tom Rini
On Wed, Nov 15, 2023 at 09:10:06PM -0700, Simon Glass wrote: > At present bootstd requires CONFIG_CMDLINE to operate. Add a new > 'programmable' boot which can be used when no command line is available. > For now it does almost nothing, since most bootmeths require the > command line. > > Signed-

[PATCH 2/2] board: st: common: simplify MTD device parsing

2023-11-17 Thread Patrice Chotard
Simplify the way all MTD devices are parsed. Signed-off-by: Patrice Chotard --- board/st/common/stm32mp_dfu.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/board/st/common/stm32mp_dfu.c b/board/st/common/stm32mp_dfu.c index ded3bf81961..77edb86e78c 100

[PATCH 1/2] board: st: common: Fix board_get_alt_info_mtd()

2023-11-17 Thread Patrice Chotard
Since MTD devices are partioned, we got the following error when command "dfu 0" is executed: DFU alt info setting: done ERROR: Too many arguments for nor0 ERROR: DFU entities configuration failed! ERROR: (partition table does not match dfu_alt_info?) Fixes: 31325e1b8b9c ("stm32mp1: dynamically b

Re: [PATCH 1/4] rockchip: rk3588: Fix boot from SPI flash

2023-11-17 Thread Slawomir Stepien
On lis 14, 2023 15:06, Quentin Schulz wrote: > Hi Jonas, Hi Quentin > On 11/12/23 11:26, Jonas Karlman wrote: > > The commit fd6e425be243 ("rockchip: rk3588-rock-5b: Enable boot from SPI > > NOR flash") added a new BROM_BOOTSOURCE_SPINOR_RK3588 with value 6. > > > > At the time the reason for th

Re: [PATCH v1 2/2] imx: spl_imx_romapi: fix emmc fast boot mode case

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 01:13:07PM -0300, Fabio Estevam wrote: > Hi Tom, > > On Fri, Nov 17, 2023 at 11:25 AM Tom Rini wrote: > > > OK. Fabio, please send me your patchwork username off-list and I'll get > > you added and you can start managing patches there. I've started using > > some of the b

Re: [PATCH v1 2/2] imx: spl_imx_romapi: fix emmc fast boot mode case

2023-11-17 Thread Fabio Estevam
Hi Tom, On Fri, Nov 17, 2023 at 11:25 AM Tom Rini wrote: > OK. Fabio, please send me your patchwork username off-list and I'll get > you added and you can start managing patches there. I've started using > some of the b4 + patchwork integration just recently and it's very nice. In the meantime,

[PATCH] boards: Disable NET on platforms without NETDEVICES

2023-11-17 Thread Tom Rini
None of these platforms enabled a networking devices, and disabled CMD_NET. Given that we used to gate network support on CMD_NET rather than NET, we disable CONFIG_NET on these platforms now. Signed-off-by: Tom Rini --- Cc: Simon Glass Cc: Heinrich Schuchardt Cc: Matthias Winker Cc: Philip Ob

Re: [PATCH 2/4] fwu-mdata: Make FWU_MDATA_GPT_BLK depend on DFU

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 04:35:22PM +0100, Heinrich Schuchardt wrote: > On 8/17/23 19:41, Tom Rini wrote: > > The implementation of this option in lib/fwu_updates/fwu_gpt.c is wholly > > dependent on DFU, so make that a requirement here. > > > > Signed-off-by: Tom Rini > > --- > > I'm honestly not

Re: [PATCH 2/4] fwu-mdata: Make FWU_MDATA_GPT_BLK depend on DFU

2023-11-17 Thread Heinrich Schuchardt
On 8/17/23 19:41, Tom Rini wrote: The implementation of this option in lib/fwu_updates/fwu_gpt.c is wholly dependent on DFU, so make that a requirement here. Signed-off-by: Tom Rini --- I'm honestly not sure how to best proceed here as drivers/fwu-mdata/gpt_blk.c doesn't need DFU, but both file

Re: bootstd: Support for distro specific EFI folders

2023-11-17 Thread Heinrich Schuchardt
On 11/16/23 19:45, Shantur Rathore wrote: On Thu, Nov 16, 2023 at 6:15 PM Heinrich Schuchardt wrote: On 11/16/23 17:52, Shantur Rathore wrote: Hi Simon, Currently bootstd - bootmethod_efi only looks for the default bootxx64.efi in /EFI/boot folder only. Generally many distros end up putting

[PATCH] tqma6: Fix DDR configuration

2023-11-17 Thread Miquel Raynal
Initially investigating a Linux network issue causing a lot of drop and poor network performances on a custom system based on a TQMA6A module (based on an iMX6Q), [1st link below]. I eventually correlated my observations with a contention at the NIC level when in concurrency with the graphics pipe

Re: [PATCH] arm64: imx: imx8mp-beacon: Add support for 4GB Variant

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 08:48:00AM -0600, Adam Ford wrote: > On Fri, Nov 17, 2023 at 8:41 AM Tom Rini wrote: > > > > On Thu, Nov 16, 2023 at 07:31:53PM -0600, Adam Ford wrote: > > > > > A new variant of the i.MX8MP System-on-module from Beacon is > > > available which contains 4GB of RAM vs 6GB.

Re: [PATCH] arm64: imx: imx8mp-beacon: Add support for 4GB Variant

2023-11-17 Thread Adam Ford
On Fri, Nov 17, 2023 at 8:41 AM Tom Rini wrote: > > On Thu, Nov 16, 2023 at 07:31:53PM -0600, Adam Ford wrote: > > > A new variant of the i.MX8MP System-on-module from Beacon is > > available which contains 4GB of RAM vs 6GB. The memory > > timings are slightly different, so a different config is

Re: [PATCH] arm64: imx: imx8mp-beacon: Add support for 4GB Variant

2023-11-17 Thread Tom Rini
On Thu, Nov 16, 2023 at 07:31:53PM -0600, Adam Ford wrote: > A new variant of the i.MX8MP System-on-module from Beacon is > available which contains 4GB of RAM vs 6GB. The memory > timings are slightly different, so a different config is necessary > to build the different timing file. > > Signed

Re: [PATCH 14/15] board: ti: Add j721e_beagleboneai64_* config fragments and env file

2023-11-17 Thread Romain Naour
Hello Andrew, All, Le 03/11/2023 à 20:20, Andrew Davis a écrit : > On 11/3/23 2:06 PM, Nishanth Menon wrote: >> On 13:51-20231103, Andrew Davis wrote: >>> On 11/2/23 7:38 PM, Nishanth Menon wrote: Add defconfig fragments for J721E based BeagleBone AI-64 and corresponding customized envir

Re: [PATCH v1 2/2] imx: spl_imx_romapi: fix emmc fast boot mode case

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 09:17:27AM +0100, Stefano Babic wrote: > Hi Tom, Marcel, > > On 16.11.23 19:42, Tom Rini wrote: > > On Thu, Nov 16, 2023 at 10:57:27AM +, Marcel Ziswiler wrote: > > > Hi Tom > > > > > > On Thu, 2023-11-02 at 08:09 +0100, Marcel Ziswiler wrote: > > > > Hi Stefano > > >

Re: [PATCH RFC 10/10] board: ti: j721e: Enable ESM initialization for J7200

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 02:00:43PM +0530, Neha Malcom Francis wrote: > Hi Tom > > On 17/11/23 00:10, Tom Rini wrote: > > On Thu, Nov 16, 2023 at 11:43:50AM +0530, Neha Malcom Francis wrote: > > > Hi Tom, > > > > > > Trying to bring back this series here. > > > > > > On 03/10/23 20:40, Tom Rini w

Re: [PATCH] arm: Enable SYS_THUMB_BUILD on AT91

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 03:49:57PM +0200, Eugen Hristev wrote: > On 11/17/23 15:46, Tom Rini wrote: > > On Fri, Nov 17, 2023 at 03:45:02PM +0200, Eugen Hristev wrote: > > > On 11/17/23 15:40, Tom Rini wrote: > > > > On Sat, 04 Nov 2023 22:27:42 -0400, Sean Anderson wrote: > > > > > > > > > Several

Re: [PATCH 3/3] treewide: use linux/time.h for time conversion defines

2023-11-17 Thread Tom Rini
On Thu, Nov 09, 2023 at 08:10:04PM +0300, Igor Prusov wrote: > Now that we have time conversion defines from in time.h there is no need > for each driver to define their own version. > > Signed-off-by: Igor Prusov > Reviewed-by: Svyatoslav Ryhel # tegra > Reviewed-by: Eugen Hristev #at91 > Rev

Re: [PATCH] arm: Enable SYS_THUMB_BUILD on AT91

2023-11-17 Thread Eugen Hristev
On 11/17/23 15:46, Tom Rini wrote: On Fri, Nov 17, 2023 at 03:45:02PM +0200, Eugen Hristev wrote: On 11/17/23 15:40, Tom Rini wrote: On Sat, 04 Nov 2023 22:27:42 -0400, Sean Anderson wrote: Several AT91 boards are quite close to their SPL size limit. For example, sama5d27_wlsom1_ek_mmc is jus

Re: [PATCH] arm: Enable SYS_THUMB_BUILD on AT91

2023-11-17 Thread Tom Rini
On Fri, Nov 17, 2023 at 03:45:02PM +0200, Eugen Hristev wrote: > On 11/17/23 15:40, Tom Rini wrote: > > On Sat, 04 Nov 2023 22:27:42 -0400, Sean Anderson wrote: > > > > > Several AT91 boards are quite close to their SPL size limit. For example, > > > sama5d27_wlsom1_ek_mmc is just 173 bytes short

Re: [PATCH] arm: Enable SYS_THUMB_BUILD on AT91

2023-11-17 Thread Eugen Hristev
On 11/17/23 15:40, Tom Rini wrote: On Sat, 04 Nov 2023 22:27:42 -0400, Sean Anderson wrote: Several AT91 boards are quite close to their SPL size limit. For example, sama5d27_wlsom1_ek_mmc is just 173 bytes short of its limit and doesn't even fit with older GCCs. All AT91 processors should hav

Re: [PATCH v2 2/2] cmd: bcb: extend BCB C API to allow read/write the fields

2023-11-17 Thread Tom Rini
On Fri, Nov 10, 2023 at 05:59:55AM +, Dmitrii Merkurev wrote: > Currently BCB C API only allows to modify 'command' BCB field. > Extend it so that we can also read and modify all the available > BCB fields (command, status, recovery, stage). > > Co-developed-by: Cody Schuffelen > Signed-off-

Re: [PATCH v2 1/2] cmd: bcb: support various block device interfaces for BCB command

2023-11-17 Thread Tom Rini
On Fri, Nov 10, 2023 at 05:59:54AM +, Dmitrii Merkurev wrote: > Currently BCB command-line, C APIs and implementation only > support MMC interface. Extend it to allow various block > device interfaces. > > Signed-off-by: Dmitrii Merkurev > Cc: Eugeniu Rosca > Cc: Ying-Chun Liu (PaulLiu) >

Re: [PATCH v1 2/2] poplar: provide more space for kernel image

2023-11-17 Thread Tom Rini
On Thu, Nov 09, 2023 at 11:34:35PM +0100, Igor Opaniuk wrote: > Adjust mem layout, providing more space for linux kernel image. > > This fixes the problem: > ERROR: FDT image overlaps OS image (OS=0x3000..0x3258) > > Signed-off-by: Igor Opaniuk > Reviewed-by: Sam Protsenko Applied to

Re: [PATCH v1 1/2] poplar: use random mac address

2023-11-17 Thread Tom Rini
On Thu, Nov 09, 2023 at 11:34:34PM +0100, Igor Opaniuk wrote: > Set CONFIG_NET_RANDOM_ETHADDR=y, which sets random eth address in > case there is no configuration provided neither in CONFIG_ETHADDR > nor in "ethaddr" env variable. > > This fixes the problem: > poplar# dhcp > Error: ethernet@98410

Re: [PATCH 1/3] linux/time.h: Add Linux time conversion defines

2023-11-17 Thread Tom Rini
On Thu, Nov 09, 2023 at 08:10:02PM +0300, Igor Prusov wrote: > Currently there are no defines for time conversion in time.h, which > leads to drivers declaring those locally or not using defines at all, so > add them from Linux. > > Signed-off-by: Igor Prusov > Reviewed-by: Simon Glass Applied

Re: [PATCH 2/3] spi: meson_spifc_a1: Use define for time interval

2023-11-17 Thread Tom Rini
On Thu, Nov 09, 2023 at 08:10:03PM +0300, Igor Prusov wrote: > Use USEC_PER_MSEC define for timeout to sync code with Linux version. > > Signed-off-by: Igor Prusov Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 1/2] dm: core: Correct reference to DM_SPL in SPL_DM_STATS

2023-11-17 Thread Tom Rini
On Sun, Nov 12, 2023 at 01:03:46PM -0700, Simon Glass wrote: > This does not existing anymore. Update SPL_DM_STATS to use the correct > Kconfig option, which is SPL_DM > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 2/2] blk: Drop reference to DM_SPL

2023-11-17 Thread Tom Rini
On Sun, Nov 12, 2023 at 01:03:47PM -0700, Simon Glass wrote: > The intent here is to only allow SPL_LEGACY_BLK if !SPL_DM - i.e. that > when driver model is enabled in SPL, legacy block cannot be used. > > However this combination is used by about 240 boards, so we cannot > disallow it, at least

Re: [PATCH] fs: btrfs: fix reading when length specified

2023-11-17 Thread Tom Rini
On Sat, Nov 11, 2023 at 08:19:04AM -0700, Sam Edwards wrote: > The btrfs read function limits the read length to ensure that it > and the read offset do not together exceed the size of the file. > However, this size was only being queried if the read length was > passed a value of zero (meaning "w

Re: [PATCH] fs: ext4: Remove unused parameter from ext4_mount

2023-11-17 Thread Tom Rini
On Wed, Nov 08, 2023 at 12:51:09PM -0500, Sean Anderson wrote: > The part_length parameter is not used. Remove it. > > Signed-off-by: Sean Anderson Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] sysreset: Fix unsupported request return values

2023-11-17 Thread Tom Rini
On Wed, Nov 08, 2023 at 08:51:10AM +, Paul Barker wrote: > The description of the sysreset request method in says that > the return value should be -EPROTONOSUPPORT if the requested reset type > is not supported by this device. > > Signed-off-by: Paul Barker > Reviewed-by: Simon Glass App

Re: [PATCH] test: eth: Don't crash if env_get returns NULL

2023-11-17 Thread Tom Rini
On Sat, Oct 28, 2023 at 06:57:27PM -0400, Sean Anderson wrote: > env_get can return NULL if it fails to find the variable. Check its result > before using it. > > Fixes: 6d9764c2a87 ("dm: test: Add a new test case against dm eth codes for > NULL pointer access") > Fixes: df33fd28897 ("test: eth:

Re: [PATCH] bootm: Enable legacy VxWorks booting from FITs

2023-11-17 Thread Tom Rini
On Fri, Oct 27, 2023 at 04:07:40PM -0400, Sean Anderson wrote: > This works without issue, so don't fail. > > Signed-off-by: Sean Anderson Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] powerpc: mpc8xx: Remove usage of common.h

2023-11-17 Thread Tom Rini
On Mon, Nov 06, 2023 at 07:12:04PM +0100, Christophe Leroy wrote: > Remove inclusion of common.h and add relevant > includes when necessary. > > Signed-off-by: Christophe Leroy Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] board: cssi: Remove usage of common.h

2023-11-17 Thread Tom Rini
On Mon, Nov 06, 2023 at 07:12:05PM +0100, Christophe Leroy wrote: > Remove inclusion of common.h and add relevant > includes when necessary. > > Signed-off-by: Christophe Leroy Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] fs/squashfs: enable LZ4 compression support

2023-11-17 Thread Tom Rini
On Mon, Nov 06, 2023 at 11:14:03AM +0100, David Oberhollenzer wrote: > The structure is identical to the existing compressor implementations, > trivially adding lz4 decompression to sqfs_decompress. > > The changes were tested using a sandbox build. An LZ4 compressed > squashfs image was bound as

Re: [PATCH] fs/squashfs: remove unused declarations

2023-11-17 Thread Tom Rini
On Mon, Nov 06, 2023 at 11:03:20AM +0100, David Oberhollenzer wrote: > This patch removes a number of struct and macro declaration that > were found through `git-grep` to be unused. Most of those are > related to compressor options and super block flags. > > For reading a SquashFS image, we do no

  1   2   >