Re: [PATCH v3 09/14] bloblist: Handle alignment with a void entry

2023-12-27 Thread Ilias Apalodimas
On Wed, 27 Dec 2023 at 19:49, Simon Glass wrote: > > Hi Ilias, > > On Wed, Dec 27, 2023 at 9:58 AM Ilias Apalodimas > wrote: > > > > On Mon, 18 Dec 2023 at 20:20, Raymond Mao wrote: > > > > > > From: Simon Glass > > > > > > Rather than setting the alignment using the header size, add an entirel

Re: [PATCH v4 10/12] bloblist: Adjust the bloblist header

2023-12-27 Thread Ilias Apalodimas
Hi Raymond, [...] > > void bloblist_show_list(void) > @@ -463,7 +477,7 @@ void bloblist_reloc(void *to, uint to_size, void *from, > uint from_size) > > memcpy(to, from, from_size); > hdr = to; > - hdr->size = to_size; > + hdr->total_size = to_size; > } > > int blob

[PATCH 2/2] cpu: riscv: set correct SMBIOS processor family value

2023-12-27 Thread Heinrich Schuchardt
The SMBIOS specification requires to set the processor family in the type 4 (Processor Information) table to specific values depending only on the bitness of the system (0x200 for RV32 and 0x201 for RV64). With this patch dmidecode shows Handle 0x0004, DMI type 4, 48 bytes Processor Infor

[PATCH 1/2] smbios: enable setting processor family > 0xff

2023-12-27 Thread Heinrich Schuchardt
Many value of processor type exceed 0xff and have to be stored as u16 value. In the type 4 table set processor_family = 0xfe signaling that field processor_family2 is used and write the actual value into the processor_family2 field. Signed-off-by: Heinrich Schuchardt --- lib/smbios.c | 4 ++-- 1

[PATCH 0/2] smbios: riscv: set correct SMBIOS processor family value

2023-12-27 Thread Heinrich Schuchardt
Many value of processor type exceed 0xff and have to be stored as u16 value. In the type 4 table set processor_family = 0xfe signaling that field processor_family2 is used and write the actual value into the processor_family2 field. The values for RISC-V are: * 0x200 for 32-bit * 0x201 for 64-bit

Re: [PATCH v4 06/12] bloblist: Drop spare value from bloblist record

2023-12-27 Thread Ilias Apalodimas
Hi Raymond, On Wed, 27 Dec 2023 at 23:08, Raymond Mao wrote: > > From: Simon Glass > > Drop spare value from bloblist record header. > > For now it is still present in the header, with an underscore, so that > tests continue to pass. > Looking at it again, this commit makes no sense to me. Why

Re: [PATCH v4 01/12] bloblist: Update the tag numbering

2023-12-27 Thread Ilias Apalodimas
On Wed, 27 Dec 2023 at 23:07, Raymond Mao wrote: > > From: Simon Glass > > Align bloblist tags with the FW handoff spec v0.9. > The most common ones are from 0. > TF related ones are from 0x100. > All non-standard ones from 0xfff000. > > Added new defined tags: > BLOBLISTT_OPTEE_PAGABLE_PART for

Re: [PATCH v4] fdt: Allow the devicetree to come from a bloblist

2023-12-27 Thread Ilias Apalodimas
Hi Tom, [...] > > > > No, but that is just a straw man. The DT is special and U-Boot reports > > where it comes from. > > > > > > > > This has been going back and forth for a while. I've lost count of how > > > many times I repeated the same proposal, but here it goes again. We > > > have OF_BOAR

Re: [PATCH v4] fdt: Allow the devicetree to come from a bloblist

2023-12-27 Thread Ilias Apalodimas
On Wed, 27 Dec 2023 at 19:48, Simon Glass wrote: > > Hi Ilias, > > On Wed, Dec 27, 2023 at 6:44 AM Ilias Apalodimas > wrote: > > > > Hi Tom, > > > > On Tue, 26 Dec 2023 at 14:07, Tom Rini wrote: > > > > > > On Tue, Dec 26, 2023 at 09:46:25AM +, Simon Glass wrote: > > > > > > > Standard passa

[PATCH] cmd: net: nfs: Enable the NFS command by default

2023-12-27 Thread Tejas Bhumkar
Activated the default use of NFS command for booting images via network using the NFS protocol. Signed-off-by: Tejas Bhumkar --- cmd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index df6d71c103..a51b2d532f 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1

[GIT PULL] u-boot-riscv/next

2023-12-27 Thread Leo Liang
Hi Tom, The following changes since commit 4b151562bb8e54160adedbc6a1c0c749c00a2f84: bootmeth: pass size to efi_binary_run() (2023-12-22 10:36:50 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-riscv.git next for you to fetch changes up to 992

Re: I'm looking for the source code of a specific u-boot version.

2023-12-27 Thread Tony Dinh
Hi Mario and Heinrich, On Wed, Dec 27, 2023 at 12:23 PM Mario Marietto wrote: > > Hello. > > I'm trying to boot FreeBSD for arm32 bit as DomU on my ARM Chromebook > SNOW with xen. Basically there are two ways to accomplish this task : > > > 1) to write a patch that allows the FreeBSD kernel to bo

Re: [RFC PATCH 2/2] common: console: Add support of passing the saved console log to the OS

2023-12-27 Thread Mark Kettenis
> From: Bence Cs > Date: Thu, 28 Dec 2023 00:30:12 +0100 > > CONFIG_CONSOLE_RECORD_SAVE option allows for the recorded console log to > be saved to a memory location, along with some metadata. This memory > address is then passed to the booted OS via command line. Hi, Sorry, but I fear the conc

[RFC PATCH 0/2] Passing U-Boot logs to the OS

2023-12-27 Thread Bence Cs
The problem of sending boot logs to the booted OS has not been solved, but it is high time we do it. This proposed patch aims to give a crude solution, utilizing CONFIG_CONSOLE_RECORD to capture the logs and saving them to RAM, along with a struct residing at CONFIG_CONSOLE_RECORD_SAVE_BASE. There

[RFC PATCH 2/2] common: console: Add support of passing the saved console log to the OS

2023-12-27 Thread Bence Cs
CONFIG_CONSOLE_RECORD_SAVE option allows for the recorded console log to be saved to a memory location, along with some metadata. This memory address is then passed to the booted OS via command line. Signed-off-by: Bence Cs --- Notes: Some improvements to consider: * pass CONFIG_CONSOLE_

[RFC PATCH 1/2] Add U_BOOT_VERSION_CODE macro for packing the version number into a single int

2023-12-27 Thread Bence Cs
Signed-off-by: Bence Cs --- include/version.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/version.h b/include/version.h index 5955b21e89..a8753deadf 100644 --- a/include/version.h +++ b/include/version.h @@ -11,4 +11,7 @@ #include "generated/version_autogenerated.h" #endif

[XEN] Re: I'm looking for the source code of a specific u-boot version.

2023-12-27 Thread Heinrich Schuchardt
Am 27. Dezember 2023 19:54:06 MEZ schrieb Mario Marietto : >Hello. > >I'm trying to boot FreeBSD for arm32 bit as DomU on my ARM Chromebook >SNOW with xen. Basically there are two ways to accomplish this task : > > >1) to write a patch that allows the FreeBSD kernel to boot as a zImage >file. T

[PATCH v3 2/2] sunxi: restore modified memory

2023-12-27 Thread Andrey Skvortsov
Current sunxi DRAM initialisation code does several test accesses to the DRAM array to detect aliasing effects and so determine the correct row/column configuration. This changes the DRAM content, which breaks use cases like soft reset and Linux's ramoops mechanism. Fix this problem by saving and

[PATCH v3 1/2] sunxi: reorganize mctl_mem_matches_* functions

2023-12-27 Thread Andrey Skvortsov
mctl_mem_matches and mctl_mem_matches_base identical functions. To avoid code duplication move them to dram_helpers and make mctl_mem_matches use generic mctl_mem_matches_base. Signed-off-by: Andrey Skvortsov --- arch/arm/include/asm/arch-sunxi/dram.h | 1 + arch/arm/mach-sunxi/dram_helpers.c

[PATCH v3 0/2] sunxi: restore modified memory

2023-12-27 Thread Andrey Skvortsov
Changes in v3: - reorder patches - remove casts - change commit message for 'sunxi: restore modified memory' patch Changes in v2: - rename temporary variables - fix types for temporary variables Andrey Skvortsov (2): sunxi: reorganize mctl_mem_matches_* functions sunxi: restore modified

[PATCH v4 12/12] bloblist: Update documentation and header comment

2023-12-27 Thread Raymond Mao
From: Simon Glass Align the documentation with the v0.9 spec. Signed-off-by: Simon Glass Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- doc/develop/bloblist.rst | 4 +++- include/bloblist.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/develop/b

[PATCH v4 11/12] bloblist: Add alignment to bloblist_new()

2023-12-27 Thread Raymond Mao
From: Simon Glass Allow the alignment to be specified when creating a bloblist. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v3 - Keep the flag argument to align to FW handoff spec up to commit 3592349. Change

[PATCH v4 10/12] bloblist: Adjust the bloblist header

2023-12-27 Thread Raymond Mao
From: Simon Glass The v0.9 spec provides for a 24-byte header. Update the implementation to match this. Rename the fields of the bloblist header to align to the spec. Adds an alignment field into the bloblist header. Update the related bloblist APIs and UT testcases. Signed-off-by: Simon Glass

[PATCH v4 09/12] bloblist: Reduce blob-header size

2023-12-27 Thread Raymond Mao
From: Simon Glass The v0.9 spec provides for an 8-byte header for each blob, with fewer fields. The blob data start address should be aligned to the alignment specified by the bloblist header. Update the implementation to match this. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Sign

[PATCH v4 08/12] bloblist: Handle alignment with a void entry

2023-12-27 Thread Raymond Mao
From: Simon Glass Rather than setting the alignment using the header size, add an entirely new entry to cover the gap left by the alignment. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao Reviewed-by: Simon Glass --- common/bloblist.c | 23 +++

[PATCH v4 07/12] bloblist: Checksum the entire bloblist

2023-12-27 Thread Raymond Mao
From: Simon Glass Use a sinple 8-bit checksum for bloblist, as specified by the spec version 0.9. Spec v0.9 specifies that the entire bloblist area is checksummed, including unused portions. Update the code to follow this. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by:

[PATCH v4 06/12] bloblist: Drop spare value from bloblist record

2023-12-27 Thread Raymond Mao
From: Simon Glass Drop spare value from bloblist record header. For now it is still present in the header, with an underscore, so that tests continue to pass. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao --- Changes in v3 - Keep the spare value in the bl

[PATCH v4 05/12] bloblist: Access record hdr_size and tag via a function

2023-12-27 Thread Raymond Mao
From: Simon Glass Convert accesses to tag and hdr_size via function for grouping tag and hdr_size together later. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao --- Changes in v3 - Update commit message. common/bloblist.c | 38 +---

[PATCH v4 04/12] bloblist: Set version to 1

2023-12-27 Thread Raymond Mao
From: Simon Glass The new bloblist for v0.9 has version 1 so update this value. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas Reviewed-by: Simon Glass --- include/bloblist.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v4 03/12] bloblist: Change the magic value

2023-12-27 Thread Raymond Mao
From: Simon Glass This uses a new value with spec v0.9 so change it. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas Reviewed-by: Simon Glass --- Changes in v2 - Update the bloblist magic to align to FW handoff spec v0.9. Chan

[PATCH v4 02/12] bloblist: Adjust API to align in powers of 2

2023-12-27 Thread Raymond Mao
From: Simon Glass The updated bloblist structure stores the alignment as a power-of-two value in its structures. Adjust the API to use this, to avoid needing to calling ilog2(). Update the bloblist alignment from 16 bytes to 8 bytes. Drop a stale comment while we are here. Signed-off-by: Simon G

[PATCH v4 01/12] bloblist: Update the tag numbering

2023-12-27 Thread Raymond Mao
From: Simon Glass Align bloblist tags with the FW handoff spec v0.9. The most common ones are from 0. TF related ones are from 0x100. All non-standard ones from 0xfff000. Added new defined tags: BLOBLISTT_OPTEE_PAGABLE_PART for TF. BLOBLISTT_TPM_EVLOG and BLOBLISTT_TPM_CRB_BASE for TPM. Signed-

[PATCH v4 00/12] Support Firmware Handoff spec via bloblist

2023-12-27 Thread Raymond Mao
Major changes: Update bloblist to align to Firmware Handoff spec v0.9 (up to commit #3592349 of the spec). (https://github.com/FirmwareHandoff/firmware_handoff). Includes: - Align bloblist tags with the FW handoff spec - Add an explicit alignment field in the header - Update bloblist magic and ve

Re: [PATCH v4] fdt: Allow the devicetree to come from a bloblist

2023-12-27 Thread Tom Rini
On Wed, Dec 27, 2023 at 05:48:44PM +, Simon Glass wrote: > Hi Ilias, > > On Wed, Dec 27, 2023 at 6:44 AM Ilias Apalodimas > wrote: > > > > Hi Tom, > > > > On Tue, 26 Dec 2023 at 14:07, Tom Rini wrote: > > > > > > On Tue, Dec 26, 2023 at 09:46:25AM +, Simon Glass wrote: > > > > > > > Stan

I'm looking for the source code of a specific u-boot version.

2023-12-27 Thread Mario Marietto
Hello. I'm trying to boot FreeBSD for arm32 bit as DomU on my ARM Chromebook SNOW with xen. Basically there are two ways to accomplish this task : 1) to write a patch that allows the FreeBSD kernel to boot as a zImage file. This could be accomplished applying this patch to a specific file that's

Re: [PATCH v4] fdt: Allow the devicetree to come from a bloblist

2023-12-27 Thread Tom Rini
On Wed, Dec 27, 2023 at 05:48:42PM +, Simon Glass wrote: > Hi Tom, > > On Tue, Dec 26, 2023 at 12:07 PM Tom Rini wrote: > > > > On Tue, Dec 26, 2023 at 09:46:25AM +, Simon Glass wrote: > > > > > Standard passage provides for a bloblist to be passed from one firmware > > > phase to the nex

Re: [PATCH v2 9/9] mtd: spi-nor-ids: Add Infineon(Cypress) s28hs02gt ID

2023-12-27 Thread Dhruva Gole
Hi! On Dec 22, 2023 at 14:46:06 +0900, tkuw584...@gmail.com wrote: > From: Takahiro Kuwano > > Infineon(Cypress) S28HS02GT is 1.8V, 2Gb (256MB) NOR Flash memory with > Octal interface. It is a dual-die package parts and has same features > with existing S28 series. > > Signed-off-by: Takahiro K

Re: [PATCH v3 06/14] bloblist: Drop spare value from bloblist record

2023-12-27 Thread Raymond Mao
Hi Ilias, On Wed, 27 Dec 2023 at 04:43, Ilias Apalodimas wrote: > Hi Raymond, > > On Mon, 18 Dec 2023 at 20:20, Raymond Mao wrote: > > > > From: Simon Glass > > > > Drop spare value from bloblist record header. > > > > For now it is still present in the header, with an underscore, so that > >

Re: [PATCH v3 09/14] bloblist: Handle alignment with a void entry

2023-12-27 Thread Simon Glass
Hi Ilias, On Wed, Dec 27, 2023 at 9:58 AM Ilias Apalodimas wrote: > > On Mon, 18 Dec 2023 at 20:20, Raymond Mao wrote: > > > > From: Simon Glass > > > > Rather than setting the alignment using the header size, add an entirely > > new entry to cover the gap left by the alignment. > > Hmm, why? D

Re: [PATCH 1/4] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-12-27 Thread Simon Glass
Hi Sughosh, On Mon, Dec 4, 2023 at 7:15 AM Sughosh Ganu wrote: > > hi Simon, > > On Sat, 2 Dec 2023 at 00:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Thu, 30 Nov 2023 at 23:39, Sughosh Ganu wrote: > > > > > > hi Simon, > > > > > > On Thu, 30 Nov 2023 at 08:16, Simon Glass wrote: > >

Re: [PATCH v3 01/14] bloblist: Update the tag numbering

2023-12-27 Thread Simon Glass
Hi Ilias, On Wed, Dec 27, 2023 at 9:48 AM Ilias Apalodimas wrote: > > Hi Raymond, > > On Mon, 18 Dec 2023 at 20:19, Raymond Mao wrote: > > > > From: Simon Glass > > > > Align bloblist tags with the FW handoff spec v0.9. > > The most common ones are from 0. > > TF related ones are from 0x100. >

Re: [PATCH v2 4/5] lib: membuff: fix readline not returning line in case of overflow

2023-12-27 Thread Simon Glass
On Wed, Nov 15, 2023 at 3:39 PM Svyatoslav Ryhel wrote: > > From: Ion Agorria > > If line overflows readline it will not be returned, fix this behavior, > make it optional and documented properly. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel > --- > boot/bootmeth_extlinux.c

Re: Proposal: FIT support for extension boards / overlays

2023-12-27 Thread Simon Glass
Hi Heinrich, On Tue, Dec 12, 2023 at 3:43 PM Heinrich Schuchardt wrote: > > On 12.12.23 15:05, Simon Glass wrote: > > Hi, > > > > The devicetree files for a board can be quite large, perhaps around > > 60KB. To boot on any supported board, many of them need to be > > provided, typically hundreds.

Re: [PATCH 04/13] soc: samsung: Add Exynos USI driver

2023-12-27 Thread Simon Glass
Hi Sam, On Wed, Dec 13, 2023 at 3:16 AM Sam Protsenko wrote: > > USIv2 IP-core is found on modern ARM64 Exynos SoCs (like Exynos850) and > provides selectable serial protocol (one of: UART, SPI, I2C). USIv2 > registers usually reside in the same register map as a particular > underlying protocol

Re: [PATCH v2 3/6] smbios: Use SMBIOS 3.0 to support an address above 4GB

2023-12-27 Thread Simon Glass
Hi Heinrich, On Tue, Dec 26, 2023 at 11:01 AM Heinrich Schuchardt wrote: > > On 10/15/23 04:45, Simon Glass wrote: > > When the SMBIOS table is written to an address above 4GB a 32-bit table > > address is not large enough. > > > > Use an SMBIOS3 table in that case. > > > > Note that we cannot us

Re: [PATCH v4] fdt: Allow the devicetree to come from a bloblist

2023-12-27 Thread Simon Glass
Hi Ilias, On Wed, Dec 27, 2023 at 6:44 AM Ilias Apalodimas wrote: > > Hi Tom, > > On Tue, 26 Dec 2023 at 14:07, Tom Rini wrote: > > > > On Tue, Dec 26, 2023 at 09:46:25AM +, Simon Glass wrote: > > > > > Standard passage provides for a bloblist to be passed from one firmware > > > phase to th

Re: [PATCH v4] fdt: Allow the devicetree to come from a bloblist

2023-12-27 Thread Simon Glass
Hi Tom, On Tue, Dec 26, 2023 at 12:07 PM Tom Rini wrote: > > On Tue, Dec 26, 2023 at 09:46:25AM +, Simon Glass wrote: > > > Standard passage provides for a bloblist to be passed from one firmware > > phase to the next. That can be used to pass the devicetree along as well. > > Add an option t

[PATCH] mtd: spi-nor: ids: Add is25lx512 chip

2023-12-27 Thread Tejas Bhumkar
Added support for the ISSI OSPI flash part IS25LX512M. Initial testing was performed on the Tenzing-se1 board using SDR mode, covering basic erase, write, and readback operations. Signed-off-by: Tejas Bhumkar --- drivers/mtd/spi/spi-nor-ids.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

Re: [PATCH v3 2/9] bloblist: check bloblist with specified buffer size

2023-12-27 Thread Raymond Mao
Hi Simon, On Tue, 26 Dec 2023 at 04:47, Simon Glass wrote: > Hi Raymond, > > On Fri, Dec 22, 2023 at 9:31 PM Raymond Mao > wrote: > > > > Instead of expecting the bloblist total size to be the same as the > > pre-allocated buffer size, practically we are more interested in > > whether the pre-a

Re: [PATCH v3 6/9] qemu-arm: Get bloblist from boot arguments

2023-12-27 Thread Raymond Mao
Hi Simon, On Tue, 26 Dec 2023 at 04:48, Simon Glass wrote: > Hi Raymond, > > On Fri, Dec 22, 2023 at 9:32 PM Raymond Mao > wrote: > > > > Add platform custom function to get bloblist from boot arguments. > > Check whether boot arguments aligns with the register conventions > > defined in FW Han

Re: [PATCH v3 8/9] fdt: update the document and Kconfig description

2023-12-27 Thread Raymond Mao
Hi Simon, On Tue, 26 Dec 2023 at 04:48, Simon Glass wrote: > Hi Raymond, > > On Fri, Dec 22, 2023 at 9:32 PM Raymond Mao > wrote: > > > > Update the document and Kconfig to describe the behavior of board > > specific custom functions when CONFIG_OF_BOARD is defined. > > > > Signed-off-by: Raymo

Re: [PATCH v3 1/9] bloblist: add API to check the register conventions

2023-12-27 Thread Raymond Mao
Hi Simon, On Tue, 26 Dec 2023 at 04:48, Simon Glass wrote: > Hi Raymond, > > On Fri, Dec 22, 2023 at 9:31 PM Raymond Mao > wrote: > > > > Add bloblist_check_reg_conv() to check whether the bloblist is compliant > > to the register conventions defined in Firmware Handoff specification. > > This

Re: [PATCH v3 4/9] arm: armv7: save boot arguments

2023-12-27 Thread Raymond Mao
Hi Simon, On Tue, 26 Dec 2023 at 04:48, Simon Glass wrote: > Hi Raymond, > > On Fri, Dec 22, 2023 at 9:31 PM Raymond Mao > wrote: > > > > Save boot arguments r[0-3] into an array for handover of bloblist from > > previous boot stage. > > > > Signed-off-by: Raymond Mao > > --- > > Changes in v2

Re: [PATCH v3 4/9] arm: armv7: save boot arguments

2023-12-27 Thread Raymond Mao
Hi Ilias and Simon, On Wed, 27 Dec 2023 at 03:30, Ilias Apalodimas wrote: > Hi Raymond, > > On Fri, 22 Dec 2023 at 23:31, Raymond Mao wrote: > > > > Save boot arguments r[0-3] into an array for handover of bloblist from > > previous boot stage. > > > > Signed-off-by: Raymond Mao > > --- > > Ch

Re: [PATCH v3 3/9] bloblist: refactor of bloblist_reloc()

2023-12-27 Thread Raymond Mao
Hi Ilias, On Wed, 27 Dec 2023 at 03:33, Ilias Apalodimas wrote: > Hi Raymond > > On Fri, 22 Dec 2023 at 23:31, Raymond Mao wrote: > > > > The current bloblist pointer and size can be retrieved from global > > data, so we don't need to pass them from the function arguments. > > This change also

Re: [PATCH v3 9/9] qemu-arm: get FDT from bloblist

2023-12-27 Thread Raymond Mao
Hi Ilias and Simon, On Wed, 27 Dec 2023 at 04:32, Ilias Apalodimas wrote: > On Tue, 26 Dec 2023 at 11:48, Simon Glass wrote: > > > > Hi, > > > > On Fri, Dec 22, 2023 at 9:32 PM Raymond Mao > wrote: > > > > > > Get devicetree from a bloblist if it exists. > > > If not, fallback to get FDT from

Re: [PATCH v3 06/14] bloblist: Drop spare value from bloblist record

2023-12-27 Thread Raymond Mao
Hi Ilias, On Wed, 27 Dec 2023 at 04:43, Ilias Apalodimas wrote: > Hi Raymond, > > On Mon, 18 Dec 2023 at 20:20, Raymond Mao wrote: > > > > From: Simon Glass > > > > Drop spare value from bloblist record header. > > > > For now it is still present in the header, with an underscore, so that > >

Re: [PATCH v3 11/14] bloblist: Adjust the bloblist header

2023-12-27 Thread Ilias Apalodimas
On Wed, 27 Dec 2023 at 17:09, Raymond Mao wrote: > > Hi Ilias, > > On Wed, 27 Dec 2023 at 09:58, Ilias Apalodimas > wrote: >> >> On Wed, 27 Dec 2023 at 16:50, Raymond Mao wrote: >> > >> > Hi Ilias, >> > >> > On Wed, 27 Dec 2023 at 05:17, Ilias Apalodimas >> > wrote: >> >> >> >> >> >> [...] >>

Re: [PATCH v3 01/14] bloblist: Update the tag numbering

2023-12-27 Thread Raymond Mao
Hi Ilias, On Wed, 27 Dec 2023 at 04:48, Ilias Apalodimas wrote: > Hi Raymond, > > On Mon, 18 Dec 2023 at 20:19, Raymond Mao wrote: > > > > From: Simon Glass > > > > Align bloblist tags with the FW handoff spec v0.9. > > The most common ones are from 0. > > TF related ones are from 0x100. > > A

Re: [PATCH v3 02/14] bloblist: Adjust API to align in powers of 2

2023-12-27 Thread Raymond Mao
Hi Ilias, On Wed, 27 Dec 2023 at 04:53, Ilias Apalodimas wrote: > Hi, > > On Mon, 18 Dec 2023 at 20:19, Raymond Mao wrote: > > > > From: Simon Glass > > > > The updated bloblist structure stores the alignment as a power-of-two > > value in its structures. Adjust the API to use this, to avoid n

Re: [PATCH v3 08/14] bloblist: Checksum the entire bloblist

2023-12-27 Thread Raymond Mao
Hi Ilias, On Wed, 27 Dec 2023 at 04:57, Ilias Apalodimas wrote: > Hi Raymond, > > On Mon, 18 Dec 2023 at 20:20, Raymond Mao wrote: > > > > From: Simon Glass > > > > Spec v0.9 specifies that the entire bloblist area is checksummed, > > including unused portions. Update the code to follow this.

Re: [PATCH v2 2/2] efi_loader: support fmp versioning for multi bank update

2023-12-27 Thread Ilias Apalodimas
Kojima-san On Thu, Dec 21, 2023 at 06:52:58PM +0900, Masahisa Kojima wrote: > This commit stores the firmware version into the array > of fmp_state structure to support the fmp versioning > for multi bank update. The index of the array is identified > by the bank index. Why do we all of them? Can

Re: [PATCH v3 12/14] bloblist: Add alignment to bloblist_new()

2023-12-27 Thread Raymond Mao
Hi Ilias, On Wed, 27 Dec 2023 at 05:10, Ilias Apalodimas wrote: > On Mon, 18 Dec 2023 at 20:20, Raymond Mao wrote: > > > > From: Simon Glass > > > > Allow the alignment to be specified when creating a bloblist. > > > > Signed-off-by: Simon Glass > > Co-developed-by: Raymond Mao > > Signed-of

Re: [PATCH v3 11/14] bloblist: Adjust the bloblist header

2023-12-27 Thread Raymond Mao
Hi Ilias, On Wed, 27 Dec 2023 at 09:58, Ilias Apalodimas wrote: > On Wed, 27 Dec 2023 at 16:50, Raymond Mao wrote: > > > > Hi Ilias, > > > > On Wed, 27 Dec 2023 at 05:17, Ilias Apalodimas < > ilias.apalodi...@linaro.org> wrote: > >> > >> > >> [...] > >> > >> > - * @chksum: checksum for the enti

Re: [PATCH v3 09/14] bloblist: Handle alignment with a void entry

2023-12-27 Thread Raymond Mao
Hi Ilias, On Wed, 27 Dec 2023 at 04:58, Ilias Apalodimas wrote: > On Mon, 18 Dec 2023 at 20:20, Raymond Mao wrote: > > > > From: Simon Glass > > > > Rather than setting the alignment using the header size, add an entirely > > new entry to cover the gap left by the alignment. > > Hmm, why? Does

Re: [PATCH v3 11/14] bloblist: Adjust the bloblist header

2023-12-27 Thread Ilias Apalodimas
On Wed, 27 Dec 2023 at 16:50, Raymond Mao wrote: > > Hi Ilias, > > On Wed, 27 Dec 2023 at 05:17, Ilias Apalodimas > wrote: >> >> >> [...] >> >> > - * @chksum: checksum for the entire bloblist allocated area. Since any of >> > the >> > - * blobs can be altered after being created, this checksu

Re: [PATCH v3 11/14] bloblist: Adjust the bloblist header

2023-12-27 Thread Raymond Mao
Hi Ilias, On Wed, 27 Dec 2023 at 05:17, Ilias Apalodimas wrote: > > [...] > > > - * @chksum: checksum for the entire bloblist allocated area. Since any > of the > > - * blobs can be altered after being created, this checksum is only > valid > > - * when the bloblist is finalised before jumpi

Re: [PATCH v2 1/2] fwu: fix fwu_get_image_index interface

2023-12-27 Thread Ilias Apalodimas
On Thu, 21 Dec 2023 at 11:54, Masahisa Kojima wrote: > > The capsule update uses the DFU framework for updating > storage. fwu_get_image_index() currently returns the > image_index calculated by (dfu_alt_num + 1), but this is > different from the image_index in UEFI terminology. > > Since capsule

Re: [PATCH 5/5] test: unit test for smbios command

2023-12-27 Thread Ilias Apalodimas
On Sat, Dec 23, 2023 at 01:44:29AM +0100, Heinrich Schuchardt wrote: > Provide a unit test for the smbios command. > > Provide different test functions for QEMU, sandbox, and other systems. > > Signed-off-by: Heinrich Schuchardt > --- > test/py/tests/test_smbios.py | 47 ++

Re: [PATCH 2/5] smbios: type2: contained object handles

2023-12-27 Thread Ilias Apalodimas
On Sat, Dec 23, 2023 at 01:44:26AM +0100, Heinrich Schuchardt wrote: > The type 2 structure must include information about the contained objects. > It is fine to set the number of contained object handles to 0. > > Add the missing field. > > Fixes: 721e992a8af5 ("x86: Add SMBIOS table support") > S

Re: Adding EFI runtime support to the Arm's FF-A bus

2023-12-27 Thread Ilias Apalodimas
[...] > > > > > > I know. Last time I checked CentOS (or was it Ubuntu?) tried to > > > > > > set EFI variables and the installer just failed. Might be fixed now, > > > > > > though. > > > > > > > > > > It's not. The error message is less scary in distros nowadays, but > > > > > setting the vari

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-27 Thread Tom Rini
On Wed, Dec 27, 2023 at 07:56:26AM +, Simon Glass wrote: > Hi Sumit, > > On Tue, Dec 26, 2023 at 10:06 AM Sumit Garg wrote: > > > > Hi Simon, > > > > On Tue, 26 Dec 2023 at 15:17, Simon Glass wrote: > > > > > > Hi Sumit, > > > > > > On Fri, Dec 22, 2023 at 5:34 AM Sumit Garg wrote: > > > >

Re: [PATCH] include: env: ti: default_findfdt: Follow the bootstd/distro conventions

2023-12-27 Thread Nishanth Menon
On 07:08-20231227, Nishanth Menon wrote: > Distroboot and bootstd both mandate a findfdt variable pointing to the > correct device tree blob. Current mechanism calls a find_fdt function > to set this variable. We do not need a find_fdt command to set the > environment variable to

Re: [PATCH 00/26] sync am65x device tree with Linux v6.7-rc1

2023-12-27 Thread Tom Rini
On Wed, Dec 27, 2023 at 06:39:28AM -0600, Nishanth Menon wrote: > On 15:00-20231221, Tom Rini wrote: > > On Thu, Dec 21, 2023 at 11:43:46AM -0600, Bryan Brattlof wrote: > > > > > Hello Everyone! > > > > > > This series gets the am65x booting again along with syncing the device > > > tree files wi

Re: [PATCH 0/9] dts: Move to SoC-specific build rules

2023-12-27 Thread Tom Rini
On Wed, Dec 27, 2023 at 08:23:56AM +, Simon Glass wrote: > U-Boot builds devicetree binaries from its source tree. As part of the > Kconfig conversion, the Makefiles were updated to align with how this > is done in Linux: a single target for each SoC is used to build all the > .dtb files for t

Re: [PATCH 1/9] microblaze: dts: Use the normal build rule

2023-12-27 Thread Tom Rini
On Wed, Dec 27, 2023 at 08:23:57AM +, Simon Glass wrote: > Build devicetree files using the normal SoC-generic rule. For > microblaze there is actually only one SoC and one board. > > Signed-off-by: Simon Glass > --- > > arch/microblaze/dts/Makefile | 2 +- > 1 file changed, 1 insertion(+),

[PATCH] include: env: ti: default_findfdt: Follow the bootstd/distro conventions

2023-12-27 Thread Nishanth Menon
Distroboot and bootstd both mandate a findfdt variable pointing to the correct device tree blob. Current mechanism calls a find_fdt function to set this variable. We do not need a find_fdt command to set the environment variable to a single dtb. Simplify the default_findfdt to remove variable expan

Re: [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally

2023-12-27 Thread Nishanth Menon
On 16:06-20231221, Tom Rini wrote: > On Mon, Dec 11, 2023 at 04:12:09PM +0530, Siddharth Vadapalli wrote: > > > From: Manorit Chawdhry > > > > The main_cpsw0_qsgmii_phyinit command is defined only for certain TI > > SoCs which have the do_main_cpsw0_qsgmii_phyinit variable set. > > > > Add a ch

Re: [PATCH 00/26] sync am65x device tree with Linux v6.7-rc1

2023-12-27 Thread Nishanth Menon
On 15:00-20231221, Tom Rini wrote: > On Thu, Dec 21, 2023 at 11:43:46AM -0600, Bryan Brattlof wrote: > > > Hello Everyone! > > > > This series gets the am65x booting again along with syncing the device > > tree files with v6.7-rc1 Linux. > > > > The bulk of these patches unify the WKUP SPL board

Re: [PATCH 16/26] arm: dts: k3-am654: remove duplicate sdhci1 pinmux node

2023-12-27 Thread Nishanth Menon
On 11:44-20231221, Bryan Brattlof wrote: > With the Linux and U-Boot board dtb files unified, we now have a > duplicate sdhci1 pinmux node. Remove it > > Signed-off-by: Bryan Brattlof > --- > arch/arm/dts/k3-am654-r5-base-board.dts | 22 +++--- > 1 file changed, 7 insertions(+),

Re: [PATCH 15/26] arm: dts: k3-am654: remove duplicate sdhci0 pinmux node

2023-12-27 Thread Nishanth Menon
On 11:44-20231221, Bryan Brattlof wrote: > With the Linux and U-Boot board dtb files unified, we now have > a duplicate sdhci0 pinmux node. Remove it > > Signed-off-by: Bryan Brattlof > --- > arch/arm/dts/k3-am654-r5-base-board.dts | 25 +++-- > 1 file changed, 7 insertions(+

Re: [PATCH 26/26] arm: dts: k3-am654: convert bootph-pre-ram to bootph-all

2023-12-27 Thread Nishanth Menon
On 11:44-20231221, Bryan Brattlof wrote: [..] > diff --git a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi > b/arch/arm/dts/k3-am654-base-board-u-boot.dtsi > index a9b2d0d2a3036..770c7d129339f 100644 > --- a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi > +++ b/arch/arm/dts/k3-am654-base-board-u-boo

Re: [PATCH 12/26] arm: dts: k3-am654: add needed regs to udmap nodes

2023-12-27 Thread Nishanth Menon
On 11:43-20231221, Bryan Brattlof wrote: > Ethernet is one of a few IPs in U-Boot that depend on DMA to operate. > However there are a few missing registers ranges in the udmap nodes > need to properly setup DMA for the am65x. > > A fix has been added to the Linux kernel[0] to add these ranges how

[PATCH v1] arm: dts: rockchip: rk3288: move to 64 bit reg size

2023-12-27 Thread Johan Jonker
To make automatic Rockchip DT syncing possible from Linux to U-boot prepare rk3288.dtsi by moving to 64 bit reg size. Signed-off-by: Johan Jonker --- arch/arm/dts/rk3288-evb.dtsi | 2 +- arch/arm/dts/rk3288-firefly.dtsi | 2 +- arch/arm/dts/rk3288-miqi.dtsi| 2 +- arch/

Re: [PATCH v4 0/7] smbios: Deal with tables beyond 4GB

2023-12-27 Thread Ilias Apalodimas
Hi Simon, Thanks this looks good On Wed, 27 Dec 2023 at 09:40, Simon Glass wrote: > > When the malloc() region extends beyond 4GB on ARM we may end up with > an SMBIOS table in that region. > > Add support for writing an SMBIOS3 table, which supports a 64-bit > address. > > Note that this proble

Re: [PATCH v4 6/7] efi: Use the correct GUID for the SMBIOS table

2023-12-27 Thread Ilias Apalodimas
On Wed, 27 Dec 2023 at 09:40, Simon Glass wrote: > > EFI does not use the 'anchor string' to determine the SMBIOS table > version, instead preferring to have two separate GUIDs. Use the correct > one, depending on the table version. > > Call unmap_system() to balance to the use of map_sysmem() > >

Re: [PATCH v4 7/7] smbios: Require the caller to align the SMBIOS table

2023-12-27 Thread Ilias Apalodimas
Hi Simon, I commented on v3 as well, but in case you miss that On Wed, 27 Dec 2023 at 09:40, Simon Glass wrote: > > All callers handle this alignment, so drop the unnecessary code. This > simplifies things a little. > > Signed-off-by: Simon Glass > Reviewed-by: Heinrich Schuchardt > --- > > (n

Re: [PATCH v4 5/7] smbios: Correct gd_smbios_start()

2023-12-27 Thread Ilias Apalodimas
On Wed, 27 Dec 2023 at 09:40, Simon Glass wrote: > > This should access arch-specific properties. Fix it and update the > existing usage. > > Signed-off-by: Simon Glass > Reviewed-by: Heinrich Schuchardt > --- > > (no changes since v2) > > Changes in v2: > - Add a new patch to correct gd_smbios_

Re: [PATCH v4 4/7] smbios: Use SMBIOS 3.0 to support an address above 4GB

2023-12-27 Thread Ilias Apalodimas
Hi Simon, On Wed, 27 Dec 2023 at 09:40, Simon Glass wrote: > > When the SMBIOS table is written to an address above 4GB a 32-bit table > address is not large enough. > > Use an SMBIOS3 table in that case. Maybe I missed this on the previous revisions, but is there a reason we don't always use SM

Re: [PATCH v4 2/7] smbios: Move the rest of the SMBIOS2 code

2023-12-27 Thread Ilias Apalodimas
On Wed, 27 Dec 2023 at 09:40, Simon Glass wrote: > > Move all of this logic into the else clause, since it will not be used > for SMBIOS3 > > Signed-off-by: Simon Glass > Reviewed-by: Heinrich Schuchardt > --- > > (no changes since v1) > > lib/smbios.c | 15 +++ > 1 file changed, 7

Re: [PATCH v4 1/7] smbios: Refactor 32-bit code into an else statement

2023-12-27 Thread Ilias Apalodimas
On Wed, 27 Dec 2023 at 09:40, Simon Glass wrote: > > In preparation for adding support for SMBIOS3 move this code into an > else statement. There is no functional change. > > Signed-off-by: Simon Glass > Reviewed-by: Heinrich Schuchardt > --- > > (no changes since v1) > > lib/smbios.c | 38

Re: [PATCH v4 3/7] smbios: SMBIOS 3.0 (64-bit) Entry Point structure

2023-12-27 Thread Ilias Apalodimas
On Wed, 27 Dec 2023 at 09:40, Simon Glass wrote: > > From: Heinrich Schuchardt > > Add definition of the SMBIOS 3.0 (64-bit) Entry Point structure. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass > > Signed-off-by: Simon Glass > --- > > Changes in v4: > - Bring in this patch

Re: [PATCH v2 1/6] smbios: Refactor 32-bit code into an else statement

2023-12-27 Thread Ilias Apalodimas
On Tue, 26 Dec 2023 at 12:46, Heinrich Schuchardt wrote: > > On 10/15/23 04:45, Simon Glass wrote: > > In preparation for adding support for SMBIOS3 move this code into an > > else statement. There is no functional change. > > > > Signed-off-by: Simon Glass > > Reviewed-by: Heinrich Schuchardt

Re: [PATCH v2 1/2] smbios: SMBIOS 3.0 (64-bit) Entry Point structure

2023-12-27 Thread Ilias Apalodimas
On Sat, 23 Dec 2023 at 03:09, Heinrich Schuchardt wrote: > > From: Heinrich Schuchardt > > Add definition of the SMBIOS 3.0 (64-bit) Entry Point structure. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > no change > --- > include/smbios.h | 26 ++ > 1 file c

Re: [PATCH v2 6/6] smbios: Require the caller to align the SMBIOS table

2023-12-27 Thread Ilias Apalodimas
On Tue, 26 Dec 2023 at 14:46, Heinrich Schuchardt wrote: > > On 10/15/23 04:45, Simon Glass wrote: > > All callers handle this alignment, so drop the unnecessary code. This > > simplifies things a little. > > > > Signed-off-by: Simon Glass > > Reviewed: Heinrich Schuchardt > > > --- > > > > (no

Re: [PATCH 1/1] smbios: type2: contained object handles

2023-12-27 Thread Ilias Apalodimas
On Fri, 22 Dec 2023 at 22:16, Heinrich Schuchardt wrote: > > The type 2 structure must include information about the contained objects. > It is fine to set the number of contained object handles to 0. > > Add the missing field. > > Fixes: 721e992a8af5 ("x86: Add SMBIOS table support") > Signed-off

Re: [RFC PATCH 12/16] arm: dts: k3-am65x-binman: Add ICSSG2 overlay and configuration

2023-12-27 Thread MD Danish Anwar
On 20/12/23 4:10 pm, Roger Quadros wrote: > > > On 19/12/2023 12:34, MD Danish Anwar wrote: >> Add ICSSG2 overlay and configuration to tispl and u-boot images. >> >> Signed-off-by: MD Danish Anwar >> --- >> arch/arm/dts/k3-am65x-binman.dtsi | 85 +++ >> 1 file change

Re: [PATCH 4/5] doc: man-page for smbios command

2023-12-27 Thread Ilias Apalodimas
On Sat, 23 Dec 2023 at 02:57, Heinrich Schuchardt wrote: > > Provide a man-page for the smbios command. > > Signed-off-by: Heinrich Schuchardt > --- > doc/usage/cmd/smbios.rst | 93 > doc/usage/index.rst | 1 + > 2 files changed, 94 insertions(+) >

Re: [PATCH v3 11/14] bloblist: Adjust the bloblist header

2023-12-27 Thread Ilias Apalodimas
[...] > - * @chksum: checksum for the entire bloblist allocated area. Since any of the > - * blobs can be altered after being created, this checksum is only valid > - * when the bloblist is finalised before jumping to the next stage of boot. > - * This is the value needed to make all check

Re: [PATCH v3 12/14] bloblist: Add alignment to bloblist_new()

2023-12-27 Thread Ilias Apalodimas
On Mon, 18 Dec 2023 at 20:20, Raymond Mao wrote: > > From: Simon Glass > > Allow the alignment to be specified when creating a bloblist. > > Signed-off-by: Simon Glass > Co-developed-by: Raymond Mao > Signed-off-by: Raymond Mao > --- > Changes in v3 > - Keep the flag argument to align to FW ha

  1   2   >