Re: [PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-20 Thread Jonas Karlman
Hi Simon, On 2024-06-21 01:06, Simon Glass wrote: > The code here is confusing due to large blocks which are #ifdefed out. > Add a function phase_sdram_init() which returns whether SDRAM init > should happen in the current phase, using that as needed to control the > code flow. > > This increases

Re: [PATCH v3 07/18] binman: Keep the efi_capsule input file

2024-06-20 Thread Sughosh Ganu
On Fri, 21 Jun 2024 at 04:36, Simon Glass wrote: > > There is no need to remove input files. It makes it harder to diagnose > failures. Keep the payload file. > > There is no test for this condition, but one could be added. > > Signed-off-by: Simon Glass > Fixes: b617611b27a ("binman: capsule: Ad

Re: [PATCH v3 03/18] mkeficapsule: Add a --version argument

2024-06-20 Thread Ilias Apalodimas
On Fri, 21 Jun 2024 at 02:06, Simon Glass wrote: > > Tools should have an option to obtain the version, so add this to the > mkeficapsule tool. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > doc/mkeficapsule.1 | 4 > tools/mkeficapsule.c | 8 +++- > 2 files changed

Re: [PATCH v3 10/18] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-20 Thread Ilias Apalodimas
On Fri, 21 Jun 2024 at 08:32, Ilias Apalodimas wrote: > > Hi Simon, > > On Fri, 21 Jun 2024 at 02:06, Simon Glass wrote: > > > > It does not make sense to enable all SHA algorithms unless they are > > needed. It bloats the code and in this case, causes chromebook_link to > > fail to build. That b

Re: [PATCH v2] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-20 Thread Dhruva Gole
Nishanth, On Jun 19, 2024 at 13:47:36 -0500, Nishanth Menon wrote: > On 10:26-20240618, Dhruva Gole wrote: > > Add support for packaging the TIFS Stub as it's required for basic Low > > Power Modes like Deep Sleep. > > What the heck is tifs stub? > https://docs.u-boot.org/en/latest/search.html?q=

Re: [PATCH v3 10/18] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-20 Thread Ilias Apalodimas
Hi Simon, On Fri, 21 Jun 2024 at 02:06, Simon Glass wrote: > > It does not make sense to enable all SHA algorithms unless they are > needed. It bloats the code and in this case, causes chromebook_link to > fail to build. That board does use the TPM, but not with measured boot, > nor EFI. > > Sinc

Re: [PATCH v2] arm: dts: k3-am625-beagleplay: Package TIFS Stub

2024-06-20 Thread Dhruva Gole
Bryan, On Jun 19, 2024 at 16:44:48 -0500, Bryan Brattlof wrote: > On June 18, 2024 thus sayeth Dhruva Gole: > > Add support for packaging the TIFS Stub as it's required for basic Low > > Power Modes like Deep Sleep. > > > > Acked-by: Neha Malcom Francis > > Signed-off-by: Dhruva Gole > > --- >

Re: [PATCH] include/fastboot.h: add missing types.h include

2024-06-20 Thread Sam Protsenko
On Thu, Jun 20, 2024 at 8:51 PM Caleb Connolly wrote: > > Fixes a compile error when building with only the TCP fastboot implementation. > > Signed-off-by: Caleb Connolly > --- Reviewed-by: Sam Protsenko > include/fastboot.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/f

[PATCH] usb: dwc3: respect role-switch-default-mode

2024-06-20 Thread Caleb Connolly
* Factor out the common pattern of checking the dr_mode property on the usb node and it's parent * Respect the usb-role-switch property, rather than requiring dr_mode be set * Override OTG mode with the value in role-switch-default-mode The devicetree bindings don't dictate that dr_mode is a r

[PATCH] mmc: msm_sdhci: program core_vendor_spec

2024-06-20 Thread Caleb Connolly
After resetting the host controller, program in the POR val for this register just like the Linux driver does. This seems to help with initialization when running U-Boot as the primary bootloader on some boards. Signed-off-by: Caleb Connolly --- drivers/mmc/msm_sdhci.c | 11 +++ 1 file

[PATCH] include/fastboot.h: add missing types.h include

2024-06-20 Thread Caleb Connolly
Fixes a compile error when building with only the TCP fastboot implementation. Signed-off-by: Caleb Connolly --- include/fastboot.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/fastboot.h b/include/fastboot.h index 2ca1b907a54d..b106d6177493 100644 --- a/include/fastboot.h +++ b

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-20 Thread Tom Rini
On Thu, Jun 20, 2024 at 05:05:30PM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 20 Jun 2024 at 08:32, Tom Rini wrote: > > > > On Thu, Jun 20, 2024 at 07:19:35AM -0600, Simon Glass wrote: > > > > > The Python virtualenv tool sets up a few things in the envronment, > > > putting its path first i

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-20 Thread Tom Rini
On Thu, Jun 20, 2024 at 05:05:29PM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 19 Jun 2024 at 09:32, Tom Rini wrote: > > > > On Tue, Jun 18, 2024 at 09:03:37PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 18 Jun 2024 at 08:15, Tom Rini wrote: > > > > > > > > On Tue, Jun 18, 20

Re: [PATCH] RFC: Add a tag for the world builds

2024-06-20 Thread Tom Rini
On Thu, Jun 20, 2024 at 05:05:26PM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 20 Jun 2024 at 08:39, Tom Rini wrote: > > > > On Thu, Jun 20, 2024 at 07:33:46AM -0600, Simon Glass wrote: > > > > > Currently the world builds run on all runners, including faster and > > > slower ones. > > > > >

[PATCH v3 00/18] Bug-fixes for a few boards

2024-06-20 Thread Simon Glass
This series includes fixes to get some rockchip and nvidia boards working again. It also drops the broken Beaglebone Black config and provides a devicetree fix for coral (x86). Changes in v3: - Use BLOBLIST instead of OF_BLOBLIST - Cut the patch down to bare bones - Split out the refactoring into

Re: [PATCH v2 2/2] board: rockchip: Add FriendlyElec NanoPi R6S

2024-06-20 Thread Ulli Kehrle
Sebastian Kropatsch writes: > The R6S is very similar to the R6C, the major difference being that > instead of the M.2 NVMe socket on the R6C, the R6S has a second RTL8125BG > Ethernet chip, which uses the same PCIe lanes that the R6C uses for its > M.2 socket. Other minor differences include: >

[PATCH v3 18/18] Drop the special am335x_boneblack_vboot target

2024-06-20 Thread Simon Glass
Now that am335x_evm boots OK on the Beaglebone black, drop the latter and update the docs to cover the change. Also add a few updates about 'make fit' and drop the note about the security review, as U-Boot's verified boot has had quite extensive review now. Signed-off-by: Simon Glass Reviewed-by

[PATCH v3 17/18] rockchip: bob: kevin: Disable dcache in SPL

2024-06-20 Thread Simon Glass
This causes a hang, so disable it. Unfortunately the RAM-size fix does not resolve the problem and I am unsure what is wrong. As soon as the cache is enabled the board appears to hang. Fixes: 6d8cdfd1536 ("rockchip: spl: Enable caches to speed up checksum validation") Signed-off-by: Simon Glass

[PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-20 Thread Simon Glass
The code here is confusing due to large blocks which are #ifdefed out. Add a function phase_sdram_init() which returns whether SDRAM init should happen in the current phase, using that as needed to control the code flow. This increases code size by about 500 bytes in SPL when the cache is on, sinc

[PATCH v3 15/18] rockchip: Ensure memory size is available in RK3399 SPL

2024-06-20 Thread Simon Glass
At present gd->ram_size is 0 in SPL, meaning that it is not possible to enable the cache. Correct this by always populating the RAM size correctly. This increases code size by about 500 bytes in SPL, since it must call the rather large rockchip_sdram_size() function. Signed-off-by: Simon Glass -

[PATCH v3 14/18] spl: Allow ATF to work when dcache is disabled

2024-06-20 Thread Simon Glass
The dcache may not be enabled in SPL. Add a check to avoid trying to use an undefined function. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) common/spl/spl_atf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/spl/spl_atf.c b/common/s

[PATCH v3 13/18] fdt: Correct condition for bloblist existing

2024-06-20 Thread Simon Glass
On some boards, the bloblist is created in SPL once SDRAM is ready. It cannot be accessed until that point, so is not available early in SPL. Add a condition to avoid a hang in this case. This fixes a hang in chromebook_coral Fixes: 70fe2385943 ("fdt: Allow the devicetree to come from a bloblist

[PATCH v3 12/18] power: regulator: Handle autoset in regulators_enable_boot_on()

2024-06-20 Thread Simon Glass
With a recent change, regulators_enable_boot_on() returns an error if a regulator is already set. Check for and handle this situation. Fixes: d99fb64a98a power: regulator: Only run autoset once for each regulator Reviewed-by: Jonas Karlman Reviewed-by: Quentin Schulz Signed-off-by: Simon Glass

[PATCH v3 11/18] rockchip: veyron: Add logging for power init

2024-06-20 Thread Simon Glass
Add better logging for power init so that CONFIG_LOG_ERROR_RETURN can be enabled. Signed-off-by: Simon Glass Reviewed-by: Quentin Schulz --- (no changes since v2) Changes in v2: - Remove the superfluous if() and drop the debug() as well board/google/veyron/veyron.c | 30 -

[PATCH v3 10/18] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-20 Thread Simon Glass
It does not make sense to enable all SHA algorithms unless they are needed. It bloats the code and in this case, causes chromebook_link to fail to build. That board does use the TPM, but not with measured boot, nor EFI. Since EFI_TCG2_PROTOCOL already selects these options, we just need to add the

[PATCH v3 09/18] nvidia: nyan-big: Disable debug UART

2024-06-20 Thread Simon Glass
This cannot be enabled early in boot since some other init is needed. At this point it is unclear exactly what init is needed, so disable the debug UART to avoid a hang. Signed-off-by: Simon Glass --- (no changes since v1) configs/nyan-big_defconfig | 1 - 1 file changed, 1 deletion(-) diff -

[PATCH v3 08/18] x86: Set up some assumed sizes for binary blobs

2024-06-20 Thread Simon Glass
Add assumed sizes so that Binman can check that the U-Boot binaries do not grow too large. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/dts/u-boot.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/dts/u-boot.dtsi b/arch/x86/dts/u-boot.dtsi index e0de331809

[PATCH v3 07/18] binman: Keep the efi_capsule input file

2024-06-20 Thread Simon Glass
There is no need to remove input files. It makes it harder to diagnose failures. Keep the payload file. There is no test for this condition, but one could be added. Signed-off-by: Simon Glass Fixes: b617611b27a ("binman: capsule: Add support for generating...") --- (no changes since v1) tools

[PATCH v3 06/18] binman: Return failure when a usage() message is generated

2024-06-20 Thread Simon Glass
The tool must return an error code when invalid arguments are provided, otherwise binman has no way of knowing that anything went wrong. Correct this. Signed-off-by: Simon Glass Fixes: fab430be2f4 ("tools: add mkeficapsule command for UEFI...") --- (no changes since v1) tools/mkeficapsule.c |

[PATCH v3 05/18] binman: Deal with mkeficapsule being missing

2024-06-20 Thread Simon Glass
Tools cannot be assumed to be present. Add a check for this with the mkeficpasule tool. Signed-off-by: Simon Glass Fixes: b617611b27a ("binman: capsule: Add support for generating...") --- (no changes since v1) tools/binman/etype/efi_capsule.py | 4 1 file changed, 4 insertions(+) diff -

[PATCH v3 04/18] binman: Collect the version number for mkeficapsule

2024-06-20 Thread Simon Glass
Now that this tool has a version number, collect it. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/btool/mkeficapsule.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/binman/btool/mkeficapsule.py b/tools/binman/btool/mkeficapsule.py index ef1d

[PATCH v3 03/18] mkeficapsule: Add a --version argument

2024-06-20 Thread Simon Glass
Tools should have an option to obtain the version, so add this to the mkeficapsule tool. Signed-off-by: Simon Glass --- (no changes since v1) doc/mkeficapsule.1 | 4 tools/mkeficapsule.c | 8 +++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/doc/mkeficapsule.1 b/do

[PATCH v3 02/18] binman: Make Intel ME default to position 0x1000

2024-06-20 Thread Simon Glass
This cannot ever go at offset 0 since the descriptor is there. Use a better offset for the ME, as used by link and coral, for example. This matters when we start using assumed sizes for missing blobs. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/intel_descriptor.py

[PATCH v3 01/18] binman: Support an assumed size for missing binaries

2024-06-20 Thread Simon Glass
Binman has a the useful feature of handling missing external blobs gracefully, including allowing them to be missing, deciding whether the resulting image is functional or not and faking blobs when this is necessary for particular tools (e.g. mkimage). This feature is widely used in CI. One drawba

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-20 Thread Simon Glass
Hi Heinrich, On Thu, 20 Jun 2024 at 07:38, Heinrich Schuchardt wrote: > > On 20.06.24 15:19, Simon Glass wrote: > > The Python virtualenv tool sets up a few things in the envronment, > > Nits > > %s/envronment/environment/ > > > putting its path first in the PATH environment variable and setting

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-20 Thread Simon Glass
Hi Tom, On Thu, 20 Jun 2024 at 08:32, Tom Rini wrote: > > On Thu, Jun 20, 2024 at 07:19:35AM -0600, Simon Glass wrote: > > > The Python virtualenv tool sets up a few things in the envronment, > > putting its path first in the PATH environment variable and setting up > > a sys.prefix different fro

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-20 Thread Simon Glass
Hi Tom, On Wed, 19 Jun 2024 at 09:32, Tom Rini wrote: > > On Tue, Jun 18, 2024 at 09:03:37PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 18 Jun 2024 at 08:15, Tom Rini wrote: > > > > > > On Tue, Jun 18, 2024 at 06:43:51AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-20 Thread Simon Glass
Hi Nishanth, On Thu, 20 Jun 2024 at 15:35, Nishanth Menon wrote: > > Hi Team, > > We have briefly discussed this topic on IRC[1]. I would like to > propose a new boot-firmware repository similar to the Linux-firmware > repository under the aegis of u-boot hosting. > > In addition to TI, it looks

Re: mkimage alignment of initrd with -T multi

2024-06-20 Thread Simon Glass
Hi Chris, On Wed, 19 Jun 2024 at 23:16, Chris Packham wrote: > > Hi U-Boot, > > I've been given a MIPS reference board with a fairly old vendor U-Boot > on it. It does seem to support the Mutli-File Image format but I'm > running into an issue where the kernel expects the initrd on a page > boun

Re: [PATCH] RFC: Add a tag for the world builds

2024-06-20 Thread Simon Glass
Hi Tom, On Thu, 20 Jun 2024 at 08:39, Tom Rini wrote: > > On Thu, Jun 20, 2024 at 07:33:46AM -0600, Simon Glass wrote: > > > Currently the world builds run on all runners, including faster and > > slower ones. > > > > The difference can be quite dramatic, with some builders 4x as fast as > > othe

Re: [PATCH] scripts/Makefile.lib: remove bootph-some-ram property from VPL/TPL/SPL

2024-06-20 Thread Simon Glass
On Wed, 19 Jun 2024 at 05:33, Quentin Schulz wrote: > > From: Quentin Schulz > > The property isn't useful in VPL/SPL/TPL as it is only for U-Boot proper > pre-reloc, which has its own DTB. > > Signed-off-by: Quentin Schulz > --- > scripts/Makefile.lib | 2 +- > 1 file changed, 1 insertion(+),

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-20 Thread Mark Kettenis
> Date: Fri, 21 Jun 2024 00:22:43 +0200 > From: Quentin Schulz Hi Quentin, > FYI, the DDR bin is printing stuff on the console, so we had to modify > it (with a tool from Rockchip) to remove the gibberish breaking the > terminal by setting the appropriate controller, mux and baudrate (for > o

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-20 Thread Peter Robinson
On Thu, 20 Jun 2024 at 23:22, Quentin Schulz wrote: > > Hi Nishanth Menon, > > +Cc Kever from Rockchip as maintainer of the arch in U-Boot > +Cc Heiko as maintainer of many things Rockchip in many projects > > On 6/20/24 11:35 PM, Nishanth Menon wrote: > > Hi Team, > > > > We have briefly discusse

[PATCH] board: gateworks: venice: Simplify Ethernet initialization

2024-06-20 Thread Tim Harvey
With DM enabled, there is no need for board code to initialize the Ethernet interfaces. Specifically board_interface_eth_init will handle the configuration of GPR1. Signed-off-by: Tim Harvey --- board/gateworks/venice/venice.c | 19 --- 1 file changed, 19 deletions(-) diff --gi

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-20 Thread Quentin Schulz
Hi Nishanth Menon, +Cc Kever from Rockchip as maintainer of the arch in U-Boot +Cc Heiko as maintainer of many things Rockchip in many projects On 6/20/24 11:35 PM, Nishanth Menon wrote: Hi Team, We have briefly discussed this topic on IRC[1]. I would like to propose a new boot-firmware reposi

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-20 Thread Peter Robinson
Hi Nishanth, Thanks for starting this conversation. > We have briefly discussed this topic on IRC[1]. I would like to > propose a new boot-firmware repository similar to the Linux-firmware > repository under the aegis of u-boot hosting. > > In addition to TI, it looks like some NXP[2] and Rockchi

Re: [PATCH] board: beagle: beagleplay: enable OF_SYSTEM_SETUP

2024-06-20 Thread Robert Nelson
On Thu, Jun 20, 2024 at 4:15 PM Nishanth Menon wrote: > > On 11:55-20240620, Chirag Shilwant wrote: > > > > On 20/06/24 11:21, Dhruva Gole wrote: > > > On Jun 19, 2024 at 15:44:41 -0500, Andrew Davis wrote: > > > > On 6/19/24 2:12 PM, Bryan Brattlof wrote

Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-20 Thread Nishanth Menon
Hi Team, We have briefly discussed this topic on IRC[1]. I would like to propose a new boot-firmware repository similar to the Linux-firmware repository under the aegis of u-boot hosting. In addition to TI, it looks like some NXP[2] and Rockchip[3] platforms seem to require additional closed-sour

Re: [PATCH] board: beagle: beagleplay: enable OF_SYSTEM_SETUP

2024-06-20 Thread Nishanth Menon
On 11:55-20240620, Chirag Shilwant wrote: > > On 20/06/24 11:21, Dhruva Gole wrote: > > On Jun 19, 2024 at 15:44:41 -0500, Andrew Davis wrote: > > > On 6/19/24 2:12 PM, Bryan Brattlof wrote: > > > > Unfortunately when enabling FDT fixups for the AM62x family of So

Re: obscure microsd detection issue between U-Boot and kernel

2024-06-20 Thread Christian Loehle
On 6/20/24 17:48, Tim Harvey wrote: > On Tue, Jun 4, 2024 at 1:14 AM Michael Walle wrote: >> >> On Tue Jun 4, 2024 at 9:47 AM CEST, Christian Loehle wrote: >>> On 6/3/24 22:28, Tim Harvey wrote: On Mon, Jun 3, 2024 at 1:18 AM Christian Loehle wrote: > > On 5/31/24 21:47, Tim Har

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-06-20 Thread Tom Rini
On Thu, Jun 13, 2024 at 11:59:05AM +0100, Chris Webb wrote: > 48b3ecbe replumbed the gpio-hog probing to use DM_FLAG_PROBE_AFTER_BIND. > > Unfortunately gpio_post_bind is called after the non-preloc recursive > dm_probe_devices completes, so setting this flag does not have the intended > effect a

[PATCH] efi_loader: adjust config options for capsule updates

2024-06-20 Thread Ilias Apalodimas
EFI_IGNORE_OSINDICATIONS is used to ignore OsIndications if setvariable at runtime is not supported and allow the platform to perform capsule updates on disk. With the recent changes boards can conditionally enable setvariable at runtime using EFI_RT_VOLATILE_STORE. Let's make that visible in our

Re: [PATCH 0/4] boot: fix crash in bootflow menu with EFI BOOTMGR support + typos

2024-06-20 Thread Tom Rini
On Wed, 12 Jun 2024 16:58:45 +0200, Quentin Schulz wrote: > bootflow menu currently crashes U-Boot with a NULL pointer dereference > because bootflow->dev is NULL for global bootmeths (such as EFI BOOTMGR). > Therefore, let's check if the bootflow is associated with a global > bootmeth before tryi

Re: [PATCH 0/3] lib: smbios: Extend driver with using sysinfo driver

2024-06-20 Thread Tom Rini
On Fri, 26 Apr 2024 15:38:10 +0200, Michal Simek wrote: > currently only DT way is supported and it is added directly to lib/smbios.c > but I think DT and env is only one way how information can be found that's > why this series is improving handling with using sysinfo driver which can > be platfo

Re: [PATCH] efi_loader: adjust config options for capsule updates

2024-06-20 Thread Ilias Apalodimas
Hi Heinrich, On Thu, 20 Jun 2024 at 18:23, Heinrich Schuchardt wrote: > > On 18.06.24 17:49, Ilias Apalodimas wrote: > > EFI_IGNORE_OSINDICATIONS is used to ignore OsIndications if setvariable > > at runtime is not supported and allow the platform to perform capsule > > updates on disk. With the

Re: [PATCH 1/2] tpm: Fix return code, if the eventlog buffer is full

2024-06-20 Thread Ilias Apalodimas
On Thu, 20 Jun 2024 at 22:16, Ilias Apalodimas wrote: > > We currently return 'No space left on device' if the eventlong buffer > we allocated is not enough. On a similar check later on that function > during the call to tcg2_log_init() we return 'No buffer space > available'. So switch both error

[PATCH 2/2] efi_loader: fix return values on efi_tcg

2024-06-20 Thread Ilias Apalodimas
A while back we moved the core functions of the EFI TCG protocol to the TPM APIs in order for them to be used with bootm, booti etc. Some prototypes changed from returning efi_status_t to int, which is more appropriate for the non-EFI APIs. However, some of the EFI callsites never changed and we en

[PATCH 1/2] tpm: Fix return code, if the eventlog buffer is full

2024-06-20 Thread Ilias Apalodimas
We currently return 'No space left on device' if the eventlong buffer we allocated is not enough. On a similar check later on that function during the call to tcg2_log_init() we return 'No buffer space available'. So switch both error codes to -ENOBUFS since we are always checking a buffer and not

Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion

2024-06-20 Thread Peter Robinson
On Thu, 20 Jun 2024 at 18:41, Alex Bee wrote: > > > Am 20.06.24 um 19:08 schrieb Tom Rini: > > On Thu, Jun 20, 2024 at 07:03:26PM +0200, Alex Bee wrote: > >> Am 20.06.24 um 12:24 schrieb Quentin Schulz: > >>> From: Quentin Schulz > >>> > >>> No meaningful changes were made to this SoM since Febru

Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion

2024-06-20 Thread Alex Bee
Am 20.06.24 um 19:08 schrieb Tom Rini: On Thu, Jun 20, 2024 at 07:03:26PM +0200, Alex Bee wrote: Am 20.06.24 um 12:24 schrieb Quentin Schulz: From: Quentin Schulz No meaningful changes were made to this SoM since February 2021. Nobody from Theobroma has booted anything recent on that produc

Re: [PATCH v3 0/9] misc: introduce STATUS LED activity function

2024-06-20 Thread Peter Robinson
On Wed, 12 Jun 2024 at 03:33, Christian Marangi wrote: > > This series expand the STATUS LED framework with a new color > and a big new feature. One thing that many device need is a way > to communicate to the user that the device is actually doing > something. > > This is especially useful for re

Re: [PATCH v4 4/9] led: status_led: add warning when an invalid Status LED ID is used

2024-06-20 Thread Peter Robinson
On Thu, 20 Jun 2024 at 02:51, Christian Marangi wrote: > > Add a warning when an invalid Status LED ID is used to make the user > aware of bad configurations. > > Signed-off-by: Christian Marangi > --- > drivers/misc/status_led.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > dif

Re: [PATCH v4 9/9] doc: convert README.LED to .rst documentation

2024-06-20 Thread Heinrich Schuchardt
On 6/20/24 06:37, Christian Marangi wrote: On Thu, Jun 20, 2024 at 08:13:34AM +0200, Heinrich Schuchardt wrote: On 6/20/24 01:03, Christian Marangi wrote: Convert README.LED to .rst documentation and include all the relevant documentation in the status_led.h. Signed-off-by: Christian Marangi

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-20 Thread Tim Harvey
On Mon, Jun 17, 2024 at 8:33 AM Jerome Forissier wrote: > > This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip > library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP > stack [2] [3] as an alternative to the current implementation in net/, > selectable w

Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion

2024-06-20 Thread Tom Rini
On Thu, Jun 20, 2024 at 07:03:26PM +0200, Alex Bee wrote: > Am 20.06.24 um 12:24 schrieb Quentin Schulz: > > From: Quentin Schulz > > > > No meaningful changes were made to this SoM since February 2021. Nobody > > from Theobroma has booted anything recent on that product since July > > 2021 at th

Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion

2024-06-20 Thread Alex Bee
Am 20.06.24 um 12:24 schrieb Quentin Schulz: From: Quentin Schulz No meaningful changes were made to this SoM since February 2021. Nobody from Theobroma has booted anything recent on that product since July 2021 at the latest. The product isn't available to buy anymore and disappeared from our

Re: [PATCH v4 0/9] misc: introduce STATUS LED activity function

2024-06-20 Thread Tom Rini
On Thu, Jun 20, 2024 at 06:29:23AM +0200, Christian Marangi wrote: > On Thu, Jun 20, 2024 at 08:34:03AM +0200, Heinrich Schuchardt wrote: > > On 6/20/24 01:03, Christian Marangi wrote: > > > This series expand the STATUS LED framework with a new color > > > and a big new feature. One thing that man

Re: obscure microsd detection issue between U-Boot and kernel

2024-06-20 Thread Tim Harvey
On Tue, Jun 4, 2024 at 1:14 AM Michael Walle wrote: > > On Tue Jun 4, 2024 at 9:47 AM CEST, Christian Loehle wrote: > > On 6/3/24 22:28, Tim Harvey wrote: > > > On Mon, Jun 3, 2024 at 1:18 AM Christian Loehle > > > wrote: > > >> > > >> On 5/31/24 21:47, Tim Harvey wrote: > > >>> Greetings, > > >>

Re: [PATCH v5 1/2] arm: mediatek: add mt8195 SOC support

2024-06-20 Thread Shengyu Qu
Hello, What happened to this series? Has it been abandoned? Also, is it possible to get memory size installed to the board dynamically? Best regards, Shengyu 在 2023/8/4 19:04, Macpaul Lin 写道: From: Fabien Parent The MediaTek MT8195 is a ARM64-based SoC with a quad-core Cortex-A73 and a quad-

Re: [PATCH] efi_loader: adjust config options for capsule updates

2024-06-20 Thread Heinrich Schuchardt
On 18.06.24 17:49, Ilias Apalodimas wrote: EFI_IGNORE_OSINDICATIONS is used to ignore OsIndications if setvariable at runtime is not supported and allow the platform to perform capsule updates on disk. With the recent changes boards can conditionally enable setvariable at runtime using EFI_RT_VOL

Re: [PATCH v3 6/7] tools: add genguid tool

2024-06-20 Thread Vincent Stehlé
On Fri, May 31, 2024 at 03:50:40PM +0200, Caleb Connolly wrote: > Add a tool that can generate GUIDs that match those generated internally > by U-Boot for capsule update fw_images. Hi Caleb, Thanks for working on this. I think there is a leftover "dtb" option; see below. Best regards, Vincent.

Re: [PATCH] RFC: Add a tag for the world builds

2024-06-20 Thread Tom Rini
On Thu, Jun 20, 2024 at 07:33:46AM -0600, Simon Glass wrote: > Currently the world builds run on all runners, including faster and > slower ones. > > The difference can be quite dramatic, with some builders 4x as fast as > others, resulting in just one world build taking between 20 minutes and >

Re: [PATCH] arm: dts: corstone1000: enable secondary cores for FVP

2024-06-20 Thread Tom Rini
On Wed, 12 Jun 2024 11:04:21 +0100, harsimransingh.tun...@arm.com wrote: > Add the secondary cores nodes in the dts file > > Applied to u-boot/next, thanks! -- Tom

Re: [PATCH v2 0/2] Enable ICSSG Driver for AM64x

2024-06-20 Thread Tom Rini
On Wed, 12 Jun 2024 16:37:47 +0530, MD Danish Anwar wrote: > This series adds config changes and env changes to enable ICSSG Ethernet > Driver on AM64x. > > Changes since v1: > *) Dropped the patch [0] as this needs to be fixed in driver as suggested >by Andrew Davis > *) Rebased on latest u

Re: [PATCH 5/5] CI: Run code-coverage test for Binman

2024-06-20 Thread Tom Rini
On Thu, Jun 20, 2024 at 07:19:37AM -0600, Simon Glass wrote: > Binman includes a good set of tests covering all of its functionality. > This includes a code-coverage test. > > However to date the code-coverage test has not been checked > automatically by CI, relying on people to run 'binman test -

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-20 Thread Tom Rini
On Thu, Jun 20, 2024 at 07:19:35AM -0600, Simon Glass wrote: > The Python virtualenv tool sets up a few things in the envronment, > putting its path first in the PATH environment variable and setting up > a sys.prefix different from the sys.base_prefix value. > > At present buildman puts the tool

Re: [PATCH 1/5] Dockerfile: Add python3-coverage

2024-06-20 Thread Tom Rini
On Thu, Jun 20, 2024 at 07:19:33AM -0600, Simon Glass wrote: > Add this package so we can run code-coverage tests for Binman. > > Signed-off-by: Simon Glass This (and same for patch 2) should be in tools/buildman/requirements.txt -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 0/5] bootstd: Add Android support

2024-06-20 Thread Tom Rini
On Thu, Jun 13, 2024 at 12:13:07PM +0200, Mattijs Korpershoek wrote: > Android boot flow is a bit different than a regular Linux distro. > Android relies on multiple partitions in order to boot. > > A typical boot flow would be: > 1. Parse the Bootloader Control Block (BCB, misc partition) > 2. I

[PATCH] mkimage: Allow 'auto-conf' signing of scripts

2024-06-20 Thread Alexander Dahl
U-Boot configured for verified boot with the "required" option set to "conf" also checks scripts put in FIT images for a valid signature, and refuses to source and run such a script if the signature for the configuration is bad or missing. Such a script could not be packaged before, because mkimag

Re: [PATCH v4 9/9] doc: convert README.LED to .rst documentation

2024-06-20 Thread Christian Marangi
On Thu, Jun 20, 2024 at 08:13:34AM +0200, Heinrich Schuchardt wrote: > On 6/20/24 01:03, Christian Marangi wrote: > > Convert README.LED to .rst documentation and include all the relevant > > documentation in the status_led.h. > > > > Signed-off-by: Christian Marangi > > --- > > doc/README.LED

Re: [PATCH v4 0/9] misc: introduce STATUS LED activity function

2024-06-20 Thread Christian Marangi
On Thu, Jun 20, 2024 at 08:34:03AM +0200, Heinrich Schuchardt wrote: > On 6/20/24 01:03, Christian Marangi wrote: > > This series expand the STATUS LED framework with a new color > > and a big new feature. One thing that many device need is a way > > to communicate to the user that the device is ac

Re: [PATCH v7 1/4] Add fdt_kaslrseed function to add kaslr-seed to chosen node

2024-06-20 Thread Caleb Connolly
Hi Tim, On 18/06/2024 23:06, Tim Harvey wrote: If RANDOMIZE_BASE is enabled in the Linux kernel instructing it to randomize the virtual address at which the kernel image is loaded, it expects entropy to be provided by the bootloader by populating /chosen/kaslr-seed with a 64-bit value from sourc

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-20 Thread Heinrich Schuchardt
On 20.06.24 15:19, Simon Glass wrote: The Python virtualenv tool sets up a few things in the envronment, Nits %s/envronment/environment/ putting its path first in the PATH environment variable and setting up a sys.prefix different from the sys.base_prefix value. At present buildman puts the

[PATCH] RFC: Add a tag for the world builds

2024-06-20 Thread Simon Glass
Currently the world builds run on all runners, including faster and slower ones. The difference can be quite dramatic, with some builders 4x as fast as others, resulting in just one world build taking between 20 minutes and an hour and 20 minutes. Add a tag so that we can select which builders ru

[PATCH 5/5] CI: Run code-coverage test for Binman

2024-06-20 Thread Simon Glass
Binman includes a good set of tests covering all of its functionality. This includes a code-coverage test. However to date the code-coverage test has not been checked automatically by CI, relying on people to run 'binman test -T' themselves. Plug the gap to avoid bugs creeping in future. Signed-

[PATCH 4/5] u_boot_pylib: Use correct coverage tool within venv

2024-06-20 Thread Simon Glass
When running within a Python venv we must use the 'coverage' tool (which is within the venv) so that the venv packages are used in preference to system packages. Otherwise the coverage tests run in a different environment from the normal tests and may fail due to missing packages. Handle this by d

[PATCH 3/5] buildman: Support building within a Python venv

2024-06-20 Thread Simon Glass
The Python virtualenv tool sets up a few things in the envronment, putting its path first in the PATH environment variable and setting up a sys.prefix different from the sys.base_prefix value. At present buildman puts the toolchain path first in PATH so that it can be found easily during the build

[PATCH 2/5] Dockerfile: Add python3-pycryptodome

2024-06-20 Thread Simon Glass
This is used by some Binman entry types, so add it to allow more tests to pass. Signed-off-by: Simon Glass --- tools/docker/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile index 0941b0f6952..a23504179c2 100644 --- a/tools/docker/D

[PATCH 1/5] Dockerfile: Add python3-coverage

2024-06-20 Thread Simon Glass
Add this package so we can run code-coverage tests for Binman. Signed-off-by: Simon Glass --- tools/docker/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile index cda87354566..0941b0f6952 100644 --- a/tools/docker/Dockerfile +++ b/t

[PATCH 0/5] Add Binman code-coverage test to CI

2024-06-20 Thread Simon Glass
Binman has 100% code coverage to ensure that future changes and refactors do not break existing entry types. This is a critical feature, given that it is relied on to produce images for all sorts of different SoCs and vendors. With the NXP additions the 'binman test -T' step was missed, so the Bin

[PATCH] doc: board: phytec: phycore-am6: Describe UART based boot

2024-06-20 Thread Wadim Egorov
Describe how to boot via UART. Signed-off-by: Wadim Egorov --- For next --- doc/board/phytec/phycore-am62x.rst | 17 + doc/board/phytec/phycore-am64x.rst | 19 +++ 2 files changed, 36 insertions(+) diff --git a/doc/board/phytec/phycore-am62x.rst b/doc/board/phyt

Re: [PATCH v2 5/5] usb: dwc3: meson-g12a: drop usb.h and make dwc3_meson_g12a_force_mode static

2024-06-20 Thread Marek Vasut
On 6/20/24 9:42 AM, Neil Armstrong wrote: Drop this useless usb.h and now make dwc3_meson_g12a_force_mode static since only used in the dwc3-meson-g12a.c file. Signed-off-by: Neil Armstrong Reviewed-by: Marek Vasut

Re: [PATCH v2 4/5] usb: dwc3: meson-gxl: drop usb-gx.h and make dwc3_meson_gxl_force_mode static

2024-06-20 Thread Marek Vasut
On 6/20/24 9:42 AM, Neil Armstrong wrote: Drop this useless usb-gx.h and now make dwc3_meson_gxl_force_mode static since only used in the dwc3-meson-gxl.c file. Signed-off-by: Neil Armstrong Reviewed-by: Marek Vasut

Re: [PATCH v2 3/5] phy: meson-gxl-usb2: remove phy_meson_gxl_usb2_set_mode

2024-06-20 Thread Marek Vasut
On 6/20/24 9:42 AM, Neil Armstrong wrote: Remove the public phy_meson_gxl_usb2_set_mode and move the implementation in the the set_mode callback. Signed-off-by: Neil Armstrong Reviewed-by: Marek Vasut -static int _phy_meson_gxl_usb2_set_mode(struct phy *phy, enum phy_mode mode, int submod

Re: [PATCH v2 2/5] usb: dwc3: meson-gxl: switch to generic_phy_set_mode

2024-06-20 Thread Marek Vasut
On 6/20/24 9:42 AM, Neil Armstrong wrote: Use the PHY set_mode call instead of calling directly in the PHY shared function. Signed-off-by: Neil Armstrong Reviewed-by: Marek Vasut

Re: [PATCH v2 1/5] phy: meson-gxl-usb2: add set_mode callback

2024-06-20 Thread Marek Vasut
On 6/20/24 9:42 AM, Neil Armstrong wrote: Implement set_mode callback by calling the current public function, use a temporary function name that will be removed when the public phy_meson_gxl_usb2_set_mode is finally removed in a following change. Signed-off-by: Neil Armstrong Reviewed-by: Mar

Re: [PATCH 3/5] phy: meson-gxl-usb2: remove phy_meson_gxl_usb2_set_mode

2024-06-20 Thread Marek Vasut
On 6/20/24 9:39 AM, Neil Armstrong wrote: On 18/06/2024 16:56, Marek Vasut wrote: On 6/18/24 9:55 AM, Neil Armstrong wrote: [...] @@ -205,7 +188,7 @@ static int phy_meson_gxl_usb2_power_off(struct phy *phy)   struct phy_ops meson_gxl_usb2_phy_ops = {   .power_on = phy_meson_gxl_usb2_powe

Re: [PATCH v1 0/7] Add Starfive JH7110 Cadence USB driver

2024-06-20 Thread E Shattow
Minda, can you test USB Host function on VisionFive2? I guess that it is connected to the USB-C port. For the boards with JH7110 and not any VL805 USB controller this Cadence USB is the only way to have host USB. It is very much wanted to have host USB. Thanks! -E On Sun, May 19, 2024 at 11:20 PM

Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion

2024-06-20 Thread Heiko Stübner
Am Donnerstag, 20. Juni 2024, 12:24:51 CEST schrieb Quentin Schulz: > From: Quentin Schulz > > No meaningful changes were made to this SoM since February 2021. Nobody > from Theobroma has booted anything recent on that product since July > 2021 at the latest. The product isn't available to buy an

[PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion

2024-06-20 Thread Quentin Schulz
From: Quentin Schulz No meaningful changes were made to this SoM since February 2021. Nobody from Theobroma has booted anything recent on that product since July 2021 at the latest. The product isn't available to buy anymore and disappeared from our website. This product is therefore unmaintaine

  1   2   >