[PATCH 12/35] global_data: Convert have_console into a flag

2024-07-24 Thread Simon Glass
We don't need a full word for this boolean value. Convert it into a flag to save space in global_data. Signed-off-by: Simon Glass --- arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 2 +- arch/arm/mach-exynos/spl_boot.c | 2 +- arch/arm/mach-k3/common.c | 2 +-

[PATCH 00/35] global_data: Reduce size of struct global_data

2024-07-24 Thread Simon Glass
The global data structure has grown quite a lot over the years, being the best place to put an important pointer or something that must be accessed before and after relocation. This series attempts to reduce the size a little, by moving some things out and shrinking and aligning some fields.

[PATCH 2/2] power: regulator: Consistently return -ENOSYS when ops is unimplemented

2024-07-24 Thread Jonas Karlman
dev_get_driver_ops() may return NULL when the udevice is invalid. Move the ops check to top of functions to consistently return -ENOSYS when ops is unimplemented and prevent trying to access uclass plat data, also add missing NULL checks to suspend ops. Signed-off-by: Jonas Karlman ---

[PATCH 1/2] power: regulator: Do not call set_suspend_value with -ENODATA

2024-07-24 Thread Jonas Karlman
On some boards a PMIC regulator is flagged with regulator-on-in-suspend and does not define any suspend or max microvolt, e.g. on Radxa ROCK 3A: vcc_ddr: DCDC_REG3 { regulator-name = "vcc_ddr"; regulator-always-on; regulator-boot-on; regulator-initial-mode =

Re: [RFC PATCH v2 38/48] lib: Kconfig: add a config symbol for getting lmb memory map updates

2024-07-24 Thread Tom Rini
On Wed, Jul 24, 2024 at 09:40:35AM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 24 Jul 2024 at 08:52, Tom Rini wrote: > > > > On Wed, Jul 24, 2024 at 08:37:14AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 23 Jul 2024 at 08:20, Tom Rini wrote: > > > > > > > > On Tue, Jul 23,

Re: [PATCH v4 00/29] Integrate MbedTLS v3.6 LTS with U-Boot

2024-07-24 Thread Tom Rini
On Wed, Jul 24, 2024 at 10:34:50AM -0400, Raymond Mao wrote: > Hi Tom, > > On Tue, 2 Jul 2024 at 21:26, Tom Rini wrote: > > > On Tue, Jul 02, 2024 at 11:22:36AM -0700, Raymond Mao wrote: > > > > > Integrate MbedTLS v3.6 LTS (currently v3.6.0-RC1) with U-Boot. > > > > > > Motivations: > > >

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-07-24 Thread Tom Rini
On Wed, Jul 24, 2024 at 12:06:46PM +0200, Heinrich Schuchardt wrote: > > > Am 24. Juli 2024 11:56:17 MESZ schrieb Mattijs Korpershoek > : > >Hi Heinrich, > > > >On mer., juil. 24, 2024 at 11:45, Heinrich Schuchardt > >wrote: > > > >> On 24.07.24 11:21, Mattijs Korpershoek wrote: > >>> Hi Tom,

Re: [PATCH 04/40] lib: Convert str_to_list() to use alist

2024-07-24 Thread Tom Rini
On Wed, Jul 24, 2024 at 04:17:32PM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 24 Jul 2024 at 14:54, Tom Rini wrote: > > > > On Wed, Jul 24, 2024 at 11:31:48AM +0530, Sughosh Ganu wrote: > > > > > From: Simon Glass > > > > > > Use this new data structure in the utility function. > > > > > >

Re: [PATCH 04/40] lib: Convert str_to_list() to use alist

2024-07-24 Thread Simon Glass
Hi Tom, On Wed, 24 Jul 2024 at 14:54, Tom Rini wrote: > > On Wed, Jul 24, 2024 at 11:31:48AM +0530, Sughosh Ganu wrote: > > > From: Simon Glass > > > > Use this new data structure in the utility function. > > > > Signed-off-by: Simon Glass > > Signed-off-by: Sughosh Ganu > > --- > >

Re: Re: [ANN] U-Boot v2024.10-rc1 released

2024-07-24 Thread Simon Glass
Hi Frank, On Wed, 24 Jul 2024 at 11:10, Frank Wunderlich wrote: > > Hi > > > Gesendet: Mittwoch, 24. Juli 2024 um 16:37 Uhr > > Von: "Simon Glass" > > An: "Frank Wunderlich" > > Cc: "Tom Rini" , u-boot@lists.denx.de, > > u-boot-custodi...@lists.denx.de, u-boot-board-maintain...@lists.denx.de

Re: [PATCH 28/40] lmb: config: make lmb config symbol def_bool

2024-07-24 Thread Tom Rini
On Wed, Jul 24, 2024 at 11:32:12AM +0530, Sughosh Ganu wrote: > The LMB module provides allocation/reservation API's, primarily for > loading images to memory. This is functionality which is used by all > boards. Make the config symbol used for the main U-Boot image as > def_bool and enable it by

Re: [PATCH 04/40] lib: Convert str_to_list() to use alist

2024-07-24 Thread Tom Rini
On Wed, Jul 24, 2024 at 11:31:48AM +0530, Sughosh Ganu wrote: > From: Simon Glass > > Use this new data structure in the utility function. > > Signed-off-by: Simon Glass > Signed-off-by: Sughosh Ganu > --- > lib/strto.c | 35 +++ > 1 file changed, 19

Re: radxa cm3 2024.01 mmc write error

2024-07-24 Thread Belisko Marek
Hi Jonas, On Thu, Jul 11, 2024 at 10:33 AM Jonas Karlman wrote: > Hi Marek, > > On 2024-07-10 21:26, Belisko Marek wrote: > > Hi, > > > > I'm playing with radxa cme and mainline u-boot 2024.01 (present in > > scarthgap yocto). > > I realized that mmc write fails all the time like: > > => md.l

Re: [PATCH v3 7/8] dts: starfive: Add JH7110 Cadence USB dts node

2024-07-24 Thread E Shattow
On Tue, Jul 23, 2024 at 8:24 PM Minda Chen wrote: > > > > > -邮件原件- > > 发件人: E Shattow > > 发送时间: 2024年7月23日 21:06 > > 收件人: Minda Chen > > 抄送: Marek Vasut ; Tom Rini ; Roger > > Quadros ; Neil Armstrong ; > > Alexey Romanov ; Sumit Garg > > ; Mark Kettenis ; Nishanth > > Menon ; Rick Chen

Aw: Re: [ANN] U-Boot v2024.10-rc1 released

2024-07-24 Thread Frank Wunderlich
Hi > Gesendet: Mittwoch, 24. Juli 2024 um 16:37 Uhr > Von: "Simon Glass" > An: "Frank Wunderlich" > Cc: "Tom Rini" , u-boot@lists.denx.de, > u-boot-custodi...@lists.denx.de, u-boot-board-maintain...@lists.denx.de > Betreff: Re: [ANN] U-Boot v2024.10-rc1 released > > Hi, > > On Tue, 23 Jul 2024

[PATCH v2 3/3] usb: dwc3: invalidate dcache on buffer used in interrupt handling

2024-07-24 Thread Neil Armstrong
On Qualcomm systems, the setup buffer and even buffers are in a bad state at interrupt handling, so invalidate the dcache lines for the setup_buf and event buffer to make sure we read correct data written by the hardware. This fixes the following error: dwc3-generic-peripheral usb@a60:

[PATCH v2 2/3] usb: dwc3: fix dcache flush range calculation

2024-07-24 Thread Neil Armstrong
The current flush operation will omit doing a flush/invalidate on the first and last bytes if the base address and size are not aligned with DMA_MINALIGN. This causes operation failures Qualcomm platforms. Take in account the alignment and size of the buffer and also flush the previous and last

[PATCH v2 0/3] dwc3: gadget: properly fix cache operations

2024-07-24 Thread Neil Armstrong
We experience huge problems with cache handling on Qualcomm systems, and it appears the dcache handling in the DWC3 gadget code is quite wrong and causes operational issues. This serie fixes the dcache operations on unaligned data, and properly invalidate buffers when reading back data from

[PATCH v2 1/3] usb: dwc3: allocate setup_buf with dma_alloc_coherent()

2024-07-24 Thread Neil Armstrong
Since setup_buf is also consumed by hardware DMA, aligns it's allocation like other hardware buffers by introduce setup_buf_addr populated by dma_alloc_coherent(), and use it to pass the physical address of the buffer to the hardware. Reviewed-by: Mattijs Korpershoek Signed-off-by: Neil

Re: [RFC PATCH v2 38/48] lib: Kconfig: add a config symbol for getting lmb memory map updates

2024-07-24 Thread Simon Glass
Hi Tom, On Wed, 24 Jul 2024 at 08:52, Tom Rini wrote: > > On Wed, Jul 24, 2024 at 08:37:14AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 23 Jul 2024 at 08:20, Tom Rini wrote: > > > > > > On Tue, Jul 23, 2024 at 01:42:59PM +0100, Simon Glass wrote: > > > > Hi Sughosh, > > > > > > > >

Re: [PATCH 1/3] usb: dwc3: allocate setup_buf with dma_alloc_coherent()

2024-07-24 Thread Neil Armstrong
On 24/07/2024 17:03, Mattijs Korpershoek wrote: Hi Neil, Thank you for the patch. On ven., juil. 19, 2024 at 15:56, Neil Armstrong wrote: Also allocate the setup_buf with dma_alloc_coherent() since it's The subject of the patch says: "usb: dwc3: allocate setup_buf with

Re: [PATCH 3/3] usb: dwc3: invalidate dcache on buffer used in interrupt handling

2024-07-24 Thread Mattijs Korpershoek
Hi Neil, Thank you for the patch. On ven., juil. 19, 2024 at 15:56, Neil Armstrong wrote: > On Qualcomm systems, the setup buffer and even buffers are in > a bad state at interrupt handling, so invalidate the dcache lines > for the setup_buf and event buffer to make sure we read correct >

Re: [PATCH 2/3] usb: dwc3: fix dcache flush range calculation

2024-07-24 Thread Mattijs Korpershoek
Hi Neil, Thank you for the patch. On ven., juil. 19, 2024 at 15:56, Neil Armstrong wrote: > The current flush operation will omit doing a flush/invalidate on > the first and last bytes if the base address and size are not aligned > with DMA_MINALIGN. > > This causes operation failures

[PATCH 35/35] doc: Add some guidelines about global data

2024-07-24 Thread Simon Glass
Update the documentation to provide a bit more information about how to use global data. Signed-off-by: Simon Glass --- doc/develop/global_data.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/doc/develop/global_data.rst b/doc/develop/global_data.rst index

[PATCH 33/35] global_data: Remove environment members if not used

2024-07-24 Thread Simon Glass
If the environment is not enabled we don't need these fields in global_data. Make them conditional. Make these fields conditional. Move env_buf up one so it can share an #ifdef. Signed-off-by: Simon Glass --- common/hwconfig.c | 8 +++- include/asm-generic/global_data.h |

[PATCH 34/35] doc: Move generic-board documentation into rst

2024-07-24 Thread Simon Glass
This information is useful for people looking at how U-Boot has changed over the years and the design decisions which led to it. Move it into doc/ in an 'historical' section. Signed-off-by: Simon Glass --- .../historical/generic_board.rst}| 16

[PATCH 32/35] global_data: Remove jump table in SPL

2024-07-24 Thread Simon Glass
SPL builds don't use the jump table since they cannot run apps. Drop it, moving it together with boardf. Signed-off-by: Simon Glass --- board/freescale/ls2080ardb/eth_ls2080rdb.c | 2 +- common/console.c | 3 ++- include/asm-generic/global_data.h | 10

[PATCH 30/35] global_data: Move ulong fields together

2024-07-24 Thread Simon Glass
Move all the always-present ulong fields next to the others at the top of global_data Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 50 +++ 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/include/asm-generic/global_data.h

[PATCH 31/35] global_data: Move pointer members together

2024-07-24 Thread Simon Glass
Collect the pointer members near the top of global_data to help with alignment. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 38 +++ 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/include/asm-generic/global_data.h

[PATCH 29/35] global_data: Put phys_addr fields near the top

2024-07-24 Thread Simon Glass
Put these fields near the top and together, since they have the same alignment. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/asm-generic/global_data.h

[PATCH 28/35] global_data: Move env_addr field higher

2024-07-24 Thread Simon Glass
Move this field to be with others of the same alignment. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h index

[PATCH 27/35] global_data: Move baud_rate field lower

2024-07-24 Thread Simon Glass
Move this field to be with others of the same alignment. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h index

[PATCH 26/35] global_data: Reduce size of early-malloc vars

2024-07-24 Thread Simon Glass
The early malloc region is normally quite small and is certainly less than 4GB, so use a 32-bit value for the limit and pointer. Update the comment for clarity while we are here. Signed-off-by: Simon Glass --- arch/arm/lib/bdinfo.c | 2 +- common/board_r.c | 2 +-

[PATCH 25/35] global_data: log: Reorder and shrink fields

2024-07-24 Thread Simon Glass
Some of the logging fields are larger than they need to be. Shrink them and adjust the ordering to improve alignment. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 43 +++ test/log/log_test.c | 6 ++--- 2 files changed, 24

[PATCH 24/35] global_data: Reduce the size of mon_len

2024-07-24 Thread Simon Glass
This is the length of the U-Boot binary, which is typically 200-800KB and certainly not larger than 4GB. Use a 32-bit value to save space in global_data and move it up to be with fields of the same alignment. Signed-off-by: Simon Glass --- common/board_f.c | 4 ++--

[PATCH 23/35] global_data: Reduce the size of bus_clk and mem_clk

2024-07-24 Thread Simon Glass
The bus clock and memory clock are unlikely to go above 4GHz for now, so reduce the field size to 32 bits. Signed-off-by: Simon Glass --- arch/mips/mach-ath79/ar934x/clk.c | 4 ++-- arch/mips/mach-octeon/cpu.c | 2 +- include/asm-generic/global_data.h | 4 ++-- 3 files changed, 5

[PATCH 22/35] global_data: Collect common fields at the top

2024-07-24 Thread Simon Glass
Move all the fields which are always present to the top of the struct, so we can potentially save some space by taking note of alignment. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 166 +++--- 1 file changed, 82 insertions(+), 84 deletions(-)

[PATCH 21/35] global_data: Drop spl_handoff

2024-07-24 Thread Simon Glass
Provide a function to locate this information, rather than doing it automatically on startup, to save space in global_data. Signed-off-by: Simon Glass --- arch/x86/cpu/intel_common/cpu_from_spl.c | 4 +--- arch/x86/lib/fsp2/fsp_dram.c | 4 ++-- cmd/sb.c

[PATCH 20/35] board_f: Move new_bloblist to boardf

2024-07-24 Thread Simon Glass
This value is only used before relocation. Move it to the new boardf struct. Signed-off-by: Simon Glass --- common/board_f.c | 11 ++- include/asm-generic/global_data.h | 4 include/board_f.h | 4 3 files changed, 10 insertions(+), 9

[PATCH 19/35] board_f: Move new_bootstage to boardf

2024-07-24 Thread Simon Glass
This value is only used before relocation. Move it to the new boardf struct. Signed-off-by: Simon Glass --- common/board_f.c | 10 +- include/asm-generic/global_data.h | 4 include/board_f.h | 4 3 files changed, 9 insertions(+), 9

[PATCH 18/35] board_f: Move fdt_size to board

2024-07-24 Thread Simon Glass
This value is only really used before relocation. There is not much use to showing its value in bdinfo, so drop it. Move it to the new boardf struct. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 1 - common/board_f.c | 11 +++

[PATCH 17/35] board_f: Add a new struct to hold pre-relocation info

2024-07-24 Thread Simon Glass
Quite a few of the members of struct global_data are only used before reloction, or have little meaning afterwards, yet they hang around in struct global_data for the lifetime of U-Boot. This uses up precious pre-relocation SRAM on many boards. To help with this, start a new struct which exists

[PATCH 16/35] global_data: Use less space for environment fields

2024-07-24 Thread Simon Glass
Use shorter types for some of these fields to save space. Reorder to put fields with like alignment together. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 14 +++--- include/env_internal.h| 1 + 2 files changed, 8 insertions(+), 7 deletions(-) diff

[PATCH 15/35] global_data: Drop pci_bootdelay

2024-07-24 Thread Simon Glass
This is not used. Drop the field and the environment code which uses it. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 11 --- include/env_default.h | 3 --- 2 files changed, 14 deletions(-) diff --git a/include/asm-generic/global_data.h

[PATCH 14/35] global_data: Drop global_data hose

2024-07-24 Thread Simon Glass
This is set on one x86 boards, but is not used anymore. Drop it. Signed-off-by: Simon Glass --- arch/x86/cpu/ivybridge/cpu.c | 5 - include/asm-generic/global_data.h | 8 +--- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/arch/x86/cpu/ivybridge/cpu.c

[PATCH 13/35] global_data: Remove pci_ram_top

2024-07-24 Thread Simon Glass
This field is set but not used. Drop it. Signed-off-by: Simon Glass --- arch/arm/mach-tegra/board2.c | 4 arch/arm/mach-tegra/cboot.c | 4 arch/x86/cpu/i386/cpu.c | 8 include/asm-generic/global_data.h | 10 -- 4 files changed, 26 deletions(-)

[PATCH 11/35] global_data: Drop fb_base

2024-07-24 Thread Simon Glass
This value mirrors information recorded by driver model video drivers, so can be removed to save space. Drop it. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/asm-generic/global_data.h

[PATCH 10/35] video: Avoid setting global_data fb_base in video setup

2024-07-24 Thread Simon Glass
This field is not used, so don't set it. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c index 1a2cde47a33..f75c0d4c937 100644 --- a/drivers/video/video-uclass.c +++

[PATCH 09/35] video: Avoid setting global_data fb_base from SPL handoff

2024-07-24 Thread Simon Glass
This field is not used, so don't set it. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c index cb3144f68e0..1a2cde47a33 100644 --- a/drivers/video/video-uclass.c +++

[PATCH 08/35] zynqmp: Avoid setting the framebuffer address

2024-07-24 Thread Simon Glass
This is handled by driver model so this driver should not be setting the framebuffer address. Drop the assignment. Signed-off-by: Simon Glass --- drivers/video/zynqmp/zynqmp_dpsub.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/zynqmp/zynqmp_dpsub.c

[PATCH 07/35] arm: ronetix: Avoid accessing global_data fb_base

2024-07-24 Thread Simon Glass
Use the new video function to get the framebuffer base. Signed-off-by: Simon Glass --- board/ronetix/pm9263/pm9263.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/board/ronetix/pm9263/pm9263.c b/board/ronetix/pm9263/pm9263.c index 1de1bd68701..8125f064cf1 100644 ---

[PATCH 06/35] arm: friendlyarm: Avoid accessing global_data fb_base

2024-07-24 Thread Simon Glass
Use the new video function to get the framebuffer base. Signed-off-by: Simon Glass --- board/friendlyarm/nanopi2/board.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/board/friendlyarm/nanopi2/board.c b/board/friendlyarm/nanopi2/board.c index

[PATCH 05/35] video: mxs: Avoid setting global_data fb_base

2024-07-24 Thread Simon Glass
This is not used, so don't set it. Signed-off-by: Simon Glass --- drivers/video/mxsfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 792d6314d15..e72839cead4 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -335,7

[PATCH 04/35] video: mxc: Avoid setting global_data fb_base

2024-07-24 Thread Simon Glass
This is not used, so don't set it. Signed-off-by: Simon Glass --- drivers/video/imx/mxc_ipuv3_fb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/imx/mxc_ipuv3_fb.c b/drivers/video/imx/mxc_ipuv3_fb.c index 039b22086a9..fdeb3cabea7 100644 ---

[PATCH 03/35] video: Add a function to obtain the framebuffer address

2024-07-24 Thread Simon Glass
Add a new function which returns the framebuffer address of the first video device. This will allow the global_data field top be dropped. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 14 ++ include/video.h | 11 +++ 2 files changed, 25

[PATCH 02/35] x86: Drop use of global_data fb_base

2024-07-24 Thread Simon Glass
This value is set by not used on x86 so there is no point in setting it. Drop the assignment. Signed-off-by: Simon Glass --- arch/x86/lib/fsp/fsp_graphics.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/lib/fsp/fsp_graphics.c b/arch/x86/lib/fsp/fsp_graphics.c index

[PATCH 01/35] global_data: Move pci_clk to m68k and powerpc

2024-07-24 Thread Simon Glass
Only m68k and powerpc use this field, so move it to the arch-specific info, to reduce the size for other archs. Signed-off-by: Simon Glass --- arch/m68k/cpu/mcf5445x/cpu.c | 2 +- arch/m68k/include/asm/global_data.h| 2 ++ arch/m68k/lib/bdinfo.c | 2 +-

Re: [PATCH 1/3] usb: dwc3: allocate setup_buf with dma_alloc_coherent()

2024-07-24 Thread Mattijs Korpershoek
Hi Neil, Thank you for the patch. On ven., juil. 19, 2024 at 15:56, Neil Armstrong wrote: > Also allocate the setup_buf with dma_alloc_coherent() since it's The subject of the patch says: "usb: dwc3: allocate setup_buf with dma_alloc_coherent()" Isn't this line just repeating the title? >

Re: [RFC PATCH v2 38/48] lib: Kconfig: add a config symbol for getting lmb memory map updates

2024-07-24 Thread Tom Rini
On Wed, Jul 24, 2024 at 08:37:14AM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 23 Jul 2024 at 08:20, Tom Rini wrote: > > > > On Tue, Jul 23, 2024 at 01:42:59PM +0100, Simon Glass wrote: > > > Hi Sughosh, > > > > > > On Mon, 22 Jul 2024 at 13:59, Sughosh Ganu > > > wrote: > > > > > > > > On

Re: [PATCH v2 02/14] spl: Correct use of CMD_BOOTI and CMD_BOOTZ

2024-07-24 Thread Simon Glass
Hi Quentin, On Mon, 22 Jul 2024 at 07:11, Quentin Schulz wrote: > > Hi Simon, > > On 7/21/24 5:25 PM, Simon Glass wrote: > > These should have a CONFIG_ prefix. Add it. > > > > Signed-off-by: Simon Glass > > Fixes: 7a0d88076b9 ("Add in the ability to load and boot an uncompr...") > >

Re: [PATCH] cmd: bcb: Fix segfault on invalid block device

2024-07-24 Thread Dmitrii Merkurev
Reviewed-by: Dmitrii Merkurev

Re: [ANN] U-Boot v2024.10-rc1 released

2024-07-24 Thread Simon Glass
Hi, On Tue, 23 Jul 2024 at 07:44, Frank Wunderlich wrote: > > Hi, > > i notice build-error because of CONFIG_TOOLS_MKEFICAPSULE is set automaticly > and does not find an include > > https://github.com/frank-w/u-boot/actions/runs/10059612312/job/27805232284 > > tools/mkeficapsule.c:20:10: fatal

Re: [RFC PATCH v2 38/48] lib: Kconfig: add a config symbol for getting lmb memory map updates

2024-07-24 Thread Simon Glass
Hi Tom, On Tue, 23 Jul 2024 at 08:20, Tom Rini wrote: > > On Tue, Jul 23, 2024 at 01:42:59PM +0100, Simon Glass wrote: > > Hi Sughosh, > > > > On Mon, 22 Jul 2024 at 13:59, Sughosh Ganu wrote: > > > > > > On Mon, 22 Jul 2024 at 18:00, Ilias Apalodimas > > > wrote: > > > > > > > > On Fri, 5 Jul

Re: [PATCHv1 1/5] cpu: add release_core callback

2024-07-24 Thread Simon Glass
Hi Zhiqiang, On Tue, 23 Jul 2024 at 08:43, Zhiqiang Hou wrote: > > From: Hou Zhiqiang > > Add a new callback release_core to the cpu_ops, which is used to > release a CPU core to run baremetal or RTOS application on a SoC > with multiple CPU cores. > > Signed-off-by: Hou Zhiqiang > --- >

Re: [PATCH v2 1/1] tpm: call tpm_tis_wait_init() after tpm_tis_init()

2024-07-24 Thread Simon Glass
On Wed, 24 Jul 2024 at 02:56, Ilias Apalodimas wrote: > > Thanks Lukas, > > On Wed, 24 Jul 2024 at 10:35, wrote: > > > > From: Lukas Funke > > > > tpm_tis_wait_init() is using the 'chip->timeout_b' field which is > > initialized in tpm_tis_init(). However, the init-function is called > >

Re: [PATCH] doc: Add a description for bootmeth_android

2024-07-24 Thread Simon Glass
On Wed, 24 Jul 2024 at 06:41, Mattijs Korpershoek wrote: > > Add initial documentation for the Android bootmeth. > > Signed-off-by: Mattijs Korpershoek > --- > MAINTAINERS | 1 + > doc/develop/bootstd/android.rst | 39 +++ >

Re: [PATCH v4 00/29] Integrate MbedTLS v3.6 LTS with U-Boot

2024-07-24 Thread Simon Glass
Hi Raymond, On Wed, 24 Jul 2024 at 08:35, Raymond Mao wrote: > > Hi Tom, > > On Tue, 2 Jul 2024 at 21:26, Tom Rini wrote: >> >> On Tue, Jul 02, 2024 at 11:22:36AM -0700, Raymond Mao wrote: >> >> > Integrate MbedTLS v3.6 LTS (currently v3.6.0-RC1) with U-Boot. >> > >> > Motivations: >> >

Re: [PATCH v4 00/29] Integrate MbedTLS v3.6 LTS with U-Boot

2024-07-24 Thread Simon Glass
Hi Raymond, On Tue, 23 Jul 2024 at 14:45, Tom Rini wrote: > > On Tue, Jul 23, 2024 at 03:24:29PM -0400, Raymond Mao wrote: > > Hi Tom, > > > > On Tue, 2 Jul 2024 at 21:26, Tom Rini wrote: > > > > > On Tue, Jul 02, 2024 at 11:22:36AM -0700, Raymond Mao wrote: > > > > > > > Integrate MbedTLS v3.6

Re: [PATCH v4 00/29] Integrate MbedTLS v3.6 LTS with U-Boot

2024-07-24 Thread Raymond Mao
Hi Tom, On Tue, 2 Jul 2024 at 21:26, Tom Rini wrote: > On Tue, Jul 02, 2024 at 11:22:36AM -0700, Raymond Mao wrote: > > > Integrate MbedTLS v3.6 LTS (currently v3.6.0-RC1) with U-Boot. > > > > Motivations: > > > > > > 1. MbedTLS is well maintained with LTS versions. > > 2. LWIP is

Re: [PATCH v3 7/7] usb: gadget: atmel: Add DM_USB_GADGET support

2024-07-24 Thread admin LI
Hi Mattijs, On Wed, Jul 24, 2024 at 12:12 PM Mattijs Korpershoek wrote: > > Checkpatch complains here: > > checkpatch.pl: 164: WARNING: From:/Signed-off-by: email address mismatch: > 'From: Zixun LI ' != 'Signed-off-by: Zixun LI > ' > > Please make sure that the commiter matches the

Re: [PATCH v2] tools: Add script to update git subtree projects

2024-07-24 Thread Raymond Mao
Hi Sumit, On Wed, 24 Jul 2024 at 03:08, Sumit Garg wrote: > Hi Raymond, > > Thanks for doing this. > > On Tue, 23 Jul 2024 at 01:01, Raymond Mao wrote: > > > > Recently we are introducing multiple git subtree projects and > > it is the right time to have a universal script to update > >

Re: [PATCH 1/1] efi_loader: correct check in efi_load_option_dp_join()

2024-07-24 Thread Ilias Apalodimas
On Wed, 24 Jul 2024 at 16:26, Heinrich Schuchardt wrote: > > After assigning to *dp we must check this value and not dp. > > Addresses-Coverity-ID: 501792 Control flow issues (DEADCODE) > Fixes: 58bef195f94e ("cmd: eficonfig: add support for setting fdt") > Signed-off-by: Heinrich Schuchardt >

[PATCH 1/1] efi_loader: correct check in efi_load_option_dp_join()

2024-07-24 Thread Heinrich Schuchardt
After assigning to *dp we must check this value and not dp. Addresses-Coverity-ID: 501792 Control flow issues (DEADCODE) Fixes: 58bef195f94e ("cmd: eficonfig: add support for setting fdt") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_helper.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v2 0/5] bootstd: Add Android support

2024-07-24 Thread Mattijs Korpershoek
On mar., juin 18, 2024 at 21:03, Simon Glass wrote: > Hi Mattijs, > > On Mon, 17 Jun 2024 at 09:15, Mattijs Korpershoek > wrote: >> >> Hi Simon, >> >> On lun., juin 17, 2024 at 07:53, Simon Glass wrote: >> >> > Hi Mattijs, >> > >> > On Thu, 13 Jun 2024 at 04:13, Mattijs Korpershoek >> >

[PATCH] doc: Add a description for bootmeth_android

2024-07-24 Thread Mattijs Korpershoek
Add initial documentation for the Android bootmeth. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + doc/develop/bootstd/android.rst | 39 +++ doc/develop/bootstd/index.rst| 1 + doc/develop/bootstd/overview.rst | 2 +- 4

Re: [PATCH v7 0/3] Introduce mtdblock device

2024-07-24 Thread Alexey Romanov
Hi Michael, Sorry for the late reply. On Fri, Jul 19, 2024 at 08:57:04AM +0200, Michael Walle wrote: > Hi, > > > Tested only on SPI NAND, so bind is made only for > > SPI NAND drivers. > > If tried to test this with the SPI NOR framework but I couldn't get > it to work. The SPI NOR flash

[PATCH v2] test/py: spi: Add tests for SPI flash device

2024-07-24 Thread Love Kumar
Add test cases for sf commands to verify various SPI flash operations such as erase, write and read. It also adds qspi lock unlock cases. This test relies on boardenv_* configurations to run it for different SPI flash family such as single SPI, QSPI, and OSPI. Signed-off-by: Love Kumar ---

Re: [PATCH 3/3] i2c: imx_lpi2c: Support read transfers longer than 256 bytes

2024-07-24 Thread Marek Vasut
On 7/24/24 11:59 AM, fedorr...@gmail.com wrote: From: Fedor Ross The TXFIFO register of LPI2C only has one byte length, and if the length of the data that needs to be read exceeds 256 bytes, it needs to be written to TXFIFO multiple times. Signed-off-by: Fedor Ross Add --- Cc: Heiko

Re: [PATCH 2/3] i2c: imx_lpi2c: Replace hard-coded bus speed value with bus->speed_hz

2024-07-24 Thread Marek Vasut
On 7/24/24 11:59 AM, fedorr...@gmail.com wrote: From: Fedor Ross Instead of using the hard-coded bus speed value I2C_SPEED_STANDARD_RATE, use the actual configured bus speed. This way the bus speed doesn't change suddenly after calling the imx_lpi2c_probe_chip() function for example.

Re: [PATCH 1/3] i2c: imx_lpi2c: Fix a typo in bus_i2c_receive

2024-07-24 Thread Marek Vasut
On 7/24/24 11:59 AM, fedorr...@gmail.com wrote: From: Fedor Ross Fix a typo in a debug message. It should be 'for' not 'fot' . Signed-off-by: Fedor Ross Please add '---' here for V2, so the CC list does not get included in commit message when the patch is applied. Cc: Heiko Schocher

Re: [PATCH v3 7/7] usb: gadget: atmel: Add DM_USB_GADGET support

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch and doing this very welcome DM_USB_GADGET addition :) On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > Add driver model support by using the uclass UCLASS_USB_GADGET_GENERIC. > > Disable local usb_gadget_register_driver()/usb_gadget_unregister_driver() >

Re: [PATCH v2 0/5] arm: exynos: Enable TRNG for E850-96 board

2024-07-24 Thread Minkyu Kang
Hi, 2024년 7월 24일 (수) 03:23, Sam Protsenko 님이 작성: > [snip] > > > > > Your patch was failed to apply to u-boot-samsung due to the > e850-96_defconfig. > > please rebase the patch. > > > > Just sent v3, please take a look. > > > and about mmc patches, those have delegated to mmc maintainers. > > >

Re: [PATCH v3 0/5] arm: exynos: Enable TRNG for E850-96 board

2024-07-24 Thread Minkyu Kang
Hi, 2024년 7월 24일 (수) 03:14, Sam Protsenko 님이 작성: > This series enables True Random Number Generator (TRNG) for E850-96 > board. Here is a short breakdown of features implemented in this series: > > 1. Load LDFW (Loadable Firmware) on E850-96 board. It's needed to make > TRNG SMC commands

Re: [PATCH v3 6/7] usb: gadget: atmel: Add attach/detach support

2024-07-24 Thread Mattijs Korpershoek
On mar., juil. 23, 2024 at 15:36, Marek Vasut wrote: > On 7/23/24 3:18 PM, Zixun LI wrote: >> Add controller attach/detach support by using >> usb_gadget_ops.pullup() method. > > It is called 'function' in C, not 'method'. I think 'method' is C++ or > maybe Java ? Agreed, 'function' is more

Re: [PATCH v3 6/7] usb: gadget: atmel: Add attach/detach support

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > Add controller attach/detach support by using > usb_gadget_ops.pullup() method. > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/atmel_usba_udc.c | 18

Re: [PATCH v3 5/7] usb: gadget: atmel: Rename atmel_usba_start()/_stop() to usba_udc_enable()/_disable()

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > Rename atmel_usba_start() / atmel_usba_stop() to usba_udc_enable() > / usba_udc_disable(), remove atmel_ prefix to be inline with other > functions. Also avoid confusion with DM start() / stop() functions. >

Re: [PATCH v3 4/7] usb: gadget: atmel: Move usba_udc_pdata() with other static functions

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > To make all static functions in the top, no functional change. > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/atmel_usba_udc.c | 80 ++---

Re: [PATCH v3 3/7] usb: gadget: atmel: Fix typo in usb_gadget_register_driver()

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > Replace "paramter" by "parameter". > > Signed-off-by: Zixun LI Same remark on checkpatch warning: WARNING: From:/Signed-off-by: email address mismatch: 'From: Zixun LI ' != 'Signed-off-by: Zixun LI ' >

Re: [PATCH v3 2/7] usb: gadget: atmel: Replace printf() and pr_err() by log_err()

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > To have a uniform printing function, also drop linux/printk.h as no > longer used. > > Signed-off-by: Zixun LI Checkpatch complains here: checkpatch.pl: 164: WARNING: From:/Signed-off-by: email address

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-07-24 Thread Heinrich Schuchardt
Am 24. Juli 2024 11:56:17 MESZ schrieb Mattijs Korpershoek : >Hi Heinrich, > >On mer., juil. 24, 2024 at 11:45, Heinrich Schuchardt >wrote: > >> On 24.07.24 11:21, Mattijs Korpershoek wrote: >>> Hi Tom, >>> >>> Thank you for the report. >>> >>> On mar., juil. 23, 2024 at 08:18, Tom Rini

Re: [PATCH v3 1/7] usb: gadget: atmel: Sort includes

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > Sort includes in alphabetical order. > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/atmel_usba_udc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3

[PATCH 3/3] i2c: imx_lpi2c: Support read transfers longer than 256 bytes

2024-07-24 Thread fedorross
From: Fedor Ross The TXFIFO register of LPI2C only has one byte length, and if the length of the data that needs to be read exceeds 256 bytes, it needs to be written to TXFIFO multiple times. Signed-off-by: Fedor Ross Cc: Heiko Schocher Cc: Tom Rini Cc: Marek Vasut ---

[PATCH 2/3] i2c: imx_lpi2c: Replace hard-coded bus speed value with bus->speed_hz

2024-07-24 Thread fedorross
From: Fedor Ross Instead of using the hard-coded bus speed value I2C_SPEED_STANDARD_RATE, use the actual configured bus speed. This way the bus speed doesn't change suddenly after calling the imx_lpi2c_probe_chip() function for example. Signed-off-by: Fedor Ross Cc: Heiko Schocher Cc: Tom

[PATCH 1/3] i2c: imx_lpi2c: Fix a typo in bus_i2c_receive

2024-07-24 Thread fedorross
From: Fedor Ross Fix a typo in a debug message. It should be 'for' not 'fot' . Signed-off-by: Fedor Ross Cc: Heiko Schocher Cc: Tom Rini Cc: Marek Vasut --- drivers/i2c/imx_lpi2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/imx_lpi2c.c

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-07-24 Thread Mattijs Korpershoek
Hi Heinrich, On mer., juil. 24, 2024 at 11:45, Heinrich Schuchardt wrote: > On 24.07.24 11:21, Mattijs Korpershoek wrote: >> Hi Tom, >> >> Thank you for the report. >> >> On mar., juil. 23, 2024 at 08:18, Tom Rini wrote: >> >>> Here's the latest report. >>> >>> -- Forwarded message

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-07-24 Thread Mattijs Korpershoek
On mer., juil. 24, 2024 at 11:21, Mattijs Korpershoek wrote: > Hi Tom, > > Thank you for the report. > > On mar., juil. 23, 2024 at 08:18, Tom Rini wrote: > >> Here's the latest report. >> >> -- Forwarded message - >> From: >> Date: Mon, Jul 22, 2024, 8:07 PM >> Subject: New

[PATCH] cmd: bcb: Fix segfault on invalid block device

2024-07-24 Thread Mattijs Korpershoek
When blk_get_dev() fails, block NULL and gets de-referenced in the error path by a printf(), resulting in a crash. This can be reproduced on sandbox with: $ ./u-boot --command "bcb load mmc 0 0" Fix the message by using the functions arguments (iface, devnum) instead. Note: partition (being a

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-07-24 Thread Heinrich Schuchardt
On 24.07.24 11:21, Mattijs Korpershoek wrote: Hi Tom, Thank you for the report. On mar., juil. 23, 2024 at 08:18, Tom Rini wrote: Here's the latest report. -- Forwarded message - From: Date: Mon, Jul 22, 2024, 8:07 PM Subject: New Defects reported by Coverity Scan for Das

Re: [PATCH V2] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present for gate and mux

2024-07-24 Thread Michael Nazzareno Trimarchi
Hi Sam On Wed, Jul 24, 2024 at 9:25 AM Michael Nazzareno Trimarchi wrote: > > Hi Sam > > On Tue, Jul 23, 2024 at 10:37 PM Sam Protsenko > wrote: > > > > On Fri, Jul 5, 2024 at 2:14 AM Michael Trimarchi > > wrote: > > > > > > Gate and mux does not have .set_rate operation, but they could have >

Re: [PATCH v5 01/11] efi: define struct efi_guid

2024-07-24 Thread Ilias Apalodimas
On Fri, 19 Jul 2024 at 15:43, Caleb Connolly wrote: > > This let's us forward declare efi_guid_t in the UUID code without > pulling in efi.h > > Signed-off-by: Caleb Connolly > --- > include/efi.h | 2 +- > tools/eficapsule.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >

  1   2   3   4   5   6   7   8   9   10   >