Re: [PATCH v2 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568

Hi Alper， The Synopsys DWC MSHC for RK3568 and RK3588 need config DWCMSHC_EMMC_CONTROL.bit0 = 1 （CARD_IS_EMMC） to enable Data Strobe pin for HS400 and HS400ES. reference code: #define DWCMSHC_EMMC_CONTROL 0x52c #define DWCMSHC_CARD_IS_EMMC BIT(0) /* set CARD_IS_EMMC bit to enable Data Strobe for

Re: Re: [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400

Hi Jaehoon > Just wonder about doesn't it affect to other mode? The strobe line will only be used in hs400 mode and will not affect other modes. Best Regards, Yifeng Zhao > On 10/15/21 5:41 PM, Yifeng Zhao wrote: > The default configuration of rk3399 EMMC PHY does not enable the > strobe lin

Re: Re: [PATCH v2 1/3] mmc: rockchip_sdhci: add phy and clock config for rk3399

Hi Jaehoon, >RK_CLRSETBITS macro is (((clr) | (set))) << 16) | (set). >Which bit is cleared? When (7 << 4) is set, it means that cleared? Yes, this ops clear the bit4-bit6. >> + >> +if (opcode == MMC_CMD_SEND_TUNING_BLOCK_HS200 && >> host->mmc->bus_width == 8) >> +

Re: Re: [PATCH v2 2/3] mmc: rockchip_sdhci: Add support for RK3568

Hi Jeahoon, >On 6/28/21 6:19 PM, Yifeng Zhao wrote: >> This patch adds support for the RK3568 platform to this driver. >> >> Signed-off-by: Yifeng Zhao >> --- >> >> Changes in v2: >> - Used sdhci_set_clock api to set clock. >> - Used read_poll_timeout api to check dll s

Re: Re: [PATCH v1 1/2] mmc: rockchip_sdhci: add phy and clock config for rk3399

Hi Jaehoon, > Does it impossible to move to phy subsystem about codes relevant to phy? I already check the mmc code, but I didn't find that the sdhci framework supports the PHY interface. It would be troublesome to support it. At present, only the EMMC of rk3399 has PHY, while rk3568 only has som