On 2023-01-19 11:47, Sumit Garg wrote:
On Mon, 16 Jan 2023 at 06:04, Alexey Minnekhanov
wrote:
Now that reg-names is required, specify them, and use correct
addresses for SPMI arbiter regs, taken from Linux dts [1] [2].
[1]
https://elixir.bootlin.com/linux/v6.1.5/source/arch/arm64/boot/dts
On 2023-01-19 11:44, Sumit Garg wrote:
On Mon, 16 Jan 2023 at 06:04, Alexey Minnekhanov
wrote:
Update spmi-msm documentation and example to reflect the current
state of the driver.
Since our long term goal is to align with Linux DT bindings and use
the DTS imported from Linux as is. So we
On 2023-01-19 11:36, Sumit Garg wrote:
On Mon, 16 Jan 2023 at 06:03, Alexey Minnekhanov
wrote:
...
- config_addr = dev_read_addr_index(dev, 0);
- priv->spmi_core = dev_read_addr_index(dev, 1);
- priv->spmi_obs = dev_read_addr_index(dev, 2);
+ /* DTS bindings: reg
Hi!
On 2023-01-19 20:18, Dzmitry Sankouski wrote:
GPIO button driver requires direction functions to probe
button gpio. Those functions are blank, since pwrkey gpio
configured earlier not by u-boot.
...
+/*
+ * Power button already configured as input by previous bootloader.
+ */
+static
t variable was introduced, it was not used
in read/write operations in that function. Fix this inconsistency,
use calculated ch_offset instead of SPMI_CH_OFFSET(..).
Fixes: f5a2d6b4b03a ("spmi: msm: add arbiter version 5 support")
Signed-off-by: Alexey Minnekhanov
---
drivers/spmi/spmi-msm.c | 19 ++
/sdm845.dtsi#L4896
Signed-off-by: Alexey Minnekhanov
---
arch/arm/dts/qcs404-evb.dts | 7 ---
arch/arm/dts/sdm845.dtsi| 8
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/arch/arm/dts/qcs404-evb.dts b/arch/arm/dts/qcs404-evb.dts
index 0639af8fe336..6bf6736139ed
Update spmi-msm documentation and example to reflect the current
state of the driver.
Signed-off-by: Alexey Minnekhanov
---
doc/device-tree-bindings/spmi/spmi-msm.txt | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/doc/device-tree-bindings/spmi/spmi
as Linux driver, use core reg to read version
from [1]. This fixes reading incorrect arbiter version.
Third, print addresses in hex, so it can be visually
compared to values in DTS more easily.
[1]:
https://elixir.bootlin.com/linux/v6.1.6/source/drivers/spmi/spmi-pmic-arb.c#L1339
Signed-off-by: Alexey
Variable err is never initialized and therefore not needed,
as well as the whole error handler block; the mentioned
"APID->PPID mapping table" is never read in the code anyways.
Signed-off-by: Alexey Minnekhanov
---
drivers/spmi/spmi-msm.c | 6 --
1 file changed, 6 deletions(-
In the process of porting my board to u-boot I've noticed incorrect
behaviour, some things that clearly look wrong, and other strange
things. Here go several fixes to MSM SPMI driver, mostly related
to newer platforms support.
Alexey Minnekhanov (5):
spmi: msm: Remove wrong and unused code
register sets inside msm uartdm?
I'm also using u-boot as chain-loaded boot loader, so I'm using uart as
it was configured by previous stage boot loader. Maybe which registers
to use depends on how the controller was initially configured?
---
Regards,
Alexey Minnekhanov
11 matches
Mail list logo
