Hi,
> So this whole mode handling here looks dodgy. Below you mix "assignments
> to mode" with "ORing in values", without actually ever initialising mode
> explicitly. I wonder why the compiler doesn't warn about this, I can see
> paths were you OR into an uninitialised value.
>
> But the compile
>
> Can I load the modified u-boot binary from the currently running u-boot
> command line?
>
Yes, U-boot supports chain loading.
On host machine you can use ckermit[1] program to load U-boot image using
serial or you can
use tftp to load modified U-boot image at SYS_TEXT_BASE address.
Once the i
Well, you tell me! At the moment I don't see much preventing people from
> enabling it on the S900, and your compatible string listing in the
> driver includes the S900 one.
>
I just checked, it's DMA descriptor structure that differs between two but
I think
This is not relevant here.
Only thing
Hi,
Thanks again for the detailed review
+
> > 3 files changed, 407 insertions(+)
> > create mode 100644 drivers/mmc/owl_mmc.c
> >
> > diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
> > index 14d7913..61f9c67 100644
> > --- a/drivers/mmc/
Hi Jaehoon
I had already mentioned about making more readable than now.
>
> if (rate <= 100) {
> rdelay = wdelay = OWL_SD_DELAY_LOW_CLK;
> } else if ( ...) {
> rdelay = wdelay = OWL_SD_DELAY_MID_CLK;
> } else if () {
> rdelay = OWL_SD_RDELAY_HIGH;
> wdelay
On Wed, Dec 23, 2020 at 4:58 AM Jaehoon Chung
wrote:
> On 12/19/20 11:51 PM, Amit Singh Tomar wrote:
> > From: Amit Singh Tomar
> >
> > This patch adds node for ethernet controller found on Action Semi OWL
> > S700 SoC.
>
> Is "ethernet controller" right?
>
It gets picked from one of earlier co
Hi,
You could pass a pointer to owl_mmc_priv here, which can hold both those
> values. See below for more more on this.
>
> Did you mean for argument 3rd and 4th but then in that case how one could
have differentiated
between source and destination.
for instance 3rd and 4th arguments are differe
Hi Jaehoon
Thanks for having a look and providing the comments
Order to the bit number.
Ok, Sure
>
> > +
> > +#define OWL_MMC_OCR (MMC_VDD_32_33 | MMC_VDD_33_34
> | \
> > + MMC_VDD_165_195)
> > +
> > +#define DATA_TRANSFER_TIMEOUT
Hi,
>
> NOTE: GNU binutils starting with v2.27.1 do this build-time relocation
> automatically, to be in-line with other architecures. So on newer
> toolchains our manual fixup is actually not needed. It doesn't hurt to
> have it, though, so that we keep compatibility with the popular Linaro
> too
>
> >
> > I tried testing this series but don't see any output while loading
> > U-Boot from ROM:
> >
> > # ./qemu-system-aarch64 -M virt -cpu cortex-a57 -nographic -smp 1 -bios
> > u-boot.bin
>
> TF-A runs at EL3 so you should test with
> -machine virt,secure=true,virtualization=true
>
> The bios
>
> Did you regenerate the .config? Otherwise, CONFIG_INIT_SP_RELATIVE may
> still be enabled.
>
I cloned a fresh U-boot source (with top commit 55004fa43364e) , and the
top of it applied these patches.
After generating the .config using "qemu_arm64_defconfig" where
CONFIG_INIT_SP_RELATIVE is disa
Hi,
Andre Przywara (5):
> arm64: PIE: Skip fixups if distance is zero
> arm64: PIE: Allow fixed stack pointer
> qemu-arm: Remove need to specify flash banks
> qemu: Drop ARCH_SUPPORT_TFABOOT
> qemu/arm64: Enable POSITION_INDEPENDENT
>
> arch/arm/Kconfig | 4 ++--
> arch/arm
12 matches
Mail list logo
