next
post onwards.
And what was changed between versions of this patch?
You are supposed to put a change log below the --- line that
explains which changes were made to the previous version of the patch.
Accepted.
Should I send the patch again with version updated?
Regards,
Amul Kumar
Hi Scott,
On Fri, Nov 06, 2009 at 05:17:44PM +0530, Amul Kumar Saha wrote:
- printk(Bad blocks %d at 0x%x\n,
-(u32)(ofs this-erase_shift), (u32)ofs);
+ printk(Bad blocks %lu at 0x%x\n,
+(u32)onenand_block(this, ofs), (u32)ofs);
cmd_onenand.c: In function
Add command for changing Flex-OneNAND SLC / MLC boundary.
Also onenand commands work for Flex-OneNAND.
Signed-off-by: Rohit Hagargundgi h.ro...@samsung.com
Signed-off-by: Amul Kumar Saha amul.s...@samsung.com
---
common/cmd_onenand.c | 106
Define and use CONFIG_ENV_ADDR_FLEX and CONFIG_ENV_SIZE_FLEX
for storing environment variables.
Signed-off-by: Rohit Hagargundgi h.ro...@samsung.com
Signed-off-by: Amul Kumar Saha amul.s...@samsung.com
---
common/env_onenand.c | 10 ++
include/configs/apollon.h |2 ++
2 files
Add command for changing Flex-OneNAND SLC / MLC boundary.
Also onenand commands work for Flex-OneNAND.
Signed-off-by: Rohit Hagargundgi h.ro...@samsung.com
Signed-off-by: Amul Kumar Saha amul.s...@samsung.com
---
common/cmd_onenand.c | 90
Hi Scott,
You seem to have stripped a copyright notice that was added in the Linux
version of patch 1/3.
Updated in the current patch.
Regards,
Amul Kumar Saha
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u
-boot doesn't
need, or something else?
Yes, there are certain functionalities that OneNAND doesn't need in U-Boot.
Sending the updated patches.
Regards,
Amul Kumar Saha
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo
.
Patch 3/3: Flex-OneNAND SLC / MLC boundary setting.
Regards,
Amul Kumar Saha
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Add command for changing Flex-OneNAND SLC / MLC boundary.
Also onenand commands work for Flex-OneNAND.
Signed-off-by: Rohit Hagargundgi h.ro...@samsung.com
Signed-off-by: Amul Kumar Saha amul.s...@samsung.com
---
common/cmd_onenand.c | 90
This patch adds support for Flex-OneNAND devices.
Signed-off-by: Rohit Hagargundgi h.ro...@samsung.com
Signed-off-by: Amul Kumar Saha amul.s...@samsung.com
---
drivers/mtd/onenand/onenand_base.c | 733 +++-
drivers/mtd/onenand/onenand_bbt.c | 14
drivers/mtd
Define and use CONFIG_ENV_ADDR_FLEX and CONFIG_ENV_SIZE_FLEX
for storing environment variables.
Signed-off-by: Rohit Hagargundgi h.ro...@samsung.com
Signed-off-by: Amul Kumar Saha amul.s...@samsung.com
---
common/env_onenand.c | 10 ++
include/configs/apollon.h |2 ++
2 files
Hi Scott,
I believe that typecasting a UL to an int, is OK.
Do let me know.
The compiler will implicitly cast unsigned long to int. The explicit cast
is unnecessary clutter which makes it harder to find casts that aren't OK.
Accepted and changed.
Thank You
Amul.
Hi Scott,
+ int blocks = (int) onenand_block(this, from + len)
+- onenand_block(this, from);
Why the (int) cast? onenand_block() already returns int.
Resolved
- if (end_block (mtd-size this-erase_shift))
- end_block = mtd-size this-erase_shift;
+ if (end_block
a hard
time following it.
Documented the above section in function header.
This patch adds support for MLC OneNAND and Flex-OneNAND devices.
Thank You,
Amul Kumar Saha
Signed-off-by: Rohit Hagargundgi h.rohit at samsung.com
Signed-off-by: Amul Kumar Saha amul.saha at samsung.com
14 matches
Mail list logo
