Re: [PATCH v2 13/14] rockchip: Enable bootstage on rockpro64

2023-02-11 Thread Andrew Abbott
On Sun, Jan 8, 2023, at 08:57, Simon Glass wrote: > This board is useful for benchmarking overall U-Boot performance. Enable > the bootstage feature so we get a report. > > Since this returns to the boot rom before finishing executing > board_init_r() in SPL, add a few bootstage calls so that we c

Re: [RFC PATCH v2 6/8] rockchip: Enable binman for ARM64

2022-05-21 Thread Andrew Abbott
On Thu May 19, 2022 at 9:37 PM AEST, Alper Nebi Yasak wrote: > On 16/05/2022 14:07, Andrew Abbott wrote: > > Binman is now being used to build the final flashable images for > > Rockchip devices, thus enabling it for all Rockchip targets here. But > > it is not yet being use

Re: [RFC PATCH v2 2/8] rockchip: Add binman definitions for final images

2022-05-21 Thread Andrew Abbott
On Thu May 19, 2022 at 9:36 PM AEST, Alper Nebi Yasak wrote: > > For RK3399 targets: > > > > - u-boot.rom > > - SPI image specific to the bob Chromebook target (see > > c4cea2bbf995764f325a907061c22ecd6768cf7b). > > I'm not sure we need anything special for the rk3399 chromebooks. I > th

Re: [RFC PATCH v2 1/8] binman: mkimage: Support ':'-separated inputs

2022-05-21 Thread Andrew Abbott
On Thu May 19, 2022 at 9:36 PM AEST, Alper Nebi Yasak wrote: > Also see another attempt for this [1] and the comments to that for a > more complete picture, though I'll try writing all the points here anyway. > > [1] binman: support mkimage separate files > https://lore.kernel.org/u-boot/2022030419

Re: [RFC PATCH v2 0/8] Build Rockchip final images using binman

2022-05-21 Thread Andrew Abbott
On Thu May 19, 2022 at 9:35 PM AEST, Alper Nebi Yasak wrote: > > - I noticed that ATF generation for ARM64 Rockchip is done via a Python > > script > > instead of binman. I don't currently know how to change that over to > > binman, > > but is that something worth pursuing as part of this? >

Re: [RFC PATCH v2 0/8] Build Rockchip final images using binman

2022-05-19 Thread Andrew Abbott
Hi Jerome, On Tue May 17, 2022 at 1:13 AM AEST, Jerome Forissier wrote: > I use this kind of configuration on ROCKPi 4B (U-Boot with TF-A BL31 and > OP-TEE), > so I could at least run some tests. Please note that I recently sent a patch > to > fix the OP-TEE support in make_fit_atf.py [1]. That

[RFC PATCH v2 7/8] doc: rockchip: Update for new binman image generation

2022-05-16 Thread Andrew Abbott
Update the Rockchip documentation for image generation with binman, including the new automatically-created SPI image. Signed-off-by: Andrew Abbott --- Changes in v2: - Remove note from docs about different offsets in SPI flash for different SoCs - this was a bad assumption on my part, it

[RFC PATCH v2 8/8] board: rockpro64: Enable building SPI image

2022-05-16 Thread Andrew Abbott
Using the new SPI image generation, build an image for the Pine64 ROCKPro64 board. Signed-off-by: Andrew Abbott --- (no changes since v1) arch/arm/mach-rockchip/rk3399/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-rockchip/rk3399/Kconfig b/arch/arm/mach-rockchip

[RFC PATCH v2 6/8] rockchip: Enable binman for ARM64

2022-05-16 Thread Andrew Abbott
Binman is now being used to build the final flashable images for Rockchip devices, thus enabling it for all Rockchip targets here. But it is not yet being used to generate the FIT image (u-boot.itb), thus we need to force it to be built. Signed-off-by: Andrew Abbott --- Question: Will this

[RFC PATCH v2 4/8] board: rockchip: Move SPI U-Boot offset to config

2022-05-16 Thread Andrew Abbott
_SYS_SPI_U_BOOT_OFFS', so this change should not functionally change the offset for any of the affected boards. Signed-off-by: Andrew Abbott --- (no changes since v1) arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi | 1 - arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 4 arch/arm/dts/rk339

[RFC PATCH v2 5/8] rockchip: Remove obsolete Makefile targets

2022-05-16 Thread Andrew Abbott
These are obsoleted by a previous patch which added binman image definitions for Rockchip SD/MMC and SPI images. Signed-off-by: Andrew Abbott --- (no changes since v1) Makefile | 31 +++ 1 file changed, 3 insertions(+), 28 deletions(-) diff --git a/Makefile b

[RFC PATCH v2 2/8] rockchip: Add binman definitions for final images

2022-05-16 Thread Andrew Abbott
flash image, in addition to the generic SD/MMC image. Signed-off-by: Andrew Abbott --- Question: Does this break/not play nicely with rockchip-optee generation? It creates u-boot.itb for rk3288 targets. That would need to run before what I've implemented here? Changes in v2: - Revert u-boot-roc

[RFC PATCH v2 3/8] soc: rockchip: Include common U-Boot dtsi file

2022-05-16 Thread Andrew Abbott
This pulls in binman definitions so images can be built for all Rockchip platforms. Signed-off-by: Andrew Abbott --- (no changes since v1) arch/arm/dts/rk3308-u-boot.dtsi | 2 ++ arch/arm/dts/rk3328-u-boot.dtsi | 2 ++ arch/arm/dts/rk3368-u-boot.dtsi | 1 + arch/arm/dts/rk3568-u-boot.dtsi | 2

[RFC PATCH v2 1/8] binman: mkimage: Support ':'-separated inputs

2022-05-16 Thread Andrew Abbott
ned-off-by: Andrew Abbott --- This is a bit of a messy implementation for now and would probably break existing uses of mkimage that rely on the concatenation behaviour. Questions: - Should this be a separate entry type, or an option to the mkimage entry type that enables this behaviour? - What kind

[RFC PATCH v2 0/8] Build Rockchip final images using binman

2022-05-16 Thread Andrew Abbott
part, it doesn't work this way. - Update name of SD/MMC image in the docs from u-boot-rockchip-sdmmc.bin to u-boot-rockchip.bin. Andrew Abbott (8): binman: mkimage: Support ':'-separated inputs rockchip: Add binman definitions for final images soc: rockchip: Include com

Re: [RFC PATCH 2/8] rockchip: Add binman definitions for final images

2022-05-04 Thread Andrew Abbott
On Wed Apr 27, 2022 at 7:22 PM AEST, Johan Jonker wrote: > Hi, > > This name "u-boot-rockchip.bin"is in use in user space scripts and shows > up in examples on the web. No desire for yet another naming variant. > What you change must give exact the same result as we had in the > existing situation

[RFC PATCH 8/8] board: rockpro64: Enable building SPI image

2022-04-24 Thread Andrew Abbott
Signed-off-by: Andrew Abbott --- arch/arm/mach-rockchip/rk3399/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-rockchip/rk3399/Kconfig b/arch/arm/mach-rockchip/rk3399/Kconfig index c1f251316c..4a049935df 100644 --- a/arch/arm/mach-rockchip/rk3399/Kconfig +++ b/arch/arm

[RFC PATCH 6/8] rockchip: Enable binman for ARM64

2022-04-24 Thread Andrew Abbott
Binman is now being used to build the final flashable images for Rockchip devices, thus enabling it for all Rockchip targets here. But it is not yet being used to generate the FIT image (u-boot.itb), thus we need to force it to be built. Signed-off-by: Andrew Abbott --- Question: Will this

[RFC PATCH 7/8] doc: rockchip: Update for new binman image generation

2022-04-24 Thread Andrew Abbott
Signed-off-by: Andrew Abbott --- doc/board/rockchip/rockchip.rst | 34 +++-- 1 file changed, 11 insertions(+), 23 deletions(-) diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst index 4ca7b00b1f..1639ce4f72 100644 --- a/doc/board/rockchip

[RFC PATCH 5/8] rockchip: Remove obsolete Makefile targets

2022-04-24 Thread Andrew Abbott
These are obsoleted by a previous patch which added binman image definitions for Rockchip SD/MMC and SPI images. Signed-off-by: Andrew Abbott --- Makefile | 31 +++ 1 file changed, 3 insertions(+), 28 deletions(-) diff --git a/Makefile b/Makefile index 7937a4cfd3

[RFC PATCH 4/8] board: rockchip: Move SPI U-Boot offset to config

2022-04-24 Thread Andrew Abbott
_SYS_SPI_U_BOOT_OFFS', so this change should not functionally change the offset for any of the affected boards. Signed-off-by: Andrew Abbott --- arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi | 1 - arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 4 arch/arm/dts/rk3399-puma-haikou-u-boot.dt

[RFC PATCH 3/8] soc: rockchip: Include common U-Boot dtsi file

2022-04-24 Thread Andrew Abbott
This pulls in binman definitions so images can be built for all Rockchip platforms. Signed-off-by: Andrew Abbott --- arch/arm/dts/rk3308-u-boot.dtsi | 2 ++ arch/arm/dts/rk3328-u-boot.dtsi | 2 ++ arch/arm/dts/rk3368-u-boot.dtsi | 1 + arch/arm/dts/rk3568-u-boot.dtsi | 2 ++ 4 files changed, 7

[RFC PATCH 2/8] rockchip: Add binman definitions for final images

2022-04-24 Thread Andrew Abbott
. Signed-off-by: Andrew Abbott --- Question: Does this break/not play nicely with rockchip-optee generation? It creates u-boot.itb for rk3288 targets. That would need to run before what I've implemented here? --- arch/arm/dts/rockchip-u-boot.dtsi | 59 +++ arch/arm

[RFC PATCH 1/8] binman: mkimage: Support ':'-separated inputs

2022-04-24 Thread Andrew Abbott
ned-off-by: Andrew Abbott --- This is a bit of a messy implementation for now and would probably break existing uses of mkimage that rely on the concatenation behaviour. Questions: - Should this be a separate entry type, or an option to the mkimage entry type that enables this behaviour? - What ki

[RFC PATCH 0/8] Build Rockchip final images using binman

2022-04-24 Thread Andrew Abbott
s: - I noticed that ATF generation for ARM64 Rockchip is done via a Python script instead of binman. I don't currently know how to change that over to binman, but is that something worth pursuing as part of this? Please give me your feedback! Andrew Abbott (8): binman: mkimage: S

[PATCH] fdt: Fix TPL SEPARATE_BSS check when locating DTB

2022-04-16 Thread Andrew Abbott
ned, but because of the above, only TPL options are considered. Since there is no CONFIG_TPL_SEPARATE_BSS, this fails. Fixes: 690af71850 ("fdt: Correct condition for SEPARATE_BSS") Signed-off-by: Andrew Abbott --- The serial output from a ROCKPro64 booting master (9859465bfe) is: