This patchset adds an i2c bus based TPM driver.
Che-Liang Chiou (3):
tpm: Rename generic_lpc_tpm to tpm_tis_lpc
tpm: Add i2c TPM driver
tpm: Update README
Makefile |2 +-
README | 18 +-
drivers/tpm
The new name is more aligned with Linux kernel's naming of TPM driver.
Signed-off-by: Che-Liang Chiou
---
Makefile |2 +-
README |5 -
drivers/tpm/Makefile |
Document TPM_TIS_I2C-related config options in README.
Signed-off-by: Che-Liang Chiou
---
README | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/README b/README
index 434384c..badb834 100644
--- a/README
+++ b/README
@@ -1076,6 +1076,19 @@ The following
Peter Huewe implemented the original driver; this patch only reorganizes
the code structure of the driver, and does not make logical changes.
tpm.c implements the interface defined in tpm.h based on underlying
LPC or i2C TPM driver. tpm.c and the underlying driver communicate
throught tpm_private
This patchset adds an i2c bus based TPM driver.
Changes in v1:
- Update s-o-b Peter Huewe's email address
- Squash patch #3 into patch #2
Che-Liang Chiou (2):
tpm: Rename generic_lpc_tpm to tpm_tis_lpc
tpm: Add i2c TPM driver
Makefile |
The new name is more aligned with Linux kernel's naming of TPM driver.
Signed-off-by: Peter Huewe
Signed-off-by: Che-Liang Chiou
Acked-by: Mike Frysinger
---
Changes in v1:
- Update s-o-b Peter Huewe's email address
Makefile |2
tpm_private.h.
This patch is tested on a tegra2-based machine, where the i2c driver is
not upstreamed yet.
Note: Merging the LPC driver with tpm.c is left to future patches.
Signed-off-by: Peter Huewe
Signed-off-by: Che-Liang Chiou
---
Changes in v1:
- Squash patch #3 into patch #2
README
This patchset adds an i2c bus based TPM driver.
Changes in v1:
- Update s-o-b Peter Huewe's email address
- Squash patch #3 into patch #2
Changes in v2:
- Style improvements
Che-Liang Chiou (2):
tpm: Rename generic_lpc_tpm to tpm_tis_lpc
tpm: Add i2c TPM driver
Mak
The new name is more aligned with Linux kernel's naming of TPM driver.
Signed-off-by: Peter Huewe
Signed-off-by: Che-Liang Chiou
Acked-by: Mike Frysinger
---
Changes in v1:
- Update s-o-b Peter Huewe's email address
Makefile |2
tpm_private.h.
This patch is tested on a tegra2-based machine, where the i2c driver is
not upstreamed yet.
Note: Merging the LPC driver with tpm.c is left to future patches.
Signed-off-by: Peter Huewe
Signed-off-by: Che-Liang Chiou
---
Changes in v1:
- Squash patch #3 into patch #2
Changes in v2
On Sat, Dec 17, 2011 at 1:21 AM, Mike Frysinger wrote:
> On Wednesday 14 December 2011 03:48:24 Che-Liang Chiou wrote:
>> --- /dev/null
>> +++ b/drivers/tpm/tpm.c
>>
>> +int tis_sendrecv(const uint8_t *sendbuf, size_t send_size, uint8_t
>> *recv
On Sun, Dec 18, 2011 at 4:33 AM, Wolfgang Denk wrote:
> Dear Che-Liang Chiou,
>
> In message <1323852504-19954-3-git-send-email-clch...@chromium.org> you wrote:
>> Peter Huewe implemented the original driver; this patch only reorganizes
>> the code structure of th
On Sun, Dec 18, 2011 at 4:35 AM, Wolfgang Denk wrote:
> Dear Che-Liang Chiou,
>
> In message <1323852504-19954-2-git-send-email-clch...@chromium.org> you wrote:
>> The new name is more aligned with Linux kernel's naming of TPM driver.
>>
>> Signed-off-by: Pe
On Mon, Dec 19, 2011 at 7:38 PM, Wolfgang Denk wrote:
> Dear Che-liang Chiou,
>
> In message
> you
> wrote:
>>
>> > Should we not rather remove all this dead code again?
>> >
>> > Until today there are no users for this code in mainline, and no
On Tue, Dec 20, 2011 at 7:43 PM, Wolfgang Denk wrote:
> Dear Che-liang Chiou,
>
> In message
> you
> wrote:
>>
>> The board that I test the TPM driver is Seaboard (a tegra2-based
>> board). The config settings enabling TPM are literally pasted as
>> foll
adds explicit mkdir's to the Makefiles in question, and
verifies that out-of-tree build is working.
Signed-off-by: Che-Liang Chiou
Cc: Albert Aribaud
---
board/nvidia/harmony/Makefile |4
board/nvidia/seaboard/Makefile |4
2 files changed, 8 insertions(+), 0 dele
Hi Anton,
Thanks for comments. Replied below.
Regards,
Che-Liang
On Wed, Aug 24, 2011 at 1:01 AM, Anton Staaf wrote:
> On Tue, Aug 23, 2011 at 3:03 AM, Che-Liang Chiou wrote:
>> The out-of-tree build fails because the Makefiles in question depend on
>> source files of another d
Hi Simon,
I have a dumb question: How did you make u-boot run native under
Linux? Did you mock out all platform functions? Or did you bundle
u-boot with a emulator?
Regards,
Che-Liang
On Wed, Aug 24, 2011 at 6:16 AM, Mike Frysinger wrote:
> On Tuesday, August 23, 2011 18:01:34 Simon Glass wrote
)
{
uint64_t a, b, q, r;
while (scanf("%llx %llx %llx %llx", &a, &b, &q, &r) > 0)
printf("%016llx %016llx %016llx %016llx\n", a, b, a / b, a % b);
return 0;
}
Signed-off-by: Che-Liang Chiou
Cc: Albert Aribaud
---
This patch is alos tested with `
on our decisions, I will rewrite (or abandon) this patch accordingly.
Regards,
Che-Liang
On Thu, Sep 1, 2011 at 4:03 AM, Wolfgang Denk wrote:
> Dear Che-Liang Chiou,
>
> In message <1314787130-1043-1-git-send-email-clch...@chromium.org> you wrote:
>> This patch adds a 64-64
Hi Marek,
I will abandon this patch and submit a new patch that is adapted from
do_div() and lib64.c of the Linux kernel. Does this sound okay to you?
Regards,
Che-Liang
On Thu, Sep 1, 2011 at 6:16 PM, Marek Vasut wrote:
> On Thursday, September 01, 2011 12:09:18 PM Che-liang Chiou wr
Hi Marek,
do_div() and lib/div64.c of linux kernel has been ported to U-Boot
since Oct, 2006 (this date is the earliest record that I can find; see
commit 7b64fef3).
Regards,
Che-Liang
On Thu, Sep 1, 2011 at 6:42 PM, Marek Vasut wrote:
> On Thursday, September 01, 2011 12:30:47 PM Che-li
Dear Wolfgang,
I am convinced that a 64-64 bit divider (this patch) is not needed. Is
there any way that we could mark a patch "abandon"?
Regards,
Che-Liang
On Thu, Sep 1, 2011 at 9:07 PM, Wolfgang Denk wrote:
> Dear Che-liang Chiou,
>
> In message
> you
> wrot
Dear Wolfgang Denk,
I checked out the master of the git repo of that time (Feb 22?).
Regards,
Che-Liang
On Thu, Apr 14, 2011 at 4:45 AM, Wolfgang Denk wrote:
> Dear Che-liang Chiou,
>
> In message you
> wrote:
>>
>> On Tue, Feb 22, 2011 at 3:33 PM, Wolfgang Denk
Thanks, Wolfgang.
On Fri, May 13, 2011 at 4:30 AM, Wolfgang Denk wrote:
> Dear Che-liang Chiou,
>
> In message you
> wrote:
>> GNU Makefile have two flavors of variables, recursively expanded that is
>> defined by using '=', and simply expanded that is defin
Hi,
On Mon, Oct 31, 2011 at 2:33 AM, Anatolij Gustschin wrote:
> Please next time additionally use '-C' Option for 'git format-patch ...'
Thanks for the advice. I will add -C option.
Regards,
Che-Liang
___
U-Boot mailing list
U-Boot@lists.denx.de
http:
On Mon, Mar 19, 2012 at 5:00 AM, Wolfgang Denk wrote:
> Dear Che-Liang Chiou,
>
> In message <20111219112511.1eddc135a...@gemini.denx.de> I wrote:
>>
>> In message <1324288224-5075-1-git-send-email-clch...@chromium.org> you wrote:
>> >
>>
CONFIG_NET_MULTI
Signed-off-by: Che-Liang Chiou
---
Makefile | 16 ++--
examples/api/Makefile |4 +---
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/Makefile b/Makefile
index dfe939f..550088f 100644
--- a/Makefile
+++ b/Makefile
@@ -137,9 +137,11
This patch set exports LCD and video clearing and bitmap-rendering on
screen functions to external apps, and provides a unified interface
of accessing them.
Che-Liang Chiou (2):
lcd: video: add clear and draw bitmap declaration
api: export LCD and video to external apps
api/Makefile
The functions for clearing and drawing bitmaps on the screen were not
exposed publicly and are made public in this patch in preparation for
implementing the display interface of api_public.h.
Signed-off-by: Che-Liang Chiou
---
common/lcd.c| 15 +--
include/lcd.h |2
.
Signed-off-by: Che-Liang Chiou
---
api/Makefile |3 +-
api/api.c| 51 ++
api/api_display.c| 85 ++
api/api_private.h|4 ++
examples/api/demo.c | 28
examples
The 'time' command runs and reports execution time of commands.
Sameple usage:
u-boot# time crc 0x1000 1000
CRC32 for 1000 ... 1fff ==> ae94dc4b
time: 0.004 seconds, 4 ticks
Signed-off-by: Che-Liang Chiou
---
README
The 'time' command runs and reports execution time of commands.
Sample usage:
u-boot# time crc 0x1000 1000
CRC32 for 1000 ... 1fff ==> ae94dc4b
time: 0.004 seconds, 4 ticks
Signed-off-by: Che-Liang Chiou
---
Changes Since V1
- Sw
Hi Mike,
Thanks for comments. Reply inlined.
On Thu, Oct 6, 2011 at 1:24 AM, Mike Frysinger wrote:
> On Wednesday 05 October 2011 03:09:15 Che-Liang Chiou wrote:
>> The 'time' command runs and reports execution time of commands.
>
> cool
>
>> Sameple usage:
&g
This patch set exports LCD and video clearing and bitmap-rendering on
screen functions to external apps, and provides a unified interface
of accessing them.
Che-Liang Chiou (2):
lcd: video: add clear and draw bitmap declaration
api: export LCD and video to external apps
api/Makefile
The functions for clearing and drawing bitmaps on the screen were not
exposed publicly and are made public in this patch in preparation for
implementing the display interface of api_public.h.
Signed-off-by: Che-Liang Chiou
---
Changes since V1
Fix style errors
common/lcd.c| 16
.
Signed-off-by: Che-Liang Chiou
---
Changes since V1
Fix style errors
api/Makefile |3 +-
api/api.c| 51 +
api/api_display.c| 86 ++
api/api_private.h|4 ++
examples/api/demo.c
Dear Wolfgang Denk,
On Fri, Oct 7, 2011 at 2:33 AM, Wolfgang Denk wrote:
> Dear Che-Liang Chiou,
>
> In message
>
> you wrote:
>> This patch exports LCD and video information and bitmap-rendering
>> functions to external apps.
>>
>> This patch is test
The 'time' command runs and reports execution time of commands.
Sample usage:
u-boot# time crc 0x1000 1000
CRC32 for 1000 ... 1fff ==> ae94dc4b
time: 0.004 seconds, 4 ticks
Signed-off-by: Che-Liang Chiou
---
Changes since
, 2011 at 5:05 PM, Wolfgang Denk wrote:
> Dear Che-liang Chiou,
>
> In message
> you
> wrote:
>>
>> >> + ub_display_clear();
>> >
>> > What happens here if no display is available?
>>
>> It is equivalent to a no-op. Or do
Hi Anatolij,
Thanks for testing this patch. Please see below.
On Tue, Oct 18, 2011 at 5:13 AM, Anatolij Gustschin wrote:
> Hi,
>
> thanks for the patch and style fixes! I've some comments on it.
> Please see below.
>
> On Fri, 7 Oct 2011 16:28:12 +0800
> Che-Liang Chi
CONFIG_NET_MULTI
Signed-off-by: Che-Liang Chiou
Acked-by: Mike Frysinger
---
Changes in V2
Rebase to ToT
Makefile | 18 +-
examples/api/Makefile |4 +---
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/Makefile b/Makefile
index e9d75f8..26956ae
CONFIG_NET_MULTI
Signed-off-by: Che-Liang Chiou
Acked-by: Mike Frysinger
---
Sorry, please ignore the previous V2 patch. I missed to git-add a
couple of lines to that patch.
Changes in V2
Rebase to ToT
Makefile | 22 +-
examples/api/Makefile |4 +---
2 files
Hi Anatolij,
On Tue, Oct 18, 2011 at 3:17 PM, Anatolij Gustschin wrote:
> Hi,
>
> On Tue, 18 Oct 2011 14:12:59 +0800
> Che-liang Chiou wrote:
> ...
>> > Many boards defining CONFIG_LCD also define CONFIG_LCD_LOGO.
>> > Enabling CONFIG_API for such board configu
This patch set exports LCD and video clearing and bitmap-rendering on
screen functions to external apps, and provides a unified interface
of accessing them.
Che-Liang Chiou (4):
lcd: video: add clear and draw bitmap declaration
tools: logo: add static and unused to bmp arrays
video: add
The functions for clearing and drawing bitmaps on the screen were not
exposed publicly and are made public in this patch in preparation for
implementing the display interface of api_public.h.
Signed-off-by: Che-Liang Chiou
---
Changes in V3
Rebase to ToT
Changes in V2
Fix style errors
__attribute__((unused))
to the array definitions so that bmp_logo.h can be included multiple
times, and these arrays is used in only one inclusion (lcd.c).
Signed-off-by: Che-Liang Chiou
---
Changes in V3
Add to the patch set
tools/bmp_logo.c |6 --
1 files changed, 4 insertions(+), 2
x27;s responsibility to make sure that the video device is properly
initialized.
Signed-off-by: Che-Liang Chiou
---
Changes in V3
Add to the patch set
board/eltec/mhpc/mhpc.c |7 +++
drivers/video/ati_radeon_fb.c |5 +
drivers/video/ct69000.c |5 +
drivers/video/fsl_diu
.
Signed-off-by: Che-Liang Chiou
---
Changes in V3
Rebase to ToT
Changes in V2
Fix style errors
api/Makefile |3 +-
api/api.c| 51 ++
api/api_display.c| 97 ++
api/api_private.h
This patch set exports LCD clearing and bitmap-rendering on screen functions
to external apps, and provides a unified interface of accessing them.
Che-Liang Chiou (3):
lcd: add clear and draw bitmap declaration
tools: logo: add static and unused to bmp arrays
api: export LCD device to
The functions for clearing and drawing bitmaps on the screen were not
exposed publicly and are made public in this patch in preparation for
implementing the display interface of api_public.h.
Signed-off-by: Che-Liang Chiou
---
Changes in V4
Remove support of video device, which is untested
__attribute__((unused))
to the array definitions so that bmp_logo.h can be included multiple
times, and these arrays is used in only one inclusion (lcd.c).
Signed-off-by: Che-Liang Chiou
---
Changes in V4
None
Changes in V3
Add to the patch set
tools/bmp_logo.c |6 --
1 files changed
This patch exports LCD info-query and bitmap-rendering functions to
external apps.
This patch is tested on a Seaboard. Because the LCD driver is not yet
upstreamed, the test was done in a local downstream repo.
Signed-off-by: Che-Liang Chiou
---
Changes in V4
Remove support of video device
38 +0800
> Che-Liang Chiou wrote:
> ...
>> +int display_get_info(int type, struct display_info *di)
>> +{
>> +#if defined(CONFIG_VIDEO) || defined(CONFIG_CFB_CONSOLE)
>> + GraphicDevice *gdev;
>> +#endif
>> +
>> + switch (type) {
>> +
struct device_info in api_public.h defined its own subset of attributes
of block_dev_desc, which limits the capability of external apps.
This patch set let external apps access the same set of block device
attributes as U-Boot.
Che-Liang Chiou (2):
Flatten and solidify block_dev_desc layout
block_dev_desc layout would be
an invariant with respect to configurations.
Doing so would waste a few extra bytes per struct block_dev_desc, which
I believe is not critical.
Signed-off-by: Che-Liang Chiou
---
disk/part_dos.c |2 +-
disk/part_efi.c |4 +---
drivers/mmc/mmc.c |4
compared to U-Boot.
The export.h and _export.h have somewhat addressed the same issue. That
is, sharing declarations between U-Boot and external apps.
Signed-off-by: Che-Liang Chiou
---
api/api_storage.c| 17 +++--
examples/api/demo.c | 15 +--
include
block_dev_desc layout would be
an invariant with respect to configurations.
Doing so would waste a few extra bytes per struct block_dev_desc, which
I believe is not critical.
Signed-off-by: Che-Liang Chiou
---
Fix a minor checkpatch violation.
disk/part_dos.c |2 +-
disk/part_efi.c |4
This patch set exports LCD clearing and bitmap-rendering on screen functions
to external apps, and provides a unified interface of accessing them.
Che-Liang Chiou (4):
lcd: add clear and draw bitmap declaration
tools: logo: split bmp arrays from bmp_logo.h
font: split font data from
arrays in another header
bmp_logo_data.h and in bmp_logo.h only declaring these arrays.
Signed-off-by: Che-Liang Chiou
---
Changes in V5
Split bmp arrays from bmp_logo.h to bmp_logo_data.h
Changes in V4
None
Changes in V3
Add to the patch set
Makefile|1 +
common
The functions for clearing and drawing bitmaps on the screen were not
exposed publicly and are made public in this patch in preparation for
implementing the display interface of api_public.h.
Signed-off-by: Che-Liang Chiou
---
Changes in V5
Remove inline extern declaration from cmd_bmp.c
This patch exports LCD info-query and bitmap-rendering functions to
external apps.
This patch is tested on a Seaboard. Because the LCD driver is not yet
upstreamed, the test was done in a local downstream repo.
Signed-off-by: Che-Liang Chiou
---
Changes in V5
Clean up logic
Changes in V4
The functions for clearing and drawing bitmaps on the screen were not
exposed publicly and are made public in this patch in preparation for
implementing the display interface of api_public.h.
Signed-off-by: Che-Liang Chiou
---
Changes in V5
Remove inline extern declaration from cmd_bmp.c
Dear Wolfgang Denk,
I guess I have to put this patchset on hold. I will get you back if we
could proceed with this patchset.
Regards,
Che-Liang
On Sat, Oct 22, 2011 at 3:09 AM, Wolfgang Denk wrote:
> Dear Che-Liang Chiou,
>
> In message <1319178708-10881-2-git-send-email-clch...@
Hi Detlev,
Oops, I did not know it is intentionally to keep the external apps API
as it is now.
I am working on an open source secure bootloader based on U-Boot.
Mostly I wrote boot logic (by boot logic I mean prompting user and
listing available devices sort of things). If you see U-Boot as a
pl
Hi Simon,
I notice one thing that I am curious about. At v2016.11, in
lib/rsa/rsa-verify.c:rsa_verify function:
* The sig_node offset is computed from fdt_blob (at line 180):
sig_node = fdt_subnode_offset(blob, 0, FIT_SIG_NODENAME);
* At the end of the rsa_verify function, sig_node is applied to
_define d 0x1001 0x1
$ tpmutil nv_write d 0x1001 0
And then increment the counter by one:
$ tpmutil nv_read d 0x1001 i
$ setexpr.l i $i + 1
$ tpmutil nv_write d 0x1001 $i
Signed-off-by: Che-Liang Chiou
---
common/cmd_tpm.c | 732 +++---
include/{tpm.
e d 0x1001 0x1
$ tpm nv_write d 0x1001 0
And then increment the counter by one:
$ tpm nv_read d 0x1001 i
$ setexpr.l i $i + 1
$ tpm nv_write d 0x1001 $i
Signed-off-by: Che-Liang Chiou
---
common/cmd_tpm.c | 709 +++
include/{tpm.h => tis.h}
e d 0x1001 0x1
$ tpm nv_write d 0x1001 0
And then increment the counter by one:
$ tpm nv_read d 0x1001 i
$ setexpr.l i $i + 1
$ tpm nv_write d 0x1001 $i
Signed-off-by: Che-Liang Chiou
---
Changes in v3:
- Add check of TPM response code
Changes in v2:
- Merge tpm_util into tpm
common/cmd
t; to use
> a well known UMA which seems to be too stupid to keep lines of text
> without additional
> word wraps...)
>
>> -Original Message-
>> From: u-boot-boun...@lists.denx.de
>> [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Che-Liang Chiou
>
Acked-by: Che-Liang Chiou
On Wed, Jun 12, 2013 at 1:08 AM, wrote:
> From: Reinhard Pfau
>
> Extend the tpm library with support for single authorized (AUTH1) commands
> as specified in the TCG Main Specification 1.2. (The internally used helper
> functions are implemented in
Acked-by: Che-Liang Chiou
On Mon, Apr 22, 2013 at 4:06 AM, Dirk Eibach wrote:
> From: Reinhard Pfau
>
> Extend the tpm library with support for single authorized (AUTH1) commands
> as specified in the TCG Main Specification 1.2. (The internally used helper
> functions are imple
Acked-by: Che-Liang Chiou
On Fri, Sep 28, 2012 at 6:11 PM, Simon Glass wrote:
> From: Tom Wai-Hong Tam
>
> Add support for drawing compressed RLE8 bitmaps.
>
> Reference: http://www.digicamsoft.com/bmp/bmp.html
>
> Signed-off-by: Che-Liang Chiou
> Signed-off-by: Tom Wa
Acked-by: Che-Liang Chiou
On Mon, Dec 3, 2012 at 8:23 AM, Richard Genoud wrote:
> 2012/12/3 Stefan Roese :
>>> @@ -543,7 +543,9 @@ enum command_ret_t cmd_process(int flag, int argc, char
>>> * const argv[],
>>>
>>> /* If OK so far, t
Acked-By: Che-Liang Chiou
On Mon, Dec 3, 2012 at 8:28 AM, Richard Genoud wrote:
> As far as every arch has a get_timer function,
> run_command_and_time_it code can now disappear.
>
> Signed-off-by: Richard Genoud
> ---
> common/cmd_time.c | 33 ++---
Acked-by: Che-Liang Chiou
On Sat, Jan 12, 2013 at 2:07 PM, Jeroen Hofstee wrote:
> cc: Che-Liang Chiou
> Signed-off-by: Jeroen Hofstee
> ---
> api/api_display.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/api/api_display.c b/api/
I work for Google and my patches signed by clch...@chromium.org come
from me while I work for Google.
On Sat, Jan 12, 2013 at 9:20 AM, Simon Glass wrote:
> Hi,
>
> You are being copied because you have written U-Boot code which is now
> in mainline.
>
> The chromium.org domain does not automatica
GNU Makefile have two flavors of variables, recursively expanded that is
defined by using '=', and simply expanded that is defined by using ':='.
The bug is caused by using recursively expanded flavor for BIN and SREC.
As you can see below, they are prepended by $(obj) twice.
We can reproduce thi
Dear Wolfgang Denk,
On Tue, Feb 22, 2011 at 3:33 PM, Wolfgang Denk wrote:
> In message you
> wrote:
>> The bug is caused by using recursively expanded flavor for BIN and SREC.
> You wrote "The bug". How does this bug manifest in U-Boot? For which
> configuration do you see issues?
The bug I
79 matches
Mail list logo
