Re: [PATCH 2/2] net: phy: mv88e6352: Fix miiphy_read/miiphy_write return value checks

On 15.02.22 08:08, Ramon Fried wrote: > On Mon, Feb 14, 2022 at 12:33 PM Daniel Klauer wrote: >> >> On 12.02.22 12:50, Ramon Fried wrote: >> > On Wed, Feb 9, 2022 at 5:41 PM Daniel Klauer wrote: >> >> >> >> The miiphy_read/miiphy_write functions r

Re: [PATCH 2/2] net: phy: mv88e6352: Fix miiphy_read/miiphy_write return value checks

On 12.02.22 12:50, Ramon Fried wrote: > On Wed, Feb 9, 2022 at 5:41 PM Daniel Klauer wrote: >> >> The miiphy_read/miiphy_write functions return 1 on error, not -errno. > Why don't you just fix the miiphy_read/miiphy_write functions ? Other functions from that module do

[PATCH 2/2] net: phy: mv88e6352: Fix miiphy_read/miiphy_write return value checks

The miiphy_read/miiphy_write functions return 1 on error, not -errno. Fix up the checks accordingly and insert -EIO as fallback error code. Signed-off-by: Daniel Klauer --- drivers/net/phy/mv88e6352.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git

[PATCH 1/2] miiphyutil: Fix inconsistent miiphy_write() error return value

match miiphy_read(), which also converts bus->read() failure to "return 1". Signed-off-by: Daniel Klauer --- common/miiphyutil.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/common/miiphyutil.c b/common/miiphyutil.c index 7d4d15ed91..86a27665e3

[PATCH] lx2160a: Fix distroboot device list for configs without USB/SCSI/etc

disabling USB, SCSI, etc. in custom lx2160a board configs, make it depend on the config settings and use only the enabled features. Signed-off-by: Daniel Klauer --- include/configs/lx2160a_common.h | 34 +++- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a