Re: [U-Boot] [PATCH v2] mkenvimage: Fix compiler warning

’ expects type ‘long int’, but argument 3 has type ‘unsigned int’ I don't have these warnings ... I guess it is because we don't have the same compiler ? Thank you, I didn't know the %zu format :) Acked-by: David Wagner deubeul...@gmail.com Cheers, David

Re: [U-Boot] [PATCHv5 1/7] mkenvimage: correct and clarify comments and error messages

On 27/03/2012 10:32, Anatolij Gustschin wrote: [...] I'll queue them in my staging branch. Thanks, Anatolij Thanks a lot ! David. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCHv5 1/7] mkenvimage: correct and clarify comments and error messages

On 15/01/2012 02:22, Mike Frysinger wrote: Acked-by: Mike Frysingervap...@gentoo.org -mike Dear Wolfgang, I think Mike has acked all the 7 patches in v5. Thanks a lot if you can apply them. Regards, David Wagner. ___ U-Boot mailing list U-Boot

Re: [U-Boot] [PATCH 0/9] mkenvimage: v10/v11 diff split into several patches

Le 13/01/2012 21:07, Wolfgang Denk a écrit : Sorry, but this patch series has become a mess; we have the original 1-9 series, then a v2 1-10, then v3 1-8, and even a v4 1-8, with htese later series all being sparse ones. Sonce the number of patches changed several times, it's totally unclear to

[U-Boot] [PATCHv5 1/7] mkenvimage: correct and clarify comments and error messages

Also, don't split error messages over several lines as per a coding style exception making them easier to grep. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 41 +++-- 1 files changed, 15 insertions(+), 26 deletions

[U-Boot] [PATCHv5 2/7] mkenvimage: Correct an include and add a missing one

compiler.h needs to be included from U-Boot's headers. Also, group U-Boot-specific includes together stdlib.h was missing. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tools

[U-Boot] [PATCHv5 4/7] mkenvimage: Read/Write from/to stdin/out by default or if the filename is -

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index cc1deec..a5676be 100644 --- a/tools/mkenvimage.c +++ b/tools

[U-Boot] [PATCHv5 5/7] mkenvimage: Use mmap() when reading from a regular file

Fall back to read() if it fails. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index a5676be..8ce1be6 100644 --- a/tools

[U-Boot] [PATCHv5 6/7] mkenvimage: Don't try to detect comments in the input file

Remove this feature since it seems impossible to reliably detect them. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index 8ce1be6..ddd4515

[U-Boot] [PATCHv5 7/7] mkenvimage: Really set the redundant byte when applicable

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index ddd4515..e148f89 100644 --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c @@ -285,7 +285,9

[U-Boot] [PATCHv5 3/7] mkenvimage: More error handling

Verbosly fail if the target environment size or the padding byte are badly formated. Verbosly fail if something bad happens when reading from standard input. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 31 +-- 1 files

Re: [U-Boot] [PATCHv3 5/8] mkenvimage: Read/Write from/to stdin/out by default or if the filename is -

Le 08/01/2012 07:50, Mike Frysinger a écrit : On Thursday 05 January 2012 13:44:56 David Wagner wrote: + bin_fd = creat(bin_filename, S_IRUSR | S_IWUSR | S_IRGRP | +S_IWGRP); this should prob be open() -mike What is wrong with creat

[U-Boot] [PATCHv4 3/8] mkenvimage: Correct an include and add a missing one

compiler.h needs to be included from U-Boot's headers. Also, group U-Boot-specific includes together stdlib.h was missing. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tools

[U-Boot] [PATCHv3 6/8] mkenvimage: Use mmap() when reading from a regular file

Fall back to read() if it fails. Signed-off-by: David Wagner david.wag...@free-electrons.com --- I let an error message be printed when mmap fails, as the user may want to know why. tools/mkenvimage.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff

[U-Boot] [PATCHv3 4/8] mkenvimage: More error handling

Verbosly fail if the target environment size or the padding byte are badly formated. Verbosly fail if something bad happens when reading from standard input. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 30 -- 1 files changed

[U-Boot] [PATCHv4 4/8] mkenvimage: More error handling

Verbosly fail if the target environment size or the padding byte are badly formated. Verbosly fail if something bad happens when reading from standard input. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 31 +-- 1 files

[U-Boot] [PATCHv2 1/8] Strip mkenvimage

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/Makefile b/tools/Makefile index a5f989a..64bcc4d 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -194,6 +194,7 @@ $(obj)xway-swap-bytes

[U-Boot] [PATCHv3 3/8] mkenvimage: Correct the includes and add a missing one

compiler.h and u-boot/crc.h need to be included from U-Boot's headers. stdlib.h was missing. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c

[U-Boot] [PATCHv3 5/8] mkenvimage: Read/Write from/to stdin/out by default or if the filename is -

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index eb9a8f2..6db2b21 100644 --- a/tools/mkenvimage.c +++ b/tools

[U-Boot] [PATCHv2 4/8] mkenvimage: More error handling

Verbosly fail if the target environment size or the padding byte are badly formated. Verbosly fail if something bad happens when reading from standard input. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 32 ++-- 1 files

[U-Boot] [PATCHv3 2/8] mkenvimage: correct and clarify comments and error messages

Also, don't split error messages over several lines as per a coding style exception making them easier to grep. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 41 +++-- 1 files changed, 15 insertions(+), 26 deletions

[U-Boot] [PATCHv2 6/8] mkenvimage: Use mmap() when reading from a regular file

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index 6db2b21..58f1d0b 100644 --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c

[U-Boot] [PATCHv2 7/8] mkenvimage: Don't try to detect comments in the input file

Remove this feature since it seems impossible to reliably detect them. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index 58f1d0b..a3d4e27

[U-Boot] [PATCHv3 8/8] mkenvimage: Really set the redundant byte when applicable

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index a3d4e27..c1e6cad 100644 --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c @@ -276,7 +276,9

Re: [U-Boot] [PATCHv2 02/10] mkenvimage: correct and clarify comments and error messages

Le 21/12/2011 08:41, Thomas Petazzoni a écrit : Seems like your forgot to resolve some conflicts. A compile test would have detected those issues. Regards, Thomas Ow. right... However, I will first wait for Horst's patch 3/4 (print program basename instead of whole path in usage()) to be

[U-Boot] [PATCHv2 02/10] mkenvimage: correct and clarify comments and error messages

Also, don't split error messages over several lines as per a coding style exception making them easier to grep. Signed-off-by: David Wagner david.wag...@free-electrons.com --- This version is rebased on top of 'next' (it didn't apply anymore, after Horst Kronstorfer's patches). tools

[U-Boot] [PATCHv2 03/10] mkenvimage: Correct the includes and add a missing one

compiler.h and u-boot/crc.h need to be included from U-Boot's headers. stdlib.h was missing. Signed-off-by: David Wagner david.wag...@free-electrons.com --- This version is rebased on top of 'next' (it didn't apply anymore, after Horst Kronstorfer's patches). tools/mkenvimage.c | 15

[U-Boot] [PATCH 09/10] Correctly handle input files beginning with several newlines

Also, fix some comments (minor) Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index 9899631..0c9194b 100644 --- a/tools/mkenvimage.c

Re: [U-Boot] [PATCH 0/9] mkenvimage: v10/v11 diff split into several patches

Le 27/11/2011 20:59, Mike Frysinger a écrit : don't see anything wrong with the latest patchset now, thanks! -mike Hi, I re-sent 2 patches that didn't apply anymore on top of next (v2 2/10 and v2 3/10) ; the others should be fine. I also sent one more patch ([PATCH 09/10] Correctly handle

[U-Boot] [PATCHv2 5/8] mkenvimage: Read/Write from/to stdin/out by default or if the filename is -

Signed-off-by: David Wagner david.wag...@free-electrons.com --- This 2nd version is a meld of the 1st version and patch 9 tools/mkenvimage.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index b6e7f14

[U-Boot] [PATCHv2 8/8] mkenvimage: Really set the redundant byte when applicable

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index 221e9de..4e69056 100644 --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c @@ -257,7 +257,9

Re: [U-Boot] [PATCH 9/9] mkenvimage: Default to stdout if the output argument is absent or -

On 25/11/2011 22:36, Mike Frysinger wrote: squash this into the first stdin patch ? [PATCH 5/9] mkenvimage: Read from stdin if the filename is - -mike Done, you can ignore this patch. David. ___ U-Boot mailing list U-Boot@lists.denx.de

[U-Boot] [PATCH 7/9] mkenvimage: Don't try to detect comments in the input file

Remove this feature since it seems impossible to reliably detect them. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index 74b296e..8d84c85

[U-Boot] [PATCH 1/9] Strip mkenvimage

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/Makefile b/tools/Makefile index a5f989a..64bcc4d 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -194,6 +194,7 @@ $(obj)xway-swap-bytes

[U-Boot] [PATCH 8/9] mkenvimage: Really set the redundant byte when applicable

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index 8d84c85..fa6eb6e 100644 --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c @@ -257,7 +257,9

[U-Boot] [PATCH 5/9] mkenvimage: Read from stdin if the filename is -

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index b6e7f14..86a4e05 100644 --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c @@ -154,15

[U-Boot] [PATCH 6/9] mkenvimage: Use mmap() when reading from a regular file

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index 86a4e05..74b296e 100644 --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c

[U-Boot] [PATCH 2/9] mkenvimage: correct and clarify comments and error messages

Also, don't split error messages over several lines as per a coding style exception making them easier to grep. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 39 ++- 1 files changed, 14 insertions(+), 25 deletions

[U-Boot] [PATCH 9/9] mkenvimage: Default to stdout if the output argument is absent or -

Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index fa6eb6e..8ba63d2 100644 --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c

[U-Boot] [PATCH 4/9] mkenvimage: More error handling

Verbosly fail if the target environment size or the padding byte are badly formated. Verbosly fail if something bad happens when reading from standard input. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c | 32 ++-- 1 files

[U-Boot] [PATCH 3/9] mkenvimage: Correct the includes and add a missing one

compiler.h and u-boot/crc.h need to be included from U-Boot's headers. stdlib.h was missing. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/mkenvimage.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c

[U-Boot] [PATCH 0/9] mkenvimage: v10/v11 diff split into several patches

, David. David Wagner (9): Strip mkenvimage mkenvimage: correct and clarify comments and error messages mkenvimage: Correct the includes and add a missing one mkenvimage: More error handling mkenvimage: Read from stdin if the filename is - mkenvimage: Use mmap() when reading from

[U-Boot] [PATCHv10] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environment image, ready to be flashed. use case: flash the environment with an external tool Signed-off-by: David Wagner david.wag...@free-electrons.com Acked-by: Mike Frysinger vap

[U-Boot] [PATCHv9] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environment image, ready to be flashed. use case: flash the environment with an external tool Signed-off-by: David Wagner david.wag...@free-electrons.com Acked-by; Mike Frysinger vap

[U-Boot] [PATCHv8] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environment image, ready to be flashed. use case: flash the environment with an external tool Signed-off-by: David Wagner david.wag...@free-electrons.com Acked-by; Mike Frysinger vap

Re: [U-Boot] mkenvimage not working for me.

used as direct input into this utility. Regards Nick Thomas -- David Wagner, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ___ U-Boot mailing list U-Boot

[U-Boot] [PATCHv7] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environment image, ready to be flashed. use case: flash the environment with an external tool Signed-off-by: David Wagner david.wag...@free-electrons.com Acked-by; Mike Frysinger vap

[U-Boot] [PATCH] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environment image, ready to be flashed. use case: flash the environment with an external tool Signed-off-by: David Wagner david.wag...@free-electrons.com --- changes since v5

[U-Boot] [PATCHv6] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environment image, ready to be flashed. use case: flash the environment with an external tool Signed-off-by: David Wagner david.wag...@free-electrons.com --- changes since v5

Re: [U-Boot] [PATCH] new tool mkenvimage: generates an env image from an arbitrary config file

oops, subject is missing v6. I just resent a correct version. David ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCHv5] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environment image, ready to be flashed. use case: flash the environment with an external tool Signed-off-by: David Wagner david.wag...@free-electrons.com --- changes since v4

[U-Boot] [PATCHv4] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environment image, ready to be flashed. For now, it doesn't work properly if environment variables have embedded newlines. Signed-off-by: David Wagner david.wag...@free-electrons.com

[U-Boot] [PATCH] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environnment image, ready to be flashed. Signed-off-by: David Wagner david.wag...@free-electrons.com --- Hi Mike, This 3rd version should address what you pointed out. I had

Re: [U-Boot] [PATCHv2] new tool mkenvimage: generates an env image from an arbitrary config file

Hi, On 08/06/2011 01:18 PM, Mike Frysinger wrote: On Fri, Aug 5, 2011 at 09:23, David Wagner wrote: +#include endian.h this is not portable. include compiler.h and use the already existing uswap/cpu_to/to_cpu/etc... helpers. +static void usage(void) +{ + printf(envcrc [-h

Re: [U-Boot] [PATCHv2] new tool mkenvimage: generates an env image from an arbitrary config file

On 08/08/2011 10:46 AM, Albert ARIBAUD wrote: Hi David, Le 08/08/2011 10:16, David Wagner a écrit : +static void usage(void) +{ + printf(envcrc [-h] [-r] [-b] -senvrionnment partition size -ooutput funny, envcrc isnt what the filename actually is ... ah, yes, it began

[U-Boot] [PATCH] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environnment image, ready to be flashed. Signed-off-by: David Wagner david.wag...@free-electrons.com --- tools/Makefile |5 ++ tools/mkenvimage.c | 157

[U-Boot] [PATCHv2] new tool mkenvimage: generates an env image from an arbitrary config file

This tool takes a key=value configuration file (same as would a `printenv' show) and generates the corresponding environnment image, ready to be flashed. Signed-off-by: David Wagner david.wag...@free-electrons.com --- Hi Thomas, This second version addresses all your comments except